RFR(S): 7123386: RFE: Preserve universal builds of HotSpot on Mac OS X

[Daniel D. Daugherty]

On 1/31/12 1:28 PM, James Melvin wrote:
> Hi,
>
> Please review the change to HotSpot to package JVM libraries in a
> universal binary on Mac OS X. The current plan of record is to only
> support a 64-bit JVM on Mac OS X. This solution preserves the option to
> additionally include other architectures in the universal binary
> in the future. It also further encapsulates platform specific makefile
> changes for Mac OS X builds.
>
> Feedback welcome...
>
> WEBREV:
>   http://cr.openjdk.java.net/~jmelvin/7123386/webrev.00

Thumbs up!

Please update copyright years to 2012.

make/Makefile
     No comments.

make/bsd/makefiles/defs.make
     nit: line 174: 'settins -> 'settings'

     line 192, 196, 197 - those '.txt' files aren't binaries... :-)

     line 198: Is there a reason not to have the Client VM on the
         "LIPO" list? We may not support a 64-bit Client VM, but
         that doesn't mean someone in the OpenJDK world wouldn't
         want/like/support one...

make/defs.make
     No comments.

make/bsd/makefiles/universal.gmk
     line 79: '-xfp' instead of '-xf'? Preserves timestamps...