[PATCH] Linux implementation for set_native_thread_name()

Roman Kennke rkennke at redhat.com
Tue Jul 24 14:10:58 PDT 2012


> I think it looks fine.

Great! I posted an updated webrev for this (replaced snprint with
jio_snprintf):

http://cr.openjdk.java.net/~rkennke/linux_threadname/webrev.01/

> Do you have a bug number for this?

No. (I don't have access to bugster anymore).

>   Also, how do we verify the result?

I verified it using htop and by inspecting /proc/$PID/task/$TID/stat.
Unfortuntately, I couldn't get top or ps to show the thread name, but
maybe I'm just stupid (and I did not try very hard).

Also: which of the many repositories do I need to push this to?

Regards,
Roman

> --
> - Keith
> 
> On 7/24/2012 3:42 PM, Roman Kennke wrote:
> > Hello,
> >
> > The following patch implements set_native_thread_name() for Linux, which
> > was so far unimplemented. The name needs to be truncated to 15 chars,
> > otherwise it would not be accepted by pthread_setname_np() at all.
> >
> > http://cr.openjdk.java.net/~rkennke/linux_threadname/webrev.00/
> >
> > This is my first patch to hotspot ever, so please let me know when I did
> > anything fundamental wrong. I have another patch in the pipeline for
> > implementing the other 2 missing methods in the same source file
> > (distribute_processes() and bind_to_processor() ).
> >
> > What do you think?
> >
> > Kind regards, Roman
> >
> >




More information about the hotspot-dev mailing list