review request (XS) - 7150454: add release jdk7u4 to jprt.properties
Kelly O'Hair
kelly.ohair at oracle.com
Fri Mar 2 13:32:36 PST 2012
On Mar 2, 2012, at 1:23 PM, Tom Rodriguez wrote:
>
> On Mar 2, 2012, at 1:12 PM, Kelly O'Hair wrote:
>
>>
>> I thought that was the default.
>
> misread your email describing the new behaviour. The previous behaviour was that no syncs were being performed at all and I assumed that was the default in the new setup. So by default it will sync at all three points but it's respecting the jprt.sync.push=false flag, so hotspot gets sync start and sync submit?
Yes. That's what I would expect. Of course I could have screwed it up, I have't done extensive testing on this.
-kto
>
> tom
>
>>
>> -kto
>>
>> On Mar 2, 2012, at 12:59 PM, Tom Rodriguez wrote:
>>
>>> Looks good.
>>>
>>> Has there been any discussion of adding jprt.sync.start=true to the jprt.properties file? It would be nice to start allowing trivial merges again.
>>>
>>> tom
>>>
>>> On Mar 2, 2012, at 10:33 AM, John Coomes wrote:
>>>
>>>> Hi,
>>>>
>>>> I'd appreciate reviews of a small change to allow jprt to build
>>>> hotspot with '-release jdk7u4'.
>>>>
>>>> http://cr.openjdk.java.net/~jcoomes/7150454-jprt-jdk7u4/
>>>>
>>>> Tested with 'jprt submit -release jdk7u4'.
>>>>
>>>> -John
>>>
>>
>
More information about the hotspot-dev
mailing list