Request for reviews (M): 6924259: Remove String.count, String.offset fields

Vitaly Davidovich vitalyd at gmail.com
Thu May 10 14:22:30 PDT 2012


Hi Vladimir,

In graphKit.cpp, should the code in load_String_length() check
has_count_field() instead of has_offset_field()? I guess this works because
they're all removed together but javaClasses.hpp does define
has_count_field() and load_String_length proceeds to read the count offset.

Regards,
Vitaly

Sent from my phone
On May 10, 2012 2:15 PM, "Vladimir Kozlov" <vladimir.kozlov at oracle.com>
wrote:

> http://cr.openjdk.java.net/~**kvn/6924259/webrev<http://cr.openjdk.java.net/~kvn/6924259/webrev>
>
> 6924259: Remove String.count/String.offset
>
> Allows a version of the String class that doesn't have count,offset fields.
> These VM changes works with both versions of String class by checking the
> presence of fields.
>
> Initial changes were done by Brian and Tom years ago. I addapted it for
> current sources and tested it.
>
> Tested with NSK, regression tests, CTW, refworkload, CDS (class sharing).
>
> Thanks,
> Vladimir
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mail.openjdk.java.net/pipermail/hotspot-dev/attachments/20120510/12d15716/attachment.html 


More information about the hotspot-dev mailing list