Request for reviews (M): 6924259: Remove String.count,String.offset fields

Roland Westrelin roland.westrelin at oracle.com
Fri May 11 08:08:59 PDT 2012


> http://cr.openjdk.java.net/~kvn/6924259/webrev
>
> 6924259: Remove String.count/String.offset
>
> Allows a version of the String class that doesn't have count,offset fields.
> These VM changes works with both versions of String class by checking the
> presence of fields.
>
> Initial changes were done by Brian and Tom years ago. I addapted it for current
> sources and tested it.
>
> Tested with NSK, regression tests, CTW, refworkload, CDS (class sharing).

Looks good to me (but I'm not a reviewer).

Maybe an assert(!java_lang_String::has_offset_field()) in GraphKit::store_String_offset() and GraphKit::store_String_length()?

Interestingly, it doesn't look like the c1 code is used anymore. I'm not sure what the history is here.

Roland.


More information about the hotspot-dev mailing list