Request for reviews (M): 6924259: Remove String.count, String.offset fields
Vladimir Kozlov
vladimir.kozlov at oracle.com
Fri May 11 09:59:07 PDT 2012
Roland Westrelin wrote:
>>> Looks good to me (but I'm not a reviewer).
>>
>> Why not? Even small comments and suggestions are considered as review.
>> Tom
>> reviewed these changes before but I look for other opinions also.
>
> I meant: I'm not an official reviewer.
> http://openjdk.java.net/census#hsx
>
> Roland.
No, you ARE Reviewer. You have 34 changesets which is more then required 32 for
Reviewer. So congratulation! I will add you as reviewer and will see what will
happened.
% hg log | grep roland | wc
34 68 680
"Some Projects require formal change review (hsx, jdk6, jdk7, jdk7u, and jdk8).
If you pushed at least 32 changegroups into such a Project's Mercurial
repositories, or if you were otherwise well-known to be a serious and regular
Committer, then you were considered a Reviewer."
Thanks,
Vladimir
More information about the hotspot-dev
mailing list