Request for reviews (M): 6924259: Remove String.count, String.offset fields

Vladimir Kozlov vladimir.kozlov at oracle.com
Mon May 14 09:03:38 PDT 2012


Coleen Phillimore wrote:
> 
> 
> Does java_lang_String::compute_offsets() have to be in 
> systemDictionary?   Can it not be in JavaClasses::compute_offsets() 
> function?   Can you add a comment why, like java_lang_Class has.

This is main change. I need it there because it is place when String class is 
loaded and after that point it can be used so it needs offsets value. The same 
for Class. I will add this comment.

Vladimir

> 
> This looks fine.  Didn't review the c2 code.
> 
> Thanks,
> Coleen
> 
> On 5/10/2012 2:11 PM, Vladimir Kozlov wrote:
>> http://cr.openjdk.java.net/~kvn/6924259/webrev
>>
>> 6924259: Remove String.count/String.offset
>>
>> Allows a version of the String class that doesn't have count,offset 
>> fields.
>> These VM changes works with both versions of String class by checking 
>> the presence of fields.
>>
>> Initial changes were done by Brian and Tom years ago. I addapted it 
>> for current sources and tested it.
>>
>> Tested with NSK, regression tests, CTW, refworkload, CDS (class sharing).
>>
>> Thanks,
>> Vladimir


More information about the hotspot-dev mailing list