Request for Review: Make the Queens test ("test in build") an option that can be disabled

[David Holmes]

Hi Magnus,

Two queries:

1. Shouldn't you skip building test_gamma as well as running it ?

2. Cross-compilation builds have to skip this too. Presently this is 
done by adding a cross-compilation check inside the test_gamma script 
that gets generated by buildtree.make - but it seems to me 
cross-compilation builds should simply set TEST_IN_BUILD=false

David
-----

On 14/05/2012 11:05 PM, Magnus Ihse Bursie wrote:
> As part of the new build system created in the build-infra project, we
> want to make it a configurable option wether or not to run the Queens
> test as part of the build.
>
> Here is a patch that introduces a new make variable, TEST_IN_BUILD,
> which controls wether to run the Queens test (test_gamma.sh) or not. If
> the variable is not explicitely set, it will default to true, mening
> that the default behaviour will be as before, that is, to run the Queens
> test. However, if you (or configure) explicitely set it to false, the
> Queens test will be skipped.
>
> http://cr.openjdk.java.net/~ihse/make-test-in-build-an-option/webrev.00
>
> /Magnus
>