Request for Review: Make the Queens test ("test in build") an option that can be disabled

[Vladimir Kozlov]

Magnus,

I hope I'm not late for review. Your changes looks good. But could you add an other change? Some time ago I add -Xmx32m 
flag to Queens TESTFLAGS in make/solaris/makefiles/buildtree.make to reduce startup time and memory usage. I also 
thought about adding flags -XX:CICompilerCount=1 -XX:ParallelGCThreads=1 for the same purpose. Could look on this and do 
this for BSD and linux test_gamma? I am fine if you don't want to do it now.

Thanks,
Vladimir


On 5/15/12 2:31 AM, Magnus Ihse Bursie wrote:
> On 2012-05-15 04:00, David Holmes wrote:
>> Hi Magnus,
>>
>> Two queries:
>>
>> 1. Shouldn't you skip building test_gamma as well as running it ?
> Sure, I can fix that.
>>
>> 2. Cross-compilation builds have to skip this too. Presently this is done by adding a cross-compilation check inside
>> the test_gamma script that gets generated by buildtree.make - but it seems to me cross-compilation builds should
>> simply set TEST_IN_BUILD=false
> Yeah, that sounds like a good idea. I modified the check in defs.make to one that sets TEST_IN_BUILD to false if it is
> not already set, and CROSS_COMPILE_ARCH is set, but true otherwise. That way you won't have to modify your scripts.
>
> New webrev:
>
> http://cr.openjdk.java.net/~ihse/make-test-in-build-an-option/webrev.01/
>
> /Magnus
>