[PATCH 0 of 3] Add support for dtrace compatible sdt probes on GNU/Linux

[serguei.spitsyn at oracle.com]

On 5/21/12 9:27 PM, David Holmes wrote:
> Is systemTap part of regular distros these days - in particular in our 
> build environment?
>
I don't know yet, we have to figure it out.
It'd be nice to have a Keith's opinion first.

> I'm just wondering who is going to ensure that these probe entries 
> compile and run correctly?

It depends on the availability or possible setup of linux machines with 
the systemTap.
Some test is needed as well.

>
> Can we see a complete webrev of the proposed changes?

I'll prepare a complete webrev.

Thanks,
Serguei

>
> Thanks,
> David
>
> On 22/05/2012 1:28 PM, serguei.spitsyn at oracle.com wrote:
>> Mark,
>>
>> I've created new RFE:
>>   7170638: enable support for dtrace compatible sdt probes on GNU/Linux
>>
>> The patches look good.
>> But I think, it is better to be reviewed by Keith McGuigan, who
>> originally added DTrace probes to HotSpot.
>> Also, let's check if we have to submit a CCC request for this.
>>
>> Keith, do you have cycles to review the patches from Mark?
>> I've included them into the bug report.
>>
>> Thanks,
>> Serguei
>>
>>
>> On 5/21/12 2:28 AM, Mark Wielaard wrote:
>>> On Thu, 2012-05-17 at 23:30 -0700,serguei.spitsyn at oracle.com  wrote:
>>>> On 18/05/2012 9:47 AM,serguei.spitsyn at oracle.com  wrote:
>>>> On 5/17/12 9:48 PM, David Holmes wrote:
>>>>>> Where are the patches?
>>>>>> I do not see them in your emails.
>>>>>>
>>>>> The patches themselves are the emails with the subjects:
>>>>>
>>>>> [PATCH 1 of 3] ...
>>>>> [PATCH 2 of 3] ...
>>>>> [PATCH 3 of 3] ...
>>>>>
>>>> I've found these emails, they somehow got to the trash folder - very
>>>> strange.
>>> Apologies. That is how hg email sends them. I have a local mercurial
>>> repository that contain the patches. Maybe your spam filter caught it
>>> because all subjects start with XXXXXX as placeholder because I don't
>>> have official bug numbers for them. If you could create the bugs and/or
>>> let me know if you rather see these patches split up differently (or 
>>> not
>>> split up at all), please let me know and I rebase my patches and resend
>>> them.
>>>
>>>>>> On 5/17/12 12:25 PM, Mark Wielaard wrote:
>>>>>>> On Mon, May 14, 2012 at 07:41:50AM -0600, Daniel D. Daugherty
>>>>>>> wrote:
>>>>>>>> On 5/14/12 2:06 AM, Mark Wielaard wrote:
>>>>>>>>> On Thu, 2012-05-10 at 09:52 -0600, Daniel D. Daugherty
>>>>>>>>> wrote:
>>>>>>>>>> Addingserviceability-dev at openjdk.java.net   to this e-mail
>>>>>>>>>> thread.
>>>>>>>>> Thanks. Please let me know if there is anything I can do to
>>>>>>>>> help
>>>>>>>>> integration of these patches, or if there are other
>>>>>>>>> places/people I need
>>>>>>>>> to add to the CC for review.
>>>>>>>> No problem. I was just making sure your e-mails got to the
>>>>>>>> right aliases.
>>>>>>>> As I no longer work on the Serviceability team, I'll leave it
>>>>>>>> to them to
>>>>>>>> address your e-mails.
>>>>>>> Feedback from the Serviceability team is highly appreciated.
>>>>>>> Please let
>>>>>>> me know how I can help getting these patches in as soon as
>>>>>>> possible.
>>>>>>>>>> On 5/10/12 7:49 AM, Mark Wielaard wrote:
>>>>>>>>>>> The following three patches enable support for dtrace
>>>>>>>>>>> compatible sdt probes
>>>>>>>>>>> on GNU/Linux. Most of the support was already submitted
>>>>>>>>>>> earlier. These are
>>>>>>>>>>> just the last three things left in IcedTea that actually
>>>>>>>>>>> enable it in
>>>>>>>>>>> hotspot. It has been in production use for some time
>>>>>>>>>>> already.
>>>>>>>>>>>
>>>>>>>>>>> The patches could be applied all as one, or individually
>>>>>>>>>>> if you want to be
>>>>>>>>>>> able to test them independently.
>>>>>>>>> [... explanation of separate patches removed ...]
>>>>>>>>>>> Patches in separate emails.
>>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mail.openjdk.java.net/pipermail/hotspot-dev/attachments/20120521/0acf4638/attachment-0001.html