request for codereview, bug 7149528: easy usage of serviceability agent

[Joe Darcy]

Yumin,

For the last two years, the average latency to get a finalized ccc 
request approved has been less than three days.  Over 10% of request are 
approved the same day they come in.

The ccc request for 7149528 is in "draft" state.  In other words, it has 
not yet been submitted to the ccc for consideration.  This state model 
is explained in the "process" link at the top of every ccc page and was 
additionally explained in a tech talk I gave earlier this year:

     http://j2se.us.oracle.com/web/pub/PrgMgmt/TechTalks/ccc-and-you.pdf

Please do not blame excessive wait times on the ccc process when the ccc 
is not being used as documented, especially when the explanatory talk 
tech was largely given in response to the experiences the serviceability 
team had with JFR.

Regards,

-Joe

On 5/22/2012 10:42 AM, Yumin Qi wrote:
> Staffan,
>
>   Thanks. Will change per your concern. Will remove -startsvr option.
>   CCC not approved yet, it may take long time waiting.
>
> Thanks
> Yumin
>
> On 2012/5/22 4:39, Staffan Larsen wrote:
>> Yumin,
>>
>> Thanks for doing this!
>>
>> I still wonder if we should support -startsvr in the new launcher, 
>> given that we already have a jsadebugd launcher that does exactly 
>> that. I don't like having two ways of doing the same thing that we 
>> have to support. Either we have jsadebugd or we have "jsa -startsvr", 
>> but I think it will be a lot of work to remove jsadebugd so it's 
>> simpler to leave it and remove the -startsvr flag.
>>
>> I think the usage instructions could be made easier to read by 
>> splitting them on multiple lines for the "live process" case and the 
>> "core" case. See the output from jsadebugd for an example. It would 
>> also be good if these two tools used the same terminology.
>>
>> A couple of nits for SAMain:
>> * the case statements do not need parentheses around the value: "case 
>> (0):" should be "case 0:"
>> * line 35: missing space before {
>> * line 37: missing space after the if
>> * line 37: always use {} and newlines after if
>> * line 42&  43: I prefer having the method implementation on a new 
>> line after the declaration
>>
>> Thanks,
>> /Staffan
>>
>>
>>
>> On 11 maj 2012, at 23:48, Yumin Qi wrote:
>>
>>> Hi, all
>>>
>>>   Can I have your codereview for bug 7149528: easy usage of 
>>> serviceability agent.
>>>   Problems 1) for launching Serviceability Agent(SA) is that it 
>>> needs setting several environmental variables for class path, 
>>> library path options. It is not easy for user to become familiar 
>>> with those settings. 2) SA launched from java and attached to java 
>>> process (or the binary which loaded JVM). On MacOS, attaching to 
>>> process needs permission. If we grant access for SA, we have to 
>>> grant all java processes have the same access permission so brings 
>>> security concern on the platform since java is too generic for doing 
>>> so. With a separate SA launcher, giving it permission attaching to 
>>> java process solves the concern.
>>>
>>> the change for both hotspot and jdk:
>>> http://cr.openjdk.java.net/~minqi/7149528
>>>
>>> Thanks
>>> Yumin