[PATCH 0 of 3] Add support for dtrace compatible sdt probes on GNU/Linux

[Mark Wielaard]

On Wed, 2012-05-23 at 09:14 -0400, Keith McGuigan wrote:
> Just a couple of quick comments/questions on the code:
> 
> Why did we get rid of a couple of the declarations in jni.cpp?  Why 
> aren't they needed?

Could you say which ones you think we got rid of? It was not my
intention to get rid of anything. Maybe you are referring to the first
patch? That came with the following description:

> The first patch is just a consistency cleanup patch. The JNI Set and
> SetStatic Field methods used HS_DTRACE_PROBE_CDECL_N and HS_DTRACE_PROBE_N
> directly instead of just using DTRACE_PROBE[N] like all other JNI methods.
> This doesn't matter for the Solaris macros, but on GNU/Linux the macros
> don't use direct function declarations (which is introduced in the second
> patch).

> dtrace.hpp should be refactored (if possible) into the os-specific 
> subdirectories, instead of using #ifdef <OS> macros in the header. 
> I.e., you might have to make a src/solaris/vm/dtrace_solaris.hpp and 
> src/linux/vm/dtrace_linux.hpp file and include it from here.

I rather not, the code should be identical except for two small details
between solaris and gnu/linux as the patch shows (and one is just a hack
for a solaris tailcall bug). The apple/macos part looks very different
and could be split out, but that was already there.

> Has this been built on solaris, and is the dtrace functionality unchanged?

I don't have access to solaris, the dtrace functionality should of
course be unchanged.

Thanks,

Mark