Request for review (XXS): inconsistent comments in instanceKlass after 7017732

=?gb2312?B?1Ma07w==?= yunda.mly at taobao.com
Sun Nov 4 02:14:16 PST 2012


Hi all,

I found a comment in instanceKlass that says ¡°embedded static fields follows here¡±. Since it¡¯s no longer true, I made a patch to fix it:

diff -r ca8168203393 src/share/vm/oops/instanceKlass.hpp
--- a/src/share/vm/oops/instanceKlass.hpp   Fri Nov 02 07:44:11 2012 -0700
+++ b/src/share/vm/oops/instanceKlass.hpp          Sun Nov 04 17:53:42 2012 +0800
@@ -278,7 +278,6 @@
   // embedded Java vtable follows here
   // embedded Java itables follows here
-  // embedded static fields follows here
   // embedded nonstatic oop-map blocks follows here
   // embedded implementor of this interface follows here
   //   The embedded implementor only exists if the current klass is an

And it seems that there¡¯s always no comment of itable below ¡°//    [EMBEDDED Java vtable             ] size in words = vtable_len¡± of vtable at the beginning of instanceKlass.hpp [1]. Could someone tell me why?

Regards,
Yunda

[1] http://hg.openjdk.java.net/hsx/hotspot-main/hotspot/file/ca8168203393/src/share/vm/oops/instanceKlass.hpp


________________________________

This email (including any attachments) is confidential and may be legally privileged. If you received this email in error, please delete it immediately and do not copy it or use it for any purpose or disclose its contents to any other person. Thank you.

±¾µçÓÊ(°üÀ¨Èκθ½¼þ)¿ÉÄܺ¬ÓлúÃÜ×ÊÁϲ¢ÊÜ·¨Âɱ£»¤¡£ÈçÄú²»ÊÇÕýÈ·µÄÊÕ¼þÈË£¬ÇëÄúÁ¢¼´É¾³ý±¾Óʼþ¡£Çë²»Òª½«±¾µçÓʽøÐи´ÖƲ¢ÓÃ×÷ÈκÎÆäËûÓÃ;¡¢»ò͸¶±¾ÓʼþÖ®ÄÚÈÝ¡£Ð»Ð»¡£


More information about the hotspot-dev mailing list