Review request: JDK-8003539 -- Minimal VM. VM doesn't react to -Dcom.sun.management and -XX:+ManagementServer

[Joe Provino]

On 11/16/2012 04:29 PM, Mandy Chung wrote:
> What about defining a new non_minimal_product flag (or whatever name) 
> for VM flags that only present in a non minimal VM?  i.e. in globals.hpp
>
>   non_minimal_product(bool, ManagementServer, 
> false,                                    \
>           "Create JMX Management 
> Server")                                   \
>
>
>
> This would avoid the need to add L2788-2792 for any flag that are not 
> supported in the minimal VM (one for each).

Mandy, that's an interesting idea.  arguments.cpp is getting cluttered 
with conditionals and maybe
that's a way to fix that.

joe

>
> Mandy
>
> On 11/16/12 12:43 PM, BILL PITTORE wrote:
>> He's saying that if you have INCLUDE_MANAGEMENT defined then you end 
>> up with an empty if statement. Harmless but ugly. I think you need to 
>> include the 'else if (match_option(... -XX:+Manage...)' line inside 
>> your #if. Watch out for braces.
>>
>> bill
>>
>>
>>
>> On 11/16/2012 3:20 PM, Joe Provino wrote:
>>>
>>>
>>> On 11/16/2012 3:14 PM, Dmitry Samersoff wrote:
>>>> Joe,
>>>>
>>>> After you fix at 2788 regular hotspot start accepting do-nothing 
>>>> option
>>>>
>>>> -XX:+ManagementServer
>>>>
>>>> Is it intentional?
>>>
>>> Hi Dmitry, I added the "} else if" at 2788 before the "} else if 
>>> (match_option(option, "-XX:+ManagementServer", &tail)) {"
>>> that was already there.  I'm not sure I understand the problem.
>>>
>>> joe
>>>
>>>> -Dmitry
>>>>
>>>>
>>>> On 2012-11-16 23:24, Joe Provino wrote:
>>>>> This is a small change to one file -- arguments.cpp -- to print an 
>>>>> error
>>>>> message
>>>>> and exit if INCLUDE_MANAGEMENT is false.
>>>>>
>>>>> Webrev is here: 
>>>>> http://cr.openjdk.java.net/~jprovino/8003539/webrev.00/
>>>>>
>>>>> thanks.
>>>>>
>>>>> joe
>>>>
>>
>>
>