hotspot-dev Digest, Vol 67, Issue 27

[Chris Plummer]

On 11/16/12 2:15 PM, hotspot-dev-request at openjdk.java.net wrote:
> Message: 8
> Date: Fri, 16 Nov 2012 17:08:22 -0500
> From: Joe Provino<joseph.provino at oracle.com>
> Subject: Re: Review request: JDK-8003539 -- Minimal VM. VM doesn't
> 	react to	-Dcom.sun.management and -XX:+ManagementServer
> To:hotspot-dev at openjdk.java.net
> Message-ID:<50A6B956.1030500 at oracle.com>
> Content-Type: text/plain; charset=UTF-8; format=flowed
>
> On 11/16/2012 04:29 PM, Mandy Chung wrote:
>> >What about defining a new non_minimal_product flag (or whatever name)
>> >for VM flags that only present in a non minimal VM?  i.e. in globals.hpp
>> >
>> >   non_minimal_product(bool, ManagementServer,
>> >false,                                    \
>> >           "Create JMX Management
>> >Server")                                   \
>> >
>> >
>> >
>> >This would avoid the need to add L2788-2792 for any flag that are not
>> >supported in the minimal VM (one for each).
> Mandy, that's an interesting idea.  arguments.cpp is getting cluttered
> with conditionals and maybe
> that's a way to fix that.
The problem with this solution is that the absence of this flag needs to 
be associated with INCLUDE_MANAGEMENT=0, not with the MinimalVM. 
Otherwise we'd just have #ifdef MINIMALVM all over the source rather 
than the more selective #if  INCLUDE_XXX. Thus instead of 
non_minimal_product, what you need is include_management_product, or 
something like that. And you would need this for each INCLUDE_XXX flag 
that has an effect on available command line options. Whether or not 
that is a good idea depends on how many options and how many INCLUDE_XXX 
flags we are talking about.

Chris
> joe
>
>> >
>> >Mandy