Review request: JDK-8003539 -- Minimal VM. VM doesn't react to -Dcom.sun.management and -XX:+ManagementServer

[David Holmes]

Hi Joe,

I think we should have utilized UNSUPPORTED_OPTION for those flags that 
have to be disabled and will generate a warning (eg all the GC warnings) 
- even if we have to augment the macro somewhat. Then we could have a 
second macro for the vm_exit_on_initialization case (though the 
distinction between a fatal error and a warning seems to be quite 
arbitrary :( ).

Otherwise this change seems functionally correct, but the indentation 
appears wrong for the -Dcom.sun.management change.

David

On 19/11/2012 7:31 AM, Joe Provino wrote:
>
> How does this look? http://cr.openjdk.java.net/~jprovino/8003539/webrev.01/
>
> On 11/16/2012 4:13 PM, BILL PITTORE wrote:
>> Where you had it is the right place, you just need to #if it better.
>> The -XX: options get process by the code just after line 2788 by
>> process_argument(). That deals with all the globals defined in
>> globals.hpp so it's not where you can special case one flag.
>>
>> bill
>>
>>
>>
>> On 11/16/2012 3:23 PM, Joe Provino wrote:
>>> Dmitri, wait, I think I see what you mean. If INCLUDE_MANAGEMENT is
>>> set to true, then there's no code generated.
>>>
>>> I think the code that's there will work but perhaps there's a better
>>> place to check for this option when
>>> INCLUDE_MANAGEMENT is false.
>>>
>>> I seem to recall there's a place were -XX: arguments are parsed But I
>>> don't see a separate method to do that.
>>> I must be looking in the wrong place.
>>>
>>> joe
>>>
>>> On 11/16/2012 3:14 PM, Dmitry Samersoff wrote:
>>>> Joe,
>>>>
>>>> After you fix at 2788 regular hotspot start accepting do-nothing option
>>>>
>>>> -XX:+ManagementServer
>>>>
>>>> Is it intentional?
>>>>
>>>> -Dmitry
>>>>
>>>>
>>>> On 2012-11-16 23:24, Joe Provino wrote:
>>>>> This is a small change to one file -- arguments.cpp -- to print an
>>>>> error
>>>>> message
>>>>> and exit if INCLUDE_MANAGEMENT is false.
>>>>>
>>>>> Webrev is here:
>>>>> http://cr.openjdk.java.net/~jprovino/8003539/webrev.00/
>>>>>
>>>>> thanks.
>>>>>
>>>>> joe
>>>>
>>
>>