Request for review 8003722: More gcc 4.7 compilation errors
Coleen Phillimore
coleen.phillimore at oracle.com
Wed Nov 21 06:18:07 PST 2012
On 11/20/2012 9:52 PM, David Holmes wrote:
> Sorry but I must protest. After the last fix we were returned to an
> unpleasant mixture of using directives and this-> augmentation. The
> fix that was lost had applied the using directive.
>
> Can we please use the using directive and just fix these once and for
> all.
Okay, someone will have to contribute the "using" fix then. I don't
know what to use in "using"!
Please do this very soon since the VM doesn't build on gcc 4.7 (again!)
Thanks,
Coleen
>
> Otherwise get rid of all using directives. But lets have a consistent
> approach here.
>
> Thanks,
> David
>
> On 21/11/2012 11:44 AM, Coleen Phillimore wrote:
>> Summary: Add a few more this->qualifications.
>> Reviewed-by: coleenp
>> Contributed-by: duboscq at ssw.jku.at
>>
>> http://cr.openjdk.java.net/~coleenp/8003722/
>>
>> Ran runThese tests with CMS gc. I want to check this into hotspot-gc
>> since it has the other changes (hotspot-rt doesn't yet).
>>
>> Thanks,
>> Coleen
More information about the hotspot-dev
mailing list