RFR(S): Fix generation of malformed options for Projectcreator
Nils Eliasson
nils.eliasson at oracle.com
Fri Nov 23 05:04:23 PST 2012
Slight change. Moving placement of escaping tokens for a more enjoyable
experience.
http://cr.openjdk.java.net/~neliasso/8003934/webrev.02/
//N
Nils Eliasson skrev 2012-11-23 09:39:
> Preferably reviewed by someone with a little nmake experience.
>
> This fixes a bug which causes visual studio to throw errors when
> trying to build hotspot.
>
> make/windows/projectfiles/common/Make sets up some options that is
> passed as a string to ProjectCreator.java. That string gets unmatched
> pairs of escaped quotation marks around the hotspot release version.
> After closer examination that happens when a number of vars and
> escaped quotation marks are appended together on a multi line string
> append.
>
> This fixes removes unnecessary (and potentially bad) quotation marks,
> simplifies the option creation and creates the options with escaping
> characters on the same line.
>
> http://cr.openjdk.java.net/~neliasso/8003934/webrev.01/
>
> Thanks,
> Nils Eliasson
More information about the hotspot-dev
mailing list