RFR (M): CR 8003985: Support @Contended Annotation - JEP 142
Aleksey Shipilev
aleksey.shipilev at oracle.com
Fri Nov 30 05:07:13 PST 2012
I can, but I will be hit in the back with footprint issue again. If that
is not a problem for Hotspot maintainers, I can make it diagnostic.
-Aleksey.
On 11/30/2012 05:05 PM, Vitaly Davidovich wrote:
> Hi Aleksey,
>
> Can you please make PrintFieldLayout at least a diagnostic flag? It
> would be useful to see its output for users in product builds.
>
> Thanks
>
> Sent from my phone
>
> On Nov 30, 2012 7:25 AM, "Aleksey Shipilev" <aleksey.shipilev at oracle.com
> <mailto:aleksey.shipilev at oracle.com>> wrote:
>
> Yes I did, Coleen, thanks for additional review. I will try to
> address/revisit these along with other issues outlined in other reviews.
> Stay tuned for another webrev coming :)
>
> -Aleksey.
>
> On 11/30/2012 04:19 PM, Coleen Phillimore wrote:
> >
> > I sent a code review of this code also, did you see it? I am very
> > concerned with the additional footprint that this allocates for
> > contended flags for each field. Did I read this code correctly? I
> > don't think this code can be pushed until this is resolved.
> > Thanks,
> > Coleen
> >
> > On 11/30/2012 5:44 AM, Aleksey Shipilev wrote:
> >> On 11/30/2012 07:35 AM, David Holmes wrote:
> >>> This work can not be pushed until the JEP has moved to the
> Funded state.
> >> So... How should one move it to the Funded state?
> >>
> >>> I'd also like to know what testing has been done so far from the
> regular
> >>> hotspot testsuites. There may be places where layout assumptions are
> >>> being made eg oops first.
> >> Are JPRT acceptance tests enough, or we should do the out-of-cycle VM
> >> testing before the integration?
> >>
> >> -Aleksey.
> >>
> >
>
More information about the hotspot-dev
mailing list