RFR (small) 6518907: cleanup IA64 specific code in Hotspot
Vladimir Kozlov
Vladimir.Kozlov at oracle.com
Fri Nov 30 12:38:57 PST 2012
I put webrev on open server:
http://cr.openjdk.java.net/~kvn/6518907/webrev/
One thing concern me is code change in os.cpp for Win64:
+ // On Windows AMD64 link() does not work as there's no back link on
the stack.
+ #elif (defined(IA64) || defined(AMD64)) && defined(_WIN32)
Can someone familiar with Windows confirm if the statement in the
comment and code change are correct?
And in os_windows.cpp EXCEPTION_REG_NAT_CONSUMPTION is defined twice.
Thanks,
Vladimir
On 11/29/12 12:01, Morris Meyer wrote:
> Gentlefolk,
>
> I have taken a second pass at
> https://jbs.oracle.com/bugs/browse/JDK-6518907 and incorporated the
> comments of Goetz Lindenmaier of SAP accordingly, and their changes to
> src/os/windows/vm/os_windows.cpp specifically.
>
> Thanks to all for the first review.
>
> --mm
>
> JBS - https://jbs.oracle.com/bugs/browse/JDK-6518907
> WEBREV - http://javaweb.us.oracle.com/~mameyer/webrevs/02/JDK-6518907/
More information about the hotspot-dev
mailing list