Request for review 7170638: Use DTRACE_PROBE[N] in JNI Set and SetStatic Field.

[Coleen Phillimore]

Yes, I've done similar reformatting for that macro, see:
http://cr.openjdk.java.net/~coleenp/7170638_2/
Coleen

On 10/1/2012 5:32 PM, Mark Wielaard wrote:
> On Mon, Oct 01, 2012 at 08:20:32PM +0200, Mark Wielaard wrote:
>> On Mon, 2012-10-01 at 08:22 -0400, Keith McGuigan wrote:
>>> Those lines in jni.cpp are bordering on "ludicrous" character length,
>>> IMO.  I know we don't have an hard-set character limit (much to my
>>> chagrin), but we should at least try to keep it reasonable to and close
>>> what else is in the surrounding code.  (My bad for not mentioning this
>>> eariler.)
>> Please feel free to add a \ line continuation before the second
>> DTRACE_PROBE macro on each line. That would still be ~100 character, but
>> that would be shorter than some of the surrounding code, and seems like
>> a "natural" break place. Normally I don't like such long lines either
>> and keep to<  76 so things fit nicely in my terminal window, but since
>> this file already had 160+ character lines I thought I would go with the
>> flow.
> The attached jni.cpp patch does this and seems to work for me.
>
> Cheers,
>
> Mark