Request for review 7170638: Use DTRACE_PROBE[N] in JNI Set and SetStatic Field.
Mark Wielaard
mjw at redhat.com
Thu Oct 4 06:08:20 PDT 2012
On Wed, 2012-10-03 at 17:52 -0400, Coleen Phillimore wrote:
> The logic for setting up OPENJDK is different but there was some code to
> set up HOTSPOT_VM_DISTRO based on the presence or absence of certain
> closed files. Anyway, I think this code is correct now. It sets
> OPENJDK if HOTSPOT_VM_DISTRO is OpenJDK. I can build Hotspot on Linux
> both ways now.
>
> open webrev at http://cr.openjdk.java.net/~coleenp/7170638_4/
> bug link at http://bugs.sun.com/view_bug.do?bug_id=7170638
>
> I also filed a bug 8000408 for Oracle JVM to support this in the future.
>
> Please review, again, and thank you for your patience!
Nice, that was a lot easier than I feared. Just one additional line!
I totally missed the flags.make snippet was generated by the buildtree
makefile itself. Works fine here. Thanks.
One small comment. Shouldn't you also make the same change to
make/solaris/makefiles/buildtree.make and
make/bsd/makefiles/buildtree.make to keep them in sync?
Thanks,
Mark
More information about the hotspot-dev
mailing list