Request for review 7170638: Use DTRACE_PROBE[N] in JNI Set and SetStatic Field.

[Mark Wielaard]

On Thu, 2012-10-04 at 20:23 -0700, serguei.spitsyn at oracle.com wrote:
> src/share/vm/utilities/dtrace.hpp
>  198 #define HS_DTRACE_PROBE9(provider,name,a0,a1,a2,a3,a4,a5,a6,a7,a8)\
>  199   DTRACE_PROBE9(provider,name,a0,a1,a2,a3,a4,a5,a6,a7,a8)
>  200 #define HS_DTRACE_PROBE10(provider,name,a0,a1,a2,a3,a4,a5,a6,a7,a8)\
>  201   DTRACE_PROBE10(provider,name,a0,a1,a2,a3,a4,a5,a6,a7,a8)
>   A question:
>     Is it intentional that PROBE9 and PROBE10 have the same number of
> parameters?
>     Should PROBE10 have extra parameter a9?

Good catch. Luckily there are no probes in hotspot with 10 arguments.
There is one probe with 9 arguments though, method__compile__end.
Yes, PROBE10 should have 10 arguments, not 9.

Thanks,

Mark