Request for Review: Conditionalize source so that functionality can be easily included or excluded

[Coleen Phillimore]

Hi Joe,

Did you take out the Windows "kernel" build with this change?   If so, 
there are still code which refers to kernel in 
http://cr.openjdk.java.net/~jprovino/7189254/webrev.10/make/Makefile.html which 
should be removed.

In make/Makefile, the COMMON_VM_*_TARGETS is what caused the kernel to 
be built with jprt.   This was pretty useful so that people didn't 
inadvertently break the kernel build.   I think you should add minimal1 
to this list instead now so that the same doesn't happen with minimal vm.

In 
http://cr.openjdk.java.net/~jprovino/7189254/webrev.10/src/share/vm/code/nmethod.cpp.udiff.html

Do you not need the conditional compilation because 
JvmtiExport::has_redefined_a_class() is included and always returns false?

If kernel is completely removed, there's some code you can remove in 
systemDictionary.cpp as well.   I think that's the last of the kernel code.

Rest looks good.
Coleen

On 10/5/2012 10:59 AM, Joe Provino wrote:
> The latest and hopefully final webrev is here:
>
> http://cr.openjdk.java.net/~jprovino/7189254/webrev.10 
> <http://cr.openjdk.java.net/%7Ejprovino/7189254/webrev.10/>
>
> The changes are to make/{linux,bsd}/gcc.make to ensure that
> CFLAGS and OPT_CFLAGS behave the way they did before any changes.
>
> joe
>