RFR (S): 7197424: update copyright year to match last edit in jdk8 hotspot repository
Coleen Phillimore
coleen.phillimore at oracle.com
Tue Oct 9 10:17:48 PDT 2012
Mikael, This looks good.
Coleen
On 10/9/2012 12:59 PM, Mikael Vidstedt wrote:
>
> I also did a couple of additional verifications to make sure the
> script seemed to have done the right thing and it does indeed look
> correct.
>
> I think there's been some work to see if we can have the update happen
> more or less automagically at modification time and I agree that if we
> could reduce the pain level it would be nice to do it that way, but
> just as you say there are pros and cons.
>
> Thanks,
> Mikael
>
> On 10/8/2012 6:42 PM, David Holmes wrote:
>> Hi Mikael,
>>
>> On 9/10/2012 10:30 AM, Mikael Vidstedt wrote:
>>> Can I please get a couple of reviews of the below change?
>>>
>>> Don't be scared by the size of the change, even though it touches many
>>> files (271 to be exact) the change is the same for all of them -
>>> updating the copyright year in the header. The change was created using
>>> the make/scripts/update_copyright_year.sh script from the JDK.
>>>
>>> http://cr.openjdk.java.net/~mikael/7197424/webrev.00/webrev/
>>
>> I've verified that the copyrights have been updated to 2012.
>>
>> I can't (well won't :) ) validate that they should have been updated
>> to 2012. I did check a couple and saw that JSR-292 changes seem t be
>> involved a lot. ;-)
>>
>> Personally I'd prefer to see file copyrights always updated at
>> modification time (preferably automagically!) rather than in bulk
>> later - as later no one is validating the change. Hotspot always
>> tended to work this way in the past, whereas the JDK did/does not.
>> There are pros and cons either way.
>>
>> Cheers,
>> David
>>
>>> Thanks,
>>> Mikael
>>>
>
More information about the hotspot-dev
mailing list