RFR (S): 7197424: update copyright year to match last edit in jdk8 hotspot repository

Christian Thalinger christian.thalinger at oracle.com
Fri Oct 12 10:26:53 PDT 2012


On Oct 8, 2012, at 6:42 PM, David Holmes <David.Holmes at oracle.com> wrote:

> Hi Mikael,
> 
> On 9/10/2012 10:30 AM, Mikael Vidstedt wrote:
>> Can I please get a couple of reviews of the below change?
>> 
>> Don't be scared by the size of the change, even though it touches many
>> files (271 to be exact) the change is the same for all of them -
>> updating the copyright year in the header. The change was created using
>> the make/scripts/update_copyright_year.sh script from the JDK.
>> 
>> http://cr.openjdk.java.net/~mikael/7197424/webrev.00/webrev/
> 
> I've verified that the copyrights have been updated to 2012.
> 
> I can't (well won't :) ) validate that they should have been updated to 2012. I did check a couple and saw that JSR-292 changes seem t be involved a lot. ;-)

Thank you.  We did our best ;-)  -- Chris

> 
> Personally I'd prefer to see file copyrights always updated at modification time (preferably automagically!) rather than in bulk later - as later no one is validating the change. Hotspot always tended to work this way in the past, whereas the JDK did/does not. There are pros and cons either way.
> 
> Cheers,
> David
> 
>> Thanks,
>> Mikael
>> 



More information about the hotspot-dev mailing list