RFR: JDK-8001619: Remove usage of _ALLBSD_SOURCE in bsd files

David Holmes david.holmes at oracle.com
Fri Oct 26 04:35:46 PDT 2012


On 26/10/2012 8:47 PM, Staffan Larsen wrote:
> This is an attempt at cleaning up the source in src/os/bsd by removing the usage of _ALLBSD_SOURCE in these files. Since the define is always set when compiling these files it is not necessary to use it in the source files. The usage was originally added during the porting to make it easier to see changes against the base linux version.
>
> http://cr.openjdk.java.net/~sla/8001619/webrev.00/

Generally looks okay (though now I see some of the actual BSD code it 
makes me a little nervous!). A couple of minor things:

os_bsd.cpp:

977 }
978 #elif

3957   return true;
3958 #elif
3959   return false;

Shouldn't the elif's have become an else?

Ditto for os_bsd_x86.cpp:

850 #elif

Also you can probably do the same thing for bsd_zero: 
/src/os_cpu/bsd_zero/vm/os_bsd_zero.cpp. Just check with the zero folk.

David
-----

> Thanks,
> /Staffan


More information about the hotspot-dev mailing list