RFR: JDK-8001619: Remove usage of _ALLBSD_SOURCE in bsd files

Coleen Phillimore coleen.phillimore at oracle.com
Fri Oct 26 04:37:09 PDT 2012


Staffan,   This looks really good.

Can you change the conditional now in arguments.cpp?   Harold's checked 
in that change yesterday.   Didn't know you'd get to this so fast. :)   
I guess it should be __APPLE__ now (idk).

A prize should go to someone who comes up with a better name for the 
posix directory and we should add common code there. Although it looks 
like os_bsd.cpp doesn't share as much with os_linux.cpp as hoped.  I 
think we can't use 'unix'.    How about 'ix'?

Thanks,
Coleen

On 10/26/2012 6:47 AM, Staffan Larsen wrote:
> This is an attempt at cleaning up the source in src/os/bsd by removing the usage of _ALLBSD_SOURCE in these files. Since the define is always set when compiling these files it is not necessary to use it in the source files. The usage was originally added during the porting to make it easier to see changes against the base linux version.
>
> http://cr.openjdk.java.net/~sla/8001619/webrev.00/
>
> Thanks,
> /Staffan



More information about the hotspot-dev mailing list