Default methods for jdk8: request for code review

Coleen Phillimore coleen.phillimore at oracle.com
Fri Oct 26 06:57:26 PDT 2012


Hi,
I have read through all of this code.  Offline to Keith, I have 
suggested some name changes and comments to make it clearer, at least to 
me, what this code is doing.  It's very dense but I believe it is 
correct and finds the correct default method to add to the vtable in the 
most efficient way possible.
Keith, can you elaborate on the tests that you've run against this?
Thanks,
Coleen

On 10/10/2012 1:12 PM, Keith McGuigan wrote:
> Hello,
>
> I'd like any review of the code which implements default methods in 
> the JVM.  This is destined for jdk8 as part of JSR 335 (Lambdas), and 
> tracked by CR 7200776.
>
> The design and implementation is described in this short document:
> http://cr.openjdk.java.net/~kamg/default_methods_in_hotspot.txt
>
> And the code is here:
> http://cr.openjdk.java.net/~kamg/default_methods/
>
> Any review (even partial) would be appreciated.  Thanks!
>
> -- 
> - Keith


More information about the hotspot-dev mailing list