Default methods for jdk8: request for code review

[Coleen Phillimore]

Have you run our hotspot-rt nightly tests (vm.quick.testlist)?
thanks,
Coleen

On 10/26/2012 10:19 AM, Keith McGuigan wrote:
> Sure.  In addition to running the internal UTE/JCK tests, the same code has gone through testing as part of the lambda repositories.  There is new test-ng lambda tests in lambda/jdk/test-ng and lambda/jdk/combo-tests (run with ant).  And the entire lambda build (including the new VM bits) gets nightly testing that runs (at least) the workspace regression tests.
>
> --
> - Keith
>
> On Oct 26, 2012, at 9:57 AM, Coleen Phillimore wrote:
>
>> Hi,
>> I have read through all of this code.  Offline to Keith, I have suggested some name changes and comments to make it clearer, at least to me, what this code is doing.  It's very dense but I believe it is correct and finds the correct default method to add to the vtable in the most efficient way possible.
>> Keith, can you elaborate on the tests that you've run against this?
>> Thanks,
>> Coleen
>>
>> On 10/10/2012 1:12 PM, Keith McGuigan wrote:
>>> Hello,
>>>
>>> I'd like any review of the code which implements default methods in the JVM.  This is destined for jdk8 as part of JSR 335 (Lambdas), and tracked by CR 7200776.
>>>
>>> The design and implementation is described in this short document:
>>> http://cr.openjdk.java.net/~kamg/default_methods_in_hotspot.txt
>>>
>>> And the code is here:
>>> http://cr.openjdk.java.net/~kamg/default_methods/
>>>
>>> Any review (even partial) would be appreciated.  Thanks!
>>>
>>> -- 
>>> - Keith