RFR: 8002078: hs_err_pid file should report full JDK version string

Krystal Mo krystal.mo at oracle.com
Wed Oct 31 14:24:13 PDT 2012


Hi Staffan,

Looks good to me. This is helpful especially when dealing with nightlies.

But I wonder if it's better to fold get_java_runtime_name() and 
get_java_runtime_version() into one, something like 
set_java_runtime_info(), since these two functions are mostly doing the 
same thing.
I'm okay either way, the choice is up to you :-)

Regards,
Kris

On 2012/11/1 4:59, Staffan Larsen wrote:
> Please review the following change to the crash output. Currently when hotspot crashes the output contains:
>
> # JRE version: Java(TM) SE Runtime Environment (8.0)
> # Java VM: Java HotSpot(TM) 64-Bit Server VM (24.0-b20 mixed mode bsd-amd64 compressed oops)
>
> With the same installation "java -version" reports:
>
> Java(TM) SE Runtime Environment (build 1.8.0-internal-staffan_2012_10_09_15_30-b00)
> Java HotSpot(TM) 64-Bit Server VM (build 24.0-b20, mixed mode)
>
> The first output above should be changed to look like:
>
> # JRE version: Java(TM) SE Runtime Environment (8.0) (build 1.8.0-internal-staffan_2012_10_09_15_30-b00)
> # Java VM: Java HotSpot(TM) 64-Bit Server VM (24.0-b20 mixed mode bsd-amd64 compressed oops)
>
> http://cr.openjdk.java.net/~sla/8002078/webrev.01/
>
> Thanks,
> /Staffan


More information about the hotspot-dev mailing list