Code review request: NMT: assertion failed: assert(rec->addr() + rec->size() <= cur->base()) failed: Can not overlap in memSnapshot.cpp

[David Holmes]

On 1/11/2012 2:12 AM, Zhengyu Gu wrote:
> NMT did not allow overlapped commit on memory regions, which is
> incorrect. Committing overlapped memory regions should be allowed, as
> long as the regions are within a reserved region.

So the overlapping stacks that were detected is perfectly valid?

>
> http://cr.openjdk.java.net/~zgu/8001591/webrev.00/

The renaming from contains_xx to contain_xx is not correct. "contains" 
is the correct form to use, and "overlaps" rather than "overlap".

Why the variable rename in VMMemPointerIterator::add_reserved_region? 
Given it is initialized from current() then 'cur' seems quite 
acceptable. Otherwise maybe it is current() that has the wrong name? The 
renaming generates a lot of noise in the webrev - it is hard to see the 
actual substantive changes that were made.

Cheers,
David


> Thanks,
>
> -Zhengyu