Request for reviews (S): 7196167: NPG: mismerge in make/solaris/makefiles/fastdebug.make

Vladimir Kozlov vladimir.kozlov at oracle.com
Wed Sep 5 10:10:13 PDT 2012


Thank you, Coleen

Vladimir

Coleen Phillimore wrote:
> 
> This looks good.  Thank you for cleaning this up.  I'm so happy I'm not 
> merging this thing anymore!
> Coleen
> 
> On 9/4/2012 10:14 PM, Vladimir Kozlov wrote:
>> Thank you, David
>>
>> Vladimir
>>
>> On 9/4/12 7:02 PM, David Holmes wrote:
>>> On 5/09/2012 11:19 AM, Vladimir Kozlov wrote:
>>>> http://cr.openjdk.java.net/~kvn/7196167/webrev
>>>>
>>>> Remove the workaround of 7187454 problem for escape.o and matcher.o
>>>> which was restored incorrectly during NPG merge. It was removed with
>>>> 7187454 fix.
>>>
>>> Original removal changeset:
>>>
>>> http://hg.openjdk.java.net/hsx/hotspot-gc/hotspot/diff/6c5b7a6becc8/make/solaris/makefiles/fastdebug.make 
>>>
>>>
>>> Mis-merge changeset that added it back:
>>>
>>> http://hg.openjdk.java.net/hsx/hotspot-gc/hotspot/diff/da91efe96a93/make/solaris/makefiles/fastdebug.make 
>>>
>>>
>>> Looks like a correct reversal to me.
>>>
>>> David
>>>
>>>> Thanks,
>>>> Vladimir
> 


More information about the hotspot-dev mailing list