Please review fix for 7196681: NPG: Some JSR 292 tests crash in Windows exception handler

[Christian Thalinger]

On Sep 11, 2012, at 4:38 PM, Coleen Phillimore <coleen.phillimore at oracle.com> wrote:

> 
> How is this?  I added some TODO's and will file an RFE to implement this.   I tested -XX:+VerifyOops with sparc and x86.
> 
> http://oklahoma.us.oracle.com/~cphillim/webrev/7196681_2/

src/cpu/x86/vm/cppInterpreter_x86.cpp:

In this file you use verify_method instead of verify_method_ptr.

-- Chris

> 
> There were some verify_oop's removed in the permgen project that would be good to add back.  I will add that to the RFE.
> 
> Thanks,
> Coleen
> 
> On 9/11/2012 7:27 PM, Christian Thalinger wrote:
>> On Sep 11, 2012, at 1:51 PM, Coleen Phillimore<coleen.phillimore at oracle.com>  wrote:
>> 
>>> Summary: There was a rogue os::breakpoint() call in log_dependency left over from the jsr292 merge.  Also removed verify_oop() calls for metadata.
>>> 
>>> Tested CallSiteTest on windows 64 where this os::breakpoint() actually sends a breakpoint signal.
>> Oops.  It must be a left-over from the merge.  Otherwise this looks good and I agree that empty verify methods would be nice.
>> 
>> -- Chris
>> 
>>> open webrev at http://cr.openjdk.java.net/~coleenp/7196681/
>>> bug link at http://bugs.sun.com/view_bug.do?bug_id=7196681
>>> 
>>> Thanks,
>>> Coleen
>>> 
>>>