RFR: 7200065 Cross-compilation changes to support the new-build

Kelly O'Hair kelly.ohair at oracle.com
Fri Sep 21 09:50:36 PDT 2012


What bothers me on this adlc.make change is that there is no comment in the Makefile as to why ARCHFLAG is filtered out
of the options. Why is this necessary?

The defs.make file changes look fine.

-kto

On Sep 20, 2012, at 11:40 PM, David Holmes wrote:

> webrev:
> 
> http://cr.openjdk.java.net/~dholmes/7200065/webrev/
> 
> These are Fredrik's contributions from build-infra being moved to mainline (to join the changes Kelly pushed the other day). There is a slight change to Fredrik's original changeset due to a bug with the old build (PATH_SEP wouldn't get set) - and it's simpler to use ?:= than ifdef.
> 
> I'm acting as one reviewer but would welcome other eyes.
> 
> Thanks,
> David



More information about the hotspot-dev mailing list