Request for review (XS): 7200470 KeepAliveClosure not needed in CodeCache::do_unloading

Bengt Rutisson bengt.rutisson at oracle.com
Tue Sep 25 06:41:59 PDT 2012


Thanks David, Keith and Coleen!

All set to push this now.

Bengt


On 2012-09-25 15:08, Coleen Phillimore wrote:
>
> This looks good.
> Thanks!
> Coleen
>
> On 9/25/2012 7:59 AM, Bengt Rutisson wrote:
>>
>> Thanks, Stefan!
>>
>> I need one more review from an OpenJDK Reviewer. Any takers? It's a 
>> very small change and fast to review...
>>
>> Bengt
>>
>> On 2012-09-25 13:20, Stefan Karlsson wrote:
>>> Looks good.
>>>
>>> StefanK
>>>
>>> On 09/24/2012 02:05 PM, Bengt Rutisson wrote:
>>>>
>>>> Hi all,
>>>>
>>>> Could I have a couple of reviews for this small change to remove 
>>>> some unused code?
>>>> http://cr.openjdk.java.net/~brutisso/7200470/webrev.00/
>>>>
>>>> We are passing around a closure but we never use it.
>>>>
>>>> Posting this on hotspot-dev since it is unclear to me if this is a 
>>>> GC, Compiler or Runtime related fix. I plan on pushing this through 
>>>> hotspot-gc.
>>>>
>>>> Thanks,
>>>> Bengt
>>>
>>



More information about the hotspot-dev mailing list