Request for review 8000213: NPG: Should have renamed arrayKlass and typeArrayKlass

Coleen Phillimore coleen.phillimore at oracle.com
Fri Sep 28 09:42:49 PDT 2012


Christian,  I made that change in the compiler interface files (ci).
thanks for pointing out the omission.

Hit reload.

Coleen

On 9/28/2012 12:01 PM, Christian Thalinger wrote:
>
> On Sep 28, 2012, at 6:46 AM, Coleen Phillimore 
> <coleen.phillimore at oracle.com <mailto:coleen.phillimore at oracle.com>> 
> wrote:
>
>> Summary: Capitalize these metadata types (and objArrayKlass)
>>
>> Also fixed some whitespace errors in classfileParser caused by one of 
>> the metadata merges and renames.   Whitespace changes don't really 
>> show up in webrev but that's why these files are in the webrev.
>>
>> open webrev at http://cr.openjdk.java.net/~coleenp/8000213/ 
>> <http://cr.openjdk.java.net/%7Ecoleenp/8000213/>
>> bug link at http://bugs.sun.com/view_bug.do?bug_id=8000213
>>
>> Sorry in advance for the tedious review.
>> Tested against nsk.sajdi.testlist because the SA is sensitive to all 
>> changes like this.
>
> Why don't you change the getter methods as well when you're already 
> there:
> *!    _ArrayKlass_* get_arrayKlass() {*
> -- Chris
>
>>
>> thanks,
>> coleen


More information about the hotspot-dev mailing list