From coleen.phillimore at oracle.com Mon Apr 1 13:09:02 2013 From: coleen.phillimore at oracle.com (Coleen Phillimore) Date: Mon, 01 Apr 2013 16:09:02 -0400 Subject: hs25 review request: 8008511 JSR 292: MemberName vmtarget refs to methods must be updated at class redefinition In-Reply-To: <51515E3C.7040307@oracle.com> References: <513E8B88.6070904@oracle.com> <51515E3C.7040307@oracle.com> Message-ID: <5159E95E.2030705@oracle.com> Hi Serguei, Sorry for the delay in reviewing this. In instanceKlass.cpp line 2730, can you make that mtClass since it's part of class metadata? In methodHandles.cpp, I think the whole member name table mechanism could be protected by #if INCLUDE_JVMTI since it's not needed unless you have jvmti built in the vm. And you don't need to call add_method_handle() or just have it do JVMTI_RETURN or something for the minimal vm. Also, I think you should consider a global table rather than one per class. I think we discussed this and may have decided that speed of adding these is important, but depending on how many are actually used per class, there's one pointer per class. Maybe they could be organized as a hashtable instead like the method handle intrinsics? The code itself looks good everywhere, except for the concern about footprint. Thanks, Coleen Can you make this mtClass on line On 03/26/2013 04:37 AM, serguei.spitsyn at oracle.com wrote: > > Please, review the following fix. > The fix was preliminarily reviewed by Coleen, Christian > and John but still a final and open jdk review is needed. > So that, everyone is welcome to review the fix! > > This is open webrev: > http://cr.openjdk.java.net/~sspitsyn/webrevs/2013/hotspot/8008511-JVMTI-JSR292.1/ > > The CR is: > http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=8008511 > https://jbs.oracle.com/bugs/browse/JDK-8008511 > > > The problem is that the old version of the bootstrap method is re-invoked > after a popframe from the bootstrap method execution. > It is because the MemberName keeps a stale reference to the old method > version. > > The solution (suggested by John Rose) is to lazily create and keep > up-to-date a MemberNameTable > which plays a role of MemberName cache assosiated with the InstanceKlass. > Then, at the Class redefinition, this cache is used to replace the old > method > references in the MemberName's with the new method references. > > The MemberNameTable is based on the GrowableArray. > A C_HEAP array is allocated at the first call to > InstanceKlass::add_member_name(). > It is released in the InstanceKlass::release_C_heap_structures(). > > A global week reference to member name oop is stored in the > MemberNameTable. > It allowed to avoid having the oops_do() in the MemberNameTable. > Also, the MemberNameTable won't hold member name oops in memory. > > The MemberNameTable_lock mutex is added to serialize MemberNameTable's > updates. > > The following No_Safepoint_Verifier has been disabled: > * src/share/vm/prims/methodHandles.cpp*: > 799 int MethodHandles::find_MemberNames(Klass* k, > . . . > 803 DEBUG_ONLY(No_Safepoint_Verifier nsv); > It is probably Ok, but, please, let me know if it is not. > The assert related to locking is fired if it is not disabled. > > Test coverage: vm.mlvm, nsk.jvmti, nsk.jdi tests on multiple platforms > (32 vs 64-bit too). > The testing looks good so far. > > > Thanks, > Serguei > > From coleen.phillimore at oracle.com Mon Apr 1 13:12:35 2013 From: coleen.phillimore at oracle.com (Coleen Phillimore) Date: Mon, 01 Apr 2013 16:12:35 -0400 Subject: hs25 review request: 8007037 JSR 292: the VM_RedefineClasses::append_entry() should do cross-checks with indy operands In-Reply-To: <51538480.4010504@oracle.com> References: <51538480.4010504@oracle.com> Message-ID: <5159EA33.8040009@oracle.com> Hi Serguei, I was going to review this one too but it looks like the same as the last one. Is the webrev the wrong repository? thanks, Coleen On 03/27/2013 07:45 PM, serguei.spitsyn at oracle.com wrote: > Please, review the hs25 fix below. > > Open webrev: > http://cr.openjdk.java.net/~sspitsyn/webrevs/2013/hotspot/8007037-JVMTI-JSR292.1/ > > CR: > http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=8007037 > https://jbs.oracle.com/bugs/browse/JDK-8007037 > > > References from INDY bootstrap method specifier operands to CP entries > and back must be correctly merged at class redefinition. > > Some background. > > An invokedynamic bytecode spec: > http://docs.oracle.com/javase/specs/jvms/se7/html/jvms-6.html#jvms-6.5.invokedynamic > > A invokedynamic instruction has an argument which is an index to the > *Constant Pool* item. > That index must be a symbolic reference to a *call-site specifier*: > http://docs.oracle.com/javase/specs/jvms/se7/html/jvms-4.html#jvms-4.4.10 > > A CP item of the type *CONSTANT_InvokeDynamic_inf* has an index into > the *bootstrap method attribute* of the class file: > http://docs.oracle.com/javase/specs/jvms/se7/html/jvms-4.html#jvms-4.7.21 > > The *|BootstrapMethods|* attribute elements normally have references > to other *Constant Pool* items. > > In VM the *bootstrap method attribute* is represented by the > *operands* array of the *ConstantPool*. > > The problem is is that all the force and back cross links between > *ConstantPool* elements > and *operands* array elements must be correctly merged at class > redefinition. > > Test coverage: > vm.mlvm, nsk.jvmti, nsk.jdi tests on multiple platforms (32 vs > 64-bit too). > The testing looks good so far. > One difficulty is that new vm.mlvm tests are currently failed > because of multiple reasons. > > > Thanks, > Serguei > > From serguei.spitsyn at oracle.com Mon Apr 1 14:23:37 2013 From: serguei.spitsyn at oracle.com (serguei.spitsyn at oracle.com) Date: Mon, 01 Apr 2013 14:23:37 -0700 Subject: hs25 review request: 8007037 JSR 292: the VM_RedefineClasses::append_entry() should do cross-checks with indy operands In-Reply-To: <5159EA33.8040009@oracle.com> References: <51538480.4010504@oracle.com> <5159EA33.8040009@oracle.com> Message-ID: <5159FAD9.2090704@oracle.com> Hi Coleen, Thank you a lot for looking at it and noticing this problem! The link as you see it is correct: http://cr.openjdk.java.net/~sspitsyn/webrevs/2013/hotspot/8007037-JVMTI-JSR292.1/ but the hidden (underlying) link is incorrect: http://cr.openjdk.java.net/~sspitsyn/webrevs/2013/hotspot/8008511-JVMTI-JSR292.1/ This happened when I copy-pasted the fragment from my previous review request and replaced it with the new one. As occurred, the the underlying link was not replaced as expected when I edited this way. I'll be more careful in the future. Thanks, Serguei On 4/1/13 1:12 PM, Coleen Phillimore wrote: > > Hi Serguei, > I was going to review this one too but it looks like the same as the > last one. Is the webrev the wrong repository? > thanks, > Coleen > > On 03/27/2013 07:45 PM, serguei.spitsyn at oracle.com wrote: >> Please, review the hs25 fix below. >> >> Open webrev: >> http://cr.openjdk.java.net/~sspitsyn/webrevs/2013/hotspot/8007037-JVMTI-JSR292.1/ >> >> CR: >> http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=8007037 >> https://jbs.oracle.com/bugs/browse/JDK-8007037 >> >> >> References from INDY bootstrap method specifier operands to CP entries >> and back must be correctly merged at class redefinition. >> >> Some background. >> >> An invokedynamic bytecode spec: >> http://docs.oracle.com/javase/specs/jvms/se7/html/jvms-6.html#jvms-6.5.invokedynamic >> >> A invokedynamic instruction has an argument which is an index to the >> *Constant Pool* item. >> That index must be a symbolic reference to a *call-site specifier*: >> http://docs.oracle.com/javase/specs/jvms/se7/html/jvms-4.html#jvms-4.4.10 >> >> A CP item of the type *CONSTANT_InvokeDynamic_inf* has an index into >> the *bootstrap method attribute* of the class file: >> http://docs.oracle.com/javase/specs/jvms/se7/html/jvms-4.html#jvms-4.7.21 >> >> The *|BootstrapMethods|* attribute elements normally have references >> to other *Constant Pool* items. >> >> In VM the *bootstrap method attribute* is represented by the >> *operands* array of the *ConstantPool*. >> >> The problem is is that all the force and back cross links between >> *ConstantPool* elements >> and *operands* array elements must be correctly merged at class >> redefinition. >> >> Test coverage: >> vm.mlvm, nsk.jvmti, nsk.jdi tests on multiple platforms (32 vs >> 64-bit too). >> The testing looks good so far. >> One difficulty is that new vm.mlvm tests are currently failed >> because of multiple reasons. >> >> >> Thanks, >> Serguei >> >> > From serguei.spitsyn at oracle.com Mon Apr 1 14:29:43 2013 From: serguei.spitsyn at oracle.com (serguei.spitsyn at oracle.com) Date: Mon, 01 Apr 2013 14:29:43 -0700 Subject: hs25 review request: 8007037 JSR 292: the VM_RedefineClasses::append_entry() should do cross-checks with indy operands (webrev link corrected) In-Reply-To: <51538480.4010504@oracle.com> References: <51538480.4010504@oracle.com> Message-ID: <5159FC47.8040409@oracle.com> Resending this request because the webrev link below is incorrect. It is correct as you see it but its reference is incorrect when you click. This is a correct link (safe to click): http://cr.openjdk.java.net/~sspitsyn/webrevs/2013/hotspot/8007037-JVMTI-JSR292.1/ Thanks, Serguei On 3/27/13 4:45 PM, serguei.spitsyn at oracle.com wrote: > Please, review the hs25 fix below. > > Open webrev: > http://cr.openjdk.java.net/~sspitsyn/webrevs/2013/hotspot/8007037-JVMTI-JSR292.1/ > > CR: > http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=8007037 > https://jbs.oracle.com/bugs/browse/JDK-8007037 > > > References from INDY bootstrap method specifier operands to CP entries > and back must be correctly merged at class redefinition. > > Some background. > > An invokedynamic bytecode spec: > http://docs.oracle.com/javase/specs/jvms/se7/html/jvms-6.html#jvms-6.5.invokedynamic > > A invokedynamic instruction has an argument which is an index to the > *Constant Pool* item. > That index must be a symbolic reference to a *call-site specifier*: > http://docs.oracle.com/javase/specs/jvms/se7/html/jvms-4.html#jvms-4.4.10 > > A CP item of the type *CONSTANT_InvokeDynamic_inf* has an index into > the *bootstrap method attribute* of the class file: > http://docs.oracle.com/javase/specs/jvms/se7/html/jvms-4.html#jvms-4.7.21 > > The *|BootstrapMethods|* attribute elements normally have references > to other *Constant Pool* items. > > In VM the *bootstrap method attribute* is represented by the > *operands* array of the *ConstantPool*. > > The problem is is that all the force and back cross links between > *ConstantPool* elements > and *operands* array elements must be correctly merged at class > redefinition. > > Test coverage: > vm.mlvm, nsk.jvmti, nsk.jdi tests on multiple platforms (32 vs > 64-bit too). > The testing looks good so far. > One difficulty is that new vm.mlvm tests are currently failed > because of multiple reasons. > > > Thanks, > Serguei > > From serguei.spitsyn at oracle.com Mon Apr 1 14:37:29 2013 From: serguei.spitsyn at oracle.com (serguei.spitsyn at oracle.com) Date: Mon, 01 Apr 2013 14:37:29 -0700 Subject: hs25 review request: 8007037 JSR 292: the VM_RedefineClasses::append_entry() should do cross-checks with indy operands (webrev link corrected) In-Reply-To: <5159FC47.8040409@oracle.com> References: <51538480.4010504@oracle.com> <5159FC47.8040409@oracle.com> Message-ID: <5159FE19.30208@oracle.com> The referenced CR links were incorrect as well. The correct links: CR: http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=8007037 https://jbs.oracle.com/bugs/browse/JDK-8007037 Webrev: http://cr.openjdk.java.net/~sspitsyn/webrevs/2013/hotspot/8007037-JVMTI-JSR292.1/ Thanks, Serguei On 4/1/13 2:29 PM, serguei.spitsyn at oracle.com wrote: > Resending this request because the webrev link below is incorrect. > It is correct as you see it but its reference is incorrect when you > click. > > This is a correct link (safe to click): > http://cr.openjdk.java.net/~sspitsyn/webrevs/2013/hotspot/8007037-JVMTI-JSR292.1/ > > > Thanks, > Serguei > > > On 3/27/13 4:45 PM, serguei.spitsyn at oracle.com wrote: >> Please, review the hs25 fix below. >> >> Open webrev: >> http://cr.openjdk.java.net/~sspitsyn/webrevs/2013/hotspot/8007037-JVMTI-JSR292.1/ >> >> >> CR: >> http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=8007037 >> https://jbs.oracle.com/bugs/browse/JDK-8007037 >> >> >> References from INDY bootstrap method specifier operands to CP entries >> and back must be correctly merged at class redefinition. >> >> Some background. >> >> An invokedynamic bytecode spec: >> http://docs.oracle.com/javase/specs/jvms/se7/html/jvms-6.html#jvms-6.5.invokedynamic >> >> >> A invokedynamic instruction has an argument which is an index to the >> *Constant Pool* item. >> That index must be a symbolic reference to a *call-site specifier*: >> http://docs.oracle.com/javase/specs/jvms/se7/html/jvms-4.html#jvms-4.4.10 >> >> >> A CP item of the type *CONSTANT_InvokeDynamic_inf* has an index into >> the *bootstrap method attribute* of the class file: >> http://docs.oracle.com/javase/specs/jvms/se7/html/jvms-4.html#jvms-4.7.21 >> >> >> The *|BootstrapMethods|* attribute elements normally have references >> to other *Constant Pool* items. >> >> In VM the *bootstrap method attribute* is represented by the >> *operands* array of the *ConstantPool*. >> >> The problem is is that all the force and back cross links between >> *ConstantPool* elements >> and *operands* array elements must be correctly merged at class >> redefinition. >> >> Test coverage: >> vm.mlvm, nsk.jvmti, nsk.jdi tests on multiple platforms (32 vs >> 64-bit too). >> The testing looks good so far. >> One difficulty is that new vm.mlvm tests are currently failed >> because of multiple reasons. >> >> >> Thanks, >> Serguei >> >> > From serguei.spitsyn at oracle.com Mon Apr 1 15:02:35 2013 From: serguei.spitsyn at oracle.com (serguei.spitsyn at oracle.com) Date: Mon, 01 Apr 2013 15:02:35 -0700 Subject: hs25 review request: 8008511 JSR 292: MemberName vmtarget refs to methods must be updated at class redefinition In-Reply-To: <5159E95E.2030705@oracle.com> References: <513E8B88.6070904@oracle.com> <51515E3C.7040307@oracle.com> <5159E95E.2030705@oracle.com> Message-ID: <515A03FB.30808@oracle.com> On 4/1/13 1:09 PM, Coleen Phillimore wrote: > > Hi Serguei, > > Sorry for the delay in reviewing this. > > In instanceKlass.cpp line 2730, can you make that mtClass since it's > part of class metadata? Fixed. Thank you for the catch! > > In methodHandles.cpp, I think the whole member name table mechanism > could be protected by #if INCLUDE_JVMTI since it's not needed unless > you have jvmti built in the vm. And you don't need to call > add_method_handle() or just have it do JVMTI_RETURN or something for > the minimal vm. My understanding was that John is considering to use the MemberNameTable in the future for the compilation purposes. However, I can temporarily place it under #if INCLUDE_JVMTI until the compiler team decides what to do with it. > > Also, I think you should consider a global table rather than one per > class. I think we discussed this and may have decided that speed of > adding these is important, but depending on how many are actually used > per class, there's one pointer per class. I thought we've reached a consensus and decided to add MNT pointer per class as it is performance sensitive for indy calls. Anyway, before changing it to a hashtable I'd want to hear from John and Christian first. > Maybe they could be organized as a hashtable instead like the method > handle intrinsics? > > The code itself looks good everywhere, except for the concern about > footprint. I very appreciate you found a time to review it! There are not many people having an expertize in this area. Thanks, Serguei > > Thanks, > Coleen > > Can you make this mtClass on line > On 03/26/2013 04:37 AM, serguei.spitsyn at oracle.com wrote: >> >> Please, review the following fix. >> The fix was preliminarily reviewed by Coleen, Christian >> and John but still a final and open jdk review is needed. >> So that, everyone is welcome to review the fix! >> >> This is open webrev: >> http://cr.openjdk.java.net/~sspitsyn/webrevs/2013/hotspot/8008511-JVMTI-JSR292.1/ >> >> The CR is: >> http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=8008511 >> https://jbs.oracle.com/bugs/browse/JDK-8008511 >> >> >> The problem is that the old version of the bootstrap method is re-invoked >> after a popframe from the bootstrap method execution. >> It is because the MemberName keeps a stale reference to the old >> method version. >> >> The solution (suggested by John Rose) is to lazily create and keep >> up-to-date a MemberNameTable >> which plays a role of MemberName cache assosiated with the InstanceKlass. >> Then, at the Class redefinition, this cache is used to replace the >> old method >> references in the MemberName's with the new method references. >> >> The MemberNameTable is based on the GrowableArray. >> A C_HEAP array is allocated at the first call to >> InstanceKlass::add_member_name(). >> It is released in the InstanceKlass::release_C_heap_structures(). >> >> A global week reference to member name oop is stored in the >> MemberNameTable. >> It allowed to avoid having the oops_do() in the MemberNameTable. >> Also, the MemberNameTable won't hold member name oops in memory. >> >> The MemberNameTable_lock mutex is added to serialize >> MemberNameTable's updates. >> >> The following No_Safepoint_Verifier has been disabled: >> * src/share/vm/prims/methodHandles.cpp*: >> 799 int MethodHandles::find_MemberNames(Klass* k, >> . . . >> 803 DEBUG_ONLY(No_Safepoint_Verifier nsv); >> It is probably Ok, but, please, let me know if it is not. >> The assert related to locking is fired if it is not disabled. >> >> Test coverage: vm.mlvm, nsk.jvmti, nsk.jdi tests on multiple >> platforms (32 vs 64-bit too). >> The testing looks good so far. >> >> >> Thanks, >> Serguei >> >> > From coleen.phillimore at oracle.com Mon Apr 1 15:51:12 2013 From: coleen.phillimore at oracle.com (Coleen Phillimore) Date: Mon, 01 Apr 2013 18:51:12 -0400 Subject: hs25 review request: 8008511 JSR 292: MemberName vmtarget refs to methods must be updated at class redefinition In-Reply-To: <515A03FB.30808@oracle.com> References: <513E8B88.6070904@oracle.com> <51515E3C.7040307@oracle.com> <5159E95E.2030705@oracle.com> <515A03FB.30808@oracle.com> Message-ID: <515A0F60.1040105@oracle.com> On 04/01/2013 06:02 PM, serguei.spitsyn at oracle.com wrote: > On 4/1/13 1:09 PM, Coleen Phillimore wrote: >> >> Hi Serguei, >> >> Sorry for the delay in reviewing this. >> >> In instanceKlass.cpp line 2730, can you make that mtClass since it's >> part of class metadata? > > Fixed. > Thank you for the catch! >> >> In methodHandles.cpp, I think the whole member name table mechanism >> could be protected by #if INCLUDE_JVMTI since it's not needed unless >> you have jvmti built in the vm. And you don't need to call >> add_method_handle() or just have it do JVMTI_RETURN or something for >> the minimal vm. > > My understanding was that John is considering to use the > MemberNameTable in the future for the compilation purposes. > However, I can temporarily place it under #if INCLUDE_JVMTI > until the compiler team decides what to do with it. > >> >> Also, I think you should consider a global table rather than one per >> class. I think we discussed this and may have decided that speed of >> adding these is important, but depending on how many are actually >> used per class, there's one pointer per class. > > I thought we've reached a consensus and decided to add MNT pointer > per class as it is performance sensitive for indy calls. > Anyway, before changing it to a hashtable I'd want to hear from John > and Christian first. Definitely would like to hear from John and Christian. We did discuss it but I wasn't totally convinced this field is more important than the others that were going to be moved out of Klass* to make it smaller. Some statistics for some sample applications like eclipse would be great. Coleen > >> Maybe they could be organized as a hashtable instead like the method >> handle intrinsics? >> >> The code itself looks good everywhere, except for the concern about >> footprint. > > I very appreciate you found a time to review it! > There are not many people having an expertize in this area. > > > Thanks, > Serguei > >> >> Thanks, >> Coleen >> >> Can you make this mtClass on line >> On 03/26/2013 04:37 AM, serguei.spitsyn at oracle.com wrote: >>> >>> Please, review the following fix. >>> The fix was preliminarily reviewed by Coleen, Christian >>> and John but still a final and open jdk review is needed. >>> So that, everyone is welcome to review the fix! >>> >>> This is open webrev: >>> http://cr.openjdk.java.net/~sspitsyn/webrevs/2013/hotspot/8008511-JVMTI-JSR292.1/ >>> >>> The CR is: >>> http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=8008511 >>> https://jbs.oracle.com/bugs/browse/JDK-8008511 >>> >>> >>> The problem is that the old version of the bootstrap method is >>> re-invoked >>> after a popframe from the bootstrap method execution. >>> It is because the MemberName keeps a stale reference to the old >>> method version. >>> >>> The solution (suggested by John Rose) is to lazily create and keep >>> up-to-date a MemberNameTable >>> which plays a role of MemberName cache assosiated with the >>> InstanceKlass. >>> Then, at the Class redefinition, this cache is used to replace the >>> old method >>> references in the MemberName's with the new method references. >>> >>> The MemberNameTable is based on the GrowableArray. >>> A C_HEAP array is allocated at the first call to >>> InstanceKlass::add_member_name(). >>> It is released in the InstanceKlass::release_C_heap_structures(). >>> >>> A global week reference to member name oop is stored in the >>> MemberNameTable. >>> It allowed to avoid having the oops_do() in the MemberNameTable. >>> Also, the MemberNameTable won't hold member name oops in memory. >>> >>> The MemberNameTable_lock mutex is added to serialize >>> MemberNameTable's updates. >>> >>> The following No_Safepoint_Verifier has been disabled: >>> * src/share/vm/prims/methodHandles.cpp*: >>> 799 int MethodHandles::find_MemberNames(Klass* k, >>> . . . >>> 803 DEBUG_ONLY(No_Safepoint_Verifier nsv); >>> It is probably Ok, but, please, let me know if it is not. >>> The assert related to locking is fired if it is not disabled. >>> >>> Test coverage: vm.mlvm, nsk.jvmti, nsk.jdi tests on multiple >>> platforms (32 vs 64-bit too). >>> The testing looks good so far. >>> >>> >>> Thanks, >>> Serguei >>> >>> >> > From erik.helin at oracle.com Tue Apr 2 09:19:06 2013 From: erik.helin at oracle.com (erik.helin at oracle.com) Date: Tue, 02 Apr 2013 16:19:06 +0000 Subject: hg: hsx/hsx24/hotspot: 8010294: Refactor HeapInspection to make it more reusable Message-ID: <20130402161914.DE6CC48532@hg.openjdk.java.net> Changeset: 4a6facbffc09 Author: ehelin Date: 2013-03-21 16:15 +0100 URL: http://hg.openjdk.java.net/hsx/hsx24/hotspot/rev/4a6facbffc09 8010294: Refactor HeapInspection to make it more reusable Reviewed-by: jwilhelm, brutisso, mgerdin ! src/share/vm/memory/heapInspection.cpp ! src/share/vm/memory/heapInspection.hpp + test/gc/heap_inspection/TestPrintClassHistogram.java From serguei.spitsyn at oracle.com Tue Apr 2 10:02:15 2013 From: serguei.spitsyn at oracle.com (serguei.spitsyn at oracle.com) Date: Tue, 02 Apr 2013 10:02:15 -0700 Subject: hs25 review request: 8008511 JSR 292: MemberName vmtarget refs to methods must be updated at class redefinition In-Reply-To: <515A0F60.1040105@oracle.com> References: <513E8B88.6070904@oracle.com> <51515E3C.7040307@oracle.com> <5159E95E.2030705@oracle.com> <515A03FB.30808@oracle.com> <515A0F60.1040105@oracle.com> Message-ID: <515B0F17.5040803@oracle.com> On 4/1/13 3:51 PM, Coleen Phillimore wrote: > > On 04/01/2013 06:02 PM, serguei.spitsyn at oracle.com wrote: >> On 4/1/13 1:09 PM, Coleen Phillimore wrote: >>> >>> Hi Serguei, >>> >>> Sorry for the delay in reviewing this. >>> >>> In instanceKlass.cpp line 2730, can you make that mtClass since it's >>> part of class metadata? >> >> Fixed. >> Thank you for the catch! >>> >>> In methodHandles.cpp, I think the whole member name table mechanism >>> could be protected by #if INCLUDE_JVMTI since it's not needed unless >>> you have jvmti built in the vm. And you don't need to call >>> add_method_handle() or just have it do JVMTI_RETURN or something for >>> the minimal vm. >> >> My understanding was that John is considering to use the >> MemberNameTable in the future for the compilation purposes. >> However, I can temporarily place it under #if INCLUDE_JVMTI >> until the compiler team decides what to do with it. >> >>> >>> Also, I think you should consider a global table rather than one per >>> class. I think we discussed this and may have decided that speed of >>> adding these is important, but depending on how many are actually >>> used per class, there's one pointer per class. >> >> I thought we've reached a consensus and decided to add MNT pointer >> per class as it is performance sensitive for indy calls. >> Anyway, before changing it to a hashtable I'd want to hear from John >> and Christian first. > > Definitely would like to hear from John and Christian. We did > discuss it but I wasn't totally convinced this field is more important > than the others that were going to be moved out of Klass* to make it > smaller. Some statistics for some sample applications like eclipse > would be great. I'm not sure what statistics do you mean here. Do you mean a footprint or performance statistics? As I understand from our previous discussion there can be a more general solution for the footprint issue. As such we could attack the footprint problem separately. For instance, we could separate all JVMTI fields from InstanceKlass and initialize them lazily. But I'd not want to go deep into this discussion. You do not want me to get involved into the footprint work, do you? :) Also, the decision how to represent the MNT depends on its future usage by the compiler team. As we agreed, the compiler team is going to adjust the MNT to their needs at some point when it is more convenient for them. So that, could we make a final decision when the whole picture is ready? It would be better to approach it in some steps. Currently, this bug blocks other work on the JVMTI support of jsr-292. Thanks, Serguei > > Coleen > >> >>> Maybe they could be organized as a hashtable instead like the method >>> handle intrinsics? >>> >>> The code itself looks good everywhere, except for the concern about >>> footprint. >> >> I very appreciate you found a time to review it! >> There are not many people having an expertize in this area. >> >> >> Thanks, >> Serguei >> >>> >>> Thanks, >>> Coleen >>> >>> Can you make this mtClass on line >>> On 03/26/2013 04:37 AM, serguei.spitsyn at oracle.com wrote: >>>> >>>> Please, review the following fix. >>>> The fix was preliminarily reviewed by Coleen, Christian >>>> and John but still a final and open jdk review is needed. >>>> So that, everyone is welcome to review the fix! >>>> >>>> This is open webrev: >>>> http://cr.openjdk.java.net/~sspitsyn/webrevs/2013/hotspot/8008511-JVMTI-JSR292.1/ >>>> >>>> The CR is: >>>> http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=8008511 >>>> https://jbs.oracle.com/bugs/browse/JDK-8008511 >>>> >>>> >>>> The problem is that the old version of the bootstrap method is >>>> re-invoked >>>> after a popframe from the bootstrap method execution. >>>> It is because the MemberName keeps a stale reference to the old >>>> method version. >>>> >>>> The solution (suggested by John Rose) is to lazily create and keep >>>> up-to-date a MemberNameTable >>>> which plays a role of MemberName cache assosiated with the >>>> InstanceKlass. >>>> Then, at the Class redefinition, this cache is used to replace the >>>> old method >>>> references in the MemberName's with the new method references. >>>> >>>> The MemberNameTable is based on the GrowableArray. >>>> A C_HEAP array is allocated at the first call to >>>> InstanceKlass::add_member_name(). >>>> It is released in the InstanceKlass::release_C_heap_structures(). >>>> >>>> A global week reference to member name oop is stored in the >>>> MemberNameTable. >>>> It allowed to avoid having the oops_do() in the MemberNameTable. >>>> Also, the MemberNameTable won't hold member name oops in memory. >>>> >>>> The MemberNameTable_lock mutex is added to serialize >>>> MemberNameTable's updates. >>>> >>>> The following No_Safepoint_Verifier has been disabled: >>>> * src/share/vm/prims/methodHandles.cpp*: >>>> 799 int MethodHandles::find_MemberNames(Klass* k, >>>> . . . >>>> 803 DEBUG_ONLY(No_Safepoint_Verifier nsv); >>>> It is probably Ok, but, please, let me know if it is not. >>>> The assert related to locking is fired if it is not disabled. >>>> >>>> Test coverage: vm.mlvm, nsk.jvmti, nsk.jdi tests on multiple >>>> platforms (32 vs 64-bit too). >>>> The testing looks good so far. >>>> >>>> >>>> Thanks, >>>> Serguei >>>> >>>> >>> >> > From xerox.time.tech at gmail.com Tue Apr 2 11:24:32 2013 From: xerox.time.tech at gmail.com (Xin Tong) Date: Tue, 2 Apr 2013 14:24:32 -0400 Subject: get method information Message-ID: In the jump_from_interpreted code. I have a method in a Register. I think this is a manifestation of the java method in memory. What is the correct way to get the properties of the method, e.g., the number of arguments in the method and the type of the arguments, etc. void InterpreterMacroAssembler::jump_from_interpreted(Register method, Register temp) { prepare_to_jump_from_interpreted(); ... } Thank you, Xin From coleen.phillimore at oracle.com Tue Apr 2 11:58:33 2013 From: coleen.phillimore at oracle.com (Coleen Phillimore) Date: Tue, 02 Apr 2013 14:58:33 -0400 Subject: CFV: New HSX Committer: Ioi Lam Message-ID: <515B2A59.6060500@oracle.com> I hereby nominate Ioi Lam (OpenJDK user name: iklam) to HSX Committer. Ioi is a member of the Hotspot runtime group. He is currently investigating Application Class Data Sharing and footprint reduction. He has contributed 8 changesets to the HSX project and he is qualified to be committer [1]: http://hg.openjdk.java.net/hsx/hotspot-main/hotspot/log?rev=ioi.lam at oracle.com http://hg.openjdk.java.net/hsx/hotspot-main/hotspot/log?rev=iklam Votes are due by April 16, 2013. Only current HSX Committers [2] are eligible to vote on this nomination. Votes must be cast in the open by replying to this mailing list. For Lazy Consensus voting instructions, see [3]. Thanks, Coleen Phillimore [1]http://openjdk.java.net/projects/#project-committer [2]http://openjdk.java.net/census#hsx [3]http://openjdk.java.net/projects#committer-vote From daniel.daugherty at oracle.com Tue Apr 2 12:15:11 2013 From: daniel.daugherty at oracle.com (Daniel D. Daugherty) Date: Tue, 02 Apr 2013 13:15:11 -0600 Subject: CFV: New HSX Committer: Ioi Lam In-Reply-To: <515B2A59.6060500@oracle.com> References: <515B2A59.6060500@oracle.com> Message-ID: <515B2E3F.6080201@oracle.com> Yes. Dan On 4/2/13 12:58 PM, Coleen Phillimore wrote: > I hereby nominate Ioi Lam (OpenJDK user name: iklam) to HSX Committer. > > Ioi is a member of the Hotspot runtime group. He is currently > investigating Application Class Data Sharing and footprint reduction. > He has contributed 8 changesets to the HSX project and he is qualified > to be committer [1]: > > http://hg.openjdk.java.net/hsx/hotspot-main/hotspot/log?rev=ioi.lam at oracle.com > > http://hg.openjdk.java.net/hsx/hotspot-main/hotspot/log?rev=iklam > > Votes are due by April 16, 2013. > > Only current HSX Committers [2] are eligible to vote on this > nomination. Votes must be cast in the open by replying to this > mailing list. > > For Lazy Consensus voting instructions, see [3]. > > Thanks, > Coleen Phillimore > > [1]http://openjdk.java.net/projects/#project-committer > [2]http://openjdk.java.net/census#hsx > [3]http://openjdk.java.net/projects#committer-vote > From vladimir.kozlov at oracle.com Tue Apr 2 12:20:57 2013 From: vladimir.kozlov at oracle.com (Vladimir Kozlov) Date: Tue, 02 Apr 2013 12:20:57 -0700 Subject: CFV: New HSX Committer: Ioi Lam In-Reply-To: <515B2A59.6060500@oracle.com> References: <515B2A59.6060500@oracle.com> Message-ID: <515B2F99.90702@oracle.com> Vote: yes Vladimir On 4/2/13 11:58 AM, Coleen Phillimore wrote: > I hereby nominate Ioi Lam (OpenJDK user name: iklam) to HSX Committer. > > Ioi is a member of the Hotspot runtime group. He is currently > investigating Application Class Data Sharing and footprint reduction. He > has contributed 8 changesets to the HSX project and he is qualified to > be committer [1]: > > http://hg.openjdk.java.net/hsx/hotspot-main/hotspot/log?rev=ioi.lam at oracle.com > > http://hg.openjdk.java.net/hsx/hotspot-main/hotspot/log?rev=iklam > > Votes are due by April 16, 2013. > > Only current HSX Committers [2] are eligible to vote on this > nomination. Votes must be cast in the open by replying to this mailing > list. > > For Lazy Consensus voting instructions, see [3]. > > Thanks, > Coleen Phillimore > > [1]http://openjdk.java.net/projects/#project-committer > [2]http://openjdk.java.net/census#hsx > [3]http://openjdk.java.net/projects#committer-vote > From bengt.rutisson at oracle.com Tue Apr 2 12:27:07 2013 From: bengt.rutisson at oracle.com (Bengt Rutisson) Date: Tue, 02 Apr 2013 21:27:07 +0200 Subject: CFV: New HSX Committer: Ioi Lam In-Reply-To: <515B2A59.6060500@oracle.com> References: <515B2A59.6060500@oracle.com> Message-ID: <515B310B.9030107@oracle.com> Vote: yes Bengt On 4/2/13 8:58 PM, Coleen Phillimore wrote: > I hereby nominate Ioi Lam (OpenJDK user name: iklam) to HSX Committer. > > Ioi is a member of the Hotspot runtime group. He is currently > investigating Application Class Data Sharing and footprint reduction. > He has contributed 8 changesets to the HSX project and he is qualified > to be committer [1]: > > http://hg.openjdk.java.net/hsx/hotspot-main/hotspot/log?rev=ioi.lam at oracle.com > > http://hg.openjdk.java.net/hsx/hotspot-main/hotspot/log?rev=iklam > > Votes are due by April 16, 2013. > > Only current HSX Committers [2] are eligible to vote on this > nomination. Votes must be cast in the open by replying to this > mailing list. > > For Lazy Consensus voting instructions, see [3]. > > Thanks, > Coleen Phillimore > > [1]http://openjdk.java.net/projects/#project-committer > [2]http://openjdk.java.net/census#hsx > [3]http://openjdk.java.net/projects#committer-vote > From zhengyu.gu at oracle.com Tue Apr 2 12:33:48 2013 From: zhengyu.gu at oracle.com (Zhengyu Gu) Date: Tue, 02 Apr 2013 15:33:48 -0400 Subject: CFV: New HSX Committer: Ioi Lam In-Reply-To: <515B2A59.6060500@oracle.com> References: <515B2A59.6060500@oracle.com> Message-ID: <515B329C.1010405@oracle.com> Vote: yes -Zhengyu On 4/2/2013 2:58 PM, Coleen Phillimore wrote: > I hereby nominate Ioi Lam (OpenJDK user name: iklam) to HSX Committer. > > Ioi is a member of the Hotspot runtime group. He is currently > investigating Application Class Data Sharing and footprint reduction. > He has contributed 8 changesets to the HSX project and he is qualified > to be committer [1]: > > http://hg.openjdk.java.net/hsx/hotspot-main/hotspot/log?rev=ioi.lam at oracle.com > > http://hg.openjdk.java.net/hsx/hotspot-main/hotspot/log?rev=iklam > > Votes are due by April 16, 2013. > > Only current HSX Committers [2] are eligible to vote on this > nomination. Votes must be cast in the open by replying to this > mailing list. > > For Lazy Consensus voting instructions, see [3]. > > Thanks, > Coleen Phillimore > > [1]http://openjdk.java.net/projects/#project-committer > [2]http://openjdk.java.net/census#hsx > [3]http://openjdk.java.net/projects#committer-vote > From jiangli.zhou at oracle.com Tue Apr 2 12:38:03 2013 From: jiangli.zhou at oracle.com (Jiangli Zhou) Date: Tue, 02 Apr 2013 12:38:03 -0700 Subject: CFV: New HSX Committer: Ioi Lam In-Reply-To: <515B2A59.6060500@oracle.com> References: <515B2A59.6060500@oracle.com> Message-ID: <515B339B.2090107@oracle.com> Vote: yes Jiangli On 04/02/2013 11:58 AM, Coleen Phillimore wrote: > I hereby nominate Ioi Lam (OpenJDK user name: iklam) to HSX Committer. > > Ioi is a member of the Hotspot runtime group. He is currently > investigating Application Class Data Sharing and footprint reduction. > He has contributed 8 changesets to the HSX project and he is qualified > to be committer [1]: > > http://hg.openjdk.java.net/hsx/hotspot-main/hotspot/log?rev=ioi.lam at oracle.com > > http://hg.openjdk.java.net/hsx/hotspot-main/hotspot/log?rev=iklam > > Votes are due by April 16, 2013. > > Only current HSX Committers [2] are eligible to vote on this > nomination. Votes must be cast in the open by replying to this > mailing list. > > For Lazy Consensus voting instructions, see [3]. > > Thanks, > Coleen Phillimore > > [1]http://openjdk.java.net/projects/#project-committer > [2]http://openjdk.java.net/census#hsx > [3]http://openjdk.java.net/projects#committer-vote > From dean.long at oracle.com Tue Apr 2 13:31:29 2013 From: dean.long at oracle.com (Dean Long) Date: Tue, 02 Apr 2013 13:31:29 -0700 Subject: CFV: New HSX Committer: Ioi Lam In-Reply-To: <515B2A59.6060500@oracle.com> References: <515B2A59.6060500@oracle.com> Message-ID: <515B4021.4060901@oracle.com> Vote: yes dl On 4/2/2013 11:58 AM, Coleen Phillimore wrote: > I hereby nominate Ioi Lam (OpenJDK user name: iklam) to HSX Committer. > > Ioi is a member of the Hotspot runtime group. He is currently > investigating Application Class Data Sharing and footprint reduction. > He has contributed 8 changesets to the HSX project and he is qualified > to be committer [1]: > > http://hg.openjdk.java.net/hsx/hotspot-main/hotspot/log?rev=ioi.lam at oracle.com > > http://hg.openjdk.java.net/hsx/hotspot-main/hotspot/log?rev=iklam > > Votes are due by April 16, 2013. > > Only current HSX Committers [2] are eligible to vote on this > nomination. Votes must be cast in the open by replying to this > mailing list. > > For Lazy Consensus voting instructions, see [3]. > > Thanks, > Coleen Phillimore > > [1]http://openjdk.java.net/projects/#project-committer > [2]http://openjdk.java.net/census#hsx > [3]http://openjdk.java.net/projects#committer-vote > From coleen.phillimore at oracle.com Tue Apr 2 13:45:14 2013 From: coleen.phillimore at oracle.com (Coleen Phillimore) Date: Tue, 02 Apr 2013 16:45:14 -0400 Subject: CFV: New HSX Committer: Ioi Lam In-Reply-To: <515B2A59.6060500@oracle.com> References: <515B2A59.6060500@oracle.com> Message-ID: <515B435A.8060404@oracle.com> Vote: yes On 04/02/2013 02:58 PM, Coleen Phillimore wrote: > I hereby nominate Ioi Lam (OpenJDK user name: iklam) to HSX Committer. > > Ioi is a member of the Hotspot runtime group. He is currently > investigating Application Class Data Sharing and footprint reduction. > He has contributed 8 changesets to the HSX project and he is qualified > to be committer [1]: > > http://hg.openjdk.java.net/hsx/hotspot-main/hotspot/log?rev=ioi.lam at oracle.com > > http://hg.openjdk.java.net/hsx/hotspot-main/hotspot/log?rev=iklam > > Votes are due by April 16, 2013. > > Only current HSX Committers [2] are eligible to vote on this > nomination. Votes must be cast in the open by replying to this > mailing list. > > For Lazy Consensus voting instructions, see [3]. > > Thanks, > Coleen Phillimore > > [1]http://openjdk.java.net/projects/#project-committer > [2]http://openjdk.java.net/census#hsx > [3]http://openjdk.java.net/projects#committer-vote > From karen.kinnear at oracle.com Tue Apr 2 13:51:18 2013 From: karen.kinnear at oracle.com (Karen Kinnear) Date: Tue, 2 Apr 2013 16:51:18 -0400 Subject: CFV: New HSX Committer: Ioi Lam In-Reply-To: <515B2A59.6060500@oracle.com> References: <515B2A59.6060500@oracle.com> Message-ID: Vote: yes On Apr 2, 2013, at 2:58 PM, Coleen Phillimore wrote: > I hereby nominate Ioi Lam (OpenJDK user name: iklam) to HSX Committer. > > Ioi is a member of the Hotspot runtime group. He is currently investigating Application Class Data Sharing and footprint reduction. He has contributed 8 changesets to the HSX project and he is qualified to be committer [1]: > > http://hg.openjdk.java.net/hsx/hotspot-main/hotspot/log?rev=ioi.lam at oracle.com > http://hg.openjdk.java.net/hsx/hotspot-main/hotspot/log?rev=iklam > > Votes are due by April 16, 2013. > > Only current HSX Committers [2] are eligible to vote on this nomination. Votes must be cast in the open by replying to this mailing list. > > For Lazy Consensus voting instructions, see [3]. > > Thanks, > Coleen Phillimore > > [1]http://openjdk.java.net/projects/#project-committer > [2]http://openjdk.java.net/census#hsx > [3]http://openjdk.java.net/projects#committer-vote > From coleen.phillimore at oracle.com Tue Apr 2 14:09:07 2013 From: coleen.phillimore at oracle.com (Coleen Phillimore) Date: Tue, 02 Apr 2013 17:09:07 -0400 Subject: hs25 review request: 8008511 JSR 292: MemberName vmtarget refs to methods must be updated at class redefinition In-Reply-To: <515B0F17.5040803@oracle.com> References: <513E8B88.6070904@oracle.com> <51515E3C.7040307@oracle.com> <5159E95E.2030705@oracle.com> <515A03FB.30808@oracle.com> <515A0F60.1040105@oracle.com> <515B0F17.5040803@oracle.com> Message-ID: <515B48F3.4040706@oracle.com> On 04/02/2013 01:02 PM, serguei.spitsyn at oracle.com wrote: > On 4/1/13 3:51 PM, Coleen Phillimore wrote: >> >> On 04/01/2013 06:02 PM, serguei.spitsyn at oracle.com wrote: >>> On 4/1/13 1:09 PM, Coleen Phillimore wrote: >>>> >>>> Hi Serguei, >>>> >>>> Sorry for the delay in reviewing this. >>>> >>>> In instanceKlass.cpp line 2730, can you make that mtClass since >>>> it's part of class metadata? >>> >>> Fixed. >>> Thank you for the catch! >>>> >>>> In methodHandles.cpp, I think the whole member name table mechanism >>>> could be protected by #if INCLUDE_JVMTI since it's not needed >>>> unless you have jvmti built in the vm. And you don't need to call >>>> add_method_handle() or just have it do JVMTI_RETURN or something >>>> for the minimal vm. >>> >>> My understanding was that John is considering to use the >>> MemberNameTable in the future for the compilation purposes. >>> However, I can temporarily place it under #if INCLUDE_JVMTI >>> until the compiler team decides what to do with it. >>> >>>> >>>> Also, I think you should consider a global table rather than one >>>> per class. I think we discussed this and may have decided that >>>> speed of adding these is important, but depending on how many are >>>> actually used per class, there's one pointer per class. >>> >>> I thought we've reached a consensus and decided to add MNT pointer >>> per class as it is performance sensitive for indy calls. >>> Anyway, before changing it to a hashtable I'd want to hear from John >>> and Christian first. >> >> Definitely would like to hear from John and Christian. We did >> discuss it but I wasn't totally convinced this field is more >> important than the others that were going to be moved out of Klass* >> to make it smaller. Some statistics for some sample applications >> like eclipse would be great. > > I'm not sure what statistics do you mean here. > Do you mean a footprint or performance statistics? > > As I understand from our previous discussion there can be a more > general solution for the footprint issue. > As such we could attack the footprint problem separately. Yes, there are more general solutions to the footprint issue. One would be moving these JVMTI fields and initializing them lazily and there are other footprint improvements. One additional improvement would be to remove this field which will be mostly zero and put this in a hashtable and not allocate it per class. > For instance, we could separate all JVMTI fields from InstanceKlass > and initialize them lazily. > But I'd not want to go deep into this discussion. > You do not want me to get involved into the footprint work, do you? :) > > Also, the decision how to represent the MNT depends on its future > usage by the compiler team. > As we agreed, the compiler team is going to adjust the MNT to their needs > at some point when it is more convenient for them. > So that, could we make a final decision when the whole picture is ready? > It would be better to approach it in some steps. > Currently, this bug blocks other work on the JVMTI support of jsr-292. I don't know what the jsr 292 team has in store for this field but it's still a footprint cost that's for only a special case. So this is okay if you file a bug so that we can remove it and reimplement this table to be global or a hashtable. Coleen > > Thanks, > Serguei > >> >> Coleen >> >>> >>>> Maybe they could be organized as a hashtable instead like the >>>> method handle intrinsics? >>>> >>>> The code itself looks good everywhere, except for the concern about >>>> footprint. >>> >>> I very appreciate you found a time to review it! >>> There are not many people having an expertize in this area. >>> >>> >>> Thanks, >>> Serguei >>> >>>> >>>> Thanks, >>>> Coleen >>>> >>>> Can you make this mtClass on line >>>> On 03/26/2013 04:37 AM, serguei.spitsyn at oracle.com wrote: >>>>> >>>>> Please, review the following fix. >>>>> The fix was preliminarily reviewed by Coleen, Christian >>>>> and John but still a final and open jdk review is needed. >>>>> So that, everyone is welcome to review the fix! >>>>> >>>>> This is open webrev: >>>>> http://cr.openjdk.java.net/~sspitsyn/webrevs/2013/hotspot/8008511-JVMTI-JSR292.1/ >>>>> >>>>> The CR is: >>>>> http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=8008511 >>>>> https://jbs.oracle.com/bugs/browse/JDK-8008511 >>>>> >>>>> >>>>> The problem is that the old version of the bootstrap method is >>>>> re-invoked >>>>> after a popframe from the bootstrap method execution. >>>>> It is because the MemberName keeps a stale reference to the old >>>>> method version. >>>>> >>>>> The solution (suggested by John Rose) is to lazily create and keep >>>>> up-to-date a MemberNameTable >>>>> which plays a role of MemberName cache assosiated with the >>>>> InstanceKlass. >>>>> Then, at the Class redefinition, this cache is used to replace the >>>>> old method >>>>> references in the MemberName's with the new method references. >>>>> >>>>> The MemberNameTable is based on the GrowableArray. >>>>> A C_HEAP array is allocated at the first call to >>>>> InstanceKlass::add_member_name(). >>>>> It is released in the InstanceKlass::release_C_heap_structures(). >>>>> >>>>> A global week reference to member name oop is stored in the >>>>> MemberNameTable. >>>>> It allowed to avoid having the oops_do() in the MemberNameTable. >>>>> Also, the MemberNameTable won't hold member name oops in memory. >>>>> >>>>> The MemberNameTable_lock mutex is added to serialize >>>>> MemberNameTable's updates. >>>>> >>>>> The following No_Safepoint_Verifier has been disabled: >>>>> * src/share/vm/prims/methodHandles.cpp*: >>>>> 799 int MethodHandles::find_MemberNames(Klass* k, >>>>> . . . >>>>> 803 DEBUG_ONLY(No_Safepoint_Verifier nsv); >>>>> It is probably Ok, but, please, let me know if it is not. >>>>> The assert related to locking is fired if it is not disabled. >>>>> >>>>> Test coverage: vm.mlvm, nsk.jvmti, nsk.jdi tests on multiple >>>>> platforms (32 vs 64-bit too). >>>>> The testing looks good so far. >>>>> >>>>> >>>>> Thanks, >>>>> Serguei >>>>> >>>>> >>>> >>> >> > From christian.thalinger at oracle.com Tue Apr 2 14:16:32 2013 From: christian.thalinger at oracle.com (Christian Thalinger) Date: Tue, 2 Apr 2013 14:16:32 -0700 Subject: get method information In-Reply-To: References: Message-ID: On Apr 2, 2013, at 11:24 AM, Xin Tong wrote: > In the jump_from_interpreted code. I have a method in a Register. I think > this is a manifestation of the java method in memory. What is the correct > way to get the properties of the method, e.g., the number of arguments in > the method and the type of the arguments, etc. The answer is in method.hpp (class Method). -- Chris > > void InterpreterMacroAssembler::jump_from_interpreted(Register method, > Register temp) { > > prepare_to_jump_from_interpreted(); > > ... > } > > Thank you, > Xin From daniel.daugherty at oracle.com Tue Apr 2 13:39:48 2013 From: daniel.daugherty at oracle.com (Daniel D. Daugherty) Date: Tue, 02 Apr 2013 14:39:48 -0600 Subject: CFV: New HSX Committer: Ioi Lam In-Reply-To: <515B2A59.6060500@oracle.com> References: <515B2A59.6060500@oracle.com> Message-ID: <515B4214.2070005@oracle.com> Vote: yes Resending in the correct format... sigh... Dan On 4/2/13 12:58 PM, Coleen Phillimore wrote: > I hereby nominate Ioi Lam (OpenJDK user name: iklam) to HSX Committer. > > Ioi is a member of the Hotspot runtime group. He is currently > investigating Application Class Data Sharing and footprint reduction. > He has contributed 8 changesets to the HSX project and he is qualified > to be committer [1]: > > http://hg.openjdk.java.net/hsx/hotspot-main/hotspot/log?rev=ioi.lam at oracle.com > > http://hg.openjdk.java.net/hsx/hotspot-main/hotspot/log?rev=iklam > > Votes are due by April 16, 2013. > > Only current HSX Committers [2] are eligible to vote on this > nomination. Votes must be cast in the open by replying to this > mailing list. > > For Lazy Consensus voting instructions, see [3]. > > Thanks, > Coleen Phillimore > > [1]http://openjdk.java.net/projects/#project-committer > [2]http://openjdk.java.net/census#hsx > [3]http://openjdk.java.net/projects#committer-vote > From serguei.spitsyn at oracle.com Tue Apr 2 14:26:41 2013 From: serguei.spitsyn at oracle.com (serguei.spitsyn at oracle.com) Date: Tue, 02 Apr 2013 14:26:41 -0700 Subject: hs25 review request: 8008511 JSR 292: MemberName vmtarget refs to methods must be updated at class redefinition In-Reply-To: <515B48F3.4040706@oracle.com> References: <513E8B88.6070904@oracle.com> <51515E3C.7040307@oracle.com> <5159E95E.2030705@oracle.com> <515A03FB.30808@oracle.com> <515A0F60.1040105@oracle.com> <515B0F17.5040803@oracle.com> <515B48F3.4040706@oracle.com> Message-ID: <515B4D11.6070402@oracle.com> On 4/2/13 2:09 PM, Coleen Phillimore wrote: > > On 04/02/2013 01:02 PM, serguei.spitsyn at oracle.com wrote: >> On 4/1/13 3:51 PM, Coleen Phillimore wrote: >>> >>> On 04/01/2013 06:02 PM, serguei.spitsyn at oracle.com wrote: >>>> On 4/1/13 1:09 PM, Coleen Phillimore wrote: >>>>> >>>>> Hi Serguei, >>>>> >>>>> Sorry for the delay in reviewing this. >>>>> >>>>> In instanceKlass.cpp line 2730, can you make that mtClass since >>>>> it's part of class metadata? >>>> >>>> Fixed. >>>> Thank you for the catch! >>>>> >>>>> In methodHandles.cpp, I think the whole member name table >>>>> mechanism could be protected by #if INCLUDE_JVMTI since it's not >>>>> needed unless you have jvmti built in the vm. And you don't need >>>>> to call add_method_handle() or just have it do JVMTI_RETURN or >>>>> something for the minimal vm. >>>> >>>> My understanding was that John is considering to use the >>>> MemberNameTable in the future for the compilation purposes. >>>> However, I can temporarily place it under #if INCLUDE_JVMTI >>>> until the compiler team decides what to do with it. >>>> >>>>> >>>>> Also, I think you should consider a global table rather than one >>>>> per class. I think we discussed this and may have decided that >>>>> speed of adding these is important, but depending on how many are >>>>> actually used per class, there's one pointer per class. >>>> >>>> I thought we've reached a consensus and decided to add MNT pointer >>>> per class as it is performance sensitive for indy calls. >>>> Anyway, before changing it to a hashtable I'd want to hear from >>>> John and Christian first. >>> >>> Definitely would like to hear from John and Christian. We did >>> discuss it but I wasn't totally convinced this field is more >>> important than the others that were going to be moved out of Klass* >>> to make it smaller. Some statistics for some sample applications >>> like eclipse would be great. >> >> I'm not sure what statistics do you mean here. >> Do you mean a footprint or performance statistics? >> >> As I understand from our previous discussion there can be a more >> general solution for the footprint issue. >> As such we could attack the footprint problem separately. > > Yes, there are more general solutions to the footprint issue. One > would be moving these JVMTI fields and initializing them lazily and > there are other footprint improvements. One additional improvement > would be to remove this field which will be mostly zero and put this > in a hashtable and not allocate it per class. > >> For instance, we could separate all JVMTI fields from InstanceKlass >> and initialize them lazily. >> But I'd not want to go deep into this discussion. >> You do not want me to get involved into the footprint work, do you? :) >> >> Also, the decision how to represent the MNT depends on its future >> usage by the compiler team. >> As we agreed, the compiler team is going to adjust the MNT to their needs >> at some point when it is more convenient for them. >> So that, could we make a final decision when the whole picture is ready? >> It would be better to approach it in some steps. >> Currently, this bug blocks other work on the JVMTI support of jsr-292. > > I don't know what the jsr 292 team has in store for this field but > it's still a footprint cost that's for only a special case. So this > is okay if you file a bug so that we can remove it and reimplement > this table to be global or a hashtable. Ok, I'll file a bug on the footprint issue and attach it to the next round of review. Thanks, Coleen! Serguei > > Coleen > >> >> Thanks, >> Serguei >> >>> >>> Coleen >>> >>>> >>>>> Maybe they could be organized as a hashtable instead like the >>>>> method handle intrinsics? >>>>> >>>>> The code itself looks good everywhere, except for the concern >>>>> about footprint. >>>> >>>> I very appreciate you found a time to review it! >>>> There are not many people having an expertize in this area. >>>> >>>> >>>> Thanks, >>>> Serguei >>>> >>>>> >>>>> Thanks, >>>>> Coleen >>>>> >>>>> Can you make this mtClass on line >>>>> On 03/26/2013 04:37 AM, serguei.spitsyn at oracle.com wrote: >>>>>> >>>>>> Please, review the following fix. >>>>>> The fix was preliminarily reviewed by Coleen, Christian >>>>>> and John but still a final and open jdk review is needed. >>>>>> So that, everyone is welcome to review the fix! >>>>>> >>>>>> This is open webrev: >>>>>> http://cr.openjdk.java.net/~sspitsyn/webrevs/2013/hotspot/8008511-JVMTI-JSR292.1/ >>>>>> >>>>>> The CR is: >>>>>> http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=8008511 >>>>>> https://jbs.oracle.com/bugs/browse/JDK-8008511 >>>>>> >>>>>> >>>>>> The problem is that the old version of the bootstrap method is >>>>>> re-invoked >>>>>> after a popframe from the bootstrap method execution. >>>>>> It is because the MemberName keeps a stale reference to the old >>>>>> method version. >>>>>> >>>>>> The solution (suggested by John Rose) is to lazily create and >>>>>> keep up-to-date a MemberNameTable >>>>>> which plays a role of MemberName cache assosiated with the >>>>>> InstanceKlass. >>>>>> Then, at the Class redefinition, this cache is used to replace >>>>>> the old method >>>>>> references in the MemberName's with the new method references. >>>>>> >>>>>> The MemberNameTable is based on the GrowableArray. >>>>>> A C_HEAP array is allocated at the first call to >>>>>> InstanceKlass::add_member_name(). >>>>>> It is released in the InstanceKlass::release_C_heap_structures(). >>>>>> >>>>>> A global week reference to member name oop is stored in the >>>>>> MemberNameTable. >>>>>> It allowed to avoid having the oops_do() in the MemberNameTable. >>>>>> Also, the MemberNameTable won't hold member name oops in memory. >>>>>> >>>>>> The MemberNameTable_lock mutex is added to serialize >>>>>> MemberNameTable's updates. >>>>>> >>>>>> The following No_Safepoint_Verifier has been disabled: >>>>>> * src/share/vm/prims/methodHandles.cpp*: >>>>>> 799 int MethodHandles::find_MemberNames(Klass* k, >>>>>> . . . >>>>>> 803 DEBUG_ONLY(No_Safepoint_Verifier nsv); >>>>>> It is probably Ok, but, please, let me know if it is not. >>>>>> The assert related to locking is fired if it is not disabled. >>>>>> >>>>>> Test coverage: vm.mlvm, nsk.jvmti, nsk.jdi tests on multiple >>>>>> platforms (32 vs 64-bit too). >>>>>> The testing looks good so far. >>>>>> >>>>>> >>>>>> Thanks, >>>>>> Serguei >>>>>> >>>>>> >>>>> >>>> >>> >> > From serguei.spitsyn at oracle.com Tue Apr 2 14:31:28 2013 From: serguei.spitsyn at oracle.com (serguei.spitsyn at oracle.com) Date: Tue, 02 Apr 2013 14:31:28 -0700 Subject: CFV: New HSX Committer: Ioi Lam In-Reply-To: <515B2A59.6060500@oracle.com> References: <515B2A59.6060500@oracle.com> Message-ID: <515B4E30.2020409@oracle.com> Vote: yes Serguei On 4/2/13 11:58 AM, Coleen Phillimore wrote: > I hereby nominate Ioi Lam (OpenJDK user name: iklam) to HSX Committer. > > Ioi is a member of the Hotspot runtime group. He is currently > investigating Application Class Data Sharing and footprint reduction. > He has contributed 8 changesets to the HSX project and he is qualified > to be committer [1]: > > http://hg.openjdk.java.net/hsx/hotspot-main/hotspot/log?rev=ioi.lam at oracle.com > > http://hg.openjdk.java.net/hsx/hotspot-main/hotspot/log?rev=iklam > > Votes are due by April 16, 2013. > > Only current HSX Committers [2] are eligible to vote on this > nomination. Votes must be cast in the open by replying to this > mailing list. > > For Lazy Consensus voting instructions, see [3]. > > Thanks, > Coleen Phillimore > > [1]http://openjdk.java.net/projects/#project-committer > [2]http://openjdk.java.net/census#hsx > [3]http://openjdk.java.net/projects#committer-vote > From alejandro.murillo at oracle.com Tue Apr 2 15:02:54 2013 From: alejandro.murillo at oracle.com (Alejandro E Murillo) Date: Tue, 02 Apr 2013 16:02:54 -0600 Subject: CFV: New HSX Committer: Ioi Lam In-Reply-To: <515B2A59.6060500@oracle.com> References: <515B2A59.6060500@oracle.com> Message-ID: <515B558E.6060600@oracle.com> vote: yes -- Alejandro From coleen.phillimore at oracle.com Tue Apr 2 15:45:35 2013 From: coleen.phillimore at oracle.com (Coleen Phillimore) Date: Tue, 02 Apr 2013 18:45:35 -0400 Subject: hs25 review request: 8007037 JSR 292: the VM_RedefineClasses::append_entry() should do cross-checks with indy operands In-Reply-To: <51538480.4010504@oracle.com> References: <51538480.4010504@oracle.com> Message-ID: <515B5F8F.4000605@oracle.com> Hi Serguei, This looks good from how much I understand of these two things. There is one problem that I found though. In ConstantPool::extend_operands() and shrink_operands() when you allocate a new Array* and assign it to the from_cp, you have to explicitly deallocate the operands that were there with MetadataFactory::free_array() or they will leak. This isn't true if you backport this code to 7u. Thanks, Coleen On 03/27/2013 07:45 PM, serguei.spitsyn at oracle.com wrote: > Please, review the hs25 fix below. > > Open webrev: > http://cr.openjdk.java.net/~sspitsyn/webrevs/2013/hotspot/8007037-JVMTI-JSR292.1/ > > CR: > http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=8007037 > https://jbs.oracle.com/bugs/browse/JDK-8007037 > > > References from INDY bootstrap method specifier operands to CP entries > and back must be correctly merged at class redefinition. > > Some background. > > An invokedynamic bytecode spec: > http://docs.oracle.com/javase/specs/jvms/se7/html/jvms-6.html#jvms-6.5.invokedynamic > > A invokedynamic instruction has an argument which is an index to the > *Constant Pool* item. > That index must be a symbolic reference to a *call-site specifier*: > http://docs.oracle.com/javase/specs/jvms/se7/html/jvms-4.html#jvms-4.4.10 > > A CP item of the type *CONSTANT_InvokeDynamic_inf* has an index into > the *bootstrap method attribute* of the class file: > http://docs.oracle.com/javase/specs/jvms/se7/html/jvms-4.html#jvms-4.7.21 > > The *|BootstrapMethods|* attribute elements normally have references > to other *Constant Pool* items. > > In VM the *bootstrap method attribute* is represented by the > *operands* array of the *ConstantPool*. > > The problem is is that all the force and back cross links between > *ConstantPool* elements > and *operands* array elements must be correctly merged at class > redefinition. > > Test coverage: > vm.mlvm, nsk.jvmti, nsk.jdi tests on multiple platforms (32 vs > 64-bit too). > The testing looks good so far. > One difficulty is that new vm.mlvm tests are currently failed > because of multiple reasons. > > > Thanks, > Serguei > > From serguei.spitsyn at oracle.com Tue Apr 2 17:07:30 2013 From: serguei.spitsyn at oracle.com (serguei.spitsyn at oracle.com) Date: Tue, 02 Apr 2013 17:07:30 -0700 Subject: hs25 review request: 8007037 JSR 292: the VM_RedefineClasses::append_entry() should do cross-checks with indy operands In-Reply-To: <515B5F8F.4000605@oracle.com> References: <51538480.4010504@oracle.com> <515B5F8F.4000605@oracle.com> Message-ID: <515B72C2.5040208@oracle.com> Hi Coleen, Again, thank you a lot for reviewing this code! This is a good catch too, thank you for pointing to it. BTW, I was thinking that this probably must be explicitly deallocated but at some point lost my focus. :) Thanks! Serguei On 4/2/13 3:45 PM, Coleen Phillimore wrote: > > Hi Serguei, > > This looks good from how much I understand of these two things. There > is one problem that I found though. In > ConstantPool::extend_operands() and shrink_operands() when you > allocate a new Array* and assign it to the from_cp, you have to > explicitly deallocate the operands that were there with > MetadataFactory::free_array() or they will leak. This isn't true > if you backport this code to 7u. > > Thanks, > Coleen > > On 03/27/2013 07:45 PM, serguei.spitsyn at oracle.com wrote: >> Please, review the hs25 fix below. >> >> Open webrev: >> http://cr.openjdk.java.net/~sspitsyn/webrevs/2013/hotspot/8007037-JVMTI-JSR292.1/ >> >> CR: >> http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=8007037 >> https://jbs.oracle.com/bugs/browse/JDK-8007037 >> >> >> References from INDY bootstrap method specifier operands to CP entries >> and back must be correctly merged at class redefinition. >> >> Some background. >> >> An invokedynamic bytecode spec: >> http://docs.oracle.com/javase/specs/jvms/se7/html/jvms-6.html#jvms-6.5.invokedynamic >> >> A invokedynamic instruction has an argument which is an index to the >> *Constant Pool* item. >> That index must be a symbolic reference to a *call-site specifier*: >> http://docs.oracle.com/javase/specs/jvms/se7/html/jvms-4.html#jvms-4.4.10 >> >> A CP item of the type *CONSTANT_InvokeDynamic_inf* has an index into >> the *bootstrap method attribute* of the class file: >> http://docs.oracle.com/javase/specs/jvms/se7/html/jvms-4.html#jvms-4.7.21 >> >> The *|BootstrapMethods|* attribute elements normally have references >> to other *Constant Pool* items. >> >> In VM the *bootstrap method attribute* is represented by the >> *operands* array of the *ConstantPool*. >> >> The problem is is that all the force and back cross links between >> *ConstantPool* elements >> and *operands* array elements must be correctly merged at class >> redefinition. >> >> Test coverage: >> vm.mlvm, nsk.jvmti, nsk.jdi tests on multiple platforms (32 vs >> 64-bit too). >> The testing looks good so far. >> One difficulty is that new vm.mlvm tests are currently failed >> because of multiple reasons. >> >> >> Thanks, >> Serguei >> >> > From vladimir.kozlov at oracle.com Tue Apr 2 17:31:49 2013 From: vladimir.kozlov at oracle.com (vladimir.kozlov at oracle.com) Date: Wed, 03 Apr 2013 00:31:49 +0000 Subject: hg: hsx/hsx24/hotspot: 8004640: C2 assert failure in memnode.cpp: NULL+offs not RAW address Message-ID: <20130403003154.7A8EC48567@hg.openjdk.java.net> Changeset: c0b1bfa39232 Author: kvn Date: 2013-03-26 12:55 -0700 URL: http://hg.openjdk.java.net/hsx/hsx24/hotspot/rev/c0b1bfa39232 8004640: C2 assert failure in memnode.cpp: NULL+offs not RAW address Summary: always transform AddP nodes in IdealKit by calling _gvn.transform(). Reviewed-by: roland, twisti ! src/share/vm/opto/graphKit.cpp ! src/share/vm/opto/idealKit.cpp ! src/share/vm/opto/idealKit.hpp ! src/share/vm/opto/loopnode.cpp ! src/share/vm/opto/phaseX.cpp From john.r.rose at oracle.com Tue Apr 2 22:42:11 2013 From: john.r.rose at oracle.com (John Rose) Date: Tue, 2 Apr 2013 22:42:11 -0700 Subject: CFV: New HSX Committer: Ioi Lam In-Reply-To: <515B2A59.6060500@oracle.com> References: <515B2A59.6060500@oracle.com> Message-ID: <7E001672-E00D-4A29-8545-42839F4B58EF@oracle.com> Vote: yes From vladimir.x.ivanov at oracle.com Tue Apr 2 23:16:05 2013 From: vladimir.x.ivanov at oracle.com (Vladimir Ivanov) Date: Wed, 03 Apr 2013 10:16:05 +0400 Subject: CFV: New HSX Committer: Ioi Lam In-Reply-To: <515B2A59.6060500@oracle.com> References: <515B2A59.6060500@oracle.com> Message-ID: <515BC925.1060303@oracle.com> Vote: yes Best regards, Vladimir Ivanov On 4/2/13 10:58 PM, Coleen Phillimore wrote: > I hereby nominate Ioi Lam (OpenJDK user name: iklam) to HSX Committer. > > Ioi is a member of the Hotspot runtime group. He is currently > investigating Application Class Data Sharing and footprint reduction. He > has contributed 8 changesets to the HSX project and he is qualified to > be committer [1]: > > http://hg.openjdk.java.net/hsx/hotspot-main/hotspot/log?rev=ioi.lam at oracle.com > > http://hg.openjdk.java.net/hsx/hotspot-main/hotspot/log?rev=iklam > > Votes are due by April 16, 2013. > > Only current HSX Committers [2] are eligible to vote on this > nomination. Votes must be cast in the open by replying to this mailing > list. > > For Lazy Consensus voting instructions, see [3]. > > Thanks, > Coleen Phillimore > > [1]http://openjdk.java.net/projects/#project-committer > [2]http://openjdk.java.net/census#hsx > [3]http://openjdk.java.net/projects#committer-vote > From david.holmes at oracle.com Wed Apr 3 00:30:23 2013 From: david.holmes at oracle.com (David Holmes) Date: Wed, 03 Apr 2013 17:30:23 +1000 Subject: RFR: 8003310: Enable -Wunused when compiling with GCC In-Reply-To: <51547282.6090005@oracle.com> References: <50A1C598.4050904@oracle.com> <50A1DEE5.8090606@oracle.com> <50A24E00.3070200@oracle.com> <50A25720.1040405@oracle.com> <50A59010.5040001@oracle.com> <510C18F6.6010305@oracle.com> <511DAB26.2010808@oracle.com> <511DB3E0.6030606@oracle.com> <5122B5C3.1010908@oracle.com> <0153EC9C-4474-4B54-B215-6BE7BF2A7E1B@oracle.com> <512508DE.70904@oracle.com> <51251015.5000501@oracle.com> <51267CE4.6090104@oracle.com> <5126E2FE.9060200@oracle.com> <51547282.6090005@oracle.com> Message-ID: <515BDA8F.6070108@oracle.com> Sorry for the delay. Ship it! (As seems to be the new catch-cry ;-) ) David On 29/03/2013 2:40 AM, Mikael Vidstedt wrote: > > I've been waiting for Joe's changes to bubble up so as to not add a > conflict unnecessarily, and since they're now in hotspot-rt I have > uploaded a webrev for what I hope is a final time *knocking on wood*. I > would appreciate a quick check to see that everything still looks fine: > > http://cr.openjdk.java.net/~mikael/webrevs/8003310/webrev.08/webrev/ > > The only relevant changes from the last webrev should be: > > make/linux/makefiles/gcc.make: > > * Eliminate the ADDITIONAL_WARNINGS variable and just use WARNING_FLAGS > directly > * Clean up the -Wconversion logic > > src/share/vm/runtime/arguments.cpp: > > * Updated after the recent changes to SERIAL/INCLUDE_ALL_GCS (8005915) > > Thanks, > Mikael > > On 2/21/2013 7:16 PM, David Holmes wrote: >> One final comment - please liaise with Joe Provino who is adding >> -Wundef so we can get a consistent approach as to where these -Wxxx >> flags get added. :) >> >> >> (Don't know what I was looking at with the trace_locking stuff - it >> ends up as an empty method.) >> >> David >> >> On 22/02/2013 6:00 AM, Mikael Vidstedt wrote: >>> >>> On 2013-02-20 10:04, Coleen Phillimore wrote: >>>> On 2/20/2013 12:33 PM, Mikael Vidstedt wrote: >>>>> >>>>> On 2/19/2013 12:01 PM, Christian Thalinger wrote: >>>>>> On Feb 18, 2013, at 3:14 PM, Mikael Vidstedt >>>>>> wrote: >>>>>> >>>>>>> A really good control question, thanks a lot for asking! >>>>>>> >>>>>>> As a matter of fact these changes are basically just doing what the >>>>>>> compiler already does for us, so it's more about cleaning up the >>>>>>> source code than reducing the size of the binary. So in theory >>>>>>> these changes should have no impact on the binary size at all, but >>>>>>> it actually turns out they do. Very specifically, the fact that I >>>>>>> moved the same_page() function from being duplicated in the three >>>>>>> os_.cpp files to having it be in globalDefinitions.cpp makes >>>>>>> the binary grow a few bytes (54 bytes to be specific). The reason >>>>>>> is a bit subtle: >>>>>>> >>>>>>> The same_page() function is (was) static in the respective os_*.cpp >>>>>>> files. They are only ever used when the Verbose flag is true, and >>>>>>> furthermore the Verbose option is a develop only flag, which means >>>>>>> it is hardcoded to false in product. The compiler knows that's the >>>>>>> case and eliminates the same_page() function completely. >>>>>>> >>>>>>> Since I moved it to globalDefinitions.cpp there's no way easy for >>>>>>> the compiler to know that it is not being used, so it will actually >>>>>>> keep the function. >>>>>>> >>>>>>> Unless there are strong opinions I'm not going to do anything about >>>>>>> this. >>>>>>> >>>>>>> However, this made me question my earlier experiments with using >>>>>>> the const bool = false construct in constantPool.cpp, because after >>>>>>> all that is the exact same pattern. And it turns out that I must >>>>>>> have done something wrong when I was performing the experiments, >>>>>>> because when I do the same thing again now it turns out the >>>>>>> compiler actually *does* deadcode eliminate the debug-only >>>>>>> functions. So I take everything back and conclude that const bool = >>>>>>> false is indeed a great way to make sure the debug code does not >>>>>>> rot over time, and that the product binary will *not* contain the >>>>>>> dead functions. Sorry for any confusion this may have caused. >>>>>>> >>>>>>> With all that in mind, here's another version of the webrev: >>>>>>> >>>>>>> http://cr.openjdk.java.net/~mikael/webrevs/8003310/webrev04/webrev/ >>>>>> src/share/vm/interpreter/interpreterRuntime.cpp: >>>>>> >>>>>> I suppose that #if 0 is to keep that code for...? Could we add a >>>>>> comment why we keep it? >>>>> >>>>> This was by "popular request" (from David Holmes) :) >>>>> >>>>> I personally don't know if and how this is being used. Note that >>>>> ObjectSynchronizer::trace_locking is PRODUCT_RETURN and the >>>>> non-product implementation in synchronizer.cpp is empty (modulo the >>>>> comment saying "Don't know what to do here"), so one can question the >>>>> value of keeping the any of the trace_locking functions, but they may >>>>> be someone's favorite debugging tool. Until proven differently I will >>>>> leave it in there for now. If somebody can help me provide a useful >>>>> comment about how the code is actually being used then I will >>>>> certainly add it, otherwise I'll keep this as it is. >>>> >>>> If I remember correctly, this trace_locking code was associated with a >>>> flag that we removed a long time ago. I don't think if we want to >>>> implement TraceLocking we'd use this function. My vote is that it and >>>> the ObjectMonitor:: version should be removed. >>> >>> Thanks Coleen, that makes sense. I've prepared a final version of the >>> webrev with the trace_locking methods removed too: >>> >>> http://cr.openjdk.java.net/~mikael/webrevs/8003310/webrev.06/webrev/ >>> >>> Any final comments? >>> >>> Cheers, >>> Mikael >>> >>>> >>>> Coleen >>>>> >>>>>> src/share/vm/oops/constantPool.cpp: >>>>>> >>>>>> So we use: >>>>>> >>>>>> + const bool debug_cpool = false; >>>>>> >>>>>> but we still have the DBG macro. Can't we have a static debug >>>>>> method that takes all printf arguments and prints them? The >>>>>> debug_cpool should make that method empty and the compiler can >>>>>> remove it. I really start to hate all these macros... >>>>> >>>>> I share your macro hate and I actually played around with removing >>>>> the macros just as you say. There is one small problem with doing it >>>>> that way, and that's the fact that a few of the printf:s print >>>>> symbols names, and as part of that they need to create utf8 strings >>>>> using sym->as_utf8(). The compiler can unfortunately not know that >>>>> that function is for all intents and purposes a no-op, so it will >>>>> keep the call even in product meaning increased binary size and it >>>>> will also add to the runtime since it actually performs the call and >>>>> creates the utf8 string. So I'm going to keep the macros for now. >>>>> >>>>> >>>>> I also moved the clamp_address_in_page to the globalDefinitions.hpp >>>>> header file, meaning it will be inlined and dead code eliminated. >>>>> >>>>> New webrev here: >>>>> >>>>> http://cr.openjdk.java.net/~mikael/webrevs/8003310/webrev.05/webrev/ >>>>> >>>>> Final comments? >>>>> >>>>> Cheers, >>>>> Mikael >>>>> >>>> >>> > From frederic.parain at oracle.com Wed Apr 3 01:27:04 2013 From: frederic.parain at oracle.com (Frederic Parain) Date: Wed, 03 Apr 2013 10:27:04 +0200 Subject: CFV: New HSX Committer: Ioi Lam In-Reply-To: <515B2A59.6060500@oracle.com> References: <515B2A59.6060500@oracle.com> Message-ID: <515BE7D8.7030304@oracle.com> Vote: yes Fred On 04/ 2/13 08:58 PM, Coleen Phillimore wrote: > I hereby nominate Ioi Lam (OpenJDK user name: iklam) to HSX Committer. > > Ioi is a member of the Hotspot runtime group. He is currently > investigating Application Class Data Sharing and footprint reduction. He > has contributed 8 changesets to the HSX project and he is qualified to > be committer [1]: > > http://hg.openjdk.java.net/hsx/hotspot-main/hotspot/log?rev=ioi.lam at oracle.com > > http://hg.openjdk.java.net/hsx/hotspot-main/hotspot/log?rev=iklam > > Votes are due by April 16, 2013. > > Only current HSX Committers [2] are eligible to vote on this > nomination. Votes must be cast in the open by replying to this mailing > list. > > For Lazy Consensus voting instructions, see [3]. > > Thanks, > Coleen Phillimore > > [1]http://openjdk.java.net/projects/#project-committer > [2]http://openjdk.java.net/census#hsx > [3]http://openjdk.java.net/projects#committer-vote > -- Frederic Parain - Oracle Grenoble Engineering Center - France Phone: +33 4 76 18 81 17 Email: Frederic.Parain at Oracle.com From staffan.larsen at oracle.com Wed Apr 3 03:59:54 2013 From: staffan.larsen at oracle.com (Staffan Larsen) Date: Wed, 3 Apr 2013 12:59:54 +0200 Subject: CFV: New HSX Committer: Ioi Lam In-Reply-To: <515B2A59.6060500@oracle.com> References: <515B2A59.6060500@oracle.com> Message-ID: <4A9DC820-C06E-4109-A5FC-1D3C87FC2366@oracle.com> Vote: yes On 2 apr 2013, at 20:58, Coleen Phillimore wrote: > I hereby nominate Ioi Lam (OpenJDK user name: iklam) to HSX Committer. > > Ioi is a member of the Hotspot runtime group. He is currently investigating Application Class Data Sharing and footprint reduction. He has contributed 8 changesets to the HSX project and he is qualified to be committer [1]: > > http://hg.openjdk.java.net/hsx/hotspot-main/hotspot/log?rev=ioi.lam at oracle.com > http://hg.openjdk.java.net/hsx/hotspot-main/hotspot/log?rev=iklam > > Votes are due by April 16, 2013. > > Only current HSX Committers [2] are eligible to vote on this nomination. Votes must be cast in the open by replying to this mailing list. > > For Lazy Consensus voting instructions, see [3]. > > Thanks, > Coleen Phillimore > > [1]http://openjdk.java.net/projects/#project-committer > [2]http://openjdk.java.net/census#hsx > [3]http://openjdk.java.net/projects#committer-vote > From stefan.karlsson at oracle.com Wed Apr 3 04:32:50 2013 From: stefan.karlsson at oracle.com (Stefan Karlsson) Date: Wed, 03 Apr 2013 13:32:50 +0200 Subject: CFV: New HSX Committer: Ioi Lam In-Reply-To: <515B2A59.6060500@oracle.com> References: <515B2A59.6060500@oracle.com> Message-ID: <515C1362.2080508@oracle.com> Vote: yes StefanK On 04/02/2013 08:58 PM, Coleen Phillimore wrote: > I hereby nominate Ioi Lam (OpenJDK user name: iklam) to HSX Committer. > > Ioi is a member of the Hotspot runtime group. He is currently > investigating Application Class Data Sharing and footprint reduction. > He has contributed 8 changesets to the HSX project and he is qualified > to be committer [1]: > > http://hg.openjdk.java.net/hsx/hotspot-main/hotspot/log?rev=ioi.lam at oracle.com > > http://hg.openjdk.java.net/hsx/hotspot-main/hotspot/log?rev=iklam > > Votes are due by April 16, 2013. > > Only current HSX Committers [2] are eligible to vote on this > nomination. Votes must be cast in the open by replying to this > mailing list. > > For Lazy Consensus voting instructions, see [3]. > > Thanks, > Coleen Phillimore > > [1]http://openjdk.java.net/projects/#project-committer > [2]http://openjdk.java.net/census#hsx > [3]http://openjdk.java.net/projects#committer-vote > From volker.simonis at gmail.com Wed Apr 3 05:11:30 2013 From: volker.simonis at gmail.com (Volker Simonis) Date: Wed, 3 Apr 2013 14:11:30 +0200 Subject: CFV: New HSX Committer: Ioi Lam In-Reply-To: <515B2A59.6060500@oracle.com> References: <515B2A59.6060500@oracle.com> Message-ID: Vote: yes On Tue, Apr 2, 2013 at 8:58 PM, Coleen Phillimore < coleen.phillimore at oracle.com> wrote: > I hereby nominate Ioi Lam (OpenJDK user name: iklam) to HSX Committer. > > Ioi is a member of the Hotspot runtime group. He is currently > investigating Application Class Data Sharing and footprint reduction. He > has contributed 8 changesets to the HSX project and he is qualified to be > committer [1]: > > http://hg.openjdk.java.net/**hsx/hotspot-main/hotspot/log?** > rev=ioi.lam at oracle.com > http://hg.openjdk.java.net/**hsx/hotspot-main/hotspot/log?**rev=iklam > > Votes are due by April 16, 2013. > > Only current HSX Committers [2] are eligible to vote on this nomination. > Votes must be cast in the open by replying to this mailing list. > > For Lazy Consensus voting instructions, see [3]. > > Thanks, > Coleen Phillimore > > [1]http://openjdk.java.net/**projects/#project-committer > [2]http://openjdk.java.net/**census#hsx > [3]http://openjdk.java.net/**projects#committer-vote > > From nils.loodin at oracle.com Wed Apr 3 05:13:40 2013 From: nils.loodin at oracle.com (Nils Loodin) Date: Wed, 03 Apr 2013 14:13:40 +0200 Subject: CFV: New HSX Committer: Ioi Lam In-Reply-To: <515C1362.2080508@oracle.com> References: <515B2A59.6060500@oracle.com> <515C1362.2080508@oracle.com> Message-ID: <515C1CF4.7080807@oracle.com> Vote: yes Nils Loodin On 04/03/2013 01:32 PM, Stefan Karlsson wrote: > Vote: yes > > StefanK > > On 04/02/2013 08:58 PM, Coleen Phillimore wrote: >> I hereby nominate Ioi Lam (OpenJDK user name: iklam) to HSX Committer. >> >> Ioi is a member of the Hotspot runtime group. He is currently >> investigating Application Class Data Sharing and footprint reduction. >> He has contributed 8 changesets to the HSX project and he is qualified >> to be committer [1]: >> >> http://hg.openjdk.java.net/hsx/hotspot-main/hotspot/log?rev=ioi.lam at oracle.com >> >> http://hg.openjdk.java.net/hsx/hotspot-main/hotspot/log?rev=iklam >> >> Votes are due by April 16, 2013. >> >> Only current HSX Committers [2] are eligible to vote on this >> nomination. Votes must be cast in the open by replying to this >> mailing list. >> >> For Lazy Consensus voting instructions, see [3]. >> >> Thanks, >> Coleen Phillimore >> >> [1]http://openjdk.java.net/projects/#project-committer >> [2]http://openjdk.java.net/census#hsx >> [3]http://openjdk.java.net/projects#committer-vote >> > From david.holmes at oracle.com Wed Apr 3 05:29:19 2013 From: david.holmes at oracle.com (David Holmes) Date: Wed, 03 Apr 2013 22:29:19 +1000 Subject: CFV: New HSX Committer: Ioi Lam In-Reply-To: <515B2A59.6060500@oracle.com> References: <515B2A59.6060500@oracle.com> Message-ID: <515C209F.4020909@oracle.com> Vote: yes David On 3/04/2013 4:58 AM, Coleen Phillimore wrote: > I hereby nominate Ioi Lam (OpenJDK user name: iklam) to HSX Committer. > > Ioi is a member of the Hotspot runtime group. He is currently > investigating Application Class Data Sharing and footprint reduction. He > has contributed 8 changesets to the HSX project and he is qualified to > be committer [1]: > > http://hg.openjdk.java.net/hsx/hotspot-main/hotspot/log?rev=ioi.lam at oracle.com > > http://hg.openjdk.java.net/hsx/hotspot-main/hotspot/log?rev=iklam > > Votes are due by April 16, 2013. > > Only current HSX Committers [2] are eligible to vote on this > nomination. Votes must be cast in the open by replying to this mailing > list. > > For Lazy Consensus voting instructions, see [3]. > > Thanks, > Coleen Phillimore > > [1]http://openjdk.java.net/projects/#project-committer > [2]http://openjdk.java.net/census#hsx > [3]http://openjdk.java.net/projects#committer-vote > From peter.allwin at oracle.com Wed Apr 3 09:16:52 2013 From: peter.allwin at oracle.com (Peter Allwin) Date: Wed, 03 Apr 2013 18:16:52 +0200 Subject: Review request: 6729929 I18N - Taking Heap Dump failed if project path contains multibyte characters Message-ID: <515C55F4.6020002@oracle.com> Webrev: http://cr.openjdk.java.net/~mgronlun/6729929/webrev01/ Bug: http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=6729929 Summary: When dumpHeap in the HotSpotDiagnostic JMX MBean is called, the filename parameter must be converted from jstring to char* to be used in open(). This was done using UTF-8 encoding which is incorrect as open() expects a platform dependent encoding according to the system locale. Fix is to use java_lang_String::as_platform_dependent_str to do the conversion. Thanks to Markus for advising and hosting the webrev! Regards, /peter From daniel.daugherty at oracle.com Wed Apr 3 20:23:17 2013 From: daniel.daugherty at oracle.com (daniel.daugherty at oracle.com) Date: Thu, 04 Apr 2013 03:23:17 +0000 Subject: hg: hsx/hotspot-main/hotspot: 16 new changesets Message-ID: <20130404032350.54915485B1@hg.openjdk.java.net> Changeset: 0c3ee6f1fa23 Author: coleenp Date: 2013-03-27 08:19 -0400 URL: http://hg.openjdk.java.net/hsx/hotspot-main/hotspot/rev/0c3ee6f1fa23 8009531: Crash when redefining class with annotated method Summary: Neglected to copy the annotations in clone_with_new_data when they were moved to ConstMethod. Reviewed-by: acorn, sspitsyn, dcubed ! src/share/vm/oops/constMethod.cpp ! src/share/vm/oops/constMethod.hpp ! src/share/vm/oops/method.cpp Changeset: aa758f0c5b1c Author: hseigel Date: 2013-03-27 11:41 -0400 URL: http://hg.openjdk.java.net/hsx/hotspot-main/hotspot/rev/aa758f0c5b1c 8010833: Test7116786.java is failing on most configs after fix for 8010667 Summary: Update test to recognize that non-zero pad bytes for lookupswitch/tablewsitch opcodes are now valid. Reviewed-by: dcubed, twisti, kvn, coleenp, dholmes ! test/runtime/7116786/Test7116786.java Changeset: b601102d00c8 Author: hseigel Date: 2013-03-27 13:26 -0700 URL: http://hg.openjdk.java.net/hsx/hotspot-main/hotspot/rev/b601102d00c8 Merge Changeset: cd3089a56438 Author: acorn Date: 2013-03-27 14:10 -0400 URL: http://hg.openjdk.java.net/hsx/hotspot-main/hotspot/rev/cd3089a56438 8009731: Confusing error message for loader constraint violation Summary: Fix text, overwritten type and holder for resolved method Reviewed-by: coleenp, dcubed, minqi, dholmes ! src/share/vm/classfile/systemDictionary.cpp ! src/share/vm/classfile/systemDictionary.hpp ! src/share/vm/interpreter/linkResolver.cpp ! src/share/vm/oops/klassVtable.cpp Changeset: 53f4040e809c Author: acorn Date: 2013-03-27 16:31 -0700 URL: http://hg.openjdk.java.net/hsx/hotspot-main/hotspot/rev/53f4040e809c Merge Changeset: b5bae74160b7 Author: zgu Date: 2013-03-27 15:41 -0400 URL: http://hg.openjdk.java.net/hsx/hotspot-main/hotspot/rev/b5bae74160b7 8010474: [parfait] Undefined return value of the functions in hotspot/src/share/vm/services/memTracker.hpp Summary: Fixed functions that miss return values Reviewed-by: coleenp, acorn, kvn ! src/share/vm/services/memTracker.hpp Changeset: 26e0c03da92c Author: zgu Date: 2013-03-27 13:07 -0700 URL: http://hg.openjdk.java.net/hsx/hotspot-main/hotspot/rev/26e0c03da92c Merge - make/windows/projectfiles/kernel/Makefile - make/windows/projectfiles/kernel/vm.def - make/windows/projectfiles/kernel/vm.dsw Changeset: f044c45bee68 Author: zgu Date: 2013-03-27 22:05 -0700 URL: http://hg.openjdk.java.net/hsx/hotspot-main/hotspot/rev/f044c45bee68 Merge Changeset: 1b90c7607451 Author: minqi Date: 2013-03-27 17:03 -0700 URL: http://hg.openjdk.java.net/hsx/hotspot-main/hotspot/rev/1b90c7607451 2178143: JVM crashes if the number of bound CPUs changed during runtime Summary: Supply a new flag -XX:+AssumeMP to workaround the problem. With the flag is turned on, assume VM run on MP platform so is_MP() will return true that sync calls will not skip away. Reviewed-by: dholmes, acorn, dcubed, jmasa Contributed-by: yumin.qi at oracle.com ! src/share/vm/runtime/arguments.cpp ! src/share/vm/runtime/globals.hpp ! src/share/vm/runtime/os.hpp Changeset: d7adf726b18a Author: minqi Date: 2013-03-28 00:44 -0700 URL: http://hg.openjdk.java.net/hsx/hotspot-main/hotspot/rev/d7adf726b18a Merge Changeset: c0f9217203b2 Author: dcubed Date: 2013-03-29 08:38 -0700 URL: http://hg.openjdk.java.net/hsx/hotspot-main/hotspot/rev/c0f9217203b2 Merge ! src/share/vm/runtime/arguments.cpp Changeset: d886ac1dfd36 Author: coleenp Date: 2013-03-31 21:43 -0400 URL: http://hg.openjdk.java.net/hsx/hotspot-main/hotspot/rev/d886ac1dfd36 8010723: fatal error: acquiring lock Metaspace allocation lock/5 out of order Summary: Avoid holding SystemDictionary_lock while calling Klass::remove_unshareable_info Reviewed-by: coleenp, acorn Contributed-by: ioi.lam at oracle.com ! src/share/vm/classfile/systemDictionary.cpp Changeset: e458120c6e1a Author: sla Date: 2013-03-28 15:39 +0100 URL: http://hg.openjdk.java.net/hsx/hotspot-main/hotspot/rev/e458120c6e1a 8002118: WindbgDebuggerLocal should not try to load 64-bit debug libraries for 32-bit JVM Reviewed-by: sspitsyn, zgu Contributed-by: peter.allwin at oracle.com ! agent/src/share/classes/sun/jvm/hotspot/debugger/windbg/WindbgDebuggerLocal.java Changeset: ede380e13960 Author: mgerdin Date: 2013-04-02 11:28 +0200 URL: http://hg.openjdk.java.net/hsx/hotspot-main/hotspot/rev/ede380e13960 8009763: Add WB test for String.intern() Summary: Add convenience method in StringTable, add WhiteBox method and simple sanity test Reviewed-by: mgerdin, zgu Contributed-by: leonid.mesnik at oracle.com ! src/share/vm/classfile/symbolTable.cpp ! src/share/vm/classfile/symbolTable.hpp ! src/share/vm/prims/whitebox.cpp + test/runtime/interned/SanityTest.java ! test/testlibrary/whitebox/sun/hotspot/WhiteBox.java Changeset: 8c03fc47511d Author: iklam Date: 2013-04-01 14:05 -0700 URL: http://hg.openjdk.java.net/hsx/hotspot-main/hotspot/rev/8c03fc47511d 8011048: Possible reading from unmapped memory in UTF8::as_quoted_ascii() Summary: Pass utf_length parameter to UTF8::as_quoted_ascii() Reviewed-by: dcubed, minqi ! src/share/vm/oops/symbol.cpp ! src/share/vm/utilities/utf8.cpp ! src/share/vm/utilities/utf8.hpp Changeset: a4e8dac9db8c Author: zgu Date: 2013-04-02 07:40 -0700 URL: http://hg.openjdk.java.net/hsx/hotspot-main/hotspot/rev/a4e8dac9db8c Merge From christian.tornqvist at oracle.com Wed Apr 3 23:02:52 2013 From: christian.tornqvist at oracle.com (Christian Tornqvist) Date: Thu, 4 Apr 2013 08:02:52 +0200 Subject: New HSX Committer: Ioi Lam In-Reply-To: <515B2A59.6060500@oracle.com> References: <515B2A59.6060500@oracle.com> Message-ID: <02a101ce30fa$0c75ff60$2561fe20$@tornqvist@oracle.com> Vote: yes -----Original Message----- From: hotspot-dev-bounces at openjdk.java.net [mailto:hotspot-dev-bounces at openjdk.java.net] On Behalf Of Coleen Phillimore Sent: den 2 april 2013 20:59 To: hotspot-dev developers Subject: CFV: New HSX Committer: Ioi Lam I hereby nominate Ioi Lam (OpenJDK user name: iklam) to HSX Committer. Ioi is a member of the Hotspot runtime group. He is currently investigating Application Class Data Sharing and footprint reduction. He has contributed 8 changesets to the HSX project and he is qualified to be committer [1]: http://hg.openjdk.java.net/hsx/hotspot-main/hotspot/log?rev=ioi.lam at oracle.c om http://hg.openjdk.java.net/hsx/hotspot-main/hotspot/log?rev=iklam Votes are due by April 16, 2013. Only current HSX Committers [2] are eligible to vote on this nomination. Votes must be cast in the open by replying to this mailing list. For Lazy Consensus voting instructions, see [3]. Thanks, Coleen Phillimore [1]http://openjdk.java.net/projects/#project-committer [2]http://openjdk.java.net/census#hsx [3]http://openjdk.java.net/projects#committer-vote From erik.helin at oracle.com Wed Apr 3 23:31:33 2013 From: erik.helin at oracle.com (erik.helin at oracle.com) Date: Thu, 04 Apr 2013 06:31:33 +0000 Subject: hg: hsx/hsx24/hotspot: 8008737: The trace event vm/gc/heap/summary is missing for CMS Message-ID: <20130404063137.CCAE1485B6@hg.openjdk.java.net> Changeset: f842ea9b8830 Author: ehelin Date: 2013-04-03 17:49 +0200 URL: http://hg.openjdk.java.net/hsx/hsx24/hotspot/rev/f842ea9b8830 8008737: The trace event vm/gc/heap/summary is missing for CMS Reviewed-by: mgerdin, brutisso ! src/share/vm/gc_implementation/concurrentMarkSweep/concurrentMarkSweepGeneration.cpp ! src/share/vm/gc_implementation/concurrentMarkSweep/concurrentMarkSweepGeneration.hpp ! src/share/vm/gc_implementation/concurrentMarkSweep/vmCMSOperations.cpp ! src/share/vm/gc_implementation/shared/gcHeapSummary.hpp From peter.allwin at oracle.com Thu Apr 4 07:12:27 2013 From: peter.allwin at oracle.com (Peter Allwin) Date: Thu, 04 Apr 2013 16:12:27 +0200 Subject: Review request: 6729929 I18N - Taking Heap Dump failed if project path contains multibyte characters In-Reply-To: <515C55F4.6020002@oracle.com> References: <515C55F4.6020002@oracle.com> Message-ID: <515D8A4B.4040005@oracle.com> Hi, I'm still looking for reviewers for this change. Thanks! /peter On 4/3/2013 6:16 PM, Peter Allwin wrote: > Webrev: http://cr.openjdk.java.net/~mgronlun/6729929/webrev01/ > > Bug: http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=6729929 > > Summary: When dumpHeap in the HotSpotDiagnostic JMX MBean is called, > the filename parameter must be converted from jstring to char* to be > used in open(). This was done using UTF-8 encoding which is incorrect > as open() expects a platform dependent encoding according to the > system locale. Fix is to use > java_lang_String::as_platform_dependent_str to do the conversion. > > Thanks to Markus for advising and hosting the webrev! > > Regards, > > /peter From kevin.walls at oracle.com Thu Apr 4 11:58:18 2013 From: kevin.walls at oracle.com (kevin.walls at oracle.com) Date: Thu, 04 Apr 2013 18:58:18 +0000 Subject: hg: hsx/hsx24/hotspot: 8009460: C2compiler crash in machnode::in_regmask(unsigned int) Message-ID: <20130404185822.906D4485DB@hg.openjdk.java.net> Changeset: abeffed9e41a Author: roland Date: 2013-03-06 10:28 +0100 URL: http://hg.openjdk.java.net/hsx/hsx24/hotspot/rev/abeffed9e41a 8009460: C2compiler crash in machnode::in_regmask(unsigned int) Summary: 7121140 may not correctly break the Allocate -> MemBarStoreStore link Reviewed-by: kvn ! src/share/vm/opto/compile.cpp ! src/share/vm/opto/macro.cpp From mikael.vidstedt at oracle.com Thu Apr 4 12:14:34 2013 From: mikael.vidstedt at oracle.com (Mikael Vidstedt) Date: Thu, 04 Apr 2013 12:14:34 -0700 Subject: RFR: 8003310: Enable -Wunused when compiling with GCC In-Reply-To: <515BDA8F.6070108@oracle.com> References: <50A1C598.4050904@oracle.com> <50A1DEE5.8090606@oracle.com> <50A24E00.3070200@oracle.com> <50A25720.1040405@oracle.com> <50A59010.5040001@oracle.com> <510C18F6.6010305@oracle.com> <511DAB26.2010808@oracle.com> <511DB3E0.6030606@oracle.com> <5122B5C3.1010908@oracle.com> <0153EC9C-4474-4B54-B215-6BE7BF2A7E1B@oracle.com> <512508DE.70904@oracle.com> <51251015.5000501@oracle.com> <51267CE4.6090104@oracle.com> <5126E2FE.9060200@oracle.com> <51547282.6090005@oracle.com> <515BDA8F.6070108@oracle.com> Message-ID: <515DD11A.6020906@oracle.com> David, Coleen, Vladimir, others - thanks for the reviews and the associated patience! Cheers, Mikael On 4/3/2013 12:30 AM, David Holmes wrote: > Sorry for the delay. > > Ship it! (As seems to be the new catch-cry ;-) ) > > David > > On 29/03/2013 2:40 AM, Mikael Vidstedt wrote: >> >> I've been waiting for Joe's changes to bubble up so as to not add a >> conflict unnecessarily, and since they're now in hotspot-rt I have >> uploaded a webrev for what I hope is a final time *knocking on wood*. I >> would appreciate a quick check to see that everything still looks fine: >> >> http://cr.openjdk.java.net/~mikael/webrevs/8003310/webrev.08/webrev/ >> >> The only relevant changes from the last webrev should be: >> >> make/linux/makefiles/gcc.make: >> >> * Eliminate the ADDITIONAL_WARNINGS variable and just use WARNING_FLAGS >> directly >> * Clean up the -Wconversion logic >> >> src/share/vm/runtime/arguments.cpp: >> >> * Updated after the recent changes to SERIAL/INCLUDE_ALL_GCS (8005915) >> >> Thanks, >> Mikael >> >> On 2/21/2013 7:16 PM, David Holmes wrote: >>> One final comment - please liaise with Joe Provino who is adding >>> -Wundef so we can get a consistent approach as to where these -Wxxx >>> flags get added. :) >>> >>> >>> (Don't know what I was looking at with the trace_locking stuff - it >>> ends up as an empty method.) >>> >>> David >>> >>> On 22/02/2013 6:00 AM, Mikael Vidstedt wrote: >>>> >>>> On 2013-02-20 10:04, Coleen Phillimore wrote: >>>>> On 2/20/2013 12:33 PM, Mikael Vidstedt wrote: >>>>>> >>>>>> On 2/19/2013 12:01 PM, Christian Thalinger wrote: >>>>>>> On Feb 18, 2013, at 3:14 PM, Mikael Vidstedt >>>>>>> wrote: >>>>>>> >>>>>>>> A really good control question, thanks a lot for asking! >>>>>>>> >>>>>>>> As a matter of fact these changes are basically just doing what >>>>>>>> the >>>>>>>> compiler already does for us, so it's more about cleaning up the >>>>>>>> source code than reducing the size of the binary. So in theory >>>>>>>> these changes should have no impact on the binary size at all, but >>>>>>>> it actually turns out they do. Very specifically, the fact that I >>>>>>>> moved the same_page() function from being duplicated in the three >>>>>>>> os_.cpp files to having it be in globalDefinitions.cpp makes >>>>>>>> the binary grow a few bytes (54 bytes to be specific). The reason >>>>>>>> is a bit subtle: >>>>>>>> >>>>>>>> The same_page() function is (was) static in the respective >>>>>>>> os_*.cpp >>>>>>>> files. They are only ever used when the Verbose flag is true, and >>>>>>>> furthermore the Verbose option is a develop only flag, which means >>>>>>>> it is hardcoded to false in product. The compiler knows that's the >>>>>>>> case and eliminates the same_page() function completely. >>>>>>>> >>>>>>>> Since I moved it to globalDefinitions.cpp there's no way easy for >>>>>>>> the compiler to know that it is not being used, so it will >>>>>>>> actually >>>>>>>> keep the function. >>>>>>>> >>>>>>>> Unless there are strong opinions I'm not going to do anything >>>>>>>> about >>>>>>>> this. >>>>>>>> >>>>>>>> However, this made me question my earlier experiments with using >>>>>>>> the const bool = false construct in constantPool.cpp, because >>>>>>>> after >>>>>>>> all that is the exact same pattern. And it turns out that I must >>>>>>>> have done something wrong when I was performing the experiments, >>>>>>>> because when I do the same thing again now it turns out the >>>>>>>> compiler actually *does* deadcode eliminate the debug-only >>>>>>>> functions. So I take everything back and conclude that const >>>>>>>> bool = >>>>>>>> false is indeed a great way to make sure the debug code does not >>>>>>>> rot over time, and that the product binary will *not* contain the >>>>>>>> dead functions. Sorry for any confusion this may have caused. >>>>>>>> >>>>>>>> With all that in mind, here's another version of the webrev: >>>>>>>> >>>>>>>> http://cr.openjdk.java.net/~mikael/webrevs/8003310/webrev04/webrev/ >>>>>>>> >>>>>>> src/share/vm/interpreter/interpreterRuntime.cpp: >>>>>>> >>>>>>> I suppose that #if 0 is to keep that code for...? Could we add a >>>>>>> comment why we keep it? >>>>>> >>>>>> This was by "popular request" (from David Holmes) :) >>>>>> >>>>>> I personally don't know if and how this is being used. Note that >>>>>> ObjectSynchronizer::trace_locking is PRODUCT_RETURN and the >>>>>> non-product implementation in synchronizer.cpp is empty (modulo the >>>>>> comment saying "Don't know what to do here"), so one can question >>>>>> the >>>>>> value of keeping the any of the trace_locking functions, but they >>>>>> may >>>>>> be someone's favorite debugging tool. Until proven differently I >>>>>> will >>>>>> leave it in there for now. If somebody can help me provide a useful >>>>>> comment about how the code is actually being used then I will >>>>>> certainly add it, otherwise I'll keep this as it is. >>>>> >>>>> If I remember correctly, this trace_locking code was associated >>>>> with a >>>>> flag that we removed a long time ago. I don't think if we want to >>>>> implement TraceLocking we'd use this function. My vote is that it >>>>> and >>>>> the ObjectMonitor:: version should be removed. >>>> >>>> Thanks Coleen, that makes sense. I've prepared a final version of the >>>> webrev with the trace_locking methods removed too: >>>> >>>> http://cr.openjdk.java.net/~mikael/webrevs/8003310/webrev.06/webrev/ >>>> >>>> Any final comments? >>>> >>>> Cheers, >>>> Mikael >>>> >>>>> >>>>> Coleen >>>>>> >>>>>>> src/share/vm/oops/constantPool.cpp: >>>>>>> >>>>>>> So we use: >>>>>>> >>>>>>> + const bool debug_cpool = false; >>>>>>> >>>>>>> but we still have the DBG macro. Can't we have a static debug >>>>>>> method that takes all printf arguments and prints them? The >>>>>>> debug_cpool should make that method empty and the compiler can >>>>>>> remove it. I really start to hate all these macros... >>>>>> >>>>>> I share your macro hate and I actually played around with removing >>>>>> the macros just as you say. There is one small problem with doing it >>>>>> that way, and that's the fact that a few of the printf:s print >>>>>> symbols names, and as part of that they need to create utf8 strings >>>>>> using sym->as_utf8(). The compiler can unfortunately not know that >>>>>> that function is for all intents and purposes a no-op, so it will >>>>>> keep the call even in product meaning increased binary size and it >>>>>> will also add to the runtime since it actually performs the call and >>>>>> creates the utf8 string. So I'm going to keep the macros for now. >>>>>> >>>>>> >>>>>> I also moved the clamp_address_in_page to the globalDefinitions.hpp >>>>>> header file, meaning it will be inlined and dead code eliminated. >>>>>> >>>>>> New webrev here: >>>>>> >>>>>> http://cr.openjdk.java.net/~mikael/webrevs/8003310/webrev.05/webrev/ >>>>>> >>>>>> Final comments? >>>>>> >>>>>> Cheers, >>>>>> Mikael >>>>>> >>>>> >>>> >> From mikael.gerdin at oracle.com Thu Apr 4 15:49:43 2013 From: mikael.gerdin at oracle.com (mikael.gerdin at oracle.com) Date: Thu, 04 Apr 2013 22:49:43 +0000 Subject: hg: hsx/hotspot-main/hotspot: 7 new changesets Message-ID: <20130404224957.1530A48075@hg.openjdk.java.net> Changeset: 2e093b564241 Author: mgerdin Date: 2013-03-28 10:27 +0100 URL: http://hg.openjdk.java.net/hsx/hotspot-main/hotspot/rev/2e093b564241 7014552: gc/lock/jni/jnilockXXX works too slow on 1-processor machine Summary: Keep a counter of how many times we were stalled by the GC locker, add a diagnostic flag which sets the limit. Reviewed-by: brutisso, ehelin, johnc ! src/share/vm/gc_implementation/g1/g1CollectedHeap.cpp ! src/share/vm/gc_implementation/g1/g1CollectedHeap.hpp ! src/share/vm/gc_implementation/g1/g1CollectedHeap.inline.hpp ! src/share/vm/gc_implementation/parallelScavenge/parallelScavengeHeap.cpp ! src/share/vm/memory/collectorPolicy.cpp ! src/share/vm/runtime/globals.hpp Changeset: 754c24457b20 Author: tschatzl Date: 2013-03-27 19:21 +0100 URL: http://hg.openjdk.java.net/hsx/hotspot-main/hotspot/rev/754c24457b20 7112912: Message "Error occurred during initialization of VM" on boxes with lots of RAM Summary: Ergonomics now also takes available virtual memory into account when deciding for a heap size. The helper method to determine the maximum allocatable memory block now uses the appropriate OS specific calls to retrieve available virtual memory for the java process. In 32 bit environments this method now also searches for the maximum actually reservable amount of memory. Merge previously separate implementations for Linux/BSD/Solaris into a single method. Reviewed-by: jmasa, tamao ! src/os/bsd/vm/os_bsd.cpp ! src/os/linux/vm/os_linux.cpp ! src/os/posix/vm/os_posix.cpp ! src/os/solaris/vm/os_solaris.cpp ! src/os/windows/vm/os_windows.cpp ! src/share/vm/runtime/arguments.cpp ! src/share/vm/runtime/arguments.hpp ! src/share/vm/runtime/globals.hpp ! src/share/vm/runtime/os.hpp Changeset: 24ef5fb05e0f Author: johnc Date: 2013-03-29 13:49 -0700 URL: http://hg.openjdk.java.net/hsx/hotspot-main/hotspot/rev/24ef5fb05e0f 8010463: G1: Crashes with -UseTLAB and heap verification Summary: Some parts of the G1 heap can only be walked during a safepoint. Skip verifying these parts of the heap when verifying during JVM startup. Reviewed-by: brutisso, tschatzl ! src/share/vm/gc_implementation/g1/g1CollectedHeap.cpp ! src/share/vm/memory/universe.cpp ! src/share/vm/runtime/init.cpp ! src/share/vm/runtime/thread.cpp + test/gc/TestVerifyBeforeGCDuringStartup.java Changeset: 8bf6338972ce Author: ehelin Date: 2013-03-23 09:16 +0100 URL: http://hg.openjdk.java.net/hsx/hotspot-main/hotspot/rev/8bf6338972ce 8009408: gc/metaspace/ClassMetaspaceSizeInJmapHeap.java fails with "exit code 1" Reviewed-by: brutisso, sla, ctornqvi ! test/gc/metaspace/ClassMetaspaceSizeInJmapHeap.java + test/testlibrary/com/oracle/java/testlibrary/JDKToolLauncher.java Changeset: cc5b5976d72c Author: tschatzl Date: 2013-04-02 10:03 +0200 URL: http://hg.openjdk.java.net/hsx/hotspot-main/hotspot/rev/cc5b5976d72c 8005857: assert in GC_locker from PSOldGen::expand with -XX:+PrintGCDetails and Verbose Summary: Use GC_locker::is_active_and_needs_gc() instead of GC_locker::is_active() for providing information about the reason of heap expansion. Reviewed-by: jmasa, johnc ! src/share/vm/gc_implementation/parallelScavenge/psOldGen.cpp Changeset: 15c04fe93c18 Author: mgerdin Date: 2013-04-03 09:19 +0200 URL: http://hg.openjdk.java.net/hsx/hotspot-main/hotspot/rev/15c04fe93c18 Merge - make/windows/projectfiles/kernel/Makefile - make/windows/projectfiles/kernel/vm.def - make/windows/projectfiles/kernel/vm.dsw ! src/os/linux/vm/os_linux.cpp ! src/share/vm/runtime/arguments.cpp ! src/share/vm/runtime/globals.hpp - test/runtime/8007736/TestStaticIF.java Changeset: 0c039865ef2b Author: mgerdin Date: 2013-04-04 19:07 +0200 URL: http://hg.openjdk.java.net/hsx/hotspot-main/hotspot/rev/0c039865ef2b Merge ! src/share/vm/runtime/arguments.cpp ! src/share/vm/runtime/globals.hpp ! src/share/vm/runtime/os.hpp From bharadwaj.yadavalli at oracle.com Thu Apr 4 20:22:39 2013 From: bharadwaj.yadavalli at oracle.com (bharadwaj.yadavalli at oracle.com) Date: Fri, 05 Apr 2013 03:22:39 +0000 Subject: hg: hsx/hotspot-main/hotspot: 21 new changesets Message-ID: <20130405032319.C5D284809A@hg.openjdk.java.net> Changeset: 46f6f063b272 Author: roland Date: 2013-03-21 09:27 +0100 URL: http://hg.openjdk.java.net/hsx/hotspot-main/hotspot/rev/46f6f063b272 7153771: array bound check elimination for c1 Summary: when possible optimize out array bound checks, inserting predicates when needed. Reviewed-by: never, kvn, twisti Contributed-by: thomaswue ! src/cpu/sparc/vm/c1_CodeStubs_sparc.cpp ! src/cpu/sparc/vm/c1_LIRAssembler_sparc.cpp ! src/cpu/sparc/vm/c1_LIRGenerator_sparc.cpp ! src/cpu/sparc/vm/c1_Runtime1_sparc.cpp ! src/cpu/x86/vm/c1_CodeStubs_x86.cpp ! src/cpu/x86/vm/c1_LIRAssembler_x86.cpp ! src/cpu/x86/vm/c1_LIRGenerator_x86.cpp ! src/cpu/x86/vm/c1_LinearScan_x86.cpp ! src/cpu/x86/vm/c1_Runtime1_x86.cpp ! src/share/vm/c1/c1_Canonicalizer.cpp ! src/share/vm/c1/c1_Canonicalizer.hpp ! src/share/vm/c1/c1_CodeStubs.hpp ! src/share/vm/c1/c1_Compilation.cpp ! src/share/vm/c1/c1_Compilation.hpp ! src/share/vm/c1/c1_GraphBuilder.cpp ! src/share/vm/c1/c1_GraphBuilder.hpp ! src/share/vm/c1/c1_IR.cpp ! src/share/vm/c1/c1_IR.hpp ! src/share/vm/c1/c1_Instruction.cpp ! src/share/vm/c1/c1_Instruction.hpp ! src/share/vm/c1/c1_InstructionPrinter.cpp ! src/share/vm/c1/c1_InstructionPrinter.hpp ! src/share/vm/c1/c1_LIR.cpp ! src/share/vm/c1/c1_LIR.hpp ! src/share/vm/c1/c1_LIRAssembler.hpp ! src/share/vm/c1/c1_LIRGenerator.cpp ! src/share/vm/c1/c1_LIRGenerator.hpp ! src/share/vm/c1/c1_LinearScan.cpp ! src/share/vm/c1/c1_Optimizer.cpp + src/share/vm/c1/c1_RangeCheckElimination.cpp + src/share/vm/c1/c1_RangeCheckElimination.hpp ! src/share/vm/c1/c1_Runtime1.cpp ! src/share/vm/c1/c1_Runtime1.hpp ! src/share/vm/c1/c1_ValueMap.cpp ! src/share/vm/c1/c1_ValueMap.hpp ! src/share/vm/c1/c1_globals.hpp ! src/share/vm/compiler/compileBroker.cpp ! src/share/vm/oops/instanceKlass.cpp ! src/share/vm/oops/methodData.cpp ! src/share/vm/runtime/globals.hpp Changeset: a57fc14f798a Author: roland Date: 2013-03-21 22:00 -0700 URL: http://hg.openjdk.java.net/hsx/hotspot-main/hotspot/rev/a57fc14f798a Merge Changeset: e370f63dc5b1 Author: bharadwaj Date: 2013-03-22 07:58 -0700 URL: http://hg.openjdk.java.net/hsx/hotspot-main/hotspot/rev/e370f63dc5b1 8009539: JVM crash when run lambda testng tests Summary: Ensure class pointer is non-null before dereferencing it to check if it is loaded. Reviewed-by: kvn ! src/share/vm/opto/parse2.cpp Changeset: 360ce06580b8 Author: bharadwaj Date: 2013-03-22 13:35 -0400 URL: http://hg.openjdk.java.net/hsx/hotspot-main/hotspot/rev/360ce06580b8 Merge Changeset: 3c786355ffb4 Author: morris Date: 2013-03-23 06:22 -0700 URL: http://hg.openjdk.java.net/hsx/hotspot-main/hotspot/rev/3c786355ffb4 8009026: [parfait] Null pointer deference in hotspot/src/share/vm/code/nmethod.cpp Summary: add guarantee() to nmethod constructor and checks to ensure CodeCache has space before allocation Reviewed-by: kvn ! src/share/vm/code/codeCache.hpp ! src/share/vm/code/nmethod.cpp Changeset: 818a1ac7da7a Author: morris Date: 2013-03-24 12:43 -0700 URL: http://hg.openjdk.java.net/hsx/hotspot-main/hotspot/rev/818a1ac7da7a Merge Changeset: 16885e702c88 Author: twisti Date: 2013-03-25 17:13 -0700 URL: http://hg.openjdk.java.net/hsx/hotspot-main/hotspot/rev/16885e702c88 7198429: need checked categorization of caller-sensitive methods in the JDK Reviewed-by: kvn, jrose ! src/share/vm/ci/ciMethod.cpp ! src/share/vm/ci/ciMethod.hpp ! src/share/vm/classfile/classFileParser.cpp ! src/share/vm/classfile/classFileParser.hpp ! src/share/vm/classfile/classLoaderData.cpp ! src/share/vm/classfile/classLoaderData.hpp ! src/share/vm/classfile/javaClasses.hpp ! src/share/vm/classfile/systemDictionary.cpp ! src/share/vm/classfile/systemDictionary.hpp ! src/share/vm/classfile/vmSymbols.hpp ! src/share/vm/oops/method.cpp ! src/share/vm/oops/method.hpp ! src/share/vm/opto/library_call.cpp ! src/share/vm/prims/jvm.cpp ! src/share/vm/prims/methodHandles.cpp ! src/share/vm/prims/unsafe.cpp ! src/share/vm/runtime/vframe.cpp ! src/share/vm/runtime/vframe.hpp Changeset: b808febcad9a Author: neliasso Date: 2013-03-26 10:05 +0100 URL: http://hg.openjdk.java.net/hsx/hotspot-main/hotspot/rev/b808febcad9a 8010281: Remove code that is never executed Reviewed-by: kvn, roland Contributed-by: niclas.adlertz at oracle.com ! src/share/vm/opto/ifg.cpp Changeset: 30f42e691e70 Author: kvn Date: 2013-03-26 12:55 -0700 URL: http://hg.openjdk.java.net/hsx/hotspot-main/hotspot/rev/30f42e691e70 8004640: C2 assert failure in memnode.cpp: NULL+offs not RAW address Summary: always transform AddP nodes in IdealKit by calling _gvn.transform(). Reviewed-by: roland, twisti ! src/share/vm/opto/graphKit.cpp ! src/share/vm/opto/idealKit.cpp ! src/share/vm/opto/idealKit.hpp ! src/share/vm/opto/loopnode.cpp ! src/share/vm/opto/phaseX.cpp Changeset: d595e8ddadd9 Author: roland Date: 2013-03-29 17:25 +0100 URL: http://hg.openjdk.java.net/hsx/hotspot-main/hotspot/rev/d595e8ddadd9 8010934: assert failure in c1_LinearScan.cpp: "asumption: non-Constant instructions have only virtual operands" Summary: incorrect code to skip some ArrayLength instructions in LIRGenerator Reviewed-by: kvn ! src/share/vm/c1/c1_LIRGenerator.cpp ! src/share/vm/c1/c1_RangeCheckElimination.cpp Changeset: cd9ad42dfde0 Author: bharadwaj Date: 2013-03-29 20:52 -0700 URL: http://hg.openjdk.java.net/hsx/hotspot-main/hotspot/rev/cd9ad42dfde0 Merge ! src/share/vm/classfile/classFileParser.cpp ! src/share/vm/prims/jvm.cpp ! src/share/vm/runtime/globals.hpp Changeset: 6b19fe41b577 Author: kmo Date: 2013-03-30 08:01 -0700 URL: http://hg.openjdk.java.net/hsx/hotspot-main/hotspot/rev/6b19fe41b577 8011009: Use do-while(0) instead of while(0) in EC_TRACE and RC_TRACE* macros Summary: Improve EC_TRACE and RC_TRACE* to use the do-while(0) trick for statement-like macro Reviewed-by: sspitsyn, dcubed ! src/share/vm/prims/jvmtiEventController.cpp ! src/share/vm/prims/jvmtiRedefineClassesTrace.hpp Changeset: 53028d751155 Author: neliasso Date: 2013-04-02 09:30 +0200 URL: http://hg.openjdk.java.net/hsx/hotspot-main/hotspot/rev/53028d751155 7034299: Faulty winsock initialization code Reviewed-by: dholmes, sla, ctornqvi ! src/os/windows/vm/os_windows.cpp Changeset: e961c11b85fe Author: kvn Date: 2013-04-03 11:12 -0700 URL: http://hg.openjdk.java.net/hsx/hotspot-main/hotspot/rev/e961c11b85fe 8011102: Clear AVX registers after return from JNI call Summary: Execute vzeroupper instruction after JNI call and on exits in jit compiled code which use 256bit vectors. Reviewed-by: roland ! src/cpu/x86/vm/cppInterpreter_x86.cpp ! src/cpu/x86/vm/macroAssembler_x86.cpp ! src/cpu/x86/vm/macroAssembler_x86.hpp ! src/cpu/x86/vm/sharedRuntime_x86_32.cpp ! src/cpu/x86/vm/sharedRuntime_x86_64.cpp ! src/cpu/x86/vm/stubGenerator_x86_32.cpp ! src/cpu/x86/vm/stubGenerator_x86_64.cpp ! src/cpu/x86/vm/templateInterpreter_x86_32.cpp ! src/cpu/x86/vm/templateInterpreter_x86_64.cpp ! src/cpu/x86/vm/x86_32.ad ! src/cpu/x86/vm/x86_64.ad ! src/os_cpu/bsd_x86/vm/bsd_x86_64.ad ! src/os_cpu/linux_x86/vm/linux_x86_64.ad ! src/os_cpu/solaris_x86/vm/solaris_x86_64.ad ! src/os_cpu/windows_x86/vm/windows_x86_64.ad Changeset: 0a8c2ea3902d Author: rasbold Date: 2013-04-03 15:00 -0700 URL: http://hg.openjdk.java.net/hsx/hotspot-main/hotspot/rev/0a8c2ea3902d 8010437: guarantee(this->is8bit(imm8)) failed: Short forward jump exceeds 8-bit offset Summary: Fix shorten_branches() to accurately count an initial nop that may be inserted in a block that starts with a safepoint. Reviewed-by: kvn ! src/share/vm/opto/output.cpp Changeset: 70c52efb2cbd Author: neliasso Date: 2013-04-04 09:18 +0200 URL: http://hg.openjdk.java.net/hsx/hotspot-main/hotspot/rev/70c52efb2cbd 8006008: Memory leak in hotspot/src/share/vm/adlc/archDesc.cpp Reviewed-by: roland, kvn Contributed-by: niclas.adlertz at oracle.com ! src/share/vm/adlc/archDesc.cpp Changeset: 6c4abd4a9595 Author: roland Date: 2013-04-04 09:33 +0200 URL: http://hg.openjdk.java.net/hsx/hotspot-main/hotspot/rev/6c4abd4a9595 8010399: Test8009761.java "Failed: init recursive calls: 5498. After deopt 5494". Summary: test from 8009761 shouldn't be run with -Xcomp Reviewed-by: kvn ! test/compiler/8009761/Test8009761.java Changeset: 9125a548c1eb Author: roland Date: 2013-04-04 02:48 -0700 URL: http://hg.openjdk.java.net/hsx/hotspot-main/hotspot/rev/9125a548c1eb Merge Changeset: 573cf206e381 Author: neliasso Date: 2013-04-04 09:30 +0200 URL: http://hg.openjdk.java.net/hsx/hotspot-main/hotspot/rev/573cf206e381 8006014: Memory leak in hotspot/src/share/vm/adlc/dfa.cpp Reviewed-by: kvn, roland Contributed-by: niclas.adlertz at oracle.com ! src/share/vm/adlc/dfa.cpp Changeset: bab5cbf74b5f Author: kvn Date: 2013-04-04 12:18 -0700 URL: http://hg.openjdk.java.net/hsx/hotspot-main/hotspot/rev/bab5cbf74b5f 8011198: LP64 setting is not preserved on Solaris after 8006965 Summary: Fixed incremental build makefiles generated by buildtree.make. Consolidated unix build.sh. Reviewed-by: twisti - make/bsd/build.sh ! make/bsd/makefiles/buildtree.make + make/build.sh - make/linux/build.sh ! make/linux/makefiles/buildtree.make - make/solaris/build.sh ! make/solaris/makefiles/buildtree.make ! src/os/posix/launcher/launcher.script Changeset: 0ca3dd0ffaba Author: bharadwaj Date: 2013-04-04 17:01 -0700 URL: http://hg.openjdk.java.net/hsx/hotspot-main/hotspot/rev/0ca3dd0ffaba Merge - make/bsd/build.sh - make/linux/build.sh - make/solaris/build.sh ! src/os/windows/vm/os_windows.cpp ! src/share/vm/classfile/systemDictionary.cpp ! src/share/vm/classfile/systemDictionary.hpp ! src/share/vm/oops/method.cpp ! src/share/vm/runtime/globals.hpp From david.holmes at oracle.com Thu Apr 4 20:30:19 2013 From: david.holmes at oracle.com (david.holmes at oracle.com) Date: Fri, 05 Apr 2013 03:30:19 +0000 Subject: hg: hsx/hsx24/hotspot: 8008081: Print outs do not have matching arguments Message-ID: <20130405033022.4103F4809B@hg.openjdk.java.net> Changeset: 63c3f7805426 Author: mikael Date: 2013-02-26 08:54 -0800 URL: http://hg.openjdk.java.net/hsx/hsx24/hotspot/rev/63c3f7805426 8008081: Print outs do not have matching arguments Summary: Corrected formatted prints to have matching arguments, removed dead print_frame_layout function Reviewed-by: sla, dholmes ! src/share/vm/c1/c1_FrameMap.cpp ! src/share/vm/c1/c1_FrameMap.hpp ! src/share/vm/gc_implementation/parNew/parCardTableModRefBS.cpp ! src/share/vm/memory/cardTableModRefBS.cpp ! src/share/vm/memory/cardTableRS.cpp ! src/share/vm/prims/jvmtiEnter.xsl ! src/share/vm/services/memReporter.cpp ! src/share/vm/utilities/numberSeq.cpp From john.coomes at oracle.com Thu Apr 4 20:32:32 2013 From: john.coomes at oracle.com (john.coomes at oracle.com) Date: Fri, 05 Apr 2013 03:32:32 +0000 Subject: hg: hsx/hotspot-main/jaxp: Added tag jdk8-b84 for changeset f5f40094ffcc Message-ID: <20130405033243.4F28A4809E@hg.openjdk.java.net> Changeset: 41b50e2c5ea3 Author: katleman Date: 2013-04-04 19:05 -0700 URL: http://hg.openjdk.java.net/hsx/hotspot-main/jaxp/rev/41b50e2c5ea3 Added tag jdk8-b84 for changeset f5f40094ffcc ! .hgtags From john.coomes at oracle.com Thu Apr 4 20:32:49 2013 From: john.coomes at oracle.com (john.coomes at oracle.com) Date: Fri, 05 Apr 2013 03:32:49 +0000 Subject: hg: hsx/hotspot-main/jaxws: 4 new changesets Message-ID: <20130405033300.BA6494809F@hg.openjdk.java.net> Changeset: 0ab59cba6167 Author: jjg Date: 2013-03-18 18:34 -0700 URL: http://hg.openjdk.java.net/hsx/hotspot-main/jaxws/rev/0ab59cba6167 8007803: Implement javax.lang.model API for Type Annotations Reviewed-by: darcy ! src/share/jaxws_classes/com/sun/tools/internal/jxc/model/nav/ApNavigator.java Changeset: 2476e1f2afa5 Author: lana Date: 2013-03-26 12:00 -0700 URL: http://hg.openjdk.java.net/hsx/hotspot-main/jaxws/rev/2476e1f2afa5 Merge Changeset: 5773e3fc8380 Author: lana Date: 2013-04-01 21:35 -0700 URL: http://hg.openjdk.java.net/hsx/hotspot-main/jaxws/rev/5773e3fc8380 Merge Changeset: 8c0b6bccfe47 Author: katleman Date: 2013-04-04 19:05 -0700 URL: http://hg.openjdk.java.net/hsx/hotspot-main/jaxws/rev/8c0b6bccfe47 Added tag jdk8-b84 for changeset 5773e3fc8380 ! .hgtags From john.coomes at oracle.com Thu Apr 4 20:32:22 2013 From: john.coomes at oracle.com (john.coomes at oracle.com) Date: Fri, 05 Apr 2013 03:32:22 +0000 Subject: hg: hsx/hotspot-main/corba: 5 new changesets Message-ID: <20130405033228.A2BFB4809D@hg.openjdk.java.net> Changeset: c3ec80715805 Author: mfang Date: 2013-03-25 16:53 -0700 URL: http://hg.openjdk.java.net/hsx/hotspot-main/corba/rev/c3ec80715805 8010521: jdk8 l10n resource file translation update 2 Reviewed-by: naoto, yhuang ! src/share/classes/com/sun/corba/se/impl/orbutil/resources/sunorb_de.properties ! src/share/classes/com/sun/corba/se/impl/orbutil/resources/sunorb_es.properties ! src/share/classes/com/sun/corba/se/impl/orbutil/resources/sunorb_fr.properties ! src/share/classes/com/sun/corba/se/impl/orbutil/resources/sunorb_it.properties ! src/share/classes/com/sun/corba/se/impl/orbutil/resources/sunorb_ja.properties ! src/share/classes/com/sun/corba/se/impl/orbutil/resources/sunorb_ko.properties ! src/share/classes/com/sun/corba/se/impl/orbutil/resources/sunorb_pt_BR.properties ! src/share/classes/com/sun/corba/se/impl/orbutil/resources/sunorb_sv.properties ! src/share/classes/com/sun/corba/se/impl/orbutil/resources/sunorb_zh_CN.properties ! src/share/classes/com/sun/corba/se/impl/orbutil/resources/sunorb_zh_TW.properties ! src/share/classes/com/sun/tools/corba/se/idl/idl_ja.prp ! src/share/classes/com/sun/tools/corba/se/idl/idl_zh_CN.prp ! src/share/classes/com/sun/tools/corba/se/idl/toJavaPortable/toJavaPortable_ja.prp ! src/share/classes/com/sun/tools/corba/se/idl/toJavaPortable/toJavaPortable_zh_CN.prp Changeset: 910af9c3f338 Author: mfang Date: 2013-03-25 18:03 -0700 URL: http://hg.openjdk.java.net/hsx/hotspot-main/corba/rev/910af9c3f338 Merge Changeset: 7d7a009d5fbd Author: lana Date: 2013-03-26 12:00 -0700 URL: http://hg.openjdk.java.net/hsx/hotspot-main/corba/rev/7d7a009d5fbd Merge Changeset: 928f8b888deb Author: lana Date: 2013-04-01 21:34 -0700 URL: http://hg.openjdk.java.net/hsx/hotspot-main/corba/rev/928f8b888deb Merge Changeset: 9583a6431596 Author: katleman Date: 2013-04-04 19:05 -0700 URL: http://hg.openjdk.java.net/hsx/hotspot-main/corba/rev/9583a6431596 Added tag jdk8-b84 for changeset 928f8b888deb ! .hgtags From john.coomes at oracle.com Thu Apr 4 20:32:18 2013 From: john.coomes at oracle.com (john.coomes at oracle.com) Date: Fri, 05 Apr 2013 03:32:18 +0000 Subject: hg: hsx/hotspot-main: 8 new changesets Message-ID: <20130405033218.F23364809C@hg.openjdk.java.net> Changeset: 19a59a13b3ef Author: dholmes Date: 2013-03-14 01:41 -0400 URL: http://hg.openjdk.java.net/hsx/hotspot-main/rev/19a59a13b3ef 8009428: Revert changes to $ substitution performed as part of nashorn integration Reviewed-by: alanb, erikj ! common/makefiles/MakeBase.gmk Changeset: 4984ac509993 Author: lana Date: 2013-03-15 23:08 -0700 URL: http://hg.openjdk.java.net/hsx/hotspot-main/rev/4984ac509993 Merge Changeset: 477d18509ecb Author: lana Date: 2013-03-26 12:00 -0700 URL: http://hg.openjdk.java.net/hsx/hotspot-main/rev/477d18509ecb Merge Changeset: a1bb1a0df1fa Author: lana Date: 2013-04-01 21:34 -0700 URL: http://hg.openjdk.java.net/hsx/hotspot-main/rev/a1bb1a0df1fa Merge Changeset: 15c1642967c9 Author: andrew Date: 2013-04-02 13:59 +0100 URL: http://hg.openjdk.java.net/hsx/hotspot-main/rev/15c1642967c9 8009988: build-infra: Fix configure output for zip debuginfo check Summary: No output from zip debuginfo option when default is used. Reviewed-by: tbell ! common/autoconf/autogen.sh ! common/autoconf/generated-configure.sh ! common/autoconf/jdk-options.m4 Changeset: f3cdfb3d360d Author: omajid Date: 2013-04-02 14:13 -0400 URL: http://hg.openjdk.java.net/hsx/hotspot-main/rev/f3cdfb3d360d 8011278: Allow using a system-installed giflib Reviewed-by: andrew, prr ! common/autoconf/generated-configure.sh ! common/autoconf/libraries.m4 Changeset: 01f631f89fa3 Author: katleman Date: 2013-04-02 15:29 -0700 URL: http://hg.openjdk.java.net/hsx/hotspot-main/rev/01f631f89fa3 Merge Changeset: a0fa9e93efee Author: katleman Date: 2013-04-04 19:05 -0700 URL: http://hg.openjdk.java.net/hsx/hotspot-main/rev/a0fa9e93efee Added tag jdk8-b84 for changeset 01f631f89fa3 ! .hgtags From john.coomes at oracle.com Thu Apr 4 20:35:37 2013 From: john.coomes at oracle.com (john.coomes at oracle.com) Date: Fri, 05 Apr 2013 03:35:37 +0000 Subject: hg: hsx/hotspot-main/jdk: 52 new changesets Message-ID: <20130405034629.5FFFB480A0@hg.openjdk.java.net> Changeset: 07acfb90700b Author: malenkov Date: 2013-03-14 12:15 +0400 URL: http://hg.openjdk.java.net/hsx/hotspot-main/jdk/rev/07acfb90700b 8000183: 7163696: JCK Swing interactive test JScrollBarTest0013 fails with Nimbus and GTK L&Fs Reviewed-by: alexsch, serb ! src/share/classes/javax/swing/plaf/synth/SynthScrollBarUI.java + test/javax/swing/JScrollBar/7163696/Test7163696.java Changeset: d4e1c5803a59 Author: alexsch Date: 2013-03-15 17:02 +0400 URL: http://hg.openjdk.java.net/hsx/hotspot-main/jdk/rev/d4e1c5803a59 8009221: [macosx] Two closed/javax/swing regression tests fail on MacOSX. Reviewed-by: serb, alexp + test/javax/swing/JMenu/4515762/bug4515762.java + test/javax/swing/JRootPane/4670486/bug4670486.java ! test/javax/swing/regtesthelpers/Util.java Changeset: 2725b8a783e7 Author: lana Date: 2013-03-15 16:39 -0700 URL: http://hg.openjdk.java.net/hsx/hotspot-main/jdk/rev/2725b8a783e7 Merge - make/tools/javazic/Makefile - make/tools/src/build/tools/javazic/BackEnd.java - make/tools/src/build/tools/javazic/Checksum.java - make/tools/src/build/tools/javazic/DayOfWeek.java - make/tools/src/build/tools/javazic/Gen.java - make/tools/src/build/tools/javazic/GenDoc.java - make/tools/src/build/tools/javazic/Main.java - make/tools/src/build/tools/javazic/Mappings.java - make/tools/src/build/tools/javazic/Month.java - make/tools/src/build/tools/javazic/Rule.java - make/tools/src/build/tools/javazic/RuleDay.java - make/tools/src/build/tools/javazic/RuleRec.java - make/tools/src/build/tools/javazic/Simple.java - make/tools/src/build/tools/javazic/Time.java - make/tools/src/build/tools/javazic/Timezone.java - make/tools/src/build/tools/javazic/Zone.java - make/tools/src/build/tools/javazic/ZoneRec.java - make/tools/src/build/tools/javazic/Zoneinfo.java - src/share/classes/java/lang/annotation/InvalidContainerAnnotationError.java - src/share/classes/java/util/function/Block.java - src/share/classes/java/util/function/DoubleBlock.java - src/share/classes/java/util/function/IntBlock.java - src/share/classes/java/util/function/LongBlock.java - src/share/classes/sun/security/util/KeyLength.java - test/javax/script/RhinoExceptionTest.java Changeset: 4bf5a5a72664 Author: serb Date: 2013-03-18 22:10 +0400 URL: http://hg.openjdk.java.net/hsx/hotspot-main/jdk/rev/4bf5a5a72664 8000435: [macosx] Button painting error under Java 7 on Mac Reviewed-by: denis, alexsch ! src/macosx/classes/com/apple/laf/AquaButtonBorder.java ! src/macosx/classes/com/apple/laf/AquaButtonExtendedTypes.java Changeset: af6049edac00 Author: kshefov Date: 2013-03-19 17:51 +0400 URL: http://hg.openjdk.java.net/hsx/hotspot-main/jdk/rev/af6049edac00 8009881: TEST_BUG: javax/swing/JTree/8004298/bug8004298.java should be modified Reviewed-by: serb, alexsch ! test/javax/swing/JTree/8004298/bug8004298.java Changeset: 4e15c3e56315 Author: kshefov Date: 2013-03-20 14:02 +0400 URL: http://hg.openjdk.java.net/hsx/hotspot-main/jdk/rev/4e15c3e56315 8009880: TEST_BUG: Test java/beans/Introspector/TestTypeResolver.java should be modified again Reviewed-by: malenkov, alexsch ! test/java/beans/Introspector/TestTypeResolver.java Changeset: 87001c7bb678 Author: alitvinov Date: 2013-03-20 20:41 +0400 URL: http://hg.openjdk.java.net/hsx/hotspot-main/jdk/rev/87001c7bb678 6550588: java.awt.Desktop cannot open file with Windows UNC filename Reviewed-by: art, uta ! src/windows/classes/sun/awt/windows/WDesktopPeer.java ! src/windows/native/sun/windows/awt_Desktop.cpp + test/java/awt/Desktop/OpenByUNCPathNameTest/OpenByUNCPathNameTest.java Changeset: ef948ef2b58f Author: alexsch Date: 2013-03-21 16:50 +0400 URL: http://hg.openjdk.java.net/hsx/hotspot-main/jdk/rev/ef948ef2b58f 8007146: [macosx] Setting a display mode crashes JDK under VNC Reviewed-by: serb ! src/macosx/native/sun/awt/CGraphicsDevice.m + test/java/awt/GraphicsDevice/CheckDisplayModes.java Changeset: a275acd8bcae Author: denis Date: 2013-03-22 19:56 +0400 URL: http://hg.openjdk.java.net/hsx/hotspot-main/jdk/rev/a275acd8bcae 7123476: DesktopOpenTests:When enter the file path and click the open button,it crash Reviewed-by: art, anthony ! make/sun/xawt/FILES_c_unix.gmk ! makefiles/CompileNativeLibraries.gmk ! src/solaris/native/sun/awt/gtk2_interface.c ! src/solaris/native/sun/awt/gtk2_interface.h ! src/solaris/native/sun/xawt/awt_Desktop.c + src/solaris/native/sun/xawt/gnome_interface.c + src/solaris/native/sun/xawt/gnome_interface.h Changeset: 15a2599f470f Author: lana Date: 2013-03-26 11:58 -0700 URL: http://hg.openjdk.java.net/hsx/hotspot-main/jdk/rev/15a2599f470f Merge ! makefiles/CompileNativeLibraries.gmk Changeset: e497a050e059 Author: uta Date: 2013-03-13 13:22 +0400 URL: http://hg.openjdk.java.net/hsx/hotspot-main/jdk/rev/e497a050e059 7190897: (fs) Files.isWritable method returns false when the path is writable (win) Summary: The [GetEffectiveRightsFromAcl] based implementation was changed to the [AccessCheck] based. Reviewed-by: alanb ! src/windows/classes/sun/nio/fs/WindowsConstants.java ! src/windows/classes/sun/nio/fs/WindowsFileSystemProvider.java ! src/windows/classes/sun/nio/fs/WindowsNativeDispatcher.java ! src/windows/classes/sun/nio/fs/WindowsSecurity.java ! src/windows/native/sun/nio/fs/WindowsNativeDispatcher.c Changeset: e33cbbe21419 Author: alanb Date: 2013-03-13 17:58 +0000 URL: http://hg.openjdk.java.net/hsx/hotspot-main/jdk/rev/e33cbbe21419 8009751: (se) Selector spin when select, close and interestOps(0) invoked at same time (lnx) Reviewed-by: zhouyx, chegar, robm ! src/solaris/classes/sun/nio/ch/EPollArrayWrapper.java ! src/solaris/classes/sun/nio/ch/EPollSelectorImpl.java Changeset: 94335b6ffb32 Author: jgish Date: 2013-03-13 11:24 -0400 URL: http://hg.openjdk.java.net/hsx/hotspot-main/jdk/rev/94335b6ffb32 8002070: Remove the stack search for a resource bundle for Logger to use Summary: The fragile, vulnerable, stack crawling has been eliminated from findResourceBundle(String) Reviewed-by: mchung, alanb ! src/share/classes/java/util/logging/Logger.java ! test/java/util/logging/LoggerResourceBundleRace.java Changeset: ef0c60b93a17 Author: dxu Date: 2013-03-13 14:50 -0700 URL: http://hg.openjdk.java.net/hsx/hotspot-main/jdk/rev/ef0c60b93a17 8001334: Remove use of JVM_* functions from java.io code Summary: Replace JVM_* functions with direct system calls in java io area Reviewed-by: alanb, uta, martin ! make/java/nio/Makefile ! makefiles/CompileNativeLibraries.gmk ! src/share/native/java/io/ObjectOutputStream.c ! src/share/native/java/io/io_util.c ! src/share/native/java/io/io_util.h ! src/solaris/native/common/jdk_util_md.h ! src/solaris/native/java/io/FileDescriptor_md.c ! src/solaris/native/java/io/UnixFileSystem_md.c ! src/solaris/native/java/io/io_util_md.c ! src/solaris/native/java/io/io_util_md.h ! src/windows/native/common/jdk_util_md.h ! src/windows/native/java/io/io_util_md.c ! src/windows/native/java/io/io_util_md.h Changeset: f5c85c0a9af0 Author: robm Date: 2013-03-14 00:21 +0000 URL: http://hg.openjdk.java.net/hsx/hotspot-main/jdk/rev/f5c85c0a9af0 8009650: HttpClient available() check throws SocketException when connection has been closed Reviewed-by: chegar, khazra, dsamersoff Contributed-by: sdouglas at redhat.com ! src/share/classes/sun/net/www/http/HttpClient.java + test/sun/net/www/http/HttpClient/IsAvailable.java Changeset: 41289b4a1819 Author: dholmes Date: 2013-03-14 01:47 -0400 URL: http://hg.openjdk.java.net/hsx/hotspot-main/jdk/rev/41289b4a1819 8009429: Miscellaneous profiles cleanup 8009428: Revert changes to $ substitution performed as part of nashorn integration Reviewed-by: alanb, erikj ! makefiles/CreateJars.gmk ! makefiles/ProfileNames.gmk ! makefiles/Profiles.gmk ! makefiles/profile-includes.txt ! makefiles/profile-rtjar-includes.txt Changeset: f010eb1e696f Author: alanb Date: 2013-03-14 16:03 +0000 URL: http://hg.openjdk.java.net/hsx/hotspot-main/jdk/rev/f010eb1e696f 8005716: Enhance JNI specification to allow support of static JNI libraries in Embedded JREs Reviewed-by: dlong, alanb, mduigou Contributed-by: bill.pittore at oracle.com, bob.vandette at oracle.com ! make/java/java/mapfile-vers ! makefiles/mapfiles/libjava/mapfile-vers ! src/share/classes/java/lang/ClassLoader.java ! src/share/classes/java/lang/Runtime.java ! src/share/classes/java/lang/System.java ! src/share/javavm/export/jni.h ! src/share/native/common/jni_util.h ! src/share/native/java/lang/ClassLoader.c ! src/solaris/native/common/jni_util_md.c ! src/windows/native/common/jni_util_md.c Changeset: ca9469a15792 Author: alanb Date: 2013-03-14 16:59 +0000 URL: http://hg.openjdk.java.net/hsx/hotspot-main/jdk/rev/ca9469a15792 7183800: TEST_BUG: Update tests to run on Ubuntu 12.04 (localhost is 127.0.1.1) Reviewed-by: alanb, chegar Contributed-by: yiming.wang at oracle.com ! test/java/nio/channels/DatagramChannel/Connect.java ! test/java/nio/channels/DatagramChannel/ConnectedSend.java ! test/java/nio/channels/spi/SelectorProvider/inheritedChannel/Launcher.java ! test/javax/management/remote/mandatory/connection/RMIConnectionIdTest.java Changeset: d79503c4c56f Author: naoto Date: 2013-03-14 11:29 -0700 URL: http://hg.openjdk.java.net/hsx/hotspot-main/jdk/rev/d79503c4c56f 8008576: Calendar mismatch using Host LocaleProviderAdapter Reviewed-by: okutsu ! make/java/java/FILES_java.gmk ! src/macosx/classes/sun/util/locale/provider/HostLocaleProviderAdapterImpl.java ! src/share/classes/java/util/Calendar.java ! src/share/classes/sun/util/locale/LanguageTag.java ! src/share/classes/sun/util/locale/provider/AuxLocaleProviderAdapter.java + src/share/classes/sun/util/locale/provider/CalendarProviderImpl.java ! src/share/classes/sun/util/locale/provider/JRELocaleProviderAdapter.java ! src/share/classes/sun/util/locale/provider/LocaleProviderAdapter.java + src/share/classes/sun/util/spi/CalendarProvider.java ! src/windows/classes/sun/util/locale/provider/HostLocaleProviderAdapterImpl.java ! src/windows/native/sun/util/locale/provider/HostLocaleProviderAdapter_md.c Changeset: 46ad8dfabd5f Author: sundar Date: 2013-03-15 19:30 +0530 URL: http://hg.openjdk.java.net/hsx/hotspot-main/jdk/rev/46ad8dfabd5f 8010136: Make jrunscript's init.js to work on nashorn Reviewed-by: lagergren, hannesw ! src/share/classes/com/sun/tools/script/shell/init.js Changeset: c1a142965db0 Author: lana Date: 2013-03-15 23:31 -0700 URL: http://hg.openjdk.java.net/hsx/hotspot-main/jdk/rev/c1a142965db0 Merge ! makefiles/CompileNativeLibraries.gmk ! src/share/classes/java/util/logging/Logger.java - src/share/classes/sun/security/util/KeyLength.java Changeset: c1165d566a23 Author: vlivanov Date: 2013-03-06 16:59 +0400 URL: http://hg.openjdk.java.net/hsx/hotspot-main/jdk/rev/c1165d566a23 8009222: java.lang.IllegalArgumentException: not invocable, no method type when attempting to get getter method handle for a static field Reviewed-by: jrose, twisti ! src/share/classes/java/lang/invoke/DirectMethodHandle.java + test/java/lang/invoke/8009222/Test8009222.java Changeset: ec8229b26dbc Author: chegar Date: 2013-03-17 09:55 +0000 URL: http://hg.openjdk.java.net/hsx/hotspot-main/jdk/rev/ec8229b26dbc 8010142: ProblemList.txt updates (3/2013) Reviewed-by: alanb ! test/ProblemList.txt Changeset: a0275a47fa78 Author: sla Date: 2013-03-19 09:53 +0100 URL: http://hg.openjdk.java.net/hsx/hotspot-main/jdk/rev/a0275a47fa78 8006637: Failure to filter out native frame events on Solaris Summary: Test is confused by other threads calling String.intern(). Add a thread filter to avoid this. Reviewed-by: sspitsyn, alanb ! test/com/sun/jdi/NativeInstanceFilter.java Changeset: e766da5575fa Author: dholmes Date: 2013-03-19 06:01 -0400 URL: http://hg.openjdk.java.net/hsx/hotspot-main/jdk/rev/e766da5575fa 8009426: "profiles" target fails due to nashorn if "images" is not built first Reviewed-by: alanb ! makefiles/CreateJars.gmk ! makefiles/Profiles.gmk ! makefiles/profile-includes.txt Changeset: 4103eb6b2137 Author: jzavgren Date: 2013-03-18 14:21 -0400 URL: http://hg.openjdk.java.net/hsx/hotspot-main/jdk/rev/4103eb6b2137 8007607: security native code doesn't always use malloc, realloc, and calloc correctly Reviewed-by: chegar, dsamersoff, valeriep ! src/share/native/sun/security/jgss/wrapper/GSSLibStub.c ! src/share/native/sun/security/jgss/wrapper/NativeUtil.c ! src/solaris/native/com/sun/security/auth/module/Solaris.c ! src/solaris/native/com/sun/security/auth/module/Unix.c ! src/solaris/native/sun/security/smartcardio/pcsc_md.c Changeset: 2241a2d34085 Author: mduigou Date: 2013-03-19 16:05 -0700 URL: http://hg.openjdk.java.net/hsx/hotspot-main/jdk/rev/2241a2d34085 8001642: Add Optional, OptionalDouble, OptionalInt, OptionalLong Reviewed-by: mduigou, darcy, alanb, jjb Contributed-by: Brian Goetz + src/share/classes/java/util/Optional.java + src/share/classes/java/util/OptionalDouble.java + src/share/classes/java/util/OptionalInt.java + src/share/classes/java/util/OptionalLong.java + test/java/util/Optional/Basic.java + test/java/util/Optional/BasicDouble.java + test/java/util/Optional/BasicInt.java + test/java/util/Optional/BasicLong.java Changeset: fb23896a01f5 Author: uta Date: 2013-03-20 13:21 +0400 URL: http://hg.openjdk.java.net/hsx/hotspot-main/jdk/rev/fb23896a01f5 8006193: (process) Clean-up java.lang.ProcessImpl.finalize, does not need to be public Reviewed-by: alanb ! src/windows/classes/java/lang/ProcessImpl.java Changeset: 3070b7363853 Author: chegar Date: 2013-03-20 14:39 +0000 URL: http://hg.openjdk.java.net/hsx/hotspot-main/jdk/rev/3070b7363853 8010282: sun.net.www.protocol.jar.JarFileFactory.close(JarFile) should be thread-safe Reviewed-by: khazra, alanb ! src/share/classes/sun/net/www/protocol/jar/JarURLConnection.java ! src/solaris/classes/sun/net/www/protocol/jar/JarFileFactory.java ! src/windows/classes/sun/net/www/protocol/jar/JarFileFactory.java Changeset: 38116bfe5323 Author: mullan Date: 2013-03-20 10:58 -0400 URL: http://hg.openjdk.java.net/hsx/hotspot-main/jdk/rev/38116bfe5323 8010112: NullPointerException in sun.security.provider.certpath.CertId() Reviewed-by: vinnie ! src/share/classes/sun/security/provider/certpath/CertId.java ! src/share/classes/sun/security/provider/certpath/DistributionPointFetcher.java ! src/share/classes/sun/security/provider/certpath/RevocationChecker.java ! src/share/classes/sun/security/x509/X509CertImpl.java Changeset: 9859856920ed Author: mullan Date: 2013-03-20 11:23 -0400 URL: http://hg.openjdk.java.net/hsx/hotspot-main/jdk/rev/9859856920ed Merge - src/share/classes/sun/security/util/KeyLength.java Changeset: 38c1d0c2d6a6 Author: mullan Date: 2013-03-20 12:06 -0400 URL: http://hg.openjdk.java.net/hsx/hotspot-main/jdk/rev/38c1d0c2d6a6 Merge Changeset: ccd9f53377c4 Author: mchung Date: 2013-03-20 09:50 -0700 URL: http://hg.openjdk.java.net/hsx/hotspot-main/jdk/rev/ccd9f53377c4 8006104: Improve tests to test ".useParentHandlers" property set in the logging configuration Reviewed-by: alanb ! test/java/util/logging/CustomLogManager.java ! test/java/util/logging/CustomLogManagerTest.java Changeset: cf0049037deb Author: darcy Date: 2013-03-20 15:21 -0700 URL: http://hg.openjdk.java.net/hsx/hotspot-main/jdk/rev/cf0049037deb 8010427: Refine Method.isDefault implementation Reviewed-by: acorn, dlsmith ! src/share/classes/java/lang/reflect/Method.java Changeset: 3c1a4966d901 Author: dholmes Date: 2013-03-20 22:39 -0400 URL: http://hg.openjdk.java.net/hsx/hotspot-main/jdk/rev/3c1a4966d901 8006818: SunEC and SunPKCS11 providers should be in all profiles Reviewed-by: dholmes, alanb, valeriep Contributed-by: Jen Dority ! makefiles/profile-includes.txt Changeset: 9ee1aff76498 Author: sundar Date: 2013-03-21 19:19 +0530 URL: http://hg.openjdk.java.net/hsx/hotspot-main/jdk/rev/9ee1aff76498 8009869: Need to modify java.security property package.access to include nashorn packages Reviewed-by: ahgross, jlaskey, lagergren ! src/share/lib/security/java.security-linux ! src/share/lib/security/java.security-macosx ! src/share/lib/security/java.security-solaris ! src/share/lib/security/java.security-windows Changeset: 3f8fbb0ab155 Author: robm Date: 2013-03-21 17:33 +0000 URL: http://hg.openjdk.java.net/hsx/hotspot-main/jdk/rev/3f8fbb0ab155 8009251: Add proxy handling and keep-alive fixes to jsse Reviewed-by: chegar ! src/share/classes/sun/net/www/http/HttpClient.java ! src/share/classes/sun/net/www/protocol/https/AbstractDelegateHttpsURLConnection.java ! src/share/classes/sun/net/www/protocol/https/HttpsClient.java Changeset: 93cd7052d306 Author: weijun Date: 2013-03-22 19:59 +0800 URL: http://hg.openjdk.java.net/hsx/hotspot-main/jdk/rev/93cd7052d306 8010531: Add BadKdc* tests to problem list for solaris-sparcv9 Reviewed-by: alanb ! test/ProblemList.txt Changeset: 470232a8e89d Author: stefank Date: 2013-03-22 15:01 +0100 URL: http://hg.openjdk.java.net/hsx/hotspot-main/jdk/rev/470232a8e89d 8005116: NPG: Rename -permstat option for jmap in jdk8 to -clstats Reviewed-by: jmasa, sla Contributed-by: Erik Helin ! src/share/classes/sun/tools/jmap/JMap.java Changeset: 518d6087e01f Author: stefank Date: 2013-03-22 15:01 +0100 URL: http://hg.openjdk.java.net/hsx/hotspot-main/jdk/rev/518d6087e01f 8004172: Update jstat counter names to reflect metaspace changes Reviewed-by: mchung Contributed-by: Erik Helin ! src/share/classes/sun/tools/jstat/resources/jstat_options ! test/sun/tools/jstat/gcCapacityOutput1.awk ! test/sun/tools/jstat/gcCauseOutput1.awk + test/sun/tools/jstat/gcMetaCapacityOutput1.awk ! test/sun/tools/jstat/gcOldOutput1.awk ! test/sun/tools/jstat/gcOutput1.awk - test/sun/tools/jstat/gcPermCapacityOutput1.awk + test/sun/tools/jstat/jstatGcMetaCapacityOutput1.sh - test/sun/tools/jstat/jstatGcPermCapacityOutput1.sh ! test/sun/tools/jstat/lineCounts1.awk ! test/sun/tools/jstat/lineCounts2.awk ! test/sun/tools/jstat/lineCounts3.awk ! test/sun/tools/jstat/lineCounts4.awk ! test/sun/tools/jstat/options1.out ! test/sun/tools/jstat/options2.out ! test/sun/tools/jstat/timeStamp1.awk ! test/sun/tools/jstatd/jstatGcutilOutput1.awk Changeset: 3470101fae58 Author: weijun Date: 2013-03-23 11:49 +0800 URL: http://hg.openjdk.java.net/hsx/hotspot-main/jdk/rev/3470101fae58 8009970: Several LoginModule classes need extra permission to load AuthResources Reviewed-by: mullan ! src/share/classes/com/sun/security/auth/module/JndiLoginModule.java ! src/share/classes/com/sun/security/auth/module/KeyStoreLoginModule.java ! src/share/classes/com/sun/security/auth/module/Krb5LoginModule.java Changeset: ed63cace1d30 Author: weijun Date: 2013-03-23 11:49 +0800 URL: http://hg.openjdk.java.net/hsx/hotspot-main/jdk/rev/ed63cace1d30 8009875: Provide a default udp_preference_limit for krb5.conf Reviewed-by: valeriep ! src/share/classes/sun/security/krb5/KdcComm.java ! src/share/classes/sun/security/krb5/internal/Krb5.java ! test/sun/security/krb5/auto/KDC.java + test/sun/security/krb5/config/DefUdpLimit.java Changeset: d92a96dcbfe1 Author: sundar Date: 2013-03-25 19:25 +0530 URL: http://hg.openjdk.java.net/hsx/hotspot-main/jdk/rev/d92a96dcbfe1 8010704: The test closed/java/lang/SecurityManager/CheckPackageDefinition.java failed after fix for 8009869 Reviewed-by: lagergren, hannesw ! src/share/lib/security/java.security-linux ! src/share/lib/security/java.security-solaris Changeset: 5d0c891264bf Author: chegar Date: 2013-03-25 14:29 +0000 URL: http://hg.openjdk.java.net/hsx/hotspot-main/jdk/rev/5d0c891264bf 8010668: builtin JNI libraries should not be unloaded Reviewed-by: chegar, alanb Contributed-by: Bill Pittore ! src/share/native/java/lang/ClassLoader.c Changeset: 5e383a73386a Author: mchung Date: 2013-03-25 17:19 -0700 URL: http://hg.openjdk.java.net/hsx/hotspot-main/jdk/rev/5e383a73386a 8007703: Remove com.sun.servicetag API Reviewed-by: dholmes, alanb, erikj ! make/com/sun/Makefile ! make/common/Release.gmk ! makefiles/CopyFiles.gmk ! makefiles/CopyIntoClasses.gmk ! makefiles/CreateJars.gmk ! makefiles/GensrcProperties.gmk ! makefiles/profile-includes.txt ! makefiles/profile-rtjar-includes.txt ! test/Makefile Changeset: 335d2156222e Author: mchung Date: 2013-03-25 18:14 -0700 URL: http://hg.openjdk.java.net/hsx/hotspot-main/jdk/rev/335d2156222e 8010787: changeset for 8007703 is missing the deleted files Reviewed-by: dholmes, alanb, erikj - make/com/sun/servicetag/Makefile - src/share/classes/com/sun/servicetag/BrowserSupport.java - src/share/classes/com/sun/servicetag/Installer.java - src/share/classes/com/sun/servicetag/LinuxSystemEnvironment.java - src/share/classes/com/sun/servicetag/RegistrationData.java - src/share/classes/com/sun/servicetag/RegistrationDocument.java - src/share/classes/com/sun/servicetag/Registry.java - src/share/classes/com/sun/servicetag/ServiceTag.java - src/share/classes/com/sun/servicetag/SolarisServiceTag.java - src/share/classes/com/sun/servicetag/SolarisSystemEnvironment.java - src/share/classes/com/sun/servicetag/SunConnection.java - src/share/classes/com/sun/servicetag/SystemEnvironment.java - src/share/classes/com/sun/servicetag/UnauthorizedAccessException.java - src/share/classes/com/sun/servicetag/Util.java - src/share/classes/com/sun/servicetag/WindowsSystemEnvironment.java - src/share/classes/com/sun/servicetag/package.html - src/share/classes/com/sun/servicetag/resources/Putback-Notes.txt - src/share/classes/com/sun/servicetag/resources/javase_5_swordfish.properties - src/share/classes/com/sun/servicetag/resources/javase_6_swordfish.properties - src/share/classes/com/sun/servicetag/resources/javase_7_swordfish.properties - src/share/classes/com/sun/servicetag/resources/javase_servicetag.properties - src/share/classes/com/sun/servicetag/resources/jdk_header.png - src/share/classes/com/sun/servicetag/resources/product_registration.xsd - src/share/classes/com/sun/servicetag/resources/register.html - src/share/classes/com/sun/servicetag/resources/register_ja.html - src/share/classes/com/sun/servicetag/resources/register_zh_CN.html - test/com/sun/servicetag/DeleteServiceTag.java - test/com/sun/servicetag/DuplicateNotFound.java - test/com/sun/servicetag/FindServiceTags.java - test/com/sun/servicetag/InstanceUrnCheck.java - test/com/sun/servicetag/InvalidRegistrationData.java - test/com/sun/servicetag/InvalidServiceTag.java - test/com/sun/servicetag/JavaServiceTagTest.java - test/com/sun/servicetag/JavaServiceTagTest1.java - test/com/sun/servicetag/NewRegistrationData.java - test/com/sun/servicetag/SvcTagClient.java - test/com/sun/servicetag/SystemRegistryTest.java - test/com/sun/servicetag/TestLoadFromXML.java - test/com/sun/servicetag/UpdateServiceTagTest.java - test/com/sun/servicetag/Util.java - test/com/sun/servicetag/ValidRegistrationData.java - test/com/sun/servicetag/environ.properties - test/com/sun/servicetag/missing-environ-field.xml - test/com/sun/servicetag/newer-registry-version.xml - test/com/sun/servicetag/registration.xml - test/com/sun/servicetag/servicetag1.properties - test/com/sun/servicetag/servicetag2.properties - test/com/sun/servicetag/servicetag3.properties - test/com/sun/servicetag/servicetag4.properties - test/com/sun/servicetag/servicetag5.properties Changeset: 543d0fbc962e Author: lana Date: 2013-03-26 12:04 -0700 URL: http://hg.openjdk.java.net/hsx/hotspot-main/jdk/rev/543d0fbc962e Merge - make/com/sun/servicetag/Makefile ! makefiles/CompileNativeLibraries.gmk - src/share/classes/com/sun/servicetag/BrowserSupport.java - src/share/classes/com/sun/servicetag/Installer.java - src/share/classes/com/sun/servicetag/LinuxSystemEnvironment.java - src/share/classes/com/sun/servicetag/RegistrationData.java - src/share/classes/com/sun/servicetag/RegistrationDocument.java - src/share/classes/com/sun/servicetag/Registry.java - src/share/classes/com/sun/servicetag/ServiceTag.java - src/share/classes/com/sun/servicetag/SolarisServiceTag.java - src/share/classes/com/sun/servicetag/SolarisSystemEnvironment.java - src/share/classes/com/sun/servicetag/SunConnection.java - src/share/classes/com/sun/servicetag/SystemEnvironment.java - src/share/classes/com/sun/servicetag/UnauthorizedAccessException.java - src/share/classes/com/sun/servicetag/Util.java - src/share/classes/com/sun/servicetag/WindowsSystemEnvironment.java - src/share/classes/com/sun/servicetag/package.html - src/share/classes/com/sun/servicetag/resources/Putback-Notes.txt - src/share/classes/com/sun/servicetag/resources/javase_5_swordfish.properties - src/share/classes/com/sun/servicetag/resources/javase_6_swordfish.properties - src/share/classes/com/sun/servicetag/resources/javase_7_swordfish.properties - src/share/classes/com/sun/servicetag/resources/javase_servicetag.properties - src/share/classes/com/sun/servicetag/resources/jdk_header.png - src/share/classes/com/sun/servicetag/resources/product_registration.xsd - src/share/classes/com/sun/servicetag/resources/register.html - src/share/classes/com/sun/servicetag/resources/register_ja.html - src/share/classes/com/sun/servicetag/resources/register_zh_CN.html - test/com/sun/servicetag/DeleteServiceTag.java - test/com/sun/servicetag/DuplicateNotFound.java - test/com/sun/servicetag/FindServiceTags.java - test/com/sun/servicetag/InstanceUrnCheck.java - test/com/sun/servicetag/InvalidRegistrationData.java - test/com/sun/servicetag/InvalidServiceTag.java - test/com/sun/servicetag/JavaServiceTagTest.java - test/com/sun/servicetag/JavaServiceTagTest1.java - test/com/sun/servicetag/NewRegistrationData.java - test/com/sun/servicetag/SvcTagClient.java - test/com/sun/servicetag/SystemRegistryTest.java - test/com/sun/servicetag/TestLoadFromXML.java - test/com/sun/servicetag/UpdateServiceTagTest.java - test/com/sun/servicetag/Util.java - test/com/sun/servicetag/ValidRegistrationData.java - test/com/sun/servicetag/environ.properties - test/com/sun/servicetag/missing-environ-field.xml - test/com/sun/servicetag/newer-registry-version.xml - test/com/sun/servicetag/registration.xml - test/com/sun/servicetag/servicetag1.properties - test/com/sun/servicetag/servicetag2.properties - test/com/sun/servicetag/servicetag3.properties - test/com/sun/servicetag/servicetag4.properties - test/com/sun/servicetag/servicetag5.properties - test/sun/tools/jstat/gcPermCapacityOutput1.awk - test/sun/tools/jstat/jstatGcPermCapacityOutput1.sh Changeset: ea7d0f49e5dd Author: lana Date: 2013-04-01 21:40 -0700 URL: http://hg.openjdk.java.net/hsx/hotspot-main/jdk/rev/ea7d0f49e5dd Merge - make/com/sun/servicetag/Makefile - src/share/classes/com/sun/servicetag/BrowserSupport.java - src/share/classes/com/sun/servicetag/Installer.java - src/share/classes/com/sun/servicetag/LinuxSystemEnvironment.java - src/share/classes/com/sun/servicetag/RegistrationData.java - src/share/classes/com/sun/servicetag/RegistrationDocument.java - src/share/classes/com/sun/servicetag/Registry.java - src/share/classes/com/sun/servicetag/ServiceTag.java - src/share/classes/com/sun/servicetag/SolarisServiceTag.java - src/share/classes/com/sun/servicetag/SolarisSystemEnvironment.java - src/share/classes/com/sun/servicetag/SunConnection.java - src/share/classes/com/sun/servicetag/SystemEnvironment.java - src/share/classes/com/sun/servicetag/UnauthorizedAccessException.java - src/share/classes/com/sun/servicetag/Util.java - src/share/classes/com/sun/servicetag/WindowsSystemEnvironment.java - src/share/classes/com/sun/servicetag/package.html - src/share/classes/com/sun/servicetag/resources/Putback-Notes.txt - src/share/classes/com/sun/servicetag/resources/javase_5_swordfish.properties - src/share/classes/com/sun/servicetag/resources/javase_6_swordfish.properties - src/share/classes/com/sun/servicetag/resources/javase_7_swordfish.properties - src/share/classes/com/sun/servicetag/resources/javase_servicetag.properties - src/share/classes/com/sun/servicetag/resources/jdk_header.png - src/share/classes/com/sun/servicetag/resources/product_registration.xsd - src/share/classes/com/sun/servicetag/resources/register.html - src/share/classes/com/sun/servicetag/resources/register_ja.html - src/share/classes/com/sun/servicetag/resources/register_zh_CN.html - test/com/sun/servicetag/DeleteServiceTag.java - test/com/sun/servicetag/DuplicateNotFound.java - test/com/sun/servicetag/FindServiceTags.java - test/com/sun/servicetag/InstanceUrnCheck.java - test/com/sun/servicetag/InvalidRegistrationData.java - test/com/sun/servicetag/InvalidServiceTag.java - test/com/sun/servicetag/JavaServiceTagTest.java - test/com/sun/servicetag/JavaServiceTagTest1.java - test/com/sun/servicetag/NewRegistrationData.java - test/com/sun/servicetag/SvcTagClient.java - test/com/sun/servicetag/SystemRegistryTest.java - test/com/sun/servicetag/TestLoadFromXML.java - test/com/sun/servicetag/UpdateServiceTagTest.java - test/com/sun/servicetag/Util.java - test/com/sun/servicetag/ValidRegistrationData.java - test/com/sun/servicetag/environ.properties - test/com/sun/servicetag/missing-environ-field.xml - test/com/sun/servicetag/newer-registry-version.xml - test/com/sun/servicetag/registration.xml - test/com/sun/servicetag/servicetag1.properties - test/com/sun/servicetag/servicetag2.properties - test/com/sun/servicetag/servicetag3.properties - test/com/sun/servicetag/servicetag4.properties - test/com/sun/servicetag/servicetag5.properties - test/sun/tools/jstat/gcPermCapacityOutput1.awk - test/sun/tools/jstat/jstatGcPermCapacityOutput1.sh Changeset: b68094f8263f Author: erikj Date: 2013-03-28 09:36 +0100 URL: http://hg.openjdk.java.net/hsx/hotspot-main/jdk/rev/b68094f8263f 8010908: Images target failes when configured with --disable-zip-debug-info Reviewed-by: tbell ! makefiles/Images.gmk Changeset: 9c76ea43d491 Author: omajid Date: 2013-04-02 14:13 -0400 URL: http://hg.openjdk.java.net/hsx/hotspot-main/jdk/rev/9c76ea43d491 8011278: Allow using a system-installed giflib Reviewed-by: andrew, prr ! makefiles/CompileNativeLibraries.gmk ! src/share/native/sun/awt/splashscreen/splashscreen_gif.c Changeset: 7b4721e4edb4 Author: katleman Date: 2013-04-02 15:31 -0700 URL: http://hg.openjdk.java.net/hsx/hotspot-main/jdk/rev/7b4721e4edb4 Merge ! makefiles/CompileNativeLibraries.gmk Changeset: 43da85020921 Author: katleman Date: 2013-04-04 19:05 -0700 URL: http://hg.openjdk.java.net/hsx/hotspot-main/jdk/rev/43da85020921 Added tag jdk8-b84 for changeset 7b4721e4edb4 ! .hgtags From john.coomes at oracle.com Thu Apr 4 20:50:54 2013 From: john.coomes at oracle.com (john.coomes at oracle.com) Date: Fri, 05 Apr 2013 03:50:54 +0000 Subject: hg: hsx/hotspot-main/nashorn: 16 new changesets Message-ID: <20130405035106.1A1A4480A2@hg.openjdk.java.net> Changeset: c54e218333be Author: sundar Date: 2013-03-12 18:12 +0530 URL: http://hg.openjdk.java.net/hsx/hotspot-main/nashorn/rev/c54e218333be 8009757: Package access clean up and refactoring Reviewed-by: jlaskey, lagergren, attila ! docs/JavaScriptingProgrammersGuide.html ! docs/source/javaarray.js ! make/build.xml ! make/java.security.override ! src/jdk/nashorn/api/scripting/NashornScriptEngineFactory.java + src/jdk/nashorn/api/scripting/ScriptUtils.java ! src/jdk/nashorn/internal/objects/Global.java ! src/jdk/nashorn/internal/objects/NativeDebug.java ! src/jdk/nashorn/internal/objects/NativeJava.java ! src/jdk/nashorn/internal/runtime/Context.java ! src/jdk/nashorn/internal/runtime/NashornLoader.java ! src/jdk/nashorn/internal/runtime/ScriptLoader.java ! src/jdk/nashorn/internal/runtime/StructureLoader.java ! src/jdk/nashorn/internal/runtime/linker/Bootstrap.java ! src/jdk/nashorn/internal/runtime/linker/JavaAdapterFactory.java + src/jdk/nashorn/internal/runtime/linker/ReflectionCheckLinker.java ! src/jdk/nashorn/internal/runtime/resources/mozilla_compat.js ! src/jdk/nashorn/internal/runtime/resources/parser.js ! test/script/basic/JDK-8008448.js ! test/script/basic/NASHORN-401.js ! test/script/basic/consstring.js ! test/script/basic/fileline.js ! test/script/basic/javainnerclasses.js ! test/script/basic/list.js ! test/script/basic/map.js ! test/script/basic/stdin.js ! test/script/sandbox/javaextend.js ! test/script/sandbox/javaextend.js.EXPECTED ! test/script/sandbox/reflection.js - test/script/sandbox/reflection.js.EXPECTED ! test/script/sandbox/unsafe.js - test/script/sandbox/unsafe.js.EXPECTED ! test/script/trusted/urlreader.js ! test/src/jdk/nashorn/api/scripting/ScriptEngineTest.java - test/src/jdk/nashorn/internal/runtime/Nashorn401TestSubject.java ! test/src/jdk/nashorn/internal/runtime/TrustedScriptEngineTest.java - test/src/jdk/nashorn/internal/test/models/ConstructorWithArgument.java - test/src/jdk/nashorn/internal/test/models/DessertTopping.java - test/src/jdk/nashorn/internal/test/models/DessertToppingFloorWaxDriver.java - test/src/jdk/nashorn/internal/test/models/FinalClass.java - test/src/jdk/nashorn/internal/test/models/FloorWax.java - test/src/jdk/nashorn/internal/test/models/NoAccessibleConstructorClass.java - test/src/jdk/nashorn/internal/test/models/NonPublicClass.java - test/src/jdk/nashorn/internal/test/models/OuterClass.java - test/src/jdk/nashorn/internal/test/models/OverloadedSam.java - test/src/jdk/nashorn/internal/test/models/OverrideObject.java - test/src/jdk/nashorn/internal/test/models/StringArgs.java - test/src/jdk/nashorn/internal/test/models/Toothpaste.java + test/src/jdk/nashorn/test/models/ConstructorWithArgument.java + test/src/jdk/nashorn/test/models/DessertTopping.java + test/src/jdk/nashorn/test/models/DessertToppingFloorWaxDriver.java + test/src/jdk/nashorn/test/models/FinalClass.java + test/src/jdk/nashorn/test/models/FloorWax.java + test/src/jdk/nashorn/test/models/Nashorn401TestSubject.java + test/src/jdk/nashorn/test/models/NoAccessibleConstructorClass.java + test/src/jdk/nashorn/test/models/NonPublicClass.java + test/src/jdk/nashorn/test/models/OuterClass.java + test/src/jdk/nashorn/test/models/OverloadedSam.java + test/src/jdk/nashorn/test/models/OverrideObject.java + test/src/jdk/nashorn/test/models/SourceHelper.java + test/src/jdk/nashorn/test/models/StringArgs.java + test/src/jdk/nashorn/test/models/Toothpaste.java Changeset: e15806b9d716 Author: lagergren Date: 2013-03-12 15:30 +0100 URL: http://hg.openjdk.java.net/hsx/hotspot-main/nashorn/rev/e15806b9d716 8009718: Lazy execution architecture continued - ScriptFunctionData is either final or recompilable. Moved ScriptFunctionData creation logic away from runtime to compile time. Prepared for method generation/specialization. Got rid of ScriptFunctionImplTrampoline whose semantics could be done as part of the relinking anyway. Merge with the lookup package change. Reviewed-by: attila, jlaskey ! src/jdk/nashorn/internal/codegen/Attr.java ! src/jdk/nashorn/internal/codegen/BranchOptimizer.java ! src/jdk/nashorn/internal/codegen/CodeGenerator.java ! src/jdk/nashorn/internal/codegen/CompilationPhase.java ! src/jdk/nashorn/internal/codegen/CompileUnit.java ! src/jdk/nashorn/internal/codegen/Compiler.java ! src/jdk/nashorn/internal/codegen/FinalizeTypes.java ! src/jdk/nashorn/internal/codegen/FoldConstants.java ! src/jdk/nashorn/internal/codegen/FunctionSignature.java ! src/jdk/nashorn/internal/codegen/Lower.java ! src/jdk/nashorn/internal/codegen/Splitter.java ! src/jdk/nashorn/internal/codegen/types/Type.java ! src/jdk/nashorn/internal/ir/Block.java ! src/jdk/nashorn/internal/ir/FunctionNode.java ! src/jdk/nashorn/internal/ir/ObjectNode.java ! src/jdk/nashorn/internal/ir/UnaryNode.java - src/jdk/nashorn/internal/ir/annotations/ChildNode.java - src/jdk/nashorn/internal/ir/annotations/ParentNode.java ! src/jdk/nashorn/internal/ir/annotations/Reference.java ! src/jdk/nashorn/internal/ir/debug/ASTWriter.java ! src/jdk/nashorn/internal/objects/NativeArray.java ! src/jdk/nashorn/internal/objects/NativeDebug.java ! src/jdk/nashorn/internal/objects/NativeError.java ! src/jdk/nashorn/internal/objects/ScriptFunctionImpl.java - src/jdk/nashorn/internal/objects/ScriptFunctionTrampolineImpl.java ! src/jdk/nashorn/internal/parser/JSONParser.java ! src/jdk/nashorn/internal/parser/Parser.java ! src/jdk/nashorn/internal/runtime/AccessorProperty.java ! src/jdk/nashorn/internal/runtime/CodeInstaller.java + src/jdk/nashorn/internal/runtime/CompiledFunction.java + src/jdk/nashorn/internal/runtime/CompiledFunctions.java ! src/jdk/nashorn/internal/runtime/Context.java ! src/jdk/nashorn/internal/runtime/ECMAException.java + src/jdk/nashorn/internal/runtime/FinalScriptFunctionData.java + src/jdk/nashorn/internal/runtime/RecompilableScriptFunctionData.java ! src/jdk/nashorn/internal/runtime/ScriptEnvironment.java ! src/jdk/nashorn/internal/runtime/ScriptFunction.java ! src/jdk/nashorn/internal/runtime/ScriptFunctionData.java - src/jdk/nashorn/internal/runtime/SpecializedMethodChooser.java ! src/jdk/nashorn/internal/runtime/linker/JavaArgumentConverters.java ! src/jdk/nashorn/internal/runtime/linker/NashornGuards.java ! src/jdk/nashorn/internal/runtime/options/OptionTemplate.java ! src/jdk/nashorn/internal/runtime/resources/Options.properties ! test/script/currently-failing/JDK-8006529.js + test/script/currently-failing/clone_ir.js Changeset: 60684aeba89c Author: sundar Date: 2013-03-12 21:17 +0530 URL: http://hg.openjdk.java.net/hsx/hotspot-main/nashorn/rev/60684aeba89c 8009868: For loop with "true" as condition results in AssertionError in codegen Reviewed-by: jlaskey, hannesw, lagergren ! src/jdk/nashorn/internal/codegen/Lower.java + test/script/basic/JDK-8009868.js Changeset: 390d44ba90cf Author: lagergren Date: 2013-03-14 14:49 +0100 URL: http://hg.openjdk.java.net/hsx/hotspot-main/nashorn/rev/390d44ba90cf 8009982: Lazy execution bugfix. Added lazy sunspider unit test. Added mandreel to compile-octane test. Fixed warnings Reviewed-by: sundar, jlaskey ! src/jdk/nashorn/api/scripting/NashornScriptEngineFactory.java ! src/jdk/nashorn/internal/codegen/CodeGenerator.java ! src/jdk/nashorn/internal/codegen/Compiler.java ! src/jdk/nashorn/internal/ir/FunctionNode.java ! src/jdk/nashorn/internal/objects/Global.java ! src/jdk/nashorn/internal/parser/Parser.java ! src/jdk/nashorn/internal/runtime/Context.java ! src/jdk/nashorn/internal/runtime/ScriptLoader.java ! src/jdk/nashorn/internal/runtime/linker/JavaAdapterFactory.java ! src/jdk/nashorn/internal/runtime/regexp/DefaultRegExp.java ! src/jdk/nashorn/internal/runtime/regexp/JoniRegExp.java ! src/jdk/nashorn/internal/runtime/regexp/RegExp.java ! src/jdk/nashorn/internal/runtime/regexp/RegExpFactory.java ! src/jdk/nashorn/internal/runtime/regexp/RegExpResult.java ! src/jdk/nashorn/internal/runtime/regexp/RegExpScanner.java ! test/script/basic/compile-octane.js.EXPECTED ! test/script/basic/run-octane.js + test/script/basic/runsunspider-eager.js + test/script/basic/runsunspider-lazy.js ! test/script/basic/runsunspider.js Changeset: d5d80b52cf1c Author: lagergren Date: 2013-03-15 16:07 +0100 URL: http://hg.openjdk.java.net/hsx/hotspot-main/nashorn/rev/d5d80b52cf1c 8010147: Forgot to add EXPECTED files for lazy and eager sunspider test Reviewed-by: sundar, jlaskey + test/script/basic/runsunspider-eager.js.EXPECTED + test/script/basic/runsunspider-lazy.js.EXPECTED - test/script/basic/runsunspider.js.EXPECTED Changeset: 4daacf8a25ef Author: sundar Date: 2013-03-15 21:52 +0530 URL: http://hg.openjdk.java.net/hsx/hotspot-main/nashorn/rev/4daacf8a25ef 8010145: removed workaround "init.js" in nashorn repo Reviewed-by: jlaskey, lagergren ! src/jdk/nashorn/api/scripting/Formatter.java ! src/jdk/nashorn/api/scripting/NashornScriptEngine.java ! src/jdk/nashorn/api/scripting/ScriptUtils.java ! src/jdk/nashorn/api/scripting/resources/engine.js - src/jdk/nashorn/api/scripting/resources/init.js Changeset: 3b0a0d9d51f0 Author: sundar Date: 2013-03-18 21:03 +0530 URL: http://hg.openjdk.java.net/hsx/hotspot-main/nashorn/rev/3b0a0d9d51f0 8010199: javax.script.Invocable implementation for nashorn does not return null when matching functions are missing Reviewed-by: lagergren, jlaskey ! bin/jjs ! bin/jjssecure ! bin/nashorn ! bin/nashornsecure ! src/jdk/nashorn/api/scripting/NashornScriptEngine.java + test/script/basic/JDK-8010199.js ! test/src/jdk/nashorn/api/scripting/ScriptEngineTest.java Changeset: 606a1946e3e2 Author: jlaskey Date: 2013-03-19 11:03 -0300 URL: http://hg.openjdk.java.net/hsx/hotspot-main/nashorn/rev/606a1946e3e2 8009969: CodeCoverage should use template Reviewed-by: jlaskey, sundar Contributed-by: pavel.stepanov at oracle.com ! make/build.xml ! make/code_coverage.xml ! make/project.properties Changeset: 4be452026847 Author: attila Date: 2013-03-23 00:58 +0100 URL: http://hg.openjdk.java.net/hsx/hotspot-main/nashorn/rev/4be452026847 8010652: Eliminate non-child references in Block/FunctionNode, and make few node types immutable Reviewed-by: jlaskey, lagergren ! make/project.properties ! src/jdk/nashorn/internal/codegen/Attr.java ! src/jdk/nashorn/internal/codegen/ClassEmitter.java ! src/jdk/nashorn/internal/codegen/CodeGenerator.java ! src/jdk/nashorn/internal/codegen/CompilationPhase.java ! src/jdk/nashorn/internal/codegen/Compiler.java ! src/jdk/nashorn/internal/codegen/FinalizeTypes.java ! src/jdk/nashorn/internal/codegen/FoldConstants.java ! src/jdk/nashorn/internal/codegen/FunctionSignature.java ! src/jdk/nashorn/internal/codegen/Lower.java ! src/jdk/nashorn/internal/codegen/MethodEmitter.java ! src/jdk/nashorn/internal/codegen/Splitter.java ! src/jdk/nashorn/internal/codegen/WeighNodes.java ! src/jdk/nashorn/internal/ir/AccessNode.java ! src/jdk/nashorn/internal/ir/Assignment.java ! src/jdk/nashorn/internal/ir/BaseNode.java ! src/jdk/nashorn/internal/ir/BinaryNode.java ! src/jdk/nashorn/internal/ir/Block.java ! src/jdk/nashorn/internal/ir/BreakNode.java ! src/jdk/nashorn/internal/ir/CallNode.java ! src/jdk/nashorn/internal/ir/CaseNode.java ! src/jdk/nashorn/internal/ir/CatchNode.java ! src/jdk/nashorn/internal/ir/ContinueNode.java ! src/jdk/nashorn/internal/ir/DoWhileNode.java ! src/jdk/nashorn/internal/ir/EmptyNode.java ! src/jdk/nashorn/internal/ir/ExecuteNode.java ! src/jdk/nashorn/internal/ir/ForNode.java ! src/jdk/nashorn/internal/ir/FunctionNode.java ! src/jdk/nashorn/internal/ir/IdentNode.java ! src/jdk/nashorn/internal/ir/IfNode.java ! src/jdk/nashorn/internal/ir/IndexNode.java ! src/jdk/nashorn/internal/ir/LabelNode.java + src/jdk/nashorn/internal/ir/LexicalContext.java ! src/jdk/nashorn/internal/ir/LineNumberNode.java ! src/jdk/nashorn/internal/ir/LiteralNode.java ! src/jdk/nashorn/internal/ir/Location.java ! src/jdk/nashorn/internal/ir/Node.java ! src/jdk/nashorn/internal/ir/ObjectNode.java ! src/jdk/nashorn/internal/ir/PropertyNode.java - src/jdk/nashorn/internal/ir/ReferenceNode.java ! src/jdk/nashorn/internal/ir/ReturnNode.java ! src/jdk/nashorn/internal/ir/RuntimeNode.java ! src/jdk/nashorn/internal/ir/SplitNode.java ! src/jdk/nashorn/internal/ir/SwitchNode.java ! src/jdk/nashorn/internal/ir/Symbol.java ! src/jdk/nashorn/internal/ir/TernaryNode.java ! src/jdk/nashorn/internal/ir/ThrowNode.java ! src/jdk/nashorn/internal/ir/TryNode.java ! src/jdk/nashorn/internal/ir/TypeOverride.java ! src/jdk/nashorn/internal/ir/UnaryNode.java ! src/jdk/nashorn/internal/ir/VarNode.java ! src/jdk/nashorn/internal/ir/WhileNode.java ! src/jdk/nashorn/internal/ir/WithNode.java ! src/jdk/nashorn/internal/ir/debug/JSONWriter.java ! src/jdk/nashorn/internal/ir/debug/PrintVisitor.java ! src/jdk/nashorn/internal/ir/visitor/NodeOperatorVisitor.java ! src/jdk/nashorn/internal/ir/visitor/NodeVisitor.java ! src/jdk/nashorn/internal/parser/Parser.java ! src/jdk/nashorn/internal/runtime/Context.java ! src/jdk/nashorn/internal/runtime/resources/Messages.properties ! test/script/basic/JDK-8006755.js ! test/script/basic/NASHORN-837.js ! test/src/jdk/nashorn/internal/codegen/CompilerTest.java Changeset: ae4ef3102d9c Author: lagergren Date: 2013-03-25 12:01 +0100 URL: http://hg.openjdk.java.net/hsx/hotspot-main/nashorn/rev/ae4ef3102d9c 8017010: index evaluation to a temporary location for index operator much change temporaries to slots, but never scoped vars Reviewed-by: hannesw, sundar ! src/jdk/nashorn/internal/codegen/Attr.java ! src/jdk/nashorn/internal/runtime/regexp/joni/ByteCodeMachine.java ! src/jdk/nashorn/internal/runtime/regexp/joni/encoding/AsciiTables.java + test/script/basic/JDK-8017010.js + test/script/basic/JDK-8017010.js.EXPECTED ! test/script/basic/NASHORN-258.js ! test/script/basic/NASHORN-258.js.EXPECTED Changeset: 15dac7439921 Author: sundar Date: 2013-03-25 18:20 +0530 URL: http://hg.openjdk.java.net/hsx/hotspot-main/nashorn/rev/15dac7439921 8010709: org on the top level doesn't resolve Reviewed-by: lagergren, hannesw ! src/jdk/nashorn/internal/objects/Global.java + test/script/basic/JDK-8010709.js Changeset: 43e40c08e7f8 Author: lagergren Date: 2013-03-26 08:42 +0100 URL: http://hg.openjdk.java.net/hsx/hotspot-main/nashorn/rev/43e40c08e7f8 8010706: -Dnashorn.args system property to create command lines to wrapped nashorn.jar:s Reviewed-by: hannesw, sundar ! docs/DEVELOPER_README ! src/jdk/nashorn/internal/runtime/options/Options.java Changeset: ed60078f0a80 Author: sundar Date: 2013-03-26 18:26 +0530 URL: http://hg.openjdk.java.net/hsx/hotspot-main/nashorn/rev/ed60078f0a80 8010720: Linkage problem with java.lang.String.length() Reviewed-by: hannesw, lagergren ! src/jdk/nashorn/internal/objects/NativeString.java ! src/jdk/nashorn/internal/runtime/linker/PrimitiveLookup.java + test/script/basic/JDK-8010720.js Changeset: db8a33cb22b8 Author: lana Date: 2013-03-26 12:08 -0700 URL: http://hg.openjdk.java.net/hsx/hotspot-main/nashorn/rev/db8a33cb22b8 Merge - src/jdk/nashorn/api/scripting/resources/init.js - src/jdk/nashorn/internal/ir/ReferenceNode.java - src/jdk/nashorn/internal/ir/annotations/ChildNode.java - src/jdk/nashorn/internal/ir/annotations/ParentNode.java - src/jdk/nashorn/internal/objects/ScriptFunctionTrampolineImpl.java - src/jdk/nashorn/internal/runtime/SpecializedMethodChooser.java - test/script/basic/runsunspider.js.EXPECTED - test/script/sandbox/reflection.js.EXPECTED - test/script/sandbox/unsafe.js.EXPECTED - test/src/jdk/nashorn/internal/runtime/Nashorn401TestSubject.java - test/src/jdk/nashorn/internal/test/models/ConstructorWithArgument.java - test/src/jdk/nashorn/internal/test/models/DessertTopping.java - test/src/jdk/nashorn/internal/test/models/DessertToppingFloorWaxDriver.java - test/src/jdk/nashorn/internal/test/models/FinalClass.java - test/src/jdk/nashorn/internal/test/models/FloorWax.java - test/src/jdk/nashorn/internal/test/models/NoAccessibleConstructorClass.java - test/src/jdk/nashorn/internal/test/models/NonPublicClass.java - test/src/jdk/nashorn/internal/test/models/OuterClass.java - test/src/jdk/nashorn/internal/test/models/OverloadedSam.java - test/src/jdk/nashorn/internal/test/models/OverrideObject.java - test/src/jdk/nashorn/internal/test/models/StringArgs.java - test/src/jdk/nashorn/internal/test/models/Toothpaste.java Changeset: 999cc1bf5520 Author: lana Date: 2013-04-01 21:42 -0700 URL: http://hg.openjdk.java.net/hsx/hotspot-main/nashorn/rev/999cc1bf5520 Merge - src/jdk/nashorn/api/scripting/resources/init.js - src/jdk/nashorn/internal/ir/ReferenceNode.java - src/jdk/nashorn/internal/ir/annotations/ChildNode.java - src/jdk/nashorn/internal/ir/annotations/ParentNode.java - src/jdk/nashorn/internal/objects/ScriptFunctionTrampolineImpl.java - src/jdk/nashorn/internal/runtime/SpecializedMethodChooser.java - test/script/basic/runsunspider.js.EXPECTED - test/script/sandbox/reflection.js.EXPECTED - test/script/sandbox/unsafe.js.EXPECTED - test/src/jdk/nashorn/internal/runtime/Nashorn401TestSubject.java - test/src/jdk/nashorn/internal/test/models/ConstructorWithArgument.java - test/src/jdk/nashorn/internal/test/models/DessertTopping.java - test/src/jdk/nashorn/internal/test/models/DessertToppingFloorWaxDriver.java - test/src/jdk/nashorn/internal/test/models/FinalClass.java - test/src/jdk/nashorn/internal/test/models/FloorWax.java - test/src/jdk/nashorn/internal/test/models/NoAccessibleConstructorClass.java - test/src/jdk/nashorn/internal/test/models/NonPublicClass.java - test/src/jdk/nashorn/internal/test/models/OuterClass.java - test/src/jdk/nashorn/internal/test/models/OverloadedSam.java - test/src/jdk/nashorn/internal/test/models/OverrideObject.java - test/src/jdk/nashorn/internal/test/models/StringArgs.java - test/src/jdk/nashorn/internal/test/models/Toothpaste.java Changeset: e0378f0a50da Author: katleman Date: 2013-04-04 19:05 -0700 URL: http://hg.openjdk.java.net/hsx/hotspot-main/nashorn/rev/e0378f0a50da Added tag jdk8-b84 for changeset 999cc1bf5520 ! .hgtags From john.coomes at oracle.com Thu Apr 4 20:49:16 2013 From: john.coomes at oracle.com (john.coomes at oracle.com) Date: Fri, 05 Apr 2013 03:49:16 +0000 Subject: hg: hsx/hotspot-main/langtools: 29 new changesets Message-ID: <20130405035043.20845480A1@hg.openjdk.java.net> Changeset: eb0198033c5c Author: jfranck Date: 2013-03-13 22:03 +0100 URL: http://hg.openjdk.java.net/hsx/hotspot-main/langtools/rev/eb0198033c5c 8006547: Repeating annotations: No Target on container annotation with all targets on base annotation gives compiler error Reviewed-by: jjg ! src/share/classes/com/sun/tools/javac/comp/Check.java + test/tools/javac/annotations/repeatingAnnotations/DefaultTarget.java + test/tools/javac/annotations/repeatingAnnotations/DefaultTargetTypeParameter.java + test/tools/javac/annotations/repeatingAnnotations/DefaultTargetTypeParameter.out + test/tools/javac/annotations/repeatingAnnotations/DefaultTargetTypeUse.java + test/tools/javac/annotations/repeatingAnnotations/DefaultTargetTypeUse.out + test/tools/javac/annotations/repeatingAnnotations/NoTargetOnContainer.java + test/tools/javac/annotations/repeatingAnnotations/NoTargetOnContainer2.java Changeset: e0ef84e33167 Author: bpatel Date: 2013-03-13 14:47 -0700 URL: http://hg.openjdk.java.net/hsx/hotspot-main/langtools/rev/e0ef84e33167 8009684: Default top left frame should be "All Packages" in the generated javadoc documentation Reviewed-by: jjg ! src/share/classes/com/sun/tools/doclets/formats/html/FrameOutputWriter.java ! src/share/classes/com/sun/tools/doclets/formats/html/PackageIndexFrameWriter.java ! src/share/classes/com/sun/tools/doclets/formats/html/ProfileIndexFrameWriter.java ! src/share/classes/com/sun/tools/doclets/formats/html/ProfilePackageIndexFrameWriter.java ! test/com/sun/javadoc/testProfiles/TestProfiles.java Changeset: 82dc1e827c2a Author: dholmes Date: 2013-03-14 01:45 -0400 URL: http://hg.openjdk.java.net/hsx/hotspot-main/langtools/rev/82dc1e827c2a 8009429: Miscellaneous profiles cleanup Reviewed-by: jjg, alanb ! src/share/classes/com/sun/tools/javac/sym/Profiles.java Changeset: 2e21ecd7a5ad Author: vromero Date: 2013-03-14 08:30 +0000 URL: http://hg.openjdk.java.net/hsx/hotspot-main/langtools/rev/2e21ecd7a5ad 8008582: jtreg failures after conversion of shell tests to Java Reviewed-by: jjg ! src/share/classes/com/sun/tools/javac/util/ArrayUtils.java ! test/tools/javac/4846262/CheckEBCDICLocaleTest.java ! test/tools/javac/ClassPathTest/ClassPathTest.java ! test/tools/javac/ProtectedInnerClass/ProtectedInnerClassesTest.java ! test/tools/javac/lib/ToolBox.java ! test/tools/javac/links/LinksTest.java ! test/tools/javac/newlines/NewLineTest.java ! test/tools/javah/6257087/T6257087.java ! test/tools/javah/constMacroTest/ConstMacroTest.java ! test/tools/javap/stackmap/StackmapTest.java Changeset: fd3fdaff0257 Author: mchung Date: 2013-03-14 10:33 -0700 URL: http://hg.openjdk.java.net/hsx/hotspot-main/langtools/rev/fd3fdaff0257 8005428: Update jdeps to read the same profile information as by javac Reviewed-by: alanb ! make/netbeans/langtools/nbproject/project.xml ! src/share/classes/com/sun/tools/jdeps/Analyzer.java ! src/share/classes/com/sun/tools/jdeps/ClassFileReader.java ! src/share/classes/com/sun/tools/jdeps/JdepsTask.java ! src/share/classes/com/sun/tools/jdeps/PlatformClassPath.java + src/share/classes/com/sun/tools/jdeps/Profiles.java ! src/share/classes/com/sun/tools/jdeps/resources/jdeps.properties - src/share/classes/com/sun/tools/jdeps/resources/jdk.properties ! test/tools/jdeps/Basic.java ! test/tools/jdeps/p/Foo.java + test/tools/jdeps/profiles.properties Changeset: fbbf5376e7e4 Author: rfield Date: 2013-03-14 22:54 -0700 URL: http://hg.openjdk.java.net/hsx/hotspot-main/langtools/rev/fbbf5376e7e4 8010010: NPE generating serializedLambdaName for nested lambda Reviewed-by: mcimadamore ! src/share/classes/com/sun/tools/javac/comp/LambdaToMethod.java + test/tools/javac/lambda/LambdaLambdaSerialized.java Changeset: fa24eba012bd Author: vromero Date: 2013-03-15 09:02 +0000 URL: http://hg.openjdk.java.net/hsx/hotspot-main/langtools/rev/fa24eba012bd 5053846: javac: MethodRef entries are duplicated in the constant pool Reviewed-by: mcimadamore ! src/share/classes/com/sun/tools/javac/comp/Lower.java + test/tools/javac/T5053846/MethodRefDupInConstantPoolTest.java Changeset: 195b71850b56 Author: mnunez Date: 2013-03-15 13:39 +0100 URL: http://hg.openjdk.java.net/hsx/hotspot-main/langtools/rev/195b71850b56 8007767: TargetAnnoCombo.java need to be updated to add a new test mode Reviewed-by: jjg, strarup ! test/tools/javac/annotations/repeatingAnnotations/combo/Helper.java ! test/tools/javac/annotations/repeatingAnnotations/combo/TargetAnnoCombo.java - test/tools/javac/annotations/repeatingAnnotations/combo/TestCaseGenerator.java Changeset: a3049f4a7987 Author: lana Date: 2013-03-15 23:46 -0700 URL: http://hg.openjdk.java.net/hsx/hotspot-main/langtools/rev/a3049f4a7987 Merge Changeset: 1f8c28134ffc Author: jjg Date: 2013-03-18 08:46 -0700 URL: http://hg.openjdk.java.net/hsx/hotspot-main/langtools/rev/1f8c28134ffc 8005220: RFE to write javap tests for repeating annotations. Reviewed-by: jjg Contributed-by: peter.jensen at oracle.com + test/tools/javap/output/RepeatingTypeAnnotations.java + test/tools/javap/output/Tester.java Changeset: 40adaf938847 Author: jjg Date: 2013-03-18 14:40 -0700 URL: http://hg.openjdk.java.net/hsx/hotspot-main/langtools/rev/40adaf938847 8008425: Remove interim new javax.lang.model API for type-annotations Reviewed-by: darcy ! src/share/classes/com/sun/tools/javac/code/Type.java ! src/share/classes/com/sun/tools/javac/code/TypeAnnotations.java ! src/share/classes/com/sun/tools/javac/code/Types.java ! src/share/classes/com/sun/tools/javac/comp/Attr.java ! src/share/classes/com/sun/tools/javac/model/JavacTypes.java ! src/share/classes/com/sun/tools/javadoc/ExecutableMemberDocImpl.java ! src/share/classes/com/sun/tools/javadoc/TypeMaker.java ! src/share/classes/com/sun/tools/javadoc/TypeVariableImpl.java - src/share/classes/javax/lang/model/type/AnnotatedType.java ! src/share/classes/javax/lang/model/type/ExecutableType.java ! src/share/classes/javax/lang/model/type/TypeKind.java ! src/share/classes/javax/lang/model/type/TypeVisitor.java ! src/share/classes/javax/lang/model/util/AbstractTypeVisitor6.java ! src/share/classes/javax/lang/model/util/Types.java Changeset: 97f6839673d6 Author: jjg Date: 2013-03-18 18:33 -0700 URL: http://hg.openjdk.java.net/hsx/hotspot-main/langtools/rev/97f6839673d6 8007803: Implement javax.lang.model API for Type Annotations Reviewed-by: darcy ! src/share/classes/com/sun/tools/javac/code/Printer.java ! src/share/classes/com/sun/tools/javac/code/Symbol.java ! src/share/classes/com/sun/tools/javac/code/Type.java ! src/share/classes/com/sun/tools/javac/comp/Attr.java ! src/share/classes/com/sun/tools/javac/model/AnnotationProxyMaker.java + src/share/classes/com/sun/tools/javac/model/JavacAnnoConstructs.java ! src/share/classes/com/sun/tools/javac/model/JavacElements.java ! src/share/classes/com/sun/tools/javac/model/JavacTypes.java + src/share/classes/javax/lang/model/AnnotatedConstruct.java ! src/share/classes/javax/lang/model/element/Element.java ! src/share/classes/javax/lang/model/element/ExecutableElement.java ! src/share/classes/javax/lang/model/type/ExecutableType.java ! src/share/classes/javax/lang/model/type/TypeMirror.java ! src/share/classes/javax/lang/model/util/Types.java Changeset: a4913ea9bb62 Author: darcy Date: 2013-03-19 13:10 -0700 URL: http://hg.openjdk.java.net/hsx/hotspot-main/langtools/rev/a4913ea9bb62 8010179: Remove transitional target values from javac Reviewed-by: jjg, mcimadamore ! src/share/classes/com/sun/tools/javac/comp/Attr.java ! src/share/classes/com/sun/tools/javac/comp/Lower.java ! src/share/classes/com/sun/tools/javac/comp/MemberEnter.java ! src/share/classes/com/sun/tools/javac/jvm/Target.java ! test/tools/javac/ClassFileModifiers/MemberModifiers.java ! test/tools/javac/profiles/ProfileOptionTest.java Changeset: 578eb3dd111d Author: jjg Date: 2013-03-19 15:13 -0700 URL: http://hg.openjdk.java.net/hsx/hotspot-main/langtools/rev/578eb3dd111d 8010315: doclint errors in javac public API Reviewed-by: darcy ! make/build.xml ! src/share/classes/com/sun/source/util/DocTreeScanner.java ! src/share/classes/com/sun/source/util/JavacTask.java ! src/share/classes/com/sun/source/util/Plugin.java ! src/share/classes/javax/lang/model/AnnotatedConstruct.java ! src/share/classes/javax/lang/model/type/ExecutableType.java Changeset: a03c4a86ea2b Author: jjg Date: 2013-03-19 17:04 -0700 URL: http://hg.openjdk.java.net/hsx/hotspot-main/langtools/rev/a03c4a86ea2b 8010361: fix some langtools findbugs issues Reviewed-by: darcy ! src/share/classes/com/sun/tools/classfile/Code_attribute.java ! src/share/classes/com/sun/tools/classfile/Descriptor.java ! src/share/classes/com/sun/tools/doclets/internal/toolkit/Configuration.java ! src/share/classes/com/sun/tools/doclets/internal/toolkit/builders/AnnotationTypeBuilder.java ! src/share/classes/com/sun/tools/javah/Util.java ! src/share/classes/com/sun/tools/javap/StackMapWriter.java ! src/share/classes/com/sun/tools/jdeps/JdepsTask.java ! src/share/classes/com/sun/tools/jdeps/PlatformClassPath.java ! src/share/classes/com/sun/tools/sjavac/Main.java ! src/share/classes/com/sun/tools/sjavac/comp/Dependencies.java Changeset: 9cf17b7a5fe7 Author: jjg Date: 2013-03-19 17:05 -0700 URL: http://hg.openjdk.java.net/hsx/hotspot-main/langtools/rev/9cf17b7a5fe7 8010333: Remove com.sun.tools.javac.Server Reviewed-by: darcy - src/share/classes/com/sun/tools/javac/Server.java Changeset: 74d7f9bcac93 Author: jjg Date: 2013-03-19 19:16 -0700 URL: http://hg.openjdk.java.net/hsx/hotspot-main/langtools/rev/74d7f9bcac93 8010317: DocLint incorrectly reports some 
 tags as empty
Reviewed-by: darcy

! src/share/classes/com/sun/tools/doclint/Checker.java
+ test/tools/doclint/EmptyPreTest.java

Changeset: 972474640b7d
Author:    darcy
Date:      2013-03-20 17:41 -0700
URL:       http://hg.openjdk.java.net/hsx/hotspot-main/langtools/rev/972474640b7d

8010364: Clarify javax.lang.model API for Type Annotations
Reviewed-by: jjg, abuckley

! src/share/classes/javax/lang/model/AnnotatedConstruct.java
! src/share/classes/javax/lang/model/type/ExecutableType.java

Changeset: cc38a6723663
Author:    mcimadamore
Date:      2013-03-22 12:38 +0000
URL:       http://hg.openjdk.java.net/hsx/hotspot-main/langtools/rev/cc38a6723663

8009649: Lambda back-end should generate invokespecial for method handles referring to private instance methods
Summary: Private lambda methods should be accessed through invokespecial
Reviewed-by: jjg

! src/share/classes/com/sun/tools/javac/comp/LambdaToMethod.java
+ test/tools/javac/lambda/bytecode/TestLambdaBytecode.java

Changeset: f3814edefb33
Author:    mcimadamore
Date:      2013-03-22 12:39 +0000
URL:       http://hg.openjdk.java.net/hsx/hotspot-main/langtools/rev/f3814edefb33

8010101: Intersection type cast issues redundant unchecked warning
Summary: Code for checking intersection type cast is incorrectly swapping operands, leading to spurious warnings
Reviewed-by: jjg

! src/share/classes/com/sun/tools/javac/code/Types.java
+ test/tools/javac/lambda/Intersection02.java
+ test/tools/javac/lambda/Intersection02.out

Changeset: b6cf07c54c29
Author:    mcimadamore
Date:      2013-03-22 12:41 +0000
URL:       http://hg.openjdk.java.net/hsx/hotspot-main/langtools/rev/b6cf07c54c29

8009820: AssertionError when compiling java code with two identical static imports
Summary: Speculative attribution is carried out twice with same method symbol in case of static imports
Reviewed-by: jjg

! src/share/classes/com/sun/tools/javac/comp/DeferredAttr.java
+ test/tools/javac/lambda/DoubleStaticImport.java

Changeset: c6728c9addff
Author:    mcimadamore
Date:      2013-03-22 12:43 +0000
URL:       http://hg.openjdk.java.net/hsx/hotspot-main/langtools/rev/c6728c9addff

8010303: Graph inference: missing incorporation step causes spurious inference error
Summary: Multiple equality constraints on inference vars are not used to generate new inference constraints
Reviewed-by: jjg

! src/share/classes/com/sun/tools/javac/code/Types.java
! src/share/classes/com/sun/tools/javac/comp/Infer.java
! test/tools/javac/lambda/TargetType28.out
+ test/tools/javac/lambda/TargetType67.java
+ test/tools/javac/lambda/TargetType68.java
+ test/tools/javac/lambda/TargetType69.java

Changeset: 5da12e8a59ba
Author:    mcimadamore
Date:      2013-03-22 12:44 +0000
URL:       http://hg.openjdk.java.net/hsx/hotspot-main/langtools/rev/5da12e8a59ba

8010387: Javac crashes when diagnostic mentions anonymous inner class' type variables
Summary: Rich formatter doesn't preprocess supertypes of an anonymous inner class
Reviewed-by: jjg

! src/share/classes/com/sun/tools/javac/util/RichDiagnosticFormatter.java
+ test/tools/javac/Diagnostics/8010387/T8010387.java
+ test/tools/javac/Diagnostics/8010387/T8010387.out

Changeset: f4500abff1fd
Author:    darcy
Date:      2013-03-22 10:08 -0700
URL:       http://hg.openjdk.java.net/hsx/hotspot-main/langtools/rev/f4500abff1fd

7080464: langtools regression test failures when assertions are enabled
Reviewed-by: jjg

! test/tools/javac/api/TestJavacTaskScanner.java
! test/tools/javac/diags/MessageFile.java
! test/tools/javac/diags/MessageInfo.java

Changeset: fdf30b225e1c
Author:    mfang
Date:      2013-03-25 16:55 -0700
URL:       http://hg.openjdk.java.net/hsx/hotspot-main/langtools/rev/fdf30b225e1c

8010521: jdk8 l10n resource file translation update 2
Reviewed-by: naoto, yhuang

! src/share/classes/com/sun/tools/doclets/formats/html/resources/standard_ja.properties
! src/share/classes/com/sun/tools/doclets/formats/html/resources/standard_zh_CN.properties
! src/share/classes/com/sun/tools/doclets/internal/toolkit/resources/doclets_ja.properties
! src/share/classes/com/sun/tools/doclets/internal/toolkit/resources/doclets_zh_CN.properties
! src/share/classes/com/sun/tools/javac/resources/compiler_ja.properties
! src/share/classes/com/sun/tools/javac/resources/compiler_zh_CN.properties
! src/share/classes/com/sun/tools/javac/resources/javac_ja.properties
! src/share/classes/com/sun/tools/javac/resources/javac_zh_CN.properties
! src/share/classes/com/sun/tools/javadoc/resources/javadoc_ja.properties
! src/share/classes/com/sun/tools/javadoc/resources/javadoc_zh_CN.properties
! src/share/classes/com/sun/tools/javah/resources/l10n_ja.properties
! src/share/classes/com/sun/tools/javah/resources/l10n_zh_CN.properties

Changeset: 65e1ca8dcdc7
Author:    mfang
Date:      2013-03-25 18:08 -0700
URL:       http://hg.openjdk.java.net/hsx/hotspot-main/langtools/rev/65e1ca8dcdc7

Merge


Changeset: 28e466e9cd34
Author:    lana
Date:      2013-03-26 12:07 -0700
URL:       http://hg.openjdk.java.net/hsx/hotspot-main/langtools/rev/28e466e9cd34

Merge

- src/share/classes/com/sun/tools/javac/Server.java
- src/share/classes/com/sun/tools/jdeps/resources/jdk.properties
- src/share/classes/javax/lang/model/type/AnnotatedType.java
- test/tools/javac/annotations/repeatingAnnotations/combo/TestCaseGenerator.java

Changeset: cfb65ca92082
Author:    lana
Date:      2013-04-01 21:42 -0700
URL:       http://hg.openjdk.java.net/hsx/hotspot-main/langtools/rev/cfb65ca92082

Merge

- src/share/classes/com/sun/tools/javac/Server.java
- src/share/classes/com/sun/tools/jdeps/resources/jdk.properties
- src/share/classes/javax/lang/model/type/AnnotatedType.java
- test/tools/javac/annotations/repeatingAnnotations/combo/TestCaseGenerator.java

Changeset: 4a48f3173534
Author:    katleman
Date:      2013-04-04 19:05 -0700
URL:       http://hg.openjdk.java.net/hsx/hotspot-main/langtools/rev/4a48f3173534

Added tag jdk8-b84 for changeset cfb65ca92082

! .hgtags


From alejandro.murillo at oracle.com  Fri Apr  5 00:32:54 2013
From: alejandro.murillo at oracle.com (alejandro.murillo at oracle.com)
Date: Fri, 05 Apr 2013 07:32:54 +0000
Subject: hg: hsx/hsx25/hotspot: 48 new changesets
Message-ID: <20130405073434.3988E480C5@hg.openjdk.java.net>

Changeset: ac242ddfa319
Author:    katleman
Date:      2013-04-04 19:05 -0700
URL:       http://hg.openjdk.java.net/hsx/hsx25/hotspot/rev/ac242ddfa319

Added tag jdk8-b84 for changeset af788b85010e

! .hgtags

Changeset: d26674db4d91
Author:    amurillo
Date:      2013-03-28 19:13 -0700
URL:       http://hg.openjdk.java.net/hsx/hsx25/hotspot/rev/d26674db4d91

8011022: new hotspot build - hs25-b26
Reviewed-by: jcoomes

! make/hotspot_version

Changeset: 0c3ee6f1fa23
Author:    coleenp
Date:      2013-03-27 08:19 -0400
URL:       http://hg.openjdk.java.net/hsx/hsx25/hotspot/rev/0c3ee6f1fa23

8009531: Crash when redefining class with annotated method
Summary: Neglected to copy the annotations in clone_with_new_data when they were moved to ConstMethod.
Reviewed-by: acorn, sspitsyn, dcubed

! src/share/vm/oops/constMethod.cpp
! src/share/vm/oops/constMethod.hpp
! src/share/vm/oops/method.cpp

Changeset: aa758f0c5b1c
Author:    hseigel
Date:      2013-03-27 11:41 -0400
URL:       http://hg.openjdk.java.net/hsx/hsx25/hotspot/rev/aa758f0c5b1c

8010833: Test7116786.java is failing on most configs after fix for 8010667
Summary: Update test to recognize that non-zero pad bytes for lookupswitch/tablewsitch opcodes are now valid.
Reviewed-by: dcubed, twisti, kvn, coleenp, dholmes

! test/runtime/7116786/Test7116786.java

Changeset: b601102d00c8
Author:    hseigel
Date:      2013-03-27 13:26 -0700
URL:       http://hg.openjdk.java.net/hsx/hsx25/hotspot/rev/b601102d00c8

Merge


Changeset: cd3089a56438
Author:    acorn
Date:      2013-03-27 14:10 -0400
URL:       http://hg.openjdk.java.net/hsx/hsx25/hotspot/rev/cd3089a56438

8009731: Confusing error message for loader constraint violation
Summary: Fix text, overwritten type and holder for resolved method
Reviewed-by: coleenp, dcubed, minqi, dholmes

! src/share/vm/classfile/systemDictionary.cpp
! src/share/vm/classfile/systemDictionary.hpp
! src/share/vm/interpreter/linkResolver.cpp
! src/share/vm/oops/klassVtable.cpp

Changeset: 53f4040e809c
Author:    acorn
Date:      2013-03-27 16:31 -0700
URL:       http://hg.openjdk.java.net/hsx/hsx25/hotspot/rev/53f4040e809c

Merge


Changeset: b5bae74160b7
Author:    zgu
Date:      2013-03-27 15:41 -0400
URL:       http://hg.openjdk.java.net/hsx/hsx25/hotspot/rev/b5bae74160b7

8010474: [parfait] Undefined return value of the functions in hotspot/src/share/vm/services/memTracker.hpp
Summary: Fixed functions that miss return values
Reviewed-by: coleenp, acorn, kvn

! src/share/vm/services/memTracker.hpp

Changeset: 26e0c03da92c
Author:    zgu
Date:      2013-03-27 13:07 -0700
URL:       http://hg.openjdk.java.net/hsx/hsx25/hotspot/rev/26e0c03da92c

Merge

- make/windows/projectfiles/kernel/Makefile
- make/windows/projectfiles/kernel/vm.def
- make/windows/projectfiles/kernel/vm.dsw

Changeset: f044c45bee68
Author:    zgu
Date:      2013-03-27 22:05 -0700
URL:       http://hg.openjdk.java.net/hsx/hsx25/hotspot/rev/f044c45bee68

Merge


Changeset: 1b90c7607451
Author:    minqi
Date:      2013-03-27 17:03 -0700
URL:       http://hg.openjdk.java.net/hsx/hsx25/hotspot/rev/1b90c7607451

2178143: JVM crashes if the number of bound CPUs changed during runtime
Summary: Supply a new flag -XX:+AssumeMP to workaround the problem. With the flag is turned on, assume VM run on MP platform so is_MP() will return true that sync calls will not skip away.
Reviewed-by: dholmes, acorn, dcubed, jmasa
Contributed-by: yumin.qi at oracle.com

! src/share/vm/runtime/arguments.cpp
! src/share/vm/runtime/globals.hpp
! src/share/vm/runtime/os.hpp

Changeset: d7adf726b18a
Author:    minqi
Date:      2013-03-28 00:44 -0700
URL:       http://hg.openjdk.java.net/hsx/hsx25/hotspot/rev/d7adf726b18a

Merge


Changeset: c0f9217203b2
Author:    dcubed
Date:      2013-03-29 08:38 -0700
URL:       http://hg.openjdk.java.net/hsx/hsx25/hotspot/rev/c0f9217203b2

Merge

! src/share/vm/runtime/arguments.cpp

Changeset: d886ac1dfd36
Author:    coleenp
Date:      2013-03-31 21:43 -0400
URL:       http://hg.openjdk.java.net/hsx/hsx25/hotspot/rev/d886ac1dfd36

8010723: fatal error: acquiring lock Metaspace allocation lock/5 out of order
Summary: Avoid holding SystemDictionary_lock while calling Klass::remove_unshareable_info
Reviewed-by: coleenp, acorn
Contributed-by: ioi.lam at oracle.com

! src/share/vm/classfile/systemDictionary.cpp

Changeset: e458120c6e1a
Author:    sla
Date:      2013-03-28 15:39 +0100
URL:       http://hg.openjdk.java.net/hsx/hsx25/hotspot/rev/e458120c6e1a

8002118: WindbgDebuggerLocal should not try to load 64-bit debug libraries for 32-bit JVM
Reviewed-by: sspitsyn, zgu
Contributed-by: peter.allwin at oracle.com

! agent/src/share/classes/sun/jvm/hotspot/debugger/windbg/WindbgDebuggerLocal.java

Changeset: ede380e13960
Author:    mgerdin
Date:      2013-04-02 11:28 +0200
URL:       http://hg.openjdk.java.net/hsx/hsx25/hotspot/rev/ede380e13960

8009763: Add WB test for String.intern()
Summary: Add convenience method in StringTable, add WhiteBox method and simple sanity test
Reviewed-by: mgerdin, zgu
Contributed-by: leonid.mesnik at oracle.com

! src/share/vm/classfile/symbolTable.cpp
! src/share/vm/classfile/symbolTable.hpp
! src/share/vm/prims/whitebox.cpp
+ test/runtime/interned/SanityTest.java
! test/testlibrary/whitebox/sun/hotspot/WhiteBox.java

Changeset: 8c03fc47511d
Author:    iklam
Date:      2013-04-01 14:05 -0700
URL:       http://hg.openjdk.java.net/hsx/hsx25/hotspot/rev/8c03fc47511d

8011048: Possible reading from unmapped memory in UTF8::as_quoted_ascii()
Summary: Pass utf_length parameter to UTF8::as_quoted_ascii()
Reviewed-by: dcubed, minqi

! src/share/vm/oops/symbol.cpp
! src/share/vm/utilities/utf8.cpp
! src/share/vm/utilities/utf8.hpp

Changeset: a4e8dac9db8c
Author:    zgu
Date:      2013-04-02 07:40 -0700
URL:       http://hg.openjdk.java.net/hsx/hsx25/hotspot/rev/a4e8dac9db8c

Merge


Changeset: 2e093b564241
Author:    mgerdin
Date:      2013-03-28 10:27 +0100
URL:       http://hg.openjdk.java.net/hsx/hsx25/hotspot/rev/2e093b564241

7014552: gc/lock/jni/jnilockXXX works too slow on 1-processor machine
Summary: Keep a counter of how many times we were stalled by the GC locker, add a diagnostic flag which sets the limit.
Reviewed-by: brutisso, ehelin, johnc

! src/share/vm/gc_implementation/g1/g1CollectedHeap.cpp
! src/share/vm/gc_implementation/g1/g1CollectedHeap.hpp
! src/share/vm/gc_implementation/g1/g1CollectedHeap.inline.hpp
! src/share/vm/gc_implementation/parallelScavenge/parallelScavengeHeap.cpp
! src/share/vm/memory/collectorPolicy.cpp
! src/share/vm/runtime/globals.hpp

Changeset: 754c24457b20
Author:    tschatzl
Date:      2013-03-27 19:21 +0100
URL:       http://hg.openjdk.java.net/hsx/hsx25/hotspot/rev/754c24457b20

7112912: Message "Error occurred during initialization of VM" on boxes with lots of RAM
Summary: Ergonomics now also takes available virtual memory into account when deciding for a heap size. The helper method to determine the maximum allocatable memory block now uses the appropriate OS specific calls to retrieve available virtual memory for the java process. In 32 bit environments this method now also searches for the maximum actually reservable amount of memory. Merge previously separate implementations for Linux/BSD/Solaris into a single method.
Reviewed-by: jmasa, tamao

! src/os/bsd/vm/os_bsd.cpp
! src/os/linux/vm/os_linux.cpp
! src/os/posix/vm/os_posix.cpp
! src/os/solaris/vm/os_solaris.cpp
! src/os/windows/vm/os_windows.cpp
! src/share/vm/runtime/arguments.cpp
! src/share/vm/runtime/arguments.hpp
! src/share/vm/runtime/globals.hpp
! src/share/vm/runtime/os.hpp

Changeset: 24ef5fb05e0f
Author:    johnc
Date:      2013-03-29 13:49 -0700
URL:       http://hg.openjdk.java.net/hsx/hsx25/hotspot/rev/24ef5fb05e0f

8010463: G1: Crashes with -UseTLAB and heap verification
Summary: Some parts of the G1 heap can only be walked during a safepoint. Skip verifying these parts of the heap when verifying during JVM startup.
Reviewed-by: brutisso, tschatzl

! src/share/vm/gc_implementation/g1/g1CollectedHeap.cpp
! src/share/vm/memory/universe.cpp
! src/share/vm/runtime/init.cpp
! src/share/vm/runtime/thread.cpp
+ test/gc/TestVerifyBeforeGCDuringStartup.java

Changeset: 8bf6338972ce
Author:    ehelin
Date:      2013-03-23 09:16 +0100
URL:       http://hg.openjdk.java.net/hsx/hsx25/hotspot/rev/8bf6338972ce

8009408: gc/metaspace/ClassMetaspaceSizeInJmapHeap.java fails with "exit code 1"
Reviewed-by: brutisso, sla, ctornqvi

! test/gc/metaspace/ClassMetaspaceSizeInJmapHeap.java
+ test/testlibrary/com/oracle/java/testlibrary/JDKToolLauncher.java

Changeset: cc5b5976d72c
Author:    tschatzl
Date:      2013-04-02 10:03 +0200
URL:       http://hg.openjdk.java.net/hsx/hsx25/hotspot/rev/cc5b5976d72c

8005857: assert in GC_locker from PSOldGen::expand with -XX:+PrintGCDetails and Verbose
Summary: Use GC_locker::is_active_and_needs_gc() instead of GC_locker::is_active() for providing information about the reason of heap expansion.
Reviewed-by: jmasa, johnc

! src/share/vm/gc_implementation/parallelScavenge/psOldGen.cpp

Changeset: 15c04fe93c18
Author:    mgerdin
Date:      2013-04-03 09:19 +0200
URL:       http://hg.openjdk.java.net/hsx/hsx25/hotspot/rev/15c04fe93c18

Merge

- make/windows/projectfiles/kernel/Makefile
- make/windows/projectfiles/kernel/vm.def
- make/windows/projectfiles/kernel/vm.dsw
! src/os/linux/vm/os_linux.cpp
! src/share/vm/runtime/arguments.cpp
! src/share/vm/runtime/globals.hpp
- test/runtime/8007736/TestStaticIF.java

Changeset: 0c039865ef2b
Author:    mgerdin
Date:      2013-04-04 19:07 +0200
URL:       http://hg.openjdk.java.net/hsx/hsx25/hotspot/rev/0c039865ef2b

Merge

! src/share/vm/runtime/arguments.cpp
! src/share/vm/runtime/globals.hpp
! src/share/vm/runtime/os.hpp

Changeset: 46f6f063b272
Author:    roland
Date:      2013-03-21 09:27 +0100
URL:       http://hg.openjdk.java.net/hsx/hsx25/hotspot/rev/46f6f063b272

7153771: array bound check elimination for c1
Summary: when possible optimize out array bound checks, inserting predicates when needed.
Reviewed-by: never, kvn, twisti
Contributed-by: thomaswue 

! src/cpu/sparc/vm/c1_CodeStubs_sparc.cpp
! src/cpu/sparc/vm/c1_LIRAssembler_sparc.cpp
! src/cpu/sparc/vm/c1_LIRGenerator_sparc.cpp
! src/cpu/sparc/vm/c1_Runtime1_sparc.cpp
! src/cpu/x86/vm/c1_CodeStubs_x86.cpp
! src/cpu/x86/vm/c1_LIRAssembler_x86.cpp
! src/cpu/x86/vm/c1_LIRGenerator_x86.cpp
! src/cpu/x86/vm/c1_LinearScan_x86.cpp
! src/cpu/x86/vm/c1_Runtime1_x86.cpp
! src/share/vm/c1/c1_Canonicalizer.cpp
! src/share/vm/c1/c1_Canonicalizer.hpp
! src/share/vm/c1/c1_CodeStubs.hpp
! src/share/vm/c1/c1_Compilation.cpp
! src/share/vm/c1/c1_Compilation.hpp
! src/share/vm/c1/c1_GraphBuilder.cpp
! src/share/vm/c1/c1_GraphBuilder.hpp
! src/share/vm/c1/c1_IR.cpp
! src/share/vm/c1/c1_IR.hpp
! src/share/vm/c1/c1_Instruction.cpp
! src/share/vm/c1/c1_Instruction.hpp
! src/share/vm/c1/c1_InstructionPrinter.cpp
! src/share/vm/c1/c1_InstructionPrinter.hpp
! src/share/vm/c1/c1_LIR.cpp
! src/share/vm/c1/c1_LIR.hpp
! src/share/vm/c1/c1_LIRAssembler.hpp
! src/share/vm/c1/c1_LIRGenerator.cpp
! src/share/vm/c1/c1_LIRGenerator.hpp
! src/share/vm/c1/c1_LinearScan.cpp
! src/share/vm/c1/c1_Optimizer.cpp
+ src/share/vm/c1/c1_RangeCheckElimination.cpp
+ src/share/vm/c1/c1_RangeCheckElimination.hpp
! src/share/vm/c1/c1_Runtime1.cpp
! src/share/vm/c1/c1_Runtime1.hpp
! src/share/vm/c1/c1_ValueMap.cpp
! src/share/vm/c1/c1_ValueMap.hpp
! src/share/vm/c1/c1_globals.hpp
! src/share/vm/compiler/compileBroker.cpp
! src/share/vm/oops/instanceKlass.cpp
! src/share/vm/oops/methodData.cpp
! src/share/vm/runtime/globals.hpp

Changeset: a57fc14f798a
Author:    roland
Date:      2013-03-21 22:00 -0700
URL:       http://hg.openjdk.java.net/hsx/hsx25/hotspot/rev/a57fc14f798a

Merge


Changeset: e370f63dc5b1
Author:    bharadwaj
Date:      2013-03-22 07:58 -0700
URL:       http://hg.openjdk.java.net/hsx/hsx25/hotspot/rev/e370f63dc5b1

8009539: JVM crash when run lambda testng tests
Summary: Ensure class pointer is non-null before dereferencing it to check if it is loaded.
Reviewed-by: kvn

! src/share/vm/opto/parse2.cpp

Changeset: 360ce06580b8
Author:    bharadwaj
Date:      2013-03-22 13:35 -0400
URL:       http://hg.openjdk.java.net/hsx/hsx25/hotspot/rev/360ce06580b8

Merge


Changeset: 3c786355ffb4
Author:    morris
Date:      2013-03-23 06:22 -0700
URL:       http://hg.openjdk.java.net/hsx/hsx25/hotspot/rev/3c786355ffb4

8009026: [parfait] Null pointer deference in hotspot/src/share/vm/code/nmethod.cpp
Summary: add guarantee() to nmethod constructor and checks to ensure CodeCache has space before allocation
Reviewed-by: kvn

! src/share/vm/code/codeCache.hpp
! src/share/vm/code/nmethod.cpp

Changeset: 818a1ac7da7a
Author:    morris
Date:      2013-03-24 12:43 -0700
URL:       http://hg.openjdk.java.net/hsx/hsx25/hotspot/rev/818a1ac7da7a

Merge


Changeset: 16885e702c88
Author:    twisti
Date:      2013-03-25 17:13 -0700
URL:       http://hg.openjdk.java.net/hsx/hsx25/hotspot/rev/16885e702c88

7198429: need checked categorization of caller-sensitive methods in the JDK
Reviewed-by: kvn, jrose

! src/share/vm/ci/ciMethod.cpp
! src/share/vm/ci/ciMethod.hpp
! src/share/vm/classfile/classFileParser.cpp
! src/share/vm/classfile/classFileParser.hpp
! src/share/vm/classfile/classLoaderData.cpp
! src/share/vm/classfile/classLoaderData.hpp
! src/share/vm/classfile/javaClasses.hpp
! src/share/vm/classfile/systemDictionary.cpp
! src/share/vm/classfile/systemDictionary.hpp
! src/share/vm/classfile/vmSymbols.hpp
! src/share/vm/oops/method.cpp
! src/share/vm/oops/method.hpp
! src/share/vm/opto/library_call.cpp
! src/share/vm/prims/jvm.cpp
! src/share/vm/prims/methodHandles.cpp
! src/share/vm/prims/unsafe.cpp
! src/share/vm/runtime/vframe.cpp
! src/share/vm/runtime/vframe.hpp

Changeset: b808febcad9a
Author:    neliasso
Date:      2013-03-26 10:05 +0100
URL:       http://hg.openjdk.java.net/hsx/hsx25/hotspot/rev/b808febcad9a

8010281: Remove code that is never executed
Reviewed-by: kvn, roland
Contributed-by: niclas.adlertz at oracle.com

! src/share/vm/opto/ifg.cpp

Changeset: 30f42e691e70
Author:    kvn
Date:      2013-03-26 12:55 -0700
URL:       http://hg.openjdk.java.net/hsx/hsx25/hotspot/rev/30f42e691e70

8004640: C2 assert failure in memnode.cpp: NULL+offs not RAW address
Summary: always transform AddP nodes in IdealKit by calling _gvn.transform().
Reviewed-by: roland, twisti

! src/share/vm/opto/graphKit.cpp
! src/share/vm/opto/idealKit.cpp
! src/share/vm/opto/idealKit.hpp
! src/share/vm/opto/loopnode.cpp
! src/share/vm/opto/phaseX.cpp

Changeset: d595e8ddadd9
Author:    roland
Date:      2013-03-29 17:25 +0100
URL:       http://hg.openjdk.java.net/hsx/hsx25/hotspot/rev/d595e8ddadd9

8010934: assert failure in c1_LinearScan.cpp: "asumption: non-Constant instructions have only virtual operands"
Summary: incorrect code to skip some ArrayLength instructions in LIRGenerator
Reviewed-by: kvn

! src/share/vm/c1/c1_LIRGenerator.cpp
! src/share/vm/c1/c1_RangeCheckElimination.cpp

Changeset: cd9ad42dfde0
Author:    bharadwaj
Date:      2013-03-29 20:52 -0700
URL:       http://hg.openjdk.java.net/hsx/hsx25/hotspot/rev/cd9ad42dfde0

Merge

! src/share/vm/classfile/classFileParser.cpp
! src/share/vm/prims/jvm.cpp
! src/share/vm/runtime/globals.hpp

Changeset: 6b19fe41b577
Author:    kmo
Date:      2013-03-30 08:01 -0700
URL:       http://hg.openjdk.java.net/hsx/hsx25/hotspot/rev/6b19fe41b577

8011009: Use do-while(0) instead of while(0) in EC_TRACE and RC_TRACE* macros
Summary: Improve EC_TRACE and RC_TRACE* to use the do-while(0) trick for statement-like macro
Reviewed-by: sspitsyn, dcubed

! src/share/vm/prims/jvmtiEventController.cpp
! src/share/vm/prims/jvmtiRedefineClassesTrace.hpp

Changeset: 53028d751155
Author:    neliasso
Date:      2013-04-02 09:30 +0200
URL:       http://hg.openjdk.java.net/hsx/hsx25/hotspot/rev/53028d751155

7034299: Faulty winsock initialization code
Reviewed-by: dholmes, sla, ctornqvi

! src/os/windows/vm/os_windows.cpp

Changeset: e961c11b85fe
Author:    kvn
Date:      2013-04-03 11:12 -0700
URL:       http://hg.openjdk.java.net/hsx/hsx25/hotspot/rev/e961c11b85fe

8011102: Clear AVX registers after return from JNI call
Summary: Execute vzeroupper instruction after JNI call and on exits in jit compiled code which use 256bit vectors.
Reviewed-by: roland

! src/cpu/x86/vm/cppInterpreter_x86.cpp
! src/cpu/x86/vm/macroAssembler_x86.cpp
! src/cpu/x86/vm/macroAssembler_x86.hpp
! src/cpu/x86/vm/sharedRuntime_x86_32.cpp
! src/cpu/x86/vm/sharedRuntime_x86_64.cpp
! src/cpu/x86/vm/stubGenerator_x86_32.cpp
! src/cpu/x86/vm/stubGenerator_x86_64.cpp
! src/cpu/x86/vm/templateInterpreter_x86_32.cpp
! src/cpu/x86/vm/templateInterpreter_x86_64.cpp
! src/cpu/x86/vm/x86_32.ad
! src/cpu/x86/vm/x86_64.ad
! src/os_cpu/bsd_x86/vm/bsd_x86_64.ad
! src/os_cpu/linux_x86/vm/linux_x86_64.ad
! src/os_cpu/solaris_x86/vm/solaris_x86_64.ad
! src/os_cpu/windows_x86/vm/windows_x86_64.ad

Changeset: 0a8c2ea3902d
Author:    rasbold
Date:      2013-04-03 15:00 -0700
URL:       http://hg.openjdk.java.net/hsx/hsx25/hotspot/rev/0a8c2ea3902d

8010437: guarantee(this->is8bit(imm8)) failed: Short forward jump exceeds 8-bit offset
Summary: Fix shorten_branches() to accurately count an initial nop that may be inserted in a block that starts with a safepoint.
Reviewed-by: kvn

! src/share/vm/opto/output.cpp

Changeset: 70c52efb2cbd
Author:    neliasso
Date:      2013-04-04 09:18 +0200
URL:       http://hg.openjdk.java.net/hsx/hsx25/hotspot/rev/70c52efb2cbd

8006008: Memory leak in hotspot/src/share/vm/adlc/archDesc.cpp
Reviewed-by: roland, kvn
Contributed-by: niclas.adlertz at oracle.com

! src/share/vm/adlc/archDesc.cpp

Changeset: 6c4abd4a9595
Author:    roland
Date:      2013-04-04 09:33 +0200
URL:       http://hg.openjdk.java.net/hsx/hsx25/hotspot/rev/6c4abd4a9595

8010399: Test8009761.java "Failed: init recursive calls: 5498. After deopt 5494".
Summary: test from 8009761 shouldn't be run with -Xcomp
Reviewed-by: kvn

! test/compiler/8009761/Test8009761.java

Changeset: 9125a548c1eb
Author:    roland
Date:      2013-04-04 02:48 -0700
URL:       http://hg.openjdk.java.net/hsx/hsx25/hotspot/rev/9125a548c1eb

Merge


Changeset: 573cf206e381
Author:    neliasso
Date:      2013-04-04 09:30 +0200
URL:       http://hg.openjdk.java.net/hsx/hsx25/hotspot/rev/573cf206e381

8006014: Memory leak in hotspot/src/share/vm/adlc/dfa.cpp
Reviewed-by: kvn, roland
Contributed-by: niclas.adlertz at oracle.com

! src/share/vm/adlc/dfa.cpp

Changeset: bab5cbf74b5f
Author:    kvn
Date:      2013-04-04 12:18 -0700
URL:       http://hg.openjdk.java.net/hsx/hsx25/hotspot/rev/bab5cbf74b5f

8011198: LP64 setting is not preserved on Solaris after 8006965
Summary: Fixed incremental build makefiles generated by buildtree.make. Consolidated unix build.sh.
Reviewed-by: twisti

- make/bsd/build.sh
! make/bsd/makefiles/buildtree.make
+ make/build.sh
- make/linux/build.sh
! make/linux/makefiles/buildtree.make
- make/solaris/build.sh
! make/solaris/makefiles/buildtree.make
! src/os/posix/launcher/launcher.script

Changeset: 0ca3dd0ffaba
Author:    bharadwaj
Date:      2013-04-04 17:01 -0700
URL:       http://hg.openjdk.java.net/hsx/hsx25/hotspot/rev/0ca3dd0ffaba

Merge

- make/bsd/build.sh
- make/linux/build.sh
- make/solaris/build.sh
! src/os/windows/vm/os_windows.cpp
! src/share/vm/classfile/systemDictionary.cpp
! src/share/vm/classfile/systemDictionary.hpp
! src/share/vm/oops/method.cpp
! src/share/vm/runtime/globals.hpp

Changeset: a947f40fb536
Author:    amurillo
Date:      2013-04-04 21:06 -0700
URL:       http://hg.openjdk.java.net/hsx/hsx25/hotspot/rev/a947f40fb536

Merge

- make/bsd/build.sh
- make/linux/build.sh
- make/solaris/build.sh

Changeset: 42fe530cd478
Author:    amurillo
Date:      2013-04-04 21:06 -0700
URL:       http://hg.openjdk.java.net/hsx/hsx25/hotspot/rev/42fe530cd478

Added tag hs25-b26 for changeset a947f40fb536

! .hgtags


From markus.gronlund at oracle.com  Fri Apr  5 02:17:55 2013
From: markus.gronlund at oracle.com (markus.gronlund at oracle.com)
Date: Fri, 05 Apr 2013 09:17:55 +0000
Subject: hg: hsx/hsx24/hotspot: 8011400: missing define OPENJDK for windows
	builds
Message-ID: <20130405091800.04713480C6@hg.openjdk.java.net>

Changeset: 03ba6eb06186
Author:    mgronlun
Date:      2013-04-05 08:53 +0200
URL:       http://hg.openjdk.java.net/hsx/hsx24/hotspot/rev/03ba6eb06186

8011400: missing define OPENJDK for windows builds
Reviewed-by: dcubed, sla

! make/windows/build.make
! make/windows/makefiles/trace.make
! make/windows/projectfiles/common/Makefile


From alejandro.murillo at oracle.com  Fri Apr  5 02:58:18 2013
From: alejandro.murillo at oracle.com (alejandro.murillo at oracle.com)
Date: Fri, 05 Apr 2013 09:58:18 +0000
Subject: hg: hsx/hotspot-main/hotspot: 4 new changesets
Message-ID: <20130405095839.5E79D480C8@hg.openjdk.java.net>

Changeset: ac242ddfa319
Author:    katleman
Date:      2013-04-04 19:05 -0700
URL:       http://hg.openjdk.java.net/hsx/hotspot-main/hotspot/rev/ac242ddfa319

Added tag jdk8-b84 for changeset af788b85010e

! .hgtags

Changeset: a947f40fb536
Author:    amurillo
Date:      2013-04-04 21:06 -0700
URL:       http://hg.openjdk.java.net/hsx/hotspot-main/hotspot/rev/a947f40fb536

Merge

- make/bsd/build.sh
- make/linux/build.sh
- make/solaris/build.sh

Changeset: 42fe530cd478
Author:    amurillo
Date:      2013-04-04 21:06 -0700
URL:       http://hg.openjdk.java.net/hsx/hotspot-main/hotspot/rev/42fe530cd478

Added tag hs25-b26 for changeset a947f40fb536

! .hgtags

Changeset: dcdeb150988c
Author:    amurillo
Date:      2013-04-04 21:15 -0700
URL:       http://hg.openjdk.java.net/hsx/hotspot-main/hotspot/rev/dcdeb150988c

8011584: new hotspot build - hs25-b27
Reviewed-by: jcoomes

! make/hotspot_version


From kevin.walls at oracle.com  Fri Apr  5 07:53:28 2013
From: kevin.walls at oracle.com (kevin.walls at oracle.com)
Date: Fri, 05 Apr 2013 14:53:28 +0000
Subject: hg: hsx/hsx24/hotspot: 8008917: CMS: Concurrent mode failure tracing
	event
Message-ID: <20130405145333.B9330480D1@hg.openjdk.java.net>

Changeset: 5c44c9466675
Author:    kevinw
Date:      2013-04-05 11:06 +0100
URL:       http://hg.openjdk.java.net/hsx/hsx24/hotspot/rev/5c44c9466675

8008917: CMS: Concurrent mode failure tracing event
Reviewed-by: jwilhelm, ehelin, brutisso

! src/share/vm/gc_implementation/concurrentMarkSweep/concurrentMarkSweepGeneration.cpp
! src/share/vm/gc_implementation/concurrentMarkSweep/concurrentMarkSweepGeneration.hpp
! src/share/vm/gc_implementation/shared/gcTrace.cpp
! src/share/vm/gc_implementation/shared/gcTrace.hpp
! src/share/vm/gc_implementation/shared/gcTraceSend.cpp
! src/share/vm/trace/trace.xml


From mark.reinhold at oracle.com  Fri Apr  5 11:13:43 2013
From: mark.reinhold at oracle.com (mark.reinhold at oracle.com)
Date: Fri,  5 Apr 2013 11:13:43 -0700 (PDT)
Subject: JEP 181: Align JVM Checks with Java Language Rules for Nested Classes
Message-ID: <20130405181343.09E2D1733@eggemoggin.niobe.net>

Posted: http://openjdk.java.net/jeps/181

- Mark

From alejandro.murillo at oracle.com  Fri Apr  5 14:06:20 2013
From: alejandro.murillo at oracle.com (alejandro.murillo at oracle.com)
Date: Fri, 05 Apr 2013 21:06:20 +0000
Subject: hg: hsx/hsx24/hotspot: 4 new changesets
Message-ID: <20130405210630.DA230480F6@hg.openjdk.java.net>

Changeset: 94e094f46104
Author:    katleman
Date:      2013-04-03 15:15 -0700
URL:       http://hg.openjdk.java.net/hsx/hsx24/hotspot/rev/94e094f46104

Added tag jdk7u14-b19 for changeset 5e622bdc713e

! .hgtags

Changeset: c23596bfe3b8
Author:    katleman
Date:      2013-04-05 09:10 -0700
URL:       http://hg.openjdk.java.net/hsx/hsx24/hotspot/rev/c23596bfe3b8

Added tag jdk7u14-b19 for changeset 94e094f46104

! .hgtags

Changeset: d6cf0e0eee29
Author:    amurillo
Date:      2013-04-05 10:32 -0700
URL:       http://hg.openjdk.java.net/hsx/hsx24/hotspot/rev/d6cf0e0eee29

Merge

- make/windows/projectfiles/kernel/Makefile
- make/windows/projectfiles/kernel/vm.def
- make/windows/projectfiles/kernel/vm.dsw

Changeset: 21b442e8b756
Author:    amurillo
Date:      2013-04-05 10:32 -0700
URL:       http://hg.openjdk.java.net/hsx/hsx24/hotspot/rev/21b442e8b756

Added tag hs24-b39 for changeset d6cf0e0eee29

! .hgtags


From alejandro.murillo at oracle.com  Fri Apr  5 21:30:03 2013
From: alejandro.murillo at oracle.com (alejandro.murillo at oracle.com)
Date: Sat, 06 Apr 2013 04:30:03 +0000
Subject: hg: hsx/hsx24/hotspot: 8011583: new hotspot build - hs24-b40
Message-ID: <20130406043007.C81134810D@hg.openjdk.java.net>

Changeset: 6477999efb5f
Author:    amurillo
Date:      2013-04-05 10:44 -0700
URL:       http://hg.openjdk.java.net/hsx/hsx24/hotspot/rev/6477999efb5f

8011583: new hotspot build - hs24-b40
Reviewed-by: jcoomes

! make/hotspot_version


From david.r.chase at oracle.com  Sat Apr  6 07:56:12 2013
From: david.r.chase at oracle.com (David Chase)
Date: Sat, 6 Apr 2013 10:56:12 -0400
Subject: RFR(M) : 7104565 : trim jprt build targets
In-Reply-To: <515D27BD.7010006@oracle.com>
References: <7C7CBBE7-2651-4F94-820A-C68378C46AA9@oracle.com>
	<515D27BD.7010006@oracle.com>
Message-ID: 

Wider list, more testing

Recap (for hs-dev minus hs-compiler-dev):

>> webrev: http://cr.openjdk.java.net/~drchase/7104565/webrev.02/
>> 
>> Problem:
>> Debug builds are inconsistently named, and are not needed for usual JPRT testing, and consume lots of space and time.
>> #ifdef conventions are a little dubious (I'm just paraphrasing from the bug here).
>> 
>> Fix:
>> Pick up Tom Rodriguez's work towards a fix (95+% complete),
>> translate forward in time to current build, check for omissions and changes.
>> 
>> Fix includes:
>> replace #ifdef DEBUG and #ifdef FASTDEBUG with #ifdef ASSERT
>> consistently name the debug build "debug" instead of "jvmg"
>> remove "debug" targets from JPRT properties files.
>> 
>> Testing:
>> Jtreg locally
>> JPRT of usual compiler tests
>> Cross-checked old diffs with new diffs
>> JPRT of compiler regression tests
>> Manually check that appropriate -DASSERT flag is passed to compilations.
>> 
>> Noticeable changes:
>> "make debug", not "make jvmg"
>> JPRT of compiler regression tests is much faster and times out much less often.


New webrev:

http://cr.openjdk.java.net/~drchase/7104565/webrev.04       (new style, corrected script)
http://cr.openjdk.java.net/~drchase/7104565/webrev.04.old (classic)


Additional testing:
open-closed new slowdebug build on Solaris10-Sparc, jtreg
open+closed new fastedbug and slowdebug build on MacOS-10.8, jtreg

JPRT from open+closed+changes build is bug-for-bug compatible with JPRT from open+closed build.
(i.e., same 10 failures in DefaultMethodsTest.java, I assume this is a property of whatever version of jdk8tl and/or hotspot I grabbed)

Scanned (find+grep) for occurrences of "^#.*DEBUG" in closed, found none.

Additional changes:
Added rule-with-warning to hotspot/Makefile for jvmg (necessary for new build)
Removed overlooked redundant files.
Corrected copyrights in changed files.
Removed trailing spaces from changed files.


Results of other scans:
find . -name * -exec egrep ^#.*[^_A-Z]DEBUG([^_A-Z]|$) /dev/null {} ;
---------
./make/windows/projectfiles/compiler2/ADLCompiler.dsp:# ADD CPP /nologo /ML /W3 /WX /Gm /GX /Zi /Od /I "." /I "$(HotSpotWorkSpace)\src\share\vm\opto" /I "..." /D "WIN32" /D "DEBUG" /D "_WINDOWS" /D "ASSERT" /Fr /FD /c

./make/windows/projectfiles/tiered/ADLCompiler.dsp:# ADD CPP /nologo /ML /W3 /WX /Gm /GX /Zi /Od /I "." /I "$(HotSpotWorkSpace)\src\share\vm\opto" /I "..." /D "WIN32" /D "DEBUG" /D "_WINDOWS" /D "ASSERT" /Fr /FD /c

./src/os/bsd/dtrace/jhelper.d:#define DEBUG
./src/os/bsd/dtrace/jhelper.d:#ifdef DEBUG
./src/os/solaris/dtrace/jhelper.d:#define DEBUG
./src/os/solaris/dtrace/jhelper.d:#ifdef DEBUG

./src/share/tools/hsdis/Makefile:#CPPFLAGS	+= /D"WIN32" /D"_WINDOWS" /D"DEBUG" /D"NDEBUG"
---------
find . -name * -exec egrep "DEBUG" /dev/null {} ;
(that's a search for \"DEBUG\", results are a subset of above)

The jhelper.d files seem to #define their own DEBUG; lacking other information, I'm leaving them alone.
I am not sure what to make of the windows.dsp files; I suspect those are not comments

Motivated by above, search for /DEBUG
find . -name * -exec egrep /DEBUG([^_A-Z]|$) /dev/null {} ;
---------
./src/share/tools/ProjectCreator/WinGammaPlatformVC10.java:        // We always want the /DEBUG option to get full symbol information in the pdb files
./src/share/tools/ProjectCreator/WinGammaPlatformVC10.java:        // Empty now that /DEBUG option is used by all configs
./src/share/tools/ProjectCreator/WinGammaPlatformVC7.java:      addAttr(rv, "GenerateDebugInformation", "TRUE"); // == /DEBUG option
./src/share/vm/opto/ifnode.cpp:  // bail (or bomb[ASSERT/DEBUG]) if NOT projection-->IfNode-->BoolNode
---------

find . -name * -exec egrep  DEBUG( |$) /dev/null {} ;
(nothing significant beyond what is already seen above)


QUESTIONS:
1) What about those Windows files?

2) I noticed that there were already both "debug.make" and "jvmg.make" with tiny differences.
The starting point for this work included changes to jvmg.make; it seems like those
should have been made to debug.make instead and jvmg.make deleted.
I experimentally removed all versions of jvmg.make and successfully configured
slow-debug and made images on MacOS.

for i in {bsd,linux,solaris} ; do diff -U 1 make/$i/makefiles/{jvmg,debug}.make; done
--- make/bsd/makefiles/jvmg.make	2013-04-05 17:18:25.000000000 -0400
+++ make/bsd/makefiles/debug.make	2013-04-05 17:18:25.000000000 -0400
@@ -29,5 +29,3 @@
 DEBUG_CFLAGS/BYFILE = $(DEBUG_CFLAGS/$@)$(DEBUG_CFLAGS/DEFAULT$(DEBUG_CFLAGS/$@))
-
-# _NMT_NOINLINE_ informs NMT that no inlining by Compiler
-CFLAGS += $(DEBUG_CFLAGS/BYFILE) -D_NMT_NOINLINE_
+CFLAGS += $(DEBUG_CFLAGS/BYFILE)
 
--- make/linux/makefiles/jvmg.make	2013-04-05 17:18:25.000000000 -0400
+++ make/linux/makefiles/debug.make	2013-04-05 17:18:25.000000000 -0400
@@ -29,5 +29,3 @@
 DEBUG_CFLAGS/BYFILE = $(DEBUG_CFLAGS/$@)$(DEBUG_CFLAGS/DEFAULT$(DEBUG_CFLAGS/$@))
-
-# _NMT_NOINLINE_ informs NMT that no inlining by Compiler
-CFLAGS += $(DEBUG_CFLAGS/BYFILE) -D_NMT_NOINLINE_
+CFLAGS += $(DEBUG_CFLAGS/BYFILE)
 
--- make/solaris/makefiles/jvmg.make	2013-04-05 17:18:25.000000000 -0400
+++ make/solaris/makefiles/debug.make	2013-04-05 17:18:25.000000000 -0400
@@ -1,3 +1,3 @@
 #
-# Copyright (c) 1999, 2013, Oracle and/or its affiliates. All rights reserved.
+# Copyright (c) 1998, 2013, Oracle and/or its affiliates. All rights reserved.
 # DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER.
@@ -39,4 +39,3 @@
 
-# _NMT_NOINLINE_ informs NMT that no inlining by Compiler
-CFLAGS += $(DEBUG_CFLAGS/BYFILE) -D_NMT_NOINLINE_
+CFLAGS += $(DEBUG_CFLAGS/BYFILE)
 




From vladimir.kozlov at oracle.com  Sat Apr  6 10:22:16 2013
From: vladimir.kozlov at oracle.com (Vladimir Kozlov)
Date: Sat, 06 Apr 2013 10:22:16 -0700
Subject: RFR(M) : 7104565 : trim jprt build targets
In-Reply-To: 
References: <7C7CBBE7-2651-4F94-820A-C68378C46AA9@oracle.com>
	<515D27BD.7010006@oracle.com>
	
Message-ID: <516059C8.3020008@oracle.com>

make/Makefile:

Instead of VM_SUBDIR=debug use what in other targets: 
VM_SUBDIR=$(@:export_%=%) (and $(@:export_%_jdk=%)) since name now matches.

make/bsd/makefiles/fastdebug.make: why did not changed?

make/solaris/makefiles/fastdebug.make: why you did next change? We 
should not low optimization level:

< OPT_CFLAGS/DEFAULT= $(OPT_CFLAGS)
---
 > OPT_CFLAGS/DEFAULT= $(OPT_CFLAGS/SLOWER)

All old debug.make should be removed and jvmg.make renamed to debug.make 
without changing its content. In other word, don't remove 
-D_NMT_NOINLINE_, it is needed.

On related NMT note: in src/share/vm/memory/allocation.hpp replace 
_DEBUG_ with _NMT_NOINLINE_.

In windows .dsp files remove /D "DEBUG"

./src/share/tools/hsdis/Makefile: remove that commented line.

Thanks,
Vladimir

On 4/6/13 7:56 AM, David Chase wrote:
> Wider list, more testing
>
> Recap (for hs-dev minus hs-compiler-dev):
>
>>> webrev: http://cr.openjdk.java.net/~drchase/7104565/webrev.02/
>>>
>>> Problem:
>>> Debug builds are inconsistently named, and are not needed for usual JPRT testing, and consume lots of space and time.
>>> #ifdef conventions are a little dubious (I'm just paraphrasing from the bug here).
>>>
>>> Fix:
>>> Pick up Tom Rodriguez's work towards a fix (95+% complete),
>>> translate forward in time to current build, check for omissions and changes.
>>>
>>> Fix includes:
>>> replace #ifdef DEBUG and #ifdef FASTDEBUG with #ifdef ASSERT
>>> consistently name the debug build "debug" instead of "jvmg"
>>> remove "debug" targets from JPRT properties files.
>>>
>>> Testing:
>>> Jtreg locally
>>> JPRT of usual compiler tests
>>> Cross-checked old diffs with new diffs
>>> JPRT of compiler regression tests
>>> Manually check that appropriate -DASSERT flag is passed to compilations.
>>>
>>> Noticeable changes:
>>> "make debug", not "make jvmg"
>>> JPRT of compiler regression tests is much faster and times out much less often.
>
>
> New webrev:
>
> http://cr.openjdk.java.net/~drchase/7104565/webrev.04       (new style, corrected script)
> http://cr.openjdk.java.net/~drchase/7104565/webrev.04.old (classic)
>
>
> Additional testing:
> open-closed new slowdebug build on Solaris10-Sparc, jtreg
> open+closed new fastedbug and slowdebug build on MacOS-10.8, jtreg
>
> JPRT from open+closed+changes build is bug-for-bug compatible with JPRT from open+closed build.
> (i.e., same 10 failures in DefaultMethodsTest.java, I assume this is a property of whatever version of jdk8tl and/or hotspot I grabbed)
>
> Scanned (find+grep) for occurrences of "^#.*DEBUG" in closed, found none.
>
> Additional changes:
> Added rule-with-warning to hotspot/Makefile for jvmg (necessary for new build)
> Removed overlooked redundant files.
> Corrected copyrights in changed files.
> Removed trailing spaces from changed files.
>
>
> Results of other scans:
> find . -name * -exec egrep ^#.*[^_A-Z]DEBUG([^_A-Z]|$) /dev/null {} ;
> ---------
> ./make/windows/projectfiles/compiler2/ADLCompiler.dsp:# ADD CPP /nologo /ML /W3 /WX /Gm /GX /Zi /Od /I "." /I "$(HotSpotWorkSpace)\src\share\vm\opto" /I "..." /D "WIN32" /D "DEBUG" /D "_WINDOWS" /D "ASSERT" /Fr /FD /c
>
> ./make/windows/projectfiles/tiered/ADLCompiler.dsp:# ADD CPP /nologo /ML /W3 /WX /Gm /GX /Zi /Od /I "." /I "$(HotSpotWorkSpace)\src\share\vm\opto" /I "..." /D "WIN32" /D "DEBUG" /D "_WINDOWS" /D "ASSERT" /Fr /FD /c
>
> ./src/os/bsd/dtrace/jhelper.d:#define DEBUG
> ./src/os/bsd/dtrace/jhelper.d:#ifdef DEBUG
> ./src/os/solaris/dtrace/jhelper.d:#define DEBUG
> ./src/os/solaris/dtrace/jhelper.d:#ifdef DEBUG
>
> ./src/share/tools/hsdis/Makefile:#CPPFLAGS	+= /D"WIN32" /D"_WINDOWS" /D"DEBUG" /D"NDEBUG"
> ---------
> find . -name * -exec egrep "DEBUG" /dev/null {} ;
> (that's a search for \"DEBUG\", results are a subset of above)
>
> The jhelper.d files seem to #define their own DEBUG; lacking other information, I'm leaving them alone.
> I am not sure what to make of the windows.dsp files; I suspect those are not comments
>
> Motivated by above, search for /DEBUG
> find . -name * -exec egrep /DEBUG([^_A-Z]|$) /dev/null {} ;
> ---------
> ./src/share/tools/ProjectCreator/WinGammaPlatformVC10.java:        // We always want the /DEBUG option to get full symbol information in the pdb files
> ./src/share/tools/ProjectCreator/WinGammaPlatformVC10.java:        // Empty now that /DEBUG option is used by all configs
> ./src/share/tools/ProjectCreator/WinGammaPlatformVC7.java:      addAttr(rv, "GenerateDebugInformation", "TRUE"); // == /DEBUG option
> ./src/share/vm/opto/ifnode.cpp:  // bail (or bomb[ASSERT/DEBUG]) if NOT projection-->IfNode-->BoolNode
> ---------
>
> find . -name * -exec egrep  DEBUG( |$) /dev/null {} ;
> (nothing significant beyond what is already seen above)
>
>
> QUESTIONS:
> 1) What about those Windows files?
>
> 2) I noticed that there were already both "debug.make" and "jvmg.make" with tiny differences.
> The starting point for this work included changes to jvmg.make; it seems like those
> should have been made to debug.make instead and jvmg.make deleted.
> I experimentally removed all versions of jvmg.make and successfully configured
> slow-debug and made images on MacOS.
>
> for i in {bsd,linux,solaris} ; do diff -U 1 make/$i/makefiles/{jvmg,debug}.make; done
> --- make/bsd/makefiles/jvmg.make	2013-04-05 17:18:25.000000000 -0400
> +++ make/bsd/makefiles/debug.make	2013-04-05 17:18:25.000000000 -0400
> @@ -29,5 +29,3 @@
>   DEBUG_CFLAGS/BYFILE = $(DEBUG_CFLAGS/$@)$(DEBUG_CFLAGS/DEFAULT$(DEBUG_CFLAGS/$@))
> -
> -# _NMT_NOINLINE_ informs NMT that no inlining by Compiler
> -CFLAGS += $(DEBUG_CFLAGS/BYFILE) -D_NMT_NOINLINE_
> +CFLAGS += $(DEBUG_CFLAGS/BYFILE)
>
> --- make/linux/makefiles/jvmg.make	2013-04-05 17:18:25.000000000 -0400
> +++ make/linux/makefiles/debug.make	2013-04-05 17:18:25.000000000 -0400
> @@ -29,5 +29,3 @@
>   DEBUG_CFLAGS/BYFILE = $(DEBUG_CFLAGS/$@)$(DEBUG_CFLAGS/DEFAULT$(DEBUG_CFLAGS/$@))
> -
> -# _NMT_NOINLINE_ informs NMT that no inlining by Compiler
> -CFLAGS += $(DEBUG_CFLAGS/BYFILE) -D_NMT_NOINLINE_
> +CFLAGS += $(DEBUG_CFLAGS/BYFILE)
>
> --- make/solaris/makefiles/jvmg.make	2013-04-05 17:18:25.000000000 -0400
> +++ make/solaris/makefiles/debug.make	2013-04-05 17:18:25.000000000 -0400
> @@ -1,3 +1,3 @@
>   #
> -# Copyright (c) 1999, 2013, Oracle and/or its affiliates. All rights reserved.
> +# Copyright (c) 1998, 2013, Oracle and/or its affiliates. All rights reserved.
>   # DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER.
> @@ -39,4 +39,3 @@
>
> -# _NMT_NOINLINE_ informs NMT that no inlining by Compiler
> -CFLAGS += $(DEBUG_CFLAGS/BYFILE) -D_NMT_NOINLINE_
> +CFLAGS += $(DEBUG_CFLAGS/BYFILE)
>
>
>
>

From christian.thalinger at oracle.com  Sat Apr  6 21:39:30 2013
From: christian.thalinger at oracle.com (Christian Thalinger)
Date: Sat, 6 Apr 2013 21:39:30 -0700
Subject: RFR (XXS): 8011678: test/Makefile should pick up JT_HOME environment
	variable
Message-ID: 

http://cr.openjdk.java.net/~twisti/8011678

8011678: test/Makefile should pick up JT_HOME environment variable
Reviewed-by:

The JT_HOME can only be overridden by a make argument or JPRT_JTREG_HOME.  Picking up the JT_HOME environment variable would be helpful.

test/Makefile


From vladimir.kozlov at oracle.com  Sun Apr  7 08:36:45 2013
From: vladimir.kozlov at oracle.com (Vladimir Kozlov)
Date: Sun, 07 Apr 2013 08:36:45 -0700
Subject: RFR (XXS): 8011678: test/Makefile should pick up JT_HOME
	environment variable
In-Reply-To: 
References: 
Message-ID: <5161928D.9010403@oracle.com>

Good.

Vladimir

On 4/6/13 9:39 PM, Christian Thalinger wrote:
> http://cr.openjdk.java.net/~twisti/8011678
>
> 8011678: test/Makefile should pick up JT_HOME environment variable
> Reviewed-by:
>
> The JT_HOME can only be overridden by a make argument or JPRT_JTREG_HOME.  Picking up the JT_HOME environment variable would be helpful.
>
> test/Makefile
>

From mikael.gerdin at oracle.com  Mon Apr  8 00:09:57 2013
From: mikael.gerdin at oracle.com (Mikael Gerdin)
Date: Mon, 08 Apr 2013 09:09:57 +0200
Subject: RFR (XXS): 8011678: test/Makefile should pick up JT_HOME
	environment variable
In-Reply-To: 
References: 
Message-ID: <51626D45.2070206@oracle.com>

Christian,

On 04/07/2013 06:39 AM, Christian Thalinger wrote:
> http://cr.openjdk.java.net/~twisti/8011678

Looks good to me.

/Mikael

>
> 8011678: test/Makefile should pick up JT_HOME environment variable
> Reviewed-by:
>
> The JT_HOME can only be overridden by a make argument or JPRT_JTREG_HOME.  Picking up the JT_HOME environment variable would be helpful.
>
> test/Makefile
>


From Nuwan.Kumarasiri at rockets.utoledo.edu  Mon Apr  8 08:36:04 2013
From: Nuwan.Kumarasiri at rockets.utoledo.edu (Kumarasiri, Nuwan R)
Date: Mon, 8 Apr 2013 15:36:04 +0000
Subject: Byte code verification source code location 
Message-ID: 

hello,

I raised this question in a different mailing list but i was asked to ask here.

I need to look at the byte code verification(http://docs.oracle.com/javase/specs/jvms/se7/html/jvms-4.html) implementation in openjdk. Could you kindly let me know the location of the byte code verification source code for version 7?

Thank you.

From vladimir.voskresensky at oracle.com  Mon Apr  1 09:10:10 2013
From: vladimir.voskresensky at oracle.com (Vladimir Voskresensky - Oracle)
Date: Mon, 01 Apr 2013 20:10:10 +0400
Subject: RFR: Project files for Solaris Studio / NetBeans
In-Reply-To: <5156C697.8060003@oracle.com>
References: <51507B60.6030809@oracle.com> <51531883.7070903@oracle.com>
	<5156C697.8060003@oracle.com>
Message-ID: <5159B162.4080805@oracle.com>

Jesper,

Minor comment: it's better to have env variable named IDE_ALT_BOOTDIR instead of 
IDE_JAVAPATH to give analogy with the old well known meaning.

Vladimir.

On 03/30/13 03:03 PM, Vladimir Voskresensky wrote:
> Jesper,
>
> It looks good and works for me on Linux_64.
>
> Some comments for others:
> before running IDE specify IDE_JAVAPATH env variable if want to navigate into 
> some java/include files (value is the same as previously was known as 
> ALT_BOOTDIR):
> #export IDE_JAVAPATH=/opt/jdk/latest7
> after opening project, make sure you are switched to Linux configuration
>
> Thanks!
> Vladimir.
>
> On 03/27/2013 08:04 PM, Jesper Wilhelmsson wrote:
>> Hi,
>>
>> A new webrev is now available. The issues reported from the first review 
>> should be fixed and the project now contains configurations for both Linux_64 
>> and Mac_64.
>>
>> To select configuration there is a dropdown menu next to the build button.
>>
>> http://cr.openjdk.java.net/~jwilhelm/7074926/webrev.2/
>>
>> Thanks,
>> /Jesper
>>
>>
>> Jesper Wilhelmsson skrev 25/3/13 5:29 PM:
>>> Hi,
>>>
>>> Sorry for cross posting, but I think this could be useful for several areas.
>>>
>>> I would like to add Solaris Studio / NetBeans project files for the entire
>>> OpenJDK project. To clarify: One project that contains the entire OpenJDK.
>>>
>>>
>>> With the new build infrastructure in JDK 8 building the entire OpenJDK is 
>>> fairly
>>> fast and even though I personally mostly work in the HotSpot tree, I tend to
>>> always clone and build the entire JDK forest. I find this to have several 
>>> benefits.
>>>
>>> Webrev: http://cr.openjdk.java.net/~jwilhelm/7074926/webrev/
>>>
>>> The configuration in this project is currently Mac only. Linux and Solaris
>>> configurations are also planned.
>>>
>>> The webrev is made from the jdk8/build repository which is where I think a
>>> change like this should go in. Let me know if you think something else.
>>>
>>>
>>>
>>> To use this project (once pushed):
>>>
>>> 1. Clone your favorite repository
>>>     hg clone http://hg.openjdk.java.net/hsx/hotspot-gc
>>>
>>> 2. Get the whole forest
>>>     cd hotspot-gc
>>>     sh get_source.sh
>>>
>>> 3. Configure
>>>     sh configure
>>>
>>> 4. Open Solaris studio / NetBeans and load the project.
>>>     The project in located in the common directory.
>>>
>>>
>>> Thanks,
>>> /Jesper
>

From mike.duigou at oracle.com  Sat Apr  6 23:58:57 2013
From: mike.duigou at oracle.com (Mike Duigou)
Date: Sat, 6 Apr 2013 23:58:57 -0700
Subject: RFR (XXS): 8011678: test/Makefile should pick up JT_HOME
	environment variable
In-Reply-To: 
References: 
Message-ID: 

This looks good to me. I will make the same change in the jdk/test/makefile for when it is invoked directly.

There is also an outstanding issue to add a --with-jtreg option to the configure script:

JDK-8007129 build-infra Add configure --with-jtreg option for location of JTREG home directory.

Mike

On Apr 6 2013, at 21:39 , Christian Thalinger wrote:

> http://cr.openjdk.java.net/~twisti/8011678
> 
> 8011678: test/Makefile should pick up JT_HOME environment variable
> Reviewed-by:
> 
> The JT_HOME can only be overridden by a make argument or JPRT_JTREG_HOME.  Picking up the JT_HOME environment variable would be helpful.
> 
> test/Makefile
> 


From krystal.mo at oracle.com  Mon Apr  8 09:03:10 2013
From: krystal.mo at oracle.com (Krystal Mo)
Date: Mon, 08 Apr 2013 09:03:10 -0700
Subject: Byte code verification source code location
In-Reply-To: 
References: 
Message-ID: <5162EA3E.8050405@oracle.com>

Hi,

The new verifier using stack maps (aka "type checking verifier" or the 
"split verifier") is located in 
hotspot/src/share/vm/classfile/verifier.[hpp|cpp]
The old verifier (aka "type inference verifier") is located in 
jdk/src/share/native/common/check_code.c

- Kris

On 2013/4/8 8:36, Kumarasiri, Nuwan R wrote:
> hello,
>
> I raised this question in a different mailing list but i was asked to ask here.
>
> I need to look at the byte code verification(http://docs.oracle.com/javase/specs/jvms/se7/html/jvms-4.html) implementation in openjdk. Could you kindly let me know the location of the byte code verification source code for version 7?
>
> Thank you.


From Nuwan.Kumarasiri at rockets.utoledo.edu  Mon Apr  8 11:26:08 2013
From: Nuwan.Kumarasiri at rockets.utoledo.edu (Kumarasiri, Nuwan R)
Date: Mon, 8 Apr 2013 18:26:08 +0000
Subject: Byte code verification source code location
In-Reply-To: <5162EA3E.8050405@oracle.com>
References: ,
	<5162EA3E.8050405@oracle.com>
Message-ID: 

hello Kris, 

Thank you for your reply. That helps. 

I also want to know if I borrow the same algorithm/code in hotspot/src/share/vm/classfile/verifier.[hpp|cpp] to implement the same feature in Jikes RVM will there be any copyright issue ? 

More information under "Bytecode verifier" at, 
http://docs.codehaus.org/display/RVM/Google+Summer+of+Code+2013

Thank you.
________________________________________
From: hotspot-dev-bounces at openjdk.java.net [hotspot-dev-bounces at openjdk.java.net] on behalf of Krystal Mo [krystal.mo at oracle.com]
Sent: Monday, April 08, 2013 12:03 PM
To: hotspot-dev at openjdk.java.net
Subject: Re: Byte code verification source code location

Hi,

The new verifier using stack maps (aka "type checking verifier" or the
"split verifier") is located in
hotspot/src/share/vm/classfile/verifier.[hpp|cpp]
The old verifier (aka "type inference verifier") is located in
jdk/src/share/native/common/check_code.c

- Kris

On 2013/4/8 8:36, Kumarasiri, Nuwan R wrote:
> hello,
>
> I raised this question in a different mailing list but i was asked to ask here.
>
> I need to look at the byte code verification(http://docs.oracle.com/javase/specs/jvms/se7/html/jvms-4.html) implementation in openjdk. Could you kindly let me know the location of the byte code verification source code for version 7?
>
> Thank you.



From kevin.walls at oracle.com  Mon Apr  8 13:53:49 2013
From: kevin.walls at oracle.com (kevin.walls at oracle.com)
Date: Mon, 08 Apr 2013 20:53:49 +0000
Subject: hg: hsx/hsx24/hotspot: 7178741: SA: jstack -m produce
	UnalignedAddressException in output (Linux)
Message-ID: <20130408205351.9803848156@hg.openjdk.java.net>

Changeset: c7b481c7e5d9
Author:    kevinw
Date:      2013-02-27 22:40 +0000
URL:       http://hg.openjdk.java.net/hsx/hsx24/hotspot/rev/c7b481c7e5d9

7178741: SA: jstack -m produce UnalignedAddressException in output (Linux)
Reviewed-by: poonam, sla

! agent/src/share/classes/sun/jvm/hotspot/debugger/linux/amd64/LinuxAMD64CFrame.java
! agent/src/share/classes/sun/jvm/hotspot/debugger/linux/x86/LinuxX86CFrame.java


From christian.thalinger at oracle.com  Mon Apr  8 18:48:15 2013
From: christian.thalinger at oracle.com (Christian Thalinger)
Date: Mon, 8 Apr 2013 18:48:15 -0700
Subject: RFR (XXS): 8011678: test/Makefile should pick up JT_HOME
	environment variable
In-Reply-To: 
References: 
	
Message-ID: <5FD29936-3648-48AB-8D0C-CE3D6430698C@oracle.com>

After checking the OpenJDK census it seems that only Vladimir is an official reviewer.  But that's just the official part.  Thanks for the reviews!

-- Chris

On Apr 6, 2013, at 11:58 PM, Mike Duigou  wrote:

> This looks good to me. I will make the same change in the jdk/test/makefile for when it is invoked directly.
> 
> There is also an outstanding issue to add a --with-jtreg option to the configure script:
> 
> JDK-8007129 build-infra Add configure --with-jtreg option for location of JTREG home directory.
> 
> Mike
> 
> On Apr 6 2013, at 21:39 , Christian Thalinger wrote:
> 
>> http://cr.openjdk.java.net/~twisti/8011678
>> 
>> 8011678: test/Makefile should pick up JT_HOME environment variable
>> Reviewed-by:
>> 
>> The JT_HOME can only be overridden by a make argument or JPRT_JTREG_HOME.  Picking up the JT_HOME environment variable would be helpful.
>> 
>> test/Makefile
>> 
> 


From krystal.mo at oracle.com  Mon Apr  8 19:25:24 2013
From: krystal.mo at oracle.com (Krystal Mo)
Date: Mon, 08 Apr 2013 19:25:24 -0700
Subject: Byte code verification source code location
In-Reply-To: 
References: ,
	<5162EA3E.8050405@oracle.com>
	
Message-ID: <51637C14.6050507@oracle.com>

Apparently the split verifier implements the algorithm as described in 
the JVM spec. So there should be no problem if you implement the same 
algorithm.
On borrowing code directly, I'm not so sure. Not a lawyer. I'd leave 
this topic to someone else.

For implementing the split verifier in Jikes RVM, though, a better 
source of reference would be the verifier in Maxine VM [1].
It can run as a standalone program, and it's written in Java for a 
metacircular JVM, which is exactly what the GSoC project suggestion is 
talking about.
Its license is in GPLv2 (whereas OpenJDK is licensed under GPLv2+CE 
under some constraints); I'd leave it to someone else to explain how 
compatible that is with Jikes RVM's EPL.
You can find more information on Maxine VM at [2], and the source code 
for the verifier can be found at [3].

- Kris

[1]: https://blogs.oracle.com/dns/entry/yet_another_offline_java_bytecode
[2]: https://wikis.oracle.com/display/MaxineVM/Home
[3]: 
https://kenai.com/hg/maxine~maxine/file/tip/com.oracle.max.vm/src/com/sun/max/vm/verifier

On 2013/4/8 11:26, Kumarasiri, Nuwan R wrote:
> hello Kris,
>
> Thank you for your reply. That helps.
>
> I also want to know if I borrow the same algorithm/code in hotspot/src/share/vm/classfile/verifier.[hpp|cpp] to implement the same feature in Jikes RVM will there be any copyright issue ?
>
> More information under "Bytecode verifier" at,
> http://docs.codehaus.org/display/RVM/Google+Summer+of+Code+2013
>
> Thank you.
> ________________________________________
> From: hotspot-dev-bounces at openjdk.java.net [hotspot-dev-bounces at openjdk.java.net] on behalf of Krystal Mo [krystal.mo at oracle.com]
> Sent: Monday, April 08, 2013 12:03 PM
> To: hotspot-dev at openjdk.java.net
> Subject: Re: Byte code verification source code location
>
> Hi,
>
> The new verifier using stack maps (aka "type checking verifier" or the
> "split verifier") is located in
> hotspot/src/share/vm/classfile/verifier.[hpp|cpp]
> The old verifier (aka "type inference verifier") is located in
> jdk/src/share/native/common/check_code.c
>
> - Kris
>
> On 2013/4/8 8:36, Kumarasiri, Nuwan R wrote:
>> hello,
>>
>> I raised this question in a different mailing list but i was asked to ask here.
>>
>> I need to look at the byte code verification(http://docs.oracle.com/javase/specs/jvms/se7/html/jvms-4.html) implementation in openjdk. Could you kindly let me know the location of the byte code verification source code for version 7?
>>
>> Thank you.
>


From Nuwan.Kumarasiri at rockets.utoledo.edu  Mon Apr  8 20:01:24 2013
From: Nuwan.Kumarasiri at rockets.utoledo.edu (Kumarasiri, Nuwan R)
Date: Tue, 9 Apr 2013 03:01:24 +0000
Subject: Byte code verification source code location
In-Reply-To: <51637C14.6050507@oracle.com>
References: ,
	<5162EA3E.8050405@oracle.com>
	,
	<51637C14.6050507@oracle.com>
Message-ID: 

hi Kris, 

Thank you for your detail answer. 


________________________________________
From: Krystal Mo [krystal.mo at oracle.com]
Sent: Monday, April 08, 2013 10:25 PM
To: Kumarasiri, Nuwan R
Cc: hotspot-dev at openjdk.java.net
Subject: Re: Byte code verification source code location

Apparently the split verifier implements the algorithm as described in
the JVM spec. So there should be no problem if you implement the same
algorithm.
On borrowing code directly, I'm not so sure. Not a lawyer. I'd leave
this topic to someone else.

For implementing the split verifier in Jikes RVM, though, a better
source of reference would be the verifier in Maxine VM [1].
It can run as a standalone program, and it's written in Java for a
metacircular JVM, which is exactly what the GSoC project suggestion is
talking about.
Its license is in GPLv2 (whereas OpenJDK is licensed under GPLv2+CE
under some constraints); I'd leave it to someone else to explain how
compatible that is with Jikes RVM's EPL.
You can find more information on Maxine VM at [2], and the source code
for the verifier can be found at [3].

- Kris

[1]: https://blogs.oracle.com/dns/entry/yet_another_offline_java_bytecode
[2]: https://wikis.oracle.com/display/MaxineVM/Home
[3]:
https://kenai.com/hg/maxine~maxine/file/tip/com.oracle.max.vm/src/com/sun/max/vm/verifier

On 2013/4/8 11:26, Kumarasiri, Nuwan R wrote:
> hello Kris,
>
> Thank you for your reply. That helps.
>
> I also want to know if I borrow the same algorithm/code in hotspot/src/share/vm/classfile/verifier.[hpp|cpp] to implement the same feature in Jikes RVM will there be any copyright issue ?
>
> More information under "Bytecode verifier" at,
> http://docs.codehaus.org/display/RVM/Google+Summer+of+Code+2013
>
> Thank you.
> ________________________________________
> From: hotspot-dev-bounces at openjdk.java.net [hotspot-dev-bounces at openjdk.java.net] on behalf of Krystal Mo [krystal.mo at oracle.com]
> Sent: Monday, April 08, 2013 12:03 PM
> To: hotspot-dev at openjdk.java.net
> Subject: Re: Byte code verification source code location
>
> Hi,
>
> The new verifier using stack maps (aka "type checking verifier" or the
> "split verifier") is located in
> hotspot/src/share/vm/classfile/verifier.[hpp|cpp]
> The old verifier (aka "type inference verifier") is located in
> jdk/src/share/native/common/check_code.c
>
> - Kris
>
> On 2013/4/8 8:36, Kumarasiri, Nuwan R wrote:
>> hello,
>>
>> I raised this question in a different mailing list but i was asked to ask here.
>>
>> I need to look at the byte code verification(http://docs.oracle.com/javase/specs/jvms/se7/html/jvms-4.html) implementation in openjdk. Could you kindly let me know the location of the byte code verification source code for version 7?
>>
>> Thank you.
>




From goetz.lindenmaier at sap.com  Tue Apr  9 08:04:07 2013
From: goetz.lindenmaier at sap.com (Lindenmaier, Goetz)
Date: Tue, 9 Apr 2013 15:04:07 +0000
Subject: RFR(M): Memory ordering in taskqueue.hpp
In-Reply-To: <51475515.9050908@oracle.com>
References: <140FA3E3585AD840A3316D2853F974DC1BF749F3BB@DEWDFECCR03.wdf.sap.corp>
	<50D26B81.8080903@oracle.com>
	<140FA3E3585AD840A3316D2853F974DC1BF699BBA0@DEWDFECCR03.wdf.sap.corp>
	<50D3CAA9.2080104@oracle.com>
	<140FA3E3585AD840A3316D2853F974DC1BF783BE76@DEWDFECCR03.wdf.sap.corp>
	<510327E8.2020907@oracle.com>
	<047B1E2ED51BB242803D2C392229AD370A48921020@DEWDFECCR03.wdf.sap.corp>
	<4295855A5C1DE049A61835A1887419CC0CFA9A9B@DEWDFEMB12A.global.corp.sap>
	
	<4295855A5C1DE049A61835A1887419CC0CFA9AF7@DEWDFEMB12A.global.corp.sap>
	
	<4295855A5C1DE049A61835A1887419CC0CFA9B1E@DEWDFEMB12A.global.corp.sap>
	
	
	<4295855A5C1DE049A61835A1887419CC0CFAC291@DEWDFEMB12A.global.corp.sap>
	<51475515.9050908@oracle.com>
Message-ID: <4295855A5C1DE049A61835A1887419CC0CFB125F@DEWDFEMB12A.global.corp.sap>

Hi John,

I'd like to get back to this issue.
Do you have the patch ready so we can test it?

Best regards,
  Goetz.

PS: In one of my mails I said you need an isync, unfortunately what I meant
is sync.

-----Original Message-----
From: John Cuthbertson [mailto:john.cuthbertson at oracle.com] 
Sent: Montag, 18. M?rz 2013 18:56
To: Lindenmaier, Goetz
Cc: Vitaly Davidovich; David Chase; Simonis, Volker; David Holmes; hotspot-dev at openjdk.java.net
Subject: Re: RFR(M): Memory ordering in taskqueue.hpp

Hi Geotz,

I have a patch that I synthesized from yours that I gave to one our 
engineers who is working on PowerPC. He was seeing crashes before 
applying your patch and mine. With either patch applied, the crashes 
disappear.

The only real difference between our patches is that I only ordered 
access to the _bottom field and left accesses to the _age field (and 
it's sub fields) unordered. If I give you my patch do you think you 
could test with it? It might take a day or two as I want to get the 
fixes for the G1 marking bugs committed - the stability of G1 is my 
highest priority.

BTW - whatever patch is committed - I intend to make you the contributor.

Cheers,

JohnC

On 3/18/2013 3:27 AM, Lindenmaier, Goetz wrote:
> Hi,
>
> I want to take up this issue again.
> I think we gave a good reason for the fence we added in the taskqueue.
> Do you have any remaining objections against this change?  We are
> happy to discuss or adapt the change.
> If not, could somebody please push this change to hotspot?
>
> http://cr.openjdk.java.net/~goetz/webrevs/8006971-2/
>
> Best regards,
>    Goetz.
>
>
> From: Vitaly Davidovich [mailto:vitalyd at gmail.com]
> Sent: Freitag, 8. M?rz 2013 17:13
> To: Volker Simonis
> Cc: hotspot-dev at openjdk.java.net; David Holmes; Lindenmaier, Goetz; Simonis, Volker
> Subject: Re: RFR(M): Memory ordering in taskqueue.hpp
>
>
> I see, thanks for the explanation guys.  Is there no atomic/locked (in x86 sense) store instruction on power? Is that what you mean by multiple atomicity? Not familiar with power, so being ignorant :).
>
> Sent from my phone
> On Mar 8, 2013 11:08 AM, "Volker Simonis" > wrote:
> On Fri, Mar 8, 2013 at 4:31 PM, Lindenmaier, Goetz
> > wrote:
>> Hi Vitaly,
>>
>> the writer has a sync after the write to bottom (see pop_local)
>> but the store and the sync are not one atomic operation.  Stuff
>> can happen before the sync is executed.  Therefore the reader
>> must sync, too.
>>
> Exactly - you have three threads. The first one executes the write
> to bottom but not the following sync. The second thread reads this
> new value (by chance) and uses it but the third thread still sees the
> old value because there's no multipl-copy-atomicity on PPC. So we
> really need the sync before the read to assure thread three is not seeing
> an older value than thread two.
>
>> Anyways, in pop_global it should be cheaper than in pop_local.
>>
>> Best regards,
>>    Geotz.
>>
>> From: Vitaly Davidovich [mailto:vitalyd at gmail.com]
>> Sent: Freitag, 8. M?rz 2013 16:13
>> To: Lindenmaier, Goetz
>> Cc: hotspot-dev at openjdk.java.net; David Holmes; John Cuthbertson; Simonis, Volker
>> Subject: RE: RFR(M): Memory ordering in taskqueue.hpp
>>
>>
>> Hmm, if load fences on the reader aren't sufficient, seems like the problem is missing order/fence on the writer? If the write isn't visible to all processors immediately on power, shouldn't there be a fence in the write to ensure all CPUs see it? Putting the fence in the reader seems odd, but maybe that's just me.
>>
>> Thanks
>>
>> Sent from my phone
>> On Mar 8, 2013 10:03 AM, "Lindenmaier, Goetz" >> wrote:
>> Hi Vitaly,
>>
>> No, the problem is not reordering.  The problem is that
>> _bottom, which is read after _age, might be older than _age because
>> another processor didn't write it back yet.  The fence (sync) makes the
>> current thread wait until it has the new _bottom.
>> On Power, a write is not visible to all other threads simultaneously
>> (no multipl-copy-atomicity).
>>
>> What you propose helps if you look at two processors, but not if
>> four threads on four processors are involved.
>>
>> Best regards,
>>    Goetz.
>>
>>
>> From: Vitaly Davidovich [mailto:vitalyd at gmail.com>]
>> Sent: Freitag, 8. M?rz 2013 15:29
>> To: Lindenmaier, Goetz
>> Cc: David Holmes; hotspot-dev at openjdk.java.net>; John Cuthbertson; Simonis, Volker
>> Subject: RE: RFR(M): Memory ordering in taskqueue.hpp
>>
>>
>> Hi Goetz,
>>
>> If I understand correctly the problem is that bottom is loaded before age via compiler or arch reordering.  But why is a full fence needed? Is it not sufficient to have just a load fence to load age and relaxed load (just compiler barrier) for bottom?
>>
>> Thanks
>>
>> Sent from my phone
>> On Mar 8, 2013 9:06 AM, "Lindenmaier, Goetz" >> wrote:
>> Hi,
>>
>> we have been, and still are, doing research on this issue.
>> We want to keep you up to date on this, and propose on the
>> further proceeding.
>>
>> You asked explicit memory ordering operations and a rationale
>> why we added them.
>>
>> Axel found a paper describing the task queue algorithm and the
>> needed ordering on arm and power:
>> Correct and Efficient Work-Stealing for Weak Memory Models;
>> L?, Pop, Cohen, Nardelli; PPoPP'13;
>> http://www.di.ens.fr/~zappa/readings/ppopp13.pdf
>>
>> According to this paper we need to add one fence and one load_acquire
>> to your implementation of the task queue.  You find this fence in this small
>> webrev:  http://cr.openjdk.java.net/~goetz/webrevs/8006971-2/
>>
>> With this fence, the algorithm works on Linux for our openjdk ppc
>> port, and also for our SAP JVM .
>>
>> Actually, the fence fixes a problem we discovered with the concurrency
>> torture test suite.  The problem occurs with four or more GC threads.
>> If three threads are stealing from the queue of the fourth, two of
>> them can pop the same element. Without a fence between the access
>> to age and bottom in pop_global(), bottom can be older than age.
>>
>>
>> Unfortunately, the OpenJDK implementation with the added fence
>> does not work on AIX.  Axel already detected one place where the xlC
>> compiler optimization removed load instruction that is required for
>> the correctness of the algorithm.  If we use our access routines with load_acquire
>> (see original webrev below) everything works, unclear why.
>>
>> Now, we think C++ might allow that this load is removed and xlC does
>> the correct, but unexpected thing.  On the other hand it might also be
>> a compiler bug.
>> We are currently discussing this with the IBM xlC developers.
>>
>> Best regards,
>>    Axel and Goetz.
>>
>>
>> PS: The webrev we proposed originally:
>> http://cr.openjdk.java.net/~goetz/webrevs/webrev-taskqueue/
>>
>>
>>
>>
>>
>>


From david.r.chase at oracle.com  Tue Apr  9 13:30:47 2013
From: david.r.chase at oracle.com (David Chase)
Date: Tue, 9 Apr 2013 16:30:47 -0400
Subject: RFR(M) : 7104565 : trim jprt build targets
In-Reply-To: <516059C8.3020008@oracle.com>
References: <7C7CBBE7-2651-4F94-820A-C68378C46AA9@oracle.com>
	<515D27BD.7010006@oracle.com>
	
	<516059C8.3020008@oracle.com>
Message-ID: 

http://cr.openjdk.java.net/~drchase/7104565/webrev.05/

All issues below addressed.
Diffs brought up-to-date with more recent version of hotspot.
(re-)tested on JPRT, manually verified that MacOS debug build was in fact debuggable and that effects of -D ASSERT were seen (set breakpoints in methods that would have been inlined otherwise).


On 2013-04-06, at 1:22 PM, Vladimir Kozlov  wrote:

> make/Makefile:
> 
> Instead of VM_SUBDIR=debug use what in other targets: VM_SUBDIR=$(@:export_%=%) (and $(@:export_%_jdk=%)) since name now matches.
> 
> make/bsd/makefiles/fastdebug.make: why did not changed?
> 
> make/solaris/makefiles/fastdebug.make: why you did next change? We should not low optimization level:
> 
> < OPT_CFLAGS/DEFAULT= $(OPT_CFLAGS)
> ---
> > OPT_CFLAGS/DEFAULT= $(OPT_CFLAGS/SLOWER)
> 
> All old debug.make should be removed and jvmg.make renamed to debug.make without changing its content. In other word, don't remove -D_NMT_NOINLINE_, it is needed.
> 
> On related NMT note: in src/share/vm/memory/allocation.hpp replace _DEBUG_ with _NMT_NOINLINE_.
> 
> In windows .dsp files remove /D "DEBUG"
> 
> ./src/share/tools/hsdis/Makefile: remove that commented line.
> 
> Thanks,
> Vladimir
> 
> On 4/6/13 7:56 AM, David Chase wrote:
>> Wider list, more testing
>> 
>> Recap (for hs-dev minus hs-compiler-dev):
>> 
>>>> webrev: http://cr.openjdk.java.net/~drchase/7104565/webrev.02/
>>>> 
>>>> Problem:
>>>> Debug builds are inconsistently named, and are not needed for usual JPRT testing, and consume lots of space and time.
>>>> #ifdef conventions are a little dubious (I'm just paraphrasing from the bug here).
>>>> 
>>>> Fix:
>>>> Pick up Tom Rodriguez's work towards a fix (95+% complete),
>>>> translate forward in time to current build, check for omissions and changes.
>>>> 
>>>> Fix includes:
>>>> replace #ifdef DEBUG and #ifdef FASTDEBUG with #ifdef ASSERT
>>>> consistently name the debug build "debug" instead of "jvmg"
>>>> remove "debug" targets from JPRT properties files.
>>>> 
>>>> Testing:
>>>> Jtreg locally
>>>> JPRT of usual compiler tests
>>>> Cross-checked old diffs with new diffs
>>>> JPRT of compiler regression tests
>>>> Manually check that appropriate -DASSERT flag is passed to compilations.
>>>> 
>>>> Noticeable changes:
>>>> "make debug", not "make jvmg"
>>>> JPRT of compiler regression tests is much faster and times out much less often.
>> 
>> 
>> New webrev:
>> 
>> http://cr.openjdk.java.net/~drchase/7104565/webrev.04       (new style, corrected script)
>> http://cr.openjdk.java.net/~drchase/7104565/webrev.04.old (classic)
>> 
>> 
>> Additional testing:
>> open-closed new slowdebug build on Solaris10-Sparc, jtreg
>> open+closed new fastedbug and slowdebug build on MacOS-10.8, jtreg
>> 
>> JPRT from open+closed+changes build is bug-for-bug compatible with JPRT from open+closed build.
>> (i.e., same 10 failures in DefaultMethodsTest.java, I assume this is a property of whatever version of jdk8tl and/or hotspot I grabbed)
>> 
>> Scanned (find+grep) for occurrences of "^#.*DEBUG" in closed, found none.
>> 
>> Additional changes:
>> Added rule-with-warning to hotspot/Makefile for jvmg (necessary for new build)
>> Removed overlooked redundant files.
>> Corrected copyrights in changed files.
>> Removed trailing spaces from changed files.
>> 
>> 
>> Results of other scans:
>> find . -name * -exec egrep ^#.*[^_A-Z]DEBUG([^_A-Z]|$) /dev/null {} ;
>> ---------
>> ./make/windows/projectfiles/compiler2/ADLCompiler.dsp:# ADD CPP /nologo /ML /W3 /WX /Gm /GX /Zi /Od /I "." /I "$(HotSpotWorkSpace)\src\share\vm\opto" /I "..." /D "WIN32" /D "DEBUG" /D "_WINDOWS" /D "ASSERT" /Fr /FD /c
>> 
>> ./make/windows/projectfiles/tiered/ADLCompiler.dsp:# ADD CPP /nologo /ML /W3 /WX /Gm /GX /Zi /Od /I "." /I "$(HotSpotWorkSpace)\src\share\vm\opto" /I "..." /D "WIN32" /D "DEBUG" /D "_WINDOWS" /D "ASSERT" /Fr /FD /c
>> 
>> ./src/os/bsd/dtrace/jhelper.d:#define DEBUG
>> ./src/os/bsd/dtrace/jhelper.d:#ifdef DEBUG
>> ./src/os/solaris/dtrace/jhelper.d:#define DEBUG
>> ./src/os/solaris/dtrace/jhelper.d:#ifdef DEBUG
>> 
>> ./src/share/tools/hsdis/Makefile:#CPPFLAGS	+= /D"WIN32" /D"_WINDOWS" /D"DEBUG" /D"NDEBUG"
>> ---------
>> find . -name * -exec egrep "DEBUG" /dev/null {} ;
>> (that's a search for \"DEBUG\", results are a subset of above)
>> 
>> The jhelper.d files seem to #define their own DEBUG; lacking other information, I'm leaving them alone.
>> I am not sure what to make of the windows.dsp files; I suspect those are not comments
>> 
>> Motivated by above, search for /DEBUG
>> find . -name * -exec egrep /DEBUG([^_A-Z]|$) /dev/null {} ;
>> ---------
>> ./src/share/tools/ProjectCreator/WinGammaPlatformVC10.java:        // We always want the /DEBUG option to get full symbol information in the pdb files
>> ./src/share/tools/ProjectCreator/WinGammaPlatformVC10.java:        // Empty now that /DEBUG option is used by all configs
>> ./src/share/tools/ProjectCreator/WinGammaPlatformVC7.java:      addAttr(rv, "GenerateDebugInformation", "TRUE"); // == /DEBUG option
>> ./src/share/vm/opto/ifnode.cpp:  // bail (or bomb[ASSERT/DEBUG]) if NOT projection-->IfNode-->BoolNode
>> ---------
>> 
>> find . -name * -exec egrep  DEBUG( |$) /dev/null {} ;
>> (nothing significant beyond what is already seen above)
>> 
>> 
>> QUESTIONS:
>> 1) What about those Windows files?
>> 
>> 2) I noticed that there were already both "debug.make" and "jvmg.make" with tiny differences.
>> The starting point for this work included changes to jvmg.make; it seems like those
>> should have been made to debug.make instead and jvmg.make deleted.
>> I experimentally removed all versions of jvmg.make and successfully configured
>> slow-debug and made images on MacOS.
>> 
>> for i in {bsd,linux,solaris} ; do diff -U 1 make/$i/makefiles/{jvmg,debug}.make; done
>> --- make/bsd/makefiles/jvmg.make	2013-04-05 17:18:25.000000000 -0400
>> +++ make/bsd/makefiles/debug.make	2013-04-05 17:18:25.000000000 -0400
>> @@ -29,5 +29,3 @@
>>  DEBUG_CFLAGS/BYFILE = $(DEBUG_CFLAGS/$@)$(DEBUG_CFLAGS/DEFAULT$(DEBUG_CFLAGS/$@))
>> -
>> -# _NMT_NOINLINE_ informs NMT that no inlining by Compiler
>> -CFLAGS += $(DEBUG_CFLAGS/BYFILE) -D_NMT_NOINLINE_
>> +CFLAGS += $(DEBUG_CFLAGS/BYFILE)
>> 
>> --- make/linux/makefiles/jvmg.make	2013-04-05 17:18:25.000000000 -0400
>> +++ make/linux/makefiles/debug.make	2013-04-05 17:18:25.000000000 -0400
>> @@ -29,5 +29,3 @@
>>  DEBUG_CFLAGS/BYFILE = $(DEBUG_CFLAGS/$@)$(DEBUG_CFLAGS/DEFAULT$(DEBUG_CFLAGS/$@))
>> -
>> -# _NMT_NOINLINE_ informs NMT that no inlining by Compiler
>> -CFLAGS += $(DEBUG_CFLAGS/BYFILE) -D_NMT_NOINLINE_
>> +CFLAGS += $(DEBUG_CFLAGS/BYFILE)
>> 
>> --- make/solaris/makefiles/jvmg.make	2013-04-05 17:18:25.000000000 -0400
>> +++ make/solaris/makefiles/debug.make	2013-04-05 17:18:25.000000000 -0400
>> @@ -1,3 +1,3 @@
>>  #
>> -# Copyright (c) 1999, 2013, Oracle and/or its affiliates. All rights reserved.
>> +# Copyright (c) 1998, 2013, Oracle and/or its affiliates. All rights reserved.
>>  # DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER.
>> @@ -39,4 +39,3 @@
>> 
>> -# _NMT_NOINLINE_ informs NMT that no inlining by Compiler
>> -CFLAGS += $(DEBUG_CFLAGS/BYFILE) -D_NMT_NOINLINE_
>> +CFLAGS += $(DEBUG_CFLAGS/BYFILE)
>> 
>> 
>> 
>> 


From vladimir.kozlov at oracle.com  Tue Apr  9 14:26:01 2013
From: vladimir.kozlov at oracle.com (Vladimir Kozlov)
Date: Tue, 09 Apr 2013 14:26:01 -0700
Subject: RFR(M) : 7104565 : trim jprt build targets
In-Reply-To: 
References: <7C7CBBE7-2651-4F94-820A-C68378C46AA9@oracle.com>
	<515D27BD.7010006@oracle.com>
	
	<516059C8.3020008@oracle.com>
	
Message-ID: <51648769.7000809@oracle.com>

Thank you, Davis

This looks good.

One note: in frame_sparc.cpp remove 'jvmg' in the line you modified 
since we will not build jvmg.

And question: did you use mercurial commands to remove and rename 
jvm.make and debug.make? We need to use hg commands to preserve changes 
history for jvmg.make (it has more changesets then old debug.make).

I just want to confirm because sometimes webrev may not show correctly 
what was done to sources. I mean you need to do:

hg remove debug.make
hg rename jvmg.make debug.make

and then edit debug.make

Thanks,
Vladimir

On 4/9/13 1:30 PM, David Chase wrote:
> http://cr.openjdk.java.net/~drchase/7104565/webrev.05/
>
> All issues below addressed.
> Diffs brought up-to-date with more recent version of hotspot.
> (re-)tested on JPRT, manually verified that MacOS debug build was in fact debuggable and that effects of -D ASSERT were seen (set breakpoints in methods that would have been inlined otherwise).
>
>
> On 2013-04-06, at 1:22 PM, Vladimir Kozlov  wrote:
>
>> make/Makefile:
>>
>> Instead of VM_SUBDIR=debug use what in other targets: VM_SUBDIR=$(@:export_%=%) (and $(@:export_%_jdk=%)) since name now matches.
>>
>> make/bsd/makefiles/fastdebug.make: why did not changed?
>>
>> make/solaris/makefiles/fastdebug.make: why you did next change? We should not low optimization level:
>>
>> < OPT_CFLAGS/DEFAULT= $(OPT_CFLAGS)
>> ---
>>> OPT_CFLAGS/DEFAULT= $(OPT_CFLAGS/SLOWER)
>>
>> All old debug.make should be removed and jvmg.make renamed to debug.make without changing its content. In other word, don't remove -D_NMT_NOINLINE_, it is needed.
>>
>> On related NMT note: in src/share/vm/memory/allocation.hpp replace _DEBUG_ with _NMT_NOINLINE_.
>>
>> In windows .dsp files remove /D "DEBUG"
>>
>> ./src/share/tools/hsdis/Makefile: remove that commented line.
>>
>> Thanks,
>> Vladimir
>>
>> On 4/6/13 7:56 AM, David Chase wrote:
>>> Wider list, more testing
>>>
>>> Recap (for hs-dev minus hs-compiler-dev):
>>>
>>>>> webrev: http://cr.openjdk.java.net/~drchase/7104565/webrev.02/
>>>>>
>>>>> Problem:
>>>>> Debug builds are inconsistently named, and are not needed for usual JPRT testing, and consume lots of space and time.
>>>>> #ifdef conventions are a little dubious (I'm just paraphrasing from the bug here).
>>>>>
>>>>> Fix:
>>>>> Pick up Tom Rodriguez's work towards a fix (95+% complete),
>>>>> translate forward in time to current build, check for omissions and changes.
>>>>>
>>>>> Fix includes:
>>>>> replace #ifdef DEBUG and #ifdef FASTDEBUG with #ifdef ASSERT
>>>>> consistently name the debug build "debug" instead of "jvmg"
>>>>> remove "debug" targets from JPRT properties files.
>>>>>
>>>>> Testing:
>>>>> Jtreg locally
>>>>> JPRT of usual compiler tests
>>>>> Cross-checked old diffs with new diffs
>>>>> JPRT of compiler regression tests
>>>>> Manually check that appropriate -DASSERT flag is passed to compilations.
>>>>>
>>>>> Noticeable changes:
>>>>> "make debug", not "make jvmg"
>>>>> JPRT of compiler regression tests is much faster and times out much less often.
>>>
>>>
>>> New webrev:
>>>
>>> http://cr.openjdk.java.net/~drchase/7104565/webrev.04       (new style, corrected script)
>>> http://cr.openjdk.java.net/~drchase/7104565/webrev.04.old (classic)
>>>
>>>
>>> Additional testing:
>>> open-closed new slowdebug build on Solaris10-Sparc, jtreg
>>> open+closed new fastedbug and slowdebug build on MacOS-10.8, jtreg
>>>
>>> JPRT from open+closed+changes build is bug-for-bug compatible with JPRT from open+closed build.
>>> (i.e., same 10 failures in DefaultMethodsTest.java, I assume this is a property of whatever version of jdk8tl and/or hotspot I grabbed)
>>>
>>> Scanned (find+grep) for occurrences of "^#.*DEBUG" in closed, found none.
>>>
>>> Additional changes:
>>> Added rule-with-warning to hotspot/Makefile for jvmg (necessary for new build)
>>> Removed overlooked redundant files.
>>> Corrected copyrights in changed files.
>>> Removed trailing spaces from changed files.
>>>
>>>
>>> Results of other scans:
>>> find . -name * -exec egrep ^#.*[^_A-Z]DEBUG([^_A-Z]|$) /dev/null {} ;
>>> ---------
>>> ./make/windows/projectfiles/compiler2/ADLCompiler.dsp:# ADD CPP /nologo /ML /W3 /WX /Gm /GX /Zi /Od /I "." /I "$(HotSpotWorkSpace)\src\share\vm\opto" /I "..." /D "WIN32" /D "DEBUG" /D "_WINDOWS" /D "ASSERT" /Fr /FD /c
>>>
>>> ./make/windows/projectfiles/tiered/ADLCompiler.dsp:# ADD CPP /nologo /ML /W3 /WX /Gm /GX /Zi /Od /I "." /I "$(HotSpotWorkSpace)\src\share\vm\opto" /I "..." /D "WIN32" /D "DEBUG" /D "_WINDOWS" /D "ASSERT" /Fr /FD /c
>>>
>>> ./src/os/bsd/dtrace/jhelper.d:#define DEBUG
>>> ./src/os/bsd/dtrace/jhelper.d:#ifdef DEBUG
>>> ./src/os/solaris/dtrace/jhelper.d:#define DEBUG
>>> ./src/os/solaris/dtrace/jhelper.d:#ifdef DEBUG
>>>
>>> ./src/share/tools/hsdis/Makefile:#CPPFLAGS	+= /D"WIN32" /D"_WINDOWS" /D"DEBUG" /D"NDEBUG"
>>> ---------
>>> find . -name * -exec egrep "DEBUG" /dev/null {} ;
>>> (that's a search for \"DEBUG\", results are a subset of above)
>>>
>>> The jhelper.d files seem to #define their own DEBUG; lacking other information, I'm leaving them alone.
>>> I am not sure what to make of the windows.dsp files; I suspect those are not comments
>>>
>>> Motivated by above, search for /DEBUG
>>> find . -name * -exec egrep /DEBUG([^_A-Z]|$) /dev/null {} ;
>>> ---------
>>> ./src/share/tools/ProjectCreator/WinGammaPlatformVC10.java:        // We always want the /DEBUG option to get full symbol information in the pdb files
>>> ./src/share/tools/ProjectCreator/WinGammaPlatformVC10.java:        // Empty now that /DEBUG option is used by all configs
>>> ./src/share/tools/ProjectCreator/WinGammaPlatformVC7.java:      addAttr(rv, "GenerateDebugInformation", "TRUE"); // == /DEBUG option
>>> ./src/share/vm/opto/ifnode.cpp:  // bail (or bomb[ASSERT/DEBUG]) if NOT projection-->IfNode-->BoolNode
>>> ---------
>>>
>>> find . -name * -exec egrep  DEBUG( |$) /dev/null {} ;
>>> (nothing significant beyond what is already seen above)
>>>
>>>
>>> QUESTIONS:
>>> 1) What about those Windows files?
>>>
>>> 2) I noticed that there were already both "debug.make" and "jvmg.make" with tiny differences.
>>> The starting point for this work included changes to jvmg.make; it seems like those
>>> should have been made to debug.make instead and jvmg.make deleted.
>>> I experimentally removed all versions of jvmg.make and successfully configured
>>> slow-debug and made images on MacOS.
>>>
>>> for i in {bsd,linux,solaris} ; do diff -U 1 make/$i/makefiles/{jvmg,debug}.make; done
>>> --- make/bsd/makefiles/jvmg.make	2013-04-05 17:18:25.000000000 -0400
>>> +++ make/bsd/makefiles/debug.make	2013-04-05 17:18:25.000000000 -0400
>>> @@ -29,5 +29,3 @@
>>>   DEBUG_CFLAGS/BYFILE = $(DEBUG_CFLAGS/$@)$(DEBUG_CFLAGS/DEFAULT$(DEBUG_CFLAGS/$@))
>>> -
>>> -# _NMT_NOINLINE_ informs NMT that no inlining by Compiler
>>> -CFLAGS += $(DEBUG_CFLAGS/BYFILE) -D_NMT_NOINLINE_
>>> +CFLAGS += $(DEBUG_CFLAGS/BYFILE)
>>>
>>> --- make/linux/makefiles/jvmg.make	2013-04-05 17:18:25.000000000 -0400
>>> +++ make/linux/makefiles/debug.make	2013-04-05 17:18:25.000000000 -0400
>>> @@ -29,5 +29,3 @@
>>>   DEBUG_CFLAGS/BYFILE = $(DEBUG_CFLAGS/$@)$(DEBUG_CFLAGS/DEFAULT$(DEBUG_CFLAGS/$@))
>>> -
>>> -# _NMT_NOINLINE_ informs NMT that no inlining by Compiler
>>> -CFLAGS += $(DEBUG_CFLAGS/BYFILE) -D_NMT_NOINLINE_
>>> +CFLAGS += $(DEBUG_CFLAGS/BYFILE)
>>>
>>> --- make/solaris/makefiles/jvmg.make	2013-04-05 17:18:25.000000000 -0400
>>> +++ make/solaris/makefiles/debug.make	2013-04-05 17:18:25.000000000 -0400
>>> @@ -1,3 +1,3 @@
>>>   #
>>> -# Copyright (c) 1999, 2013, Oracle and/or its affiliates. All rights reserved.
>>> +# Copyright (c) 1998, 2013, Oracle and/or its affiliates. All rights reserved.
>>>   # DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER.
>>> @@ -39,4 +39,3 @@
>>>
>>> -# _NMT_NOINLINE_ informs NMT that no inlining by Compiler
>>> -CFLAGS += $(DEBUG_CFLAGS/BYFILE) -D_NMT_NOINLINE_
>>> +CFLAGS += $(DEBUG_CFLAGS/BYFILE)
>>>
>>>
>>>
>>>
>

From david.r.chase at oracle.com  Tue Apr  9 16:01:12 2013
From: david.r.chase at oracle.com (David Chase)
Date: Tue, 9 Apr 2013 19:01:12 -0400
Subject: RFR(M) : 7104565 : trim jprt build targets
In-Reply-To: <51648769.7000809@oracle.com>
References: <7C7CBBE7-2651-4F94-820A-C68378C46AA9@oracle.com>
	<515D27BD.7010006@oracle.com>
	
	<516059C8.3020008@oracle.com>
	
	<51648769.7000809@oracle.com>
Message-ID: <293891EC-45D0-4549-BD66-3605C6E757EC@oracle.com>


On 2013-04-09, at 5:26 PM, Vladimir Kozlov  wrote:
> One note: in frame_sparc.cpp remove 'jvmg' in the line you modified since we will not build jvmg.

done

> And question: did you use mercurial commands to remove and rename jvm.make and debug.make? We need to use hg commands to preserve changes history for jvmg.make (it has more changesets then old debug.make).
> 
> I just want to confirm because sometimes webrev may not show correctly what was done to sources. I mean you need to do:
> 
> hg remove debug.make
> hg rename jvmg.make debug.make
> 
> and then edit debug.make

To be sure:

10009  hg revert make/{solaris,bsd,linux}/makefiles/jvmg.make
10010  zip -9 ../safemakes.zip make/{solaris,bsd,linux}/makefiles/debug.make
10011  hg revert make/{solaris,bsd,linux}/makefiles/debug.make
10012  hg remove make/{solaris,bsd,linux}/makefiles/debug.make
10013  for i in solaris bsd linux ; do hg rename make/$i/makefiles/{jvmg,debug}.make; done
10014  unzip -l ../safemakes.zip
10015  unzip ../safemakes.zip

And the new-and-improved diffs:

http://cr.openjdk.java.net/~drchase/7104565/webrev.06-new/



From vladimir.kozlov at oracle.com  Tue Apr  9 16:26:23 2013
From: vladimir.kozlov at oracle.com (Vladimir Kozlov)
Date: Tue, 09 Apr 2013 16:26:23 -0700
Subject: RFR(M) : 7104565 : trim jprt build targets
In-Reply-To: <293891EC-45D0-4549-BD66-3605C6E757EC@oracle.com>
References: <7C7CBBE7-2651-4F94-820A-C68378C46AA9@oracle.com>
	<515D27BD.7010006@oracle.com>
	
	<516059C8.3020008@oracle.com>
	
	<51648769.7000809@oracle.com>
	<293891EC-45D0-4549-BD66-3605C6E757EC@oracle.com>
Message-ID: <5164A39F.1020107@oracle.com>

Perfect!

Lets wait one day for other reviewers to look if they want. And we will 
push it tomorrow.

Thanks,
Vladimir

On 4/9/13 4:01 PM, David Chase wrote:
>
> On 2013-04-09, at 5:26 PM, Vladimir Kozlov  wrote:
>> One note: in frame_sparc.cpp remove 'jvmg' in the line you modified since we will not build jvmg.
>
> done
>
>> And question: did you use mercurial commands to remove and rename jvm.make and debug.make? We need to use hg commands to preserve changes history for jvmg.make (it has more changesets then old debug.make).
>>
>> I just want to confirm because sometimes webrev may not show correctly what was done to sources. I mean you need to do:
>>
>> hg remove debug.make
>> hg rename jvmg.make debug.make
>>
>> and then edit debug.make
>
> To be sure:
>
> 10009  hg revert make/{solaris,bsd,linux}/makefiles/jvmg.make
> 10010  zip -9 ../safemakes.zip make/{solaris,bsd,linux}/makefiles/debug.make
> 10011  hg revert make/{solaris,bsd,linux}/makefiles/debug.make
> 10012  hg remove make/{solaris,bsd,linux}/makefiles/debug.make
> 10013  for i in solaris bsd linux ; do hg rename make/$i/makefiles/{jvmg,debug}.make; done
> 10014  unzip -l ../safemakes.zip
> 10015  unzip ../safemakes.zip
>
> And the new-and-improved diffs:
>
> http://cr.openjdk.java.net/~drchase/7104565/webrev.06-new/
>
>

From david.holmes at oracle.com  Tue Apr  9 19:33:56 2013
From: david.holmes at oracle.com (David Holmes)
Date: Wed, 10 Apr 2013 12:33:56 +1000
Subject: RFR(M) : 7104565 : trim jprt build targets
In-Reply-To: <293891EC-45D0-4549-BD66-3605C6E757EC@oracle.com>
References: <7C7CBBE7-2651-4F94-820A-C68378C46AA9@oracle.com>
	<515D27BD.7010006@oracle.com>
	
	<516059C8.3020008@oracle.com>
	
	<51648769.7000809@oracle.com>
	<293891EC-45D0-4549-BD66-3605C6E757EC@oracle.com>
Message-ID: <5164CF94.4000005@oracle.com>

Hi David,

A few comments/concerns:

jprt.properties:

So the JPRT GC "_default" tests were redundant? Don't they test that 
ergonomics based selection works okay versus forced GC selection?

---

makefile related:

The bug says that the debug targets are unused but a fix for that is not 
what has been implemented. Please update the CR to reflect that debug 
lives and jvmg/profiled are what are now gone.

Why is there no jvmgminimal1_warn target?

---

As discussed in the CR I have concerns about replacing all ifdef 
DEBUG/FASTDEBUG with ASSERT as they do not mean the same thing. In 
particular:

I don't agree with the removal of the FASTDEBUG define as used here:

./os/solaris/dtrace/generateJvmOffsets.cpp:#if defined(DEBUG) || 
defined(FASTDEBUG)
./os/solaris/dtrace/generateJvmOffsets.cpp:#endif /* defined(DEBUG) || 
defined(FASTDEBUG) */
./os/bsd/dtrace/generateJvmOffsets.cpp:#if defined(DEBUG) || 
defined(FASTDEBUG)
./os/bsd/dtrace/generateJvmOffsets.cpp:#endif /* defined(DEBUG) || 
defined(FASTDEBUG) */

the code this guards couldn't care less about ASSERT, it cares about a 
symbol issue that is related to doing debug/fastdebug builds. (I wonder 
if this is still an issue though - what different build settings do we 
use for a debug build ??)

Ditto for src/share/vm/classfile/stackMapFrame.hpp - that code is not 
assert related but debugging related. Further you have now added that 
code to fastdebug builds - which seems wrong (or at least potentially 
impacts the "fast" part!). Also as Vladimir has indicated in the bug 
report this code would now be getting tested for the first time! - so 
potential bug tail there.

The changes in src/share/vm/shark/llvmHeaders.hpp need to be confirmed 
by the shark folk (if they haven't already). (And of course depend on 
-DDEBUG being eradicated.)

Thanks,
David
-----


On 10/04/2013 9:01 AM, David Chase wrote:
>
> On 2013-04-09, at 5:26 PM, Vladimir Kozlov  wrote:
>> One note: in frame_sparc.cpp remove 'jvmg' in the line you modified since we will not build jvmg.
>
> done
>
>> And question: did you use mercurial commands to remove and rename jvm.make and debug.make? We need to use hg commands to preserve changes history for jvmg.make (it has more changesets then old debug.make).
>>
>> I just want to confirm because sometimes webrev may not show correctly what was done to sources. I mean you need to do:
>>
>> hg remove debug.make
>> hg rename jvmg.make debug.make
>>
>> and then edit debug.make
>
> To be sure:
>
> 10009  hg revert make/{solaris,bsd,linux}/makefiles/jvmg.make
> 10010  zip -9 ../safemakes.zip make/{solaris,bsd,linux}/makefiles/debug.make
> 10011  hg revert make/{solaris,bsd,linux}/makefiles/debug.make
> 10012  hg remove make/{solaris,bsd,linux}/makefiles/debug.make
> 10013  for i in solaris bsd linux ; do hg rename make/$i/makefiles/{jvmg,debug}.make; done
> 10014  unzip -l ../safemakes.zip
> 10015  unzip ../safemakes.zip
>
> And the new-and-improved diffs:
>
> http://cr.openjdk.java.net/~drchase/7104565/webrev.06-new/
>
>

From david.r.chase at oracle.com  Tue Apr  9 20:05:13 2013
From: david.r.chase at oracle.com (David Chase)
Date: Tue, 9 Apr 2013 23:05:13 -0400
Subject: RFR(M) : 7104565 : trim jprt build targets
In-Reply-To: <5164CF94.4000005@oracle.com>
References: <7C7CBBE7-2651-4F94-820A-C68378C46AA9@oracle.com>
	<515D27BD.7010006@oracle.com>
	
	<516059C8.3020008@oracle.com>
	
	<51648769.7000809@oracle.com>
	<293891EC-45D0-4549-BD66-3605C6E757EC@oracle.com>
	<5164CF94.4000005@oracle.com>
Message-ID: <209BC5C3-D6ED-4F19-A22B-597746D69F05@oracle.com>

David,

The "why" on some of this is that I was starting with an existing mostly-done-but-aged changeset, so I don't always know why, and there could be mistakes.  I'm perfectly happy to put those tests back in (and I will unless someone else objects).

jvmgminimal1_warn needs to go in, I'd call that an oversight.

And as I understand the plan of this patch, the DEBUG and FASTDEBUG definitions are gone; however ASSERT is defined in either case, and I think only in those cases:

find . -name * -exec egrep -e DASSERT /dev/null {} ;
./bsd/makefiles/adlc.make:CXXFLAGS += -DASSERT
./bsd/makefiles/debug.make:SYSDEFS += -DASSERT
./bsd/makefiles/fastdebug.make:SYSDEFS += -DASSERT
./linux/makefiles/adlc.make:CXXFLAGS += -DASSERT
./linux/makefiles/debug.make:SYSDEFS += -DASSERT
./linux/makefiles/fastdebug.make:SYSDEFS += -DASSERT
./solaris/makefiles/adlc.make:CXXFLAGS += -DASSERT
./solaris/makefiles/debug.make:SYSDEFS += -DASSERT
./solaris/makefiles/fastdebug.make:SYSDEFS += -DASSERT -DCHECK_UNHANDLED_OOPS

One of these things is not like the other, how about that?
Should -DCHECK_UNHANDLED_OOPS be removed from solaris.fastdebug, or added to the others (or is Solaris.fastdebug somehow special)?

I don't have much of an opinion on generateJvmOffsets.cpp and stackMapFrame.hpp -- I don't know enough of the history, I don't know how important fastdebug performance is for those two files, and I'm perfectly willing to defer to someone else's judgment here, but I don't see a conclusion yet.  I do see that adding in DEBUG-sensitivity would tweak the makefiles a little again, but that seems like a minor issue compared to the wins of sanitizing both jprt and jvmg-vs--debug and cleaning out old profiled builds.  Do you and Vladimir settle this with rock-paper-scissors, or can we get someone else to weigh in?

On 2013-04-09, at 10:33 PM, David Holmes  wrote:

> Hi David,
> 
> A few comments/concerns:
> 
> jprt.properties:
> 
> So the JPRT GC "_default" tests were redundant? Don't they test that ergonomics based selection works okay versus forced GC selection?
> 
> ---
> 
> makefile related:
> 
> The bug says that the debug targets are unused but a fix for that is not what has been implemented. Please update the CR to reflect that debug lives and jvmg/profiled are what are now gone.
> 
> Why is there no jvmgminimal1_warn target?
> 
> ---
> 
> As discussed in the CR I have concerns about replacing all ifdef DEBUG/FASTDEBUG with ASSERT as they do not mean the same thing. In particular:
> 
> I don't agree with the removal of the FASTDEBUG define as used here:
> 
> ./os/solaris/dtrace/generateJvmOffsets.cpp:#if defined(DEBUG) || defined(FASTDEBUG)
> ./os/solaris/dtrace/generateJvmOffsets.cpp:#endif /* defined(DEBUG) || defined(FASTDEBUG) */
> ./os/bsd/dtrace/generateJvmOffsets.cpp:#if defined(DEBUG) || defined(FASTDEBUG)
> ./os/bsd/dtrace/generateJvmOffsets.cpp:#endif /* defined(DEBUG) || defined(FASTDEBUG) */
> 
> the code this guards couldn't care less about ASSERT, it cares about a symbol issue that is related to doing debug/fastdebug builds. (I wonder if this is still an issue though - what different build settings do we use for a debug build ??)
> 
> Ditto for src/share/vm/classfile/stackMapFrame.hpp - that code is not assert related but debugging related. Further you have now added that code to fastdebug builds - which seems wrong (or at least potentially impacts the "fast" part!). Also as Vladimir has indicated in the bug report this code would now be getting tested for the first time! - so potential bug tail there.
> 
> The changes in src/share/vm/shark/llvmHeaders.hpp need to be confirmed by the shark folk (if they haven't already). (And of course depend on -DDEBUG being eradicated.)
> 
> Thanks,
> David
> -----
> 
> 
> On 10/04/2013 9:01 AM, David Chase wrote:
>> 
>> On 2013-04-09, at 5:26 PM, Vladimir Kozlov  wrote:
>>> One note: in frame_sparc.cpp remove 'jvmg' in the line you modified since we will not build jvmg.
>> 
>> done
>> 
>>> And question: did you use mercurial commands to remove and rename jvm.make and debug.make? We need to use hg commands to preserve changes history for jvmg.make (it has more changesets then old debug.make).
>>> 
>>> I just want to confirm because sometimes webrev may not show correctly what was done to sources. I mean you need to do:
>>> 
>>> hg remove debug.make
>>> hg rename jvmg.make debug.make
>>> 
>>> and then edit debug.make
>> 
>> To be sure:
>> 
>> 10009  hg revert make/{solaris,bsd,linux}/makefiles/jvmg.make
>> 10010  zip -9 ../safemakes.zip make/{solaris,bsd,linux}/makefiles/debug.make
>> 10011  hg revert make/{solaris,bsd,linux}/makefiles/debug.make
>> 10012  hg remove make/{solaris,bsd,linux}/makefiles/debug.make
>> 10013  for i in solaris bsd linux ; do hg rename make/$i/makefiles/{jvmg,debug}.make; done
>> 10014  unzip -l ../safemakes.zip
>> 10015  unzip ../safemakes.zip
>> 
>> And the new-and-improved diffs:
>> 
>> http://cr.openjdk.java.net/~drchase/7104565/webrev.06-new/
>> 
>> 


From vladimir.kozlov at oracle.com  Tue Apr  9 20:09:12 2013
From: vladimir.kozlov at oracle.com (Vladimir Kozlov)
Date: Tue, 09 Apr 2013 20:09:12 -0700
Subject: RFR(M) : 7104565 : trim jprt build targets
In-Reply-To: <5164CF94.4000005@oracle.com>
References: <7C7CBBE7-2651-4F94-820A-C68378C46AA9@oracle.com>
	<515D27BD.7010006@oracle.com>
	
	<516059C8.3020008@oracle.com>
	
	<51648769.7000809@oracle.com>
	<293891EC-45D0-4549-BD66-3605C6E757EC@oracle.com>
	<5164CF94.4000005@oracle.com>
Message-ID: <5164D7D8.5080206@oracle.com>

On 4/9/13 7:33 PM, David Holmes wrote:
> Hi David,
>
> A few comments/concerns:
>
> jprt.properties:
>
> So the JPRT GC "_default" tests were redundant? Don't they test that
> ergonomics based selection works okay versus forced GC selection?

It is redundant because forced selection use all gc collectors.

>
> makefile related:
>
> The bug says that the debug targets are unused but a fix for that is not
> what has been implemented. Please update the CR to reflect that debug
> lives and jvmg/profiled are what are now gone.
>
> Why is there no jvmgminimal1_warn target?
>
> ---
>
> As discussed in the CR I have concerns about replacing all ifdef
> DEBUG/FASTDEBUG with ASSERT as they do not mean the same thing. In
> particular:
>
> I don't agree with the removal of the FASTDEBUG define as used here:
>
> ./os/solaris/dtrace/generateJvmOffsets.cpp:#if defined(DEBUG) ||
> defined(FASTDEBUG)
> ./os/solaris/dtrace/generateJvmOffsets.cpp:#endif /* defined(DEBUG) ||
> defined(FASTDEBUG) */
> ./os/bsd/dtrace/generateJvmOffsets.cpp:#if defined(DEBUG) ||
> defined(FASTDEBUG)
> ./os/bsd/dtrace/generateJvmOffsets.cpp:#endif /* defined(DEBUG) ||
> defined(FASTDEBUG) */
>
> the code this guards couldn't care less about ASSERT, it cares about a
> symbol issue that is related to doing debug/fastdebug builds. (I wonder
> if this is still an issue though - what different build settings do we
> use for a debug build ??)

For both debug/fastdebug builds ASSERT is set. So this replacement is 
correct.

Yes, using ASSERT here could be confusing and we could add new 
-DAVOID_C1_DEBUG_LINK_ERROR but we have the comment which explains the 
problem and we know that ASSERT is set in such case.

I agree that we need to investigate this case and fix the problem 
instead of using this workaround.

>
> Ditto for src/share/vm/classfile/stackMapFrame.hpp - that code is not
> assert related but debugging related. Further you have now added that

It is assert related! VM will assert (I hope) somewhere where we check 
values in wrong place on stack or VM dies (SEGV) which is also good 
since it is incorrect to use invalid values.

> code to fastdebug builds - which seems wrong (or at least potentially
> impacts the "fast" part!). Also as Vladimir has indicated in the bug
> report this code would now be getting tested for the first time! - so
> potential bug tail there.

I don't understand this argument. It would be good if it helps to find 
problems here. Why do you want to hide problems?

>
> The changes in src/share/vm/shark/llvmHeaders.hpp need to be confirmed
> by the shark folk (if they haven't already). (And of course depend on
> -DDEBUG being eradicated.)

Oracle is not supporting shark! They are on this mailing alias. We 
discussing this for long time already. We hear nothing from them. If 
they find problems later they will send a patch and we use it.

Thanks,
Vladimir

>
> Thanks,
> David
> -----
>
>
> On 10/04/2013 9:01 AM, David Chase wrote:
>>
>> On 2013-04-09, at 5:26 PM, Vladimir Kozlov
>>  wrote:
>>> One note: in frame_sparc.cpp remove 'jvmg' in the line you modified
>>> since we will not build jvmg.
>>
>> done
>>
>>> And question: did you use mercurial commands to remove and rename
>>> jvm.make and debug.make? We need to use hg commands to preserve
>>> changes history for jvmg.make (it has more changesets then old
>>> debug.make).
>>>
>>> I just want to confirm because sometimes webrev may not show
>>> correctly what was done to sources. I mean you need to do:
>>>
>>> hg remove debug.make
>>> hg rename jvmg.make debug.make
>>>
>>> and then edit debug.make
>>
>> To be sure:
>>
>> 10009  hg revert make/{solaris,bsd,linux}/makefiles/jvmg.make
>> 10010  zip -9 ../safemakes.zip
>> make/{solaris,bsd,linux}/makefiles/debug.make
>> 10011  hg revert make/{solaris,bsd,linux}/makefiles/debug.make
>> 10012  hg remove make/{solaris,bsd,linux}/makefiles/debug.make
>> 10013  for i in solaris bsd linux ; do hg rename
>> make/$i/makefiles/{jvmg,debug}.make; done
>> 10014  unzip -l ../safemakes.zip
>> 10015  unzip ../safemakes.zip
>>
>> And the new-and-improved diffs:
>>
>> http://cr.openjdk.java.net/~drchase/7104565/webrev.06-new/
>>
>>

From david.holmes at oracle.com  Tue Apr  9 20:46:55 2013
From: david.holmes at oracle.com (David Holmes)
Date: Wed, 10 Apr 2013 13:46:55 +1000
Subject: RFR(M) : 7104565 : trim jprt build targets
In-Reply-To: <209BC5C3-D6ED-4F19-A22B-597746D69F05@oracle.com>
References: <7C7CBBE7-2651-4F94-820A-C68378C46AA9@oracle.com>
	<515D27BD.7010006@oracle.com>
	
	<516059C8.3020008@oracle.com>
	
	<51648769.7000809@oracle.com>
	<293891EC-45D0-4549-BD66-3605C6E757EC@oracle.com>
	<5164CF94.4000005@oracle.com>
	<209BC5C3-D6ED-4F19-A22B-597746D69F05@oracle.com>
Message-ID: <5164E0AF.7040503@oracle.com>

On 10/04/2013 1:05 PM, David Chase wrote:
> David,
>
> The "why" on some of this is that I was starting with an existing mostly-done-but-aged changeset, so I don't always know why, and there could be mistakes.  I'm perfectly happy to put those tests back in (and I will unless someone else objects).

Understood.

> jvmgminimal1_warn needs to go in, I'd call that an oversight.

That's fine.

> And as I understand the plan of this patch, the DEBUG and FASTDEBUG definitions are gone; however ASSERT is defined in either case, and I think only in those cases:
>
> find . -name * -exec egrep -e DASSERT /dev/null {} ;
> ./bsd/makefiles/adlc.make:CXXFLAGS += -DASSERT
> ./bsd/makefiles/debug.make:SYSDEFS += -DASSERT
> ./bsd/makefiles/fastdebug.make:SYSDEFS += -DASSERT
> ./linux/makefiles/adlc.make:CXXFLAGS += -DASSERT
> ./linux/makefiles/debug.make:SYSDEFS += -DASSERT
> ./linux/makefiles/fastdebug.make:SYSDEFS += -DASSERT
> ./solaris/makefiles/adlc.make:CXXFLAGS += -DASSERT
> ./solaris/makefiles/debug.make:SYSDEFS += -DASSERT
> ./solaris/makefiles/fastdebug.make:SYSDEFS += -DASSERT -DCHECK_UNHANDLED_OOPS
>
> One of these things is not like the other, how about that?
> Should -DCHECK_UNHANDLED_OOPS be removed from solaris.fastdebug, or added to the others (or is Solaris.fastdebug somehow special)?

CHECK_UNHANDLED_OOPS is only implemented on Solaris.

> I don't have much of an opinion on generateJvmOffsets.cpp and stackMapFrame.hpp -- I don't know enough of the history, I don't know how important fastdebug performance is for those two files, and I'm perfectly willing to defer to someone else's judgment here, but I don't see a conclusion yet.  I do see that adding in DEBUG-sensitivity would tweak the makefiles a little again, but that seems like a minor issue compared to the wins of sanitizing both jprt and jvmg-vs--debug and cleaning out old profiled builds.  Do you and Vladimir settle this with rock-paper-scissors, or can we get someone else to weigh in?

It would be nice if other opinions were expressed.

Cheers,
David
-----

> On 2013-04-09, at 10:33 PM, David Holmes  wrote:
>
>> Hi David,
>>
>> A few comments/concerns:
>>
>> jprt.properties:
>>
>> So the JPRT GC "_default" tests were redundant? Don't they test that ergonomics based selection works okay versus forced GC selection?
>>
>> ---
>>
>> makefile related:
>>
>> The bug says that the debug targets are unused but a fix for that is not what has been implemented. Please update the CR to reflect that debug lives and jvmg/profiled are what are now gone.
>>
>> Why is there no jvmgminimal1_warn target?
>>
>> ---
>>
>> As discussed in the CR I have concerns about replacing all ifdef DEBUG/FASTDEBUG with ASSERT as they do not mean the same thing. In particular:
>>
>> I don't agree with the removal of the FASTDEBUG define as used here:
>>
>> ./os/solaris/dtrace/generateJvmOffsets.cpp:#if defined(DEBUG) || defined(FASTDEBUG)
>> ./os/solaris/dtrace/generateJvmOffsets.cpp:#endif /* defined(DEBUG) || defined(FASTDEBUG) */
>> ./os/bsd/dtrace/generateJvmOffsets.cpp:#if defined(DEBUG) || defined(FASTDEBUG)
>> ./os/bsd/dtrace/generateJvmOffsets.cpp:#endif /* defined(DEBUG) || defined(FASTDEBUG) */
>>
>> the code this guards couldn't care less about ASSERT, it cares about a symbol issue that is related to doing debug/fastdebug builds. (I wonder if this is still an issue though - what different build settings do we use for a debug build ??)
>>
>> Ditto for src/share/vm/classfile/stackMapFrame.hpp - that code is not assert related but debugging related. Further you have now added that code to fastdebug builds - which seems wrong (or at least potentially impacts the "fast" part!). Also as Vladimir has indicated in the bug report this code would now be getting tested for the first time! - so potential bug tail there.
>>
>> The changes in src/share/vm/shark/llvmHeaders.hpp need to be confirmed by the shark folk (if they haven't already). (And of course depend on -DDEBUG being eradicated.)
>>
>> Thanks,
>> David
>> -----
>>
>>
>> On 10/04/2013 9:01 AM, David Chase wrote:
>>>
>>> On 2013-04-09, at 5:26 PM, Vladimir Kozlov  wrote:
>>>> One note: in frame_sparc.cpp remove 'jvmg' in the line you modified since we will not build jvmg.
>>>
>>> done
>>>
>>>> And question: did you use mercurial commands to remove and rename jvm.make and debug.make? We need to use hg commands to preserve changes history for jvmg.make (it has more changesets then old debug.make).
>>>>
>>>> I just want to confirm because sometimes webrev may not show correctly what was done to sources. I mean you need to do:
>>>>
>>>> hg remove debug.make
>>>> hg rename jvmg.make debug.make
>>>>
>>>> and then edit debug.make
>>>
>>> To be sure:
>>>
>>> 10009  hg revert make/{solaris,bsd,linux}/makefiles/jvmg.make
>>> 10010  zip -9 ../safemakes.zip make/{solaris,bsd,linux}/makefiles/debug.make
>>> 10011  hg revert make/{solaris,bsd,linux}/makefiles/debug.make
>>> 10012  hg remove make/{solaris,bsd,linux}/makefiles/debug.make
>>> 10013  for i in solaris bsd linux ; do hg rename make/$i/makefiles/{jvmg,debug}.make; done
>>> 10014  unzip -l ../safemakes.zip
>>> 10015  unzip ../safemakes.zip
>>>
>>> And the new-and-improved diffs:
>>>
>>> http://cr.openjdk.java.net/~drchase/7104565/webrev.06-new/
>>>
>>>
>

From david.holmes at oracle.com  Tue Apr  9 21:09:44 2013
From: david.holmes at oracle.com (David Holmes)
Date: Wed, 10 Apr 2013 14:09:44 +1000
Subject: RFR(M) : 7104565 : trim jprt build targets
In-Reply-To: <5164D7D8.5080206@oracle.com>
References: <7C7CBBE7-2651-4F94-820A-C68378C46AA9@oracle.com>
	<515D27BD.7010006@oracle.com>
	
	<516059C8.3020008@oracle.com>
	
	<51648769.7000809@oracle.com>
	<293891EC-45D0-4549-BD66-3605C6E757EC@oracle.com>
	<5164CF94.4000005@oracle.com> <5164D7D8.5080206@oracle.com>
Message-ID: <5164E608.8020003@oracle.com>

On 10/04/2013 1:09 PM, Vladimir Kozlov wrote:
> On 4/9/13 7:33 PM, David Holmes wrote:
>> A few comments/concerns:
>>
>> jprt.properties:
>>
>> So the JPRT GC "_default" tests were redundant? Don't they test that
>> ergonomics based selection works okay versus forced GC selection?
>
> It is redundant because forced selection use all gc collectors.

Ok.

>>
>> makefile related:
>>
>> The bug says that the debug targets are unused but a fix for that is not
>> what has been implemented. Please update the CR to reflect that debug
>> lives and jvmg/profiled are what are now gone.
>>
>> Why is there no jvmgminimal1_warn target?
>>
>> ---
>>
>> As discussed in the CR I have concerns about replacing all ifdef
>> DEBUG/FASTDEBUG with ASSERT as they do not mean the same thing. In
>> particular:
>>
>> I don't agree with the removal of the FASTDEBUG define as used here:
>>
>> ./os/solaris/dtrace/generateJvmOffsets.cpp:#if defined(DEBUG) ||
>> defined(FASTDEBUG)
>> ./os/solaris/dtrace/generateJvmOffsets.cpp:#endif /* defined(DEBUG) ||
>> defined(FASTDEBUG) */
>> ./os/bsd/dtrace/generateJvmOffsets.cpp:#if defined(DEBUG) ||
>> defined(FASTDEBUG)
>> ./os/bsd/dtrace/generateJvmOffsets.cpp:#endif /* defined(DEBUG) ||
>> defined(FASTDEBUG) */
>>
>> the code this guards couldn't care less about ASSERT, it cares about a
>> symbol issue that is related to doing debug/fastdebug builds. (I wonder
>> if this is still an issue though - what different build settings do we
>> use for a debug build ??)
>
> For both debug/fastdebug builds ASSERT is set. So this replacement is
> correct.

It is equivalent based on the present setting of flags, but code added 
for debugging purposes and code added for assertions are quite distinct 
things. I think many people will be surprised to find that we have:

#ifdef ASSERT
#define DEBUG_ONLY(code) code
#define NOT_DEBUG(code)

and not

#if defined(DEBUG) || defined(FASTDEBUG)
#define DEBUG_ONLY(code) code
#define NOT_DEBUG(code)


> Yes, using ASSERT here could be confusing and we could add new
> -DAVOID_C1_DEBUG_LINK_ERROR but we have the comment which explains the
> problem and we know that ASSERT is set in such case.
>
> I agree that we need to investigate this case and fix the problem
> instead of using this workaround.
>
>>
>> Ditto for src/share/vm/classfile/stackMapFrame.hpp - that code is not
>> assert related but debugging related. Further you have now added that
>
> It is assert related! VM will assert (I hope) somewhere where we check
> values in wrong place on stack or VM dies (SEGV) which is also good
> since it is incorrect to use invalid values.

Even if ultimately this code relies on assertions to flag errors it is 
still fundamentally additional debugging code. It is an extra level of 
checking/verification that we did not want to do for either product 
builds or fastdebug builds. But now it is in fastdebug. Is that a 
problem? can't say for sure as I don't do anything that relies on 
fastdebug being fast. If no one cares then maybe we can kill fastdebug 
too? Afterall it already has all that DEBUG_ONLY code in it so not as 
fast as one might assume.

>> code to fastdebug builds - which seems wrong (or at least potentially
>> impacts the "fast" part!). Also as Vladimir has indicated in the bug
>> report this code would now be getting tested for the first time! - so
>> potential bug tail there.
>
> I don't understand this argument. It would be good if it helps to find
> problems here. Why do you want to hide problems?

This last part wasn't an argument (sorry if it wasn't clear) just an 
observation. It wouldn't be obvious to the readers that this changeset 
will result in previously untested code now being tested. (Heads up to 
gatekeepers!)

>> The changes in src/share/vm/shark/llvmHeaders.hpp need to be confirmed
>> by the shark folk (if they haven't already). (And of course depend on
>> -DDEBUG being eradicated.)
>
> Oracle is not supporting shark! They are on this mailing alias. We
> discussing this for long time already. We hear nothing from them. If
> they find problems later they will send a patch and we use it.

As long as this shouldn't break their build (which it shouldn't). But 
based on that view you could have simply left this untouched.

Thanks,
David

> Thanks,
> Vladimir
>
>>
>> Thanks,
>> David
>> -----
>>
>>
>> On 10/04/2013 9:01 AM, David Chase wrote:
>>>
>>> On 2013-04-09, at 5:26 PM, Vladimir Kozlov
>>>  wrote:
>>>> One note: in frame_sparc.cpp remove 'jvmg' in the line you modified
>>>> since we will not build jvmg.
>>>
>>> done
>>>
>>>> And question: did you use mercurial commands to remove and rename
>>>> jvm.make and debug.make? We need to use hg commands to preserve
>>>> changes history for jvmg.make (it has more changesets then old
>>>> debug.make).
>>>>
>>>> I just want to confirm because sometimes webrev may not show
>>>> correctly what was done to sources. I mean you need to do:
>>>>
>>>> hg remove debug.make
>>>> hg rename jvmg.make debug.make
>>>>
>>>> and then edit debug.make
>>>
>>> To be sure:
>>>
>>> 10009  hg revert make/{solaris,bsd,linux}/makefiles/jvmg.make
>>> 10010  zip -9 ../safemakes.zip
>>> make/{solaris,bsd,linux}/makefiles/debug.make
>>> 10011  hg revert make/{solaris,bsd,linux}/makefiles/debug.make
>>> 10012  hg remove make/{solaris,bsd,linux}/makefiles/debug.make
>>> 10013  for i in solaris bsd linux ; do hg rename
>>> make/$i/makefiles/{jvmg,debug}.make; done
>>> 10014  unzip -l ../safemakes.zip
>>> 10015  unzip ../safemakes.zip
>>>
>>> And the new-and-improved diffs:
>>>
>>> http://cr.openjdk.java.net/~drchase/7104565/webrev.06-new/
>>>
>>>

From david.holmes at oracle.com  Tue Apr  9 21:25:21 2013
From: david.holmes at oracle.com (David Holmes)
Date: Wed, 10 Apr 2013 14:25:21 +1000
Subject: RFR(M) : 7104565 : trim jprt build targets
In-Reply-To: <5164E608.8020003@oracle.com>
References: <7C7CBBE7-2651-4F94-820A-C68378C46AA9@oracle.com>
	<515D27BD.7010006@oracle.com>
	
	<516059C8.3020008@oracle.com>
	
	<51648769.7000809@oracle.com>
	<293891EC-45D0-4549-BD66-3605C6E757EC@oracle.com>
	<5164CF94.4000005@oracle.com> <5164D7D8.5080206@oracle.com>
	<5164E608.8020003@oracle.com>
Message-ID: <5164E9B1.5000600@oracle.com>

On 10/04/2013 2:09 PM, David Holmes wrote:
> On 10/04/2013 1:09 PM, Vladimir Kozlov wrote:
>> On 4/9/13 7:33 PM, David Holmes wrote:
>>> A few comments/concerns:
>>>
>>> jprt.properties:
>>>
>>> So the JPRT GC "_default" tests were redundant? Don't they test that
>>> ergonomics based selection works okay versus forced GC selection?
>>
>> It is redundant because forced selection use all gc collectors.
>
> Ok.
>
>>>
>>> makefile related:
>>>
>>> The bug says that the debug targets are unused but a fix for that is not
>>> what has been implemented. Please update the CR to reflect that debug
>>> lives and jvmg/profiled are what are now gone.
>>>
>>> Why is there no jvmgminimal1_warn target?
>>>
>>> ---
>>>
>>> As discussed in the CR I have concerns about replacing all ifdef
>>> DEBUG/FASTDEBUG with ASSERT as they do not mean the same thing. In
>>> particular:
>>>
>>> I don't agree with the removal of the FASTDEBUG define as used here:
>>>
>>> ./os/solaris/dtrace/generateJvmOffsets.cpp:#if defined(DEBUG) ||
>>> defined(FASTDEBUG)
>>> ./os/solaris/dtrace/generateJvmOffsets.cpp:#endif /* defined(DEBUG) ||
>>> defined(FASTDEBUG) */
>>> ./os/bsd/dtrace/generateJvmOffsets.cpp:#if defined(DEBUG) ||
>>> defined(FASTDEBUG)
>>> ./os/bsd/dtrace/generateJvmOffsets.cpp:#endif /* defined(DEBUG) ||
>>> defined(FASTDEBUG) */
>>>
>>> the code this guards couldn't care less about ASSERT, it cares about a
>>> symbol issue that is related to doing debug/fastdebug builds. (I wonder
>>> if this is still an issue though - what different build settings do we
>>> use for a debug build ??)
>>
>> For both debug/fastdebug builds ASSERT is set. So this replacement is
>> correct.
>
> It is equivalent based on the present setting of flags, but code added
> for debugging purposes and code added for assertions are quite distinct
> things. I think many people will be surprised to find that we have:
>
> #ifdef ASSERT
> #define DEBUG_ONLY(code) code
> #define NOT_DEBUG(code)
>
> and not
>
> #if defined(DEBUG) || defined(FASTDEBUG)
> #define DEBUG_ONLY(code) code
> #define NOT_DEBUG(code)
>
>
>> Yes, using ASSERT here could be confusing and we could add new
>> -DAVOID_C1_DEBUG_LINK_ERROR but we have the comment which explains the
>> problem and we know that ASSERT is set in such case.
>>
>> I agree that we need to investigate this case and fix the problem
>> instead of using this workaround.
>>
>>>
>>> Ditto for src/share/vm/classfile/stackMapFrame.hpp - that code is not
>>> assert related but debugging related. Further you have now added that
>>
>> It is assert related! VM will assert (I hope) somewhere where we check
>> values in wrong place on stack or VM dies (SEGV) which is also good
>> since it is incorrect to use invalid values.
>
> Even if ultimately this code relies on assertions to flag errors it is
> still fundamentally additional debugging code. It is an extra level of
> checking/verification that we did not want to do for either product
> builds or fastdebug builds. But now it is in fastdebug. Is that a
> problem? can't say for sure as I don't do anything that relies on
> fastdebug being fast. If no one cares then maybe we can kill fastdebug
> too? Afterall it already has all that DEBUG_ONLY code in it so not as
> fast as one might assume.

Which only makes sense if above I had said:

#if defined(DEBUG)
#define DEBUG_ONLY(code) code
#define NOT_DEBUG(code)

rather than

#if defined(DEBUG) || defined(FASTDEBUG)
#define DEBUG_ONLY(code) code
#define NOT_DEBUG(code)

David
-----

>>> code to fastdebug builds - which seems wrong (or at least potentially
>>> impacts the "fast" part!). Also as Vladimir has indicated in the bug
>>> report this code would now be getting tested for the first time! - so
>>> potential bug tail there.
>>
>> I don't understand this argument. It would be good if it helps to find
>> problems here. Why do you want to hide problems?
>
> This last part wasn't an argument (sorry if it wasn't clear) just an
> observation. It wouldn't be obvious to the readers that this changeset
> will result in previously untested code now being tested. (Heads up to
> gatekeepers!)
>
>>> The changes in src/share/vm/shark/llvmHeaders.hpp need to be confirmed
>>> by the shark folk (if they haven't already). (And of course depend on
>>> -DDEBUG being eradicated.)
>>
>> Oracle is not supporting shark! They are on this mailing alias. We
>> discussing this for long time already. We hear nothing from them. If
>> they find problems later they will send a patch and we use it.
>
> As long as this shouldn't break their build (which it shouldn't). But
> based on that view you could have simply left this untouched.
>
> Thanks,
> David
>
>> Thanks,
>> Vladimir
>>
>>>
>>> Thanks,
>>> David
>>> -----
>>>
>>>
>>> On 10/04/2013 9:01 AM, David Chase wrote:
>>>>
>>>> On 2013-04-09, at 5:26 PM, Vladimir Kozlov
>>>>  wrote:
>>>>> One note: in frame_sparc.cpp remove 'jvmg' in the line you modified
>>>>> since we will not build jvmg.
>>>>
>>>> done
>>>>
>>>>> And question: did you use mercurial commands to remove and rename
>>>>> jvm.make and debug.make? We need to use hg commands to preserve
>>>>> changes history for jvmg.make (it has more changesets then old
>>>>> debug.make).
>>>>>
>>>>> I just want to confirm because sometimes webrev may not show
>>>>> correctly what was done to sources. I mean you need to do:
>>>>>
>>>>> hg remove debug.make
>>>>> hg rename jvmg.make debug.make
>>>>>
>>>>> and then edit debug.make
>>>>
>>>> To be sure:
>>>>
>>>> 10009  hg revert make/{solaris,bsd,linux}/makefiles/jvmg.make
>>>> 10010  zip -9 ../safemakes.zip
>>>> make/{solaris,bsd,linux}/makefiles/debug.make
>>>> 10011  hg revert make/{solaris,bsd,linux}/makefiles/debug.make
>>>> 10012  hg remove make/{solaris,bsd,linux}/makefiles/debug.make
>>>> 10013  for i in solaris bsd linux ; do hg rename
>>>> make/$i/makefiles/{jvmg,debug}.make; done
>>>> 10014  unzip -l ../safemakes.zip
>>>> 10015  unzip ../safemakes.zip
>>>>
>>>> And the new-and-improved diffs:
>>>>
>>>> http://cr.openjdk.java.net/~drchase/7104565/webrev.06-new/
>>>>
>>>>

From vladimir.kozlov at oracle.com  Tue Apr  9 21:41:49 2013
From: vladimir.kozlov at oracle.com (Vladimir Kozlov)
Date: Tue, 09 Apr 2013 21:41:49 -0700
Subject: RFR(M) : 7104565 : trim jprt build targets
In-Reply-To: <5164E608.8020003@oracle.com>
References: <7C7CBBE7-2651-4F94-820A-C68378C46AA9@oracle.com>
	<515D27BD.7010006@oracle.com>
	
	<516059C8.3020008@oracle.com>
	
	<51648769.7000809@oracle.com>
	<293891EC-45D0-4549-BD66-3605C6E757EC@oracle.com>
	<5164CF94.4000005@oracle.com> <5164D7D8.5080206@oracle.com>
	<5164E608.8020003@oracle.com>
Message-ID: <5164ED8D.8080107@oracle.com>

On 4/9/13 9:09 PM, David Holmes wrote:
> On 10/04/2013 1:09 PM, Vladimir Kozlov wrote:
>>
>> For both debug/fastdebug builds ASSERT is set. So this replacement is
>> correct.
>
> It is equivalent based on the present setting of flags, but code added
> for debugging purposes and code added for assertions are quite distinct
> things. I think many people will be surprised to find that we have:

I think everyone working on Hotspot already knows this and will not 
surprise. Yes, we use #ifdef ASSERT to produce debug outputs and for 
asserts.

>
> #ifdef ASSERT
> #define DEBUG_ONLY(code) code
> #define NOT_DEBUG(code)
>
> and not
>
> #if defined(DEBUG) || defined(FASTDEBUG)
> #define DEBUG_ONLY(code) code
> #define NOT_DEBUG(code)

Yes, we had very long discussion before about this and decided to keep 
it as it is. I would like to avoid such discussion again.

>>> Ditto for src/share/vm/classfile/stackMapFrame.hpp - that code is not
>>> assert related but debugging related. Further you have now added that
>>
>> It is assert related! VM will assert (I hope) somewhere where we check
>> values in wrong place on stack or VM dies (SEGV) which is also good
>> since it is incorrect to use invalid values.
>
> Even if ultimately this code relies on assertions to flag errors it is
> still fundamentally additional debugging code. It is an extra level of
> checking/verification that we did not want to do for either product
> builds or fastdebug builds. But now it is in fastdebug. Is that a
> problem? can't say for sure as I don't do anything that relies on
> fastdebug being fast. If no one cares then maybe we can kill fastdebug
> too? Afterall it already has all that DEBUG_ONLY code in it so not as
> fast as one might assume.

David, the only difference between debug and fastdebug VM builds should 
be optimization level. The fastdebug VM uses the same -O4 (or -O3) as 
product build which forces inlining and other optimization and helps 
with VM speed. Debug VM compiled without any optimizations and does not 
inline (we need this to be able debug). It is a lot slower then 
fastdebug VM and because of that can't be used for testing. There should 
be no other differences between debug and fastdebug VM.

All checks done in debug VM should be done in fastdebug VM, period!

>>> The changes in src/share/vm/shark/llvmHeaders.hpp need to be confirmed
>>> by the shark folk (if they haven't already). (And of course depend on
>>> -DDEBUG being eradicated.)
>>
>> Oracle is not supporting shark! They are on this mailing alias. We
>> discussing this for long time already. We hear nothing from them. If
>> they find problems later they will send a patch and we use it.
>
> As long as this shouldn't break their build (which it shouldn't). But
> based on that view you could have simply left this untouched.

It looks like that code tries to preserve our DEBUG across llvm include 
files. Yes, you are right - we can leave it.

David C., please, undo changes in llvmHeaders.hpp.

Thanks,
Vladimir

>
> Thanks,
> David
>
>> Thanks,
>> Vladimir
>>
>>>
>>> Thanks,
>>> David
>>> -----
>>>
>>>
>>> On 10/04/2013 9:01 AM, David Chase wrote:
>>>>
>>>> On 2013-04-09, at 5:26 PM, Vladimir Kozlov
>>>>  wrote:
>>>>> One note: in frame_sparc.cpp remove 'jvmg' in the line you modified
>>>>> since we will not build jvmg.
>>>>
>>>> done
>>>>
>>>>> And question: did you use mercurial commands to remove and rename
>>>>> jvm.make and debug.make? We need to use hg commands to preserve
>>>>> changes history for jvmg.make (it has more changesets then old
>>>>> debug.make).
>>>>>
>>>>> I just want to confirm because sometimes webrev may not show
>>>>> correctly what was done to sources. I mean you need to do:
>>>>>
>>>>> hg remove debug.make
>>>>> hg rename jvmg.make debug.make
>>>>>
>>>>> and then edit debug.make
>>>>
>>>> To be sure:
>>>>
>>>> 10009  hg revert make/{solaris,bsd,linux}/makefiles/jvmg.make
>>>> 10010  zip -9 ../safemakes.zip
>>>> make/{solaris,bsd,linux}/makefiles/debug.make
>>>> 10011  hg revert make/{solaris,bsd,linux}/makefiles/debug.make
>>>> 10012  hg remove make/{solaris,bsd,linux}/makefiles/debug.make
>>>> 10013  for i in solaris bsd linux ; do hg rename
>>>> make/$i/makefiles/{jvmg,debug}.make; done
>>>> 10014  unzip -l ../safemakes.zip
>>>> 10015  unzip ../safemakes.zip
>>>>
>>>> And the new-and-improved diffs:
>>>>
>>>> http://cr.openjdk.java.net/~drchase/7104565/webrev.06-new/
>>>>
>>>>

From david.holmes at oracle.com  Tue Apr  9 22:34:18 2013
From: david.holmes at oracle.com (David Holmes)
Date: Wed, 10 Apr 2013 15:34:18 +1000
Subject: RFR(M) : 7104565 : trim jprt build targets
In-Reply-To: <5164ED8D.8080107@oracle.com>
References: <7C7CBBE7-2651-4F94-820A-C68378C46AA9@oracle.com>
	<515D27BD.7010006@oracle.com>
	
	<516059C8.3020008@oracle.com>
	
	<51648769.7000809@oracle.com>
	<293891EC-45D0-4549-BD66-3605C6E757EC@oracle.com>
	<5164CF94.4000005@oracle.com> <5164D7D8.5080206@oracle.com>
	<5164E608.8020003@oracle.com> <5164ED8D.8080107@oracle.com>
Message-ID: <5164F9DA.1010506@oracle.com>

On 10/04/2013 2:41 PM, Vladimir Kozlov wrote:
> David, the only difference between debug and fastdebug VM builds should
> be optimization level.

Ok.

Looking at stackMapFrame.hpp the changeset that added the "ifdef DEBUG" was

http://hg.openjdk.java.net/hsx/hotspot-rt/hotspot/rev/4ee06e614636

and it seems to me that perhaps it should have been
"ifndef PRODUCT" based on the fact that it appears to be a refactoring 
of NOT_PRODUCT code. (The only difference being whether or not it is 
included in the optimized build.)

Thanks,
David



> The fastdebug VM uses the same -O4 (or -O3) as
> product build which forces inlining and other optimization and helps
> with VM speed. Debug VM compiled without any optimizations and does not
> inline (we need this to be able debug). It is a lot slower then
> fastdebug VM and because of that can't be used for testing. There should
> be no other differences between debug and fastdebug VM.
>
> All checks done in debug VM should be done in fastdebug VM, period!
>
>>>> The changes in src/share/vm/shark/llvmHeaders.hpp need to be confirmed
>>>> by the shark folk (if they haven't already). (And of course depend on
>>>> -DDEBUG being eradicated.)
>>>
>>> Oracle is not supporting shark! They are on this mailing alias. We
>>> discussing this for long time already. We hear nothing from them. If
>>> they find problems later they will send a patch and we use it.
>>
>> As long as this shouldn't break their build (which it shouldn't). But
>> based on that view you could have simply left this untouched.
>
> It looks like that code tries to preserve our DEBUG across llvm include
> files. Yes, you are right - we can leave it.
>
> David C., please, undo changes in llvmHeaders.hpp.
>
> Thanks,
> Vladimir
>
>>
>> Thanks,
>> David
>>
>>> Thanks,
>>> Vladimir
>>>
>>>>
>>>> Thanks,
>>>> David
>>>> -----
>>>>
>>>>
>>>> On 10/04/2013 9:01 AM, David Chase wrote:
>>>>>
>>>>> On 2013-04-09, at 5:26 PM, Vladimir Kozlov
>>>>>  wrote:
>>>>>> One note: in frame_sparc.cpp remove 'jvmg' in the line you modified
>>>>>> since we will not build jvmg.
>>>>>
>>>>> done
>>>>>
>>>>>> And question: did you use mercurial commands to remove and rename
>>>>>> jvm.make and debug.make? We need to use hg commands to preserve
>>>>>> changes history for jvmg.make (it has more changesets then old
>>>>>> debug.make).
>>>>>>
>>>>>> I just want to confirm because sometimes webrev may not show
>>>>>> correctly what was done to sources. I mean you need to do:
>>>>>>
>>>>>> hg remove debug.make
>>>>>> hg rename jvmg.make debug.make
>>>>>>
>>>>>> and then edit debug.make
>>>>>
>>>>> To be sure:
>>>>>
>>>>> 10009  hg revert make/{solaris,bsd,linux}/makefiles/jvmg.make
>>>>> 10010  zip -9 ../safemakes.zip
>>>>> make/{solaris,bsd,linux}/makefiles/debug.make
>>>>> 10011  hg revert make/{solaris,bsd,linux}/makefiles/debug.make
>>>>> 10012  hg remove make/{solaris,bsd,linux}/makefiles/debug.make
>>>>> 10013  for i in solaris bsd linux ; do hg rename
>>>>> make/$i/makefiles/{jvmg,debug}.make; done
>>>>> 10014  unzip -l ../safemakes.zip
>>>>> 10015  unzip ../safemakes.zip
>>>>>
>>>>> And the new-and-improved diffs:
>>>>>
>>>>> http://cr.openjdk.java.net/~drchase/7104565/webrev.06-new/
>>>>>
>>>>>

From vladimir.kozlov at oracle.com  Tue Apr  9 23:31:01 2013
From: vladimir.kozlov at oracle.com (Vladimir Kozlov)
Date: Tue, 09 Apr 2013 23:31:01 -0700
Subject: RFR(M) : 7104565 : trim jprt build targets
In-Reply-To: <5164F9DA.1010506@oracle.com>
References: <7C7CBBE7-2651-4F94-820A-C68378C46AA9@oracle.com>
	<515D27BD.7010006@oracle.com>
	
	<516059C8.3020008@oracle.com>
	
	<51648769.7000809@oracle.com>
	<293891EC-45D0-4549-BD66-3605C6E757EC@oracle.com>
	<5164CF94.4000005@oracle.com> <5164D7D8.5080206@oracle.com>
	<5164E608.8020003@oracle.com> <5164ED8D.8080107@oracle.com>
	<5164F9DA.1010506@oracle.com>
Message-ID: <51650725.8070007@oracle.com>

On 4/9/13 10:34 PM, David Holmes wrote:
> On 10/04/2013 2:41 PM, Vladimir Kozlov wrote:
>> David, the only difference between debug and fastdebug VM builds should
>> be optimization level.
>
> Ok.
>
> Looking at stackMapFrame.hpp the changeset that added the "ifdef DEBUG" was
>
> http://hg.openjdk.java.net/hsx/hotspot-rt/hotspot/rev/4ee06e614636
>
> and it seems to me that perhaps it should have been
> "ifndef PRODUCT" based on the fact that it appears to be a refactoring
> of NOT_PRODUCT code. (The only difference being whether or not it is
> included in the optimized build.)

Thank you, David, for finding this. I think, the intention of changes 
was to not include it into optimized build but may be there was 
confusion about DEBUG vs ASSERT.

We need a brave soul :) and general agreement to do global renaming 
after we done with 7uX (currently we still do backports from hs25 into 
hs24).

We can rename ASSERT to DEBUG_VM (not DEBUG to avoid conflicts with 
external include files like in llvmHeaders.hpp). Then we can change low 
case macro name assert() to upper case ASSERT() to avoid other external 
conflicts found recently. And remove low case debug_only() macro to use 
only upper case.

I hope such changes will resolve our concerns/confusions. But changes 
will be big and will take time.

We can consider David's C. current changes as a move in that direction.

Thanks,
Vladimir

>
> Thanks,
> David
>
>
>
>> The fastdebug VM uses the same -O4 (or -O3) as
>> product build which forces inlining and other optimization and helps
>> with VM speed. Debug VM compiled without any optimizations and does not
>> inline (we need this to be able debug). It is a lot slower then
>> fastdebug VM and because of that can't be used for testing. There should
>> be no other differences between debug and fastdebug VM.
>>
>> All checks done in debug VM should be done in fastdebug VM, period!
>>
>>>>> The changes in src/share/vm/shark/llvmHeaders.hpp need to be confirmed
>>>>> by the shark folk (if they haven't already). (And of course depend on
>>>>> -DDEBUG being eradicated.)
>>>>
>>>> Oracle is not supporting shark! They are on this mailing alias. We
>>>> discussing this for long time already. We hear nothing from them. If
>>>> they find problems later they will send a patch and we use it.
>>>
>>> As long as this shouldn't break their build (which it shouldn't). But
>>> based on that view you could have simply left this untouched.
>>
>> It looks like that code tries to preserve our DEBUG across llvm include
>> files. Yes, you are right - we can leave it.
>>
>> David C., please, undo changes in llvmHeaders.hpp.
>>
>> Thanks,
>> Vladimir
>>
>>>
>>> Thanks,
>>> David
>>>
>>>> Thanks,
>>>> Vladimir
>>>>
>>>>>
>>>>> Thanks,
>>>>> David
>>>>> -----
>>>>>
>>>>>
>>>>> On 10/04/2013 9:01 AM, David Chase wrote:
>>>>>>
>>>>>> On 2013-04-09, at 5:26 PM, Vladimir Kozlov
>>>>>>  wrote:
>>>>>>> One note: in frame_sparc.cpp remove 'jvmg' in the line you modified
>>>>>>> since we will not build jvmg.
>>>>>>
>>>>>> done
>>>>>>
>>>>>>> And question: did you use mercurial commands to remove and rename
>>>>>>> jvm.make and debug.make? We need to use hg commands to preserve
>>>>>>> changes history for jvmg.make (it has more changesets then old
>>>>>>> debug.make).
>>>>>>>
>>>>>>> I just want to confirm because sometimes webrev may not show
>>>>>>> correctly what was done to sources. I mean you need to do:
>>>>>>>
>>>>>>> hg remove debug.make
>>>>>>> hg rename jvmg.make debug.make
>>>>>>>
>>>>>>> and then edit debug.make
>>>>>>
>>>>>> To be sure:
>>>>>>
>>>>>> 10009  hg revert make/{solaris,bsd,linux}/makefiles/jvmg.make
>>>>>> 10010  zip -9 ../safemakes.zip
>>>>>> make/{solaris,bsd,linux}/makefiles/debug.make
>>>>>> 10011  hg revert make/{solaris,bsd,linux}/makefiles/debug.make
>>>>>> 10012  hg remove make/{solaris,bsd,linux}/makefiles/debug.make
>>>>>> 10013  for i in solaris bsd linux ; do hg rename
>>>>>> make/$i/makefiles/{jvmg,debug}.make; done
>>>>>> 10014  unzip -l ../safemakes.zip
>>>>>> 10015  unzip ../safemakes.zip
>>>>>>
>>>>>> And the new-and-improved diffs:
>>>>>>
>>>>>> http://cr.openjdk.java.net/~drchase/7104565/webrev.06-new/
>>>>>>
>>>>>>

From erik.helin at oracle.com  Wed Apr 10 04:27:15 2013
From: erik.helin at oracle.com (erik.helin at oracle.com)
Date: Wed, 10 Apr 2013 11:27:15 +0000
Subject: hg: hsx/hsx24/hotspot: 8010916: Add tenuring threshold to young
	garbage collection events
Message-ID: <20130410112720.35881481AE@hg.openjdk.java.net>

Changeset: 97f2e3ceb67c
Author:    ehelin
Date:      2013-04-10 09:43 +0200
URL:       http://hg.openjdk.java.net/hsx/hsx24/hotspot/rev/97f2e3ceb67c

8010916: Add tenuring threshold to young garbage collection events
Reviewed-by: jwilhelm, brutisso

! src/share/vm/gc_implementation/g1/g1CollectedHeap.cpp
! src/share/vm/gc_implementation/g1/g1CollectorPolicy.hpp
! src/share/vm/gc_implementation/parNew/parNewGeneration.cpp
! src/share/vm/gc_implementation/parallelScavenge/psScavenge.cpp
! src/share/vm/gc_implementation/shared/gcTrace.cpp
! src/share/vm/gc_implementation/shared/gcTrace.hpp
! src/share/vm/gc_implementation/shared/gcTraceSend.cpp
! src/share/vm/memory/defNewGeneration.cpp
! src/share/vm/trace/trace.xml


From coleen.phillimore at oracle.com  Wed Apr 10 05:29:31 2013
From: coleen.phillimore at oracle.com (Coleen Phillimore)
Date: Wed, 10 Apr 2013 08:29:31 -0400
Subject: RFR(M) : 7104565 : trim jprt build targets
In-Reply-To: <5164E0AF.7040503@oracle.com>
References: <7C7CBBE7-2651-4F94-820A-C68378C46AA9@oracle.com>
	<515D27BD.7010006@oracle.com>
	
	<516059C8.3020008@oracle.com>
	
	<51648769.7000809@oracle.com>
	<293891EC-45D0-4549-BD66-3605C6E757EC@oracle.com>
	<5164CF94.4000005@oracle.com>
	<209BC5C3-D6ED-4F19-A22B-597746D69F05@oracle.com>
	<5164E0AF.7040503@oracle.com>
Message-ID: <51655B2B.8060204@oracle.com>


Hi, I plan on reviewing this and expressing opinions, just haven't 
gotten to it yet.   One comment below.

On 4/9/2013 11:46 PM, David Holmes wrote:
> On 10/04/2013 1:05 PM, David Chase wrote:
>> David,
>>
>> The "why" on some of this is that I was starting with an existing 
>> mostly-done-but-aged changeset, so I don't always know why, and there 
>> could be mistakes.  I'm perfectly happy to put those tests back in 
>> (and I will unless someone else objects).
>
> Understood.
>
>> jvmgminimal1_warn needs to go in, I'd call that an oversight.
>
> That's fine.
>
>> And as I understand the plan of this patch, the DEBUG and FASTDEBUG 
>> definitions are gone; however ASSERT is defined in either case, and I 
>> think only in those cases:
>>
>> find . -name * -exec egrep -e DASSERT /dev/null {} ;
>> ./bsd/makefiles/adlc.make:CXXFLAGS += -DASSERT
>> ./bsd/makefiles/debug.make:SYSDEFS += -DASSERT
>> ./bsd/makefiles/fastdebug.make:SYSDEFS += -DASSERT
>> ./linux/makefiles/adlc.make:CXXFLAGS += -DASSERT
>> ./linux/makefiles/debug.make:SYSDEFS += -DASSERT
>> ./linux/makefiles/fastdebug.make:SYSDEFS += -DASSERT
>> ./solaris/makefiles/adlc.make:CXXFLAGS += -DASSERT
>> ./solaris/makefiles/debug.make:SYSDEFS += -DASSERT
>> ./solaris/makefiles/fastdebug.make:SYSDEFS += -DASSERT 
>> -DCHECK_UNHANDLED_OOPS
>>
>> One of these things is not like the other, how about that?
>> Should -DCHECK_UNHANDLED_OOPS be removed from solaris.fastdebug, or 
>> added to the others (or is Solaris.fastdebug somehow special)?
>
> CHECK_UNHANDLED_OOPS is only implemented on Solaris.

Yes, it only works on solaris and only works with fastdebug.   We were 
going to add it to debug too but it made the code less debuggable.   
Couldn't get the overloaded operators for "class oop" to compile on 
linux or windows compilers.   They are probably wrong and won't compile 
on newer solaris compilers either.  It's on our list!  Do not remove it 
though.

Coleen

>
>> I don't have much of an opinion on generateJvmOffsets.cpp and 
>> stackMapFrame.hpp -- I don't know enough of the history, I don't know 
>> how important fastdebug performance is for those two files, and I'm 
>> perfectly willing to defer to someone else's judgment here, but I 
>> don't see a conclusion yet.  I do see that adding in 
>> DEBUG-sensitivity would tweak the makefiles a little again, but that 
>> seems like a minor issue compared to the wins of sanitizing both jprt 
>> and jvmg-vs--debug and cleaning out old profiled builds.  Do you and 
>> Vladimir settle this with rock-paper-scissors, or can we get someone 
>> else to weigh in?
>
> It would be nice if other opinions were expressed.
>
> Cheers,
> David
> -----
>
>> On 2013-04-09, at 10:33 PM, David Holmes  
>> wrote:
>>
>>> Hi David,
>>>
>>> A few comments/concerns:
>>>
>>> jprt.properties:
>>>
>>> So the JPRT GC "_default" tests were redundant? Don't they test that 
>>> ergonomics based selection works okay versus forced GC selection?
>>>
>>> ---
>>>
>>> makefile related:
>>>
>>> The bug says that the debug targets are unused but a fix for that is 
>>> not what has been implemented. Please update the CR to reflect that 
>>> debug lives and jvmg/profiled are what are now gone.
>>>
>>> Why is there no jvmgminimal1_warn target?
>>>
>>> ---
>>>
>>> As discussed in the CR I have concerns about replacing all ifdef 
>>> DEBUG/FASTDEBUG with ASSERT as they do not mean the same thing. In 
>>> particular:
>>>
>>> I don't agree with the removal of the FASTDEBUG define as used here:
>>>
>>> ./os/solaris/dtrace/generateJvmOffsets.cpp:#if defined(DEBUG) || 
>>> defined(FASTDEBUG)
>>> ./os/solaris/dtrace/generateJvmOffsets.cpp:#endif /* defined(DEBUG) 
>>> || defined(FASTDEBUG) */
>>> ./os/bsd/dtrace/generateJvmOffsets.cpp:#if defined(DEBUG) || 
>>> defined(FASTDEBUG)
>>> ./os/bsd/dtrace/generateJvmOffsets.cpp:#endif /* defined(DEBUG) || 
>>> defined(FASTDEBUG) */
>>>
>>> the code this guards couldn't care less about ASSERT, it cares about 
>>> a symbol issue that is related to doing debug/fastdebug builds. (I 
>>> wonder if this is still an issue though - what different build 
>>> settings do we use for a debug build ??)
>>>
>>> Ditto for src/share/vm/classfile/stackMapFrame.hpp - that code is 
>>> not assert related but debugging related. Further you have now added 
>>> that code to fastdebug builds - which seems wrong (or at least 
>>> potentially impacts the "fast" part!). Also as Vladimir has 
>>> indicated in the bug report this code would now be getting tested 
>>> for the first time! - so potential bug tail there.
>>>
>>> The changes in src/share/vm/shark/llvmHeaders.hpp need to be 
>>> confirmed by the shark folk (if they haven't already). (And of 
>>> course depend on -DDEBUG being eradicated.)
>>>
>>> Thanks,
>>> David
>>> -----
>>>
>>>
>>> On 10/04/2013 9:01 AM, David Chase wrote:
>>>>
>>>> On 2013-04-09, at 5:26 PM, Vladimir Kozlov 
>>>>  wrote:
>>>>> One note: in frame_sparc.cpp remove 'jvmg' in the line you 
>>>>> modified since we will not build jvmg.
>>>>
>>>> done
>>>>
>>>>> And question: did you use mercurial commands to remove and rename 
>>>>> jvm.make and debug.make? We need to use hg commands to preserve 
>>>>> changes history for jvmg.make (it has more changesets then old 
>>>>> debug.make).
>>>>>
>>>>> I just want to confirm because sometimes webrev may not show 
>>>>> correctly what was done to sources. I mean you need to do:
>>>>>
>>>>> hg remove debug.make
>>>>> hg rename jvmg.make debug.make
>>>>>
>>>>> and then edit debug.make
>>>>
>>>> To be sure:
>>>>
>>>> 10009  hg revert make/{solaris,bsd,linux}/makefiles/jvmg.make
>>>> 10010  zip -9 ../safemakes.zip 
>>>> make/{solaris,bsd,linux}/makefiles/debug.make
>>>> 10011  hg revert make/{solaris,bsd,linux}/makefiles/debug.make
>>>> 10012  hg remove make/{solaris,bsd,linux}/makefiles/debug.make
>>>> 10013  for i in solaris bsd linux ; do hg rename 
>>>> make/$i/makefiles/{jvmg,debug}.make; done
>>>> 10014  unzip -l ../safemakes.zip
>>>> 10015  unzip ../safemakes.zip
>>>>
>>>> And the new-and-improved diffs:
>>>>
>>>> http://cr.openjdk.java.net/~drchase/7104565/webrev.06-new/
>>>>
>>>>
>>


From karen.kinnear at oracle.com  Wed Apr 10 06:20:49 2013
From: karen.kinnear at oracle.com (Karen Kinnear)
Date: Wed, 10 Apr 2013 09:20:49 -0400
Subject: RFR(M) : 7104565 : trim jprt build targets
In-Reply-To: <51655B2B.8060204@oracle.com>
References: <7C7CBBE7-2651-4F94-820A-C68378C46AA9@oracle.com>
	<515D27BD.7010006@oracle.com>
	
	<516059C8.3020008@oracle.com>
	
	<51648769.7000809@oracle.com>
	<293891EC-45D0-4549-BD66-3605C6E757EC@oracle.com>
	<5164CF94.4000005@oracle.com>
	<209BC5C3-D6ED-4F19-A22B-597746D69F05@oracle.com>
	<5164E0AF.7040503@oracle.com> <51655B2B.8060204@oracle.com>
Message-ID: 

David,

I did not read the webrev - I just wanted to make sure I understood the goals:

Are you leaving product alone. Leaving fastdebug alone, removing debug, and renaming jvmg
to debug - which will continue to have debug and assert and all the symbols jvmg used to have?
And when we do a debug build from jdk level, what will that build?

thanks,
Karen

On Apr 10, 2013, at 8:29 AM, Coleen Phillimore wrote:

> 
> Hi, I plan on reviewing this and expressing opinions, just haven't gotten to it yet.   One comment below.
> 
> On 4/9/2013 11:46 PM, David Holmes wrote:
>> On 10/04/2013 1:05 PM, David Chase wrote:
>>> David,
>>> 
>>> The "why" on some of this is that I was starting with an existing mostly-done-but-aged changeset, so I don't always know why, and there could be mistakes.  I'm perfectly happy to put those tests back in (and I will unless someone else objects).
>> 
>> Understood.
>> 
>>> jvmgminimal1_warn needs to go in, I'd call that an oversight.
>> 
>> That's fine.
>> 
>>> And as I understand the plan of this patch, the DEBUG and FASTDEBUG definitions are gone; however ASSERT is defined in either case, and I think only in those cases:
>>> 
>>> find . -name * -exec egrep -e DASSERT /dev/null {} ;
>>> ./bsd/makefiles/adlc.make:CXXFLAGS += -DASSERT
>>> ./bsd/makefiles/debug.make:SYSDEFS += -DASSERT
>>> ./bsd/makefiles/fastdebug.make:SYSDEFS += -DASSERT
>>> ./linux/makefiles/adlc.make:CXXFLAGS += -DASSERT
>>> ./linux/makefiles/debug.make:SYSDEFS += -DASSERT
>>> ./linux/makefiles/fastdebug.make:SYSDEFS += -DASSERT
>>> ./solaris/makefiles/adlc.make:CXXFLAGS += -DASSERT
>>> ./solaris/makefiles/debug.make:SYSDEFS += -DASSERT
>>> ./solaris/makefiles/fastdebug.make:SYSDEFS += -DASSERT -DCHECK_UNHANDLED_OOPS
>>> 
>>> One of these things is not like the other, how about that?
>>> Should -DCHECK_UNHANDLED_OOPS be removed from solaris.fastdebug, or added to the others (or is Solaris.fastdebug somehow special)?
>> 
>> CHECK_UNHANDLED_OOPS is only implemented on Solaris.
> 
> Yes, it only works on solaris and only works with fastdebug.   We were going to add it to debug too but it made the code less debuggable.   Couldn't get the overloaded operators for "class oop" to compile on linux or windows compilers.   They are probably wrong and won't compile on newer solaris compilers either.  It's on our list!  Do not remove it though.
> 
> Coleen
> 
>> 
>>> I don't have much of an opinion on generateJvmOffsets.cpp and stackMapFrame.hpp -- I don't know enough of the history, I don't know how important fastdebug performance is for those two files, and I'm perfectly willing to defer to someone else's judgment here, but I don't see a conclusion yet.  I do see that adding in DEBUG-sensitivity would tweak the makefiles a little again, but that seems like a minor issue compared to the wins of sanitizing both jprt and jvmg-vs--debug and cleaning out old profiled builds.  Do you and Vladimir settle this with rock-paper-scissors, or can we get someone else to weigh in?
>> 
>> It would be nice if other opinions were expressed.
>> 
>> Cheers,
>> David
>> -----
>> 
>>> On 2013-04-09, at 10:33 PM, David Holmes  wrote:
>>> 
>>>> Hi David,
>>>> 
>>>> A few comments/concerns:
>>>> 
>>>> jprt.properties:
>>>> 
>>>> So the JPRT GC "_default" tests were redundant? Don't they test that ergonomics based selection works okay versus forced GC selection?
>>>> 
>>>> ---
>>>> 
>>>> makefile related:
>>>> 
>>>> The bug says that the debug targets are unused but a fix for that is not what has been implemented. Please update the CR to reflect that debug lives and jvmg/profiled are what are now gone.
>>>> 
>>>> Why is there no jvmgminimal1_warn target?
>>>> 
>>>> ---
>>>> 
>>>> As discussed in the CR I have concerns about replacing all ifdef DEBUG/FASTDEBUG with ASSERT as they do not mean the same thing. In particular:
>>>> 
>>>> I don't agree with the removal of the FASTDEBUG define as used here:
>>>> 
>>>> ./os/solaris/dtrace/generateJvmOffsets.cpp:#if defined(DEBUG) || defined(FASTDEBUG)
>>>> ./os/solaris/dtrace/generateJvmOffsets.cpp:#endif /* defined(DEBUG) || defined(FASTDEBUG) */
>>>> ./os/bsd/dtrace/generateJvmOffsets.cpp:#if defined(DEBUG) || defined(FASTDEBUG)
>>>> ./os/bsd/dtrace/generateJvmOffsets.cpp:#endif /* defined(DEBUG) || defined(FASTDEBUG) */
>>>> 
>>>> the code this guards couldn't care less about ASSERT, it cares about a symbol issue that is related to doing debug/fastdebug builds. (I wonder if this is still an issue though - what different build settings do we use for a debug build ??)
>>>> 
>>>> Ditto for src/share/vm/classfile/stackMapFrame.hpp - that code is not assert related but debugging related. Further you have now added that code to fastdebug builds - which seems wrong (or at least potentially impacts the "fast" part!). Also as Vladimir has indicated in the bug report this code would now be getting tested for the first time! - so potential bug tail there.
>>>> 
>>>> The changes in src/share/vm/shark/llvmHeaders.hpp need to be confirmed by the shark folk (if they haven't already). (And of course depend on -DDEBUG being eradicated.)
>>>> 
>>>> Thanks,
>>>> David
>>>> -----
>>>> 
>>>> 
>>>> On 10/04/2013 9:01 AM, David Chase wrote:
>>>>> 
>>>>> On 2013-04-09, at 5:26 PM, Vladimir Kozlov  wrote:
>>>>>> One note: in frame_sparc.cpp remove 'jvmg' in the line you modified since we will not build jvmg.
>>>>> 
>>>>> done
>>>>> 
>>>>>> And question: did you use mercurial commands to remove and rename jvm.make and debug.make? We need to use hg commands to preserve changes history for jvmg.make (it has more changesets then old debug.make).
>>>>>> 
>>>>>> I just want to confirm because sometimes webrev may not show correctly what was done to sources. I mean you need to do:
>>>>>> 
>>>>>> hg remove debug.make
>>>>>> hg rename jvmg.make debug.make
>>>>>> 
>>>>>> and then edit debug.make
>>>>> 
>>>>> To be sure:
>>>>> 
>>>>> 10009  hg revert make/{solaris,bsd,linux}/makefiles/jvmg.make
>>>>> 10010  zip -9 ../safemakes.zip make/{solaris,bsd,linux}/makefiles/debug.make
>>>>> 10011  hg revert make/{solaris,bsd,linux}/makefiles/debug.make
>>>>> 10012  hg remove make/{solaris,bsd,linux}/makefiles/debug.make
>>>>> 10013  for i in solaris bsd linux ; do hg rename make/$i/makefiles/{jvmg,debug}.make; done
>>>>> 10014  unzip -l ../safemakes.zip
>>>>> 10015  unzip ../safemakes.zip
>>>>> 
>>>>> And the new-and-improved diffs:
>>>>> 
>>>>> http://cr.openjdk.java.net/~drchase/7104565/webrev.06-new/
>>>>> 
>>>>> 
>>> 
> 


From david.r.chase at oracle.com  Wed Apr 10 08:09:26 2013
From: david.r.chase at oracle.com (David Chase)
Date: Wed, 10 Apr 2013 11:09:26 -0400
Subject: RFR(M) : 7104565 : trim jprt build targets
In-Reply-To: 
References: <7C7CBBE7-2651-4F94-820A-C68378C46AA9@oracle.com>
	<515D27BD.7010006@oracle.com>
	
	<516059C8.3020008@oracle.com>
	
	<51648769.7000809@oracle.com>
	<293891EC-45D0-4549-BD66-3605C6E757EC@oracle.com>
	<5164CF94.4000005@oracle.com>
	<209BC5C3-D6ED-4F19-A22B-597746D69F05@oracle.com>
	<5164E0AF.7040503@oracle.com> <51655B2B.8060204@oracle.com>
	
Message-ID: <99F2DE73-5CEC-4663-8864-01174984C749@oracle.com>


On 2013-04-10, at 9:20 AM, Karen Kinnear  wrote:

> David,
> 
> I did not read the webrev - I just wanted to make sure I understood the goals:
> 
> Are you leaving product alone.

Leaving product alone.

> Leaving fastdebug alone, removing debug, and renaming jvmg
> to debug - which will continue to have debug and assert and all the symbols jvmg used to have?

Debug and Fastdebug should be compiled from the same source and flags (ASSERT defined for both), and debug should be the same as what we now call jvmg, but fastdebug will compiled with optimization on.
Fastdebug is (not-)modified in the sense that it no longer defines FASTDEBUG, but all the occurrences of "defined(FASTDEBUG)" or defined(DEBUG)" have been replaced with "defined(ASSERT)".

> And when we do a debug build from jdk level, what will that build?

New build currently attempts to build a jvmg, and goes through these rules to build "debug" instead:

--------
# Compatibility for transition to new naming
warn_jvmg_deprecated:
	echo "Warning: The jvmg target has been replaced with debug"
	echo "Warning: Please update your usage"

jvmg: warn_jvmg_deprecated debug
--------

Next turn of the RFE crank is to replace those other uses of "jvmg" with "debug" and eventually retire those deprecated rules.

A second goal is to prune the JPRT targets -- if debug is just like fastdebug, only slower, then we don't need to test debug builds.
(Complaining about the time taken in testing is what got this pile-o-fun dropped in my lap.)

David


From david.r.chase at oracle.com  Wed Apr 10 08:34:47 2013
From: david.r.chase at oracle.com (David Chase)
Date: Wed, 10 Apr 2013 11:34:47 -0400
Subject: RFR(M) : 7104565 : trim jprt build targets
In-Reply-To: <51650725.8070007@oracle.com>
References: <7C7CBBE7-2651-4F94-820A-C68378C46AA9@oracle.com>
	<515D27BD.7010006@oracle.com>
	
	<516059C8.3020008@oracle.com>
	
	<51648769.7000809@oracle.com>
	<293891EC-45D0-4549-BD66-3605C6E757EC@oracle.com>
	<5164CF94.4000005@oracle.com> <5164D7D8.5080206@oracle.com>
	<5164E608.8020003@oracle.com> <5164ED8D.8080107@oracle.com>
	<5164F9DA.1010506@oracle.com> <51650725.8070007@oracle.com>
Message-ID: <8D328CD6-DF49-4F09-8471-B76B06767F32@oracle.com>

David, Vladimir (and anyone else)

>> Looking at stackMapFrame.hpp the changeset that added the "ifdef DEBUG" was
>> 
>> http://hg.openjdk.java.net/hsx/hotspot-rt/hotspot/rev/4ee06e614636
>> 
>> and it seems to me that perhaps it should have been
>> "ifndef PRODUCT" based on the fact that it appears to be a refactoring
>> of NOT_PRODUCT code. (The only difference being whether or not it is
>> included in the optimized build.)
> 
> I think, the intention of changes was to not include it into optimized build but may be there was confusion about DEBUG vs ASSERT.

Is this a proposed change for this fix in this file (replace ifdef ASSERT with ifndef PRODUCT)
or is this a change for some future fix, or is this a road-not-taken?

I'm happy either way, the editor is open, I just want to get all moles properly whacked.
(other moles -- jvmgminimal1 and llvmHeaders.hpp -- are whacked)

David


From coleen.phillimore at oracle.com  Wed Apr 10 08:50:50 2013
From: coleen.phillimore at oracle.com (Coleen Phillimore)
Date: Wed, 10 Apr 2013 11:50:50 -0400
Subject: RFR(M) : 7104565 : trim jprt build targets
In-Reply-To: <99F2DE73-5CEC-4663-8864-01174984C749@oracle.com>
References: <7C7CBBE7-2651-4F94-820A-C68378C46AA9@oracle.com>
	<515D27BD.7010006@oracle.com>
	
	<516059C8.3020008@oracle.com>
	
	<51648769.7000809@oracle.com>
	<293891EC-45D0-4549-BD66-3605C6E757EC@oracle.com>
	<5164CF94.4000005@oracle.com>
	<209BC5C3-D6ED-4F19-A22B-597746D69F05@oracle.com>
	<5164E0AF.7040503@oracle.com> <51655B2B.8060204@oracle.com>
	
	<99F2DE73-5CEC-4663-8864-01174984C749@oracle.com>
Message-ID: <51658A5A.5070407@oracle.com>


This change is really good.  Thank you for picking it up.  I have a few 
comments:

I think people still use "profiled", or at least Vlad asked me about it 
yesterday.   Were the rules already gone?  I'm not particularly attached 
to it but our other means of profiling the VM might not be available on 
all platforms.   I think people should chime up if they want it.

make/linux/makefiles/defs.make - just a comment.   There should be a 
make/xnix directory for these duplicated files.  They are the same for 
bsd/linux and solaris, aren't they?

I don't understand the concern with generateJVMOffsets.cpp performance.  
I think this is a tool for dtrace or ptrace.  For the 
os/bsd/dtrace/generateJvmOffsets.cpp can you fix bellow on line 70 like 
you did on solaris.

I was somewhat surprised with how few #ifdef DEBUG conditionals there 
are.  But there is still DEBUG_ONLY macros.  I think you said in another 
mail that these eventually should change to ASSERT_ONLY() but 
DEBUG_ONLY() seems fine for now.   So this isn't as confusing as not 
knowing whether to use #ifdef DEBUG vs. ifdef ASSERT.

I didn't see anything in this change that would make fastdebug run 
significantly slower since we use it for testing, but this was the 
original purpose of #ifdef DEBUG.   Fastdebug is neither fast nor 
debuggable, but is a lot faster than jvmg (oops I mean debug) because at 
least functions are inlined on all platforms.   So fastdebug is still 
valuable for running tests, 'debug' is still valuable for debugging and 
product is what we ship so I don't see any going away.   btw. optimized 
even though it bit rots is still useful too.  I wish JPRT builds would 
include an optimized build.

Thanks for doing this pile-o-fun!
Coleen

On 4/10/2013 11:09 AM, David Chase wrote:
> On 2013-04-10, at 9:20 AM, Karen Kinnear  wrote:
>
>> David,
>>
>> I did not read the webrev - I just wanted to make sure I understood the goals:
>>
>> Are you leaving product alone.
> Leaving product alone.
>
>> Leaving fastdebug alone, removing debug, and renaming jvmg
>> to debug - which will continue to have debug and assert and all the symbols jvmg used to have?
> Debug and Fastdebug should be compiled from the same source and flags (ASSERT defined for both), and debug should be the same as what we now call jvmg, but fastdebug will compiled with optimization on.
> Fastdebug is (not-)modified in the sense that it no longer defines FASTDEBUG, but all the occurrences of "defined(FASTDEBUG)" or defined(DEBUG)" have been replaced with "defined(ASSERT)".
>
>> And when we do a debug build from jdk level, what will that build?
> New build currently attempts to build a jvmg, and goes through these rules to build "debug" instead:
>
> --------
> # Compatibility for transition to new naming
> warn_jvmg_deprecated:
> 	echo "Warning: The jvmg target has been replaced with debug"
> 	echo "Warning: Please update your usage"
>
> jvmg: warn_jvmg_deprecated debug
> --------
>
> Next turn of the RFE crank is to replace those other uses of "jvmg" with "debug" and eventually retire those deprecated rules.
>
> A second goal is to prune the JPRT targets -- if debug is just like fastdebug, only slower, then we don't need to test debug builds.
> (Complaining about the time taken in testing is what got this pile-o-fun dropped in my lap.)
>
> David
>


From coleen.phillimore at oracle.com  Wed Apr 10 09:01:23 2013
From: coleen.phillimore at oracle.com (Coleen Phillimore)
Date: Wed, 10 Apr 2013 12:01:23 -0400
Subject: RFR(M) : 7104565 : trim jprt build targets
In-Reply-To: <8D328CD6-DF49-4F09-8471-B76B06767F32@oracle.com>
References: <7C7CBBE7-2651-4F94-820A-C68378C46AA9@oracle.com>
	<515D27BD.7010006@oracle.com>
	
	<516059C8.3020008@oracle.com>
	
	<51648769.7000809@oracle.com>
	<293891EC-45D0-4549-BD66-3605C6E757EC@oracle.com>
	<5164CF94.4000005@oracle.com> <5164D7D8.5080206@oracle.com>
	<5164E608.8020003@oracle.com> <5164ED8D.8080107@oracle.com>
	<5164F9DA.1010506@oracle.com> <51650725.8070007@oracle.com>
	<8D328CD6-DF49-4F09-8471-B76B06767F32@oracle.com>
Message-ID: <51658CD3.8060209@oracle.com>

On 4/10/2013 11:34 AM, David Chase wrote:
> David, Vladimir (and anyone else)
>
>>> Looking at stackMapFrame.hpp the changeset that added the "ifdef DEBUG" was
>>>
>>> http://hg.openjdk.java.net/hsx/hotspot-rt/hotspot/rev/4ee06e614636
>>>
>>> and it seems to me that perhaps it should have been
>>> "ifndef PRODUCT" based on the fact that it appears to be a refactoring
>>> of NOT_PRODUCT code. (The only difference being whether or not it is
>>> included in the optimized build.)
>> I think, the intention of changes was to not include it into optimized build but may be there was confusion about DEBUG vs ASSERT.
> Is this a proposed change for this fix in this file (replace ifdef ASSERT with ifndef PRODUCT)
> or is this a change for some future fix, or is this a road-not-taken?

Yes, I think it was confusion which to use.  It should be ASSERT.
Coleen

>
> I'm happy either way, the editor is open, I just want to get all moles properly whacked.
> (other moles -- jvmgminimal1 and llvmHeaders.hpp -- are whacked)
>
> David
>


From vladimir.kozlov at oracle.com  Wed Apr 10 09:13:45 2013
From: vladimir.kozlov at oracle.com (Vladimir Kozlov)
Date: Wed, 10 Apr 2013 09:13:45 -0700
Subject: RFR(M) : 7104565 : trim jprt build targets
In-Reply-To: <8D328CD6-DF49-4F09-8471-B76B06767F32@oracle.com>
References: <7C7CBBE7-2651-4F94-820A-C68378C46AA9@oracle.com>
	<515D27BD.7010006@oracle.com>
	
	<516059C8.3020008@oracle.com>
	
	<51648769.7000809@oracle.com>
	<293891EC-45D0-4549-BD66-3605C6E757EC@oracle.com>
	<5164CF94.4000005@oracle.com> <5164D7D8.5080206@oracle.com>
	<5164E608.8020003@oracle.com> <5164ED8D.8080107@oracle.com>
	<5164F9DA.1010506@oracle.com> <51650725.8070007@oracle.com>
	<8D328CD6-DF49-4F09-8471-B76B06767F32@oracle.com>
Message-ID: <51658FB9.6070607@oracle.com>

On 4/10/13 8:34 AM, David Chase wrote:
> David, Vladimir (and anyone else)
>
>>> Looking at stackMapFrame.hpp the changeset that added the "ifdef DEBUG" was
>>>
>>> http://hg.openjdk.java.net/hsx/hotspot-rt/hotspot/rev/4ee06e614636
>>>
>>> and it seems to me that perhaps it should have been
>>> "ifndef PRODUCT" based on the fact that it appears to be a refactoring
>>> of NOT_PRODUCT code. (The only difference being whether or not it is
>>> included in the optimized build.)
>>
>> I think, the intention of changes was to not include it into optimized build but may be there was confusion about DEBUG vs ASSERT.
>
> Is this a proposed change for this fix in this file (replace ifdef ASSERT with ifndef PRODUCT)
> or is this a change for some future fix, or is this a road-not-taken?

Keep your ifdef ASSERT. I tried to say that original changes used DEBUG 
instead of ASSERT due to confusion.

Thanks,
Vladimir

>
> I'm happy either way, the editor is open, I just want to get all moles properly whacked.
> (other moles -- jvmgminimal1 and llvmHeaders.hpp -- are whacked)
>
> David
>

From vladimir.kozlov at oracle.com  Wed Apr 10 09:27:40 2013
From: vladimir.kozlov at oracle.com (Vladimir Kozlov)
Date: Wed, 10 Apr 2013 09:27:40 -0700
Subject: RFR(M) : 7104565 : trim jprt build targets
In-Reply-To: <51658A5A.5070407@oracle.com>
References: <7C7CBBE7-2651-4F94-820A-C68378C46AA9@oracle.com>
	<515D27BD.7010006@oracle.com>
	
	<516059C8.3020008@oracle.com>
	
	<51648769.7000809@oracle.com>
	<293891EC-45D0-4549-BD66-3605C6E757EC@oracle.com>
	<5164CF94.4000005@oracle.com>
	<209BC5C3-D6ED-4F19-A22B-597746D69F05@oracle.com>
	<5164E0AF.7040503@oracle.com> <51655B2B.8060204@oracle.com>
	
	<99F2DE73-5CEC-4663-8864-01174984C749@oracle.com>
	<51658A5A.5070407@oracle.com>
Message-ID: <516592FC.9020708@oracle.com>

Coleen,

On 4/10/13 8:50 AM, Coleen Phillimore wrote:
>
> This change is really good.  Thank you for picking it up.  I have a few
> comments:
>
> I think people still use "profiled", or at least Vlad asked me about it
> yesterday.   Were the rules already gone?  I'm not particularly attached
> to it but our other means of profiling the VM might not be available on
> all platforms.   I think people should chime up if they want it.

Nobody use 'profiled' for long time and you can't build it. You may be 
mistaking it for 'optimized' which we still use and it is not touched by 
these changes.

>
> make/linux/makefiles/defs.make - just a comment.   There should be a
> make/xnix directory for these duplicated files.  They are the same for
> bsd/linux and solaris, aren't they?

They are different now. There was discussion long ago to combine all of 
them into one make/posix. But it is a different task.

>
> I don't understand the concern with generateJVMOffsets.cpp performance.
> I think this is a tool for dtrace or ptrace.  For the
> os/bsd/dtrace/generateJvmOffsets.cpp can you fix bellow on line 70 like
> you did on solaris.
>
> I was somewhat surprised with how few #ifdef DEBUG conditionals there
> are.  But there is still DEBUG_ONLY macros.  I think you said in another
> mail that these eventually should change to ASSERT_ONLY() but
> DEBUG_ONLY() seems fine for now.   So this isn't as confusing as not
> knowing whether to use #ifdef DEBUG vs. ifdef ASSERT.

There is confusion about ASSERT and DEBUG_ONLY() usage. We should move 
in an other direction - rename ASSERT to DEBUG_VM, then DEBUG_ONLY() 
will fit perfectly. But it is big change and outside the scope of these 
changes.

>
> I didn't see anything in this change that would make fastdebug run
> significantly slower since we use it for testing, but this was the
> original purpose of #ifdef DEBUG.   Fastdebug is neither fast nor
> debuggable, but is a lot faster than jvmg (oops I mean debug) because at
> least functions are inlined on all platforms.   So fastdebug is still
> valuable for running tests, 'debug' is still valuable for debugging and
> product is what we ship so I don't see any going away.   btw. optimized
> even though it bit rots is still useful too.  I wish JPRT builds would
> include an optimized build.

'optimized' is still used to collect VM statistics. And it is not rots. 
Yes, sometimes we broke its build but we are fixing it.

Thanks,
Vladimir

>
> Thanks for doing this pile-o-fun!
> Coleen
>
> On 4/10/2013 11:09 AM, David Chase wrote:
>> On 2013-04-10, at 9:20 AM, Karen Kinnear 
>> wrote:
>>
>>> David,
>>>
>>> I did not read the webrev - I just wanted to make sure I understood
>>> the goals:
>>>
>>> Are you leaving product alone.
>> Leaving product alone.
>>
>>> Leaving fastdebug alone, removing debug, and renaming jvmg
>>> to debug - which will continue to have debug and assert and all the
>>> symbols jvmg used to have?
>> Debug and Fastdebug should be compiled from the same source and flags
>> (ASSERT defined for both), and debug should be the same as what we now
>> call jvmg, but fastdebug will compiled with optimization on.
>> Fastdebug is (not-)modified in the sense that it no longer defines
>> FASTDEBUG, but all the occurrences of "defined(FASTDEBUG)" or
>> defined(DEBUG)" have been replaced with "defined(ASSERT)".
>>
>>> And when we do a debug build from jdk level, what will that build?
>> New build currently attempts to build a jvmg, and goes through these
>> rules to build "debug" instead:
>>
>> --------
>> # Compatibility for transition to new naming
>> warn_jvmg_deprecated:
>>     echo "Warning: The jvmg target has been replaced with debug"
>>     echo "Warning: Please update your usage"
>>
>> jvmg: warn_jvmg_deprecated debug
>> --------
>>
>> Next turn of the RFE crank is to replace those other uses of "jvmg"
>> with "debug" and eventually retire those deprecated rules.
>>
>> A second goal is to prune the JPRT targets -- if debug is just like
>> fastdebug, only slower, then we don't need to test debug builds.
>> (Complaining about the time taken in testing is what got this
>> pile-o-fun dropped in my lap.)
>>
>> David
>>
>

From coleen.phillimore at oracle.com  Wed Apr 10 10:02:16 2013
From: coleen.phillimore at oracle.com (Coleen Phillimore)
Date: Wed, 10 Apr 2013 13:02:16 -0400
Subject: RFR(M) : 7104565 : trim jprt build targets
In-Reply-To: <516592FC.9020708@oracle.com>
References: <7C7CBBE7-2651-4F94-820A-C68378C46AA9@oracle.com>
	<515D27BD.7010006@oracle.com>
	
	<516059C8.3020008@oracle.com>
	
	<51648769.7000809@oracle.com>
	<293891EC-45D0-4549-BD66-3605C6E757EC@oracle.com>
	<5164CF94.4000005@oracle.com>
	<209BC5C3-D6ED-4F19-A22B-597746D69F05@oracle.com>
	<5164E0AF.7040503@oracle.com> <51655B2B.8060204@oracle.com>
	
	<99F2DE73-5CEC-4663-8864-01174984C749@oracle.com>
	<51658A5A.5070407@oracle.com> <516592FC.9020708@oracle.com>
Message-ID: <51659B18.7060100@oracle.com>

On 4/10/2013 12:27 PM, Vladimir Kozlov wrote:
> Coleen,
>
> On 4/10/13 8:50 AM, Coleen Phillimore wrote:
>>
>> This change is really good.  Thank you for picking it up.  I have a few
>> comments:
>>
>> I think people still use "profiled", or at least Vlad asked me about it
>> yesterday.   Were the rules already gone?  I'm not particularly attached
>> to it but our other means of profiling the VM might not be available on
>> all platforms.   I think people should chime up if they want it.
>
> Nobody use 'profiled' for long time and you can't build it. You may be 
> mistaking it for 'optimized' which we still use and it is not touched 
> by these changes.

If it doesn't build now, then, yes it should be removed.   Two people 
asked me about it recently though, so it might be the only way to 
profile the vm on some platforms.

>
>>
>> make/linux/makefiles/defs.make - just a comment.   There should be a
>> make/xnix directory for these duplicated files.  They are the same for
>> bsd/linux and solaris, aren't they?
>
> They are different now. There was discussion long ago to combine all 
> of them into one make/posix. But it is a different task.
>

Yes, bug id JDK-7015652 
>>
>> I don't understand the concern with generateJVMOffsets.cpp performance.
>> I think this is a tool for dtrace or ptrace.  For the
>> os/bsd/dtrace/generateJvmOffsets.cpp can you fix bellow on line 70 like
>> you did on solaris.
>>
>> I was somewhat surprised with how few #ifdef DEBUG conditionals there
>> are.  But there is still DEBUG_ONLY macros.  I think you said in another
>> mail that these eventually should change to ASSERT_ONLY() but
>> DEBUG_ONLY() seems fine for now.   So this isn't as confusing as not
>> knowing whether to use #ifdef DEBUG vs. ifdef ASSERT.
>
> There is confusion about ASSERT and DEBUG_ONLY() usage. We should move 
> in an other direction - rename ASSERT to DEBUG_VM, then DEBUG_ONLY() 
> will fit perfectly. But it is big change and outside the scope of 
> these changes.

There are a lot of #ifdef ASSERTs in the code.   It is bigger and more 
disruptive to change these to DEBUG_VM or (why not) simply DEBUG.
>
>>
>> I didn't see anything in this change that would make fastdebug run
>> significantly slower since we use it for testing, but this was the
>> original purpose of #ifdef DEBUG.   Fastdebug is neither fast nor
>> debuggable, but is a lot faster than jvmg (oops I mean debug) because at
>> least functions are inlined on all platforms.   So fastdebug is still
>> valuable for running tests, 'debug' is still valuable for debugging and
>> product is what we ship so I don't see any going away.   btw. optimized
>> even though it bit rots is still useful too.  I wish JPRT builds would
>> include an optimized build.
>
> 'optimized' is still used to collect VM statistics. And it is not 
> rots. Yes, sometimes we broke its build but we are fixing it.
>

Well, it does break a lot!  It should be a JPRT build target because 
this is completely avoidable.   Not with this change.   Next time it 
breaks someone should fix it and add it to be a JPRT build target.

Coleen
> Thanks,
> Vladimir
>
>>
>> Thanks for doing this pile-o-fun!
>> Coleen
>>
>> On 4/10/2013 11:09 AM, David Chase wrote:
>>> On 2013-04-10, at 9:20 AM, Karen Kinnear 
>>> wrote:
>>>
>>>> David,
>>>>
>>>> I did not read the webrev - I just wanted to make sure I understood
>>>> the goals:
>>>>
>>>> Are you leaving product alone.
>>> Leaving product alone.
>>>
>>>> Leaving fastdebug alone, removing debug, and renaming jvmg
>>>> to debug - which will continue to have debug and assert and all the
>>>> symbols jvmg used to have?
>>> Debug and Fastdebug should be compiled from the same source and flags
>>> (ASSERT defined for both), and debug should be the same as what we now
>>> call jvmg, but fastdebug will compiled with optimization on.
>>> Fastdebug is (not-)modified in the sense that it no longer defines
>>> FASTDEBUG, but all the occurrences of "defined(FASTDEBUG)" or
>>> defined(DEBUG)" have been replaced with "defined(ASSERT)".
>>>
>>>> And when we do a debug build from jdk level, what will that build?
>>> New build currently attempts to build a jvmg, and goes through these
>>> rules to build "debug" instead:
>>>
>>> --------
>>> # Compatibility for transition to new naming
>>> warn_jvmg_deprecated:
>>>     echo "Warning: The jvmg target has been replaced with debug"
>>>     echo "Warning: Please update your usage"
>>>
>>> jvmg: warn_jvmg_deprecated debug
>>> --------
>>>
>>> Next turn of the RFE crank is to replace those other uses of "jvmg"
>>> with "debug" and eventually retire those deprecated rules.
>>>
>>> A second goal is to prune the JPRT targets -- if debug is just like
>>> fastdebug, only slower, then we don't need to test debug builds.
>>> (Complaining about the time taken in testing is what got this
>>> pile-o-fun dropped in my lap.)
>>>
>>> David
>>>
>>


From vladimir.kozlov at oracle.com  Wed Apr 10 10:43:11 2013
From: vladimir.kozlov at oracle.com (Vladimir Kozlov)
Date: Wed, 10 Apr 2013 10:43:11 -0700
Subject: RFR(M) : 7104565 : trim jprt build targets
In-Reply-To: <51659B18.7060100@oracle.com>
References: <7C7CBBE7-2651-4F94-820A-C68378C46AA9@oracle.com>
	<515D27BD.7010006@oracle.com>
	
	<516059C8.3020008@oracle.com>
	
	<51648769.7000809@oracle.com>
	<293891EC-45D0-4549-BD66-3605C6E757EC@oracle.com>
	<5164CF94.4000005@oracle.com>
	<209BC5C3-D6ED-4F19-A22B-597746D69F05@oracle.com>
	<5164E0AF.7040503@oracle.com> <51655B2B.8060204@oracle.com>
	
	<99F2DE73-5CEC-4663-8864-01174984C749@oracle.com>
	<51658A5A.5070407@oracle.com> <516592FC.9020708@oracle.com>
	<51659B18.7060100@oracle.com>
Message-ID: <5165A4AF.6020402@oracle.com>

 > There are a lot of #ifdef ASSERTs in the code.   It is bigger and more
 > disruptive to change these to DEBUG_VM or (why not) simply DEBUG.

Unfortunately DEBUG is used by external include files. For example, in 
llvm - that is why we have that DEBUG preserve code in 
shark/llvmHeaders.hpp.

 >> 'optimized' is still used to collect VM statistics. And it is not
 >> rots. Yes, sometimes we broke its build but we are fixing it.
 >
 > Well, it does break a lot!  It should be a JPRT build target because
 > this is completely avoidable.   Not with this change.   Next time it
 > breaks someone should fix it and add it to be a JPRT build target.

Agree, at least on platforms which are not bottleneck for JPRT job.

Thanks,
Vladimir

On 4/10/13 10:02 AM, Coleen Phillimore wrote:
> On 4/10/2013 12:27 PM, Vladimir Kozlov wrote:
>> Coleen,
>>
>> On 4/10/13 8:50 AM, Coleen Phillimore wrote:
>>>
>>> This change is really good.  Thank you for picking it up.  I have a few
>>> comments:
>>>
>>> I think people still use "profiled", or at least Vlad asked me about it
>>> yesterday.   Were the rules already gone?  I'm not particularly attached
>>> to it but our other means of profiling the VM might not be available on
>>> all platforms.   I think people should chime up if they want it.
>>
>> Nobody use 'profiled' for long time and you can't build it. You may be
>> mistaking it for 'optimized' which we still use and it is not touched
>> by these changes.
>
> If it doesn't build now, then, yes it should be removed.   Two people
> asked me about it recently though, so it might be the only way to
> profile the vm on some platforms.
>
>>
>>>
>>> make/linux/makefiles/defs.make - just a comment.   There should be a
>>> make/xnix directory for these duplicated files.  They are the same for
>>> bsd/linux and solaris, aren't they?
>>
>> They are different now. There was discussion long ago to combine all
>> of them into one make/posix. But it is a different task.
>>
>
> Yes, bug id JDK-7015652 
>>>
>>> I don't understand the concern with generateJVMOffsets.cpp performance.
>>> I think this is a tool for dtrace or ptrace.  For the
>>> os/bsd/dtrace/generateJvmOffsets.cpp can you fix bellow on line 70 like
>>> you did on solaris.
>>>
>>> I was somewhat surprised with how few #ifdef DEBUG conditionals there
>>> are.  But there is still DEBUG_ONLY macros.  I think you said in another
>>> mail that these eventually should change to ASSERT_ONLY() but
>>> DEBUG_ONLY() seems fine for now.   So this isn't as confusing as not
>>> knowing whether to use #ifdef DEBUG vs. ifdef ASSERT.
>>
>> There is confusion about ASSERT and DEBUG_ONLY() usage. We should move
>> in an other direction - rename ASSERT to DEBUG_VM, then DEBUG_ONLY()
>> will fit perfectly. But it is big change and outside the scope of
>> these changes.
>
> There are a lot of #ifdef ASSERTs in the code.   It is bigger and more
> disruptive to change these to DEBUG_VM or (why not) simply DEBUG.
>>
>>>
>>> I didn't see anything in this change that would make fastdebug run
>>> significantly slower since we use it for testing, but this was the
>>> original purpose of #ifdef DEBUG.   Fastdebug is neither fast nor
>>> debuggable, but is a lot faster than jvmg (oops I mean debug) because at
>>> least functions are inlined on all platforms.   So fastdebug is still
>>> valuable for running tests, 'debug' is still valuable for debugging and
>>> product is what we ship so I don't see any going away.   btw. optimized
>>> even though it bit rots is still useful too.  I wish JPRT builds would
>>> include an optimized build.
>>
>> 'optimized' is still used to collect VM statistics. And it is not
>> rots. Yes, sometimes we broke its build but we are fixing it.
>>
>
> Well, it does break a lot!  It should be a JPRT build target because
> this is completely avoidable.   Not with this change.   Next time it
> breaks someone should fix it and add it to be a JPRT build target.
>
> Coleen
>> Thanks,
>> Vladimir
>>
>>>
>>> Thanks for doing this pile-o-fun!
>>> Coleen
>>>
>>> On 4/10/2013 11:09 AM, David Chase wrote:
>>>> On 2013-04-10, at 9:20 AM, Karen Kinnear 
>>>> wrote:
>>>>
>>>>> David,
>>>>>
>>>>> I did not read the webrev - I just wanted to make sure I understood
>>>>> the goals:
>>>>>
>>>>> Are you leaving product alone.
>>>> Leaving product alone.
>>>>
>>>>> Leaving fastdebug alone, removing debug, and renaming jvmg
>>>>> to debug - which will continue to have debug and assert and all the
>>>>> symbols jvmg used to have?
>>>> Debug and Fastdebug should be compiled from the same source and flags
>>>> (ASSERT defined for both), and debug should be the same as what we now
>>>> call jvmg, but fastdebug will compiled with optimization on.
>>>> Fastdebug is (not-)modified in the sense that it no longer defines
>>>> FASTDEBUG, but all the occurrences of "defined(FASTDEBUG)" or
>>>> defined(DEBUG)" have been replaced with "defined(ASSERT)".
>>>>
>>>>> And when we do a debug build from jdk level, what will that build?
>>>> New build currently attempts to build a jvmg, and goes through these
>>>> rules to build "debug" instead:
>>>>
>>>> --------
>>>> # Compatibility for transition to new naming
>>>> warn_jvmg_deprecated:
>>>>     echo "Warning: The jvmg target has been replaced with debug"
>>>>     echo "Warning: Please update your usage"
>>>>
>>>> jvmg: warn_jvmg_deprecated debug
>>>> --------
>>>>
>>>> Next turn of the RFE crank is to replace those other uses of "jvmg"
>>>> with "debug" and eventually retire those deprecated rules.
>>>>
>>>> A second goal is to prune the JPRT targets -- if debug is just like
>>>> fastdebug, only slower, then we don't need to test debug builds.
>>>> (Complaining about the time taken in testing is what got this
>>>> pile-o-fun dropped in my lap.)
>>>>
>>>> David
>>>>
>>>
>

From erik.helin at oracle.com  Wed Apr 10 17:22:47 2013
From: erik.helin at oracle.com (erik.helin at oracle.com)
Date: Thu, 11 Apr 2013 00:22:47 +0000
Subject: hg: hsx/hsx24/hotspot: 8011699: CMS: assert(_shared_gc_info.id() !=
	SharedGCInfo::UNSET_GCID) failed: GC not started?
Message-ID: <20130411002254.B159E481DF@hg.openjdk.java.net>

Changeset: 6f73a3a47ba4
Author:    ehelin
Date:      2013-04-11 00:02 +0200
URL:       http://hg.openjdk.java.net/hsx/hsx24/hotspot/rev/6f73a3a47ba4

8011699: CMS: assert(_shared_gc_info.id() != SharedGCInfo::UNSET_GCID) failed: GC not started?
Reviewed-by: stefank, mgerdin

! src/share/vm/gc_implementation/concurrentMarkSweep/concurrentMarkSweepGeneration.cpp
! src/share/vm/gc_implementation/concurrentMarkSweep/concurrentMarkSweepGeneration.hpp
! src/share/vm/gc_implementation/concurrentMarkSweep/vmCMSOperations.cpp


From erik.helin at oracle.com  Thu Apr 11 00:25:44 2013
From: erik.helin at oracle.com (erik.helin at oracle.com)
Date: Thu, 11 Apr 2013 07:25:44 +0000
Subject: hg: hsx/hsx24/hotspot: 8008920: Tracing events for heap statistics
Message-ID: <20130411072548.DF977481ED@hg.openjdk.java.net>

Changeset: 7c942384867f
Author:    ehelin
Date:      2013-04-10 10:40 +0200
URL:       http://hg.openjdk.java.net/hsx/hsx24/hotspot/rev/7c942384867f

8008920: Tracing events for heap statistics
Reviewed-by: jwilhelm, mgerdin, brutisso

! src/share/vm/gc_implementation/concurrentMarkSweep/concurrentMarkSweepGeneration.cpp
! src/share/vm/gc_implementation/g1/concurrentMark.cpp
! src/share/vm/gc_implementation/g1/g1MarkSweep.cpp
! src/share/vm/gc_implementation/parallelScavenge/psMarkSweep.cpp
! src/share/vm/gc_implementation/parallelScavenge/psParallelCompact.cpp
! src/share/vm/gc_implementation/shared/gcTrace.cpp
! src/share/vm/gc_implementation/shared/gcTrace.hpp
! src/share/vm/gc_implementation/shared/gcTraceSend.cpp
! src/share/vm/gc_implementation/shared/vmGCOperations.cpp
! src/share/vm/gc_implementation/shared/vmGCOperations.hpp
! src/share/vm/memory/genMarkSweep.cpp
! src/share/vm/trace/trace.xml


From alejandro.murillo at oracle.com  Thu Apr 11 00:54:57 2013
From: alejandro.murillo at oracle.com (alejandro.murillo at oracle.com)
Date: Thu, 11 Apr 2013 07:54:57 +0000
Subject: hg: hsx/hotspot-main/hotspot: 11 new changesets
Message-ID: <20130411075524.7BDD6481F1@hg.openjdk.java.net>

Changeset: 3b890cd4da64
Author:    ctornqvi
Date:      2013-04-03 21:41 +0200
URL:       http://hg.openjdk.java.net/hsx/hotspot-main/hotspot/rev/3b890cd4da64

8009125: Add NMT tests for Virtual Memory operations
Summary: Tests added for Reserve/Commit/Uncommit/Unreserve operations
Reviewed-by: zgu, mgerdin

! src/share/vm/prims/whitebox.cpp
- test/runtime/NMT/AllocTestType.java
+ test/runtime/NMT/MallocTestType.java
+ test/runtime/NMT/ThreadedMallocTestType.java
+ test/runtime/NMT/ThreadedVirtualAllocTestType.java
+ test/runtime/NMT/VirtualAllocTestType.java
! test/testlibrary/OutputAnalyzerTest.java
! test/testlibrary/com/oracle/java/testlibrary/OutputAnalyzer.java
! test/testlibrary/whitebox/sun/hotspot/WhiteBox.java

Changeset: 8554c55669b0
Author:    hseigel
Date:      2013-04-04 08:47 -0400
URL:       http://hg.openjdk.java.net/hsx/hotspot-main/hotspot/rev/8554c55669b0

8010943: guarantee(length == 0) failed: invalid method ordering length
Summary: Add DumpSharedSpaces to IF condition to handle verify during -Xshare:dump.
Reviewed-by: coleenp, zgu

! src/share/vm/oops/instanceKlass.cpp

Changeset: bad3bed4b323
Author:    ccheung
Date:      2013-03-29 14:18 -0700
URL:       http://hg.openjdk.java.net/hsx/hotspot-main/hotspot/rev/bad3bed4b323

8006006: [parfait] Memory leak at hotspot/src/share/tools/launcher/wildcard.c
Summary: a simple fix to add FileList_free(fl) before returning NULL.
Reviewed-by: zgu, coleenp, minqi

! src/share/tools/launcher/wildcard.c

Changeset: 17bf4d428955
Author:    ccheung
Date:      2013-04-03 16:43 -0700
URL:       http://hg.openjdk.java.net/hsx/hotspot-main/hotspot/rev/17bf4d428955

8006103: [parfait] Possible null pointer dereference at hotspot/src/os/linux/vm/os_linux.cpp; os_windows.cpp; os_solaris.cpp; os_bsd.cpp
Reviewed-by: zgu, iklam

! src/os/bsd/vm/os_bsd.cpp
! src/os/linux/vm/os_linux.cpp
! src/os/solaris/vm/os_solaris.cpp
! src/os/windows/vm/os_windows.cpp

Changeset: cc32ccaaf47f
Author:    mikael
Date:      2013-04-04 10:01 -0700
URL:       http://hg.openjdk.java.net/hsx/hotspot-main/hotspot/rev/cc32ccaaf47f

8003310: Enable -Wunused-function when compiling with gcc
Summary: Add the -Wunused-function flag and remove a number of unused functions.
Reviewed-by: dholmes, coleenp, kvn

! make/linux/makefiles/gcc.make
! src/cpu/x86/vm/assembler_x86.cpp
! src/cpu/x86/vm/methodHandles_x86.cpp
! src/cpu/x86/vm/x86_64.ad
! src/os/bsd/vm/os_bsd.cpp
! src/os/linux/vm/os_linux.cpp
! src/os/solaris/vm/os_solaris.cpp
! src/share/vm/c1/c1_LIRGenerator.cpp
! src/share/vm/compiler/compileLog.cpp
! src/share/vm/compiler/compilerOracle.cpp
! src/share/vm/gc_implementation/g1/g1CollectorPolicy.cpp
! src/share/vm/gc_implementation/g1/ptrQueue.cpp
! src/share/vm/interpreter/interpreterRuntime.cpp
! src/share/vm/memory/heap.cpp
! src/share/vm/memory/universe.cpp
! src/share/vm/oops/constantPool.cpp
! src/share/vm/opto/block.cpp
! src/share/vm/opto/compile.cpp
! src/share/vm/opto/connode.cpp
! src/share/vm/opto/subnode.cpp
! src/share/vm/prims/jni.cpp
! src/share/vm/prims/jniCheck.hpp
! src/share/vm/runtime/arguments.cpp
! src/share/vm/runtime/safepoint.cpp
! src/share/vm/runtime/synchronizer.cpp
! src/share/vm/runtime/synchronizer.hpp
! src/share/vm/utilities/debug.cpp
! src/share/vm/utilities/globalDefinitions.cpp
! src/share/vm/utilities/globalDefinitions.hpp

Changeset: 4c8bb5e4f68f
Author:    zgu
Date:      2013-04-05 12:19 -0400
URL:       http://hg.openjdk.java.net/hsx/hotspot-main/hotspot/rev/4c8bb5e4f68f

8011161: NMT: Memory leak when encountering out of memory error while initializing memory snapshot
Summary: Fix memory leaks when NMT fails to initialize snapshot and worker thread
Reviewed-by: dcubed, ccheung, rdurbin

! src/share/vm/services/memTracker.cpp

Changeset: 8be1318fbe77
Author:    dcubed
Date:      2013-04-05 10:38 -0700
URL:       http://hg.openjdk.java.net/hsx/hotspot-main/hotspot/rev/8be1318fbe77

Merge

! src/cpu/x86/vm/x86_64.ad
! src/os/bsd/vm/os_bsd.cpp
! src/os/linux/vm/os_linux.cpp
! src/os/solaris/vm/os_solaris.cpp
! src/os/windows/vm/os_windows.cpp
! src/share/vm/c1/c1_LIRGenerator.cpp
! src/share/vm/memory/universe.cpp
! src/share/vm/oops/instanceKlass.cpp
! src/share/vm/runtime/arguments.cpp
- test/runtime/NMT/AllocTestType.java

Changeset: 46d24f112c27
Author:    dcubed
Date:      2013-04-05 16:16 -0700
URL:       http://hg.openjdk.java.net/hsx/hotspot-main/hotspot/rev/46d24f112c27

Merge

- make/bsd/build.sh
- make/linux/build.sh
- make/solaris/build.sh

Changeset: 4b7cf00ccb08
Author:    ccheung
Date:      2013-04-05 11:15 -0700
URL:       http://hg.openjdk.java.net/hsx/hotspot-main/hotspot/rev/4b7cf00ccb08

8006001: [parfait] Possible file leak in hotspot/src/os/linux/vm/perfMemory_linux.cpp
Reviewed-by: zgu, coleenp, hseigel, dholmes

! src/os/bsd/vm/perfMemory_bsd.cpp
! src/os/linux/vm/perfMemory_linux.cpp
! src/os/solaris/vm/perfMemory_solaris.cpp
! src/os/windows/vm/perfMemory_windows.cpp

Changeset: b933e75e7cbe
Author:    zgu
Date:      2013-04-05 23:10 -0700
URL:       http://hg.openjdk.java.net/hsx/hotspot-main/hotspot/rev/b933e75e7cbe

Merge


Changeset: 09b0d3e9ba6c
Author:    bharadwaj
Date:      2013-04-09 08:52 -0700
URL:       http://hg.openjdk.java.net/hsx/hotspot-main/hotspot/rev/09b0d3e9ba6c

8011671: JCK tests on static interface methods fail under b84: Illegal type at constant pool entry 5
Summary: Restore incorrect removal of support for static interface method verification in Java 8
Reviewed-by: kvn, coleenp

! src/share/vm/classfile/verifier.cpp


From vladimir.voskresensky at oracle.com  Thu Apr 11 04:13:42 2013
From: vladimir.voskresensky at oracle.com (Vladimir Voskresensky - Oracle)
Date: Thu, 11 Apr 2013 15:13:42 +0400
Subject: RFR: Project files for Solaris Studio / NetBeans
In-Reply-To: <5159B162.4080805@oracle.com>
References: <51507B60.6030809@oracle.com> <51531883.7070903@oracle.com>
	<5156C697.8060003@oracle.com> <5159B162.4080805@oracle.com>
Message-ID: <51669AE6.3010201@oracle.com>

Hi Jesper,

Just interested in the progress with review/push :-)
Any news?

Thanks,
Vladimir.

On 04/ 1/13 08:10 PM, Vladimir Voskresensky - Oracle wrote:
> Jesper,
>
> Minor comment: it's better to have env variable named IDE_ALT_BOOTDIR instead 
> of IDE_JAVAPATH to give analogy with the old well known meaning.
>
> Vladimir.
>
> On 03/30/13 03:03 PM, Vladimir Voskresensky wrote:
>> Jesper,
>>
>> It looks good and works for me on Linux_64.
>>
>> Some comments for others:
>> before running IDE specify IDE_JAVAPATH env variable if want to navigate into 
>> some java/include files (value is the same as previously was known as 
>> ALT_BOOTDIR):
>> #export IDE_JAVAPATH=/opt/jdk/latest7
>> after opening project, make sure you are switched to Linux configuration
>>
>> Thanks!
>> Vladimir.
>>
>> On 03/27/2013 08:04 PM, Jesper Wilhelmsson wrote:
>>> Hi,
>>>
>>> A new webrev is now available. The issues reported from the first review 
>>> should be fixed and the project now contains configurations for both 
>>> Linux_64 and Mac_64.
>>>
>>> To select configuration there is a dropdown menu next to the build button.
>>>
>>> http://cr.openjdk.java.net/~jwilhelm/7074926/webrev.2/
>>>
>>> Thanks,
>>> /Jesper
>>>
>>>
>>> Jesper Wilhelmsson skrev 25/3/13 5:29 PM:
>>>> Hi,
>>>>
>>>> Sorry for cross posting, but I think this could be useful for several areas.
>>>>
>>>> I would like to add Solaris Studio / NetBeans project files for the entire
>>>> OpenJDK project. To clarify: One project that contains the entire OpenJDK.
>>>>
>>>>
>>>> With the new build infrastructure in JDK 8 building the entire OpenJDK is 
>>>> fairly
>>>> fast and even though I personally mostly work in the HotSpot tree, I tend to
>>>> always clone and build the entire JDK forest. I find this to have several 
>>>> benefits.
>>>>
>>>> Webrev: http://cr.openjdk.java.net/~jwilhelm/7074926/webrev/
>>>>
>>>> The configuration in this project is currently Mac only. Linux and Solaris
>>>> configurations are also planned.
>>>>
>>>> The webrev is made from the jdk8/build repository which is where I think a
>>>> change like this should go in. Let me know if you think something else.
>>>>
>>>>
>>>>
>>>> To use this project (once pushed):
>>>>
>>>> 1. Clone your favorite repository
>>>>     hg clone http://hg.openjdk.java.net/hsx/hotspot-gc
>>>>
>>>> 2. Get the whole forest
>>>>     cd hotspot-gc
>>>>     sh get_source.sh
>>>>
>>>> 3. Configure
>>>>     sh configure
>>>>
>>>> 4. Open Solaris studio / NetBeans and load the project.
>>>>     The project in located in the common directory.
>>>>
>>>>
>>>> Thanks,
>>>> /Jesper
>>

From dmitry.samersoff at oracle.com  Thu Apr 11 05:23:55 2013
From: dmitry.samersoff at oracle.com (Dmitry Samersoff)
Date: Thu, 11 Apr 2013 16:23:55 +0400
Subject: RFR: Project files for Solaris Studio / NetBeans
In-Reply-To: <51531883.7070903@oracle.com>
References: <51507B60.6030809@oracle.com> <51531883.7070903@oracle.com>
Message-ID: <5166AB5B.5050403@oracle.com>

Jesper,

Is it correct that this this project is for native part of JDK only?

If yes - is it possible to rename it to OpenJDK_Native or create
common/netbeans/native/OpenJDK to avoid any misunderstanding and future
name conflicts?

I hope sometimes OpenJDK_java project appears as well.

-Dmitry

On 2013-03-27 20:04, Jesper Wilhelmsson wrote:
> Hi,
> 
> A new webrev is now available. The issues reported from the first review
> should be fixed and the project now contains configurations for both
> Linux_64 and Mac_64.
> 
> To select configuration there is a dropdown menu next to the build button.
> 
> http://cr.openjdk.java.net/~jwilhelm/7074926/webrev.2/
> 
> Thanks,
> /Jesper
> 
> 
> Jesper Wilhelmsson skrev 25/3/13 5:29 PM:
>> Hi,
>>
>> Sorry for cross posting, but I think this could be useful for several
>> areas.
>>
>> I would like to add Solaris Studio / NetBeans project files for the
>> entire
>> OpenJDK project. To clarify: One project that contains the entire
>> OpenJDK.
>>
>>
>> With the new build infrastructure in JDK 8 building the entire OpenJDK
>> is fairly
>> fast and even though I personally mostly work in the HotSpot tree, I
>> tend to
>> always clone and build the entire JDK forest. I find this to have
>> several benefits.
>>
>> Webrev: http://cr.openjdk.java.net/~jwilhelm/7074926/webrev/
>>
>> The configuration in this project is currently Mac only. Linux and
>> Solaris
>> configurations are also planned.
>>
>> The webrev is made from the jdk8/build repository which is where I
>> think a
>> change like this should go in. Let me know if you think something else.
>>
>>
>>
>> To use this project (once pushed):
>>
>> 1. Clone your favorite repository
>>     hg clone http://hg.openjdk.java.net/hsx/hotspot-gc
>>
>> 2. Get the whole forest
>>     cd hotspot-gc
>>     sh get_source.sh
>>
>> 3. Configure
>>     sh configure
>>
>> 4. Open Solaris studio / NetBeans and load the project.
>>     The project in located in the common directory.
>>
>>
>> Thanks,
>> /Jesper


-- 
Dmitry Samersoff
Oracle Java development team, Saint Petersburg, Russia
* Give Rabbit time, and he'll always get the answer

From david.r.chase at oracle.com  Thu Apr 11 05:46:09 2013
From: david.r.chase at oracle.com (David Chase)
Date: Thu, 11 Apr 2013 08:46:09 -0400
Subject: RFR(M) : 7104565 : trim jprt build targets
In-Reply-To: <51658FB9.6070607@oracle.com>
References: <7C7CBBE7-2651-4F94-820A-C68378C46AA9@oracle.com>
	<515D27BD.7010006@oracle.com>
	
	<516059C8.3020008@oracle.com>
	
	<51648769.7000809@oracle.com>
	<293891EC-45D0-4549-BD66-3605C6E757EC@oracle.com>
	<5164CF94.4000005@oracle.com> <5164D7D8.5080206@oracle.com>
	<5164E608.8020003@oracle.com> <5164ED8D.8080107@oracle.com>
	<5164F9DA.1010506@oracle.com> <51650725.8070007@oracle.com>
	<8D328CD6-DF49-4F09-8471-B76B06767F32@oracle.com>
	<51658FB9.6070607@oracle.com>
Message-ID: 

http://cr.openjdk.java.net/~drchase/7104565/webrev.07/

 jvmgminimal1_warn added.
 llvmHeaders.hpp reverted.



From vladimir.voskresensky at oracle.com  Thu Apr 11 06:00:17 2013
From: vladimir.voskresensky at oracle.com (Vladimir Voskresensky)
Date: Thu, 11 Apr 2013 17:00:17 +0400
Subject: RFR: Project files for Solaris Studio / NetBeans
In-Reply-To: <5166AB5B.5050403@oracle.com>
References: <51507B60.6030809@oracle.com> <51531883.7070903@oracle.com>
	<5166AB5B.5050403@oracle.com>
Message-ID: <5166B3E1.1060104@oracle.com>

Dmitry,

On 04/11/2013 04:23 PM, Dmitry Samersoff wrote:
> Jesper,
>
> Is it correct that this this project is for native part of JDK only?
Yes, it is project around C/C++ part of OpenJDK, but it's build command 
creates full jdk image (i.e. with all java parts as well):
${MAKE} -f Makefile LOG=debug images

>
> If yes - is it possible to rename it to OpenJDK_Native or create
> common/netbeans/native/OpenJDK to avoid any misunderstanding and future
> name conflicts?
what about simpler layout:
common/native_project
(or make/native_project)
otherwise developer have to go several levels down: common, netbeans, 
native, OpenJDK

Thanks,
Vladimir.
>
> I hope sometimes OpenJDK_java project appears as well.
>
> -Dmitry
>
> On 2013-03-27 20:04, Jesper Wilhelmsson wrote:
>> Hi,
>>
>> A new webrev is now available. The issues reported from the first review
>> should be fixed and the project now contains configurations for both
>> Linux_64 and Mac_64.
>>
>> To select configuration there is a dropdown menu next to the build button.
>>
>> http://cr.openjdk.java.net/~jwilhelm/7074926/webrev.2/
>>
>> Thanks,
>> /Jesper
>>
>>
>> Jesper Wilhelmsson skrev 25/3/13 5:29 PM:
>>> Hi,
>>>
>>> Sorry for cross posting, but I think this could be useful for several
>>> areas.
>>>
>>> I would like to add Solaris Studio / NetBeans project files for the
>>> entire
>>> OpenJDK project. To clarify: One project that contains the entire
>>> OpenJDK.
>>>
>>>
>>> With the new build infrastructure in JDK 8 building the entire OpenJDK
>>> is fairly
>>> fast and even though I personally mostly work in the HotSpot tree, I
>>> tend to
>>> always clone and build the entire JDK forest. I find this to have
>>> several benefits.
>>>
>>> Webrev: http://cr.openjdk.java.net/~jwilhelm/7074926/webrev/
>>>
>>> The configuration in this project is currently Mac only. Linux and
>>> Solaris
>>> configurations are also planned.
>>>
>>> The webrev is made from the jdk8/build repository which is where I
>>> think a
>>> change like this should go in. Let me know if you think something else.
>>>
>>>
>>>
>>> To use this project (once pushed):
>>>
>>> 1. Clone your favorite repository
>>>      hg clone http://hg.openjdk.java.net/hsx/hotspot-gc
>>>
>>> 2. Get the whole forest
>>>      cd hotspot-gc
>>>      sh get_source.sh
>>>
>>> 3. Configure
>>>      sh configure
>>>
>>> 4. Open Solaris studio / NetBeans and load the project.
>>>      The project in located in the common directory.
>>>
>>>
>>> Thanks,
>>> /Jesper
>


From alejandro.murillo at oracle.com  Thu Apr 11 06:09:34 2013
From: alejandro.murillo at oracle.com (alejandro.murillo at oracle.com)
Date: Thu, 11 Apr 2013 13:09:34 +0000
Subject: hg: hsx/hsx25/hotspot: 13 new changesets
Message-ID: <20130411131011.7675B48201@hg.openjdk.java.net>

Changeset: dcdeb150988c
Author:    amurillo
Date:      2013-04-04 21:15 -0700
URL:       http://hg.openjdk.java.net/hsx/hsx25/hotspot/rev/dcdeb150988c

8011584: new hotspot build - hs25-b27
Reviewed-by: jcoomes

! make/hotspot_version

Changeset: 3b890cd4da64
Author:    ctornqvi
Date:      2013-04-03 21:41 +0200
URL:       http://hg.openjdk.java.net/hsx/hsx25/hotspot/rev/3b890cd4da64

8009125: Add NMT tests for Virtual Memory operations
Summary: Tests added for Reserve/Commit/Uncommit/Unreserve operations
Reviewed-by: zgu, mgerdin

! src/share/vm/prims/whitebox.cpp
- test/runtime/NMT/AllocTestType.java
+ test/runtime/NMT/MallocTestType.java
+ test/runtime/NMT/ThreadedMallocTestType.java
+ test/runtime/NMT/ThreadedVirtualAllocTestType.java
+ test/runtime/NMT/VirtualAllocTestType.java
! test/testlibrary/OutputAnalyzerTest.java
! test/testlibrary/com/oracle/java/testlibrary/OutputAnalyzer.java
! test/testlibrary/whitebox/sun/hotspot/WhiteBox.java

Changeset: 8554c55669b0
Author:    hseigel
Date:      2013-04-04 08:47 -0400
URL:       http://hg.openjdk.java.net/hsx/hsx25/hotspot/rev/8554c55669b0

8010943: guarantee(length == 0) failed: invalid method ordering length
Summary: Add DumpSharedSpaces to IF condition to handle verify during -Xshare:dump.
Reviewed-by: coleenp, zgu

! src/share/vm/oops/instanceKlass.cpp

Changeset: bad3bed4b323
Author:    ccheung
Date:      2013-03-29 14:18 -0700
URL:       http://hg.openjdk.java.net/hsx/hsx25/hotspot/rev/bad3bed4b323

8006006: [parfait] Memory leak at hotspot/src/share/tools/launcher/wildcard.c
Summary: a simple fix to add FileList_free(fl) before returning NULL.
Reviewed-by: zgu, coleenp, minqi

! src/share/tools/launcher/wildcard.c

Changeset: 17bf4d428955
Author:    ccheung
Date:      2013-04-03 16:43 -0700
URL:       http://hg.openjdk.java.net/hsx/hsx25/hotspot/rev/17bf4d428955

8006103: [parfait] Possible null pointer dereference at hotspot/src/os/linux/vm/os_linux.cpp; os_windows.cpp; os_solaris.cpp; os_bsd.cpp
Reviewed-by: zgu, iklam

! src/os/bsd/vm/os_bsd.cpp
! src/os/linux/vm/os_linux.cpp
! src/os/solaris/vm/os_solaris.cpp
! src/os/windows/vm/os_windows.cpp

Changeset: cc32ccaaf47f
Author:    mikael
Date:      2013-04-04 10:01 -0700
URL:       http://hg.openjdk.java.net/hsx/hsx25/hotspot/rev/cc32ccaaf47f

8003310: Enable -Wunused-function when compiling with gcc
Summary: Add the -Wunused-function flag and remove a number of unused functions.
Reviewed-by: dholmes, coleenp, kvn

! make/linux/makefiles/gcc.make
! src/cpu/x86/vm/assembler_x86.cpp
! src/cpu/x86/vm/methodHandles_x86.cpp
! src/cpu/x86/vm/x86_64.ad
! src/os/bsd/vm/os_bsd.cpp
! src/os/linux/vm/os_linux.cpp
! src/os/solaris/vm/os_solaris.cpp
! src/share/vm/c1/c1_LIRGenerator.cpp
! src/share/vm/compiler/compileLog.cpp
! src/share/vm/compiler/compilerOracle.cpp
! src/share/vm/gc_implementation/g1/g1CollectorPolicy.cpp
! src/share/vm/gc_implementation/g1/ptrQueue.cpp
! src/share/vm/interpreter/interpreterRuntime.cpp
! src/share/vm/memory/heap.cpp
! src/share/vm/memory/universe.cpp
! src/share/vm/oops/constantPool.cpp
! src/share/vm/opto/block.cpp
! src/share/vm/opto/compile.cpp
! src/share/vm/opto/connode.cpp
! src/share/vm/opto/subnode.cpp
! src/share/vm/prims/jni.cpp
! src/share/vm/prims/jniCheck.hpp
! src/share/vm/runtime/arguments.cpp
! src/share/vm/runtime/safepoint.cpp
! src/share/vm/runtime/synchronizer.cpp
! src/share/vm/runtime/synchronizer.hpp
! src/share/vm/utilities/debug.cpp
! src/share/vm/utilities/globalDefinitions.cpp
! src/share/vm/utilities/globalDefinitions.hpp

Changeset: 4c8bb5e4f68f
Author:    zgu
Date:      2013-04-05 12:19 -0400
URL:       http://hg.openjdk.java.net/hsx/hsx25/hotspot/rev/4c8bb5e4f68f

8011161: NMT: Memory leak when encountering out of memory error while initializing memory snapshot
Summary: Fix memory leaks when NMT fails to initialize snapshot and worker thread
Reviewed-by: dcubed, ccheung, rdurbin

! src/share/vm/services/memTracker.cpp

Changeset: 8be1318fbe77
Author:    dcubed
Date:      2013-04-05 10:38 -0700
URL:       http://hg.openjdk.java.net/hsx/hsx25/hotspot/rev/8be1318fbe77

Merge

! src/cpu/x86/vm/x86_64.ad
! src/os/bsd/vm/os_bsd.cpp
! src/os/linux/vm/os_linux.cpp
! src/os/solaris/vm/os_solaris.cpp
! src/os/windows/vm/os_windows.cpp
! src/share/vm/c1/c1_LIRGenerator.cpp
! src/share/vm/memory/universe.cpp
! src/share/vm/oops/instanceKlass.cpp
! src/share/vm/runtime/arguments.cpp
- test/runtime/NMT/AllocTestType.java

Changeset: 46d24f112c27
Author:    dcubed
Date:      2013-04-05 16:16 -0700
URL:       http://hg.openjdk.java.net/hsx/hsx25/hotspot/rev/46d24f112c27

Merge

- make/bsd/build.sh
- make/linux/build.sh
- make/solaris/build.sh

Changeset: 4b7cf00ccb08
Author:    ccheung
Date:      2013-04-05 11:15 -0700
URL:       http://hg.openjdk.java.net/hsx/hsx25/hotspot/rev/4b7cf00ccb08

8006001: [parfait] Possible file leak in hotspot/src/os/linux/vm/perfMemory_linux.cpp
Reviewed-by: zgu, coleenp, hseigel, dholmes

! src/os/bsd/vm/perfMemory_bsd.cpp
! src/os/linux/vm/perfMemory_linux.cpp
! src/os/solaris/vm/perfMemory_solaris.cpp
! src/os/windows/vm/perfMemory_windows.cpp

Changeset: b933e75e7cbe
Author:    zgu
Date:      2013-04-05 23:10 -0700
URL:       http://hg.openjdk.java.net/hsx/hsx25/hotspot/rev/b933e75e7cbe

Merge


Changeset: 09b0d3e9ba6c
Author:    bharadwaj
Date:      2013-04-09 08:52 -0700
URL:       http://hg.openjdk.java.net/hsx/hsx25/hotspot/rev/09b0d3e9ba6c

8011671: JCK tests on static interface methods fail under b84: Illegal type at constant pool entry 5
Summary: Restore incorrect removal of support for static interface method verification in Java 8
Reviewed-by: kvn, coleenp

! src/share/vm/classfile/verifier.cpp

Changeset: 9b4a6a172a8a
Author:    amurillo
Date:      2013-04-11 01:03 -0700
URL:       http://hg.openjdk.java.net/hsx/hsx25/hotspot/rev/9b4a6a172a8a

Added tag hs25-b27 for changeset 09b0d3e9ba6c

! .hgtags


From alejandro.murillo at oracle.com  Thu Apr 11 06:33:20 2013
From: alejandro.murillo at oracle.com (alejandro.murillo at oracle.com)
Date: Thu, 11 Apr 2013 13:33:20 +0000
Subject: hg: hsx/hotspot-main/hotspot: 2 new changesets
Message-ID: <20130411133328.2EB0348204@hg.openjdk.java.net>

Changeset: 9b4a6a172a8a
Author:    amurillo
Date:      2013-04-11 01:03 -0700
URL:       http://hg.openjdk.java.net/hsx/hotspot-main/hotspot/rev/9b4a6a172a8a

Added tag hs25-b27 for changeset 09b0d3e9ba6c

! .hgtags

Changeset: e437668ced9d
Author:    amurillo
Date:      2013-04-11 01:14 -0700
URL:       http://hg.openjdk.java.net/hsx/hotspot-main/hotspot/rev/e437668ced9d

8011948: new hotspot build - hs25-b28
Reviewed-by: jcoomes

! make/hotspot_version


From mikael.gerdin at oracle.com  Thu Apr 11 07:02:20 2013
From: mikael.gerdin at oracle.com (mikael.gerdin at oracle.com)
Date: Thu, 11 Apr 2013 14:02:20 +0000
Subject: hg: hsx/hsx24/hotspot: 8006753: fix failed for JDK-8002415 White box
	testing API for HotSpot
Message-ID: <20130411140228.83EDE48206@hg.openjdk.java.net>

Changeset: 8185d3f3d16e
Author:    mgerdin
Date:      2013-04-10 17:30 +0200
URL:       http://hg.openjdk.java.net/hsx/hsx24/hotspot/rev/8185d3f3d16e

8006753: fix failed for JDK-8002415 White box testing API for HotSpot
Summary: Modify WhiteBoxAPI to use interface classes from test/testlibrary instead, add ClassFileInstaller to resolve the boot class path issue
Reviewed-by: ctornqvi, dsamersoff, coleenp, kvn

! make/Makefile
! make/bsd/makefiles/defs.make
! make/bsd/makefiles/vm.make
- make/bsd/makefiles/wb.make
! make/linux/makefiles/defs.make
! make/linux/makefiles/vm.make
- make/linux/makefiles/wb.make
! make/solaris/makefiles/defs.make
! make/solaris/makefiles/vm.make
- make/solaris/makefiles/wb.make
! make/windows/makefiles/debug.make
! make/windows/makefiles/defs.make
! make/windows/makefiles/fastdebug.make
! make/windows/makefiles/product.make
- make/windows/makefiles/wb.make
- src/share/tools/whitebox/sun/hotspot/WhiteBox.java
- src/share/tools/whitebox/sun/hotspot/parser/DiagnosticCommand.java
! src/share/vm/runtime/arguments.cpp
! test/runtime/NMT/AllocTestType.java
! test/runtime/NMT/PrintNMTStatistics.java
! test/runtime/NMT/SummarySanityCheck.java
! test/sanity/WBApi.java
! test/serviceability/ParserTest.java
+ test/testlibrary/ClassFileInstaller.java
+ test/testlibrary/whitebox/sun/hotspot/WhiteBox.java
+ test/testlibrary/whitebox/sun/hotspot/parser/DiagnosticCommand.java


From vladimir.kozlov at oracle.com  Thu Apr 11 08:42:05 2013
From: vladimir.kozlov at oracle.com (Vladimir Kozlov)
Date: Thu, 11 Apr 2013 08:42:05 -0700
Subject: RFR(M) : 7104565 : trim jprt build targets
In-Reply-To: 
References: <7C7CBBE7-2651-4F94-820A-C68378C46AA9@oracle.com>
	<515D27BD.7010006@oracle.com>
	
	<516059C8.3020008@oracle.com>
	
	<51648769.7000809@oracle.com>
	<293891EC-45D0-4549-BD66-3605C6E757EC@oracle.com>
	<5164CF94.4000005@oracle.com> <5164D7D8.5080206@oracle.com>
	<5164E608.8020003@oracle.com> <5164ED8D.8080107@oracle.com>
	<5164F9DA.1010506@oracle.com> <51650725.8070007@oracle.com>
	<8D328CD6-DF49-4F09-8471-B76B06767F32@oracle.com>
	<51658FB9.6070607@oracle.com>
	
Message-ID: <5166D9CD.7080304@oracle.com>

Good.

Thanks,
Vladimir

On 4/11/13 5:46 AM, David Chase wrote:
> http://cr.openjdk.java.net/~drchase/7104565/webrev.07/
>
>   jvmgminimal1_warn added.
>   llvmHeaders.hpp reverted.
>
>

From nils.eliasson at oracle.com  Thu Apr 11 10:09:00 2013
From: nils.eliasson at oracle.com (nils.eliasson at oracle.com)
Date: Thu, 11 Apr 2013 17:09:00 +0000
Subject: hg: hsx/hsx24/hotspot: 3 new changesets
Message-ID: <20130411170914.173784820F@hg.openjdk.java.net>

Changeset: d67b08a0b6c0
Author:    neliasso
Date:      2013-03-25 14:03 +0100
URL:       http://hg.openjdk.java.net/hsx/hsx24/hotspot/rev/d67b08a0b6c0

8007701: Hotspot trace allocation events
Reviewed-by: brutisso, ehelin, egahlin

+ src/share/vm/gc_interface/allocTracer.cpp
+ src/share/vm/gc_interface/allocTracer.hpp
! src/share/vm/gc_interface/collectedHeap.cpp
! src/share/vm/gc_interface/collectedHeap.hpp
! src/share/vm/gc_interface/collectedHeap.inline.hpp
! src/share/vm/trace/trace.xml

Changeset: d44caacedf85
Author:    neliasso
Date:      2013-04-11 04:25 -0400
URL:       http://hg.openjdk.java.net/hsx/hsx24/hotspot/rev/d44caacedf85

Merge

! src/share/vm/trace/trace.xml

Changeset: e40faea12793
Author:    neliasso
Date:      2013-04-11 10:10 -0400
URL:       http://hg.openjdk.java.net/hsx/hsx24/hotspot/rev/e40faea12793

Merge



From Ulf.Zibis at CoSoCo.de  Thu Apr 11 10:17:13 2013
From: Ulf.Zibis at CoSoCo.de (Ulf Zibis)
Date: Thu, 11 Apr 2013 19:17:13 +0200
Subject: RFR: Project files for Solaris Studio / NetBeans
In-Reply-To: <5166B3E1.1060104@oracle.com>
References: <51507B60.6030809@oracle.com> <51531883.7070903@oracle.com>
	<5166AB5B.5050403@oracle.com> <5166B3E1.1060104@oracle.com>
Message-ID: <5166F019.9010904@CoSoCo.de>

Am 11.04.2013 15:00, schrieb Vladimir Voskresensky:
>> If yes - is it possible to rename it to OpenJDK_Native or create
>> common/netbeans/native/OpenJDK to avoid any misunderstanding and future
>> name conflicts?
> what about simpler layout:
> common/native_project
> (or make/native_project)
> otherwise developer have to go several levels down: common, netbeans, native, OpenJDK

I think "netbeans" should not be dropped in the path, as there are other concurrent IDE's in the world.
I also see the possibility of an extra path:
ide/netbeans/...
tools/netbeans/...
devtools/netbeans/...
...

The latter could be used for different development help tools, e.g. webrev

-Ulf

From coleen.phillimore at oracle.com  Thu Apr 11 13:52:39 2013
From: coleen.phillimore at oracle.com (Coleen Phillimore)
Date: Thu, 11 Apr 2013 16:52:39 -0400
Subject: RFR (S): 8011803: release_C_heap_structures is never called for
	anonymous classes.
Message-ID: <51672297.3080503@oracle.com>

Summary: Call this function from CLD::unload()  now for anonymous classes.

Anonymous classes aren't in the system dictionary so 
release_C_heap_structures isn't called for them if they are unloaded.  I 
fixed this for jdk8 because they are in the class loader data graph but 
for jdk7, I don't know how to fix this.  They are unloaded by being 
garbage collected after the references are dropped.

Tested with ute tests vm.mvlm.testlist nsk.monitoring.testlist and 
jdk/test/java/lang/invoke tests.

open webrev at http://cr.openjdk.java.net/~coleenp/8011803/
bug link at http://bugs.sun.com/view_bug.do?bug_id=8011803

Thanks,
Coleen

From mikael.gerdin at oracle.com  Thu Apr 11 15:08:27 2013
From: mikael.gerdin at oracle.com (mikael.gerdin at oracle.com)
Date: Thu, 11 Apr 2013 22:08:27 +0000
Subject: hg: hsx/hotspot-main/hotspot: 7 new changesets
Message-ID: <20130411220848.EC75D48225@hg.openjdk.java.net>

Changeset: 68fe50d4f1d5
Author:    johnc
Date:      2013-04-05 10:20 -0700
URL:       http://hg.openjdk.java.net/hsx/hotspot-main/hotspot/rev/68fe50d4f1d5

8011343: Add new flag for verifying the heap during startup
Summary: Perform verification during VM startup under control of new flag and within a VMOperation.
Reviewed-by: stefank, jmasa, brutisso

! src/share/vm/classfile/systemDictionary.cpp
! src/share/vm/memory/genCollectedHeap.cpp
! src/share/vm/runtime/arguments.cpp
! src/share/vm/runtime/globals.hpp
! src/share/vm/runtime/thread.cpp
! src/share/vm/runtime/vm_operations.cpp
! src/share/vm/runtime/vm_operations.hpp
- test/gc/TestVerifyBeforeGCDuringStartup.java
+ test/gc/TestVerifyDuringStartup.java

Changeset: 8617e38bb4cb
Author:    jmasa
Date:      2013-02-11 10:31 -0800
URL:       http://hg.openjdk.java.net/hsx/hotspot-main/hotspot/rev/8617e38bb4cb

8008508: CMS does not correctly reduce heap size after a Full GC
Reviewed-by: johnc, ysr

! src/share/vm/gc_implementation/concurrentMarkSweep/concurrentMarkSweepGeneration.cpp
! src/share/vm/gc_implementation/concurrentMarkSweep/concurrentMarkSweepGeneration.hpp
! src/share/vm/memory/generation.cpp
! src/share/vm/memory/generation.hpp
! src/share/vm/memory/tenuredGeneration.cpp
! src/share/vm/memory/tenuredGeneration.hpp
! src/share/vm/runtime/vmStructs.cpp

Changeset: 83f27710f5f7
Author:    brutisso
Date:      2013-04-08 07:49 +0200
URL:       http://hg.openjdk.java.net/hsx/hotspot-main/hotspot/rev/83f27710f5f7

7197666: java -d64 -version core dumps in a box with lots of memory
Summary: Allow task queues to be mmapped instead of malloced on Solaris
Reviewed-by: coleenp, jmasa, johnc, tschatzl

! src/share/vm/memory/allocation.hpp
! src/share/vm/memory/allocation.inline.hpp
! src/share/vm/runtime/globals.hpp
! src/share/vm/utilities/taskqueue.hpp

Changeset: 63f57a8c5283
Author:    mgerdin
Date:      2013-04-09 15:32 +0200
URL:       http://hg.openjdk.java.net/hsx/hotspot-main/hotspot/rev/63f57a8c5283

8009808: TEST-BUG : test case is using bash style tests. Default shell for jtreg is bourne. thus failure
Summary: Rewrite test to use Java only instead of shell script
Reviewed-by: mgerdin, brutisso
Contributed-by: leonid.mesnik at oracle.com

+ test/gc/6941923/Test6941923.java
- test/gc/6941923/test6941923.sh

Changeset: ba42fd5e00e6
Author:    mgerdin
Date:      2013-04-10 13:27 +0200
URL:       http://hg.openjdk.java.net/hsx/hotspot-main/hotspot/rev/ba42fd5e00e6

8010196: NPG: Internal Error: Metaspace allocation lock -- possible deadlock
Summary: Refactor the CLD dependency list into a separate class. Use an ObjectLocker to synchronize additions to the CLD dependency list.
Reviewed-by: stefank, coleenp

! src/share/vm/classfile/classLoaderData.cpp
! src/share/vm/classfile/classLoaderData.hpp
+ test/gc/metaspace/G1AddMetaspaceDependency.java

Changeset: 7b835924c31c
Author:    stefank
Date:      2013-04-10 14:26 +0200
URL:       http://hg.openjdk.java.net/hsx/hotspot-main/hotspot/rev/7b835924c31c

8011872: Include Bit Map addresses in the hs_err files
Reviewed-by: brutisso, jmasa

! src/share/vm/gc_implementation/concurrentMarkSweep/concurrentMarkSweepGeneration.cpp
! src/share/vm/gc_implementation/concurrentMarkSweep/concurrentMarkSweepGeneration.hpp
! src/share/vm/gc_implementation/g1/concurrentMark.cpp
! src/share/vm/gc_implementation/g1/concurrentMark.hpp
! src/share/vm/gc_implementation/g1/g1CollectedHeap.cpp
! src/share/vm/gc_implementation/g1/g1CollectedHeap.hpp
! src/share/vm/gc_implementation/parallelScavenge/parMarkBitMap.hpp
! src/share/vm/gc_implementation/parallelScavenge/parallelScavengeHeap.cpp
! src/share/vm/gc_implementation/parallelScavenge/parallelScavengeHeap.hpp
! src/share/vm/gc_implementation/parallelScavenge/psParallelCompact.cpp
! src/share/vm/gc_implementation/parallelScavenge/psParallelCompact.hpp
! src/share/vm/gc_interface/collectedHeap.hpp
! src/share/vm/memory/genCollectedHeap.cpp
! src/share/vm/memory/genCollectedHeap.hpp
! src/share/vm/utilities/bitMap.cpp
! src/share/vm/utilities/bitMap.hpp
! src/share/vm/utilities/vmError.cpp

Changeset: 480d934f62a8
Author:    mgerdin
Date:      2013-04-11 16:35 +0200
URL:       http://hg.openjdk.java.net/hsx/hotspot-main/hotspot/rev/480d934f62a8

Merge

! src/share/vm/runtime/arguments.cpp
- test/runtime/NMT/AllocTestType.java


From jesper.wilhelmsson at oracle.com  Thu Apr 11 16:05:44 2013
From: jesper.wilhelmsson at oracle.com (jesper.wilhelmsson at oracle.com)
Date: Thu, 11 Apr 2013 23:05:44 +0000
Subject: hg: hsx/hsx24/hotspot: 8009032: Implement evacuation info event
Message-ID: <20130411230552.5D42D48227@hg.openjdk.java.net>

Changeset: 7097a4e746c1
Author:    jwilhelm
Date:      2013-04-11 13:43 +0200
URL:       http://hg.openjdk.java.net/hsx/hsx24/hotspot/rev/7097a4e746c1

8009032: Implement evacuation info event
Summary: EvacuationFailedInfo event implemented for G1
Reviewed-by: brutisso, johnc

+ src/share/vm/gc_implementation/g1/evacuationInfo.hpp
! src/share/vm/gc_implementation/g1/g1CollectedHeap.cpp
! src/share/vm/gc_implementation/g1/g1CollectedHeap.hpp
! src/share/vm/gc_implementation/g1/g1CollectorPolicy.cpp
! src/share/vm/gc_implementation/g1/g1CollectorPolicy.hpp
! src/share/vm/gc_implementation/shared/gcTrace.cpp
! src/share/vm/gc_implementation/shared/gcTrace.hpp
! src/share/vm/gc_implementation/shared/gcTraceSend.cpp
! src/share/vm/trace/trace.xml


From serguei.spitsyn at oracle.com  Thu Apr 11 16:08:30 2013
From: serguei.spitsyn at oracle.com (serguei.spitsyn at oracle.com)
Date: Thu, 11 Apr 2013 16:08:30 -0700
Subject: hs25 review request (round 2): 8007037 JSR 292: the
	VM_RedefineClasses::append_entry()
	should do cross-checks with indy operands
Message-ID: <5167426E.6020502@oracle.com>

Please, review the hs25 fix (round 2) below.

Open webrev:
http://cr.openjdk.java.net/~sspitsyn/webrevs/2013/hotspot/8007037-JVMTI-JSR292.2/

CR:
http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=8007037
https://jbs.oracle.com/bugs/browse/JDK-8007037


This webrev includes a review fix from Coleen about explicit deallocation
of the old operands array in ConstantPool::resize_operands() and a couple
of fixes for the corner case when the old CP has no operands array:

1121 void ConstantPool::extend_operands(constantPoolHandle ext_cp, TRAPS) {
. . .
1130   if (operand_array_length(operands()) == 0) {
1131     ClassLoaderData* loader_data = pool_holder()->class_loader_data();
1132     Array* new_ops = MetadataFactory::new_array(loader_data, delta_size, CHECK);
1133     // The first element index defines the offset of second part
+        operand_offset_at_put(new_ops, 0, 2*delta_len); // offset in new array
1135     set_operands(new_ops);
1136   } else {
1137     resize_operands(delta_len, delta_size, CHECK);
1138   }
1139
1140 } // end extend_operands()


  void VM_RedefineClasses::append_operand(constantPoolHandle scratch_cp, int old_bs_i,
  505        constantPoolHandle *merge_cp_p, int *merge_cp_length_p, TRAPS) {
  . . .

  - 518   int new_base = (*merge_cp_p)->operand_next_offset_at(new_bs_i);

--

  + 518   // We have _operands_cur_length == 0 when the merge_cp operands is empty yet.
  + 519   // However, the operand_offset_at(0) was set in the extend_operands() call.
  + 520   int new_base = (new_bs_i == 0) ? (*merge_cp_p)->operand_offset_at(0)
  + 521                                  : (*merge_cp_p)->operand_next_offset_at(new_bs_i - 1);



Description:

References from INDY bootstrap method specifier operands to CP entries
and back must be correctly merged at class redefinition.

Some background.

An invokedynamic bytecode spec:
http://docs.oracle.com/javase/specs/jvms/se7/html/jvms-6.html#jvms-6.5.invokedynamic

A invokedynamic instruction has an argument which is an index to the 
*Constant Pool* item.
That index must be a symbolic reference to a *call-site specifier*:
http://docs.oracle.com/javase/specs/jvms/se7/html/jvms-4.html#jvms-4.4.10

A CP item of the type *CONSTANT_InvokeDynamic_inf* has an index into
the *bootstrap method attribute* of the class file:
http://docs.oracle.com/javase/specs/jvms/se7/html/jvms-4.html#jvms-4.7.21

The *|BootstrapMethods|* attribute elements normally have references to 
other *Constant Pool* items.

In VM the *bootstrap method attribute* is represented by the *operands* 
array of the *ConstantPool*.

The problem is is that all the force and back cross links between 
*ConstantPool* elements
and *operands* array elements must be correctly merged at class 
redefinition.

Test coverage:
   vm.mlvm, nsk.jvmti, nsk.jdi tests on multiple platforms (32 vs 64-bit 
too).
   The testing looks good so far.
   One difficulty is that new vm.mlvm tests are currently failed because 
of multiple reasons.


Thanks,
Serguei

From david.holmes at oracle.com  Thu Apr 11 19:07:48 2013
From: david.holmes at oracle.com (David Holmes)
Date: Fri, 12 Apr 2013 12:07:48 +1000
Subject: RFR(M) : 7104565 : trim jprt build targets
In-Reply-To: 
References: <7C7CBBE7-2651-4F94-820A-C68378C46AA9@oracle.com>
	<515D27BD.7010006@oracle.com>
	
	<516059C8.3020008@oracle.com>
	
	<51648769.7000809@oracle.com>
	<293891EC-45D0-4549-BD66-3605C6E757EC@oracle.com>
	<5164CF94.4000005@oracle.com> <5164D7D8.5080206@oracle.com>
	<5164E608.8020003@oracle.com> <5164ED8D.8080107@oracle.com>
	<5164F9DA.1010506@oracle.com> <51650725.8070007@oracle.com>
	<8D328CD6-DF49-4F09-8471-B76B06767F32@oracle.com>
	<51658FB9.6070607@oracle.com>
	
Message-ID: <51676C74.4020901@oracle.com>

Okay.

Thanks,
David

On 11/04/2013 10:46 PM, David Chase wrote:
> http://cr.openjdk.java.net/~drchase/7104565/webrev.07/
>
>   jvmgminimal1_warn added.
>   llvmHeaders.hpp reverted.
>
>

From david.holmes at oracle.com  Thu Apr 11 19:21:12 2013
From: david.holmes at oracle.com (David Holmes)
Date: Fri, 12 Apr 2013 12:21:12 +1000
Subject: RFR (S): 8011803: release_C_heap_structures is never called for
	anonymous classes.
In-Reply-To: <51672297.3080503@oracle.com>
References: <51672297.3080503@oracle.com>
Message-ID: <51676F98.8030109@oracle.com>

Hi Coleen,

Can you clarify something for me please. ClassLoaderData::unload() is 
what now cleans up the anonymous classes - correct? But 
ClassLoaderData::unload() is only called when the ClassLoader is 
unloaded - correct? And the whole point of anonymous classes is that 
they get unloaded independent of the classloader lifecycle. Assuming I'm 
correct so far it seems to me that if the classloader is never unloaded, 
the anonymous classes still won't have release_C_heap_structures called. 
And if it is unloaded it could be well after the classes were unloaded.

David

On 12/04/2013 6:52 AM, Coleen Phillimore wrote:
> Summary: Call this function from CLD::unload()  now for anonymous classes.
>
> Anonymous classes aren't in the system dictionary so
> release_C_heap_structures isn't called for them if they are unloaded.  I
> fixed this for jdk8 because they are in the class loader data graph but
> for jdk7, I don't know how to fix this.  They are unloaded by being
> garbage collected after the references are dropped.
>
> Tested with ute tests vm.mvlm.testlist nsk.monitoring.testlist and
> jdk/test/java/lang/invoke tests.
>
> open webrev at http://cr.openjdk.java.net/~coleenp/8011803/
> bug link at http://bugs.sun.com/view_bug.do?bug_id=8011803
>
> Thanks,
> Coleen

From john.coomes at oracle.com  Thu Apr 11 20:32:47 2013
From: john.coomes at oracle.com (john.coomes at oracle.com)
Date: Fri, 12 Apr 2013 03:32:47 +0000
Subject: hg: hsx/hotspot-main/jaxp: Added tag jdk8-b85 for changeset
	41b50e2c5ea3
Message-ID: <20130412033259.74E474823D@hg.openjdk.java.net>

Changeset: ca71ec37b2ef
Author:    katleman
Date:      2013-04-11 09:40 -0700
URL:       http://hg.openjdk.java.net/hsx/hotspot-main/jaxp/rev/ca71ec37b2ef

Added tag jdk8-b85 for changeset 41b50e2c5ea3

! .hgtags


From john.coomes at oracle.com  Thu Apr 11 20:33:05 2013
From: john.coomes at oracle.com (john.coomes at oracle.com)
Date: Fri, 12 Apr 2013 03:33:05 +0000
Subject: hg: hsx/hotspot-main/jaxws: Added tag jdk8-b85 for changeset
	8c0b6bccfe47
Message-ID: <20130412033311.9C6674823E@hg.openjdk.java.net>

Changeset: 26c840af7720
Author:    katleman
Date:      2013-04-11 09:40 -0700
URL:       http://hg.openjdk.java.net/hsx/hotspot-main/jaxws/rev/26c840af7720

Added tag jdk8-b85 for changeset 8c0b6bccfe47

! .hgtags


From john.coomes at oracle.com  Thu Apr 11 20:32:34 2013
From: john.coomes at oracle.com (john.coomes at oracle.com)
Date: Fri, 12 Apr 2013 03:32:34 +0000
Subject: hg: hsx/hotspot-main: 9 new changesets
Message-ID: <20130412033235.15ABE4823B@hg.openjdk.java.net>

Changeset: 52d1b385a4ed
Author:    erikj
Date:      2013-04-04 09:24 +0200
URL:       http://hg.openjdk.java.net/hsx/hotspot-main/rev/52d1b385a4ed

8006828: "SKIP_BOOT_CYCLE=false" must work in new building infrastructure
Reviewed-by: tbell, alanb

! common/autoconf/bootcycle-spec.gmk.in
! common/autoconf/spec.gmk.in
! common/makefiles/Jprt.gmk
! common/makefiles/Main.gmk

Changeset: 2d4156e077fa
Author:    erikj
Date:      2013-04-04 09:25 +0200
URL:       http://hg.openjdk.java.net/hsx/hotspot-main/rev/2d4156e077fa

8011372: Remove -p from cp in IdleCompilation.gmk
Reviewed-by: pliden, tbell

! common/makefiles/IdlCompilation.gmk

Changeset: 3b8ffb80db0f
Author:    erikj
Date:      2013-04-05 09:38 +0200
URL:       http://hg.openjdk.java.net/hsx/hotspot-main/rev/3b8ffb80db0f

8008373: JFR JTReg tests fail with CompilationError on MacOSX; missing '._sunec.jar'
Reviewed-by: tbell

! common/autoconf/basics.m4
! common/autoconf/generated-configure.sh
! common/autoconf/spec.gmk.in
! common/makefiles/MakeBase.gmk

Changeset: 653ff6bcf0b1
Author:    omajid
Date:      2013-04-08 14:07 -0400
URL:       http://hg.openjdk.java.net/hsx/hotspot-main/rev/653ff6bcf0b1

8011388: Support building zero and zeroshark with the new build
Reviewed-by: andrew, dholmes, erikj
Contributed-by: Omair Majid , Roman Kennke 

! common/autoconf/generated-configure.sh
! common/autoconf/hotspot-spec.gmk.in
! common/autoconf/jdk-options.m4
! common/autoconf/libraries.m4
! common/autoconf/platform.m4
! common/autoconf/spec.gmk.in

Changeset: 2f43964043c2
Author:    erikj
Date:      2013-04-09 09:42 +0200
URL:       http://hg.openjdk.java.net/hsx/hotspot-main/rev/2f43964043c2

8006288: build-infra: Use solaris nm and not gnm on solaris
Reviewed-by: tbell

! common/autoconf/compare.sh.in
! common/autoconf/generated-configure.sh
! common/autoconf/spec.gmk.in
! common/autoconf/toolchain.m4

Changeset: 2ef28c12d649
Author:    erikj
Date:      2013-04-09 09:45 +0200
URL:       http://hg.openjdk.java.net/hsx/hotspot-main/rev/2ef28c12d649

8010465: Can't enable sjavac when building in jprt.
Reviewed-by: ohair, tbell

! common/makefiles/JavaCompilation.gmk
! common/makefiles/Jprt.gmk
! common/makefiles/MakeBase.gmk
! common/makefiles/MakeHelpers.gmk

Changeset: a09e9c9ca963
Author:    tbell
Date:      2013-04-09 13:05 -0700
URL:       http://hg.openjdk.java.net/hsx/hotspot-main/rev/a09e9c9ca963

8011348: use of which in common/autoconf/autogen.sh is not portable
Reviewed-by: erikj, katleman, mduigou

! common/autoconf/autogen.sh

Changeset: 7fc358f59436
Author:    katleman
Date:      2013-04-09 15:16 -0700
URL:       http://hg.openjdk.java.net/hsx/hotspot-main/rev/7fc358f59436

Merge


Changeset: 44bc9bc4da4d
Author:    katleman
Date:      2013-04-11 09:39 -0700
URL:       http://hg.openjdk.java.net/hsx/hotspot-main/rev/44bc9bc4da4d

Added tag jdk8-b85 for changeset 7fc358f59436

! .hgtags


From john.coomes at oracle.com  Thu Apr 11 20:32:38 2013
From: john.coomes at oracle.com (john.coomes at oracle.com)
Date: Fri, 12 Apr 2013 03:32:38 +0000
Subject: hg: hsx/hotspot-main/corba: Added tag jdk8-b85 for changeset
	9583a6431596
Message-ID: <20130412033242.AC8024823C@hg.openjdk.java.net>

Changeset: 44a8ce4a759f
Author:    katleman
Date:      2013-04-11 09:39 -0700
URL:       http://hg.openjdk.java.net/hsx/hotspot-main/corba/rev/44a8ce4a759f

Added tag jdk8-b85 for changeset 9583a6431596

! .hgtags


From john.coomes at oracle.com  Thu Apr 11 20:33:21 2013
From: john.coomes at oracle.com (john.coomes at oracle.com)
Date: Fri, 12 Apr 2013 03:33:21 +0000
Subject: hg: hsx/hotspot-main/jdk: 4 new changesets
Message-ID: <20130412033516.CC50C4823F@hg.openjdk.java.net>

Changeset: e22961ea91bd
Author:    erikj
Date:      2013-04-05 09:39 +0200
URL:       http://hg.openjdk.java.net/hsx/hotspot-main/jdk/rev/e22961ea91bd

8008373: JFR JTReg tests fail with CompilationError on MacOSX; missing '._sunec.jar'
Reviewed-by: tbell

! makefiles/CompileDemos.gmk
! makefiles/CompileJavaClasses.gmk
! makefiles/CompileLaunchers.gmk
! makefiles/CompileNativeLibraries.gmk
! makefiles/CopyFiles.gmk
! makefiles/CopyIntoClasses.gmk
! makefiles/CopySamples.gmk
! makefiles/GendataFontConfig.gmk
! makefiles/GensrcCharacterData.gmk
! makefiles/GensrcMisc.gmk
! makefiles/GensrcSwing.gmk
! makefiles/SignJars.gmk
! makefiles/Tools.gmk

Changeset: fddd158b872a
Author:    omajid
Date:      2013-04-08 14:09 -0400
URL:       http://hg.openjdk.java.net/hsx/hotspot-main/jdk/rev/fddd158b872a

8011388: Support building zero and zeroshark with the new build
Reviewed-by: andrew, dholmes, erikj
Contributed-by: Omair Majid , Roman Kennke 

! makefiles/Profiles.gmk

Changeset: 296676d534c5
Author:    katleman
Date:      2013-04-09 15:17 -0700
URL:       http://hg.openjdk.java.net/hsx/hotspot-main/jdk/rev/296676d534c5

Merge


Changeset: 081327aac5be
Author:    katleman
Date:      2013-04-11 09:40 -0700
URL:       http://hg.openjdk.java.net/hsx/hotspot-main/jdk/rev/081327aac5be

Added tag jdk8-b85 for changeset 296676d534c5

! .hgtags


From john.coomes at oracle.com  Thu Apr 11 20:37:12 2013
From: john.coomes at oracle.com (john.coomes at oracle.com)
Date: Fri, 12 Apr 2013 03:37:12 +0000
Subject: hg: hsx/hotspot-main/langtools: Added tag jdk8-b85 for changeset
	4a48f3173534
Message-ID: <20130412033723.A23AD48240@hg.openjdk.java.net>

Changeset: 2c9acb17f41a
Author:    katleman
Date:      2013-04-11 09:40 -0700
URL:       http://hg.openjdk.java.net/hsx/hotspot-main/langtools/rev/2c9acb17f41a

Added tag jdk8-b85 for changeset 4a48f3173534

! .hgtags


From john.coomes at oracle.com  Thu Apr 11 20:37:30 2013
From: john.coomes at oracle.com (john.coomes at oracle.com)
Date: Fri, 12 Apr 2013 03:37:30 +0000
Subject: hg: hsx/hotspot-main/nashorn: Added tag jdk8-b85 for changeset
	e0378f0a50da
Message-ID: <20130412033732.EB7B848241@hg.openjdk.java.net>

Changeset: aed0529f5f5d
Author:    katleman
Date:      2013-04-11 09:40 -0700
URL:       http://hg.openjdk.java.net/hsx/hotspot-main/nashorn/rev/aed0529f5f5d

Added tag jdk8-b85 for changeset e0378f0a50da

! .hgtags


From bharadwaj.yadavalli at oracle.com  Thu Apr 11 21:16:21 2013
From: bharadwaj.yadavalli at oracle.com (bharadwaj.yadavalli at oracle.com)
Date: Fri, 12 Apr 2013 04:16:21 +0000
Subject: hg: hsx/hotspot-main/hotspot: 8 new changesets
Message-ID: <20130412041654.302114825B@hg.openjdk.java.net>

Changeset: 705ef39fcaa9
Author:    neliasso
Date:      2013-04-05 11:09 +0200
URL:       http://hg.openjdk.java.net/hsx/hotspot-main/hotspot/rev/705ef39fcaa9

8006016: Memory leak at hotspot/src/share/vm/adlc/output_c.cpp
Reviewed-by: kvn, roland
Contributed-by: niclas.adlertz at oracle.com

! src/share/vm/adlc/output_c.cpp
! src/share/vm/adlc/output_h.cpp

Changeset: f67065f02409
Author:    bharadwaj
Date:      2013-04-08 07:40 -0700
URL:       http://hg.openjdk.java.net/hsx/hotspot-main/hotspot/rev/f67065f02409

8010913: compiler/6863420 often exceeds timeout
Summary: add longer timeout for jtreg, add internal timeout thread to prevent spurious timeouts
Reviewed-by: twisti, kvn
Contributed-by: drchase 

! test/compiler/6863420/Test.java

Changeset: b84fd7d73702
Author:    iignatyev
Date:      2013-04-09 09:54 -0700
URL:       http://hg.openjdk.java.net/hsx/hotspot-main/hotspot/rev/b84fd7d73702

8007288: Additional WB API for compiler's testing
Reviewed-by: kvn, vlivanov

! src/share/vm/compiler/compileBroker.cpp
! src/share/vm/oops/method.hpp
! src/share/vm/oops/methodData.cpp
! src/share/vm/oops/methodData.hpp
! src/share/vm/prims/whitebox.cpp
! src/share/vm/runtime/compilationPolicy.cpp
! src/share/vm/runtime/compilationPolicy.hpp
! src/share/vm/utilities/accessFlags.hpp
! src/share/vm/utilities/globalDefinitions.hpp
+ test/compiler/whitebox/ClearMethodStateTest.java
! test/compiler/whitebox/CompilerWhiteBoxTest.java
! test/compiler/whitebox/DeoptimizeAllTest.java
! test/compiler/whitebox/DeoptimizeMethodTest.java
+ test/compiler/whitebox/EnqueueMethodForCompilationTest.java
! test/compiler/whitebox/IsMethodCompilableTest.java
! test/compiler/whitebox/MakeMethodNotCompilableTest.java
! test/compiler/whitebox/SetDontInlineMethodTest.java
+ test/compiler/whitebox/SetForceInlineMethodTest.java
! test/testlibrary/whitebox/sun/hotspot/WhiteBox.java

Changeset: 84ab5667f290
Author:    roland
Date:      2013-04-10 09:52 +0200
URL:       http://hg.openjdk.java.net/hsx/hotspot-main/hotspot/rev/84ab5667f290

8011706: specjvm2008 test xml.transform gets array bound exception with c1
Summary: loop invariant code motion may move load before store to the same field
Reviewed-by: kvn

! src/share/vm/c1/c1_ValueMap.cpp
+ test/compiler/8011706/Test8011706.java

Changeset: d79859ff6535
Author:    kmo
Date:      2013-04-11 07:12 -0700
URL:       http://hg.openjdk.java.net/hsx/hotspot-main/hotspot/rev/d79859ff6535

8011952: Missing ResourceMarks in TraceMethodHandles
Summary: add missing ResourceMark under TraceMethodHandles in LinkResolver
Reviewed-by: dholmes

! src/share/vm/interpreter/linkResolver.cpp

Changeset: 9befe2fce567
Author:    vlivanov
Date:      2013-04-11 09:08 -0700
URL:       http://hg.openjdk.java.net/hsx/hotspot-main/hotspot/rev/9befe2fce567

8011972: Field can be erroneously marked as contended when @Contended annotation isn't present
Reviewed-by: kvn, kmo, shade

! src/share/vm/classfile/classFileParser.cpp
! src/share/vm/classfile/classFileParser.hpp

Changeset: b5db9d29062f
Author:    vlivanov
Date:      2013-04-11 11:42 -0700
URL:       http://hg.openjdk.java.net/hsx/hotspot-main/hotspot/rev/b5db9d29062f

Merge


Changeset: 7a5aec879506
Author:    bharadwaj
Date:      2013-04-11 17:16 -0700
URL:       http://hg.openjdk.java.net/hsx/hotspot-main/hotspot/rev/7a5aec879506

Merge

! src/share/vm/prims/whitebox.cpp
! src/share/vm/utilities/globalDefinitions.hpp
! test/testlibrary/whitebox/sun/hotspot/WhiteBox.java


From bengt.rutisson at oracle.com  Fri Apr 12 01:45:04 2013
From: bengt.rutisson at oracle.com (Bengt Rutisson)
Date: Fri, 12 Apr 2013 10:45:04 +0200
Subject: Naming HotSpot JTReg tests
Message-ID: <5167C990.3040303@oracle.com>


Hi all,

I just added a page to the HotSpot Style Guide [1] to describe how JTReg 
tests should be named:

https://wikis.oracle.com/display/HotSpotInternals/Naming+HotSpot+JTReg+Tests

Thanks,
Bengt


[1] https://wikis.oracle.com/display/HotSpotInternals/StyleGuide

From stefan.karlsson at oracle.com  Fri Apr 12 01:48:12 2013
From: stefan.karlsson at oracle.com (Stefan Karlsson)
Date: Fri, 12 Apr 2013 10:48:12 +0200
Subject: RFR (S): 8011803: release_C_heap_structures is never called for
	anonymous classes.
In-Reply-To: <51672297.3080503@oracle.com>
References: <51672297.3080503@oracle.com>
Message-ID: <5167CA4C.5040608@oracle.com>

On 04/11/2013 10:52 PM, Coleen Phillimore wrote:
> Summary: Call this function from CLD::unload()  now for anonymous 
> classes.
>
> Anonymous classes aren't in the system dictionary so 
> release_C_heap_structures isn't called for them if they are unloaded.  
> I fixed this for jdk8 because they are in the class loader data graph 
> but for jdk7, I don't know how to fix this. They are unloaded by being 
> garbage collected after the references are dropped.
>
> Tested with ute tests vm.mvlm.testlist nsk.monitoring.testlist and 
> jdk/test/java/lang/invoke tests.
>
> open webrev at http://cr.openjdk.java.net/~coleenp/8011803/
> bug link at http://bugs.sun.com/view_bug.do?bug_id=8011803

I've two comments.

1) It's unfortunate that we now call unload_class() at two different 
places in the code. It makes it harder to understand the deallocation of 
metadata. It would be better to keep the calls to unload_class() for 
ordinary InstanceKlasses and anonymous classes together.

2) This change actually breaks the Tracing class unloading event that 
Markus is working on. That code walk the 
ClassLoaderDataGraph::_unloading list in 
ClassLoaderDataGraph::do_unloading and use the information in the 
classes of the CLDs that are about to be unloaded. With this patch they 
probably crash because some pointers in the anonymous classes will be 
trashed.

I have a suggestion on how to solve both points above. It's probably 
easier to show with a pseudo patch:

$ hg diff
diff --git a/src/share/vm/classfile/classLoaderData.cpp 
b/src/share/vm/classfile/classLoaderData.cpp
--- a/src/share/vm/classfile/classLoaderData.cpp
+++ b/src/share/vm/classfile/classLoaderData.cpp
@@ -671,7 +671,6 @@
      }
      seen_dead_loader = true;
      ClassLoaderData* dead = data;
-    dead->unload();
      data = data->next();
      // Remove from loader list.
      if (prev != NULL) {
@@ -683,9 +682,24 @@
      dead->set_next(_unloading);
      _unloading = dead;
    }
+
+  report_class_unloading_info(_unloading);
+
+  ClassLoaderDataGraph::unload_classes();
+
    return seen_dead_loader;
  }

+void ClassLoaderDataGraph::unload_classes() {
+  ClassLoaderData* list = _unloading;
+  ClassLoaderData* next = list;
+  while (next != NULL) {
+    for (Klass* k = next->_klasses; k != NULL; k = k->next_link()) {
+      k->unload_class();
+    }
+  }
+}
+
  void ClassLoaderDataGraph::purge() {
    ClassLoaderData* list = _unloading;
    _unloading = NULL;
diff --git a/src/share/vm/classfile/dictionary.cpp 
b/src/share/vm/classfile/dictionary.cpp
--- a/src/share/vm/classfile/dictionary.cpp
+++ b/src/share/vm/classfile/dictionary.cpp
@@ -157,9 +157,6 @@
              // to be unloaded.
              // Notify the debugger and clean up the class.
              class_was_unloaded = true;
-
-            // perform unloading actions on this class
-            ik->unload_class();
            }
            // Also remove this system dictionary entry.
            purge_entry = true;

As a bonus, the dictionary()->do_unloading() will then only do a simple 
purge of the SystemDictionary.

What do you think?

thanks,
StefanK

>
> Thanks,
> Coleen


From alejandro.murillo at oracle.com  Fri Apr 12 03:28:54 2013
From: alejandro.murillo at oracle.com (alejandro.murillo at oracle.com)
Date: Fri, 12 Apr 2013 10:28:54 +0000
Subject: hg: hsx/hsx25/hotspot: 20 new changesets
Message-ID: <20130412102937.6B18448272@hg.openjdk.java.net>

Changeset: 5dcfeb396fed
Author:    katleman
Date:      2013-04-11 09:39 -0700
URL:       http://hg.openjdk.java.net/hsx/hsx25/hotspot/rev/5dcfeb396fed

Added tag jdk8-b85 for changeset 42fe530cd478

! .hgtags

Changeset: 511e334ee345
Author:    amurillo
Date:      2013-04-11 16:35 -0700
URL:       http://hg.openjdk.java.net/hsx/hsx25/hotspot/rev/511e334ee345

Merge

! .hgtags
- test/runtime/NMT/AllocTestType.java

Changeset: e437668ced9d
Author:    amurillo
Date:      2013-04-11 01:14 -0700
URL:       http://hg.openjdk.java.net/hsx/hsx25/hotspot/rev/e437668ced9d

8011948: new hotspot build - hs25-b28
Reviewed-by: jcoomes

! make/hotspot_version

Changeset: 68fe50d4f1d5
Author:    johnc
Date:      2013-04-05 10:20 -0700
URL:       http://hg.openjdk.java.net/hsx/hsx25/hotspot/rev/68fe50d4f1d5

8011343: Add new flag for verifying the heap during startup
Summary: Perform verification during VM startup under control of new flag and within a VMOperation.
Reviewed-by: stefank, jmasa, brutisso

! src/share/vm/classfile/systemDictionary.cpp
! src/share/vm/memory/genCollectedHeap.cpp
! src/share/vm/runtime/arguments.cpp
! src/share/vm/runtime/globals.hpp
! src/share/vm/runtime/thread.cpp
! src/share/vm/runtime/vm_operations.cpp
! src/share/vm/runtime/vm_operations.hpp
- test/gc/TestVerifyBeforeGCDuringStartup.java
+ test/gc/TestVerifyDuringStartup.java

Changeset: 8617e38bb4cb
Author:    jmasa
Date:      2013-02-11 10:31 -0800
URL:       http://hg.openjdk.java.net/hsx/hsx25/hotspot/rev/8617e38bb4cb

8008508: CMS does not correctly reduce heap size after a Full GC
Reviewed-by: johnc, ysr

! src/share/vm/gc_implementation/concurrentMarkSweep/concurrentMarkSweepGeneration.cpp
! src/share/vm/gc_implementation/concurrentMarkSweep/concurrentMarkSweepGeneration.hpp
! src/share/vm/memory/generation.cpp
! src/share/vm/memory/generation.hpp
! src/share/vm/memory/tenuredGeneration.cpp
! src/share/vm/memory/tenuredGeneration.hpp
! src/share/vm/runtime/vmStructs.cpp

Changeset: 83f27710f5f7
Author:    brutisso
Date:      2013-04-08 07:49 +0200
URL:       http://hg.openjdk.java.net/hsx/hsx25/hotspot/rev/83f27710f5f7

7197666: java -d64 -version core dumps in a box with lots of memory
Summary: Allow task queues to be mmapped instead of malloced on Solaris
Reviewed-by: coleenp, jmasa, johnc, tschatzl

! src/share/vm/memory/allocation.hpp
! src/share/vm/memory/allocation.inline.hpp
! src/share/vm/runtime/globals.hpp
! src/share/vm/utilities/taskqueue.hpp

Changeset: 63f57a8c5283
Author:    mgerdin
Date:      2013-04-09 15:32 +0200
URL:       http://hg.openjdk.java.net/hsx/hsx25/hotspot/rev/63f57a8c5283

8009808: TEST-BUG : test case is using bash style tests. Default shell for jtreg is bourne. thus failure
Summary: Rewrite test to use Java only instead of shell script
Reviewed-by: mgerdin, brutisso
Contributed-by: leonid.mesnik at oracle.com

+ test/gc/6941923/Test6941923.java
- test/gc/6941923/test6941923.sh

Changeset: ba42fd5e00e6
Author:    mgerdin
Date:      2013-04-10 13:27 +0200
URL:       http://hg.openjdk.java.net/hsx/hsx25/hotspot/rev/ba42fd5e00e6

8010196: NPG: Internal Error: Metaspace allocation lock -- possible deadlock
Summary: Refactor the CLD dependency list into a separate class. Use an ObjectLocker to synchronize additions to the CLD dependency list.
Reviewed-by: stefank, coleenp

! src/share/vm/classfile/classLoaderData.cpp
! src/share/vm/classfile/classLoaderData.hpp
+ test/gc/metaspace/G1AddMetaspaceDependency.java

Changeset: 7b835924c31c
Author:    stefank
Date:      2013-04-10 14:26 +0200
URL:       http://hg.openjdk.java.net/hsx/hsx25/hotspot/rev/7b835924c31c

8011872: Include Bit Map addresses in the hs_err files
Reviewed-by: brutisso, jmasa

! src/share/vm/gc_implementation/concurrentMarkSweep/concurrentMarkSweepGeneration.cpp
! src/share/vm/gc_implementation/concurrentMarkSweep/concurrentMarkSweepGeneration.hpp
! src/share/vm/gc_implementation/g1/concurrentMark.cpp
! src/share/vm/gc_implementation/g1/concurrentMark.hpp
! src/share/vm/gc_implementation/g1/g1CollectedHeap.cpp
! src/share/vm/gc_implementation/g1/g1CollectedHeap.hpp
! src/share/vm/gc_implementation/parallelScavenge/parMarkBitMap.hpp
! src/share/vm/gc_implementation/parallelScavenge/parallelScavengeHeap.cpp
! src/share/vm/gc_implementation/parallelScavenge/parallelScavengeHeap.hpp
! src/share/vm/gc_implementation/parallelScavenge/psParallelCompact.cpp
! src/share/vm/gc_implementation/parallelScavenge/psParallelCompact.hpp
! src/share/vm/gc_interface/collectedHeap.hpp
! src/share/vm/memory/genCollectedHeap.cpp
! src/share/vm/memory/genCollectedHeap.hpp
! src/share/vm/utilities/bitMap.cpp
! src/share/vm/utilities/bitMap.hpp
! src/share/vm/utilities/vmError.cpp

Changeset: 480d934f62a8
Author:    mgerdin
Date:      2013-04-11 16:35 +0200
URL:       http://hg.openjdk.java.net/hsx/hsx25/hotspot/rev/480d934f62a8

Merge

! src/share/vm/runtime/arguments.cpp
- test/runtime/NMT/AllocTestType.java

Changeset: 705ef39fcaa9
Author:    neliasso
Date:      2013-04-05 11:09 +0200
URL:       http://hg.openjdk.java.net/hsx/hsx25/hotspot/rev/705ef39fcaa9

8006016: Memory leak at hotspot/src/share/vm/adlc/output_c.cpp
Reviewed-by: kvn, roland
Contributed-by: niclas.adlertz at oracle.com

! src/share/vm/adlc/output_c.cpp
! src/share/vm/adlc/output_h.cpp

Changeset: f67065f02409
Author:    bharadwaj
Date:      2013-04-08 07:40 -0700
URL:       http://hg.openjdk.java.net/hsx/hsx25/hotspot/rev/f67065f02409

8010913: compiler/6863420 often exceeds timeout
Summary: add longer timeout for jtreg, add internal timeout thread to prevent spurious timeouts
Reviewed-by: twisti, kvn
Contributed-by: drchase 

! test/compiler/6863420/Test.java

Changeset: b84fd7d73702
Author:    iignatyev
Date:      2013-04-09 09:54 -0700
URL:       http://hg.openjdk.java.net/hsx/hsx25/hotspot/rev/b84fd7d73702

8007288: Additional WB API for compiler's testing
Reviewed-by: kvn, vlivanov

! src/share/vm/compiler/compileBroker.cpp
! src/share/vm/oops/method.hpp
! src/share/vm/oops/methodData.cpp
! src/share/vm/oops/methodData.hpp
! src/share/vm/prims/whitebox.cpp
! src/share/vm/runtime/compilationPolicy.cpp
! src/share/vm/runtime/compilationPolicy.hpp
! src/share/vm/utilities/accessFlags.hpp
! src/share/vm/utilities/globalDefinitions.hpp
+ test/compiler/whitebox/ClearMethodStateTest.java
! test/compiler/whitebox/CompilerWhiteBoxTest.java
! test/compiler/whitebox/DeoptimizeAllTest.java
! test/compiler/whitebox/DeoptimizeMethodTest.java
+ test/compiler/whitebox/EnqueueMethodForCompilationTest.java
! test/compiler/whitebox/IsMethodCompilableTest.java
! test/compiler/whitebox/MakeMethodNotCompilableTest.java
! test/compiler/whitebox/SetDontInlineMethodTest.java
+ test/compiler/whitebox/SetForceInlineMethodTest.java
! test/testlibrary/whitebox/sun/hotspot/WhiteBox.java

Changeset: 84ab5667f290
Author:    roland
Date:      2013-04-10 09:52 +0200
URL:       http://hg.openjdk.java.net/hsx/hsx25/hotspot/rev/84ab5667f290

8011706: specjvm2008 test xml.transform gets array bound exception with c1
Summary: loop invariant code motion may move load before store to the same field
Reviewed-by: kvn

! src/share/vm/c1/c1_ValueMap.cpp
+ test/compiler/8011706/Test8011706.java

Changeset: d79859ff6535
Author:    kmo
Date:      2013-04-11 07:12 -0700
URL:       http://hg.openjdk.java.net/hsx/hsx25/hotspot/rev/d79859ff6535

8011952: Missing ResourceMarks in TraceMethodHandles
Summary: add missing ResourceMark under TraceMethodHandles in LinkResolver
Reviewed-by: dholmes

! src/share/vm/interpreter/linkResolver.cpp

Changeset: 9befe2fce567
Author:    vlivanov
Date:      2013-04-11 09:08 -0700
URL:       http://hg.openjdk.java.net/hsx/hsx25/hotspot/rev/9befe2fce567

8011972: Field can be erroneously marked as contended when @Contended annotation isn't present
Reviewed-by: kvn, kmo, shade

! src/share/vm/classfile/classFileParser.cpp
! src/share/vm/classfile/classFileParser.hpp

Changeset: b5db9d29062f
Author:    vlivanov
Date:      2013-04-11 11:42 -0700
URL:       http://hg.openjdk.java.net/hsx/hsx25/hotspot/rev/b5db9d29062f

Merge


Changeset: 7a5aec879506
Author:    bharadwaj
Date:      2013-04-11 17:16 -0700
URL:       http://hg.openjdk.java.net/hsx/hsx25/hotspot/rev/7a5aec879506

Merge

! src/share/vm/prims/whitebox.cpp
! src/share/vm/utilities/globalDefinitions.hpp
! test/testlibrary/whitebox/sun/hotspot/WhiteBox.java

Changeset: 6d88a566d369
Author:    amurillo
Date:      2013-04-11 21:45 -0700
URL:       http://hg.openjdk.java.net/hsx/hsx25/hotspot/rev/6d88a566d369

Merge

- test/gc/6941923/test6941923.sh
- test/gc/TestVerifyBeforeGCDuringStartup.java

Changeset: 5201379fe487
Author:    amurillo
Date:      2013-04-11 21:45 -0700
URL:       http://hg.openjdk.java.net/hsx/hsx25/hotspot/rev/5201379fe487

Added tag hs25-b28 for changeset 6d88a566d369

! .hgtags


From alejandro.murillo at oracle.com  Fri Apr 12 04:34:46 2013
From: alejandro.murillo at oracle.com (alejandro.murillo at oracle.com)
Date: Fri, 12 Apr 2013 11:34:46 +0000
Subject: hg: hsx/hsx24/hotspot: 3 new changesets
Message-ID: <20130412113457.2F93A48275@hg.openjdk.java.net>

Changeset: 0e7cb4f6dcb7
Author:    katleman
Date:      2013-04-10 10:29 -0700
URL:       http://hg.openjdk.java.net/hsx/hsx24/hotspot/rev/0e7cb4f6dcb7

Added tag jdk7u14-b20 for changeset c23596bfe3b8

! .hgtags

Changeset: 3295faa5b5cc
Author:    amurillo
Date:      2013-04-11 22:44 -0700
URL:       http://hg.openjdk.java.net/hsx/hsx24/hotspot/rev/3295faa5b5cc

Merge

! .hgtags
- make/bsd/makefiles/wb.make
- make/linux/makefiles/wb.make
- make/solaris/makefiles/wb.make
- make/windows/makefiles/wb.make
- make/windows/projectfiles/kernel/Makefile
- make/windows/projectfiles/kernel/vm.def
- make/windows/projectfiles/kernel/vm.dsw
- src/share/tools/whitebox/sun/hotspot/WhiteBox.java
- src/share/tools/whitebox/sun/hotspot/parser/DiagnosticCommand.java

Changeset: 3e88170d8be2
Author:    amurillo
Date:      2013-04-11 22:44 -0700
URL:       http://hg.openjdk.java.net/hsx/hsx24/hotspot/rev/3e88170d8be2

Added tag hs24-b40 for changeset 3295faa5b5cc

! .hgtags


From coleen.phillimore at oracle.com  Fri Apr 12 04:54:31 2013
From: coleen.phillimore at oracle.com (Coleen Phillimore)
Date: Fri, 12 Apr 2013 07:54:31 -0400
Subject: RFR (S): 8011803: release_C_heap_structures is never called for
	anonymous classes.
In-Reply-To: <51676F98.8030109@oracle.com>
References: <51672297.3080503@oracle.com> <51676F98.8030109@oracle.com>
Message-ID: <5167F5F7.1090504@oracle.com>

On 4/11/2013 10:21 PM, David Holmes wrote:
> Hi Coleen,
>
> Can you clarify something for me please. ClassLoaderData::unload() is 
> what now cleans up the anonymous classes - correct? But 
> ClassLoaderData::unload() is only called when the ClassLoader is 
> unloaded - correct? And the whole point of anonymous classes is that 
> they get unloaded independent of the classloader lifecycle. Assuming 
> I'm correct so far it seems to me that if the classloader is never 
> unloaded, the anonymous classes still won't have 
> release_C_heap_structures called. And if it is unloaded it could be 
> well after the classes were unloaded.

Hi David,

Yes, anonymous classes do get unloaded independent of the class loader 
lifecycle, but they get their own ClassLoaderData when created.   This 
ClassLoaderData is tied to the lifetime of the anonymous class's mirror, 
so when the mirror is unreferenced, the CLD will get unloaded.    With 
anonymous classes there is not a 1-1 relationship between object of 
java/lang/ClassLoader and CLD.

I did it this way because otherwise the metadata for the anonymous 
classes is never reclaimed (or reclamation would have to walk the CLD 
graph and put holes in the metaspaces).

Thanks,
Coleen


>
> David
>
> On 12/04/2013 6:52 AM, Coleen Phillimore wrote:
>> Summary: Call this function from CLD::unload()  now for anonymous 
>> classes.
>>
>> Anonymous classes aren't in the system dictionary so
>> release_C_heap_structures isn't called for them if they are unloaded.  I
>> fixed this for jdk8 because they are in the class loader data graph but
>> for jdk7, I don't know how to fix this.  They are unloaded by being
>> garbage collected after the references are dropped.
>>
>> Tested with ute tests vm.mvlm.testlist nsk.monitoring.testlist and
>> jdk/test/java/lang/invoke tests.
>>
>> open webrev at http://cr.openjdk.java.net/~coleenp/8011803/
>> bug link at http://bugs.sun.com/view_bug.do?bug_id=8011803
>>
>> Thanks,
>> Coleen


From david.holmes at oracle.com  Fri Apr 12 04:58:13 2013
From: david.holmes at oracle.com (David Holmes)
Date: Fri, 12 Apr 2013 21:58:13 +1000
Subject: RFR (S): 8011803: release_C_heap_structures is never called for
	anonymous classes.
In-Reply-To: <5167F5F7.1090504@oracle.com>
References: <51672297.3080503@oracle.com> <51676F98.8030109@oracle.com>
	<5167F5F7.1090504@oracle.com>
Message-ID: <5167F6D5.1070602@oracle.com>

Thanks Coleen. I mentally treat ClassLoaderData as a ClassLoader but 
that's not right.

David

On 12/04/2013 9:54 PM, Coleen Phillimore wrote:
> On 4/11/2013 10:21 PM, David Holmes wrote:
>> Hi Coleen,
>>
>> Can you clarify something for me please. ClassLoaderData::unload() is
>> what now cleans up the anonymous classes - correct? But
>> ClassLoaderData::unload() is only called when the ClassLoader is
>> unloaded - correct? And the whole point of anonymous classes is that
>> they get unloaded independent of the classloader lifecycle. Assuming
>> I'm correct so far it seems to me that if the classloader is never
>> unloaded, the anonymous classes still won't have
>> release_C_heap_structures called. And if it is unloaded it could be
>> well after the classes were unloaded.
>
> Hi David,
>
> Yes, anonymous classes do get unloaded independent of the class loader
> lifecycle, but they get their own ClassLoaderData when created.   This
> ClassLoaderData is tied to the lifetime of the anonymous class's mirror,
> so when the mirror is unreferenced, the CLD will get unloaded.    With
> anonymous classes there is not a 1-1 relationship between object of
> java/lang/ClassLoader and CLD.
>
> I did it this way because otherwise the metadata for the anonymous
> classes is never reclaimed (or reclamation would have to walk the CLD
> graph and put holes in the metaspaces).
>
> Thanks,
> Coleen
>
>
>>
>> David
>>
>> On 12/04/2013 6:52 AM, Coleen Phillimore wrote:
>>> Summary: Call this function from CLD::unload()  now for anonymous
>>> classes.
>>>
>>> Anonymous classes aren't in the system dictionary so
>>> release_C_heap_structures isn't called for them if they are unloaded.  I
>>> fixed this for jdk8 because they are in the class loader data graph but
>>> for jdk7, I don't know how to fix this.  They are unloaded by being
>>> garbage collected after the references are dropped.
>>>
>>> Tested with ute tests vm.mvlm.testlist nsk.monitoring.testlist and
>>> jdk/test/java/lang/invoke tests.
>>>
>>> open webrev at http://cr.openjdk.java.net/~coleenp/8011803/
>>> bug link at http://bugs.sun.com/view_bug.do?bug_id=8011803
>>>
>>> Thanks,
>>> Coleen
>

From coleen.phillimore at oracle.com  Fri Apr 12 05:38:25 2013
From: coleen.phillimore at oracle.com (Coleen Phillimore)
Date: Fri, 12 Apr 2013 08:38:25 -0400
Subject: RFR (S): 8011803: release_C_heap_structures is never called for
	anonymous classes.
In-Reply-To: <5167CA4C.5040608@oracle.com>
References: <51672297.3080503@oracle.com> <5167CA4C.5040608@oracle.com>
Message-ID: <51680041.5070905@oracle.com>

On 4/12/2013 4:48 AM, Stefan Karlsson wrote:
> On 04/11/2013 10:52 PM, Coleen Phillimore wrote:
>> Summary: Call this function from CLD::unload()  now for anonymous 
>> classes.
>>
>> Anonymous classes aren't in the system dictionary so 
>> release_C_heap_structures isn't called for them if they are 
>> unloaded.  I fixed this for jdk8 because they are in the class loader 
>> data graph but for jdk7, I don't know how to fix this. They are 
>> unloaded by being garbage collected after the references are dropped.
>>
>> Tested with ute tests vm.mvlm.testlist nsk.monitoring.testlist and 
>> jdk/test/java/lang/invoke tests.
>>
>> open webrev at http://cr.openjdk.java.net/~coleenp/8011803/
>> bug link at http://bugs.sun.com/view_bug.do?bug_id=8011803
>
> I've two comments.
>
> 1) It's unfortunate that we now call unload_class() at two different 
> places in the code. It makes it harder to understand the deallocation 
> of metadata. It would be better to keep the calls to unload_class() 
> for ordinary InstanceKlasses and anonymous classes together.

Hi Stefan,  Thank you for looking at this.   This is the feedback I was 
looking for.

I went back and forth about moving the regular class unloading actions 
for everything in unload (or ~ClassLoaderData), but I didn't want to 
introduce a _klasses walk for all the class loaders.   We're already 
walking them in the system dictionary purge.

For my change I'm walking these classes if UseCompressedKlassPointers, 
and Markus is walking them for serviceability (hopefully under some 
flag) so maybe I should just do it.

>
> 2) This change actually breaks the Tracing class unloading event that 
> Markus is working on. That code walk the 
> ClassLoaderDataGraph::_unloading list in 
> ClassLoaderDataGraph::do_unloading and use the information in the 
> classes of the CLDs that are about to be unloaded. With this patch 
> they probably crash because some pointers in the anonymous classes 
> will be trashed.
>

I thought about that, since I've been talking to Markus about this.   I 
wanted to consolidate the serviceability calls in one place and calling 
InstanceKlass::unload_class() that notifies serviceability in the 
~ClassLoaderData destructor might be too late.  It might not be 
though.   I think the walk in the destructor might be better for 
release_C_heap_structures though.

> I have a suggestion on how to solve both points above. It's probably 
> easier to show with a pseudo patch:
>
> $ hg diff
> diff --git a/src/share/vm/classfile/classLoaderData.cpp 
> b/src/share/vm/classfile/classLoaderData.cpp
> --- a/src/share/vm/classfile/classLoaderData.cpp
> +++ b/src/share/vm/classfile/classLoaderData.cpp
> @@ -671,7 +671,6 @@
>      }
>      seen_dead_loader = true;
>      ClassLoaderData* dead = data;
> -    dead->unload();
>      data = data->next();
>      // Remove from loader list.
>      if (prev != NULL) {
> @@ -683,9 +682,24 @@
>      dead->set_next(_unloading);
>      _unloading = dead;
>    }
> +
> +  report_class_unloading_info(_unloading);
> +
> +  ClassLoaderDataGraph::unload_classes();
> +
>    return seen_dead_loader;
>  }
>
> +void ClassLoaderDataGraph::unload_classes() {
> +  ClassLoaderData* list = _unloading;
> +  ClassLoaderData* next = list;
> +  while (next != NULL) {
> +    for (Klass* k = next->_klasses; k != NULL; k = k->next_link()) {
> +      k->unload_class();
> +    }
> +  }
> +}
> +

That's too much extra walking.   But maybe we can split the 
serviceability stuff into ClassLoaderData::unload() and do the 
release_C_heap_structures() into the ClassLoaderData destructor. That 
seems better.   Maybe Markus could put his callback into CLD::unload().

Thanks!  I will change this and resend.
Coleen

>  void ClassLoaderDataGraph::purge() {
>    ClassLoaderData* list = _unloading;
>    _unloading = NULL;
> diff --git a/src/share/vm/classfile/dictionary.cpp 
> b/src/share/vm/classfile/dictionary.cpp
> --- a/src/share/vm/classfile/dictionary.cpp
> +++ b/src/share/vm/classfile/dictionary.cpp
> @@ -157,9 +157,6 @@
>              // to be unloaded.
>              // Notify the debugger and clean up the class.
>              class_was_unloaded = true;
> -
> -            // perform unloading actions on this class
> -            ik->unload_class();
>            }
>            // Also remove this system dictionary entry.
>            purge_entry = true;
>
> As a bonus, the dictionary()->do_unloading() will then only do a 
> simple purge of the SystemDictionary.
>
> What do you think?
>
> thanks,
> StefanK
>
>>
>> Thanks,
>> Coleen
>


From alejandro.murillo at oracle.com  Fri Apr 12 07:07:03 2013
From: alejandro.murillo at oracle.com (alejandro.murillo at oracle.com)
Date: Fri, 12 Apr 2013 14:07:03 +0000
Subject: hg: hsx/hotspot-main/hotspot: 5 new changesets
Message-ID: <20130412140719.E53CB4827D@hg.openjdk.java.net>

Changeset: 5dcfeb396fed
Author:    katleman
Date:      2013-04-11 09:39 -0700
URL:       http://hg.openjdk.java.net/hsx/hotspot-main/hotspot/rev/5dcfeb396fed

Added tag jdk8-b85 for changeset 42fe530cd478

! .hgtags

Changeset: 511e334ee345
Author:    amurillo
Date:      2013-04-11 16:35 -0700
URL:       http://hg.openjdk.java.net/hsx/hotspot-main/hotspot/rev/511e334ee345

Merge

! .hgtags
- test/runtime/NMT/AllocTestType.java

Changeset: 6d88a566d369
Author:    amurillo
Date:      2013-04-11 21:45 -0700
URL:       http://hg.openjdk.java.net/hsx/hotspot-main/hotspot/rev/6d88a566d369

Merge

- test/gc/6941923/test6941923.sh
- test/gc/TestVerifyBeforeGCDuringStartup.java

Changeset: 5201379fe487
Author:    amurillo
Date:      2013-04-11 21:45 -0700
URL:       http://hg.openjdk.java.net/hsx/hotspot-main/hotspot/rev/5201379fe487

Added tag hs25-b28 for changeset 6d88a566d369

! .hgtags

Changeset: c60f69931e1a
Author:    amurillo
Date:      2013-04-11 21:54 -0700
URL:       http://hg.openjdk.java.net/hsx/hotspot-main/hotspot/rev/c60f69931e1a

8011949: new hotspot build - hs25-b29
Reviewed-by: jcoomes

! make/hotspot_version


From christian.thalinger at oracle.com  Fri Apr 12 11:58:55 2013
From: christian.thalinger at oracle.com (Christian Thalinger)
Date: Fri, 12 Apr 2013 11:58:55 -0700
Subject: RFR (S): 7172922: export_ makefile targets do not work unless all
	supported variants are built
Message-ID: <39142204-69FF-49BE-9FF1-D16B80E4A3F7@oracle.com>

http://cr.openjdk.java.net/~twisti/7172922

7172922: export_ makefile targets do not work unless all supported variants are built
Reviewed-by:

GEN_DIR can be overwritten by other configurations if multiple JVM_VARIANT_*s are defined. The fix is to use the *_BASE_DIRs directly to install the correct files.

make/Makefile


From coleen.phillimore at oracle.com  Fri Apr 12 12:03:03 2013
From: coleen.phillimore at oracle.com (Coleen Phillimore)
Date: Fri, 12 Apr 2013 15:03:03 -0400
Subject: RFR (S): 8011803: release_C_heap_structures is never called for
	anonymous classes.
In-Reply-To: <51680041.5070905@oracle.com>
References: <51672297.3080503@oracle.com> <5167CA4C.5040608@oracle.com>
	<51680041.5070905@oracle.com>
Message-ID: <51685A67.4020007@oracle.com>


Hi,

I have updated the webrev to split the serviceability actions and the 
deleting C heap data for classes in ClassLoaderData.  I left the 
serviceability actions in dictionary::do_unloading() to avoid rewalking 
the ClassLoaderData _klasses.   For release_C_heap_structures(), all the 
_klasses are walked at the end.   This should work for Markus G's new 
serviceability changes with minor modifications.

open webrev at http://cr.openjdk.java.net/~coleenp/8011803_2/

thanks,
Coleen

On 4/12/2013 8:38 AM, Coleen Phillimore wrote:
> On 4/12/2013 4:48 AM, Stefan Karlsson wrote:
>> On 04/11/2013 10:52 PM, Coleen Phillimore wrote:
>>> Summary: Call this function from CLD::unload()  now for anonymous 
>>> classes.
>>>
>>> Anonymous classes aren't in the system dictionary so 
>>> release_C_heap_structures isn't called for them if they are 
>>> unloaded.  I fixed this for jdk8 because they are in the class 
>>> loader data graph but for jdk7, I don't know how to fix this. They 
>>> are unloaded by being garbage collected after the references are 
>>> dropped.
>>>
>>> Tested with ute tests vm.mvlm.testlist nsk.monitoring.testlist and 
>>> jdk/test/java/lang/invoke tests.
>>>
>>> open webrev at http://cr.openjdk.java.net/~coleenp/8011803/
>>> bug link at http://bugs.sun.com/view_bug.do?bug_id=8011803
>>
>> I've two comments.
>>
>> 1) It's unfortunate that we now call unload_class() at two different 
>> places in the code. It makes it harder to understand the deallocation 
>> of metadata. It would be better to keep the calls to unload_class() 
>> for ordinary InstanceKlasses and anonymous classes together.
>
> Hi Stefan,  Thank you for looking at this.   This is the feedback I 
> was looking for.
>
> I went back and forth about moving the regular class unloading actions 
> for everything in unload (or ~ClassLoaderData), but I didn't want to 
> introduce a _klasses walk for all the class loaders.   We're already 
> walking them in the system dictionary purge.
>
> For my change I'm walking these classes if UseCompressedKlassPointers, 
> and Markus is walking them for serviceability (hopefully under some 
> flag) so maybe I should just do it.
>
>>
>> 2) This change actually breaks the Tracing class unloading event that 
>> Markus is working on. That code walk the 
>> ClassLoaderDataGraph::_unloading list in 
>> ClassLoaderDataGraph::do_unloading and use the information in the 
>> classes of the CLDs that are about to be unloaded. With this patch 
>> they probably crash because some pointers in the anonymous classes 
>> will be trashed.
>>
>
> I thought about that, since I've been talking to Markus about this.   
> I wanted to consolidate the serviceability calls in one place and 
> calling InstanceKlass::unload_class() that notifies serviceability in 
> the ~ClassLoaderData destructor might be too late.  It might not be 
> though.   I think the walk in the destructor might be better for 
> release_C_heap_structures though.
>
>> I have a suggestion on how to solve both points above. It's probably 
>> easier to show with a pseudo patch:
>>
>> $ hg diff
>> diff --git a/src/share/vm/classfile/classLoaderData.cpp 
>> b/src/share/vm/classfile/classLoaderData.cpp
>> --- a/src/share/vm/classfile/classLoaderData.cpp
>> +++ b/src/share/vm/classfile/classLoaderData.cpp
>> @@ -671,7 +671,6 @@
>>      }
>>      seen_dead_loader = true;
>>      ClassLoaderData* dead = data;
>> -    dead->unload();
>>      data = data->next();
>>      // Remove from loader list.
>>      if (prev != NULL) {
>> @@ -683,9 +682,24 @@
>>      dead->set_next(_unloading);
>>      _unloading = dead;
>>    }
>> +
>> +  report_class_unloading_info(_unloading);
>> +
>> +  ClassLoaderDataGraph::unload_classes();
>> +
>>    return seen_dead_loader;
>>  }
>>
>> +void ClassLoaderDataGraph::unload_classes() {
>> +  ClassLoaderData* list = _unloading;
>> +  ClassLoaderData* next = list;
>> +  while (next != NULL) {
>> +    for (Klass* k = next->_klasses; k != NULL; k = k->next_link()) {
>> +      k->unload_class();
>> +    }
>> +  }
>> +}
>> +
>
> That's too much extra walking.   But maybe we can split the 
> serviceability stuff into ClassLoaderData::unload() and do the 
> release_C_heap_structures() into the ClassLoaderData destructor. That 
> seems better.   Maybe Markus could put his callback into CLD::unload().
>
> Thanks!  I will change this and resend.
> Coleen
>
>>  void ClassLoaderDataGraph::purge() {
>>    ClassLoaderData* list = _unloading;
>>    _unloading = NULL;
>> diff --git a/src/share/vm/classfile/dictionary.cpp 
>> b/src/share/vm/classfile/dictionary.cpp
>> --- a/src/share/vm/classfile/dictionary.cpp
>> +++ b/src/share/vm/classfile/dictionary.cpp
>> @@ -157,9 +157,6 @@
>>              // to be unloaded.
>>              // Notify the debugger and clean up the class.
>>              class_was_unloaded = true;
>> -
>> -            // perform unloading actions on this class
>> -            ik->unload_class();
>>            }
>>            // Also remove this system dictionary entry.
>>            purge_entry = true;
>>
>> As a bonus, the dictionary()->do_unloading() will then only do a 
>> simple purge of the SystemDictionary.
>>
>> What do you think?
>>
>> thanks,
>> StefanK
>>
>>>
>>> Thanks,
>>> Coleen
>>
>


From coleen.phillimore at oracle.com  Fri Apr 12 14:36:25 2013
From: coleen.phillimore at oracle.com (Coleen Phillimore)
Date: Fri, 12 Apr 2013 17:36:25 -0400
Subject: RFR (S): 8011803: release_C_heap_structures is never called for
	anonymous classes.
In-Reply-To: <51685A67.4020007@oracle.com>
References: <51672297.3080503@oracle.com> <5167CA4C.5040608@oracle.com>
	<51680041.5070905@oracle.com> <51685A67.4020007@oracle.com>
Message-ID: <51687E59.6060702@oracle.com>

On 4/12/2013 3:03 PM, Coleen Phillimore wrote:
>
> Hi,
>
> I have updated the webrev to split the serviceability actions and the 
> deleting C heap data for classes in ClassLoaderData.  I left the 
> serviceability actions in dictionary::do_unloading() to avoid 
> rewalking the ClassLoaderData _klasses.   For 
> release_C_heap_structures(), all the _klasses are walked at the end.   
> This should work for Markus G's new serviceability changes with minor 
> modifications.

Reload if you looked at this already.  Stefan convinced me that walking 
the class list in the ClassLoaderData::unload() is not too expensive, so 
the serviceability actions have been removed from 
dictionary::do_unloading() and done in ClassLoaderData::unload() 
unconditionally.

>
> open webrev at http://cr.openjdk.java.net/~coleenp/8011803_2/
>
> thanks,
> Coleen
>
> On 4/12/2013 8:38 AM, Coleen Phillimore wrote:
>> On 4/12/2013 4:48 AM, Stefan Karlsson wrote:
>>> On 04/11/2013 10:52 PM, Coleen Phillimore wrote:
>>>> Summary: Call this function from CLD::unload()  now for anonymous 
>>>> classes.
>>>>
>>>> Anonymous classes aren't in the system dictionary so 
>>>> release_C_heap_structures isn't called for them if they are 
>>>> unloaded.  I fixed this for jdk8 because they are in the class 
>>>> loader data graph but for jdk7, I don't know how to fix this. They 
>>>> are unloaded by being garbage collected after the references are 
>>>> dropped.
>>>>
>>>> Tested with ute tests vm.mvlm.testlist nsk.monitoring.testlist and 
>>>> jdk/test/java/lang/invoke tests.
>>>>
>>>> open webrev at http://cr.openjdk.java.net/~coleenp/8011803/
>>>> bug link at http://bugs.sun.com/view_bug.do?bug_id=8011803
>>>
>>> I've two comments.
>>>
>>> 1) It's unfortunate that we now call unload_class() at two different 
>>> places in the code. It makes it harder to understand the 
>>> deallocation of metadata. It would be better to keep the calls to 
>>> unload_class() for ordinary InstanceKlasses and anonymous classes 
>>> together.
>>
>> Hi Stefan,  Thank you for looking at this.   This is the feedback I 
>> was looking for.
>>
>> I went back and forth about moving the regular class unloading 
>> actions for everything in unload (or ~ClassLoaderData), but I didn't 
>> want to introduce a _klasses walk for all the class loaders.   We're 
>> already walking them in the system dictionary purge.
>>
>> For my change I'm walking these classes if 
>> UseCompressedKlassPointers, and Markus is walking them for 
>> serviceability (hopefully under some flag) so maybe I should just do it.
>>
>>>
>>> 2) This change actually breaks the Tracing class unloading event 
>>> that Markus is working on. That code walk the 
>>> ClassLoaderDataGraph::_unloading list in 
>>> ClassLoaderDataGraph::do_unloading and use the information in the 
>>> classes of the CLDs that are about to be unloaded. With this patch 
>>> they probably crash because some pointers in the anonymous classes 
>>> will be trashed.
>>>
>>
>> I thought about that, since I've been talking to Markus about this.   
>> I wanted to consolidate the serviceability calls in one place and 
>> calling InstanceKlass::unload_class() that notifies serviceability in 
>> the ~ClassLoaderData destructor might be too late.  It might not be 
>> though.   I think the walk in the destructor might be better for 
>> release_C_heap_structures though.
>>
>>> I have a suggestion on how to solve both points above. It's probably 
>>> easier to show with a pseudo patch:
>>>
>>> $ hg diff
>>> diff --git a/src/share/vm/classfile/classLoaderData.cpp 
>>> b/src/share/vm/classfile/classLoaderData.cpp
>>> --- a/src/share/vm/classfile/classLoaderData.cpp
>>> +++ b/src/share/vm/classfile/classLoaderData.cpp
>>> @@ -671,7 +671,6 @@
>>>      }
>>>      seen_dead_loader = true;
>>>      ClassLoaderData* dead = data;
>>> -    dead->unload();
>>>      data = data->next();
>>>      // Remove from loader list.
>>>      if (prev != NULL) {
>>> @@ -683,9 +682,24 @@
>>>      dead->set_next(_unloading);
>>>      _unloading = dead;
>>>    }
>>> +
>>> +  report_class_unloading_info(_unloading);
>>> +
>>> +  ClassLoaderDataGraph::unload_classes();
>>> +
>>>    return seen_dead_loader;
>>>  }
>>>
>>> +void ClassLoaderDataGraph::unload_classes() {
>>> +  ClassLoaderData* list = _unloading;
>>> +  ClassLoaderData* next = list;
>>> +  while (next != NULL) {
>>> +    for (Klass* k = next->_klasses; k != NULL; k = k->next_link()) {
>>> +      k->unload_class();
>>> +    }
>>> +  }
>>> +}
>>> +
>>
>> That's too much extra walking.   But maybe we can split the 
>> serviceability stuff into ClassLoaderData::unload() and do the 
>> release_C_heap_structures() into the ClassLoaderData destructor. That 
>> seems better.   Maybe Markus could put his callback into CLD::unload().
>>
>> Thanks!  I will change this and resend.
>> Coleen
>>
>>>  void ClassLoaderDataGraph::purge() {
>>>    ClassLoaderData* list = _unloading;
>>>    _unloading = NULL;
>>> diff --git a/src/share/vm/classfile/dictionary.cpp 
>>> b/src/share/vm/classfile/dictionary.cpp
>>> --- a/src/share/vm/classfile/dictionary.cpp
>>> +++ b/src/share/vm/classfile/dictionary.cpp
>>> @@ -157,9 +157,6 @@
>>>              // to be unloaded.
>>>              // Notify the debugger and clean up the class.
>>>              class_was_unloaded = true;
>>> -
>>> -            // perform unloading actions on this class
>>> -            ik->unload_class();
>>>            }
>>>            // Also remove this system dictionary entry.
>>>            purge_entry = true;
>>>
>>> As a bonus, the dictionary()->do_unloading() will then only do a 
>>> simple purge of the SystemDictionary.
>>>
>>> What do you think?
>>>
>>> thanks,
>>> StefanK
>>>
>>>>
>>>> Thanks,
>>>> Coleen
>>>
>>
>


From john.r.rose at oracle.com  Fri Apr 12 15:12:28 2013
From: john.r.rose at oracle.com (John Rose)
Date: Fri, 12 Apr 2013 15:12:28 -0700
Subject: hs25 review request: 8008511 JSR 292: MemberName vmtarget refs to
	methods must be updated at class redefinition
In-Reply-To: <515B48F3.4040706@oracle.com>
References: <513E8B88.6070904@oracle.com> <51515E3C.7040307@oracle.com>
	<5159E95E.2030705@oracle.com> <515A03FB.30808@oracle.com>
	<515A0F60.1040105@oracle.com> <515B0F17.5040803@oracle.com>
	<515B48F3.4040706@oracle.com>
Message-ID: 

On Apr 2, 2013, at 2:09 PM, Coleen Phillimore  wrote:

>> Also, the decision how to represent the MNT depends on its future usage by the compiler team.
>> As we agreed, the compiler team is going to adjust the MNT to their needs
>> at some point when it is more convenient for them. 
>> So that, could we make a final decision when the whole picture is ready?
>> It would be better to approach it in some steps.
>> Currently, this bug blocks other work on the JVMTI support of jsr-292.
> 
> I don't know what the jsr 292 team has in store for this field but it's still a footprint cost that's for only a special case.  So this is okay if you file a bug so that we can remove it and reimplement this table to be global or a hashtable.

FTR, I would prefer to reimplement it as an optional attribute of java.lang.Class, so that JDK code can access it.  This will cut down on the number of native-to-Java transitions (JNI calls).  By "optional attribute" I mean something like ReflectionData, or even a field of ReflectionData itself.

? John

From serguei.spitsyn at oracle.com  Fri Apr 12 15:18:24 2013
From: serguei.spitsyn at oracle.com (serguei.spitsyn at oracle.com)
Date: Fri, 12 Apr 2013 15:18:24 -0700
Subject: hs25 review request: 8008511 JSR 292: MemberName vmtarget refs
	to methods must be updated at class redefinition
In-Reply-To: 
References: <513E8B88.6070904@oracle.com> <51515E3C.7040307@oracle.com>
	<5159E95E.2030705@oracle.com> <515A03FB.30808@oracle.com>
	<515A0F60.1040105@oracle.com> <515B0F17.5040803@oracle.com>
	<515B48F3.4040706@oracle.com>
	
Message-ID: <51688830.7070709@oracle.com>

I've filed a bug on this:
   https://jbs.oracle.com/bugs/browse/JDK-8012162

Thanks,
Serguei

On 4/12/13 3:12 PM, John Rose wrote:
> On Apr 2, 2013, at 2:09 PM, Coleen Phillimore 
> > 
> wrote:
>
>>> Also, the decision how to represent the MNT depends on its future 
>>> usage by the compiler team.
>>> As we agreed, the compiler team is going to adjust the MNT to their 
>>> needs
>>> at some point when it is more convenient for them.
>>> So that, could we make a final decision when the whole picture is ready?
>>> It would be better to approach it in some steps.
>>> Currently, this bug blocks other work on the JVMTI support of jsr-292.
>>
>> I don't know what the jsr 292 team has in store for this field but 
>> it's still a footprint cost that's for only a special case.  So this 
>> is okay if you file a bug so that we can remove it and reimplement 
>> this table to be global or a hashtable.
>
> FTR, I would prefer to reimplement it as an optional attribute of 
> java.lang.Class, so that JDK code can access it.  This will cut down 
> on the number of native-to-Java transitions (JNI calls).  By "optional 
> attribute" I mean something like ReflectionData, or even a field of 
> ReflectionData itself.
>
> ? John


From alejandro.murillo at oracle.com  Fri Apr 12 16:24:41 2013
From: alejandro.murillo at oracle.com (alejandro.murillo at oracle.com)
Date: Fri, 12 Apr 2013 23:24:41 +0000
Subject: hg: hsx/hsx24/hotspot: 8011947: new hotspot build - hs24-b41
Message-ID: <20130412232446.77A81482A2@hg.openjdk.java.net>

Changeset: 70a60475632f
Author:    amurillo
Date:      2013-04-11 22:52 -0700
URL:       http://hg.openjdk.java.net/hsx/hsx24/hotspot/rev/70a60475632f

8011947: new hotspot build - hs24-b41
Reviewed-by: jcoomes

! make/hotspot_version


From vladimir.kozlov at oracle.com  Fri Apr 12 16:26:23 2013
From: vladimir.kozlov at oracle.com (Vladimir Kozlov)
Date: Fri, 12 Apr 2013 16:26:23 -0700
Subject: RFR (S): 7172922: export_ makefile targets do not work unless
	all supported variants are built
In-Reply-To: <39142204-69FF-49BE-9FF1-D16B80E4A3F7@oracle.com>
References: <39142204-69FF-49BE-9FF1-D16B80E4A3F7@oracle.com>
Message-ID: <5168981F.1090001@oracle.com>

Looks good to me.

Vladimir

On 4/12/13 11:58 AM, Christian Thalinger wrote:
> http://cr.openjdk.java.net/~twisti/7172922
>
> 7172922: export_ makefile targets do not work unless all supported variants are built
> Reviewed-by:
>
> GEN_DIR can be overwritten by other configurations if multiple JVM_VARIANT_*s are defined. The fix is to use the *_BASE_DIRs directly to install the correct files.
>
> make/Makefile
>

From david.holmes at oracle.com  Fri Apr 12 17:10:12 2013
From: david.holmes at oracle.com (David Holmes)
Date: Sat, 13 Apr 2013 10:10:12 +1000
Subject: RFR (S): 7172922: export_ makefile targets do not work unless
	all supported variants are built
In-Reply-To: <39142204-69FF-49BE-9FF1-D16B80E4A3F7@oracle.com>
References: <39142204-69FF-49BE-9FF1-D16B80E4A3F7@oracle.com>
Message-ID: <5168A264.3070700@oracle.com>

Hi Chris,

On 13/04/2013 4:58 AM, Christian Thalinger wrote:
> http://cr.openjdk.java.net/~twisti/7172922
>
> 7172922: export_ makefile targets do not work unless all supported variants are built
> Reviewed-by:
>
> GEN_DIR can be overwritten by other configurations if multiple JVM_VARIANT_*s are defined. The fix is to use the *_BASE_DIRs directly to install the correct files.
>
> make/Makefile

This looks like a simple temporary solution - thanks.

More long term I hope we should be able to generate the set of targets 
based on the selected JVM_VARIANTS, without needing all those duplicated 
blocks.

One query with the current situation: why doesn't MISC_DIR cause us a 
problem? It would seem to have the same issue as GEN_DIR. ???

Thanks,
David


From serguei.spitsyn at oracle.com  Fri Apr 12 19:13:43 2013
From: serguei.spitsyn at oracle.com (serguei.spitsyn at oracle.com)
Date: Fri, 12 Apr 2013 19:13:43 -0700
Subject: hs25 review request (2nd round): 8008511 JSR 292: MemberName vmtarget
	refs to methods must be updated at class redefinition
Message-ID: <5168BF57.3030206@oracle.com>


Please, review the following fix.

This is the 2nd version that has a review fixes suggested by Coleen and 
John in the 1st review round.

Now the mtClass is used in allocation of MemberNameTable since it's part 
of class metadata.
All call sites in the methodHandles.cpp that recursively invoke the 
add_member_name()
are made safepoint-safe by replacing oop's with Handle's.
This allowed to get rid of the No_Safepoint_Verifier in the 
find_MemberNames.
The MemberName's are added to MNT not only for methods but also for fields.

Coleen,
You also suggested to put all new non-jvmti code under #if INCLUDE_JVMTI 
condition.
I've not done it because now the MemberName's associated with the fields are
also registered in the MNT which is not needed for JVMTI purposes.
Just have some doubt if it is a right thing to do.
I'm Ok to add this modification, but could you, confirm that it is still 
important.


Webrev:
http://cr.openjdk.java.net/~sspitsyn/webrevs/2013/hotspot/8008511-JVMTI-JSR292.2/

Bug:
http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=8008511
https://jbs.oracle.com/bugs/browse/JDK-8008511


The problem is that the old version of the bootstrap method is re-invoked
after a popframe from the bootstrap method execution.
It is because the MemberName keeps a stale reference to the old method 
version.

The solution (suggested by John) is to lazily create and keep up-to-date 
a MemberNameTable
which plays a role of MemberName cache assosiated with the InstanceKlass.
Then, at class redefinition, this cache is used to replace the old method
references in the MemberName's with the new method references.

The MemberNameTable is based on the GrowableArray.
A C_HEAP array is allocated at the first call to 
InstanceKlass::add_member_name().
It is released in the InstanceKlass::release_C_heap_structures().

A global week reference to member name oop is stored in the MemberNameTable.
It allowed to avoid having the oops_do() in the MemberNameTable.
Also, the MemberNameTable won't hold member name oops in memory.

The MemberNameTable_lock mutex is added to serialize MemberNameTable's 
updates.

Test coverage: vm.mlvm, nsk.jvmti, nsk.jdi tests on multiple platforms 
(32 vs 64-bit too).
The testing looks good.


Thanks,
Serguei

From christian.thalinger at oracle.com  Sat Apr 13 21:03:04 2013
From: christian.thalinger at oracle.com (Christian Thalinger)
Date: Sat, 13 Apr 2013 21:03:04 -0700
Subject: RFR (S): 7172922: export_ makefile targets do not work unless all
	supported variants are built
In-Reply-To: <5168A264.3070700@oracle.com>
References: <39142204-69FF-49BE-9FF1-D16B80E4A3F7@oracle.com>
	<5168A264.3070700@oracle.com>
Message-ID: <3C52BCA3-1721-4663-AECD-6CAA334E1232@oracle.com>


On Apr 12, 2013, at 5:10 PM, David Holmes  wrote:

> Hi Chris,
> 
> On 13/04/2013 4:58 AM, Christian Thalinger wrote:
>> http://cr.openjdk.java.net/~twisti/7172922
>> 
>> 7172922: export_ makefile targets do not work unless all supported variants are built
>> Reviewed-by:
>> 
>> GEN_DIR can be overwritten by other configurations if multiple JVM_VARIANT_*s are defined. The fix is to use the *_BASE_DIRs directly to install the correct files.
>> 
>> make/Makefile
> 
> This looks like a simple temporary solution - thanks.

Yes, it's not perfect but good enough for now.

> 
> More long term I hope we should be able to generate the set of targets based on the selected JVM_VARIANTS, without needing all those duplicated blocks.
> 
> One query with the current situation: why doesn't MISC_DIR cause us a problem? It would seem to have the same issue as GEN_DIR. ???

MISC_DIR has the same problem but I didn't want to mess with Windows.

How about this one?

http://cr.openjdk.java.net/~twisti/7172922

-- Chris

> 
> Thanks,
> David
> 


From nils.loodin at oracle.com  Sun Apr 14 07:38:42 2013
From: nils.loodin at oracle.com (nils.loodin at oracle.com)
Date: Sun, 14 Apr 2013 14:38:42 +0000
Subject: hg: hsx/hsx24/hotspot: 8008391: Incorrect metadata for event based
	tracing
Message-ID: <20130414143847.79FDA482C9@hg.openjdk.java.net>

Changeset: 2eae59f5418c
Author:    egahlin
Date:      2013-04-09 05:08 +0200
URL:       http://hg.openjdk.java.net/hsx/hsx24/hotspot/rev/2eae59f5418c

8008391: Incorrect metadata for event based tracing
Reviewed-by: stefank, sla

! src/share/vm/trace/trace.xml


From zhengyu.gu at oracle.com  Sun Apr 14 13:11:24 2013
From: zhengyu.gu at oracle.com (zhengyu.gu at oracle.com)
Date: Sun, 14 Apr 2013 20:11:24 +0000
Subject: hg: hsx/hsx24/hotspot: 2 new changesets
Message-ID: <20130414201131.255EE482CF@hg.openjdk.java.net>

Changeset: 1ed2314952c8
Author:    zgu
Date:      2013-04-12 11:26 -0400
URL:       http://hg.openjdk.java.net/hsx/hsx24/hotspot/rev/1ed2314952c8

8011161: NMT: Memory leak when encountering out of memory error while initializing memory snapshot
Summary: Fix memory leaks when NMT fails to initialize snapshot and worker thread
Reviewed-by: dcubed, ccheung, rdurbin

! src/share/vm/services/memTracker.cpp

Changeset: 0c00fe85302b
Author:    zgu
Date:      2013-04-14 14:16 -0400
URL:       http://hg.openjdk.java.net/hsx/hsx24/hotspot/rev/0c00fe85302b

Merge



From david.holmes at oracle.com  Sun Apr 14 16:39:36 2013
From: david.holmes at oracle.com (David Holmes)
Date: Mon, 15 Apr 2013 09:39:36 +1000
Subject: RFR (S): 7172922: export_ makefile targets do not work unless
	all supported variants are built
In-Reply-To: <3C52BCA3-1721-4663-AECD-6CAA334E1232@oracle.com>
References: <39142204-69FF-49BE-9FF1-D16B80E4A3F7@oracle.com>
	<5168A264.3070700@oracle.com>
	<3C52BCA3-1721-4663-AECD-6CAA334E1232@oracle.com>
Message-ID: <516B3E38.7020203@oracle.com>

Hi Chris,

On 14/04/2013 2:03 PM, Christian Thalinger wrote:
>
> On Apr 12, 2013, at 5:10 PM, David Holmes  wrote:
>
>> Hi Chris,
>>
>> On 13/04/2013 4:58 AM, Christian Thalinger wrote:
>>> http://cr.openjdk.java.net/~twisti/7172922
>>>
>>> 7172922: export_ makefile targets do not work unless all supported variants are built
>>> Reviewed-by:
>>>
>>> GEN_DIR can be overwritten by other configurations if multiple JVM_VARIANT_*s are defined. The fix is to use the *_BASE_DIRs directly to install the correct files.
>>>
>>> make/Makefile
>>
>> This looks like a simple temporary solution - thanks.
>
> Yes, it's not perfect but good enough for now.
>
>>
>> More long term I hope we should be able to generate the set of targets based on the selected JVM_VARIANTS, without needing all those duplicated blocks.
>>
>> One query with the current situation: why doesn't MISC_DIR cause us a problem? It would seem to have the same issue as GEN_DIR. ???
>
> MISC_DIR has the same problem but I didn't want to mess with Windows.
>
> How about this one?
>
> http://cr.openjdk.java.net/~twisti/7172922

I like the addition simplification of getting rid of BASE_DIR and MISC_DIR.

However I think you still need conditionals for Windows otherwise this:

  315 $(EXPORT_JRE_BIN_DIR)/%.diz:                    $(C2_DIR)/%.diz
  316         $(install-file)

for example, is going to be executed for all platforms and dump the diz 
files into the bin directory.

David
-----

> -- Chris
>
>>
>> Thanks,
>> David
>>
>

From kevin.walls at oracle.com  Sun Apr 14 16:54:02 2013
From: kevin.walls at oracle.com (kevin.walls at oracle.com)
Date: Sun, 14 Apr 2013 23:54:02 +0000
Subject: hg: hsx/hsx24/hotspot: 8010514: G1: Concurrent mode failure tracing
	event
Message-ID: <20130414235418.1B441482D1@hg.openjdk.java.net>

Changeset: ad278ee734e4
Author:    kevinw
Date:      2013-04-14 22:26 +0100
URL:       http://hg.openjdk.java.net/hsx/hsx24/hotspot/rev/ad278ee734e4

8010514: G1: Concurrent mode failure tracing event
Reviewed-by: jwilhelm, johnc

! src/share/vm/gc_implementation/g1/concurrentMark.hpp
! src/share/vm/gc_implementation/g1/g1CollectedHeap.cpp
! src/share/vm/gc_implementation/shared/gcTrace.cpp
! src/share/vm/gc_implementation/shared/gcTrace.hpp
! src/share/vm/gc_implementation/shared/gcTraceSend.cpp


From zhengyu.gu at oracle.com  Sun Apr 14 18:50:17 2013
From: zhengyu.gu at oracle.com (zhengyu.gu at oracle.com)
Date: Mon, 15 Apr 2013 01:50:17 +0000
Subject: hg: hsx/hsx24/hotspot: 2 new changesets
Message-ID: <20130415015044.D0FCF482D6@hg.openjdk.java.net>

Changeset: 24b1584443e9
Author:    zgu
Date:      2013-04-14 18:08 -0400
URL:       http://hg.openjdk.java.net/hsx/hsx24/hotspot/rev/24b1584443e9

8010151: nsk/regression/b6653214 fails "assert(snapshot != NULL) failed: Worker should not be started"
Summary: Fixed a racing condition when shutting down NMT while worker thread is being started, also fixed a few mis-declared volatile pointers.
Reviewed-by: dholmes, dlong

! src/share/vm/runtime/thread.hpp
! src/share/vm/services/memTrackWorker.cpp
! src/share/vm/services/memTrackWorker.hpp
! src/share/vm/services/memTracker.cpp
! src/share/vm/services/memTracker.hpp

Changeset: 87f5d2977493
Author:    zgu
Date:      2013-04-14 19:57 -0400
URL:       http://hg.openjdk.java.net/hsx/hsx24/hotspot/rev/87f5d2977493

Merge



From christian.thalinger at oracle.com  Sun Apr 14 21:36:25 2013
From: christian.thalinger at oracle.com (Christian Thalinger)
Date: Sun, 14 Apr 2013 21:36:25 -0700
Subject: RFR (S): 7172922: export_ makefile targets do not work unless all
	supported variants are built
In-Reply-To: <516B3E38.7020203@oracle.com>
References: <39142204-69FF-49BE-9FF1-D16B80E4A3F7@oracle.com>
	<5168A264.3070700@oracle.com>
	<3C52BCA3-1721-4663-AECD-6CAA334E1232@oracle.com>
	<516B3E38.7020203@oracle.com>
Message-ID: <0AD290D1-E523-4DAD-B27C-FF93FFB1BD7F@oracle.com>


On Apr 14, 2013, at 4:39 PM, David Holmes  wrote:

> Hi Chris,
> 
> On 14/04/2013 2:03 PM, Christian Thalinger wrote:
>> 
>> On Apr 12, 2013, at 5:10 PM, David Holmes  wrote:
>> 
>>> Hi Chris,
>>> 
>>> On 13/04/2013 4:58 AM, Christian Thalinger wrote:
>>>> http://cr.openjdk.java.net/~twisti/7172922
>>>> 
>>>> 7172922: export_ makefile targets do not work unless all supported variants are built
>>>> Reviewed-by:
>>>> 
>>>> GEN_DIR can be overwritten by other configurations if multiple JVM_VARIANT_*s are defined. The fix is to use the *_BASE_DIRs directly to install the correct files.
>>>> 
>>>> make/Makefile
>>> 
>>> This looks like a simple temporary solution - thanks.
>> 
>> Yes, it's not perfect but good enough for now.
>> 
>>> 
>>> More long term I hope we should be able to generate the set of targets based on the selected JVM_VARIANTS, without needing all those duplicated blocks.
>>> 
>>> One query with the current situation: why doesn't MISC_DIR cause us a problem? It would seem to have the same issue as GEN_DIR. ???
>> 
>> MISC_DIR has the same problem but I didn't want to mess with Windows.
>> 
>> How about this one?
>> 
>> http://cr.openjdk.java.net/~twisti/7172922
> 
> I like the addition simplification of getting rid of BASE_DIR and MISC_DIR.
> 
> However I think you still need conditionals for Windows otherwise this:
> 
> 315 $(EXPORT_JRE_BIN_DIR)/%.diz:                    $(C2_DIR)/%.diz
> 316         $(install-file)
> 
> for example, is going to be executed for all platforms and dump the diz files into the bin directory.

Only if a $(EXPORT_JRE_BIN_DIR)/*.diz file is on the EXPORT_LIST.

-- Chris

> 
> David
> -----
> 
>> -- Chris
>> 
>>> 
>>> Thanks,
>>> David
>>> 
>> 


From david.holmes at oracle.com  Sun Apr 14 21:54:05 2013
From: david.holmes at oracle.com (David Holmes)
Date: Mon, 15 Apr 2013 14:54:05 +1000
Subject: RFR (S): 7172922: export_ makefile targets do not work unless
	all supported variants are built
In-Reply-To: <0AD290D1-E523-4DAD-B27C-FF93FFB1BD7F@oracle.com>
References: <39142204-69FF-49BE-9FF1-D16B80E4A3F7@oracle.com>
	<5168A264.3070700@oracle.com>
	<3C52BCA3-1721-4663-AECD-6CAA334E1232@oracle.com>
	<516B3E38.7020203@oracle.com>
	<0AD290D1-E523-4DAD-B27C-FF93FFB1BD7F@oracle.com>
Message-ID: <516B87ED.3070307@oracle.com>

On 15/04/2013 2:36 PM, Christian Thalinger wrote:
>
> On Apr 14, 2013, at 4:39 PM, David Holmes  wrote:
>
>> Hi Chris,
>>
>> On 14/04/2013 2:03 PM, Christian Thalinger wrote:
>>>
>>> On Apr 12, 2013, at 5:10 PM, David Holmes  wrote:
>>>
>>>> Hi Chris,
>>>>
>>>> On 13/04/2013 4:58 AM, Christian Thalinger wrote:
>>>>> http://cr.openjdk.java.net/~twisti/7172922
>>>>>
>>>>> 7172922: export_ makefile targets do not work unless all supported variants are built
>>>>> Reviewed-by:
>>>>>
>>>>> GEN_DIR can be overwritten by other configurations if multiple JVM_VARIANT_*s are defined. The fix is to use the *_BASE_DIRs directly to install the correct files.
>>>>>
>>>>> make/Makefile
>>>>
>>>> This looks like a simple temporary solution - thanks.
>>>
>>> Yes, it's not perfect but good enough for now.
>>>
>>>>
>>>> More long term I hope we should be able to generate the set of targets based on the selected JVM_VARIANTS, without needing all those duplicated blocks.
>>>>
>>>> One query with the current situation: why doesn't MISC_DIR cause us a problem? It would seem to have the same issue as GEN_DIR. ???
>>>
>>> MISC_DIR has the same problem but I didn't want to mess with Windows.
>>>
>>> How about this one?
>>>
>>> http://cr.openjdk.java.net/~twisti/7172922
>>
>> I like the addition simplification of getting rid of BASE_DIR and MISC_DIR.
>>
>> However I think you still need conditionals for Windows otherwise this:
>>
>> 315 $(EXPORT_JRE_BIN_DIR)/%.diz:                    $(C2_DIR)/%.diz
>> 316         $(install-file)
>>
>> for example, is going to be executed for all platforms and dump the diz files into the bin directory.
>
> Only if a $(EXPORT_JRE_BIN_DIR)/*.diz file is on the EXPORT_LIST.

Oops! My bad.

I still think I prefer seeing platform specific targets in platform 
specific conditionals, rather than using comments. But if we can macrofy 
this as the next step (different CR) then that can be handled once 
within the macro.

Thanks,
David

> -- Chris
>
>>
>> David
>> -----
>>
>>> -- Chris
>>>
>>>>
>>>> Thanks,
>>>> David
>>>>
>>>
>

From christian.thalinger at oracle.com  Sun Apr 14 21:56:23 2013
From: christian.thalinger at oracle.com (Christian Thalinger)
Date: Sun, 14 Apr 2013 21:56:23 -0700
Subject: RFR (S): 7172922: export_ makefile targets do not work unless all
	supported variants are built
In-Reply-To: <516B87ED.3070307@oracle.com>
References: <39142204-69FF-49BE-9FF1-D16B80E4A3F7@oracle.com>
	<5168A264.3070700@oracle.com>
	<3C52BCA3-1721-4663-AECD-6CAA334E1232@oracle.com>
	<516B3E38.7020203@oracle.com>
	<0AD290D1-E523-4DAD-B27C-FF93FFB1BD7F@oracle.com>
	<516B87ED.3070307@oracle.com>
Message-ID: <5D7DC7C7-1A55-4A83-90CE-6DC9EA9C909D@oracle.com>


On Apr 14, 2013, at 9:54 PM, David Holmes  wrote:

> On 15/04/2013 2:36 PM, Christian Thalinger wrote:
>> 
>> On Apr 14, 2013, at 4:39 PM, David Holmes  wrote:
>> 
>>> Hi Chris,
>>> 
>>> On 14/04/2013 2:03 PM, Christian Thalinger wrote:
>>>> 
>>>> On Apr 12, 2013, at 5:10 PM, David Holmes  wrote:
>>>> 
>>>>> Hi Chris,
>>>>> 
>>>>> On 13/04/2013 4:58 AM, Christian Thalinger wrote:
>>>>>> http://cr.openjdk.java.net/~twisti/7172922
>>>>>> 
>>>>>> 7172922: export_ makefile targets do not work unless all supported variants are built
>>>>>> Reviewed-by:
>>>>>> 
>>>>>> GEN_DIR can be overwritten by other configurations if multiple JVM_VARIANT_*s are defined. The fix is to use the *_BASE_DIRs directly to install the correct files.
>>>>>> 
>>>>>> make/Makefile
>>>>> 
>>>>> This looks like a simple temporary solution - thanks.
>>>> 
>>>> Yes, it's not perfect but good enough for now.
>>>> 
>>>>> 
>>>>> More long term I hope we should be able to generate the set of targets based on the selected JVM_VARIANTS, without needing all those duplicated blocks.
>>>>> 
>>>>> One query with the current situation: why doesn't MISC_DIR cause us a problem? It would seem to have the same issue as GEN_DIR. ???
>>>> 
>>>> MISC_DIR has the same problem but I didn't want to mess with Windows.
>>>> 
>>>> How about this one?
>>>> 
>>>> http://cr.openjdk.java.net/~twisti/7172922
>>> 
>>> I like the addition simplification of getting rid of BASE_DIR and MISC_DIR.
>>> 
>>> However I think you still need conditionals for Windows otherwise this:
>>> 
>>> 315 $(EXPORT_JRE_BIN_DIR)/%.diz:                    $(C2_DIR)/%.diz
>>> 316         $(install-file)
>>> 
>>> for example, is going to be executed for all platforms and dump the diz files into the bin directory.
>> 
>> Only if a $(EXPORT_JRE_BIN_DIR)/*.diz file is on the EXPORT_LIST.
> 
> Oops! My bad.
> 
> I still think I prefer seeing platform specific targets in platform specific conditionals, rather than using comments.

I don't have a strong opinion about this.  Will add the ifdefs tomorrow.

-- Chris

> But if we can macrofy this as the next step (different CR) then that can be handled once within the macro.
> 
> Thanks,
> David
> 
>> -- Chris
>> 
>>> 
>>> David
>>> -----
>>> 
>>>> -- Chris
>>>> 
>>>>> 
>>>>> Thanks,
>>>>> David
>>>>> 
>>>> 
>> 


From david.holmes at oracle.com  Sun Apr 14 22:12:23 2013
From: david.holmes at oracle.com (David Holmes)
Date: Mon, 15 Apr 2013 15:12:23 +1000
Subject: hs25 review request (2nd round): 8008511 JSR 292: MemberName
	vmtarget refs to methods must be updated at class redefinition
In-Reply-To: <5168BF57.3030206@oracle.com>
References: <5168BF57.3030206@oracle.com>
Message-ID: <516B8C37.7020002@oracle.com>

Hi Serguei,

Not a full review ...

In instanceKlass.cpp:

+   MemberNameTable* mnt = member_names();
+   if (mnt != NULL) {
+     delete mnt;
+   }

a) do we need to call set_member_names(null) ?
b) do we need to use the MemberNameTable_lock to guard this?

---

I'm still concerned about the removal of the No_Safepoint_verifier. Has 
whomever added it indicated that removing it is indeed okay?

Thanks,
David

On 13/04/2013 12:13 PM, serguei.spitsyn at oracle.com wrote:
>
> Please, review the following fix.
>
> This is the 2nd version that has a review fixes suggested by Coleen and
> John in the 1st review round.
>
> Now the mtClass is used in allocation of MemberNameTable since it's part
> of class metadata.
> All call sites in the methodHandles.cpp that recursively invoke the
> add_member_name()
> are made safepoint-safe by replacing oop's with Handle's.
> This allowed to get rid of the No_Safepoint_Verifier in the
> find_MemberNames.
> The MemberName's are added to MNT not only for methods but also for fields.
>
> Coleen,
> You also suggested to put all new non-jvmti code under #if INCLUDE_JVMTI
> condition.
> I've not done it because now the MemberName's associated with the fields
> are
> also registered in the MNT which is not needed for JVMTI purposes.
> Just have some doubt if it is a right thing to do.
> I'm Ok to add this modification, but could you, confirm that it is still
> important.
>
>
> Webrev:
> http://cr.openjdk.java.net/~sspitsyn/webrevs/2013/hotspot/8008511-JVMTI-JSR292.2/
>
>
> Bug:
> http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=8008511
> https://jbs.oracle.com/bugs/browse/JDK-8008511
>
>
> The problem is that the old version of the bootstrap method is re-invoked
> after a popframe from the bootstrap method execution.
> It is because the MemberName keeps a stale reference to the old method
> version.
>
> The solution (suggested by John) is to lazily create and keep up-to-date
> a MemberNameTable
> which plays a role of MemberName cache assosiated with the InstanceKlass.
> Then, at class redefinition, this cache is used to replace the old method
> references in the MemberName's with the new method references.
>
> The MemberNameTable is based on the GrowableArray.
> A C_HEAP array is allocated at the first call to
> InstanceKlass::add_member_name().
> It is released in the InstanceKlass::release_C_heap_structures().
>
> A global week reference to member name oop is stored in the
> MemberNameTable.
> It allowed to avoid having the oops_do() in the MemberNameTable.
> Also, the MemberNameTable won't hold member name oops in memory.
>
> The MemberNameTable_lock mutex is added to serialize MemberNameTable's
> updates.
>
> Test coverage: vm.mlvm, nsk.jvmti, nsk.jdi tests on multiple platforms
> (32 vs 64-bit too).
> The testing looks good.
>
>
> Thanks,
> Serguei

From david.holmes at oracle.com  Sun Apr 14 22:14:24 2013
From: david.holmes at oracle.com (David Holmes)
Date: Mon, 15 Apr 2013 15:14:24 +1000
Subject: RFR (S): 7172922: export_ makefile targets do not work unless
	all supported variants are built
In-Reply-To: <5D7DC7C7-1A55-4A83-90CE-6DC9EA9C909D@oracle.com>
References: <39142204-69FF-49BE-9FF1-D16B80E4A3F7@oracle.com>
	<5168A264.3070700@oracle.com>
	<3C52BCA3-1721-4663-AECD-6CAA334E1232@oracle.com>
	<516B3E38.7020203@oracle.com>
	<0AD290D1-E523-4DAD-B27C-FF93FFB1BD7F@oracle.com>
	<516B87ED.3070307@oracle.com>
	<5D7DC7C7-1A55-4A83-90CE-6DC9EA9C909D@oracle.com>
Message-ID: <516B8CB0.4040608@oracle.com>

On 15/04/2013 2:56 PM, Christian Thalinger wrote:
>
> On Apr 14, 2013, at 9:54 PM, David Holmes  wrote:
>
>> On 15/04/2013 2:36 PM, Christian Thalinger wrote:
>>>
>>> On Apr 14, 2013, at 4:39 PM, David Holmes  wrote:
>>>
>>>> Hi Chris,
>>>>
>>>> On 14/04/2013 2:03 PM, Christian Thalinger wrote:
>>>>>
>>>>> On Apr 12, 2013, at 5:10 PM, David Holmes  wrote:
>>>>>
>>>>>> Hi Chris,
>>>>>>
>>>>>> On 13/04/2013 4:58 AM, Christian Thalinger wrote:
>>>>>>> http://cr.openjdk.java.net/~twisti/7172922
>>>>>>>
>>>>>>> 7172922: export_ makefile targets do not work unless all supported variants are built
>>>>>>> Reviewed-by:
>>>>>>>
>>>>>>> GEN_DIR can be overwritten by other configurations if multiple JVM_VARIANT_*s are defined. The fix is to use the *_BASE_DIRs directly to install the correct files.
>>>>>>>
>>>>>>> make/Makefile
>>>>>>
>>>>>> This looks like a simple temporary solution - thanks.
>>>>>
>>>>> Yes, it's not perfect but good enough for now.
>>>>>
>>>>>>
>>>>>> More long term I hope we should be able to generate the set of targets based on the selected JVM_VARIANTS, without needing all those duplicated blocks.
>>>>>>
>>>>>> One query with the current situation: why doesn't MISC_DIR cause us a problem? It would seem to have the same issue as GEN_DIR. ???
>>>>>
>>>>> MISC_DIR has the same problem but I didn't want to mess with Windows.
>>>>>
>>>>> How about this one?
>>>>>
>>>>> http://cr.openjdk.java.net/~twisti/7172922
>>>>
>>>> I like the addition simplification of getting rid of BASE_DIR and MISC_DIR.
>>>>
>>>> However I think you still need conditionals for Windows otherwise this:
>>>>
>>>> 315 $(EXPORT_JRE_BIN_DIR)/%.diz:                    $(C2_DIR)/%.diz
>>>> 316         $(install-file)
>>>>
>>>> for example, is going to be executed for all platforms and dump the diz files into the bin directory.
>>>
>>> Only if a $(EXPORT_JRE_BIN_DIR)/*.diz file is on the EXPORT_LIST.
>>
>> Oops! My bad.
>>
>> I still think I prefer seeing platform specific targets in platform specific conditionals, rather than using comments.
>
> I don't have a strong opinion about this.  Will add the ifdefs tomorrow.

Don't bother unless someone else feels strongly about it. (I don't want 
to have to re-review :) )

David
-----

> -- Chris
>
>> But if we can macrofy this as the next step (different CR) then that can be handled once within the macro.
>>
>> Thanks,
>> David
>>
>>> -- Chris
>>>
>>>>
>>>> David
>>>> -----
>>>>
>>>>> -- Chris
>>>>>
>>>>>>
>>>>>> Thanks,
>>>>>> David
>>>>>>
>>>>>
>>>
>

From christian.thalinger at oracle.com  Sun Apr 14 22:17:34 2013
From: christian.thalinger at oracle.com (Christian Thalinger)
Date: Sun, 14 Apr 2013 22:17:34 -0700
Subject: RFR (S): 7172922: export_ makefile targets do not work unless all
	supported variants are built
In-Reply-To: <516B8CB0.4040608@oracle.com>
References: <39142204-69FF-49BE-9FF1-D16B80E4A3F7@oracle.com>
	<5168A264.3070700@oracle.com>
	<3C52BCA3-1721-4663-AECD-6CAA334E1232@oracle.com>
	<516B3E38.7020203@oracle.com>
	<0AD290D1-E523-4DAD-B27C-FF93FFB1BD7F@oracle.com>
	<516B87ED.3070307@oracle.com>
	<5D7DC7C7-1A55-4A83-90CE-6DC9EA9C909D@oracle.com>
	<516B8CB0.4040608@oracle.com>
Message-ID: 


On Apr 14, 2013, at 10:14 PM, David Holmes  wrote:

> On 15/04/2013 2:56 PM, Christian Thalinger wrote:
>> 
>> On Apr 14, 2013, at 9:54 PM, David Holmes  wrote:
>> 
>>> On 15/04/2013 2:36 PM, Christian Thalinger wrote:
>>>> 
>>>> On Apr 14, 2013, at 4:39 PM, David Holmes  wrote:
>>>> 
>>>>> Hi Chris,
>>>>> 
>>>>> On 14/04/2013 2:03 PM, Christian Thalinger wrote:
>>>>>> 
>>>>>> On Apr 12, 2013, at 5:10 PM, David Holmes  wrote:
>>>>>> 
>>>>>>> Hi Chris,
>>>>>>> 
>>>>>>> On 13/04/2013 4:58 AM, Christian Thalinger wrote:
>>>>>>>> http://cr.openjdk.java.net/~twisti/7172922
>>>>>>>> 
>>>>>>>> 7172922: export_ makefile targets do not work unless all supported variants are built
>>>>>>>> Reviewed-by:
>>>>>>>> 
>>>>>>>> GEN_DIR can be overwritten by other configurations if multiple JVM_VARIANT_*s are defined. The fix is to use the *_BASE_DIRs directly to install the correct files.
>>>>>>>> 
>>>>>>>> make/Makefile
>>>>>>> 
>>>>>>> This looks like a simple temporary solution - thanks.
>>>>>> 
>>>>>> Yes, it's not perfect but good enough for now.
>>>>>> 
>>>>>>> 
>>>>>>> More long term I hope we should be able to generate the set of targets based on the selected JVM_VARIANTS, without needing all those duplicated blocks.
>>>>>>> 
>>>>>>> One query with the current situation: why doesn't MISC_DIR cause us a problem? It would seem to have the same issue as GEN_DIR. ???
>>>>>> 
>>>>>> MISC_DIR has the same problem but I didn't want to mess with Windows.
>>>>>> 
>>>>>> How about this one?
>>>>>> 
>>>>>> http://cr.openjdk.java.net/~twisti/7172922
>>>>> 
>>>>> I like the addition simplification of getting rid of BASE_DIR and MISC_DIR.
>>>>> 
>>>>> However I think you still need conditionals for Windows otherwise this:
>>>>> 
>>>>> 315 $(EXPORT_JRE_BIN_DIR)/%.diz:                    $(C2_DIR)/%.diz
>>>>> 316         $(install-file)
>>>>> 
>>>>> for example, is going to be executed for all platforms and dump the diz files into the bin directory.
>>>> 
>>>> Only if a $(EXPORT_JRE_BIN_DIR)/*.diz file is on the EXPORT_LIST.
>>> 
>>> Oops! My bad.
>>> 
>>> I still think I prefer seeing platform specific targets in platform specific conditionals, rather than using comments.
>> 
>> I don't have a strong opinion about this.  Will add the ifdefs tomorrow.
> 
> Don't bother unless someone else feels strongly about it. (I don't want to have to re-review :) )

Even better :-)  If there are no objections tomorrow I will push it.  Thanks for reviewing.

-- Chris

> 
> David
> -----
> 
>> -- Chris
>> 
>>> But if we can macrofy this as the next step (different CR) then that can be handled once within the macro.
>>> 
>>> Thanks,
>>> David
>>> 
>>>> -- Chris
>>>> 
>>>>> 
>>>>> David
>>>>> -----
>>>>> 
>>>>>> -- Chris
>>>>>> 
>>>>>>> 
>>>>>>> Thanks,
>>>>>>> David
>>>>>>> 
>>>>>> 
>>>> 
>> 


From mikael.gerdin at oracle.com  Mon Apr 15 01:23:25 2013
From: mikael.gerdin at oracle.com (Mikael Gerdin)
Date: Mon, 15 Apr 2013 10:23:25 +0200
Subject: RFR (S): 8011803: release_C_heap_structures is never called for
	anonymous classes.
In-Reply-To: <51687E59.6060702@oracle.com>
References: <51672297.3080503@oracle.com> <5167CA4C.5040608@oracle.com>
	<51680041.5070905@oracle.com> <51685A67.4020007@oracle.com>
	<51687E59.6060702@oracle.com>
Message-ID: <516BB8FD.4030001@oracle.com>

Coleen,

On 2013-04-12 23:36, Coleen Phillimore wrote:
> On 4/12/2013 3:03 PM, Coleen Phillimore wrote:
>>
>> Hi,
>>
>> I have updated the webrev to split the serviceability actions and the
>> deleting C heap data for classes in ClassLoaderData.  I left the
>> serviceability actions in dictionary::do_unloading() to avoid
>> rewalking the ClassLoaderData _klasses.   For
>> release_C_heap_structures(), all the _klasses are walked at the end.
>> This should work for Markus G's new serviceability changes with minor
>> modifications.
>
> Reload if you looked at this already.  Stefan convinced me that walking
> the class list in the ClassLoaderData::unload() is not too expensive, so
> the serviceability actions have been removed from
> dictionary::do_unloading() and done in ClassLoaderData::unload()
> unconditionally.

It looks like http://cr.openjdk.java.net/~coleenp/8011803_2/ is the 
wrong webrev since it's inconsistent with your mail.
But I have some comments about moving the calls to 
release_c_heap_structures.

By moving the calls to {IK,CP}::release_c_heap_structures to 
~ClassLoaderData they will be called concurrently from the CMS thread 
through its call to ClassLoaderDataGraph::purge.

Previously they were called at a safepoint since 
Dictionary::do_unloading is only called at safepoint.
A cursory inspection suggests that this is safe.

However.
This will cause the symbol refcounts to be decremented at a later stage 
than before, in fact by the time we come to ~ClassLoaderData we've 
already called SymbolTable::unkink so this will artificially extend the 
lifetime of unreferenced symbols by one full gc.

/Mikael

>
>>
>> open webrev at http://cr.openjdk.java.net/~coleenp/8011803_2/
>>
>> thanks,
>> Coleen
>>
>> On 4/12/2013 8:38 AM, Coleen Phillimore wrote:
>>> On 4/12/2013 4:48 AM, Stefan Karlsson wrote:
>>>> On 04/11/2013 10:52 PM, Coleen Phillimore wrote:
>>>>> Summary: Call this function from CLD::unload()  now for anonymous
>>>>> classes.
>>>>>
>>>>> Anonymous classes aren't in the system dictionary so
>>>>> release_C_heap_structures isn't called for them if they are
>>>>> unloaded.  I fixed this for jdk8 because they are in the class
>>>>> loader data graph but for jdk7, I don't know how to fix this. They
>>>>> are unloaded by being garbage collected after the references are
>>>>> dropped.
>>>>>
>>>>> Tested with ute tests vm.mvlm.testlist nsk.monitoring.testlist and
>>>>> jdk/test/java/lang/invoke tests.
>>>>>
>>>>> open webrev at http://cr.openjdk.java.net/~coleenp/8011803/
>>>>> bug link at http://bugs.sun.com/view_bug.do?bug_id=8011803
>>>>
>>>> I've two comments.
>>>>
>>>> 1) It's unfortunate that we now call unload_class() at two different
>>>> places in the code. It makes it harder to understand the
>>>> deallocation of metadata. It would be better to keep the calls to
>>>> unload_class() for ordinary InstanceKlasses and anonymous classes
>>>> together.
>>>
>>> Hi Stefan,  Thank you for looking at this.   This is the feedback I
>>> was looking for.
>>>
>>> I went back and forth about moving the regular class unloading
>>> actions for everything in unload (or ~ClassLoaderData), but I didn't
>>> want to introduce a _klasses walk for all the class loaders.   We're
>>> already walking them in the system dictionary purge.
>>>
>>> For my change I'm walking these classes if
>>> UseCompressedKlassPointers, and Markus is walking them for
>>> serviceability (hopefully under some flag) so maybe I should just do it.
>>>
>>>>
>>>> 2) This change actually breaks the Tracing class unloading event
>>>> that Markus is working on. That code walk the
>>>> ClassLoaderDataGraph::_unloading list in
>>>> ClassLoaderDataGraph::do_unloading and use the information in the
>>>> classes of the CLDs that are about to be unloaded. With this patch
>>>> they probably crash because some pointers in the anonymous classes
>>>> will be trashed.
>>>>
>>>
>>> I thought about that, since I've been talking to Markus about this. I
>>> wanted to consolidate the serviceability calls in one place and
>>> calling InstanceKlass::unload_class() that notifies serviceability in
>>> the ~ClassLoaderData destructor might be too late.  It might not be
>>> though.   I think the walk in the destructor might be better for
>>> release_C_heap_structures though.
>>>
>>>> I have a suggestion on how to solve both points above. It's probably
>>>> easier to show with a pseudo patch:
>>>>
>>>> $ hg diff
>>>> diff --git a/src/share/vm/classfile/classLoaderData.cpp
>>>> b/src/share/vm/classfile/classLoaderData.cpp
>>>> --- a/src/share/vm/classfile/classLoaderData.cpp
>>>> +++ b/src/share/vm/classfile/classLoaderData.cpp
>>>> @@ -671,7 +671,6 @@
>>>>      }
>>>>      seen_dead_loader = true;
>>>>      ClassLoaderData* dead = data;
>>>> -    dead->unload();
>>>>      data = data->next();
>>>>      // Remove from loader list.
>>>>      if (prev != NULL) {
>>>> @@ -683,9 +682,24 @@
>>>>      dead->set_next(_unloading);
>>>>      _unloading = dead;
>>>>    }
>>>> +
>>>> +  report_class_unloading_info(_unloading);
>>>> +
>>>> +  ClassLoaderDataGraph::unload_classes();
>>>> +
>>>>    return seen_dead_loader;
>>>>  }
>>>>
>>>> +void ClassLoaderDataGraph::unload_classes() {
>>>> +  ClassLoaderData* list = _unloading;
>>>> +  ClassLoaderData* next = list;
>>>> +  while (next != NULL) {
>>>> +    for (Klass* k = next->_klasses; k != NULL; k = k->next_link()) {
>>>> +      k->unload_class();
>>>> +    }
>>>> +  }
>>>> +}
>>>> +
>>>
>>> That's too much extra walking.   But maybe we can split the
>>> serviceability stuff into ClassLoaderData::unload() and do the
>>> release_C_heap_structures() into the ClassLoaderData destructor. That
>>> seems better.   Maybe Markus could put his callback into CLD::unload().
>>>
>>> Thanks!  I will change this and resend.
>>> Coleen
>>>
>>>>  void ClassLoaderDataGraph::purge() {
>>>>    ClassLoaderData* list = _unloading;
>>>>    _unloading = NULL;
>>>> diff --git a/src/share/vm/classfile/dictionary.cpp
>>>> b/src/share/vm/classfile/dictionary.cpp
>>>> --- a/src/share/vm/classfile/dictionary.cpp
>>>> +++ b/src/share/vm/classfile/dictionary.cpp
>>>> @@ -157,9 +157,6 @@
>>>>              // to be unloaded.
>>>>              // Notify the debugger and clean up the class.
>>>>              class_was_unloaded = true;
>>>> -
>>>> -            // perform unloading actions on this class
>>>> -            ik->unload_class();
>>>>            }
>>>>            // Also remove this system dictionary entry.
>>>>            purge_entry = true;
>>>>
>>>> As a bonus, the dictionary()->do_unloading() will then only do a
>>>> simple purge of the SystemDictionary.
>>>>
>>>> What do you think?
>>>>
>>>> thanks,
>>>> StefanK
>>>>
>>>>>
>>>>> Thanks,
>>>>> Coleen
>>>>
>>>
>>
>

From nils.loodin at oracle.com  Mon Apr 15 02:50:30 2013
From: nils.loodin at oracle.com (Nils Loodin)
Date: Mon, 15 Apr 2013 11:50:30 +0200
Subject: RFR: JDK-8012212 - link against kstat on solaris x86
Message-ID: <516BCD66.7080904@oracle.com>

Any reviewers for this unassuming change to not exclude sparc from 
linking against kstat?

Regards,
Nils Loodin

From nils.loodin at oracle.com  Mon Apr 15 05:35:17 2013
From: nils.loodin at oracle.com (Nils Loodin)
Date: Mon, 15 Apr 2013 14:35:17 +0200
Subject: RFR: JDK-8012212 - link against kstat on solaris x86
In-Reply-To: <516BCD66.7080904@oracle.com>
References: <516BCD66.7080904@oracle.com>
Message-ID: <516BF405.7010303@oracle.com>

And here is the actual link to the webrev... sigh.

http://cr.openjdk.java.net/~nloodin/8012212/webrev.00/

/Nisse



On 04/15/2013 11:50 AM, Nils Loodin wrote:
> Any reviewers for this unassuming change to not exclude sparc from
> linking against kstat?
>
> Regards,
> Nils Loodin


From nils.loodin at oracle.com  Mon Apr 15 08:14:34 2013
From: nils.loodin at oracle.com (nils.loodin at oracle.com)
Date: Mon, 15 Apr 2013 15:14:34 +0000
Subject: hg: hsx/hsx24/hotspot: 8007150: Event based tracing is missing
	truncated field in stack trace content type
Message-ID: <20130415151436.C4B96482F1@hg.openjdk.java.net>

Changeset: 3cb217881b6c
Author:    egahlin
Date:      2013-04-02 19:17 +0200
URL:       http://hg.openjdk.java.net/hsx/hsx24/hotspot/rev/3cb217881b6c

8007150: Event based tracing is missing truncated field in stack trace content type
Reviewed-by: stefank, sla, mgronlun

! src/share/vm/trace/tracetypes.xml


From vladimir.kozlov at oracle.com  Mon Apr 15 10:00:19 2013
From: vladimir.kozlov at oracle.com (Vladimir Kozlov)
Date: Mon, 15 Apr 2013 10:00:19 -0700
Subject: RFR: JDK-8012212 - link against kstat on solaris x86
In-Reply-To: <516BF405.7010303@oracle.com>
References: <516BCD66.7080904@oracle.com> <516BF405.7010303@oracle.com>
Message-ID: <516C3223.8060000@oracle.com>

Nils,

Do you have future work in plan for this? You should do this change only 
when you add a code to really use data from kstat on x86.
Currently kstat is only used on SPARC to get CPU information (since it 
doesn't have cpuid instruction). No kstat counters are read in VM.

Thanks,
Vladimir

On 4/15/13 5:35 AM, Nils Loodin wrote:
> And here is the actual link to the webrev... sigh.
>
> http://cr.openjdk.java.net/~nloodin/8012212/webrev.00/
>
> /Nisse
>
>
>
> On 04/15/2013 11:50 AM, Nils Loodin wrote:
>> Any reviewers for this unassuming change to not exclude sparc from
>> linking against kstat?
>>
>> Regards,
>> Nils Loodin
>

From vladimir.kozlov at oracle.com  Mon Apr 15 10:52:29 2013
From: vladimir.kozlov at oracle.com (Vladimir Kozlov)
Date: Mon, 15 Apr 2013 10:52:29 -0700
Subject: RFR (S): 7172922: export_ makefile targets do not work unless
	all supported variants are built
In-Reply-To: 
References: <39142204-69FF-49BE-9FF1-D16B80E4A3F7@oracle.com>
	<5168A264.3070700@oracle.com>
	<3C52BCA3-1721-4663-AECD-6CAA334E1232@oracle.com>
	<516B3E38.7020203@oracle.com>
	<0AD290D1-E523-4DAD-B27C-FF93FFB1BD7F@oracle.com>
	<516B87ED.3070307@oracle.com>
	<5D7DC7C7-1A55-4A83-90CE-6DC9EA9C909D@oracle.com>
	<516B8CB0.4040608@oracle.com>
	
Message-ID: <516C3E5D.6060501@oracle.com>

Christian,

First, you should start using webrev versions so we can follow your 
changes during reviews.

Changes are fine. I wish there was a way to avoid duplicated code 
(functions in Makefiles?).

Thanks,
Vladimir

On 4/14/13 10:17 PM, Christian Thalinger wrote:
>
> On Apr 14, 2013, at 10:14 PM, David Holmes  wrote:
>
>> On 15/04/2013 2:56 PM, Christian Thalinger wrote:
>>>
>>> On Apr 14, 2013, at 9:54 PM, David Holmes  wrote:
>>>
>>>> On 15/04/2013 2:36 PM, Christian Thalinger wrote:
>>>>>
>>>>> On Apr 14, 2013, at 4:39 PM, David Holmes  wrote:
>>>>>
>>>>>> Hi Chris,
>>>>>>
>>>>>> On 14/04/2013 2:03 PM, Christian Thalinger wrote:
>>>>>>>
>>>>>>> On Apr 12, 2013, at 5:10 PM, David Holmes  wrote:
>>>>>>>
>>>>>>>> Hi Chris,
>>>>>>>>
>>>>>>>> On 13/04/2013 4:58 AM, Christian Thalinger wrote:
>>>>>>>>> http://cr.openjdk.java.net/~twisti/7172922
>>>>>>>>>
>>>>>>>>> 7172922: export_ makefile targets do not work unless all supported variants are built
>>>>>>>>> Reviewed-by:
>>>>>>>>>
>>>>>>>>> GEN_DIR can be overwritten by other configurations if multiple JVM_VARIANT_*s are defined. The fix is to use the *_BASE_DIRs directly to install the correct files.
>>>>>>>>>
>>>>>>>>> make/Makefile
>>>>>>>>
>>>>>>>> This looks like a simple temporary solution - thanks.
>>>>>>>
>>>>>>> Yes, it's not perfect but good enough for now.
>>>>>>>
>>>>>>>>
>>>>>>>> More long term I hope we should be able to generate the set of targets based on the selected JVM_VARIANTS, without needing all those duplicated blocks.
>>>>>>>>
>>>>>>>> One query with the current situation: why doesn't MISC_DIR cause us a problem? It would seem to have the same issue as GEN_DIR. ???
>>>>>>>
>>>>>>> MISC_DIR has the same problem but I didn't want to mess with Windows.
>>>>>>>
>>>>>>> How about this one?
>>>>>>>
>>>>>>> http://cr.openjdk.java.net/~twisti/7172922
>>>>>>
>>>>>> I like the addition simplification of getting rid of BASE_DIR and MISC_DIR.
>>>>>>
>>>>>> However I think you still need conditionals for Windows otherwise this:
>>>>>>
>>>>>> 315 $(EXPORT_JRE_BIN_DIR)/%.diz:                    $(C2_DIR)/%.diz
>>>>>> 316         $(install-file)
>>>>>>
>>>>>> for example, is going to be executed for all platforms and dump the diz files into the bin directory.
>>>>>
>>>>> Only if a $(EXPORT_JRE_BIN_DIR)/*.diz file is on the EXPORT_LIST.
>>>>
>>>> Oops! My bad.
>>>>
>>>> I still think I prefer seeing platform specific targets in platform specific conditionals, rather than using comments.
>>>
>>> I don't have a strong opinion about this.  Will add the ifdefs tomorrow.
>>
>> Don't bother unless someone else feels strongly about it. (I don't want to have to re-review :) )
>
> Even better :-)  If there are no objections tomorrow I will push it.  Thanks for reviewing.
>
> -- Chris
>
>>
>> David
>> -----
>>
>>> -- Chris
>>>
>>>> But if we can macrofy this as the next step (different CR) then that can be handled once within the macro.
>>>>
>>>> Thanks,
>>>> David
>>>>
>>>>> -- Chris
>>>>>
>>>>>>
>>>>>> David
>>>>>> -----
>>>>>>
>>>>>>> -- Chris
>>>>>>>
>>>>>>>>
>>>>>>>> Thanks,
>>>>>>>> David
>>>>>>>>
>>>>>>>
>>>>>
>>>
>

From serguei.spitsyn at oracle.com  Mon Apr 15 10:59:25 2013
From: serguei.spitsyn at oracle.com (serguei.spitsyn at oracle.com)
Date: Mon, 15 Apr 2013 10:59:25 -0700
Subject: hs25 review request (2nd round): 8008511 JSR 292: MemberName
	vmtarget refs to methods must be updated at class redefinition
In-Reply-To: <516B8C37.7020002@oracle.com>
References: <5168BF57.3030206@oracle.com> <516B8C37.7020002@oracle.com>
Message-ID: <516C3FFD.9040606@oracle.com>

Hi David,


Thank you for the comments!


On 4/14/13 10:12 PM, David Holmes wrote:
> Hi Serguei,
>
> Not a full review ...
>
> In instanceKlass.cpp:
>
> +   MemberNameTable* mnt = member_names();
> +   if (mnt != NULL) {
> +     delete mnt;
> +   }
>
> a) do we need to call set_member_names(null) ?

Fixed, thanks.


> b) do we need to use the MemberNameTable_lock to guard this?

I don't think so.
This deallocation must be done at a safepoint.
We can't grab locks at safepoints.

These are the details:

classLoaderData.cpp:

// Deallocate free metadata on the free list.  How useful the PermGen was!
void ClassLoaderData::free_deallocate_list() {
   // Don't need lock, at safepoint
assert(SafepointSynchronize::is_at_safepoint(), "only called at safepoint");
       . . .
       } else if (m->is_klass()) {
         MetadataFactory::free_metadata(this, (InstanceKlass*)m);
      . . .
}

metadataFactory.hpp:

   // Deallocation method for metadata
   template 
   static void free_metadata(ClassLoaderData* loader_data, T md) {
     if (md != NULL) {
       . . .
       md->deallocate_contents(loader_data);
loader_data->metaspace_non_null()->deallocate((MetaWord*)md, size, 
md->is_klass());
     }
   }

instanceKlass.cpp:

void InstanceKlass::deallocate_contents(ClassLoaderData* loader_data) {
   . . .
   release_C_heap_structures();
   . . .
}

>
> ---
>
> I'm still concerned about the removal of the No_Safepoint_verifier. 
> Has whomever added it indicated that removing it is indeed okay?

Yes, John confirmed that it it is Ok to remove the No_Safepoint_verifier.
We added handles (see methodHandles.cpp) for all potentially impacted oops.


Thanks!
Serguei

>
> Thanks,
> David
>
> On 13/04/2013 12:13 PM, serguei.spitsyn at oracle.com wrote:
>>
>> Please, review the following fix.
>>
>> This is the 2nd version that has a review fixes suggested by Coleen and
>> John in the 1st review round.
>>
>> Now the mtClass is used in allocation of MemberNameTable since it's part
>> of class metadata.
>> All call sites in the methodHandles.cpp that recursively invoke the
>> add_member_name()
>> are made safepoint-safe by replacing oop's with Handle's.
>> This allowed to get rid of the No_Safepoint_Verifier in the
>> find_MemberNames.
>> The MemberName's are added to MNT not only for methods but also for 
>> fields.
>>
>> Coleen,
>> You also suggested to put all new non-jvmti code under #if INCLUDE_JVMTI
>> condition.
>> I've not done it because now the MemberName's associated with the fields
>> are
>> also registered in the MNT which is not needed for JVMTI purposes.
>> Just have some doubt if it is a right thing to do.
>> I'm Ok to add this modification, but could you, confirm that it is still
>> important.
>>
>>
>> Webrev:
>> http://cr.openjdk.java.net/~sspitsyn/webrevs/2013/hotspot/8008511-JVMTI-JSR292.2/ 
>>
>>
>>
>> Bug:
>> http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=8008511
>> https://jbs.oracle.com/bugs/browse/JDK-8008511
>>
>>
>> The problem is that the old version of the bootstrap method is 
>> re-invoked
>> after a popframe from the bootstrap method execution.
>> It is because the MemberName keeps a stale reference to the old method
>> version.
>>
>> The solution (suggested by John) is to lazily create and keep up-to-date
>> a MemberNameTable
>> which plays a role of MemberName cache assosiated with the 
>> InstanceKlass.
>> Then, at class redefinition, this cache is used to replace the old 
>> method
>> references in the MemberName's with the new method references.
>>
>> The MemberNameTable is based on the GrowableArray.
>> A C_HEAP array is allocated at the first call to
>> InstanceKlass::add_member_name().
>> It is released in the InstanceKlass::release_C_heap_structures().
>>
>> A global week reference to member name oop is stored in the
>> MemberNameTable.
>> It allowed to avoid having the oops_do() in the MemberNameTable.
>> Also, the MemberNameTable won't hold member name oops in memory.
>>
>> The MemberNameTable_lock mutex is added to serialize MemberNameTable's
>> updates.
>>
>> Test coverage: vm.mlvm, nsk.jvmti, nsk.jdi tests on multiple platforms
>> (32 vs 64-bit too).
>> The testing looks good.
>>
>>
>> Thanks,
>> Serguei


From christian.thalinger at oracle.com  Mon Apr 15 12:30:33 2013
From: christian.thalinger at oracle.com (Christian Thalinger)
Date: Mon, 15 Apr 2013 12:30:33 -0700
Subject: RFR (S): 7172922: export_ makefile targets do not work unless all
	supported variants are built
In-Reply-To: <516C3E5D.6060501@oracle.com>
References: <39142204-69FF-49BE-9FF1-D16B80E4A3F7@oracle.com>
	<5168A264.3070700@oracle.com>
	<3C52BCA3-1721-4663-AECD-6CAA334E1232@oracle.com>
	<516B3E38.7020203@oracle.com>
	<0AD290D1-E523-4DAD-B27C-FF93FFB1BD7F@oracle.com>
	<516B87ED.3070307@oracle.com>
	<5D7DC7C7-1A55-4A83-90CE-6DC9EA9C909D@oracle.com>
	<516B8CB0.4040608@oracle.com>
	
	<516C3E5D.6060501@oracle.com>
Message-ID: 


On Apr 15, 2013, at 10:52 AM, Vladimir Kozlov  wrote:

> Christian,
> 
> First, you should start using webrev versions so we can follow your changes during reviews.

I should.  Where is our new review system? ;-)

> 
> Changes are fine. I wish there was a way to avoid duplicated code (functions in Makefiles?).

That would be nice but the problem as I see it is the way how we are doing this.  We add all the targets to EXPORT_LIST and then:

generic_export: $(EXPORT_LIST)

So all the targets in EXPORT_LIST must exists.  If not, you get these mysterious make failures saying it can't find a target.

Again, I'm not a make expert...

-- Chris

> 
> Thanks,
> Vladimir
> 
> On 4/14/13 10:17 PM, Christian Thalinger wrote:
>> 
>> On Apr 14, 2013, at 10:14 PM, David Holmes  wrote:
>> 
>>> On 15/04/2013 2:56 PM, Christian Thalinger wrote:
>>>> 
>>>> On Apr 14, 2013, at 9:54 PM, David Holmes  wrote:
>>>> 
>>>>> On 15/04/2013 2:36 PM, Christian Thalinger wrote:
>>>>>> 
>>>>>> On Apr 14, 2013, at 4:39 PM, David Holmes  wrote:
>>>>>> 
>>>>>>> Hi Chris,
>>>>>>> 
>>>>>>> On 14/04/2013 2:03 PM, Christian Thalinger wrote:
>>>>>>>> 
>>>>>>>> On Apr 12, 2013, at 5:10 PM, David Holmes  wrote:
>>>>>>>> 
>>>>>>>>> Hi Chris,
>>>>>>>>> 
>>>>>>>>> On 13/04/2013 4:58 AM, Christian Thalinger wrote:
>>>>>>>>>> http://cr.openjdk.java.net/~twisti/7172922
>>>>>>>>>> 
>>>>>>>>>> 7172922: export_ makefile targets do not work unless all supported variants are built
>>>>>>>>>> Reviewed-by:
>>>>>>>>>> 
>>>>>>>>>> GEN_DIR can be overwritten by other configurations if multiple JVM_VARIANT_*s are defined. The fix is to use the *_BASE_DIRs directly to install the correct files.
>>>>>>>>>> 
>>>>>>>>>> make/Makefile
>>>>>>>>> 
>>>>>>>>> This looks like a simple temporary solution - thanks.
>>>>>>>> 
>>>>>>>> Yes, it's not perfect but good enough for now.
>>>>>>>> 
>>>>>>>>> 
>>>>>>>>> More long term I hope we should be able to generate the set of targets based on the selected JVM_VARIANTS, without needing all those duplicated blocks.
>>>>>>>>> 
>>>>>>>>> One query with the current situation: why doesn't MISC_DIR cause us a problem? It would seem to have the same issue as GEN_DIR. ???
>>>>>>>> 
>>>>>>>> MISC_DIR has the same problem but I didn't want to mess with Windows.
>>>>>>>> 
>>>>>>>> How about this one?
>>>>>>>> 
>>>>>>>> http://cr.openjdk.java.net/~twisti/7172922
>>>>>>> 
>>>>>>> I like the addition simplification of getting rid of BASE_DIR and MISC_DIR.
>>>>>>> 
>>>>>>> However I think you still need conditionals for Windows otherwise this:
>>>>>>> 
>>>>>>> 315 $(EXPORT_JRE_BIN_DIR)/%.diz:                    $(C2_DIR)/%.diz
>>>>>>> 316         $(install-file)
>>>>>>> 
>>>>>>> for example, is going to be executed for all platforms and dump the diz files into the bin directory.
>>>>>> 
>>>>>> Only if a $(EXPORT_JRE_BIN_DIR)/*.diz file is on the EXPORT_LIST.
>>>>> 
>>>>> Oops! My bad.
>>>>> 
>>>>> I still think I prefer seeing platform specific targets in platform specific conditionals, rather than using comments.
>>>> 
>>>> I don't have a strong opinion about this.  Will add the ifdefs tomorrow.
>>> 
>>> Don't bother unless someone else feels strongly about it. (I don't want to have to re-review :) )
>> 
>> Even better :-)  If there are no objections tomorrow I will push it.  Thanks for reviewing.
>> 
>> -- Chris
>> 
>>> 
>>> David
>>> -----
>>> 
>>>> -- Chris
>>>> 
>>>>> But if we can macrofy this as the next step (different CR) then that can be handled once within the macro.
>>>>> 
>>>>> Thanks,
>>>>> David
>>>>> 
>>>>>> -- Chris
>>>>>> 
>>>>>>> 
>>>>>>> David
>>>>>>> -----
>>>>>>> 
>>>>>>>> -- Chris
>>>>>>>> 
>>>>>>>>> 
>>>>>>>>> Thanks,
>>>>>>>>> David
>>>>>>>>> 
>>>>>>>> 
>>>>>> 
>>>> 
>> 


From david.holmes at oracle.com  Mon Apr 15 16:43:18 2013
From: david.holmes at oracle.com (David Holmes)
Date: Tue, 16 Apr 2013 09:43:18 +1000
Subject: RFR (S): 7172922: export_ makefile targets do not work unless
	all supported variants are built
In-Reply-To: 
References: <39142204-69FF-49BE-9FF1-D16B80E4A3F7@oracle.com>
	<5168A264.3070700@oracle.com>
	<3C52BCA3-1721-4663-AECD-6CAA334E1232@oracle.com>
	<516B3E38.7020203@oracle.com>
	<0AD290D1-E523-4DAD-B27C-FF93FFB1BD7F@oracle.com>
	<516B87ED.3070307@oracle.com>
	<5D7DC7C7-1A55-4A83-90CE-6DC9EA9C909D@oracle.com>
	<516B8CB0.4040608@oracle.com>
	
	<516C3E5D.6060501@oracle.com>
	
Message-ID: <516C9096.3060404@oracle.com>

On 16/04/2013 5:30 AM, Christian Thalinger wrote:
>
> On Apr 15, 2013, at 10:52 AM, Vladimir Kozlov  wrote:
>
>> Christian,
>>
>> First, you should start using webrev versions so we can follow your changes during reviews.
>
> I should.  Where is our new review system? ;-)
>
>>
>> Changes are fine. I wish there was a way to avoid duplicated code (functions in Makefiles?).
>
> That would be nice but the problem as I see it is the way how we are doing this.  We add all the targets to EXPORT_LIST and then:
>
> generic_export: $(EXPORT_LIST)
>
> So all the targets in EXPORT_LIST must exists.  If not, you get these mysterious make failures saying it can't find a target.

We should be able to use similar techniques as used in the new build to 
dynamically generate targets, dependencies and recipes.

However as I mention in the bug report a further problem is that we 
bundle some VM independent build artifacts into the VM specific build 
directory. and we will need to clean that up I think if we are to 
macrofy this part of the build logic.

I have JDK-7195896 as a cleanup task that might be able to deal with 
this problem. But no idea when I'll get to it.

David


> Again, I'm not a make expert...
>
> -- Chris
>
>>
>> Thanks,
>> Vladimir
>>
>> On 4/14/13 10:17 PM, Christian Thalinger wrote:
>>>
>>> On Apr 14, 2013, at 10:14 PM, David Holmes  wrote:
>>>
>>>> On 15/04/2013 2:56 PM, Christian Thalinger wrote:
>>>>>
>>>>> On Apr 14, 2013, at 9:54 PM, David Holmes  wrote:
>>>>>
>>>>>> On 15/04/2013 2:36 PM, Christian Thalinger wrote:
>>>>>>>
>>>>>>> On Apr 14, 2013, at 4:39 PM, David Holmes  wrote:
>>>>>>>
>>>>>>>> Hi Chris,
>>>>>>>>
>>>>>>>> On 14/04/2013 2:03 PM, Christian Thalinger wrote:
>>>>>>>>>
>>>>>>>>> On Apr 12, 2013, at 5:10 PM, David Holmes  wrote:
>>>>>>>>>
>>>>>>>>>> Hi Chris,
>>>>>>>>>>
>>>>>>>>>> On 13/04/2013 4:58 AM, Christian Thalinger wrote:
>>>>>>>>>>> http://cr.openjdk.java.net/~twisti/7172922
>>>>>>>>>>>
>>>>>>>>>>> 7172922: export_ makefile targets do not work unless all supported variants are built
>>>>>>>>>>> Reviewed-by:
>>>>>>>>>>>
>>>>>>>>>>> GEN_DIR can be overwritten by other configurations if multiple JVM_VARIANT_*s are defined. The fix is to use the *_BASE_DIRs directly to install the correct files.
>>>>>>>>>>>
>>>>>>>>>>> make/Makefile
>>>>>>>>>>
>>>>>>>>>> This looks like a simple temporary solution - thanks.
>>>>>>>>>
>>>>>>>>> Yes, it's not perfect but good enough for now.
>>>>>>>>>
>>>>>>>>>>
>>>>>>>>>> More long term I hope we should be able to generate the set of targets based on the selected JVM_VARIANTS, without needing all those duplicated blocks.
>>>>>>>>>>
>>>>>>>>>> One query with the current situation: why doesn't MISC_DIR cause us a problem? It would seem to have the same issue as GEN_DIR. ???
>>>>>>>>>
>>>>>>>>> MISC_DIR has the same problem but I didn't want to mess with Windows.
>>>>>>>>>
>>>>>>>>> How about this one?
>>>>>>>>>
>>>>>>>>> http://cr.openjdk.java.net/~twisti/7172922
>>>>>>>>
>>>>>>>> I like the addition simplification of getting rid of BASE_DIR and MISC_DIR.
>>>>>>>>
>>>>>>>> However I think you still need conditionals for Windows otherwise this:
>>>>>>>>
>>>>>>>> 315 $(EXPORT_JRE_BIN_DIR)/%.diz:                    $(C2_DIR)/%.diz
>>>>>>>> 316         $(install-file)
>>>>>>>>
>>>>>>>> for example, is going to be executed for all platforms and dump the diz files into the bin directory.
>>>>>>>
>>>>>>> Only if a $(EXPORT_JRE_BIN_DIR)/*.diz file is on the EXPORT_LIST.
>>>>>>
>>>>>> Oops! My bad.
>>>>>>
>>>>>> I still think I prefer seeing platform specific targets in platform specific conditionals, rather than using comments.
>>>>>
>>>>> I don't have a strong opinion about this.  Will add the ifdefs tomorrow.
>>>>
>>>> Don't bother unless someone else feels strongly about it. (I don't want to have to re-review :) )
>>>
>>> Even better :-)  If there are no objections tomorrow I will push it.  Thanks for reviewing.
>>>
>>> -- Chris
>>>
>>>>
>>>> David
>>>> -----
>>>>
>>>>> -- Chris
>>>>>
>>>>>> But if we can macrofy this as the next step (different CR) then that can be handled once within the macro.
>>>>>>
>>>>>> Thanks,
>>>>>> David
>>>>>>
>>>>>>> -- Chris
>>>>>>>
>>>>>>>>
>>>>>>>> David
>>>>>>>> -----
>>>>>>>>
>>>>>>>>> -- Chris
>>>>>>>>>
>>>>>>>>>>
>>>>>>>>>> Thanks,
>>>>>>>>>> David
>>>>>>>>>>
>>>>>>>>>
>>>>>>>
>>>>>
>>>
>

From david.holmes at oracle.com  Mon Apr 15 16:48:56 2013
From: david.holmes at oracle.com (David Holmes)
Date: Tue, 16 Apr 2013 09:48:56 +1000
Subject: hs25 review request (2nd round): 8008511 JSR 292: MemberName
	vmtarget refs to methods must be updated at class redefinition
In-Reply-To: <516C3FFD.9040606@oracle.com>
References: <5168BF57.3030206@oracle.com> <516B8C37.7020002@oracle.com>
	<516C3FFD.9040606@oracle.com>
Message-ID: <516C91E8.8010207@oracle.com>

On 16/04/2013 3:59 AM, serguei.spitsyn at oracle.com wrote:
> Hi David,
>
>
> Thank you for the comments!
>
>
> On 4/14/13 10:12 PM, David Holmes wrote:
>> Hi Serguei,
>>
>> Not a full review ...
>>
>> In instanceKlass.cpp:
>>
>> +   MemberNameTable* mnt = member_names();
>> +   if (mnt != NULL) {
>> +     delete mnt;
>> +   }
>>
>> a) do we need to call set_member_names(null) ?
>
> Fixed, thanks.
>
>
>> b) do we need to use the MemberNameTable_lock to guard this?
>
> I don't think so.
> This deallocation must be done at a safepoint.
> We can't grab locks at safepoints.

Okay but that is only one side of things. We also have to verify that 
any code that does grab the lock can't enter a safepoint while holding 
the lock.

David
------

From david.holmes at oracle.com  Mon Apr 15 16:54:26 2013
From: david.holmes at oracle.com (David Holmes)
Date: Tue, 16 Apr 2013 09:54:26 +1000
Subject: hs25 review request (2nd round): 8008511 JSR 292: MemberName
	vmtarget refs to methods must be updated at class redefinition
In-Reply-To: <516C91E8.8010207@oracle.com>
References: <5168BF57.3030206@oracle.com> <516B8C37.7020002@oracle.com>
	<516C3FFD.9040606@oracle.com> <516C91E8.8010207@oracle.com>
Message-ID: <516C9332.2030201@oracle.com>

On 16/04/2013 9:48 AM, David Holmes wrote:
> On 16/04/2013 3:59 AM, serguei.spitsyn at oracle.com wrote:
>> On 4/14/13 10:12 PM, David Holmes wrote:
>>> Not a full review ...
>>>
>>> In instanceKlass.cpp:
>>>
>>> +   MemberNameTable* mnt = member_names();
>>> +   if (mnt != NULL) {
>>> +     delete mnt;
>>> +   }
>>>
>>> a) do we need to call set_member_names(null) ?
>>
>> Fixed, thanks.
>>
>>
>>> b) do we need to use the MemberNameTable_lock to guard this?
>>
>> I don't think so.
>> This deallocation must be done at a safepoint.
>> We can't grab locks at safepoints.
>
> Okay but that is only one side of things. We also have to verify that
> any code that does grab the lock can't enter a safepoint while holding
> the lock.

That was an over generalization. Presumably we would never be in a 
position of doing the delete if the table could actually still be in use.

David


> David
> ------

From serguei.spitsyn at oracle.com  Mon Apr 15 17:48:12 2013
From: serguei.spitsyn at oracle.com (serguei.spitsyn at oracle.com)
Date: Mon, 15 Apr 2013 17:48:12 -0700
Subject: hs25 review request (2nd round): 8008511 JSR 292: MemberName
	vmtarget refs to methods must be updated at class redefinition
In-Reply-To: <516C91E8.8010207@oracle.com>
References: <5168BF57.3030206@oracle.com> <516B8C37.7020002@oracle.com>
	<516C3FFD.9040606@oracle.com> <516C91E8.8010207@oracle.com>
Message-ID: <516C9FCC.6040800@oracle.com>

On 4/15/13 4:48 PM, David Holmes wrote:
> On 16/04/2013 3:59 AM, serguei.spitsyn at oracle.com wrote:
>> Hi David,
>>
>>
>> Thank you for the comments!
>>
>>
>> On 4/14/13 10:12 PM, David Holmes wrote:
>>> Hi Serguei,
>>>
>>> Not a full review ...
>>>
>>> In instanceKlass.cpp:
>>>
>>> +   MemberNameTable* mnt = member_names();
>>> +   if (mnt != NULL) {
>>> +     delete mnt;
>>> +   }
>>>
>>> a) do we need to call set_member_names(null) ?
>>
>> Fixed, thanks.
>>
>>
>>> b) do we need to use the MemberNameTable_lock to guard this?
>>
>> I don't think so.
>> This deallocation must be done at a safepoint.
>> We can't grab locks at safepoints.
>
> Okay but that is only one side of things. We also have to verify that 
> any code that does grab the lock can't enter a safepoint while holding 
> the lock.

Thank you for checking this.
I did a check that the code that grabs the lock does not need a safepoint.
I can place a No_Safepoint_Verifier, if you think, it makes sense to do.

Currently, this is the only place that grabs the lock:

void InstanceKlass::add_member_name(Handle mem_name) {
   jweak mem_name_wref = JNIHandles::make_weak_global(mem_name);
   MutexLocker ml(MemberNameTable_lock);
   DEBUG_ONLY(No_Safepoint_Verifier nsv);  // <= We can add this check

   if (_member_names == NULL) {
     _member_names = new (ResourceObj::C_HEAP, mtClass) MemberNameTable();
   }
   _member_names->add_member_name(mem_name_wref);
}


Thanks,
Serguei

>
> David
> ------


From erik.helin at oracle.com  Mon Apr 15 20:45:55 2013
From: erik.helin at oracle.com (erik.helin at oracle.com)
Date: Tue, 16 Apr 2013 03:45:55 +0000
Subject: hg: hsx/hsx24/hotspot: 2 new changesets
Message-ID: <20130416034603.8CB5A48324@hg.openjdk.java.net>

Changeset: 7baf47cf4bed
Author:    ehelin
Date:      2013-04-15 08:14 +0200
URL:       http://hg.openjdk.java.net/hsx/hsx24/hotspot/rev/7baf47cf4bed

8012102: CollectedHeap::ensure_parsability is not always called during heap inspection
Reviewed-by: mgerdin, stefank

! src/share/vm/gc_implementation/shared/vmGCOperations.cpp

Changeset: 17ff5d08f85b
Author:    ehelin
Date:      2013-04-15 08:17 -0700
URL:       http://hg.openjdk.java.net/hsx/hsx24/hotspot/rev/17ff5d08f85b

Merge



From nils.loodin at oracle.com  Tue Apr 16 03:51:37 2013
From: nils.loodin at oracle.com (Nils Loodin)
Date: Tue, 16 Apr 2013 12:51:37 +0200
Subject: RFR: JDK-8012212 - link against kstat on solaris x86
In-Reply-To: <516C3223.8060000@oracle.com>
References: <516BCD66.7080904@oracle.com> <516BF405.7010303@oracle.com>
	<516C3223.8060000@oracle.com>
Message-ID: <516D2D39.9030001@oracle.com>

Yes, there are changes in the pipe that needs this change.

Regards,
Nils Loodin

On 04/15/2013 07:00 PM, Vladimir Kozlov wrote:
> Nils,
>
> Do you have future work in plan for this? You should do this change only
> when you add a code to really use data from kstat on x86.
> Currently kstat is only used on SPARC to get CPU information (since it
> doesn't have cpuid instruction). No kstat counters are read in VM.
>
> Thanks,
> Vladimir
>
> On 4/15/13 5:35 AM, Nils Loodin wrote:
>> And here is the actual link to the webrev... sigh.
>>
>> http://cr.openjdk.java.net/~nloodin/8012212/webrev.00/
>>
>> /Nisse
>>
>>
>>
>> On 04/15/2013 11:50 AM, Nils Loodin wrote:
>>> Any reviewers for this unassuming change to not exclude sparc from
>>> linking against kstat?
>>>
>>> Regards,
>>> Nils Loodin
>>


From rickard.backman at oracle.com  Tue Apr 16 07:03:57 2013
From: rickard.backman at oracle.com (rickard.backman at oracle.com)
Date: Tue, 16 Apr 2013 14:03:57 +0000
Subject: hg: hsx/hsx24/hotspot: 8012210: Make TracingTime available when
	INCLUDE_TRACE = 0
Message-ID: <20130416140359.E0ACE48332@hg.openjdk.java.net>

Changeset: f438a35cc903
Author:    rbackman
Date:      2013-04-15 11:38 +0200
URL:       http://hg.openjdk.java.net/hsx/hsx24/hotspot/rev/f438a35cc903

8012210: Make TracingTime available when INCLUDE_TRACE = 0
Reviewed-by: dholmes, sla

+ src/share/vm/trace/noTraceBackend.hpp
! src/share/vm/trace/traceBackend.hpp


From coleen.phillimore at oracle.com  Tue Apr 16 11:35:43 2013
From: coleen.phillimore at oracle.com (Coleen Phillimore)
Date: Tue, 16 Apr 2013 14:35:43 -0400
Subject: hs25 review request (2nd round): 8008511 JSR 292: MemberName
	vmtarget refs to methods must be updated at class redefinition
In-Reply-To: <5168BF57.3030206@oracle.com>
References: <5168BF57.3030206@oracle.com>
Message-ID: <516D99FF.9090205@oracle.com>


On 04/12/2013 10:13 PM, serguei.spitsyn at oracle.com wrote:
>
> Please, review the following fix.
>
> This is the 2nd version that has a review fixes suggested by Coleen 
> and John in the 1st review round.
>
> Now the mtClass is used in allocation of MemberNameTable since it's 
> part of class metadata.
> All call sites in the methodHandles.cpp that recursively invoke the 
> add_member_name()
> are made safepoint-safe by replacing oop's with Handle's.
> This allowed to get rid of the No_Safepoint_Verifier in the 
> find_MemberNames.
> The MemberName's are added to MNT not only for methods but also for 
> fields.
>
> Coleen,
> You also suggested to put all new non-jvmti code under #if 
> INCLUDE_JVMTI condition.
> I've not done it because now the MemberName's associated with the 
> fields are
> also registered in the MNT which is not needed for JVMTI purposes.
> Just have some doubt if it is a right thing to do.
> I'm Ok to add this modification, but could you, confirm that it is 
> still important.
>

Ok.   I've rereviewed this code.   It looks fine to me.   Thanks for 
taking on this fix.

Coleen

>
> Webrev:
> http://cr.openjdk.java.net/~sspitsyn/webrevs/2013/hotspot/8008511-JVMTI-JSR292.2/ 
>
>
> Bug:
> http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=8008511
> https://jbs.oracle.com/bugs/browse/JDK-8008511
>
>
> The problem is that the old version of the bootstrap method is re-invoked
> after a popframe from the bootstrap method execution.
> It is because the MemberName keeps a stale reference to the old method 
> version.
>
> The solution (suggested by John) is to lazily create and keep 
> up-to-date a MemberNameTable
> which plays a role of MemberName cache assosiated with the InstanceKlass.
> Then, at class redefinition, this cache is used to replace the old method
> references in the MemberName's with the new method references.
>
> The MemberNameTable is based on the GrowableArray.
> A C_HEAP array is allocated at the first call to 
> InstanceKlass::add_member_name().
> It is released in the InstanceKlass::release_C_heap_structures().
>
> A global week reference to member name oop is stored in the 
> MemberNameTable.
> It allowed to avoid having the oops_do() in the MemberNameTable.
> Also, the MemberNameTable won't hold member name oops in memory.
>
> The MemberNameTable_lock mutex is added to serialize MemberNameTable's 
> updates.
>
> Test coverage: vm.mlvm, nsk.jvmti, nsk.jdi tests on multiple platforms 
> (32 vs 64-bit too).
> The testing looks good.
>
>
> Thanks,
> Serguei


From serguei.spitsyn at oracle.com  Tue Apr 16 11:46:17 2013
From: serguei.spitsyn at oracle.com (serguei.spitsyn at oracle.com)
Date: Tue, 16 Apr 2013 11:46:17 -0700
Subject: hs25 review request (2nd round): 8008511 JSR 292: MemberName
	vmtarget refs to methods must be updated at class redefinition
In-Reply-To: <516D99FF.9090205@oracle.com>
References: <5168BF57.3030206@oracle.com> <516D99FF.9090205@oracle.com>
Message-ID: <516D9C79.3020605@oracle.com>

Thanks a lot, Coleen!
Serguei


On 4/16/13 11:35 AM, Coleen Phillimore wrote:
>
> On 04/12/2013 10:13 PM, serguei.spitsyn at oracle.com wrote:
>>
>> Please, review the following fix.
>>
>> This is the 2nd version that has a review fixes suggested by Coleen 
>> and John in the 1st review round.
>>
>> Now the mtClass is used in allocation of MemberNameTable since it's 
>> part of class metadata.
>> All call sites in the methodHandles.cpp that recursively invoke the 
>> add_member_name()
>> are made safepoint-safe by replacing oop's with Handle's.
>> This allowed to get rid of the No_Safepoint_Verifier in the 
>> find_MemberNames.
>> The MemberName's are added to MNT not only for methods but also for 
>> fields.
>>
>> Coleen,
>> You also suggested to put all new non-jvmti code under #if 
>> INCLUDE_JVMTI condition.
>> I've not done it because now the MemberName's associated with the 
>> fields are
>> also registered in the MNT which is not needed for JVMTI purposes.
>> Just have some doubt if it is a right thing to do.
>> I'm Ok to add this modification, but could you, confirm that it is 
>> still important.
>>
>
> Ok.   I've rereviewed this code.   It looks fine to me.   Thanks for 
> taking on this fix.
>
> Coleen
>
>>
>> Webrev:
>> http://cr.openjdk.java.net/~sspitsyn/webrevs/2013/hotspot/8008511-JVMTI-JSR292.2/ 
>>
>>
>> Bug:
>> http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=8008511
>> https://jbs.oracle.com/bugs/browse/JDK-8008511
>>
>>
>> The problem is that the old version of the bootstrap method is 
>> re-invoked
>> after a popframe from the bootstrap method execution.
>> It is because the MemberName keeps a stale reference to the old 
>> method version.
>>
>> The solution (suggested by John) is to lazily create and keep 
>> up-to-date a MemberNameTable
>> which plays a role of MemberName cache assosiated with the 
>> InstanceKlass.
>> Then, at class redefinition, this cache is used to replace the old 
>> method
>> references in the MemberName's with the new method references.
>>
>> The MemberNameTable is based on the GrowableArray.
>> A C_HEAP array is allocated at the first call to 
>> InstanceKlass::add_member_name().
>> It is released in the InstanceKlass::release_C_heap_structures().
>>
>> A global week reference to member name oop is stored in the 
>> MemberNameTable.
>> It allowed to avoid having the oops_do() in the MemberNameTable.
>> Also, the MemberNameTable won't hold member name oops in memory.
>>
>> The MemberNameTable_lock mutex is added to serialize 
>> MemberNameTable's updates.
>>
>> Test coverage: vm.mlvm, nsk.jvmti, nsk.jdi tests on multiple 
>> platforms (32 vs 64-bit too).
>> The testing looks good.
>>
>>
>> Thanks,
>> Serguei
>


From coleen.phillimore at oracle.com  Tue Apr 16 15:40:36 2013
From: coleen.phillimore at oracle.com (Coleen Phillimore)
Date: Tue, 16 Apr 2013 18:40:36 -0400
Subject: Result: New HSX Committer: Ioi Lam
Message-ID: <516DD364.2050704@oracle.com>

|Voting for *Ioi Lam* [1] is now closed.

Yes: *19*
Veto: 0
Abstain: 0

According to the Bylaws definition of Lazy Consensus, this is sufficient 
to approve the nomination.

*Coleen Phillimore*

[1] 
*http://mail.openjdk.java.net/pipermail/hotspot-dev/2013-April/009100.html*| 


||

|*
*|

From bengt.rutisson at oracle.com  Wed Apr 17 02:20:09 2013
From: bengt.rutisson at oracle.com (Bengt Rutisson)
Date: Wed, 17 Apr 2013 11:20:09 +0200
Subject: RFR: JDK-8012212 - link against kstat on solaris x86
In-Reply-To: <516BF405.7010303@oracle.com>
References: <516BCD66.7080904@oracle.com> <516BF405.7010303@oracle.com>
Message-ID: <516E6949.5000602@oracle.com>


Hi Nisse,

I am no make file expert, but this looks good to me.

Bengt

On 4/15/13 2:35 PM, Nils Loodin wrote:
> And here is the actual link to the webrev... sigh.
>
> http://cr.openjdk.java.net/~nloodin/8012212/webrev.00/
>
> /Nisse
>
>
>
> On 04/15/2013 11:50 AM, Nils Loodin wrote:
>> Any reviewers for this unassuming change to not exclude sparc from
>> linking against kstat?
>>
>> Regards,
>> Nils Loodin
>


From igor.ignatyev at oracle.com  Wed Apr 17 03:11:53 2013
From: igor.ignatyev at oracle.com (Igor Ignatyev)
Date: Wed, 17 Apr 2013 14:11:53 +0400
Subject: RFR(S) : 8012337 : Change Whitebox implementation to make absence
	of method in Whitebox.class not fatal
Message-ID: <516E7569.1060201@oracle.com>

Hi all,

Please review patch.

Problem:
If there is some method that presences in native part of whitebox, but 
absences in java side, we get 'j.l.NoSuchMethodError' exception

Fix:
Batch registration of WB functions was replaced with one by one registration

Testing:
JPRT of sanity tests and tests that use WhiteBox: runtime/interned, 
compiler/whitebox

webrev: http://cr.openjdk.java.net/~iignatyev/8012337/webrev.00/
jbs: https://jbs.oracle.com/bugs/browse/JDK-8012337
-- 
Best regards,
Igor Ignatyev

From mikael.gerdin at oracle.com  Wed Apr 17 04:22:20 2013
From: mikael.gerdin at oracle.com (Mikael Gerdin)
Date: Wed, 17 Apr 2013 13:22:20 +0200
Subject: RFR(S) : 8012337 : Change Whitebox implementation to make absence
	of method in Whitebox.class not fatal
In-Reply-To: <516E7569.1060201@oracle.com>
References: <516E7569.1060201@oracle.com>
Message-ID: <516E85EC.6040203@oracle.com>

Igor,

On 2013-04-17 12:11, Igor Ignatyev wrote:
> Hi all,
>
> Please review patch.
>
> Problem:
> If there is some method that presences in native part of whitebox, but
> absences in java side, we get 'j.l.NoSuchMethodError' exception

The intended use of is of course that whitebox.cpp and WhiteBox.java are 
in sync since they are in the same hg repository.

I understand that some feel that they need to copy WhiteBox to some 
other test suite and I find this change acceptable but unfortunate.

>
> Fix:
> Batch registration of WB functions was replaced with one by one
> registration
>
> Testing:
> JPRT of sanity tests and tests that use WhiteBox: runtime/interned,
> compiler/whitebox
>
> webrev: http://cr.openjdk.java.net/~iignatyev/8012337/webrev.00/

It's too bad that you need a shell script here but I don't see any way 
around it.

I'm ok with you pushing this.

/Mikael

> jbs: https://jbs.oracle.com/bugs/browse/JDK-8012337

From igor.ignatyev at oracle.com  Wed Apr 17 06:56:31 2013
From: igor.ignatyev at oracle.com (Igor Ignatyev)
Date: Wed, 17 Apr 2013 17:56:31 +0400
Subject: RFR(S) : 8012337 : Change Whitebox implementation to make absence
	of method in Whitebox.class not fatal
In-Reply-To: <516E85EC.6040203@oracle.com>
References: <516E7569.1060201@oracle.com> <516E85EC.6040203@oracle.com>
Message-ID: <516EAA0F.2020807@oracle.com>

Mikael,
Thank you for review.

I have updated webrev:
- added checking for exception class
- added print warning on unexpected error

http://cr.openjdk.java.net/~iignatyev/8012337/webrev.01/

Best regards,
Igor Ignatyev

On 04/17/2013 03:22 PM, Mikael Gerdin wrote:
> Igor,
>
> On 2013-04-17 12:11, Igor Ignatyev wrote:
>> Hi all,
>>
>> Please review patch.
>>
>> Problem:
>> If there is some method that presences in native part of whitebox, but
>> absences in java side, we get 'j.l.NoSuchMethodError' exception
>
> The intended use of is of course that whitebox.cpp and WhiteBox.java are
> in sync since they are in the same hg repository.
>
> I understand that some feel that they need to copy WhiteBox to some
> other test suite and I find this change acceptable but unfortunate.
>
>>
>> Fix:
>> Batch registration of WB functions was replaced with one by one
>> registration
>>
>> Testing:
>> JPRT of sanity tests and tests that use WhiteBox: runtime/interned,
>> compiler/whitebox
>>
>> webrev: http://cr.openjdk.java.net/~iignatyev/8012337/webrev.00/
>
> It's too bad that you need a shell script here but I don't see any way
> around it.
>
> I'm ok with you pushing this.
>
> /Mikael
>
>> jbs: https://jbs.oracle.com/bugs/browse/JDK-8012337

From adomurad at redhat.com  Wed Apr 17 07:29:38 2013
From: adomurad at redhat.com (Adam Domurad)
Date: Wed, 17 Apr 2013 10:29:38 -0400
Subject: Very poor performance of JNI AttachCurrentThread on Linux
In-Reply-To: <51549495.6000603@oracle.com>
References: <512CF7D5.2030300@redhat.com> <512D2B73.4060103@oracle.com>
	
	<5130D0AB.8000001@oracle.com> <513780C0.9050103@redhat.com>
	<513E1210.4030406@oracle.com> <515493D5.7090308@redhat.com>
	<51549495.6000603@oracle.com>
Message-ID: <516EB1D2.8070908@redhat.com>

On 03/28/2013 03:05 PM, Dmitry Samersoff wrote:
> Adam,
>
> Thank you!
>
> -Dmitry
>
> On 2013-03-28 23:02, Adam Domurad wrote:
>> On 03/11/2013 01:19 PM, Dmitry Samersoff wrote:
>>> Adam,
>>>
>>> Sorry! I can't provide any estimations right now. But it's a high
>>> priority issue in my queue, and I plan to provide a fix as soon as it
>>> become possible.
>>>
>>> -Dmitry
>>>
>>> On 2013-03-06 21:45, Adam Domurad wrote:
>>>> On 03/01/2013 11:00 AM, Dmitry Samersoff wrote:
>>>>> Adam,
>>>>>
>>>>> Thank you for advice! I'm looking for a possibility to remove
>>>>> get_stack_bounds function entirely as Dean suggested. But it takes some
>>>>> time.
>>>> Hi again, not to be a bother, but do you have a rough time-frame that
>>>> the fix will take?
>>>>
>>>> Thanks,
>>>> -Adam
>> As per our off-list chat, I have attached my implementation of a revised
>> implementation of get_stack_bounds with a small test-case. As far as
>> performance is concerned, it's an order of magnitude faster from my
>> timings. This should be suitable given that no problems were reported
>> with the old implementation.
>>
>> Happy hacking,
>> -Adam
>

How is the fix coming along ? Have you looked into if my version was 
suitable ?

Thanks once again,
-Adam

From jesper.wilhelmsson at oracle.com  Wed Apr 17 08:08:06 2013
From: jesper.wilhelmsson at oracle.com (jesper.wilhelmsson at oracle.com)
Date: Wed, 17 Apr 2013 15:08:06 +0000
Subject: hg: hsx/hsx24/hotspot: 8008916: G1: Evacuation failed tracing event
Message-ID: <20130417150815.9A2894839C@hg.openjdk.java.net>

Changeset: 78538cd4794c
Author:    jwilhelm
Date:      2013-04-17 13:16 +0200
URL:       http://hg.openjdk.java.net/hsx/hsx24/hotspot/rev/78538cd4794c

8008916: G1: Evacuation failed tracing event
Summary: Evacuation failed event for G1
Reviewed-by: johnc, brutisso, ehelin

! src/share/vm/gc_implementation/g1/g1CollectedHeap.cpp
! src/share/vm/gc_implementation/g1/g1CollectedHeap.hpp
! src/share/vm/gc_implementation/g1/g1GCPhaseTimes.hpp
! src/share/vm/gc_implementation/shared/copyFailedInfo.hpp
! src/share/vm/gc_implementation/shared/gcTrace.cpp
! src/share/vm/gc_implementation/shared/gcTrace.hpp
! src/share/vm/gc_implementation/shared/gcTraceSend.cpp
! src/share/vm/trace/trace.xml


From coleen.phillimore at oracle.com  Wed Apr 17 08:57:26 2013
From: coleen.phillimore at oracle.com (Coleen Phillimore)
Date: Wed, 17 Apr 2013 11:57:26 -0400
Subject: RFR (S): 8011803: release_C_heap_structures is never called for
	anonymous classes.
In-Reply-To: <516BB8FD.4030001@oracle.com>
References: <51672297.3080503@oracle.com> <5167CA4C.5040608@oracle.com>
	<51680041.5070905@oracle.com> <51685A67.4020007@oracle.com>
	<51687E59.6060702@oracle.com> <516BB8FD.4030001@oracle.com>
Message-ID: <516EC666.5010805@oracle.com>


Mikael, Thanks for looking at this in detail.

On 4/15/2013 4:23 AM, Mikael Gerdin wrote:
> Coleen,
>
> On 2013-04-12 23:36, Coleen Phillimore wrote:
>> On 4/12/2013 3:03 PM, Coleen Phillimore wrote:
>>>
>>> Hi,
>>>
>>> I have updated the webrev to split the serviceability actions and the
>>> deleting C heap data for classes in ClassLoaderData.  I left the
>>> serviceability actions in dictionary::do_unloading() to avoid
>>> rewalking the ClassLoaderData _klasses.   For
>>> release_C_heap_structures(), all the _klasses are walked at the end.
>>> This should work for Markus G's new serviceability changes with minor
>>> modifications.
>>
>> Reload if you looked at this already.  Stefan convinced me that walking
>> the class list in the ClassLoaderData::unload() is not too expensive, so
>> the serviceability actions have been removed from
>> dictionary::do_unloading() and done in ClassLoaderData::unload()
>> unconditionally.
>
> It looks like http://cr.openjdk.java.net/~coleenp/8011803_2/ is the 
> wrong webrev since it's inconsistent with your mail.
> But I have some comments about moving the calls to 
> release_c_heap_structures.

I forgot to copy it over.  Please reload.
>
>
> By moving the calls to {IK,CP}::release_c_heap_structures to 
> ~ClassLoaderData they will be called concurrently from the CMS thread 
> through its call to ClassLoaderDataGraph::purge.
>
> Previously they were called at a safepoint since 
> Dictionary::do_unloading is only called at safepoint.
> A cursory inspection suggests that this is safe.
>
> However.
> This will cause the symbol refcounts to be decremented at a later 
> stage than before, in fact by the time we come to ~ClassLoaderData 
> we've already called SymbolTable::unkink so this will artificially 
> extend the lifetime of unreferenced symbols by one full gc.

Yes, this is true and a good point.  I feel like it's safer actually 
since all the memory shouldn't go away before the destructor is run.   
Symbols aren't reclaimed that much so this change is not likely to cause 
a measurable increase in footprint between GC's (famous last words).

Coleen

>
> /Mikael
>
>>
>>>
>>> open webrev at http://cr.openjdk.java.net/~coleenp/8011803_2/
>>>
>>> thanks,
>>> Coleen
>>>
>>> On 4/12/2013 8:38 AM, Coleen Phillimore wrote:
>>>> On 4/12/2013 4:48 AM, Stefan Karlsson wrote:
>>>>> On 04/11/2013 10:52 PM, Coleen Phillimore wrote:
>>>>>> Summary: Call this function from CLD::unload()  now for anonymous
>>>>>> classes.
>>>>>>
>>>>>> Anonymous classes aren't in the system dictionary so
>>>>>> release_C_heap_structures isn't called for them if they are
>>>>>> unloaded.  I fixed this for jdk8 because they are in the class
>>>>>> loader data graph but for jdk7, I don't know how to fix this. They
>>>>>> are unloaded by being garbage collected after the references are
>>>>>> dropped.
>>>>>>
>>>>>> Tested with ute tests vm.mvlm.testlist nsk.monitoring.testlist and
>>>>>> jdk/test/java/lang/invoke tests.
>>>>>>
>>>>>> open webrev at http://cr.openjdk.java.net/~coleenp/8011803/
>>>>>> bug link at http://bugs.sun.com/view_bug.do?bug_id=8011803
>>>>>
>>>>> I've two comments.
>>>>>
>>>>> 1) It's unfortunate that we now call unload_class() at two different
>>>>> places in the code. It makes it harder to understand the
>>>>> deallocation of metadata. It would be better to keep the calls to
>>>>> unload_class() for ordinary InstanceKlasses and anonymous classes
>>>>> together.
>>>>
>>>> Hi Stefan,  Thank you for looking at this.   This is the feedback I
>>>> was looking for.
>>>>
>>>> I went back and forth about moving the regular class unloading
>>>> actions for everything in unload (or ~ClassLoaderData), but I didn't
>>>> want to introduce a _klasses walk for all the class loaders.   We're
>>>> already walking them in the system dictionary purge.
>>>>
>>>> For my change I'm walking these classes if
>>>> UseCompressedKlassPointers, and Markus is walking them for
>>>> serviceability (hopefully under some flag) so maybe I should just 
>>>> do it.
>>>>
>>>>>
>>>>> 2) This change actually breaks the Tracing class unloading event
>>>>> that Markus is working on. That code walk the
>>>>> ClassLoaderDataGraph::_unloading list in
>>>>> ClassLoaderDataGraph::do_unloading and use the information in the
>>>>> classes of the CLDs that are about to be unloaded. With this patch
>>>>> they probably crash because some pointers in the anonymous classes
>>>>> will be trashed.
>>>>>
>>>>
>>>> I thought about that, since I've been talking to Markus about this. I
>>>> wanted to consolidate the serviceability calls in one place and
>>>> calling InstanceKlass::unload_class() that notifies serviceability in
>>>> the ~ClassLoaderData destructor might be too late.  It might not be
>>>> though.   I think the walk in the destructor might be better for
>>>> release_C_heap_structures though.
>>>>
>>>>> I have a suggestion on how to solve both points above. It's probably
>>>>> easier to show with a pseudo patch:
>>>>>
>>>>> $ hg diff
>>>>> diff --git a/src/share/vm/classfile/classLoaderData.cpp
>>>>> b/src/share/vm/classfile/classLoaderData.cpp
>>>>> --- a/src/share/vm/classfile/classLoaderData.cpp
>>>>> +++ b/src/share/vm/classfile/classLoaderData.cpp
>>>>> @@ -671,7 +671,6 @@
>>>>>      }
>>>>>      seen_dead_loader = true;
>>>>>      ClassLoaderData* dead = data;
>>>>> -    dead->unload();
>>>>>      data = data->next();
>>>>>      // Remove from loader list.
>>>>>      if (prev != NULL) {
>>>>> @@ -683,9 +682,24 @@
>>>>>      dead->set_next(_unloading);
>>>>>      _unloading = dead;
>>>>>    }
>>>>> +
>>>>> +  report_class_unloading_info(_unloading);
>>>>> +
>>>>> +  ClassLoaderDataGraph::unload_classes();
>>>>> +
>>>>>    return seen_dead_loader;
>>>>>  }
>>>>>
>>>>> +void ClassLoaderDataGraph::unload_classes() {
>>>>> +  ClassLoaderData* list = _unloading;
>>>>> +  ClassLoaderData* next = list;
>>>>> +  while (next != NULL) {
>>>>> +    for (Klass* k = next->_klasses; k != NULL; k = k->next_link()) {
>>>>> +      k->unload_class();
>>>>> +    }
>>>>> +  }
>>>>> +}
>>>>> +
>>>>
>>>> That's too much extra walking.   But maybe we can split the
>>>> serviceability stuff into ClassLoaderData::unload() and do the
>>>> release_C_heap_structures() into the ClassLoaderData destructor. That
>>>> seems better.   Maybe Markus could put his callback into 
>>>> CLD::unload().
>>>>
>>>> Thanks!  I will change this and resend.
>>>> Coleen
>>>>
>>>>>  void ClassLoaderDataGraph::purge() {
>>>>>    ClassLoaderData* list = _unloading;
>>>>>    _unloading = NULL;
>>>>> diff --git a/src/share/vm/classfile/dictionary.cpp
>>>>> b/src/share/vm/classfile/dictionary.cpp
>>>>> --- a/src/share/vm/classfile/dictionary.cpp
>>>>> +++ b/src/share/vm/classfile/dictionary.cpp
>>>>> @@ -157,9 +157,6 @@
>>>>>              // to be unloaded.
>>>>>              // Notify the debugger and clean up the class.
>>>>>              class_was_unloaded = true;
>>>>> -
>>>>> -            // perform unloading actions on this class
>>>>> -            ik->unload_class();
>>>>>            }
>>>>>            // Also remove this system dictionary entry.
>>>>>            purge_entry = true;
>>>>>
>>>>> As a bonus, the dictionary()->do_unloading() will then only do a
>>>>> simple purge of the SystemDictionary.
>>>>>
>>>>> What do you think?
>>>>>
>>>>> thanks,
>>>>> StefanK
>>>>>
>>>>>>
>>>>>> Thanks,
>>>>>> Coleen
>>>>>
>>>>
>>>
>>


From daniel.daugherty at oracle.com  Wed Apr 17 14:12:11 2013
From: daniel.daugherty at oracle.com (daniel.daugherty at oracle.com)
Date: Wed, 17 Apr 2013 21:12:11 +0000
Subject: hg: hsx/hotspot-main/hotspot: 2 new changesets
Message-ID: <20130417211228.449BA483CC@hg.openjdk.java.net>

Changeset: 35f8765422b9
Author:    zgu
Date:      2013-04-10 08:55 -0400
URL:       http://hg.openjdk.java.net/hsx/hotspot-main/hotspot/rev/35f8765422b9

8010151: nsk/regression/b6653214 fails "assert(snapshot != NULL) failed: Worker should not be started"
Summary: Fixed a racing condition when shutting down NMT while worker thread is being started, also fixed a few mis-declared volatile pointers.
Reviewed-by: dholmes, dlong

! src/share/vm/runtime/thread.hpp
! src/share/vm/services/memTrackWorker.cpp
! src/share/vm/services/memTrackWorker.hpp
! src/share/vm/services/memTracker.cpp
! src/share/vm/services/memTracker.hpp

Changeset: f2c0ccccc6b6
Author:    rdurbin
Date:      2013-04-16 08:59 -0700
URL:       http://hg.openjdk.java.net/hsx/hotspot-main/hotspot/rev/f2c0ccccc6b6

Merge



From christian.thalinger at oracle.com  Wed Apr 17 16:06:29 2013
From: christian.thalinger at oracle.com (Christian Thalinger)
Date: Wed, 17 Apr 2013 16:06:29 -0700
Subject: hs25 review request (round 2): 8007037 JSR 292: the
	VM_RedefineClasses::append_entry() should do cross-checks with
	indy operands
In-Reply-To: <5167426E.6020502@oracle.com>
References: <5167426E.6020502@oracle.com>
Message-ID: 


On Apr 11, 2013, at 4:08 PM, serguei.spitsyn at oracle.com wrote:

> Please, review the hs25 fix (round 2) below.
> 
> Open webrev:
> http://cr.openjdk.java.net/~sspitsyn/webrevs/2013/hotspot/8007037-JVMTI-JSR292.2/

One thing that makes it hard to follow what going on are the variable names, e.g.:

new_bs_i
old_bs_i
merge_ops
found_i
argc (unusual usage of that name :-)
?

I suppose _i is for index?  bs for bootstrap?  I don't expect you to change this; just pointing out.

src/share/vm/prims/jvmtiRedefineClasses.cpp:

+// value by seaching the index map. Returns zero (-1) if there is no mapped

"Returns zero"?

The change seems to be fine.  For correctness I really rely on your testing here.

-- Chris

> 
> CR:
> http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=8007037
> https://jbs.oracle.com/bugs/browse/JDK-8007037
> 
> 
> This webrev includes a review fix from Coleen about explicit deallocation
> of the old operands array in ConstantPool::resize_operands() and a couple
> of fixes for the corner case when the old CP has no operands array:
> 
> 1121 void ConstantPool::extend_operands(constantPoolHandle ext_cp, TRAPS) {
> . . .
> 1130   if (operand_array_length(operands()) == 0) {
> 1131     ClassLoaderData* loader_data = pool_holder()->class_loader_data();
> 1132     Array* new_ops = MetadataFactory::new_array(loader_data, delta_size, CHECK);
> 1133     // The first element index defines the offset of second part
> +        operand_offset_at_put(new_ops, 0, 2*delta_len); // offset in new array
> 1135     set_operands(new_ops);
> 1136   } else {
> 1137     resize_operands(delta_len, delta_size, CHECK);
> 1138   }
> 1139
> 1140 } // end extend_operands()
> 
> 
> void VM_RedefineClasses::append_operand(constantPoolHandle scratch_cp, int old_bs_i,
> 505        constantPoolHandle *merge_cp_p, int *merge_cp_length_p, TRAPS) {
> . . .
> 
> - 518   int new_base = (*merge_cp_p)->operand_next_offset_at(new_bs_i);
> 
> --
> 
> + 518   // We have _operands_cur_length == 0 when the merge_cp operands is empty yet.
> + 519   // However, the operand_offset_at(0) was set in the extend_operands() call.
> + 520   int new_base = (new_bs_i == 0) ? (*merge_cp_p)->operand_offset_at(0)
> + 521                                  : (*merge_cp_p)->operand_next_offset_at(new_bs_i - 1);
> 
> 
> 
> Description:
> 
> References from INDY bootstrap method specifier operands to CP entries
> and back must be correctly merged at class redefinition.
> 
> Some background.
> 
> An invokedynamic bytecode spec:
> http://docs.oracle.com/javase/specs/jvms/se7/html/jvms-6.html#jvms-6.5.invokedynamic
> 
> A invokedynamic instruction has an argument which is an index to the *Constant Pool* item.
> That index must be a symbolic reference to a *call-site specifier*:
> http://docs.oracle.com/javase/specs/jvms/se7/html/jvms-4.html#jvms-4.4.10
> 
> A CP item of the type *CONSTANT_InvokeDynamic_inf* has an index into
> the *bootstrap method attribute* of the class file:
> http://docs.oracle.com/javase/specs/jvms/se7/html/jvms-4.html#jvms-4.7.21
> 
> The *|BootstrapMethods|* attribute elements normally have references to other *Constant Pool* items.
> 
> In VM the *bootstrap method attribute* is represented by the *operands* array of the *ConstantPool*.
> 
> The problem is is that all the force and back cross links between *ConstantPool* elements
> and *operands* array elements must be correctly merged at class redefinition.
> 
> Test coverage:
>  vm.mlvm, nsk.jvmti, nsk.jdi tests on multiple platforms (32 vs 64-bit too).
>  The testing looks good so far.
>  One difficulty is that new vm.mlvm tests are currently failed because of multiple reasons.
> 
> 
> Thanks,
> Serguei


From serguei.spitsyn at oracle.com  Wed Apr 17 16:28:31 2013
From: serguei.spitsyn at oracle.com (serguei.spitsyn at oracle.com)
Date: Wed, 17 Apr 2013 16:28:31 -0700
Subject: hs25 review request (round 2): 8007037 JSR 292: the
	VM_RedefineClasses::append_entry()
	should do cross-checks with indy operands
In-Reply-To: 
References: <5167426E.6020502@oracle.com>
	
Message-ID: <516F301F.9090701@oracle.com>

Hi Christian,


On 4/17/13 4:06 PM, Christian Thalinger wrote:
> On Apr 11, 2013, at 4:08 PM, serguei.spitsyn at oracle.com wrote:
>
>> Please, review the hs25 fix (round 2) below.
>>
>> Open webrev:
>> http://cr.openjdk.java.net/~sspitsyn/webrevs/2013/hotspot/8007037-JVMTI-JSR292.2/
> One thing that makes it hard to follow what going on are the variable names, e.g.:
>
> new_bs_i
> old_bs_i
> merge_ops
> found_i
> argc (unusual usage of that name :-)
> ?
>
> I suppose _i is for index?  bs for bootstrap?  I don't expect you to change this; just pointing out.
Yes, _i stands for index and bs is for bootstrap.
For most of these names I just follow the style that was in that file.

> src/share/vm/prims/jvmtiRedefineClasses.cpp:
>
> +// value by seaching the index map. Returns zero (-1) if there is no mapped
>
> "Returns zero"?

Nice catch, I'll fix it. It must be just -1.

>
> The change seems to be fine.  For correctness I really rely on your testing here.

Thanks a lot for reviewing, I really appreciate it!

Thanks,
Serguei
>
> -- Chris
>
>> CR:
>> http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=8007037
>> https://jbs.oracle.com/bugs/browse/JDK-8007037
>>
>>
>> This webrev includes a review fix from Coleen about explicit deallocation
>> of the old operands array in ConstantPool::resize_operands() and a couple
>> of fixes for the corner case when the old CP has no operands array:
>>
>> 1121 void ConstantPool::extend_operands(constantPoolHandle ext_cp, TRAPS) {
>> . . .
>> 1130   if (operand_array_length(operands()) == 0) {
>> 1131     ClassLoaderData* loader_data = pool_holder()->class_loader_data();
>> 1132     Array* new_ops = MetadataFactory::new_array(loader_data, delta_size, CHECK);
>> 1133     // The first element index defines the offset of second part
>> +        operand_offset_at_put(new_ops, 0, 2*delta_len); // offset in new array
>> 1135     set_operands(new_ops);
>> 1136   } else {
>> 1137     resize_operands(delta_len, delta_size, CHECK);
>> 1138   }
>> 1139
>> 1140 } // end extend_operands()
>>
>>
>> void VM_RedefineClasses::append_operand(constantPoolHandle scratch_cp, int old_bs_i,
>> 505        constantPoolHandle *merge_cp_p, int *merge_cp_length_p, TRAPS) {
>> . . .
>>
>> - 518   int new_base = (*merge_cp_p)->operand_next_offset_at(new_bs_i);
>>
>> --
>>
>> + 518   // We have _operands_cur_length == 0 when the merge_cp operands is empty yet.
>> + 519   // However, the operand_offset_at(0) was set in the extend_operands() call.
>> + 520   int new_base = (new_bs_i == 0) ? (*merge_cp_p)->operand_offset_at(0)
>> + 521                                  : (*merge_cp_p)->operand_next_offset_at(new_bs_i - 1);
>>
>>
>>
>> Description:
>>
>> References from INDY bootstrap method specifier operands to CP entries
>> and back must be correctly merged at class redefinition.
>>
>> Some background.
>>
>> An invokedynamic bytecode spec:
>> http://docs.oracle.com/javase/specs/jvms/se7/html/jvms-6.html#jvms-6.5.invokedynamic
>>
>> A invokedynamic instruction has an argument which is an index to the *Constant Pool* item.
>> That index must be a symbolic reference to a *call-site specifier*:
>> http://docs.oracle.com/javase/specs/jvms/se7/html/jvms-4.html#jvms-4.4.10
>>
>> A CP item of the type *CONSTANT_InvokeDynamic_inf* has an index into
>> the *bootstrap method attribute* of the class file:
>> http://docs.oracle.com/javase/specs/jvms/se7/html/jvms-4.html#jvms-4.7.21
>>
>> The *|BootstrapMethods|* attribute elements normally have references to other *Constant Pool* items.
>>
>> In VM the *bootstrap method attribute* is represented by the *operands* array of the *ConstantPool*.
>>
>> The problem is is that all the force and back cross links between *ConstantPool* elements
>> and *operands* array elements must be correctly merged at class redefinition.
>>
>> Test coverage:
>>   vm.mlvm, nsk.jvmti, nsk.jdi tests on multiple platforms (32 vs 64-bit too).
>>   The testing looks good so far.
>>   One difficulty is that new vm.mlvm tests are currently failed because of multiple reasons.
>>
>>
>> Thanks,
>> Serguei


From john.r.rose at oracle.com  Wed Apr 17 19:05:56 2013
From: john.r.rose at oracle.com (John Rose)
Date: Wed, 17 Apr 2013 19:05:56 -0700
Subject: hs25 review request (2nd round): 8008511 JSR 292: MemberName
	vmtarget refs to methods must be updated at class redefinition
In-Reply-To: <516C3FFD.9040606@oracle.com>
References: <5168BF57.3030206@oracle.com> <516B8C37.7020002@oracle.com>
	<516C3FFD.9040606@oracle.com>
Message-ID: <58C449C3-D8BE-4924-9646-7FAB696E4759@oracle.com>

As we discussed verbally, I suggest adding a line like this at the beginning of every low-level MemberNameTable access function:

    assert_locked_or_safepoint(MemberNameTable_lock);

(I'm modeling this from SystemDictionary::find_class and its brothers.)

The rest of it looks good.  Reviewed!

? John


On Apr 15, 2013, at 10:59 AM, serguei.spitsyn at oracle.com wrote:

>> 
>> b) do we need to use the MemberNameTable_lock to guard this? 
> 
> I don't think so.
> This deallocation must be done at a safepoint.
> We can't grab locks at safepoints.
> 
> These are the details:
> 
> classLoaderData.cpp:
> 
> // Deallocate free metadata on the free list.  How useful the PermGen was!
> void ClassLoaderData::free_deallocate_list() {
>   // Don't need lock, at safepoint
>   assert(SafepointSynchronize::is_at_safepoint(), "only called at safepoint");
>       . . .
>       } else if (m->is_klass()) {
>         MetadataFactory::free_metadata(this, (InstanceKlass*)m);
>      . . .
> }
> 
> metadataFactory.hpp:
> 
>   // Deallocation method for metadata
>   template 
>   static void free_metadata(ClassLoaderData* loader_data, T md) {
>     if (md != NULL) {
>       . . .
>       md->deallocate_contents(loader_data);
>       loader_data->metaspace_non_null()->deallocate((MetaWord*)md, size, md->is_klass());
>     }
>   }
> 
> instanceKlass.cpp:
> 
> void InstanceKlass::deallocate_contents(ClassLoaderData* loader_data) {
>   . . .
>   release_C_heap_structures();
>   . . .
> }


From staffan.larsen at oracle.com  Thu Apr 18 05:17:31 2013
From: staffan.larsen at oracle.com (staffan.larsen at oracle.com)
Date: Thu, 18 Apr 2013 12:17:31 +0000
Subject: hg: hsx/hsx24/hotspot: 8006423: SA: NullPointerException in
	sun.jvm.hotspot.debugger.bsd.BsdThread.getContext(BsdThread.java:67)
Message-ID: <20130418121733.CE70D48404@hg.openjdk.java.net>

Changeset: be693a09e7f5
Author:    sla
Date:      2013-02-08 12:48 +0100
URL:       http://hg.openjdk.java.net/hsx/hsx24/hotspot/rev/be693a09e7f5

8006423: SA: NullPointerException in sun.jvm.hotspot.debugger.bsd.BsdThread.getContext(BsdThread.java:67)
Summary: Do not rely on mach thread port names to identify threads from SA
Reviewed-by: dholmes, minqi, rbackman

! agent/src/os/bsd/MacosxDebuggerLocal.m
! agent/src/share/classes/sun/jvm/hotspot/debugger/bsd/BsdDebugger.java
! agent/src/share/classes/sun/jvm/hotspot/debugger/bsd/BsdDebuggerLocal.java
! agent/src/share/classes/sun/jvm/hotspot/debugger/bsd/BsdThread.java
! agent/src/share/classes/sun/jvm/hotspot/runtime/bsd_amd64/BsdAMD64JavaThreadPDAccess.java
! src/os/bsd/vm/osThread_bsd.hpp
! src/os/bsd/vm/os_bsd.cpp
! src/os_cpu/bsd_x86/vm/vmStructs_bsd_x86.hpp


From peter.allwin at oracle.com  Thu Apr 18 07:10:01 2013
From: peter.allwin at oracle.com (Peter Allwin)
Date: Thu, 18 Apr 2013 16:10:01 +0200
Subject: Review request: 6729929 I18N - Taking Heap Dump failed if project
	path contains multibyte characters
In-Reply-To: <515C55F4.6020002@oracle.com>
References: <515C55F4.6020002@oracle.com>
Message-ID: <516FFEB9.90509@oracle.com>

Hi all, I'm still looking for reviews for this change...

Thanks!

/peter

On 4/3/2013 6:16 PM, Peter Allwin wrote:
> Webrev: http://cr.openjdk.java.net/~mgronlun/6729929/webrev01/ 
> 
> Bug: http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=6729929
>
> Summary: When dumpHeap in the HotSpotDiagnostic JMX MBean is called, 
> the filename parameter must be converted from jstring to char* to be 
> used in open(). This was done using UTF-8 encoding which is incorrect 
> as open() expects a platform dependent encoding according to the 
> system locale. Fix is to use 
> java_lang_String::as_platform_dependent_str to do the conversion.
>
> Thanks to Markus for advising and hosting the webrev!
>
> Regards,
>
> /peter


From mikael.gerdin at oracle.com  Thu Apr 18 08:04:41 2013
From: mikael.gerdin at oracle.com (Mikael Gerdin)
Date: Thu, 18 Apr 2013 17:04:41 +0200
Subject: RFR (S): 8011803: release_C_heap_structures is never called for
	anonymous classes.
In-Reply-To: <516EC666.5010805@oracle.com>
References: <51672297.3080503@oracle.com> <5167CA4C.5040608@oracle.com>
	<51680041.5070905@oracle.com> <51685A67.4020007@oracle.com>
	<51687E59.6060702@oracle.com> <516BB8FD.4030001@oracle.com>
	<516EC666.5010805@oracle.com>
Message-ID: <51700B89.9000901@oracle.com>

Coleen

On 04/17/2013 05:57 PM, Coleen Phillimore wrote:
>
> Mikael, Thanks for looking at this in detail.
>
> On 4/15/2013 4:23 AM, Mikael Gerdin wrote:
>> Coleen,
>>
>> On 2013-04-12 23:36, Coleen Phillimore wrote:
>>> On 4/12/2013 3:03 PM, Coleen Phillimore wrote:
>>>>
>>>> Hi,
>>>>
>>>> I have updated the webrev to split the serviceability actions and the
>>>> deleting C heap data for classes in ClassLoaderData.  I left the
>>>> serviceability actions in dictionary::do_unloading() to avoid
>>>> rewalking the ClassLoaderData _klasses.   For
>>>> release_C_heap_structures(), all the _klasses are walked at the end.
>>>> This should work for Markus G's new serviceability changes with minor
>>>> modifications.
>>>
>>> Reload if you looked at this already.  Stefan convinced me that walking
>>> the class list in the ClassLoaderData::unload() is not too expensive, so
>>> the serviceability actions have been removed from
>>> dictionary::do_unloading() and done in ClassLoaderData::unload()
>>> unconditionally.
>>
>> It looks like http://cr.openjdk.java.net/~coleenp/8011803_2/ is the
>> wrong webrev since it's inconsistent with your mail.
>> But I have some comments about moving the calls to
>> release_c_heap_structures.
>
> I forgot to copy it over.  Please reload.
>>
>>
>> By moving the calls to {IK,CP}::release_c_heap_structures to
>> ~ClassLoaderData they will be called concurrently from the CMS thread
>> through its call to ClassLoaderDataGraph::purge.
>>
>> Previously they were called at a safepoint since
>> Dictionary::do_unloading is only called at safepoint.
>> A cursory inspection suggests that this is safe.
>>
>> However.
>> This will cause the symbol refcounts to be decremented at a later
>> stage than before, in fact by the time we come to ~ClassLoaderData
>> we've already called SymbolTable::unkink so this will artificially
>> extend the lifetime of unreferenced symbols by one full gc.
>
> Yes, this is true and a good point.  I feel like it's safer actually
> since all the memory shouldn't go away before the destructor is run.
> Symbols aren't reclaimed that much so this change is not likely to cause
> a measurable increase in footprint between GC's (famous last words).

Well, I see what you mean regarding the destructor but it seems kind of 
strange to always shift the symbol unloading to the next GC as well.

I'm not going to insist on you changing this.

/Mikael

>
> Coleen
>
>>
>> /Mikael
>>
>>> but delaying
>>>>
>>>> open webrev at http://cr.openjdk.java.net/~coleenp/8011803_2/
>>>>
>>>> thanks,
>>>> Coleen
>>>>
>>>> On 4/12/2013 8:38 AM, Coleen Phillimore wrote:
>>>>> On 4/12/2013 4:48 AM, Stefan Karlsson wrote:
>>>>>> On 04/11/2013 10:52 PM, Coleen Phillimore wrote:
>>>>>>> Summary: Call this function from CLD::unload()  now for anonymous
>>>>>>> classes.
>>>>>>>
>>>>>>> Anonymous classes aren't in the system dictionary so
>>>>>>> release_C_heap_structures isn't called for them if they are
>>>>>>> unloaded.  I fixed this for jdk8 because they are in the class
>>>>>>> loader data graph but for jdk7, I don't know how to fix this. They
>>>>>>> are unloaded by being garbage collected after the references are
>>>>>>> dropped.
>>>>>>>
>>>>>>> Tested with ute tests vm.mvlm.testlist nsk.monitoring.testlist and
>>>>>>> jdk/test/java/lang/invoke tests.
>>>>>>>
>>>>>>> open webrev at http://cr.openjdk.java.net/~coleenp/8011803/
>>>>>>> bug link at http://bugs.sun.com/view_bug.do?bug_id=8011803
>>>>>>
>>>>>> I've two comments.
>>>>>>
>>>>>> 1) It's unfortunate that we now call unload_class() at two different
>>>>>> places in the code. It makes it harder to understand the
>>>>>> deallocation of metadata. It would be better to keep the calls to
>>>>>> unload_class() for ordinary InstanceKlasses and anonymous classes
>>>>>> together.
>>>>>
>>>>> Hi Stefan,  Thank you for looking at this.   This is the feedback I
>>>>> was looking for.
>>>>>
>>>>> I went back and forth about moving the regular class unloading
>>>>> actions for everything in unload (or ~ClassLoaderData), but I didn't
>>>>> want to introduce a _klasses walk for all the class loaders.   We're
>>>>> already walking them in the system dictionary purge.
>>>>>
>>>>> For my change I'm walking these classes if
>>>>> UseCompressedKlassPointers, and Markus is walking them for
>>>>> serviceability (hopefully under some flag) so maybe I should just
>>>>> do it.
>>>>>
>>>>>>
>>>>>> 2) This change actually breaks the Tracing class unloading event
>>>>>> that Markus is working on. That code walk the
>>>>>> ClassLoaderDataGraph::_unloading list in
>>>>>> ClassLoaderDataGraph::do_unloading and use the information in the
>>>>>> classes of the CLDs that are about to be unloaded. With this patch
>>>>>> they probably crash because some pointers in the anonymous classes
>>>>>> will be trashed.
>>>>>>
>>>>>
>>>>> I thought about that, since I've been talking to Markus about this. I
>>>>> wanted to consolidate the serviceability calls in one place and
>>>>> calling InstanceKlass::unload_class() that notifies serviceability in
>>>>> the ~ClassLoaderData destructor might be too late.  It might not be
>>>>> though.   I think the walk in the destructor might be better for
>>>>> release_C_heap_structures though.
>>>>>
>>>>>> I have a suggestion on how to solve both points above. It's probably
>>>>>> easier to show with a pseudo patch:
>>>>>>
>>>>>> $ hg diff
>>>>>> diff --git a/src/share/vm/classfile/classLoaderData.cpp
>>>>>> b/src/share/vm/classfile/classLoaderData.cpp
>>>>>> --- a/src/share/vm/classfile/classLoaderData.cpp
>>>>>> +++ b/src/share/vm/classfile/classLoaderData.cpp
>>>>>> @@ -671,7 +671,6 @@
>>>>>>      }
>>>>>>      seen_dead_loader = true;
>>>>>>      ClassLoaderData* dead = data;
>>>>>> -    dead->unload();
>>>>>>      data = data->next();
>>>>>>      // Remove from loader list.
>>>>>>      if (prev != NULL) {
>>>>>> @@ -683,9 +682,24 @@
>>>>>>      dead->set_next(_unloading);
>>>>>>      _unloading = dead;
>>>>>>    }
>>>>>> +
>>>>>> +  report_class_unloading_info(_unloading);
>>>>>> +
>>>>>> +  ClassLoaderDataGraph::unload_classes();
>>>>>> +
>>>>>>    return seen_dead_loader;
>>>>>>  }
>>>>>>
>>>>>> +void ClassLoaderDataGraph::unload_classes() {
>>>>>> +  ClassLoaderData* list = _unloading;
>>>>>> +  ClassLoaderData* next = list;
>>>>>> +  while (next != NULL) {
>>>>>> +    for (Klass* k = next->_klasses; k != NULL; k = k->next_link()) {
>>>>>> +      k->unload_class();
>>>>>> +    }
>>>>>> +  }
>>>>>> +}
>>>>>> +
>>>>>
>>>>> That's too much extra walking.   But maybe we can split the
>>>>> serviceability stuff into ClassLoaderData::unload() and do the
>>>>> release_C_heap_structures() into the ClassLoaderData destructor. That
>>>>> seems better.   Maybe Markus could put his callback into
>>>>> CLD::unload().
>>>>>
>>>>> Thanks!  I will change this and resend.
>>>>> Coleen
>>>>>
>>>>>>  void ClassLoaderDataGraph::purge() {
>>>>>>    ClassLoaderData* list = _unloading;
>>>>>>    _unloading = NULL;
>>>>>> diff --git a/src/share/vm/classfile/dictionary.cpp
>>>>>> b/src/share/vm/classfile/dictionary.cpp
>>>>>> --- a/src/share/vm/classfile/dictionary.cpp
>>>>>> +++ b/src/share/vm/classfile/dictionary.cpp
>>>>>> @@ -157,9 +157,6 @@
>>>>>>              // to be unloaded.
>>>>>>              // Notify the debugger and clean up the class.
>>>>>>              class_was_unloaded = true;
>>>>>> -
>>>>>> -            // perform unloading actions on this class
>>>>>> -            ik->unload_class();
>>>>>>            }
>>>>>>            // Also remove this system dictionary entry.
>>>>>>            purge_entry = true;
>>>>>>
>>>>>> As a bonus, the dictionary()->do_unloading() will then only do a
>>>>>> simple purge of the SystemDictionary.
>>>>>>
>>>>>> What do you think?
>>>>>>
>>>>>> thanks,
>>>>>> StefanK
>>>>>>
>>>>>>>
>>>>>>> Thanks,
>>>>>>> Coleen
>>>>>>
>>>>>
>>>>
>>>
>


From nils.loodin at oracle.com  Thu Apr 18 08:51:25 2013
From: nils.loodin at oracle.com (nils.loodin at oracle.com)
Date: Thu, 18 Apr 2013 15:51:25 +0000
Subject: hg: hsx/hsx24/hotspot: 2 new changesets
Message-ID: <20130418155134.E448D4840C@hg.openjdk.java.net>

Changeset: 4135583e60cc
Author:    nloodin
Date:      2013-04-04 13:49 +0200
URL:       http://hg.openjdk.java.net/hsx/hsx24/hotspot/rev/4135583e60cc

8012212: Want to link against kstat on solaris x86 as well as sparc
Reviewed-by: brutisso, mgronlun

! make/solaris/makefiles/vm.make

Changeset: 9dccaeb8e966
Author:    nloodin
Date:      2013-04-18 15:18 +0200
URL:       http://hg.openjdk.java.net/hsx/hsx24/hotspot/rev/9dccaeb8e966

Merge



From mikael.gerdin at oracle.com  Thu Apr 18 09:20:03 2013
From: mikael.gerdin at oracle.com (mikael.gerdin at oracle.com)
Date: Thu, 18 Apr 2013 16:20:03 +0000
Subject: hg: hsx/hotspot-main/hotspot: 7 new changesets
Message-ID: <20130418162022.5BDE84840D@hg.openjdk.java.net>

Changeset: 71013d764f6e
Author:    johnc
Date:      2013-04-10 10:57 -0700
URL:       http://hg.openjdk.java.net/hsx/hotspot-main/hotspot/rev/71013d764f6e

8010780: G1: Eden occupancy/capacity output wrong after a full GC
Summary: Move the calculation and recording of eden capacity to the start of a GC and print a detailed heap transition for full GCs.
Reviewed-by: tschatzl, jmasa

! src/share/vm/gc_implementation/g1/g1CollectedHeap.cpp
! src/share/vm/gc_implementation/g1/g1CollectorPolicy.cpp
! src/share/vm/gc_implementation/g1/g1CollectorPolicy.hpp

Changeset: c0000f77bc6d
Author:    johnc
Date:      2013-04-11 10:20 -0700
URL:       http://hg.openjdk.java.net/hsx/hotspot-main/hotspot/rev/c0000f77bc6d

Merge

! src/share/vm/gc_implementation/g1/g1CollectedHeap.cpp

Changeset: 9aa8d8037ee3
Author:    mgerdin
Date:      2013-04-16 12:46 +0200
URL:       http://hg.openjdk.java.net/hsx/hotspot-main/hotspot/rev/9aa8d8037ee3

Merge

! src/share/vm/gc_implementation/g1/g1CollectorPolicy.cpp

Changeset: df254344edf1
Author:    jmasa
Date:      2013-04-01 10:50 -0700
URL:       http://hg.openjdk.java.net/hsx/hotspot-main/hotspot/rev/df254344edf1

8011173: NPG: Replace the ChunkList implementation with class FreeList
Reviewed-by: mgerdin, tschatzl, johnc, coleenp

! src/share/vm/memory/metaspace.cpp

Changeset: f2e682ef3156
Author:    johnc
Date:      2013-04-17 10:57 -0700
URL:       http://hg.openjdk.java.net/hsx/hotspot-main/hotspot/rev/f2e682ef3156

8012335: G1: Fix bug with compressed oops in template interpreter on x86 and sparc.
Summary: In do_oop_store the uncompressed value of the oop being stored needs to be preserved and passed to g1_write_barrier_post. This is necessary for the heap region cross check to work correctly.
Reviewed-by: coleenp, johnc
Contributed-by: Martin Doerr 

! src/cpu/sparc/vm/templateTable_sparc.cpp
! src/cpu/x86/vm/templateTable_x86_64.cpp

Changeset: 07a4efc5ed14
Author:    brutisso
Date:      2013-04-18 06:50 +0200
URL:       http://hg.openjdk.java.net/hsx/hotspot-main/hotspot/rev/07a4efc5ed14

8012455: Missing time and date stamps for PrintGCApplicationConcurrentTime and PrintGCApplicationStoppedTime
Summary: also reviewed by: kirk at kodewerk.com, brandon at twitter.com
Reviewed-by: tschatzl, stefank, johnc

! src/share/vm/services/runtimeService.cpp

Changeset: cbf8c8c25bbe
Author:    mgerdin
Date:      2013-04-18 14:38 +0200
URL:       http://hg.openjdk.java.net/hsx/hotspot-main/hotspot/rev/cbf8c8c25bbe

Merge



From markus.gronlund at oracle.com  Thu Apr 18 12:04:33 2013
From: markus.gronlund at oracle.com (markus.gronlund at oracle.com)
Date: Thu, 18 Apr 2013 19:04:33 +0000
Subject: hg: hsx/hsx24/hotspot: 2 new changesets
Message-ID: <20130418190437.E7AA848419@hg.openjdk.java.net>

Changeset: 04f81958a8e2
Author:    mgronlun
Date:      2013-04-18 17:46 +0200
URL:       http://hg.openjdk.java.net/hsx/hsx24/hotspot/rev/04f81958a8e2

8012182: Add information about class loading and unloading to event based tracing framework
Reviewed-by: coleenp, dholmes, sspitsyn
Contributed-by: calvin.cheung at oracle.com

! src/share/vm/classfile/systemDictionary.cpp
! src/share/vm/classfile/systemDictionary.hpp
! src/share/vm/gc_implementation/shared/gcTraceSend.cpp
! src/share/vm/runtime/objectMonitor.cpp
! src/share/vm/trace/trace.xml
! src/share/vm/trace/traceBackend.hpp
! src/share/vm/trace/traceEvent.hpp
! src/share/vm/trace/traceEventClasses.xsl
! src/share/vm/trace/traceStream.hpp

Changeset: 0e9dba751d8b
Author:    mgronlun
Date:      2013-04-18 18:06 +0200
URL:       http://hg.openjdk.java.net/hsx/hsx24/hotspot/rev/0e9dba751d8b

Merge



From John.Coomes at oracle.com  Thu Apr 18 12:39:45 2013
From: John.Coomes at oracle.com (John Coomes)
Date: Thu, 18 Apr 2013 12:39:45 -0700
Subject: CFV: New hsx Committer: Tao Mao
Message-ID: <20848.19457.854901.807286@oracle.com>

I hereby nominate Tao Mao to hsx Committer.

Tao joined the HotSpot garbage collection team at Oracle last year;
over the last eight months he has contributed eight changesets which
have improved or fixed bugs in several different GC components
including ergonomics, G1 and serial gc [1].

Votes are due by Thu, May 2, 2013 8:00pm UTC [2].

Only current hsx Committers [3] are eligible to vote on this
nomination.  Votes must be cast in the open by replying to to this
mailing list.

For Lazy Consensus voting instructions, see [4].

John Coomes, hsx Project Lead

[1] http://hg.openjdk.java.net/hsx/hotspot-gc/hotspot/log?rev=tao.mao
[2] http://www.timeanddate.com/worldclock/fixedtime.html?msg=CFV%3A+New+hsx+Committer%3A+Tao+Mao&iso=20130502T20
[3] http://openjdk.java.net/census/#hsx
[4] http://openjdk.java.net/projects/#committer-vote

From jon.masamitsu at oracle.com  Thu Apr 18 12:56:47 2013
From: jon.masamitsu at oracle.com (Jon Masamitsu)
Date: Thu, 18 Apr 2013 12:56:47 -0700
Subject: CFV: New hsx Committer: Tao Mao
In-Reply-To: <20848.19457.854901.807286@oracle.com>
References: <20848.19457.854901.807286@oracle.com>
Message-ID: <51704FFF.6050205@oracle.com>

Vote: Yes


On 4/18/13 12:39 PM, John Coomes wrote:
> I hereby nominate Tao Mao to hsx Committer.
>
> Tao joined the HotSpot garbage collection team at Oracle last year;
> over the last eight months he has contributed eight changesets which
> have improved or fixed bugs in several different GC components
> including ergonomics, G1 and serial gc [1].
>
> Votes are due by Thu, May 2, 2013 8:00pm UTC [2].
>
> Only current hsx Committers [3] are eligible to vote on this
> nomination.  Votes must be cast in the open by replying to to this
> mailing list.
>
> For Lazy Consensus voting instructions, see [4].
>
> John Coomes, hsx Project Lead
>
> [1] http://hg.openjdk.java.net/hsx/hotspot-gc/hotspot/log?rev=tao.mao
> [2] http://www.timeanddate.com/worldclock/fixedtime.html?msg=CFV%3A+New+hsx+Committer%3A+Tao+Mao&iso=20130502T20
> [3] http://openjdk.java.net/census/#hsx
> [4] http://openjdk.java.net/projects/#committer-vote


From daniel.daugherty at oracle.com  Thu Apr 18 13:01:58 2013
From: daniel.daugherty at oracle.com (Daniel D. Daugherty)
Date: Thu, 18 Apr 2013 14:01:58 -0600
Subject: CFV: New hsx Committer: Tao Mao
In-Reply-To: <20848.19457.854901.807286@oracle.com>
References: <20848.19457.854901.807286@oracle.com>
Message-ID: <51705136.7060405@oracle.com>

Vote: yes

Dan


On 4/18/13 1:39 PM, John Coomes wrote:
> I hereby nominate Tao Mao to hsx Committer.
>
> Tao joined the HotSpot garbage collection team at Oracle last year;
> over the last eight months he has contributed eight changesets which
> have improved or fixed bugs in several different GC components
> including ergonomics, G1 and serial gc [1].
>
> Votes are due by Thu, May 2, 2013 8:00pm UTC [2].
>
> Only current hsx Committers [3] are eligible to vote on this
> nomination.  Votes must be cast in the open by replying to to this
> mailing list.
>
> For Lazy Consensus voting instructions, see [4].
>
> John Coomes, hsx Project Lead
>
> [1] http://hg.openjdk.java.net/hsx/hotspot-gc/hotspot/log?rev=tao.mao
> [2] http://www.timeanddate.com/worldclock/fixedtime.html?msg=CFV%3A+New+hsx+Committer%3A+Tao+Mao&iso=20130502T20
> [3] http://openjdk.java.net/census/#hsx
> [4] http://openjdk.java.net/projects/#committer-vote


From vladimir.x.ivanov at oracle.com  Thu Apr 18 13:06:38 2013
From: vladimir.x.ivanov at oracle.com (Vladimir Ivanov)
Date: Fri, 19 Apr 2013 00:06:38 +0400
Subject: CFV: New hsx Committer: Tao Mao
In-Reply-To: <20848.19457.854901.807286@oracle.com>
References: <20848.19457.854901.807286@oracle.com>
Message-ID: <5170524E.1090300@oracle.com>

Vote: yes

Best regards,
Vladimir Ivanov

On 4/18/13 11:39 PM, John Coomes wrote:
> I hereby nominate Tao Mao to hsx Committer.
>
> Tao joined the HotSpot garbage collection team at Oracle last year;
> over the last eight months he has contributed eight changesets which
> have improved or fixed bugs in several different GC components
> including ergonomics, G1 and serial gc [1].
>
> Votes are due by Thu, May 2, 2013 8:00pm UTC [2].
>
> Only current hsx Committers [3] are eligible to vote on this
> nomination.  Votes must be cast in the open by replying to to this
> mailing list.
>
> For Lazy Consensus voting instructions, see [4].
>
> John Coomes, hsx Project Lead
>
> [1] http://hg.openjdk.java.net/hsx/hotspot-gc/hotspot/log?rev=tao.mao
> [2] http://www.timeanddate.com/worldclock/fixedtime.html?msg=CFV%3A+New+hsx+Committer%3A+Tao+Mao&iso=20130502T20
> [3] http://openjdk.java.net/census/#hsx
> [4] http://openjdk.java.net/projects/#committer-vote
>

From krystal.mo at oracle.com  Thu Apr 18 13:19:26 2013
From: krystal.mo at oracle.com (Krystal Mo)
Date: Thu, 18 Apr 2013 13:19:26 -0700
Subject: CFV: New hsx Committer: Tao Mao
In-Reply-To: <20848.19457.854901.807286@oracle.com>
References: <20848.19457.854901.807286@oracle.com>
Message-ID: <5170554E.40205@oracle.com>

Vote: yes

- Kris

On 2013/4/18 12:39, John Coomes wrote:
> I hereby nominate Tao Mao to hsx Committer.
>
> Tao joined the HotSpot garbage collection team at Oracle last year;
> over the last eight months he has contributed eight changesets which
> have improved or fixed bugs in several different GC components
> including ergonomics, G1 and serial gc [1].
>
> Votes are due by Thu, May 2, 2013 8:00pm UTC [2].
>
> Only current hsx Committers [3] are eligible to vote on this
> nomination.  Votes must be cast in the open by replying to to this
> mailing list.
>
> For Lazy Consensus voting instructions, see [4].
>
> John Coomes, hsx Project Lead
>
> [1] http://hg.openjdk.java.net/hsx/hotspot-gc/hotspot/log?rev=tao.mao
> [2] http://www.timeanddate.com/worldclock/fixedtime.html?msg=CFV%3A+New+hsx+Committer%3A+Tao+Mao&iso=20130502T20
> [3] http://openjdk.java.net/census/#hsx
> [4] http://openjdk.java.net/projects/#committer-vote


From zhengyu.gu at oracle.com  Thu Apr 18 13:23:04 2013
From: zhengyu.gu at oracle.com (Zhengyu Gu)
Date: Thu, 18 Apr 2013 16:23:04 -0400
Subject: CFV: New hsx Committer: Tao Mao
In-Reply-To: <20848.19457.854901.807286@oracle.com>
References: <20848.19457.854901.807286@oracle.com>
Message-ID: <51705628.7090108@oracle.com>

Vote: yes

-Zhengyu

On 4/18/2013 3:39 PM, John Coomes wrote:
> I hereby nominate Tao Mao to hsx Committer.
>
> Tao joined the HotSpot garbage collection team at Oracle last year;
> over the last eight months he has contributed eight changesets which
> have improved or fixed bugs in several different GC components
> including ergonomics, G1 and serial gc [1].
>
> Votes are due by Thu, May 2, 2013 8:00pm UTC [2].
>
> Only current hsx Committers [3] are eligible to vote on this
> nomination.  Votes must be cast in the open by replying to to this
> mailing list.
>
> For Lazy Consensus voting instructions, see [4].
>
> John Coomes, hsx Project Lead
>
> [1] http://hg.openjdk.java.net/hsx/hotspot-gc/hotspot/log?rev=tao.mao
> [2] http://www.timeanddate.com/worldclock/fixedtime.html?msg=CFV%3A+New+hsx+Committer%3A+Tao+Mao&iso=20130502T20
> [3] http://openjdk.java.net/census/#hsx
> [4] http://openjdk.java.net/projects/#committer-vote


From serguei.spitsyn at oracle.com  Thu Apr 18 13:23:44 2013
From: serguei.spitsyn at oracle.com (serguei.spitsyn at oracle.com)
Date: Thu, 18 Apr 2013 13:23:44 -0700
Subject: CFV: New hsx Committer: Tao Mao
In-Reply-To: <20848.19457.854901.807286@oracle.com>
References: <20848.19457.854901.807286@oracle.com>
Message-ID: <51705650.9040900@oracle.com>

Vote: Yes

On 4/18/13 12:39 PM, John Coomes wrote:
> I hereby nominate Tao Mao to hsx Committer.
>
> Tao joined the HotSpot garbage collection team at Oracle last year;
> over the last eight months he has contributed eight changesets which
> have improved or fixed bugs in several different GC components
> including ergonomics, G1 and serial gc [1].
>
> Votes are due by Thu, May 2, 2013 8:00pm UTC [2].
>
> Only current hsx Committers [3] are eligible to vote on this
> nomination.  Votes must be cast in the open by replying to to this
> mailing list.
>
> For Lazy Consensus voting instructions, see [4].
>
> John Coomes, hsx Project Lead
>
> [1] http://hg.openjdk.java.net/hsx/hotspot-gc/hotspot/log?rev=tao.mao
> [2] http://www.timeanddate.com/worldclock/fixedtime.html?msg=CFV%3A+New+hsx+Committer%3A+Tao+Mao&iso=20130502T20
> [3] http://openjdk.java.net/census/#hsx
> [4] http://openjdk.java.net/projects/#committer-vote


From igor.ignatyev at oracle.com  Thu Apr 18 14:01:18 2013
From: igor.ignatyev at oracle.com (Igor Ignatyev)
Date: Fri, 19 Apr 2013 01:01:18 +0400
Subject: RFR(S) : 8012337 : Change Whitebox implementation to make absence
	of method in Whitebox.class not fatal
In-Reply-To: <516EAA0F.2020807@oracle.com>
References: <516E7569.1060201@oracle.com> <516E85EC.6040203@oracle.com>
	<516EAA0F.2020807@oracle.com>
Message-ID: <51705F1E.6050602@oracle.com>

could someone with "reviewer" status look at that?

Best regards,
Igor Ignatyev

On 04/17/2013 05:56 PM, Igor Ignatyev wrote:
> Mikael,
> Thank you for review.
>
> I have updated webrev:
> - added checking for exception class
> - added print warning on unexpected error
>
> http://cr.openjdk.java.net/~iignatyev/8012337/webrev.01/
>
> Best regards,
> Igor Ignatyev
>
> On 04/17/2013 03:22 PM, Mikael Gerdin wrote:
>> Igor,
>>
>> On 2013-04-17 12:11, Igor Ignatyev wrote:
>>> Hi all,
>>>
>>> Please review patch.
>>>
>>> Problem:
>>> If there is some method that presences in native part of whitebox, but
>>> absences in java side, we get 'j.l.NoSuchMethodError' exception
>>
>> The intended use of is of course that whitebox.cpp and WhiteBox.java are
>> in sync since they are in the same hg repository.
>>
>> I understand that some feel that they need to copy WhiteBox to some
>> other test suite and I find this change acceptable but unfortunate.
>>
>>>
>>> Fix:
>>> Batch registration of WB functions was replaced with one by one
>>> registration
>>>
>>> Testing:
>>> JPRT of sanity tests and tests that use WhiteBox: runtime/interned,
>>> compiler/whitebox
>>>
>>> webrev: http://cr.openjdk.java.net/~iignatyev/8012337/webrev.00/
>>
>> It's too bad that you need a shell script here but I don't see any way
>> around it.
>>
>> I'm ok with you pushing this.
>>
>> /Mikael
>>
>>> jbs: https://jbs.oracle.com/bugs/browse/JDK-8012337

From vladimir.kozlov at oracle.com  Thu Apr 18 15:18:34 2013
From: vladimir.kozlov at oracle.com (Vladimir Kozlov)
Date: Thu, 18 Apr 2013 15:18:34 -0700
Subject: CFV: New hsx Committer: Tao Mao
In-Reply-To: <20848.19457.854901.807286@oracle.com>
References: <20848.19457.854901.807286@oracle.com>
Message-ID: <5170713A.30507@oracle.com>

Vote: yes

On 4/18/13 12:39 PM, John Coomes wrote:
> I hereby nominate Tao Mao to hsx Committer.
>
> Tao joined the HotSpot garbage collection team at Oracle last year;
> over the last eight months he has contributed eight changesets which
> have improved or fixed bugs in several different GC components
> including ergonomics, G1 and serial gc [1].
>
> Votes are due by Thu, May 2, 2013 8:00pm UTC [2].
>
> Only current hsx Committers [3] are eligible to vote on this
> nomination.  Votes must be cast in the open by replying to to this
> mailing list.
>
> For Lazy Consensus voting instructions, see [4].
>
> John Coomes, hsx Project Lead
>
> [1] http://hg.openjdk.java.net/hsx/hotspot-gc/hotspot/log?rev=tao.mao
> [2] http://www.timeanddate.com/worldclock/fixedtime.html?msg=CFV%3A+New+hsx+Committer%3A+Tao+Mao&iso=20130502T20
> [3] http://openjdk.java.net/census/#hsx
> [4] http://openjdk.java.net/projects/#committer-vote
>

From vladimir.kozlov at oracle.com  Thu Apr 18 15:37:13 2013
From: vladimir.kozlov at oracle.com (Vladimir Kozlov)
Date: Thu, 18 Apr 2013 15:37:13 -0700
Subject: RFR(S) : 8012337 : Change Whitebox implementation to make absence
	of method in Whitebox.class not fatal
In-Reply-To: <51705F1E.6050602@oracle.com>
References: <516E7569.1060201@oracle.com> <516E85EC.6040203@oracle.com>
	<516EAA0F.2020807@oracle.com> <51705F1E.6050602@oracle.com>
Message-ID: <51707599.8050907@oracle.com>

Why not use WB technique (ClassFileInstaller) which compiles and copies 
class file into directory you want so you can avoid using shell?

Vladimir

On 4/18/13 2:01 PM, Igor Ignatyev wrote:
> could someone with "reviewer" status look at that?
>
> Best regards,
> Igor Ignatyev
>
> On 04/17/2013 05:56 PM, Igor Ignatyev wrote:
>> Mikael,
>> Thank you for review.
>>
>> I have updated webrev:
>> - added checking for exception class
>> - added print warning on unexpected error
>>
>> http://cr.openjdk.java.net/~iignatyev/8012337/webrev.01/
>>
>> Best regards,
>> Igor Ignatyev
>>
>> On 04/17/2013 03:22 PM, Mikael Gerdin wrote:
>>> Igor,
>>>
>>> On 2013-04-17 12:11, Igor Ignatyev wrote:
>>>> Hi all,
>>>>
>>>> Please review patch.
>>>>
>>>> Problem:
>>>> If there is some method that presences in native part of whitebox, but
>>>> absences in java side, we get 'j.l.NoSuchMethodError' exception
>>>
>>> The intended use of is of course that whitebox.cpp and WhiteBox.java are
>>> in sync since they are in the same hg repository.
>>>
>>> I understand that some feel that they need to copy WhiteBox to some
>>> other test suite and I find this change acceptable but unfortunate.
>>>
>>>>
>>>> Fix:
>>>> Batch registration of WB functions was replaced with one by one
>>>> registration
>>>>
>>>> Testing:
>>>> JPRT of sanity tests and tests that use WhiteBox: runtime/interned,
>>>> compiler/whitebox
>>>>
>>>> webrev: http://cr.openjdk.java.net/~iignatyev/8012337/webrev.00/
>>>
>>> It's too bad that you need a shell script here but I don't see any way
>>> around it.
>>>
>>> I'm ok with you pushing this.
>>>
>>> /Mikael
>>>
>>>> jbs: https://jbs.oracle.com/bugs/browse/JDK-8012337

From john.r.rose at oracle.com  Thu Apr 18 15:38:06 2013
From: john.r.rose at oracle.com (John Rose)
Date: Thu, 18 Apr 2013 15:38:06 -0700
Subject: CFV: New hsx Committer: Tao Mao
In-Reply-To: <20848.19457.854901.807286@oracle.com>
References: <20848.19457.854901.807286@oracle.com>
Message-ID: <36B6F8FB-8EA1-44BF-A157-2A28F517F6C3@oracle.com>

Vote: yes


From rasbold at google.com  Thu Apr 18 16:23:19 2013
From: rasbold at google.com (Chuck Rasbold)
Date: Thu, 18 Apr 2013 16:23:19 -0700
Subject: CFV: New hsx Committer: Tao Mao
In-Reply-To: <20848.19457.854901.807286@oracle.com>
References: <20848.19457.854901.807286@oracle.com>
Message-ID: 

Vote: yes


On Thu, Apr 18, 2013 at 12:39 PM, John Coomes wrote:

> I hereby nominate Tao Mao to hsx Committer.
>
> Tao joined the HotSpot garbage collection team at Oracle last year;
> over the last eight months he has contributed eight changesets which
> have improved or fixed bugs in several different GC components
> including ergonomics, G1 and serial gc [1].
>
> Votes are due by Thu, May 2, 2013 8:00pm UTC [2].
>
> Only current hsx Committers [3] are eligible to vote on this
> nomination.  Votes must be cast in the open by replying to to this
> mailing list.
>
> For Lazy Consensus voting instructions, see [4].
>
> John Coomes, hsx Project Lead
>
> [1] http://hg.openjdk.java.net/hsx/hotspot-gc/hotspot/log?rev=tao.mao
> [2]
> http://www.timeanddate.com/worldclock/fixedtime.html?msg=CFV%3A+New+hsx+Committer%3A+Tao+Mao&iso=20130502T20
> [3] http://openjdk.java.net/census/#hsx
> [4] http://openjdk.java.net/projects/#committer-vote
>

From alejandro.murillo at oracle.com  Thu Apr 18 17:24:43 2013
From: alejandro.murillo at oracle.com (alejandro.murillo at oracle.com)
Date: Fri, 19 Apr 2013 00:24:43 +0000
Subject: hg: hsx/hsx24/hotspot: 3 new changesets
Message-ID: <20130419002452.6C6914843A@hg.openjdk.java.net>

Changeset: 00144225e0dd
Author:    katleman
Date:      2013-04-17 12:13 -0700
URL:       http://hg.openjdk.java.net/hsx/hsx24/hotspot/rev/00144225e0dd

Added tag jdk7u14-b21 for changeset 3e88170d8be2

! .hgtags

Changeset: d90c913b8103
Author:    amurillo
Date:      2013-04-18 13:42 -0700
URL:       http://hg.openjdk.java.net/hsx/hsx24/hotspot/rev/d90c913b8103

Merge


Changeset: c11b058d4170
Author:    amurillo
Date:      2013-04-18 13:42 -0700
URL:       http://hg.openjdk.java.net/hsx/hsx24/hotspot/rev/c11b058d4170

Added tag hs24-b41 for changeset d90c913b8103

! .hgtags


From david.holmes at oracle.com  Thu Apr 18 19:19:28 2013
From: david.holmes at oracle.com (David Holmes)
Date: Fri, 19 Apr 2013 12:19:28 +1000
Subject: Review request: 6729929 I18N - Taking Heap Dump failed if project
	path contains multibyte characters
In-Reply-To: <516FFEB9.90509@oracle.com>
References: <515C55F4.6020002@oracle.com> <516FFEB9.90509@oracle.com>
Message-ID: <5170A9B0.5020805@oracle.com>

Hi Peter,

On 19/04/2013 12:10 AM, Peter Allwin wrote:
> Hi all, I'm still looking for reviews for this change...

Sounds like a perfectly reasonable change.

Reviewed.

Thanks,
David

> Thanks!
>
> /peter
>
> On 4/3/2013 6:16 PM, Peter Allwin wrote:
>> Webrev: http://cr.openjdk.java.net/~mgronlun/6729929/webrev01/
>> 
>> Bug: http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=6729929
>>
>> Summary: When dumpHeap in the HotSpotDiagnostic JMX MBean is called,
>> the filename parameter must be converted from jstring to char* to be
>> used in open(). This was done using UTF-8 encoding which is incorrect
>> as open() expects a platform dependent encoding according to the
>> system locale. Fix is to use
>> java_lang_String::as_platform_dependent_str to do the conversion.
>>
>> Thanks to Markus for advising and hosting the webrev!
>>
>> Regards,
>>
>> /peter
>

From john.coomes at oracle.com  Thu Apr 18 20:32:16 2013
From: john.coomes at oracle.com (john.coomes at oracle.com)
Date: Fri, 19 Apr 2013 03:32:16 +0000
Subject: hg: hsx/hotspot-main: 12 new changesets
Message-ID: <20130419033217.2951848442@hg.openjdk.java.net>

Changeset: fc1e08c2bb27
Author:    mduigou
Date:      2013-04-01 11:48 -0700
URL:       http://hg.openjdk.java.net/hsx/hotspot-main/rev/fc1e08c2bb27

8010267: Add test-clean for cleaning of testoutput directory from output directory. Add depedency on test-clean to clean
Reviewed-by: mchung, tbell

! common/makefiles/Main.gmk

Changeset: 26a4456cb19e
Author:    jgish
Date:      2013-03-26 13:41 -0400
URL:       http://hg.openjdk.java.net/hsx/hotspot-main/rev/26a4456cb19e

8009824: webrev.ksh generated jdk.patch files do not handle renames, copies, and shouldn't be applied
Summary: use hg export --git to produce proper patch file
Reviewed-by: mduigou

! make/scripts/webrev.ksh

Changeset: 760074bec012
Author:    mduigou
Date:      2013-04-01 21:11 -0700
URL:       http://hg.openjdk.java.net/hsx/hotspot-main/rev/760074bec012

8011178: improve common/bin/hgforest.sh python detection (MacOS)
Reviewed-by: ohair

! common/bin/hgforest.sh

Changeset: bcbdbcfe7ed8
Author:    lana
Date:      2013-04-02 11:55 -0700
URL:       http://hg.openjdk.java.net/hsx/hotspot-main/rev/bcbdbcfe7ed8

Merge


Changeset: 7320922b694e
Author:    mduigou
Date:      2013-04-02 14:56 -0700
URL:       http://hg.openjdk.java.net/hsx/hotspot-main/rev/7320922b694e

8011342: hgforest.sh : 'python --version' not supported on older python
Reviewed-by: wetmore

! common/bin/hgforest.sh

Changeset: 575f2ca947ab
Author:    mduigou
Date:      2013-04-03 16:26 -0700
URL:       http://hg.openjdk.java.net/hsx/hotspot-main/rev/575f2ca947ab

8011350: hgforest.sh uses non-POSIX sh features that may fail with some shells
Reviewed-by: tbell, katleman, dholmes

! common/bin/hgforest.sh

Changeset: 11c057460b91
Author:    lana
Date:      2013-04-05 14:49 -0700
URL:       http://hg.openjdk.java.net/hsx/hotspot-main/rev/11c057460b91

Merge


Changeset: 4c13b7994f38
Author:    lana
Date:      2013-04-16 08:10 -0700
URL:       http://hg.openjdk.java.net/hsx/hotspot-main/rev/4c13b7994f38

Merge

! common/makefiles/Main.gmk

Changeset: bee6ff988f9c
Author:    katleman
Date:      2013-04-12 15:21 -0700
URL:       http://hg.openjdk.java.net/hsx/hotspot-main/rev/bee6ff988f9c

8012048: JDK8 b85 source with GPL header errors
Reviewed-by: iris, mduigou, jjg

! common/autoconf/compare.sh.in
! common/bin/compare.sh

Changeset: 8c5b18d6f4fb
Author:    katleman
Date:      2013-04-15 14:19 -0700
URL:       http://hg.openjdk.java.net/hsx/hotspot-main/rev/8c5b18d6f4fb

Merge


Changeset: df9b5240f0a7
Author:    katleman
Date:      2013-04-16 14:57 -0700
URL:       http://hg.openjdk.java.net/hsx/hotspot-main/rev/df9b5240f0a7

Merge


Changeset: 6981694f7674
Author:    katleman
Date:      2013-04-18 10:30 -0700
URL:       http://hg.openjdk.java.net/hsx/hotspot-main/rev/6981694f7674

Added tag jdk8-b86 for changeset df9b5240f0a7

! .hgtags


From john.coomes at oracle.com  Thu Apr 18 20:32:20 2013
From: john.coomes at oracle.com (john.coomes at oracle.com)
Date: Fri, 19 Apr 2013 03:32:20 +0000
Subject: hg: hsx/hotspot-main/corba: Added tag jdk8-b86 for changeset
	44a8ce4a759f
Message-ID: <20130419033224.B962A48443@hg.openjdk.java.net>

Changeset: f1709874d55a
Author:    katleman
Date:      2013-04-18 10:30 -0700
URL:       http://hg.openjdk.java.net/hsx/hotspot-main/corba/rev/f1709874d55a

Added tag jdk8-b86 for changeset 44a8ce4a759f

! .hgtags


From john.coomes at oracle.com  Thu Apr 18 20:32:28 2013
From: john.coomes at oracle.com (john.coomes at oracle.com)
Date: Fri, 19 Apr 2013 03:32:28 +0000
Subject: hg: hsx/hotspot-main/jaxp: Added tag jdk8-b86 for changeset
	ca71ec37b2ef
Message-ID: <20130419033239.A0B4C48444@hg.openjdk.java.net>

Changeset: 9550aab82b5d
Author:    katleman
Date:      2013-04-18 10:30 -0700
URL:       http://hg.openjdk.java.net/hsx/hotspot-main/jaxp/rev/9550aab82b5d

Added tag jdk8-b86 for changeset ca71ec37b2ef

! .hgtags


From john.coomes at oracle.com  Thu Apr 18 20:33:01 2013
From: john.coomes at oracle.com (john.coomes at oracle.com)
Date: Fri, 19 Apr 2013 03:33:01 +0000
Subject: hg: hsx/hotspot-main/jaxws: 3 new changesets
Message-ID: <20130419033310.3FA3F48445@hg.openjdk.java.net>

Changeset: 0989ad8c0860
Author:    alanb
Date:      2013-04-09 14:51 +0100
URL:       http://hg.openjdk.java.net/hsx/hotspot-main/jaxws/rev/0989ad8c0860

8010393: Update JAX-WS RI to 2.2.9-b12941
Reviewed-by: alanb, erikj
Contributed-by: miroslav.kos at oracle.com, martin.grebac at oracle.com

! makefiles/BuildJaxws.gmk
+ src/share/jaxws_classes/com/oracle/webservices/internal/api/EnvelopeStyle.java
+ src/share/jaxws_classes/com/oracle/webservices/internal/api/EnvelopeStyleFeature.java
+ src/share/jaxws_classes/com/oracle/webservices/internal/api/databinding/Databinding.java
+ src/share/jaxws_classes/com/oracle/webservices/internal/api/databinding/DatabindingFactory.java
+ src/share/jaxws_classes/com/oracle/webservices/internal/api/databinding/DatabindingMode.java
+ src/share/jaxws_classes/com/oracle/webservices/internal/api/databinding/DatabindingModeFeature.java
+ src/share/jaxws_classes/com/oracle/webservices/internal/api/databinding/ExternalMetadataFeature.java
+ src/share/jaxws_classes/com/oracle/webservices/internal/api/databinding/JavaCallInfo.java
+ src/share/jaxws_classes/com/oracle/webservices/internal/api/databinding/WSDLGenerator.java
+ src/share/jaxws_classes/com/oracle/webservices/internal/api/databinding/WSDLResolver.java
+ src/share/jaxws_classes/com/oracle/webservices/internal/api/message/BaseDistributedPropertySet.java
+ src/share/jaxws_classes/com/oracle/webservices/internal/api/message/BasePropertySet.java
+ src/share/jaxws_classes/com/oracle/webservices/internal/api/message/ContentType.java
+ src/share/jaxws_classes/com/oracle/webservices/internal/api/message/DistributedPropertySet.java
+ src/share/jaxws_classes/com/oracle/webservices/internal/api/message/MessageContext.java
+ src/share/jaxws_classes/com/oracle/webservices/internal/api/message/MessageContextFactory.java
+ src/share/jaxws_classes/com/oracle/webservices/internal/api/message/PropertySet.java
+ src/share/jaxws_classes/com/oracle/webservices/internal/api/message/ReadOnlyPropertyException.java
+ src/share/jaxws_classes/com/oracle/webservices/internal/impl/encoding/StreamDecoderImpl.java
+ src/share/jaxws_classes/com/oracle/webservices/internal/impl/internalspi/encoding/StreamDecoder.java
+ src/share/jaxws_classes/com/oracle/xmlns/internal/webservices/jaxws_databinding/ExistingAnnotationsType.java
+ src/share/jaxws_classes/com/oracle/xmlns/internal/webservices/jaxws_databinding/JavaMethod.java
+ src/share/jaxws_classes/com/oracle/xmlns/internal/webservices/jaxws_databinding/JavaParam.java
+ src/share/jaxws_classes/com/oracle/xmlns/internal/webservices/jaxws_databinding/JavaWsdlMappingType.java
+ src/share/jaxws_classes/com/oracle/xmlns/internal/webservices/jaxws_databinding/ObjectFactory.java
+ src/share/jaxws_classes/com/oracle/xmlns/internal/webservices/jaxws_databinding/SoapBindingParameterStyle.java
+ src/share/jaxws_classes/com/oracle/xmlns/internal/webservices/jaxws_databinding/SoapBindingStyle.java
+ src/share/jaxws_classes/com/oracle/xmlns/internal/webservices/jaxws_databinding/SoapBindingUse.java
+ src/share/jaxws_classes/com/oracle/xmlns/internal/webservices/jaxws_databinding/Util.java
+ src/share/jaxws_classes/com/oracle/xmlns/internal/webservices/jaxws_databinding/WebParamMode.java
+ src/share/jaxws_classes/com/oracle/xmlns/internal/webservices/jaxws_databinding/XmlAction.java
+ src/share/jaxws_classes/com/oracle/xmlns/internal/webservices/jaxws_databinding/XmlAddressing.java
+ src/share/jaxws_classes/com/oracle/xmlns/internal/webservices/jaxws_databinding/XmlBindingType.java
+ src/share/jaxws_classes/com/oracle/xmlns/internal/webservices/jaxws_databinding/XmlFaultAction.java
+ src/share/jaxws_classes/com/oracle/xmlns/internal/webservices/jaxws_databinding/XmlHandlerChain.java
+ src/share/jaxws_classes/com/oracle/xmlns/internal/webservices/jaxws_databinding/XmlMTOM.java
+ src/share/jaxws_classes/com/oracle/xmlns/internal/webservices/jaxws_databinding/XmlOneway.java
+ src/share/jaxws_classes/com/oracle/xmlns/internal/webservices/jaxws_databinding/XmlRequestWrapper.java
+ src/share/jaxws_classes/com/oracle/xmlns/internal/webservices/jaxws_databinding/XmlResponseWrapper.java
+ src/share/jaxws_classes/com/oracle/xmlns/internal/webservices/jaxws_databinding/XmlSOAPBinding.java
+ src/share/jaxws_classes/com/oracle/xmlns/internal/webservices/jaxws_databinding/XmlServiceMode.java
+ src/share/jaxws_classes/com/oracle/xmlns/internal/webservices/jaxws_databinding/XmlWebEndpoint.java
+ src/share/jaxws_classes/com/oracle/xmlns/internal/webservices/jaxws_databinding/XmlWebFault.java
+ src/share/jaxws_classes/com/oracle/xmlns/internal/webservices/jaxws_databinding/XmlWebMethod.java
+ src/share/jaxws_classes/com/oracle/xmlns/internal/webservices/jaxws_databinding/XmlWebParam.java
+ src/share/jaxws_classes/com/oracle/xmlns/internal/webservices/jaxws_databinding/XmlWebResult.java
+ src/share/jaxws_classes/com/oracle/xmlns/internal/webservices/jaxws_databinding/XmlWebService.java
+ src/share/jaxws_classes/com/oracle/xmlns/internal/webservices/jaxws_databinding/XmlWebServiceClient.java
+ src/share/jaxws_classes/com/oracle/xmlns/internal/webservices/jaxws_databinding/XmlWebServiceProvider.java
+ src/share/jaxws_classes/com/oracle/xmlns/internal/webservices/jaxws_databinding/XmlWebServiceRef.java
+ src/share/jaxws_classes/com/oracle/xmlns/internal/webservices/jaxws_databinding/package-info.java
! src/share/jaxws_classes/com/sun/istack/internal/Builder.java
! src/share/jaxws_classes/com/sun/istack/internal/ByteArrayDataSource.java
! src/share/jaxws_classes/com/sun/istack/internal/FinalArrayList.java
! src/share/jaxws_classes/com/sun/istack/internal/FragmentContentHandler.java
! src/share/jaxws_classes/com/sun/istack/internal/Interned.java
! src/share/jaxws_classes/com/sun/istack/internal/NotNull.java
! src/share/jaxws_classes/com/sun/istack/internal/Nullable.java
! src/share/jaxws_classes/com/sun/istack/internal/Pool.java
! src/share/jaxws_classes/com/sun/istack/internal/SAXException2.java
! src/share/jaxws_classes/com/sun/istack/internal/SAXParseException2.java
! src/share/jaxws_classes/com/sun/istack/internal/XMLStreamException2.java
! src/share/jaxws_classes/com/sun/istack/internal/XMLStreamReaderToContentHandler.java
! src/share/jaxws_classes/com/sun/istack/internal/localization/Localizable.java
! src/share/jaxws_classes/com/sun/istack/internal/localization/LocalizableMessage.java
! src/share/jaxws_classes/com/sun/istack/internal/localization/LocalizableMessageFactory.java
! src/share/jaxws_classes/com/sun/istack/internal/localization/Localizer.java
+ src/share/jaxws_classes/com/sun/istack/internal/localization/NullLocalizable.java
! src/share/jaxws_classes/com/sun/istack/internal/logging/Logger.java
! src/share/jaxws_classes/com/sun/istack/internal/package-info.java
+ src/share/jaxws_classes/com/sun/istack/internal/tools/DefaultAuthenticator.java
! src/share/jaxws_classes/com/sun/istack/internal/tools/MaskingClassLoader.java
! src/share/jaxws_classes/com/sun/istack/internal/tools/ParallelWorldClassLoader.java
! src/share/jaxws_classes/com/sun/istack/internal/tools/SecureLoader.java
! src/share/jaxws_classes/com/sun/istack/internal/tools/package-info.java
! src/share/jaxws_classes/com/sun/org/glassfish/external/amx/AMX.java
! src/share/jaxws_classes/com/sun/org/glassfish/external/amx/AMXGlassfish.java
! src/share/jaxws_classes/com/sun/org/glassfish/external/amx/AMXUtil.java
! src/share/jaxws_classes/com/sun/org/glassfish/external/amx/BootAMXMBean.java
! src/share/jaxws_classes/com/sun/org/glassfish/external/amx/MBeanListener.java
! src/share/jaxws_classes/com/sun/org/glassfish/external/arc/Stability.java
! src/share/jaxws_classes/com/sun/org/glassfish/external/arc/Taxonomy.java
! src/share/jaxws_classes/com/sun/org/glassfish/external/probe/provider/PluginPoint.java
! src/share/jaxws_classes/com/sun/org/glassfish/external/probe/provider/StatsProvider.java
! src/share/jaxws_classes/com/sun/org/glassfish/external/probe/provider/StatsProviderInfo.java
! src/share/jaxws_classes/com/sun/org/glassfish/external/probe/provider/StatsProviderManager.java
! src/share/jaxws_classes/com/sun/org/glassfish/external/probe/provider/StatsProviderManagerDelegate.java
! src/share/jaxws_classes/com/sun/org/glassfish/external/probe/provider/annotations/Probe.java
! src/share/jaxws_classes/com/sun/org/glassfish/external/probe/provider/annotations/ProbeListener.java
! src/share/jaxws_classes/com/sun/org/glassfish/external/probe/provider/annotations/ProbeParam.java
! src/share/jaxws_classes/com/sun/org/glassfish/external/probe/provider/annotations/ProbeProvider.java
! src/share/jaxws_classes/com/sun/org/glassfish/external/statistics/AverageRangeStatistic.java
! src/share/jaxws_classes/com/sun/org/glassfish/external/statistics/BoundaryStatistic.java
! src/share/jaxws_classes/com/sun/org/glassfish/external/statistics/BoundedRangeStatistic.java
! src/share/jaxws_classes/com/sun/org/glassfish/external/statistics/CountStatistic.java
! src/share/jaxws_classes/com/sun/org/glassfish/external/statistics/RangeStatistic.java
! src/share/jaxws_classes/com/sun/org/glassfish/external/statistics/Statistic.java
! src/share/jaxws_classes/com/sun/org/glassfish/external/statistics/Stats.java
! src/share/jaxws_classes/com/sun/org/glassfish/external/statistics/StringStatistic.java
! src/share/jaxws_classes/com/sun/org/glassfish/external/statistics/TimeStatistic.java
! src/share/jaxws_classes/com/sun/org/glassfish/external/statistics/annotations/Reset.java
! src/share/jaxws_classes/com/sun/org/glassfish/external/statistics/impl/AverageRangeStatisticImpl.java
! src/share/jaxws_classes/com/sun/org/glassfish/external/statistics/impl/BoundaryStatisticImpl.java
! src/share/jaxws_classes/com/sun/org/glassfish/external/statistics/impl/BoundedRangeStatisticImpl.java
! src/share/jaxws_classes/com/sun/org/glassfish/external/statistics/impl/CountStatisticImpl.java
! src/share/jaxws_classes/com/sun/org/glassfish/external/statistics/impl/RangeStatisticImpl.java
! src/share/jaxws_classes/com/sun/org/glassfish/external/statistics/impl/StatisticImpl.java
! src/share/jaxws_classes/com/sun/org/glassfish/external/statistics/impl/StatsImpl.java
! src/share/jaxws_classes/com/sun/org/glassfish/external/statistics/impl/StringStatisticImpl.java
! src/share/jaxws_classes/com/sun/org/glassfish/external/statistics/impl/TimeStatisticImpl.java
! src/share/jaxws_classes/com/sun/tools/etc/META-INF/services/com.sun.tools.internal.xjc.Plugin
! src/share/jaxws_classes/com/sun/tools/internal/jxc/ConfigReader.java
! src/share/jaxws_classes/com/sun/tools/internal/jxc/MessageBundle.properties
+ src/share/jaxws_classes/com/sun/tools/internal/jxc/MessageBundle_de.properties
+ src/share/jaxws_classes/com/sun/tools/internal/jxc/MessageBundle_es.properties
+ src/share/jaxws_classes/com/sun/tools/internal/jxc/MessageBundle_fr.properties
+ src/share/jaxws_classes/com/sun/tools/internal/jxc/MessageBundle_it.properties
+ src/share/jaxws_classes/com/sun/tools/internal/jxc/MessageBundle_ja.properties
+ src/share/jaxws_classes/com/sun/tools/internal/jxc/MessageBundle_ko.properties
+ src/share/jaxws_classes/com/sun/tools/internal/jxc/MessageBundle_pt_BR.properties
+ src/share/jaxws_classes/com/sun/tools/internal/jxc/MessageBundle_zh_CN.properties
+ src/share/jaxws_classes/com/sun/tools/internal/jxc/MessageBundle_zh_TW.properties
! src/share/jaxws_classes/com/sun/tools/internal/jxc/NGCCRuntimeEx.java
! src/share/jaxws_classes/com/sun/tools/internal/jxc/SchemaGenerator.java
! src/share/jaxws_classes/com/sun/tools/internal/jxc/SchemaGeneratorFacade.java
! src/share/jaxws_classes/com/sun/tools/internal/jxc/SecureLoader.java
! src/share/jaxws_classes/com/sun/tools/internal/jxc/ap/AnnotationParser.java
+ src/share/jaxws_classes/com/sun/tools/internal/jxc/ap/MessageBundle_de.properties
+ src/share/jaxws_classes/com/sun/tools/internal/jxc/ap/MessageBundle_es.properties
+ src/share/jaxws_classes/com/sun/tools/internal/jxc/ap/MessageBundle_fr.properties
+ src/share/jaxws_classes/com/sun/tools/internal/jxc/ap/MessageBundle_it.properties
+ src/share/jaxws_classes/com/sun/tools/internal/jxc/ap/MessageBundle_ja.properties
+ src/share/jaxws_classes/com/sun/tools/internal/jxc/ap/MessageBundle_ko.properties
+ src/share/jaxws_classes/com/sun/tools/internal/jxc/ap/MessageBundle_pt_BR.properties
+ src/share/jaxws_classes/com/sun/tools/internal/jxc/ap/MessageBundle_zh_CN.properties
+ src/share/jaxws_classes/com/sun/tools/internal/jxc/ap/MessageBundle_zh_TW.properties
! src/share/jaxws_classes/com/sun/tools/internal/jxc/ap/Options.java
! src/share/jaxws_classes/com/sun/tools/internal/jxc/ap/SchemaGenerator.java
! src/share/jaxws_classes/com/sun/tools/internal/jxc/ap/SecureLoader.java
+ src/share/jaxws_classes/com/sun/tools/internal/jxc/api/JXC.java
+ src/share/jaxws_classes/com/sun/tools/internal/jxc/api/impl/j2s/JAXBModelImpl.java
+ src/share/jaxws_classes/com/sun/tools/internal/jxc/api/impl/j2s/JavaCompilerImpl.java
! src/share/jaxws_classes/com/sun/tools/internal/jxc/gen/config/AttributesImpl.java
! src/share/jaxws_classes/com/sun/tools/internal/jxc/gen/config/Classes.java
! src/share/jaxws_classes/com/sun/tools/internal/jxc/gen/config/Config.java
! src/share/jaxws_classes/com/sun/tools/internal/jxc/gen/config/NGCCEventReceiver.java
! src/share/jaxws_classes/com/sun/tools/internal/jxc/gen/config/NGCCEventSource.java
! src/share/jaxws_classes/com/sun/tools/internal/jxc/gen/config/NGCCHandler.java
! src/share/jaxws_classes/com/sun/tools/internal/jxc/gen/config/NGCCInterleaveFilter.java
! src/share/jaxws_classes/com/sun/tools/internal/jxc/gen/config/NGCCRuntime.java
! src/share/jaxws_classes/com/sun/tools/internal/jxc/gen/config/Schema.java
! src/share/jaxws_classes/com/sun/tools/internal/jxc/model/nav/ApNavigator.java
! src/share/jaxws_classes/com/sun/tools/internal/ws/Invoker.java
! src/share/jaxws_classes/com/sun/tools/internal/ws/ToolVersion.java
! src/share/jaxws_classes/com/sun/tools/internal/ws/WsGen.java
! src/share/jaxws_classes/com/sun/tools/internal/ws/WsImport.java
! src/share/jaxws_classes/com/sun/tools/internal/ws/api/TJavaGeneratorExtension.java
! src/share/jaxws_classes/com/sun/tools/internal/ws/api/WsgenExtension.java
! src/share/jaxws_classes/com/sun/tools/internal/ws/api/WsgenProtocol.java
! src/share/jaxws_classes/com/sun/tools/internal/ws/api/wsdl/TWSDLExtensible.java
! src/share/jaxws_classes/com/sun/tools/internal/ws/api/wsdl/TWSDLExtension.java
! src/share/jaxws_classes/com/sun/tools/internal/ws/api/wsdl/TWSDLExtensionHandler.java
! src/share/jaxws_classes/com/sun/tools/internal/ws/api/wsdl/TWSDLOperation.java
! src/share/jaxws_classes/com/sun/tools/internal/ws/api/wsdl/TWSDLParserContext.java
! src/share/jaxws_classes/com/sun/tools/internal/ws/package-info.java
! src/share/jaxws_classes/com/sun/tools/internal/ws/processor/ProcessorException.java
! src/share/jaxws_classes/com/sun/tools/internal/ws/processor/generator/CustomExceptionGenerator.java
! src/share/jaxws_classes/com/sun/tools/internal/ws/processor/generator/GeneratorBase.java
! src/share/jaxws_classes/com/sun/tools/internal/ws/processor/generator/GeneratorConstants.java
! src/share/jaxws_classes/com/sun/tools/internal/ws/processor/generator/GeneratorException.java
! src/share/jaxws_classes/com/sun/tools/internal/ws/processor/generator/GeneratorExtension.java
! src/share/jaxws_classes/com/sun/tools/internal/ws/processor/generator/GeneratorUtil.java
! src/share/jaxws_classes/com/sun/tools/internal/ws/processor/generator/JavaGeneratorExtensionFacade.java
! src/share/jaxws_classes/com/sun/tools/internal/ws/processor/generator/JwsImplGenerator.java
! src/share/jaxws_classes/com/sun/tools/internal/ws/processor/generator/Names.java
! src/share/jaxws_classes/com/sun/tools/internal/ws/processor/generator/SeiGenerator.java
! src/share/jaxws_classes/com/sun/tools/internal/ws/processor/generator/ServiceGenerator.java
! src/share/jaxws_classes/com/sun/tools/internal/ws/processor/generator/W3CAddressingJavaGeneratorExtension.java
! src/share/jaxws_classes/com/sun/tools/internal/ws/processor/model/AbstractType.java
! src/share/jaxws_classes/com/sun/tools/internal/ws/processor/model/AsyncOperation.java
! src/share/jaxws_classes/com/sun/tools/internal/ws/processor/model/AsyncOperationType.java
! src/share/jaxws_classes/com/sun/tools/internal/ws/processor/model/Block.java
! src/share/jaxws_classes/com/sun/tools/internal/ws/processor/model/ExtendedModelVisitor.java
! src/share/jaxws_classes/com/sun/tools/internal/ws/processor/model/Fault.java
! src/share/jaxws_classes/com/sun/tools/internal/ws/processor/model/HeaderFault.java
! src/share/jaxws_classes/com/sun/tools/internal/ws/processor/model/Message.java
! src/share/jaxws_classes/com/sun/tools/internal/ws/processor/model/Model.java
! src/share/jaxws_classes/com/sun/tools/internal/ws/processor/model/ModelException.java
! src/share/jaxws_classes/com/sun/tools/internal/ws/processor/model/ModelObject.java
! src/share/jaxws_classes/com/sun/tools/internal/ws/processor/model/ModelProperties.java
! src/share/jaxws_classes/com/sun/tools/internal/ws/processor/model/ModelVisitor.java
! src/share/jaxws_classes/com/sun/tools/internal/ws/processor/model/Operation.java
! src/share/jaxws_classes/com/sun/tools/internal/ws/processor/model/Parameter.java
! src/share/jaxws_classes/com/sun/tools/internal/ws/processor/model/Port.java
! src/share/jaxws_classes/com/sun/tools/internal/ws/processor/model/Request.java
! src/share/jaxws_classes/com/sun/tools/internal/ws/processor/model/Response.java
! src/share/jaxws_classes/com/sun/tools/internal/ws/processor/model/Service.java
! src/share/jaxws_classes/com/sun/tools/internal/ws/processor/model/exporter/ExternalObject.java
! src/share/jaxws_classes/com/sun/tools/internal/ws/processor/model/java/JavaArrayType.java
! src/share/jaxws_classes/com/sun/tools/internal/ws/processor/model/java/JavaException.java
! src/share/jaxws_classes/com/sun/tools/internal/ws/processor/model/java/JavaInterface.java
! src/share/jaxws_classes/com/sun/tools/internal/ws/processor/model/java/JavaMethod.java
! src/share/jaxws_classes/com/sun/tools/internal/ws/processor/model/java/JavaParameter.java
! src/share/jaxws_classes/com/sun/tools/internal/ws/processor/model/java/JavaSimpleType.java
! src/share/jaxws_classes/com/sun/tools/internal/ws/processor/model/java/JavaStructureMember.java
! src/share/jaxws_classes/com/sun/tools/internal/ws/processor/model/java/JavaStructureType.java
! src/share/jaxws_classes/com/sun/tools/internal/ws/processor/model/java/JavaType.java
! src/share/jaxws_classes/com/sun/tools/internal/ws/processor/model/jaxb/JAXBElementMember.java
! src/share/jaxws_classes/com/sun/tools/internal/ws/processor/model/jaxb/JAXBMapping.java
! src/share/jaxws_classes/com/sun/tools/internal/ws/processor/model/jaxb/JAXBModel.java
! src/share/jaxws_classes/com/sun/tools/internal/ws/processor/model/jaxb/JAXBProperty.java
! src/share/jaxws_classes/com/sun/tools/internal/ws/processor/model/jaxb/JAXBStructuredType.java
! src/share/jaxws_classes/com/sun/tools/internal/ws/processor/model/jaxb/JAXBType.java
! src/share/jaxws_classes/com/sun/tools/internal/ws/processor/model/jaxb/JAXBTypeAndAnnotation.java
! src/share/jaxws_classes/com/sun/tools/internal/ws/processor/model/jaxb/JAXBTypeVisitor.java
! src/share/jaxws_classes/com/sun/tools/internal/ws/processor/model/jaxb/RpcLitMember.java
! src/share/jaxws_classes/com/sun/tools/internal/ws/processor/model/jaxb/RpcLitStructure.java
! src/share/jaxws_classes/com/sun/tools/internal/ws/processor/model/jaxb/Util.java
! src/share/jaxws_classes/com/sun/tools/internal/ws/processor/modeler/JavaSimpleTypeCreator.java
! src/share/jaxws_classes/com/sun/tools/internal/ws/processor/modeler/Modeler.java
! src/share/jaxws_classes/com/sun/tools/internal/ws/processor/modeler/ModelerConstants.java
! src/share/jaxws_classes/com/sun/tools/internal/ws/processor/modeler/ModelerException.java
! src/share/jaxws_classes/com/sun/tools/internal/ws/processor/modeler/annotation/AnnotationProcessorContext.java
! src/share/jaxws_classes/com/sun/tools/internal/ws/processor/modeler/annotation/FaultInfo.java
! src/share/jaxws_classes/com/sun/tools/internal/ws/processor/modeler/annotation/MakeSafeTypeVisitor.java
! src/share/jaxws_classes/com/sun/tools/internal/ws/processor/modeler/annotation/MemberInfo.java
! src/share/jaxws_classes/com/sun/tools/internal/ws/processor/modeler/annotation/ModelBuilder.java
! src/share/jaxws_classes/com/sun/tools/internal/ws/processor/modeler/annotation/TypeModeler.java
! src/share/jaxws_classes/com/sun/tools/internal/ws/processor/modeler/annotation/TypeMoniker.java
! src/share/jaxws_classes/com/sun/tools/internal/ws/processor/modeler/annotation/TypeMonikerFactory.java
! src/share/jaxws_classes/com/sun/tools/internal/ws/processor/modeler/annotation/WebServiceAp.java
! src/share/jaxws_classes/com/sun/tools/internal/ws/processor/modeler/annotation/WebServiceConstants.java
! src/share/jaxws_classes/com/sun/tools/internal/ws/processor/modeler/annotation/WebServiceVisitor.java
! src/share/jaxws_classes/com/sun/tools/internal/ws/processor/modeler/annotation/WebServiceWrapperGenerator.java
! src/share/jaxws_classes/com/sun/tools/internal/ws/processor/modeler/annotation/WrapperInfo.java
! src/share/jaxws_classes/com/sun/tools/internal/ws/processor/modeler/wsdl/AccessorElement.java
! src/share/jaxws_classes/com/sun/tools/internal/ws/processor/modeler/wsdl/ClassNameAllocatorImpl.java
! src/share/jaxws_classes/com/sun/tools/internal/ws/processor/modeler/wsdl/ConsoleErrorReporter.java
! src/share/jaxws_classes/com/sun/tools/internal/ws/processor/modeler/wsdl/JAXBModelBuilder.java
! src/share/jaxws_classes/com/sun/tools/internal/ws/processor/modeler/wsdl/ModelerUtils.java
! src/share/jaxws_classes/com/sun/tools/internal/ws/processor/modeler/wsdl/PseudoSchemaBuilder.java
! src/share/jaxws_classes/com/sun/tools/internal/ws/processor/modeler/wsdl/WSDLModeler.java
! src/share/jaxws_classes/com/sun/tools/internal/ws/processor/modeler/wsdl/WSDLModelerBase.java
! src/share/jaxws_classes/com/sun/tools/internal/ws/processor/util/ClassNameCollector.java
! src/share/jaxws_classes/com/sun/tools/internal/ws/processor/util/DirectoryUtil.java
! src/share/jaxws_classes/com/sun/tools/internal/ws/processor/util/IndentingWriter.java
! src/share/jaxws_classes/com/sun/tools/internal/ws/resources/ConfigurationMessages.java
! src/share/jaxws_classes/com/sun/tools/internal/ws/resources/GeneratorMessages.java
! src/share/jaxws_classes/com/sun/tools/internal/ws/resources/JavacompilerMessages.java
! src/share/jaxws_classes/com/sun/tools/internal/ws/resources/ModelMessages.java
! src/share/jaxws_classes/com/sun/tools/internal/ws/resources/ModelerMessages.java
! src/share/jaxws_classes/com/sun/tools/internal/ws/resources/ProcessorMessages.java
! src/share/jaxws_classes/com/sun/tools/internal/ws/resources/UtilMessages.java
! src/share/jaxws_classes/com/sun/tools/internal/ws/resources/WebserviceapMessages.java
! src/share/jaxws_classes/com/sun/tools/internal/ws/resources/WscompileMessages.java
! src/share/jaxws_classes/com/sun/tools/internal/ws/resources/WsdlMessages.java
! src/share/jaxws_classes/com/sun/tools/internal/ws/resources/configuration.properties
+ src/share/jaxws_classes/com/sun/tools/internal/ws/resources/configuration_de.properties
+ src/share/jaxws_classes/com/sun/tools/internal/ws/resources/configuration_es.properties
+ src/share/jaxws_classes/com/sun/tools/internal/ws/resources/configuration_fr.properties
+ src/share/jaxws_classes/com/sun/tools/internal/ws/resources/configuration_it.properties
+ src/share/jaxws_classes/com/sun/tools/internal/ws/resources/configuration_ja.properties
+ src/share/jaxws_classes/com/sun/tools/internal/ws/resources/configuration_ko.properties
+ src/share/jaxws_classes/com/sun/tools/internal/ws/resources/configuration_pt_BR.properties
+ src/share/jaxws_classes/com/sun/tools/internal/ws/resources/configuration_zh_CN.properties
+ src/share/jaxws_classes/com/sun/tools/internal/ws/resources/configuration_zh_TW.properties
! src/share/jaxws_classes/com/sun/tools/internal/ws/resources/generator.properties
+ src/share/jaxws_classes/com/sun/tools/internal/ws/resources/generator_de.properties
+ src/share/jaxws_classes/com/sun/tools/internal/ws/resources/generator_es.properties
+ src/share/jaxws_classes/com/sun/tools/internal/ws/resources/generator_fr.properties
+ src/share/jaxws_classes/com/sun/tools/internal/ws/resources/generator_it.properties
+ src/share/jaxws_classes/com/sun/tools/internal/ws/resources/generator_ja.properties
+ src/share/jaxws_classes/com/sun/tools/internal/ws/resources/generator_ko.properties
+ src/share/jaxws_classes/com/sun/tools/internal/ws/resources/generator_pt_BR.properties
+ src/share/jaxws_classes/com/sun/tools/internal/ws/resources/generator_zh_CN.properties
+ src/share/jaxws_classes/com/sun/tools/internal/ws/resources/generator_zh_TW.properties
! src/share/jaxws_classes/com/sun/tools/internal/ws/resources/javacompiler.properties
+ src/share/jaxws_classes/com/sun/tools/internal/ws/resources/javacompiler_de.properties
+ src/share/jaxws_classes/com/sun/tools/internal/ws/resources/javacompiler_es.properties
+ src/share/jaxws_classes/com/sun/tools/internal/ws/resources/javacompiler_fr.properties
+ src/share/jaxws_classes/com/sun/tools/internal/ws/resources/javacompiler_it.properties
+ src/share/jaxws_classes/com/sun/tools/internal/ws/resources/javacompiler_ja.properties
+ src/share/jaxws_classes/com/sun/tools/internal/ws/resources/javacompiler_ko.properties
+ src/share/jaxws_classes/com/sun/tools/internal/ws/resources/javacompiler_pt_BR.properties
+ src/share/jaxws_classes/com/sun/tools/internal/ws/resources/javacompiler_zh_CN.properties
+ src/share/jaxws_classes/com/sun/tools/internal/ws/resources/javacompiler_zh_TW.properties
! src/share/jaxws_classes/com/sun/tools/internal/ws/resources/model.properties
+ src/share/jaxws_classes/com/sun/tools/internal/ws/resources/model_de.properties
+ src/share/jaxws_classes/com/sun/tools/internal/ws/resources/model_es.properties
+ src/share/jaxws_classes/com/sun/tools/internal/ws/resources/model_fr.properties
+ src/share/jaxws_classes/com/sun/tools/internal/ws/resources/model_it.properties
+ src/share/jaxws_classes/com/sun/tools/internal/ws/resources/model_ja.properties
+ src/share/jaxws_classes/com/sun/tools/internal/ws/resources/model_ko.properties
+ src/share/jaxws_classes/com/sun/tools/internal/ws/resources/model_pt_BR.properties
+ src/share/jaxws_classes/com/sun/tools/internal/ws/resources/model_zh_CN.properties
+ src/share/jaxws_classes/com/sun/tools/internal/ws/resources/model_zh_TW.properties
! src/share/jaxws_classes/com/sun/tools/internal/ws/resources/modeler.properties
+ src/share/jaxws_classes/com/sun/tools/internal/ws/resources/modeler_de.properties
+ src/share/jaxws_classes/com/sun/tools/internal/ws/resources/modeler_es.properties
+ src/share/jaxws_classes/com/sun/tools/internal/ws/resources/modeler_fr.properties
+ src/share/jaxws_classes/com/sun/tools/internal/ws/resources/modeler_it.properties
+ src/share/jaxws_classes/com/sun/tools/internal/ws/resources/modeler_ja.properties
+ src/share/jaxws_classes/com/sun/tools/internal/ws/resources/modeler_ko.properties
+ src/share/jaxws_classes/com/sun/tools/internal/ws/resources/modeler_pt_BR.properties
+ src/share/jaxws_classes/com/sun/tools/internal/ws/resources/modeler_zh_CN.properties
+ src/share/jaxws_classes/com/sun/tools/internal/ws/resources/modeler_zh_TW.properties
! src/share/jaxws_classes/com/sun/tools/internal/ws/resources/processor.properties
+ src/share/jaxws_classes/com/sun/tools/internal/ws/resources/processor_de.properties
+ src/share/jaxws_classes/com/sun/tools/internal/ws/resources/processor_es.properties
+ src/share/jaxws_classes/com/sun/tools/internal/ws/resources/processor_fr.properties
+ src/share/jaxws_classes/com/sun/tools/internal/ws/resources/processor_it.properties
+ src/share/jaxws_classes/com/sun/tools/internal/ws/resources/processor_ja.properties
+ src/share/jaxws_classes/com/sun/tools/internal/ws/resources/processor_ko.properties
+ src/share/jaxws_classes/com/sun/tools/internal/ws/resources/processor_pt_BR.properties
+ src/share/jaxws_classes/com/sun/tools/internal/ws/resources/processor_zh_CN.properties
+ src/share/jaxws_classes/com/sun/tools/internal/ws/resources/processor_zh_TW.properties
! src/share/jaxws_classes/com/sun/tools/internal/ws/resources/util.properties
+ src/share/jaxws_classes/com/sun/tools/internal/ws/resources/util_de.properties
+ src/share/jaxws_classes/com/sun/tools/internal/ws/resources/util_es.properties
+ src/share/jaxws_classes/com/sun/tools/internal/ws/resources/util_fr.properties
+ src/share/jaxws_classes/com/sun/tools/internal/ws/resources/util_it.properties
+ src/share/jaxws_classes/com/sun/tools/internal/ws/resources/util_ja.properties
+ src/share/jaxws_classes/com/sun/tools/internal/ws/resources/util_ko.properties
+ src/share/jaxws_classes/com/sun/tools/internal/ws/resources/util_pt_BR.properties
+ src/share/jaxws_classes/com/sun/tools/internal/ws/resources/util_zh_CN.properties
+ src/share/jaxws_classes/com/sun/tools/internal/ws/resources/util_zh_TW.properties
! src/share/jaxws_classes/com/sun/tools/internal/ws/resources/webserviceap.properties
+ src/share/jaxws_classes/com/sun/tools/internal/ws/resources/webserviceap_de.properties
+ src/share/jaxws_classes/com/sun/tools/internal/ws/resources/webserviceap_es.properties
+ src/share/jaxws_classes/com/sun/tools/internal/ws/resources/webserviceap_fr.properties
+ src/share/jaxws_classes/com/sun/tools/internal/ws/resources/webserviceap_it.properties
+ src/share/jaxws_classes/com/sun/tools/internal/ws/resources/webserviceap_ja.properties
+ src/share/jaxws_classes/com/sun/tools/internal/ws/resources/webserviceap_ko.properties
+ src/share/jaxws_classes/com/sun/tools/internal/ws/resources/webserviceap_pt_BR.properties
+ src/share/jaxws_classes/com/sun/tools/internal/ws/resources/webserviceap_zh_CN.properties
+ src/share/jaxws_classes/com/sun/tools/internal/ws/resources/webserviceap_zh_TW.properties
! src/share/jaxws_classes/com/sun/tools/internal/ws/resources/wscompile.properties
+ src/share/jaxws_classes/com/sun/tools/internal/ws/resources/wscompile_de.properties
+ src/share/jaxws_classes/com/sun/tools/internal/ws/resources/wscompile_es.properties
+ src/share/jaxws_classes/com/sun/tools/internal/ws/resources/wscompile_fr.properties
+ src/share/jaxws_classes/com/sun/tools/internal/ws/resources/wscompile_it.properties
+ src/share/jaxws_classes/com/sun/tools/internal/ws/resources/wscompile_ja.properties
+ src/share/jaxws_classes/com/sun/tools/internal/ws/resources/wscompile_ko.properties
+ src/share/jaxws_classes/com/sun/tools/internal/ws/resources/wscompile_pt_BR.properties
+ src/share/jaxws_classes/com/sun/tools/internal/ws/resources/wscompile_zh_CN.properties
+ src/share/jaxws_classes/com/sun/tools/internal/ws/resources/wscompile_zh_TW.properties
! src/share/jaxws_classes/com/sun/tools/internal/ws/resources/wsdl.properties
+ src/share/jaxws_classes/com/sun/tools/internal/ws/resources/wsdl_de.properties
+ src/share/jaxws_classes/com/sun/tools/internal/ws/resources/wsdl_es.properties
+ src/share/jaxws_classes/com/sun/tools/internal/ws/resources/wsdl_fr.properties
+ src/share/jaxws_classes/com/sun/tools/internal/ws/resources/wsdl_it.properties
+ src/share/jaxws_classes/com/sun/tools/internal/ws/resources/wsdl_ja.properties
+ src/share/jaxws_classes/com/sun/tools/internal/ws/resources/wsdl_ko.properties
+ src/share/jaxws_classes/com/sun/tools/internal/ws/resources/wsdl_pt_BR.properties
+ src/share/jaxws_classes/com/sun/tools/internal/ws/resources/wsdl_zh_CN.properties
+ src/share/jaxws_classes/com/sun/tools/internal/ws/resources/wsdl_zh_TW.properties
! src/share/jaxws_classes/com/sun/tools/internal/ws/spi/WSToolsObjectFactory.java
! src/share/jaxws_classes/com/sun/tools/internal/ws/spi/package-info.java
! src/share/jaxws_classes/com/sun/tools/internal/ws/util/ClassNameInfo.java
! src/share/jaxws_classes/com/sun/tools/internal/ws/util/ForkEntityResolver.java
! src/share/jaxws_classes/com/sun/tools/internal/ws/util/WSDLFetcher.java
! src/share/jaxws_classes/com/sun/tools/internal/ws/util/WSDLParseException.java
! src/share/jaxws_classes/com/sun/tools/internal/ws/util/WSToolsObjectFactoryImpl.java
! src/share/jaxws_classes/com/sun/tools/internal/ws/util/xml/XmlUtil.java
! src/share/jaxws_classes/com/sun/tools/internal/ws/version.properties
! src/share/jaxws_classes/com/sun/tools/internal/ws/wscompile/AbortException.java
! src/share/jaxws_classes/com/sun/tools/internal/ws/wscompile/AuthInfo.java
! src/share/jaxws_classes/com/sun/tools/internal/ws/wscompile/BadCommandLineException.java
- src/share/jaxws_classes/com/sun/tools/internal/ws/wscompile/DefaultAuthenticator.java
! src/share/jaxws_classes/com/sun/tools/internal/ws/wscompile/ErrorReceiver.java
! src/share/jaxws_classes/com/sun/tools/internal/ws/wscompile/ErrorReceiverFilter.java
! src/share/jaxws_classes/com/sun/tools/internal/ws/wscompile/FilerCodeWriter.java
! src/share/jaxws_classes/com/sun/tools/internal/ws/wscompile/JavaCompilerHelper.java
! src/share/jaxws_classes/com/sun/tools/internal/ws/wscompile/Options.java
! src/share/jaxws_classes/com/sun/tools/internal/ws/wscompile/Plugin.java
! src/share/jaxws_classes/com/sun/tools/internal/ws/wscompile/WSCodeWriter.java
! src/share/jaxws_classes/com/sun/tools/internal/ws/wscompile/WsgenOptions.java
! src/share/jaxws_classes/com/sun/tools/internal/ws/wscompile/WsgenTool.java
! src/share/jaxws_classes/com/sun/tools/internal/ws/wscompile/WsimportListener.java
! src/share/jaxws_classes/com/sun/tools/internal/ws/wscompile/WsimportOptions.java
! src/share/jaxws_classes/com/sun/tools/internal/ws/wscompile/WsimportTool.java
! src/share/jaxws_classes/com/sun/tools/internal/ws/wscompile/plugin/at_generated/PluginImpl.java
! src/share/jaxws_classes/com/sun/tools/internal/ws/wsdl/document/Binding.java
! src/share/jaxws_classes/com/sun/tools/internal/ws/wsdl/document/BindingFault.java
! src/share/jaxws_classes/com/sun/tools/internal/ws/wsdl/document/BindingInput.java
! src/share/jaxws_classes/com/sun/tools/internal/ws/wsdl/document/BindingOperation.java
! src/share/jaxws_classes/com/sun/tools/internal/ws/wsdl/document/BindingOutput.java
! src/share/jaxws_classes/com/sun/tools/internal/ws/wsdl/document/Definitions.java
! src/share/jaxws_classes/com/sun/tools/internal/ws/wsdl/document/Documentation.java
! src/share/jaxws_classes/com/sun/tools/internal/ws/wsdl/document/Fault.java
! src/share/jaxws_classes/com/sun/tools/internal/ws/wsdl/document/Import.java
! src/share/jaxws_classes/com/sun/tools/internal/ws/wsdl/document/Input.java
! src/share/jaxws_classes/com/sun/tools/internal/ws/wsdl/document/Kinds.java
! src/share/jaxws_classes/com/sun/tools/internal/ws/wsdl/document/Message.java
! src/share/jaxws_classes/com/sun/tools/internal/ws/wsdl/document/MessagePart.java
! src/share/jaxws_classes/com/sun/tools/internal/ws/wsdl/document/Operation.java
! src/share/jaxws_classes/com/sun/tools/internal/ws/wsdl/document/OperationStyle.java
! src/share/jaxws_classes/com/sun/tools/internal/ws/wsdl/document/Output.java
! src/share/jaxws_classes/com/sun/tools/internal/ws/wsdl/document/Port.java
! src/share/jaxws_classes/com/sun/tools/internal/ws/wsdl/document/PortType.java
! src/share/jaxws_classes/com/sun/tools/internal/ws/wsdl/document/Service.java
! src/share/jaxws_classes/com/sun/tools/internal/ws/wsdl/document/Types.java
! src/share/jaxws_classes/com/sun/tools/internal/ws/wsdl/document/WSDLConstants.java
! src/share/jaxws_classes/com/sun/tools/internal/ws/wsdl/document/WSDLDocument.java
! src/share/jaxws_classes/com/sun/tools/internal/ws/wsdl/document/WSDLDocumentVisitor.java
! src/share/jaxws_classes/com/sun/tools/internal/ws/wsdl/document/WSDLDocumentVisitorBase.java
! src/share/jaxws_classes/com/sun/tools/internal/ws/wsdl/document/http/HTTPAddress.java
! src/share/jaxws_classes/com/sun/tools/internal/ws/wsdl/document/http/HTTPBinding.java
! src/share/jaxws_classes/com/sun/tools/internal/ws/wsdl/document/http/HTTPConstants.java
! src/share/jaxws_classes/com/sun/tools/internal/ws/wsdl/document/http/HTTPOperation.java
! src/share/jaxws_classes/com/sun/tools/internal/ws/wsdl/document/http/HTTPUrlEncoded.java
! src/share/jaxws_classes/com/sun/tools/internal/ws/wsdl/document/http/HTTPUrlReplacement.java
! src/share/jaxws_classes/com/sun/tools/internal/ws/wsdl/document/jaxws/CustomName.java
! src/share/jaxws_classes/com/sun/tools/internal/ws/wsdl/document/jaxws/Exception.java
! src/share/jaxws_classes/com/sun/tools/internal/ws/wsdl/document/jaxws/JAXWSBinding.java
! src/share/jaxws_classes/com/sun/tools/internal/ws/wsdl/document/jaxws/JAXWSBindingsConstants.java
! src/share/jaxws_classes/com/sun/tools/internal/ws/wsdl/document/jaxws/Parameter.java
! src/share/jaxws_classes/com/sun/tools/internal/ws/wsdl/document/mime/MIMEConstants.java
! src/share/jaxws_classes/com/sun/tools/internal/ws/wsdl/document/mime/MIMEContent.java
! src/share/jaxws_classes/com/sun/tools/internal/ws/wsdl/document/mime/MIMEMultipartRelated.java
! src/share/jaxws_classes/com/sun/tools/internal/ws/wsdl/document/mime/MIMEPart.java
! src/share/jaxws_classes/com/sun/tools/internal/ws/wsdl/document/mime/MIMEXml.java
! src/share/jaxws_classes/com/sun/tools/internal/ws/wsdl/document/schema/SchemaConstants.java
! src/share/jaxws_classes/com/sun/tools/internal/ws/wsdl/document/schema/SchemaKinds.java
! src/share/jaxws_classes/com/sun/tools/internal/ws/wsdl/document/soap/SOAP12Binding.java
! src/share/jaxws_classes/com/sun/tools/internal/ws/wsdl/document/soap/SOAP12Constants.java
! src/share/jaxws_classes/com/sun/tools/internal/ws/wsdl/document/soap/SOAPAddress.java
! src/share/jaxws_classes/com/sun/tools/internal/ws/wsdl/document/soap/SOAPBinding.java
! src/share/jaxws_classes/com/sun/tools/internal/ws/wsdl/document/soap/SOAPBody.java
! src/share/jaxws_classes/com/sun/tools/internal/ws/wsdl/document/soap/SOAPConstants.java
! src/share/jaxws_classes/com/sun/tools/internal/ws/wsdl/document/soap/SOAPFault.java
! src/share/jaxws_classes/com/sun/tools/internal/ws/wsdl/document/soap/SOAPHeader.java
! src/share/jaxws_classes/com/sun/tools/internal/ws/wsdl/document/soap/SOAPHeaderFault.java
! src/share/jaxws_classes/com/sun/tools/internal/ws/wsdl/document/soap/SOAPOperation.java
! src/share/jaxws_classes/com/sun/tools/internal/ws/wsdl/document/soap/SOAPStyle.java
! src/share/jaxws_classes/com/sun/tools/internal/ws/wsdl/document/soap/SOAPUse.java
! src/share/jaxws_classes/com/sun/tools/internal/ws/wsdl/framework/AbstractDocument.java
! src/share/jaxws_classes/com/sun/tools/internal/ws/wsdl/framework/Defining.java
! src/share/jaxws_classes/com/sun/tools/internal/ws/wsdl/framework/DuplicateEntityException.java
! src/share/jaxws_classes/com/sun/tools/internal/ws/wsdl/framework/Elemental.java
! src/share/jaxws_classes/com/sun/tools/internal/ws/wsdl/framework/Entity.java
! src/share/jaxws_classes/com/sun/tools/internal/ws/wsdl/framework/EntityAction.java
! src/share/jaxws_classes/com/sun/tools/internal/ws/wsdl/framework/EntityReferenceAction.java
! src/share/jaxws_classes/com/sun/tools/internal/ws/wsdl/framework/EntityReferenceValidator.java
! src/share/jaxws_classes/com/sun/tools/internal/ws/wsdl/framework/ExtensibilityHelper.java
! src/share/jaxws_classes/com/sun/tools/internal/ws/wsdl/framework/ExtensionImpl.java
! src/share/jaxws_classes/com/sun/tools/internal/ws/wsdl/framework/ExtensionVisitor.java
! src/share/jaxws_classes/com/sun/tools/internal/ws/wsdl/framework/ExtensionVisitorBase.java
! src/share/jaxws_classes/com/sun/tools/internal/ws/wsdl/framework/ExternalEntityReference.java
! src/share/jaxws_classes/com/sun/tools/internal/ws/wsdl/framework/GlobalEntity.java
! src/share/jaxws_classes/com/sun/tools/internal/ws/wsdl/framework/GloballyKnown.java
! src/share/jaxws_classes/com/sun/tools/internal/ws/wsdl/framework/Identifiable.java
! src/share/jaxws_classes/com/sun/tools/internal/ws/wsdl/framework/Kind.java
! src/share/jaxws_classes/com/sun/tools/internal/ws/wsdl/framework/NoSuchEntityException.java
! src/share/jaxws_classes/com/sun/tools/internal/ws/wsdl/framework/ParseException.java
! src/share/jaxws_classes/com/sun/tools/internal/ws/wsdl/framework/ParserListener.java
! src/share/jaxws_classes/com/sun/tools/internal/ws/wsdl/framework/QNameAction.java
! src/share/jaxws_classes/com/sun/tools/internal/ws/wsdl/framework/TWSDLParserContextImpl.java
! src/share/jaxws_classes/com/sun/tools/internal/ws/wsdl/framework/ValidationException.java
! src/share/jaxws_classes/com/sun/tools/internal/ws/wsdl/framework/WSDLLocation.java
! src/share/jaxws_classes/com/sun/tools/internal/ws/wsdl/parser/AbstractExtensionHandler.java
! src/share/jaxws_classes/com/sun/tools/internal/ws/wsdl/parser/AbstractReferenceFinderImpl.java
! src/share/jaxws_classes/com/sun/tools/internal/ws/wsdl/parser/Constants.java
! src/share/jaxws_classes/com/sun/tools/internal/ws/wsdl/parser/DOMBuilder.java
! src/share/jaxws_classes/com/sun/tools/internal/ws/wsdl/parser/DOMForest.java
! src/share/jaxws_classes/com/sun/tools/internal/ws/wsdl/parser/DOMForestParser.java
! src/share/jaxws_classes/com/sun/tools/internal/ws/wsdl/parser/DOMForestScanner.java
! src/share/jaxws_classes/com/sun/tools/internal/ws/wsdl/parser/HTTPExtensionHandler.java
! src/share/jaxws_classes/com/sun/tools/internal/ws/wsdl/parser/InternalizationLogic.java
! src/share/jaxws_classes/com/sun/tools/internal/ws/wsdl/parser/Internalizer.java
! src/share/jaxws_classes/com/sun/tools/internal/ws/wsdl/parser/JAXWSBindingExtensionHandler.java
! src/share/jaxws_classes/com/sun/tools/internal/ws/wsdl/parser/MIMEExtensionHandler.java
! src/share/jaxws_classes/com/sun/tools/internal/ws/wsdl/parser/MemberSubmissionAddressingExtensionHandler.java
! src/share/jaxws_classes/com/sun/tools/internal/ws/wsdl/parser/MetadataFinder.java
! src/share/jaxws_classes/com/sun/tools/internal/ws/wsdl/parser/NamespaceContextImpl.java
! src/share/jaxws_classes/com/sun/tools/internal/ws/wsdl/parser/Policy12ExtensionHandler.java
! src/share/jaxws_classes/com/sun/tools/internal/ws/wsdl/parser/Policy15ExtensionHandler.java
! src/share/jaxws_classes/com/sun/tools/internal/ws/wsdl/parser/SOAP12ExtensionHandler.java
! src/share/jaxws_classes/com/sun/tools/internal/ws/wsdl/parser/SOAPEntityReferenceValidator.java
! src/share/jaxws_classes/com/sun/tools/internal/ws/wsdl/parser/SOAPExtensionHandler.java
! src/share/jaxws_classes/com/sun/tools/internal/ws/wsdl/parser/Util.java
! src/share/jaxws_classes/com/sun/tools/internal/ws/wsdl/parser/VersionChecker.java
! src/share/jaxws_classes/com/sun/tools/internal/ws/wsdl/parser/W3CAddressingExtensionHandler.java
! src/share/jaxws_classes/com/sun/tools/internal/ws/wsdl/parser/W3CAddressingMetadataExtensionHandler.java
! src/share/jaxws_classes/com/sun/tools/internal/ws/wsdl/parser/WSDLInternalizationLogic.java
! src/share/jaxws_classes/com/sun/tools/internal/ws/wsdl/parser/WSDLParser.java
! src/share/jaxws_classes/com/sun/tools/internal/ws/wsdl/parser/WhitespaceStripper.java
! src/share/jaxws_classes/com/sun/tools/internal/xjc/ClassLoaderBuilder.java
! src/share/jaxws_classes/com/sun/tools/internal/xjc/Driver.java
! src/share/jaxws_classes/com/sun/tools/internal/xjc/MessageBundle.properties
+ src/share/jaxws_classes/com/sun/tools/internal/xjc/MessageBundle_de.properties
+ src/share/jaxws_classes/com/sun/tools/internal/xjc/MessageBundle_es.properties
+ src/share/jaxws_classes/com/sun/tools/internal/xjc/MessageBundle_fr.properties
+ src/share/jaxws_classes/com/sun/tools/internal/xjc/MessageBundle_it.properties
+ src/share/jaxws_classes/com/sun/tools/internal/xjc/MessageBundle_ja.properties
+ src/share/jaxws_classes/com/sun/tools/internal/xjc/MessageBundle_ko.properties
+ src/share/jaxws_classes/com/sun/tools/internal/xjc/MessageBundle_pt_BR.properties
+ src/share/jaxws_classes/com/sun/tools/internal/xjc/MessageBundle_zh_CN.properties
+ src/share/jaxws_classes/com/sun/tools/internal/xjc/MessageBundle_zh_TW.properties
! src/share/jaxws_classes/com/sun/tools/internal/xjc/Messages.java
! src/share/jaxws_classes/com/sun/tools/internal/xjc/ModelLoader.java
! src/share/jaxws_classes/com/sun/tools/internal/xjc/Options.java
! src/share/jaxws_classes/com/sun/tools/internal/xjc/SchemaCache.java
! src/share/jaxws_classes/com/sun/tools/internal/xjc/SecureLoader.java
! src/share/jaxws_classes/com/sun/tools/internal/xjc/XJCFacade.java
! src/share/jaxws_classes/com/sun/tools/internal/xjc/api/XJC.java
- src/share/jaxws_classes/com/sun/tools/internal/xjc/api/impl/j2s/JAXBModelImpl.java
- src/share/jaxws_classes/com/sun/tools/internal/xjc/api/impl/j2s/JavaCompilerImpl.java
! src/share/jaxws_classes/com/sun/tools/internal/xjc/api/impl/s2j/SchemaCompilerImpl.java
! src/share/jaxws_classes/com/sun/tools/internal/xjc/api/impl/s2j/TypeAndAnnotationImpl.java
+ src/share/jaxws_classes/com/sun/tools/internal/xjc/api/util/Messages_de.properties
+ src/share/jaxws_classes/com/sun/tools/internal/xjc/api/util/Messages_es.properties
+ src/share/jaxws_classes/com/sun/tools/internal/xjc/api/util/Messages_fr.properties
+ src/share/jaxws_classes/com/sun/tools/internal/xjc/api/util/Messages_it.properties
+ src/share/jaxws_classes/com/sun/tools/internal/xjc/api/util/Messages_ja.properties
+ src/share/jaxws_classes/com/sun/tools/internal/xjc/api/util/Messages_ko.properties
+ src/share/jaxws_classes/com/sun/tools/internal/xjc/api/util/Messages_pt_BR.properties
+ src/share/jaxws_classes/com/sun/tools/internal/xjc/api/util/Messages_zh_CN.properties
+ src/share/jaxws_classes/com/sun/tools/internal/xjc/api/util/Messages_zh_TW.properties
- src/share/jaxws_classes/com/sun/tools/internal/xjc/generator/annotation/ri/OverrideAnnotationOfWriter.java
- src/share/jaxws_classes/com/sun/tools/internal/xjc/generator/annotation/ri/XmlIsSetWriter.java
- src/share/jaxws_classes/com/sun/tools/internal/xjc/generator/annotation/ri/XmlLocationWriter.java
! src/share/jaxws_classes/com/sun/tools/internal/xjc/generator/annotation/spec/XmlAccessorOrderWriter.java
! src/share/jaxws_classes/com/sun/tools/internal/xjc/generator/annotation/spec/XmlAccessorTypeWriter.java
! src/share/jaxws_classes/com/sun/tools/internal/xjc/generator/annotation/spec/XmlAnyAttributeWriter.java
! src/share/jaxws_classes/com/sun/tools/internal/xjc/generator/annotation/spec/XmlAnyElementWriter.java
! src/share/jaxws_classes/com/sun/tools/internal/xjc/generator/annotation/spec/XmlAttachmentRefWriter.java
! src/share/jaxws_classes/com/sun/tools/internal/xjc/generator/annotation/spec/XmlAttributeWriter.java
! src/share/jaxws_classes/com/sun/tools/internal/xjc/generator/annotation/spec/XmlElementDeclWriter.java
! src/share/jaxws_classes/com/sun/tools/internal/xjc/generator/annotation/spec/XmlElementRefWriter.java
! src/share/jaxws_classes/com/sun/tools/internal/xjc/generator/annotation/spec/XmlElementRefsWriter.java
! src/share/jaxws_classes/com/sun/tools/internal/xjc/generator/annotation/spec/XmlElementWrapperWriter.java
! src/share/jaxws_classes/com/sun/tools/internal/xjc/generator/annotation/spec/XmlElementWriter.java
! src/share/jaxws_classes/com/sun/tools/internal/xjc/generator/annotation/spec/XmlElementsWriter.java
! src/share/jaxws_classes/com/sun/tools/internal/xjc/generator/annotation/spec/XmlEnumValueWriter.java
! src/share/jaxws_classes/com/sun/tools/internal/xjc/generator/annotation/spec/XmlEnumWriter.java
! src/share/jaxws_classes/com/sun/tools/internal/xjc/generator/annotation/spec/XmlIDREFWriter.java
! src/share/jaxws_classes/com/sun/tools/internal/xjc/generator/annotation/spec/XmlIDWriter.java
! src/share/jaxws_classes/com/sun/tools/internal/xjc/generator/annotation/spec/XmlInlineBinaryDataWriter.java
! src/share/jaxws_classes/com/sun/tools/internal/xjc/generator/annotation/spec/XmlJavaTypeAdapterWriter.java
! src/share/jaxws_classes/com/sun/tools/internal/xjc/generator/annotation/spec/XmlListWriter.java
! src/share/jaxws_classes/com/sun/tools/internal/xjc/generator/annotation/spec/XmlMimeTypeWriter.java
! src/share/jaxws_classes/com/sun/tools/internal/xjc/generator/annotation/spec/XmlMixedWriter.java
! src/share/jaxws_classes/com/sun/tools/internal/xjc/generator/annotation/spec/XmlNsWriter.java
! src/share/jaxws_classes/com/sun/tools/internal/xjc/generator/annotation/spec/XmlRegistryWriter.java
! src/share/jaxws_classes/com/sun/tools/internal/xjc/generator/annotation/spec/XmlRootElementWriter.java
! src/share/jaxws_classes/com/sun/tools/internal/xjc/generator/annotation/spec/XmlSchemaTypeWriter.java
! src/share/jaxws_classes/com/sun/tools/internal/xjc/generator/annotation/spec/XmlSchemaTypesWriter.java
! src/share/jaxws_classes/com/sun/tools/internal/xjc/generator/annotation/spec/XmlSchemaWriter.java
! src/share/jaxws_classes/com/sun/tools/internal/xjc/generator/annotation/spec/XmlSeeAlsoWriter.java
! src/share/jaxws_classes/com/sun/tools/internal/xjc/generator/annotation/spec/XmlTransientWriter.java
! src/share/jaxws_classes/com/sun/tools/internal/xjc/generator/annotation/spec/XmlTypeWriter.java
! src/share/jaxws_classes/com/sun/tools/internal/xjc/generator/annotation/spec/XmlValueWriter.java
! src/share/jaxws_classes/com/sun/tools/internal/xjc/generator/bean/BeanGenerator.java
! src/share/jaxws_classes/com/sun/tools/internal/xjc/generator/bean/DualObjectFactoryGenerator.java
+ src/share/jaxws_classes/com/sun/tools/internal/xjc/generator/bean/MessageBundle_de.properties
+ src/share/jaxws_classes/com/sun/tools/internal/xjc/generator/bean/MessageBundle_es.properties
+ src/share/jaxws_classes/com/sun/tools/internal/xjc/generator/bean/MessageBundle_fr.properties
+ src/share/jaxws_classes/com/sun/tools/internal/xjc/generator/bean/MessageBundle_it.properties
+ src/share/jaxws_classes/com/sun/tools/internal/xjc/generator/bean/MessageBundle_ja.properties
+ src/share/jaxws_classes/com/sun/tools/internal/xjc/generator/bean/MessageBundle_ko.properties
+ src/share/jaxws_classes/com/sun/tools/internal/xjc/generator/bean/MessageBundle_pt_BR.properties
+ src/share/jaxws_classes/com/sun/tools/internal/xjc/generator/bean/MessageBundle_zh_CN.properties
+ src/share/jaxws_classes/com/sun/tools/internal/xjc/generator/bean/MessageBundle_zh_TW.properties
! src/share/jaxws_classes/com/sun/tools/internal/xjc/generator/bean/field/AbstractFieldWithVar.java
+ src/share/jaxws_classes/com/sun/tools/internal/xjc/generator/bean/field/MessageBundle_de.properties
+ src/share/jaxws_classes/com/sun/tools/internal/xjc/generator/bean/field/MessageBundle_es.properties
+ src/share/jaxws_classes/com/sun/tools/internal/xjc/generator/bean/field/MessageBundle_fr.properties
+ src/share/jaxws_classes/com/sun/tools/internal/xjc/generator/bean/field/MessageBundle_it.properties
+ src/share/jaxws_classes/com/sun/tools/internal/xjc/generator/bean/field/MessageBundle_ja.properties
+ src/share/jaxws_classes/com/sun/tools/internal/xjc/generator/bean/field/MessageBundle_ko.properties
+ src/share/jaxws_classes/com/sun/tools/internal/xjc/generator/bean/field/MessageBundle_pt_BR.properties
+ src/share/jaxws_classes/com/sun/tools/internal/xjc/generator/bean/field/MessageBundle_zh_CN.properties
+ src/share/jaxws_classes/com/sun/tools/internal/xjc/generator/bean/field/MessageBundle_zh_TW.properties
! src/share/jaxws_classes/com/sun/tools/internal/xjc/model/CArrayInfo.java
! src/share/jaxws_classes/com/sun/tools/internal/xjc/model/CBuiltinLeafInfo.java
! src/share/jaxws_classes/com/sun/tools/internal/xjc/model/CPropertyInfo.java
! src/share/jaxws_classes/com/sun/tools/internal/xjc/model/CTypeInfo.java
! src/share/jaxws_classes/com/sun/tools/internal/xjc/model/nav/NavigatorImpl.java
+ src/share/jaxws_classes/com/sun/tools/internal/xjc/reader/MessageBundle_de.properties
+ src/share/jaxws_classes/com/sun/tools/internal/xjc/reader/MessageBundle_es.properties
+ src/share/jaxws_classes/com/sun/tools/internal/xjc/reader/MessageBundle_fr.properties
+ src/share/jaxws_classes/com/sun/tools/internal/xjc/reader/MessageBundle_it.properties
+ src/share/jaxws_classes/com/sun/tools/internal/xjc/reader/MessageBundle_ja.properties
+ src/share/jaxws_classes/com/sun/tools/internal/xjc/reader/MessageBundle_ko.properties
+ src/share/jaxws_classes/com/sun/tools/internal/xjc/reader/MessageBundle_pt_BR.properties
+ src/share/jaxws_classes/com/sun/tools/internal/xjc/reader/MessageBundle_zh_CN.properties
+ src/share/jaxws_classes/com/sun/tools/internal/xjc/reader/MessageBundle_zh_TW.properties
! src/share/jaxws_classes/com/sun/tools/internal/xjc/reader/TypeUtil.java
+ src/share/jaxws_classes/com/sun/tools/internal/xjc/reader/dtd/MessageBundle_de.properties
+ src/share/jaxws_classes/com/sun/tools/internal/xjc/reader/dtd/MessageBundle_es.properties
+ src/share/jaxws_classes/com/sun/tools/internal/xjc/reader/dtd/MessageBundle_fr.properties
+ src/share/jaxws_classes/com/sun/tools/internal/xjc/reader/dtd/MessageBundle_it.properties
+ src/share/jaxws_classes/com/sun/tools/internal/xjc/reader/dtd/MessageBundle_ja.properties
+ src/share/jaxws_classes/com/sun/tools/internal/xjc/reader/dtd/MessageBundle_ko.properties
+ src/share/jaxws_classes/com/sun/tools/internal/xjc/reader/dtd/MessageBundle_pt_BR.properties
+ src/share/jaxws_classes/com/sun/tools/internal/xjc/reader/dtd/MessageBundle_zh_CN.properties
+ src/share/jaxws_classes/com/sun/tools/internal/xjc/reader/dtd/MessageBundle_zh_TW.properties
! src/share/jaxws_classes/com/sun/tools/internal/xjc/reader/dtd/bindinfo/BIUserConversion.java
! src/share/jaxws_classes/com/sun/tools/internal/xjc/reader/dtd/bindinfo/BindInfo.java
! src/share/jaxws_classes/com/sun/tools/internal/xjc/reader/dtd/bindinfo/DOMBuilder.java
+ src/share/jaxws_classes/com/sun/tools/internal/xjc/reader/dtd/bindinfo/MessageBundle_de.properties
+ src/share/jaxws_classes/com/sun/tools/internal/xjc/reader/dtd/bindinfo/MessageBundle_es.properties
+ src/share/jaxws_classes/com/sun/tools/internal/xjc/reader/dtd/bindinfo/MessageBundle_fr.properties
+ src/share/jaxws_classes/com/sun/tools/internal/xjc/reader/dtd/bindinfo/MessageBundle_it.properties
+ src/share/jaxws_classes/com/sun/tools/internal/xjc/reader/dtd/bindinfo/MessageBundle_ja.properties
+ src/share/jaxws_classes/com/sun/tools/internal/xjc/reader/dtd/bindinfo/MessageBundle_ko.properties
+ src/share/jaxws_classes/com/sun/tools/internal/xjc/reader/dtd/bindinfo/MessageBundle_pt_BR.properties
+ src/share/jaxws_classes/com/sun/tools/internal/xjc/reader/dtd/bindinfo/MessageBundle_zh_CN.properties
+ src/share/jaxws_classes/com/sun/tools/internal/xjc/reader/dtd/bindinfo/MessageBundle_zh_TW.properties
! src/share/jaxws_classes/com/sun/tools/internal/xjc/reader/internalizer/AbstractReferenceFinderImpl.java
! src/share/jaxws_classes/com/sun/tools/internal/xjc/reader/internalizer/DOMForest.java
! src/share/jaxws_classes/com/sun/tools/internal/xjc/reader/internalizer/Internalizer.java
+ src/share/jaxws_classes/com/sun/tools/internal/xjc/reader/internalizer/MessageBundle_de.properties
+ src/share/jaxws_classes/com/sun/tools/internal/xjc/reader/internalizer/MessageBundle_es.properties
+ src/share/jaxws_classes/com/sun/tools/internal/xjc/reader/internalizer/MessageBundle_fr.properties
+ src/share/jaxws_classes/com/sun/tools/internal/xjc/reader/internalizer/MessageBundle_it.properties
+ src/share/jaxws_classes/com/sun/tools/internal/xjc/reader/internalizer/MessageBundle_ja.properties
+ src/share/jaxws_classes/com/sun/tools/internal/xjc/reader/internalizer/MessageBundle_ko.properties
+ src/share/jaxws_classes/com/sun/tools/internal/xjc/reader/internalizer/MessageBundle_pt_BR.properties
+ src/share/jaxws_classes/com/sun/tools/internal/xjc/reader/internalizer/MessageBundle_zh_CN.properties
+ src/share/jaxws_classes/com/sun/tools/internal/xjc/reader/internalizer/MessageBundle_zh_TW.properties
! src/share/jaxws_classes/com/sun/tools/internal/xjc/reader/internalizer/SCDBasedBindingSet.java
! src/share/jaxws_classes/com/sun/tools/internal/xjc/reader/xmlschema/BGMBuilder.java
+ src/share/jaxws_classes/com/sun/tools/internal/xjc/reader/xmlschema/MessageBundle_de.properties
+ src/share/jaxws_classes/com/sun/tools/internal/xjc/reader/xmlschema/MessageBundle_es.properties
+ src/share/jaxws_classes/com/sun/tools/internal/xjc/reader/xmlschema/MessageBundle_fr.properties
+ src/share/jaxws_classes/com/sun/tools/internal/xjc/reader/xmlschema/MessageBundle_it.properties
+ src/share/jaxws_classes/com/sun/tools/internal/xjc/reader/xmlschema/MessageBundle_ja.properties
+ src/share/jaxws_classes/com/sun/tools/internal/xjc/reader/xmlschema/MessageBundle_ko.properties
+ src/share/jaxws_classes/com/sun/tools/internal/xjc/reader/xmlschema/MessageBundle_pt_BR.properties
+ src/share/jaxws_classes/com/sun/tools/internal/xjc/reader/xmlschema/MessageBundle_zh_CN.properties
+ src/share/jaxws_classes/com/sun/tools/internal/xjc/reader/xmlschema/MessageBundle_zh_TW.properties
! src/share/jaxws_classes/com/sun/tools/internal/xjc/reader/xmlschema/SimpleTypeBuilder.java
! src/share/jaxws_classes/com/sun/tools/internal/xjc/reader/xmlschema/bindinfo/AnnotationParserFactoryImpl.java
! src/share/jaxws_classes/com/sun/tools/internal/xjc/reader/xmlschema/bindinfo/BindInfo.java
! src/share/jaxws_classes/com/sun/tools/internal/xjc/reader/xmlschema/bindinfo/DomHandlerEx.java
+ src/share/jaxws_classes/com/sun/tools/internal/xjc/reader/xmlschema/bindinfo/MessageBundle_de.properties
+ src/share/jaxws_classes/com/sun/tools/internal/xjc/reader/xmlschema/bindinfo/MessageBundle_es.properties
+ src/share/jaxws_classes/com/sun/tools/internal/xjc/reader/xmlschema/bindinfo/MessageBundle_fr.properties
+ src/share/jaxws_classes/com/sun/tools/internal/xjc/reader/xmlschema/bindinfo/MessageBundle_it.properties
+ src/share/jaxws_classes/com/sun/tools/internal/xjc/reader/xmlschema/bindinfo/MessageBundle_ja.properties
+ src/share/jaxws_classes/com/sun/tools/internal/xjc/reader/xmlschema/bindinfo/MessageBundle_ko.properties
+ src/share/jaxws_classes/com/sun/tools/internal/xjc/reader/xmlschema/bindinfo/MessageBundle_pt_BR.properties
+ src/share/jaxws_classes/com/sun/tools/internal/xjc/reader/xmlschema/bindinfo/MessageBundle_zh_CN.properties
+ src/share/jaxws_classes/com/sun/tools/internal/xjc/reader/xmlschema/bindinfo/MessageBundle_zh_TW.properties
+ src/share/jaxws_classes/com/sun/tools/internal/xjc/reader/xmlschema/ct/MessageBundle_de.properties
+ src/share/jaxws_classes/com/sun/tools/internal/xjc/reader/xmlschema/ct/MessageBundle_es.properties
+ src/share/jaxws_classes/com/sun/tools/internal/xjc/reader/xmlschema/ct/MessageBundle_fr.properties
+ src/share/jaxws_classes/com/sun/tools/internal/xjc/reader/xmlschema/ct/MessageBundle_it.properties
+ src/share/jaxws_classes/com/sun/tools/internal/xjc/reader/xmlschema/ct/MessageBundle_ja.properties
+ src/share/jaxws_classes/com/sun/tools/internal/xjc/reader/xmlschema/ct/MessageBundle_ko.properties
+ src/share/jaxws_classes/com/sun/tools/internal/xjc/reader/xmlschema/ct/MessageBundle_pt_BR.properties
+ src/share/jaxws_classes/com/sun/tools/internal/xjc/reader/xmlschema/ct/MessageBundle_zh_CN.properties
+ src/share/jaxws_classes/com/sun/tools/internal/xjc/reader/xmlschema/ct/MessageBundle_zh_TW.properties
+ src/share/jaxws_classes/com/sun/tools/internal/xjc/reader/xmlschema/parser/MessageBundle_de.properties
+ src/share/jaxws_classes/com/sun/tools/internal/xjc/reader/xmlschema/parser/MessageBundle_es.properties
+ src/share/jaxws_classes/com/sun/tools/internal/xjc/reader/xmlschema/parser/MessageBundle_fr.properties
+ src/share/jaxws_classes/com/sun/tools/internal/xjc/reader/xmlschema/parser/MessageBundle_it.properties
+ src/share/jaxws_classes/com/sun/tools/internal/xjc/reader/xmlschema/parser/MessageBundle_ja.properties
+ src/share/jaxws_classes/com/sun/tools/internal/xjc/reader/xmlschema/parser/MessageBundle_ko.properties
+ src/share/jaxws_classes/com/sun/tools/internal/xjc/reader/xmlschema/parser/MessageBundle_pt_BR.properties
+ src/share/jaxws_classes/com/sun/tools/internal/xjc/reader/xmlschema/parser/MessageBundle_zh_CN.properties
+ src/share/jaxws_classes/com/sun/tools/internal/xjc/reader/xmlschema/parser/MessageBundle_zh_TW.properties
! src/share/jaxws_classes/com/sun/tools/internal/xjc/reader/xmlschema/parser/SchemaConstraintChecker.java
! src/share/jaxws_classes/com/sun/tools/internal/xjc/util/DOMUtils.java
+ src/share/jaxws_classes/com/sun/tools/internal/xjc/util/MessageBundle_de.properties
+ src/share/jaxws_classes/com/sun/tools/internal/xjc/util/MessageBundle_es.properties
+ src/share/jaxws_classes/com/sun/tools/internal/xjc/util/MessageBundle_fr.properties
+ src/share/jaxws_classes/com/sun/tools/internal/xjc/util/MessageBundle_it.properties
+ src/share/jaxws_classes/com/sun/tools/internal/xjc/util/MessageBundle_ja.properties
+ src/share/jaxws_classes/com/sun/tools/internal/xjc/util/MessageBundle_ko.properties
+ src/share/jaxws_classes/com/sun/tools/internal/xjc/util/MessageBundle_pt_BR.properties
+ src/share/jaxws_classes/com/sun/tools/internal/xjc/util/MessageBundle_zh_CN.properties
+ src/share/jaxws_classes/com/sun/tools/internal/xjc/util/MessageBundle_zh_TW.properties
! src/share/jaxws_classes/com/sun/tools/internal/xjc/util/Util.java
! src/share/jaxws_classes/com/sun/xml/internal/bind/DatatypeConverterImpl.java
! src/share/jaxws_classes/com/sun/xml/internal/bind/InternalAccessorFactory.java
! src/share/jaxws_classes/com/sun/xml/internal/bind/Util.java
! src/share/jaxws_classes/com/sun/xml/internal/bind/WhiteSpaceProcessor.java
! src/share/jaxws_classes/com/sun/xml/internal/bind/api/JAXBRIContext.java
+ src/share/jaxws_classes/com/sun/xml/internal/bind/api/Messages_de.properties
+ src/share/jaxws_classes/com/sun/xml/internal/bind/api/Messages_es.properties
+ src/share/jaxws_classes/com/sun/xml/internal/bind/api/Messages_fr.properties
+ src/share/jaxws_classes/com/sun/xml/internal/bind/api/Messages_it.properties
+ src/share/jaxws_classes/com/sun/xml/internal/bind/api/Messages_ja.properties
+ src/share/jaxws_classes/com/sun/xml/internal/bind/api/Messages_ko.properties
+ src/share/jaxws_classes/com/sun/xml/internal/bind/api/Messages_pt_BR.properties
+ src/share/jaxws_classes/com/sun/xml/internal/bind/api/Messages_zh_CN.properties
+ src/share/jaxws_classes/com/sun/xml/internal/bind/api/Messages_zh_TW.properties
! src/share/jaxws_classes/com/sun/xml/internal/bind/api/impl/NameConverter.java
! src/share/jaxws_classes/com/sun/xml/internal/bind/api/impl/NameUtil.java
+ src/share/jaxws_classes/com/sun/xml/internal/bind/marshaller/Messages_de.properties
+ src/share/jaxws_classes/com/sun/xml/internal/bind/marshaller/Messages_es.properties
+ src/share/jaxws_classes/com/sun/xml/internal/bind/marshaller/Messages_fr.properties
+ src/share/jaxws_classes/com/sun/xml/internal/bind/marshaller/Messages_it.properties
+ src/share/jaxws_classes/com/sun/xml/internal/bind/marshaller/Messages_ja.properties
+ src/share/jaxws_classes/com/sun/xml/internal/bind/marshaller/Messages_ko.properties
+ src/share/jaxws_classes/com/sun/xml/internal/bind/marshaller/Messages_pt_BR.properties
+ src/share/jaxws_classes/com/sun/xml/internal/bind/marshaller/Messages_zh_CN.properties
+ src/share/jaxws_classes/com/sun/xml/internal/bind/marshaller/Messages_zh_TW.properties
! src/share/jaxws_classes/com/sun/xml/internal/bind/marshaller/SAX2DOMEx.java
+ src/share/jaxws_classes/com/sun/xml/internal/bind/unmarshaller/Messages_de.properties
+ src/share/jaxws_classes/com/sun/xml/internal/bind/unmarshaller/Messages_es.properties
+ src/share/jaxws_classes/com/sun/xml/internal/bind/unmarshaller/Messages_fr.properties
+ src/share/jaxws_classes/com/sun/xml/internal/bind/unmarshaller/Messages_it.properties
+ src/share/jaxws_classes/com/sun/xml/internal/bind/unmarshaller/Messages_ja.properties
+ src/share/jaxws_classes/com/sun/xml/internal/bind/unmarshaller/Messages_ko.properties
+ src/share/jaxws_classes/com/sun/xml/internal/bind/unmarshaller/Messages_pt_BR.properties
+ src/share/jaxws_classes/com/sun/xml/internal/bind/unmarshaller/Messages_zh_CN.properties
+ src/share/jaxws_classes/com/sun/xml/internal/bind/unmarshaller/Messages_zh_TW.properties
! src/share/jaxws_classes/com/sun/xml/internal/bind/util/SecureLoader.java
! src/share/jaxws_classes/com/sun/xml/internal/bind/v2/ClassFactory.java
! src/share/jaxws_classes/com/sun/xml/internal/bind/v2/ContextFactory.java
! src/share/jaxws_classes/com/sun/xml/internal/bind/v2/Messages.java
! src/share/jaxws_classes/com/sun/xml/internal/bind/v2/Messages.properties
+ src/share/jaxws_classes/com/sun/xml/internal/bind/v2/Messages_de.properties
+ src/share/jaxws_classes/com/sun/xml/internal/bind/v2/Messages_es.properties
+ src/share/jaxws_classes/com/sun/xml/internal/bind/v2/Messages_fr.properties
+ src/share/jaxws_classes/com/sun/xml/internal/bind/v2/Messages_it.properties
+ src/share/jaxws_classes/com/sun/xml/internal/bind/v2/Messages_ja.properties
+ src/share/jaxws_classes/com/sun/xml/internal/bind/v2/Messages_ko.properties
+ src/share/jaxws_classes/com/sun/xml/internal/bind/v2/Messages_pt_BR.properties
+ src/share/jaxws_classes/com/sun/xml/internal/bind/v2/Messages_zh_CN.properties
+ src/share/jaxws_classes/com/sun/xml/internal/bind/v2/Messages_zh_TW.properties
! src/share/jaxws_classes/com/sun/xml/internal/bind/v2/model/annotation/Init.java
+ src/share/jaxws_classes/com/sun/xml/internal/bind/v2/model/annotation/Messages_de.properties
+ src/share/jaxws_classes/com/sun/xml/internal/bind/v2/model/annotation/Messages_es.properties
+ src/share/jaxws_classes/com/sun/xml/internal/bind/v2/model/annotation/Messages_fr.properties
+ src/share/jaxws_classes/com/sun/xml/internal/bind/v2/model/annotation/Messages_it.properties
+ src/share/jaxws_classes/com/sun/xml/internal/bind/v2/model/annotation/Messages_ja.properties
+ src/share/jaxws_classes/com/sun/xml/internal/bind/v2/model/annotation/Messages_ko.properties
+ src/share/jaxws_classes/com/sun/xml/internal/bind/v2/model/annotation/Messages_pt_BR.properties
+ src/share/jaxws_classes/com/sun/xml/internal/bind/v2/model/annotation/Messages_zh_CN.properties
+ src/share/jaxws_classes/com/sun/xml/internal/bind/v2/model/annotation/Messages_zh_TW.properties
! src/share/jaxws_classes/com/sun/xml/internal/bind/v2/model/annotation/XmlAttributeQuick.java
! src/share/jaxws_classes/com/sun/xml/internal/bind/v2/model/annotation/XmlElementDeclQuick.java
! src/share/jaxws_classes/com/sun/xml/internal/bind/v2/model/annotation/XmlElementQuick.java
! src/share/jaxws_classes/com/sun/xml/internal/bind/v2/model/annotation/XmlElementRefQuick.java
! src/share/jaxws_classes/com/sun/xml/internal/bind/v2/model/annotation/XmlElementRefsQuick.java
! src/share/jaxws_classes/com/sun/xml/internal/bind/v2/model/annotation/XmlEnumQuick.java
! src/share/jaxws_classes/com/sun/xml/internal/bind/v2/model/annotation/XmlRootElementQuick.java
! src/share/jaxws_classes/com/sun/xml/internal/bind/v2/model/annotation/XmlSchemaQuick.java
! src/share/jaxws_classes/com/sun/xml/internal/bind/v2/model/annotation/XmlSchemaTypeQuick.java
! src/share/jaxws_classes/com/sun/xml/internal/bind/v2/model/annotation/XmlTransientQuick.java
! src/share/jaxws_classes/com/sun/xml/internal/bind/v2/model/annotation/XmlTypeQuick.java
! src/share/jaxws_classes/com/sun/xml/internal/bind/v2/model/annotation/XmlValueQuick.java
! src/share/jaxws_classes/com/sun/xml/internal/bind/v2/model/core/ErrorHandler.java
! src/share/jaxws_classes/com/sun/xml/internal/bind/v2/model/core/PropertyInfo.java
! src/share/jaxws_classes/com/sun/xml/internal/bind/v2/model/core/PropertyKind.java
! src/share/jaxws_classes/com/sun/xml/internal/bind/v2/model/core/Ref.java
! src/share/jaxws_classes/com/sun/xml/internal/bind/v2/model/core/RegistryInfo.java
! src/share/jaxws_classes/com/sun/xml/internal/bind/v2/model/impl/ArrayInfoImpl.java
+ src/share/jaxws_classes/com/sun/xml/internal/bind/v2/model/impl/Messages_de.properties
+ src/share/jaxws_classes/com/sun/xml/internal/bind/v2/model/impl/Messages_es.properties
+ src/share/jaxws_classes/com/sun/xml/internal/bind/v2/model/impl/Messages_fr.properties
+ src/share/jaxws_classes/com/sun/xml/internal/bind/v2/model/impl/Messages_it.properties
+ src/share/jaxws_classes/com/sun/xml/internal/bind/v2/model/impl/Messages_ja.properties
+ src/share/jaxws_classes/com/sun/xml/internal/bind/v2/model/impl/Messages_ko.properties
+ src/share/jaxws_classes/com/sun/xml/internal/bind/v2/model/impl/Messages_pt_BR.properties
+ src/share/jaxws_classes/com/sun/xml/internal/bind/v2/model/impl/Messages_zh_CN.properties
+ src/share/jaxws_classes/com/sun/xml/internal/bind/v2/model/impl/Messages_zh_TW.properties
! src/share/jaxws_classes/com/sun/xml/internal/bind/v2/model/impl/ModelBuilder.java
+ src/share/jaxws_classes/com/sun/xml/internal/bind/v2/model/impl/ModelBuilderI.java
! src/share/jaxws_classes/com/sun/xml/internal/bind/v2/model/impl/ReferencePropertyInfoImpl.java
! src/share/jaxws_classes/com/sun/xml/internal/bind/v2/model/impl/RuntimeBuiltinLeafInfoImpl.java
! src/share/jaxws_classes/com/sun/xml/internal/bind/v2/model/impl/RuntimeTypeInfoSetImpl.java
! src/share/jaxws_classes/com/sun/xml/internal/bind/v2/model/nav/ParameterizedTypeImpl.java
! src/share/jaxws_classes/com/sun/xml/internal/bind/v2/model/nav/ReflectionNavigator.java
! src/share/jaxws_classes/com/sun/xml/internal/bind/v2/model/nav/SecureLoader.java
! src/share/jaxws_classes/com/sun/xml/internal/bind/v2/model/runtime/RuntimeNonElement.java
! src/share/jaxws_classes/com/sun/xml/internal/bind/v2/model/runtime/RuntimeTypeInfoSet.java
+ src/share/jaxws_classes/com/sun/xml/internal/bind/v2/model/util/ArrayInfoUtil.java
! src/share/jaxws_classes/com/sun/xml/internal/bind/v2/runtime/ClassBeanInfoImpl.java
! src/share/jaxws_classes/com/sun/xml/internal/bind/v2/runtime/JAXBContextImpl.java
! src/share/jaxws_classes/com/sun/xml/internal/bind/v2/runtime/LeafBeanInfoImpl.java
! src/share/jaxws_classes/com/sun/xml/internal/bind/v2/runtime/MarshallerImpl.java
+ src/share/jaxws_classes/com/sun/xml/internal/bind/v2/runtime/Messages_de.properties
+ src/share/jaxws_classes/com/sun/xml/internal/bind/v2/runtime/Messages_es.properties
+ src/share/jaxws_classes/com/sun/xml/internal/bind/v2/runtime/Messages_fr.properties
+ src/share/jaxws_classes/com/sun/xml/internal/bind/v2/runtime/Messages_it.properties
+ src/share/jaxws_classes/com/sun/xml/internal/bind/v2/runtime/Messages_ja.properties
+ src/share/jaxws_classes/com/sun/xml/internal/bind/v2/runtime/Messages_ko.properties
+ src/share/jaxws_classes/com/sun/xml/internal/bind/v2/runtime/Messages_pt_BR.properties
+ src/share/jaxws_classes/com/sun/xml/internal/bind/v2/runtime/Messages_zh_CN.properties
+ src/share/jaxws_classes/com/sun/xml/internal/bind/v2/runtime/Messages_zh_TW.properties
! src/share/jaxws_classes/com/sun/xml/internal/bind/v2/runtime/RuntimeUtil.java
+ src/share/jaxws_classes/com/sun/xml/internal/bind/v2/runtime/SwaRefAdapterMarker.java
! src/share/jaxws_classes/com/sun/xml/internal/bind/v2/runtime/XMLSerializer.java
- src/share/jaxws_classes/com/sun/xml/internal/bind/v2/runtime/output/InPlaceDOMOutput.java
! src/share/jaxws_classes/com/sun/xml/internal/bind/v2/runtime/property/ListElementProperty.java
+ src/share/jaxws_classes/com/sun/xml/internal/bind/v2/runtime/property/Messages_de.properties
+ src/share/jaxws_classes/com/sun/xml/internal/bind/v2/runtime/property/Messages_es.properties
+ src/share/jaxws_classes/com/sun/xml/internal/bind/v2/runtime/property/Messages_fr.properties
+ src/share/jaxws_classes/com/sun/xml/internal/bind/v2/runtime/property/Messages_it.properties
+ src/share/jaxws_classes/com/sun/xml/internal/bind/v2/runtime/property/Messages_ja.properties
+ src/share/jaxws_classes/com/sun/xml/internal/bind/v2/runtime/property/Messages_ko.properties
+ src/share/jaxws_classes/com/sun/xml/internal/bind/v2/runtime/property/Messages_pt_BR.properties
+ src/share/jaxws_classes/com/sun/xml/internal/bind/v2/runtime/property/Messages_zh_CN.properties
+ src/share/jaxws_classes/com/sun/xml/internal/bind/v2/runtime/property/Messages_zh_TW.properties
! src/share/jaxws_classes/com/sun/xml/internal/bind/v2/runtime/property/SingleElementLeafProperty.java
! src/share/jaxws_classes/com/sun/xml/internal/bind/v2/runtime/property/SingleMapNodeProperty.java
! src/share/jaxws_classes/com/sun/xml/internal/bind/v2/runtime/reflect/Accessor.java
! src/share/jaxws_classes/com/sun/xml/internal/bind/v2/runtime/reflect/Lister.java
+ src/share/jaxws_classes/com/sun/xml/internal/bind/v2/runtime/reflect/Messages_de.properties
+ src/share/jaxws_classes/com/sun/xml/internal/bind/v2/runtime/reflect/Messages_es.properties
+ src/share/jaxws_classes/com/sun/xml/internal/bind/v2/runtime/reflect/Messages_fr.properties
+ src/share/jaxws_classes/com/sun/xml/internal/bind/v2/runtime/reflect/Messages_it.properties
+ src/share/jaxws_classes/com/sun/xml/internal/bind/v2/runtime/reflect/Messages_ja.properties
+ src/share/jaxws_classes/com/sun/xml/internal/bind/v2/runtime/reflect/Messages_ko.properties
+ src/share/jaxws_classes/com/sun/xml/internal/bind/v2/runtime/reflect/Messages_pt_BR.properties
+ src/share/jaxws_classes/com/sun/xml/internal/bind/v2/runtime/reflect/Messages_zh_CN.properties
+ src/share/jaxws_classes/com/sun/xml/internal/bind/v2/runtime/reflect/Messages_zh_TW.properties
! src/share/jaxws_classes/com/sun/xml/internal/bind/v2/runtime/reflect/opt/AccessorInjector.java
! src/share/jaxws_classes/com/sun/xml/internal/bind/v2/runtime/reflect/opt/OptimizedAccessorFactory.java
! src/share/jaxws_classes/com/sun/xml/internal/bind/v2/runtime/unmarshaller/DomLoader.java
+ src/share/jaxws_classes/com/sun/xml/internal/bind/v2/runtime/unmarshaller/Messages_de.properties
+ src/share/jaxws_classes/com/sun/xml/internal/bind/v2/runtime/unmarshaller/Messages_es.properties
+ src/share/jaxws_classes/com/sun/xml/internal/bind/v2/runtime/unmarshaller/Messages_fr.properties
+ src/share/jaxws_classes/com/sun/xml/internal/bind/v2/runtime/unmarshaller/Messages_it.properties
+ src/share/jaxws_classes/com/sun/xml/internal/bind/v2/runtime/unmarshaller/Messages_ja.properties
+ src/share/jaxws_classes/com/sun/xml/internal/bind/v2/runtime/unmarshaller/Messages_ko.properties
+ src/share/jaxws_classes/com/sun/xml/internal/bind/v2/runtime/unmarshaller/Messages_pt_BR.properties
+ src/share/jaxws_classes/com/sun/xml/internal/bind/v2/runtime/unmarshaller/Messages_zh_CN.properties
+ src/share/jaxws_classes/com/sun/xml/internal/bind/v2/runtime/unmarshaller/Messages_zh_TW.properties
! src/share/jaxws_classes/com/sun/xml/internal/bind/v2/runtime/unmarshaller/UnmarshallerImpl.java
+ src/share/jaxws_classes/com/sun/xml/internal/bind/v2/schemagen/Messages_de.properties
+ src/share/jaxws_classes/com/sun/xml/internal/bind/v2/schemagen/Messages_es.properties
+ src/share/jaxws_classes/com/sun/xml/internal/bind/v2/schemagen/Messages_fr.properties
+ src/share/jaxws_classes/com/sun/xml/internal/bind/v2/schemagen/Messages_it.properties
+ src/share/jaxws_classes/com/sun/xml/internal/bind/v2/schemagen/Messages_ja.properties
+ src/share/jaxws_classes/com/sun/xml/internal/bind/v2/schemagen/Messages_ko.properties
+ src/share/jaxws_classes/com/sun/xml/internal/bind/v2/schemagen/Messages_pt_BR.properties
+ src/share/jaxws_classes/com/sun/xml/internal/bind/v2/schemagen/Messages_zh_CN.properties
+ src/share/jaxws_classes/com/sun/xml/internal/bind/v2/schemagen/Messages_zh_TW.properties
! src/share/jaxws_classes/com/sun/xml/internal/bind/v2/schemagen/XmlSchemaGenerator.java
! src/share/jaxws_classes/com/sun/xml/internal/bind/v2/schemagen/xmlschema/Annotated.java
! src/share/jaxws_classes/com/sun/xml/internal/bind/v2/schemagen/xmlschema/Annotation.java
! src/share/jaxws_classes/com/sun/xml/internal/bind/v2/schemagen/xmlschema/Any.java
! src/share/jaxws_classes/com/sun/xml/internal/bind/v2/schemagen/xmlschema/Appinfo.java
! src/share/jaxws_classes/com/sun/xml/internal/bind/v2/schemagen/xmlschema/AttrDecls.java
! src/share/jaxws_classes/com/sun/xml/internal/bind/v2/schemagen/xmlschema/AttributeType.java
! src/share/jaxws_classes/com/sun/xml/internal/bind/v2/schemagen/xmlschema/ComplexContent.java
! src/share/jaxws_classes/com/sun/xml/internal/bind/v2/schemagen/xmlschema/ComplexExtension.java
! src/share/jaxws_classes/com/sun/xml/internal/bind/v2/schemagen/xmlschema/ComplexRestriction.java
! src/share/jaxws_classes/com/sun/xml/internal/bind/v2/schemagen/xmlschema/ComplexType.java
! src/share/jaxws_classes/com/sun/xml/internal/bind/v2/schemagen/xmlschema/ComplexTypeHost.java
! src/share/jaxws_classes/com/sun/xml/internal/bind/v2/schemagen/xmlschema/ComplexTypeModel.java
! src/share/jaxws_classes/com/sun/xml/internal/bind/v2/schemagen/xmlschema/Documentation.java
! src/share/jaxws_classes/com/sun/xml/internal/bind/v2/schemagen/xmlschema/Element.java
! src/share/jaxws_classes/com/sun/xml/internal/bind/v2/schemagen/xmlschema/ExplicitGroup.java
! src/share/jaxws_classes/com/sun/xml/internal/bind/v2/schemagen/xmlschema/ExtensionType.java
! src/share/jaxws_classes/com/sun/xml/internal/bind/v2/schemagen/xmlschema/FixedOrDefault.java
! src/share/jaxws_classes/com/sun/xml/internal/bind/v2/schemagen/xmlschema/Import.java
! src/share/jaxws_classes/com/sun/xml/internal/bind/v2/schemagen/xmlschema/List.java
! src/share/jaxws_classes/com/sun/xml/internal/bind/v2/schemagen/xmlschema/LocalAttribute.java
! src/share/jaxws_classes/com/sun/xml/internal/bind/v2/schemagen/xmlschema/LocalElement.java
! src/share/jaxws_classes/com/sun/xml/internal/bind/v2/schemagen/xmlschema/NestedParticle.java
! src/share/jaxws_classes/com/sun/xml/internal/bind/v2/schemagen/xmlschema/NoFixedFacet.java
! src/share/jaxws_classes/com/sun/xml/internal/bind/v2/schemagen/xmlschema/Occurs.java
! src/share/jaxws_classes/com/sun/xml/internal/bind/v2/schemagen/xmlschema/Redefinable.java
! src/share/jaxws_classes/com/sun/xml/internal/bind/v2/schemagen/xmlschema/Schema.java
! src/share/jaxws_classes/com/sun/xml/internal/bind/v2/schemagen/xmlschema/SchemaTop.java
! src/share/jaxws_classes/com/sun/xml/internal/bind/v2/schemagen/xmlschema/SimpleContent.java
! src/share/jaxws_classes/com/sun/xml/internal/bind/v2/schemagen/xmlschema/SimpleDerivation.java
! src/share/jaxws_classes/com/sun/xml/internal/bind/v2/schemagen/xmlschema/SimpleExtension.java
! src/share/jaxws_classes/com/sun/xml/internal/bind/v2/schemagen/xmlschema/SimpleRestriction.java
! src/share/jaxws_classes/com/sun/xml/internal/bind/v2/schemagen/xmlschema/SimpleRestrictionModel.java
! src/share/jaxws_classes/com/sun/xml/internal/bind/v2/schemagen/xmlschema/SimpleType.java
! src/share/jaxws_classes/com/sun/xml/internal/bind/v2/schemagen/xmlschema/SimpleTypeHost.java
! src/share/jaxws_classes/com/sun/xml/internal/bind/v2/schemagen/xmlschema/TopLevelAttribute.java
! src/share/jaxws_classes/com/sun/xml/internal/bind/v2/schemagen/xmlschema/TopLevelElement.java
! src/share/jaxws_classes/com/sun/xml/internal/bind/v2/schemagen/xmlschema/TypeDefParticle.java
! src/share/jaxws_classes/com/sun/xml/internal/bind/v2/schemagen/xmlschema/TypeHost.java
! src/share/jaxws_classes/com/sun/xml/internal/bind/v2/schemagen/xmlschema/Union.java
! src/share/jaxws_classes/com/sun/xml/internal/bind/v2/schemagen/xmlschema/Wildcard.java
! src/share/jaxws_classes/com/sun/xml/internal/bind/v2/schemagen/xmlschema/package-info.java
+ src/share/jaxws_classes/com/sun/xml/internal/bind/v2/util/XmlFactory.java
! src/share/jaxws_classes/com/sun/xml/internal/messaging/saaj/SOAPExceptionImpl.java
! src/share/jaxws_classes/com/sun/xml/internal/messaging/saaj/client/p2p/HttpSOAPConnection.java
! src/share/jaxws_classes/com/sun/xml/internal/messaging/saaj/client/p2p/HttpSOAPConnectionFactory.java
! src/share/jaxws_classes/com/sun/xml/internal/messaging/saaj/client/p2p/LocalStrings.properties
+ src/share/jaxws_classes/com/sun/xml/internal/messaging/saaj/client/p2p/LocalStrings_de.properties
+ src/share/jaxws_classes/com/sun/xml/internal/messaging/saaj/client/p2p/LocalStrings_es.properties
+ src/share/jaxws_classes/com/sun/xml/internal/messaging/saaj/client/p2p/LocalStrings_fr.properties
+ src/share/jaxws_classes/com/sun/xml/internal/messaging/saaj/client/p2p/LocalStrings_it.properties
+ src/share/jaxws_classes/com/sun/xml/internal/messaging/saaj/client/p2p/LocalStrings_ja.properties
+ src/share/jaxws_classes/com/sun/xml/internal/messaging/saaj/client/p2p/LocalStrings_ko.properties
+ src/share/jaxws_classes/com/sun/xml/internal/messaging/saaj/client/p2p/LocalStrings_pt_BR.properties
+ src/share/jaxws_classes/com/sun/xml/internal/messaging/saaj/client/p2p/LocalStrings_zh_CN.properties
+ src/share/jaxws_classes/com/sun/xml/internal/messaging/saaj/client/p2p/LocalStrings_zh_TW.properties
! src/share/jaxws_classes/com/sun/xml/internal/messaging/saaj/packaging/mime/Header.java
! src/share/jaxws_classes/com/sun/xml/internal/messaging/saaj/packaging/mime/MessagingException.java
! src/share/jaxws_classes/com/sun/xml/internal/messaging/saaj/packaging/mime/MultipartDataSource.java
! src/share/jaxws_classes/com/sun/xml/internal/messaging/saaj/packaging/mime/internet/BMMimeMultipart.java
! src/share/jaxws_classes/com/sun/xml/internal/messaging/saaj/packaging/mime/internet/ContentDisposition.java
! src/share/jaxws_classes/com/sun/xml/internal/messaging/saaj/packaging/mime/internet/ContentType.java
! src/share/jaxws_classes/com/sun/xml/internal/messaging/saaj/packaging/mime/internet/HeaderTokenizer.java
! src/share/jaxws_classes/com/sun/xml/internal/messaging/saaj/packaging/mime/internet/InternetHeaders.java
! src/share/jaxws_classes/com/sun/xml/internal/messaging/saaj/packaging/mime/internet/MimeBodyPart.java
! src/share/jaxws_classes/com/sun/xml/internal/messaging/saaj/packaging/mime/internet/MimeMultipart.java
! src/share/jaxws_classes/com/sun/xml/internal/messaging/saaj/packaging/mime/internet/MimePartDataSource.java
! src/share/jaxws_classes/com/sun/xml/internal/messaging/saaj/packaging/mime/internet/MimePullMultipart.java
! src/share/jaxws_classes/com/sun/xml/internal/messaging/saaj/packaging/mime/internet/MimeUtility.java
! src/share/jaxws_classes/com/sun/xml/internal/messaging/saaj/packaging/mime/internet/ParameterList.java
! src/share/jaxws_classes/com/sun/xml/internal/messaging/saaj/packaging/mime/internet/ParseException.java
! src/share/jaxws_classes/com/sun/xml/internal/messaging/saaj/packaging/mime/internet/SharedInputStream.java
! src/share/jaxws_classes/com/sun/xml/internal/messaging/saaj/packaging/mime/internet/UniqueValue.java
! src/share/jaxws_classes/com/sun/xml/internal/messaging/saaj/packaging/mime/util/ASCIIUtility.java
! src/share/jaxws_classes/com/sun/xml/internal/messaging/saaj/packaging/mime/util/BASE64DecoderStream.java
! src/share/jaxws_classes/com/sun/xml/internal/messaging/saaj/packaging/mime/util/BASE64EncoderStream.java
! src/share/jaxws_classes/com/sun/xml/internal/messaging/saaj/packaging/mime/util/BEncoderStream.java
! src/share/jaxws_classes/com/sun/xml/internal/messaging/saaj/packaging/mime/util/LineInputStream.java
! src/share/jaxws_classes/com/sun/xml/internal/messaging/saaj/packaging/mime/util/OutputUtil.java
! src/share/jaxws_classes/com/sun/xml/internal/messaging/saaj/packaging/mime/util/QDecoderStream.java
! src/share/jaxws_classes/com/sun/xml/internal/messaging/saaj/packaging/mime/util/QEncoderStream.java
! src/share/jaxws_classes/com/sun/xml/internal/messaging/saaj/packaging/mime/util/QPDecoderStream.java
! src/share/jaxws_classes/com/sun/xml/internal/messaging/saaj/packaging/mime/util/QPEncoderStream.java
! src/share/jaxws_classes/com/sun/xml/internal/messaging/saaj/packaging/mime/util/UUDecoderStream.java
! src/share/jaxws_classes/com/sun/xml/internal/messaging/saaj/packaging/mime/util/UUEncoderStream.java
! src/share/jaxws_classes/com/sun/xml/internal/messaging/saaj/soap/AttachmentPartImpl.java
! src/share/jaxws_classes/com/sun/xml/internal/messaging/saaj/soap/Envelope.java
! src/share/jaxws_classes/com/sun/xml/internal/messaging/saaj/soap/EnvelopeFactory.java
! src/share/jaxws_classes/com/sun/xml/internal/messaging/saaj/soap/FastInfosetDataContentHandler.java
! src/share/jaxws_classes/com/sun/xml/internal/messaging/saaj/soap/GifDataContentHandler.java
! src/share/jaxws_classes/com/sun/xml/internal/messaging/saaj/soap/ImageDataContentHandler.java
! src/share/jaxws_classes/com/sun/xml/internal/messaging/saaj/soap/JpegDataContentHandler.java
! src/share/jaxws_classes/com/sun/xml/internal/messaging/saaj/soap/LocalStrings.properties
+ src/share/jaxws_classes/com/sun/xml/internal/messaging/saaj/soap/LocalStrings_de.properties
+ src/share/jaxws_classes/com/sun/xml/internal/messaging/saaj/soap/LocalStrings_es.properties
+ src/share/jaxws_classes/com/sun/xml/internal/messaging/saaj/soap/LocalStrings_fr.properties
+ src/share/jaxws_classes/com/sun/xml/internal/messaging/saaj/soap/LocalStrings_it.properties
+ src/share/jaxws_classes/com/sun/xml/internal/messaging/saaj/soap/LocalStrings_ja.properties
+ src/share/jaxws_classes/com/sun/xml/internal/messaging/saaj/soap/LocalStrings_ko.properties
+ src/share/jaxws_classes/com/sun/xml/internal/messaging/saaj/soap/LocalStrings_pt_BR.properties
+ src/share/jaxws_classes/com/sun/xml/internal/messaging/saaj/soap/LocalStrings_zh_CN.properties
+ src/share/jaxws_classes/com/sun/xml/internal/messaging/saaj/soap/LocalStrings_zh_TW.properties
! src/share/jaxws_classes/com/sun/xml/internal/messaging/saaj/soap/MessageFactoryImpl.java
! src/share/jaxws_classes/com/sun/xml/internal/messaging/saaj/soap/MessageImpl.java
! src/share/jaxws_classes/com/sun/xml/internal/messaging/saaj/soap/MultipartDataContentHandler.java
! src/share/jaxws_classes/com/sun/xml/internal/messaging/saaj/soap/SAAJMetaFactoryImpl.java
! src/share/jaxws_classes/com/sun/xml/internal/messaging/saaj/soap/SOAPDocument.java
! src/share/jaxws_classes/com/sun/xml/internal/messaging/saaj/soap/SOAPDocumentFragment.java
! src/share/jaxws_classes/com/sun/xml/internal/messaging/saaj/soap/SOAPDocumentImpl.java
! src/share/jaxws_classes/com/sun/xml/internal/messaging/saaj/soap/SOAPFactoryImpl.java
! src/share/jaxws_classes/com/sun/xml/internal/messaging/saaj/soap/SOAPIOException.java
! src/share/jaxws_classes/com/sun/xml/internal/messaging/saaj/soap/SOAPPartImpl.java
! src/share/jaxws_classes/com/sun/xml/internal/messaging/saaj/soap/SOAPVersionMismatchException.java
! src/share/jaxws_classes/com/sun/xml/internal/messaging/saaj/soap/StringDataContentHandler.java
! src/share/jaxws_classes/com/sun/xml/internal/messaging/saaj/soap/XmlDataContentHandler.java
! src/share/jaxws_classes/com/sun/xml/internal/messaging/saaj/soap/dynamic/SOAPFactoryDynamicImpl.java
! src/share/jaxws_classes/com/sun/xml/internal/messaging/saaj/soap/dynamic/SOAPMessageFactoryDynamicImpl.java
! src/share/jaxws_classes/com/sun/xml/internal/messaging/saaj/soap/impl/BodyElementImpl.java
! src/share/jaxws_classes/com/sun/xml/internal/messaging/saaj/soap/impl/BodyImpl.java
! src/share/jaxws_classes/com/sun/xml/internal/messaging/saaj/soap/impl/CDATAImpl.java
! src/share/jaxws_classes/com/sun/xml/internal/messaging/saaj/soap/impl/CommentImpl.java
! src/share/jaxws_classes/com/sun/xml/internal/messaging/saaj/soap/impl/DetailEntryImpl.java
! src/share/jaxws_classes/com/sun/xml/internal/messaging/saaj/soap/impl/DetailImpl.java
! src/share/jaxws_classes/com/sun/xml/internal/messaging/saaj/soap/impl/ElementFactory.java
! src/share/jaxws_classes/com/sun/xml/internal/messaging/saaj/soap/impl/ElementImpl.java
! src/share/jaxws_classes/com/sun/xml/internal/messaging/saaj/soap/impl/EnvelopeImpl.java
! src/share/jaxws_classes/com/sun/xml/internal/messaging/saaj/soap/impl/FaultElementImpl.java
! src/share/jaxws_classes/com/sun/xml/internal/messaging/saaj/soap/impl/FaultImpl.java
! src/share/jaxws_classes/com/sun/xml/internal/messaging/saaj/soap/impl/HeaderElementImpl.java
! src/share/jaxws_classes/com/sun/xml/internal/messaging/saaj/soap/impl/HeaderImpl.java
! src/share/jaxws_classes/com/sun/xml/internal/messaging/saaj/soap/impl/LocalStrings.properties
+ src/share/jaxws_classes/com/sun/xml/internal/messaging/saaj/soap/impl/LocalStrings_de.properties
+ src/share/jaxws_classes/com/sun/xml/internal/messaging/saaj/soap/impl/LocalStrings_es.properties
+ src/share/jaxws_classes/com/sun/xml/internal/messaging/saaj/soap/impl/LocalStrings_fr.properties
+ src/share/jaxws_classes/com/sun/xml/internal/messaging/saaj/soap/impl/LocalStrings_it.properties
+ src/share/jaxws_classes/com/sun/xml/internal/messaging/saaj/soap/impl/LocalStrings_ja.properties
+ src/share/jaxws_classes/com/sun/xml/internal/messaging/saaj/soap/impl/LocalStrings_ko.properties
+ src/share/jaxws_classes/com/sun/xml/internal/messaging/saaj/soap/impl/LocalStrings_pt_BR.properties
+ src/share/jaxws_classes/com/sun/xml/internal/messaging/saaj/soap/impl/LocalStrings_zh_CN.properties
+ src/share/jaxws_classes/com/sun/xml/internal/messaging/saaj/soap/impl/LocalStrings_zh_TW.properties
! src/share/jaxws_classes/com/sun/xml/internal/messaging/saaj/soap/impl/TextImpl.java
! src/share/jaxws_classes/com/sun/xml/internal/messaging/saaj/soap/impl/TreeException.java
! src/share/jaxws_classes/com/sun/xml/internal/messaging/saaj/soap/name/LocalStrings.properties
+ src/share/jaxws_classes/com/sun/xml/internal/messaging/saaj/soap/name/LocalStrings_de.properties
+ src/share/jaxws_classes/com/sun/xml/internal/messaging/saaj/soap/name/LocalStrings_es.properties
+ src/share/jaxws_classes/com/sun/xml/internal/messaging/saaj/soap/name/LocalStrings_fr.properties
+ src/share/jaxws_classes/com/sun/xml/internal/messaging/saaj/soap/name/LocalStrings_it.properties
+ src/share/jaxws_classes/com/sun/xml/internal/messaging/saaj/soap/name/LocalStrings_ja.properties
+ src/share/jaxws_classes/com/sun/xml/internal/messaging/saaj/soap/name/LocalStrings_ko.properties
+ src/share/jaxws_classes/com/sun/xml/internal/messaging/saaj/soap/name/LocalStrings_pt_BR.properties
+ src/share/jaxws_classes/com/sun/xml/internal/messaging/saaj/soap/name/LocalStrings_zh_CN.properties
+ src/share/jaxws_classes/com/sun/xml/internal/messaging/saaj/soap/name/LocalStrings_zh_TW.properties
! src/share/jaxws_classes/com/sun/xml/internal/messaging/saaj/soap/name/NameImpl.java
! src/share/jaxws_classes/com/sun/xml/internal/messaging/saaj/soap/ver1_1/Body1_1Impl.java
! src/share/jaxws_classes/com/sun/xml/internal/messaging/saaj/soap/ver1_1/BodyElement1_1Impl.java
! src/share/jaxws_classes/com/sun/xml/internal/messaging/saaj/soap/ver1_1/Detail1_1Impl.java
! src/share/jaxws_classes/com/sun/xml/internal/messaging/saaj/soap/ver1_1/DetailEntry1_1Impl.java
! src/share/jaxws_classes/com/sun/xml/internal/messaging/saaj/soap/ver1_1/Envelope1_1Impl.java
! src/share/jaxws_classes/com/sun/xml/internal/messaging/saaj/soap/ver1_1/Fault1_1Impl.java
! src/share/jaxws_classes/com/sun/xml/internal/messaging/saaj/soap/ver1_1/FaultElement1_1Impl.java
! src/share/jaxws_classes/com/sun/xml/internal/messaging/saaj/soap/ver1_1/Header1_1Impl.java
! src/share/jaxws_classes/com/sun/xml/internal/messaging/saaj/soap/ver1_1/HeaderElement1_1Impl.java
! src/share/jaxws_classes/com/sun/xml/internal/messaging/saaj/soap/ver1_1/LocalStrings.properties
+ src/share/jaxws_classes/com/sun/xml/internal/messaging/saaj/soap/ver1_1/LocalStrings_de.properties
+ src/share/jaxws_classes/com/sun/xml/internal/messaging/saaj/soap/ver1_1/LocalStrings_es.properties
+ src/share/jaxws_classes/com/sun/xml/internal/messaging/saaj/soap/ver1_1/LocalStrings_fr.properties
+ src/share/jaxws_classes/com/sun/xml/internal/messaging/saaj/soap/ver1_1/LocalStrings_it.properties
+ src/share/jaxws_classes/com/sun/xml/internal/messaging/saaj/soap/ver1_1/LocalStrings_ja.properties
+ src/share/jaxws_classes/com/sun/xml/internal/messaging/saaj/soap/ver1_1/LocalStrings_ko.properties
+ src/share/jaxws_classes/com/sun/xml/internal/messaging/saaj/soap/ver1_1/LocalStrings_pt_BR.properties
+ src/share/jaxws_classes/com/sun/xml/internal/messaging/saaj/soap/ver1_1/LocalStrings_zh_CN.properties
+ src/share/jaxws_classes/com/sun/xml/internal/messaging/saaj/soap/ver1_1/LocalStrings_zh_TW.properties
! src/share/jaxws_classes/com/sun/xml/internal/messaging/saaj/soap/ver1_1/Message1_1Impl.java
! src/share/jaxws_classes/com/sun/xml/internal/messaging/saaj/soap/ver1_1/SOAPFactory1_1Impl.java
! src/share/jaxws_classes/com/sun/xml/internal/messaging/saaj/soap/ver1_1/SOAPMessageFactory1_1Impl.java
! src/share/jaxws_classes/com/sun/xml/internal/messaging/saaj/soap/ver1_1/SOAPPart1_1Impl.java
! src/share/jaxws_classes/com/sun/xml/internal/messaging/saaj/soap/ver1_2/Body1_2Impl.java
! src/share/jaxws_classes/com/sun/xml/internal/messaging/saaj/soap/ver1_2/BodyElement1_2Impl.java
! src/share/jaxws_classes/com/sun/xml/internal/messaging/saaj/soap/ver1_2/Detail1_2Impl.java
! src/share/jaxws_classes/com/sun/xml/internal/messaging/saaj/soap/ver1_2/DetailEntry1_2Impl.java
! src/share/jaxws_classes/com/sun/xml/internal/messaging/saaj/soap/ver1_2/Envelope1_2Impl.java
! src/share/jaxws_classes/com/sun/xml/internal/messaging/saaj/soap/ver1_2/Fault1_2Impl.java
! src/share/jaxws_classes/com/sun/xml/internal/messaging/saaj/soap/ver1_2/FaultElement1_2Impl.java
! src/share/jaxws_classes/com/sun/xml/internal/messaging/saaj/soap/ver1_2/Header1_2Impl.java
! src/share/jaxws_classes/com/sun/xml/internal/messaging/saaj/soap/ver1_2/HeaderElement1_2Impl.java
! src/share/jaxws_classes/com/sun/xml/internal/messaging/saaj/soap/ver1_2/LocalStrings.properties
+ src/share/jaxws_classes/com/sun/xml/internal/messaging/saaj/soap/ver1_2/LocalStrings_de.properties
+ src/share/jaxws_classes/com/sun/xml/internal/messaging/saaj/soap/ver1_2/LocalStrings_es.properties
+ src/share/jaxws_classes/com/sun/xml/internal/messaging/saaj/soap/ver1_2/LocalStrings_fr.properties
+ src/share/jaxws_classes/com/sun/xml/internal/messaging/saaj/soap/ver1_2/LocalStrings_it.properties
+ src/share/jaxws_classes/com/sun/xml/internal/messaging/saaj/soap/ver1_2/LocalStrings_ja.properties
+ src/share/jaxws_classes/com/sun/xml/internal/messaging/saaj/soap/ver1_2/LocalStrings_ko.properties
+ src/share/jaxws_classes/com/sun/xml/internal/messaging/saaj/soap/ver1_2/LocalStrings_pt_BR.properties
+ src/share/jaxws_classes/com/sun/xml/internal/messaging/saaj/soap/ver1_2/LocalStrings_zh_CN.properties
+ src/share/jaxws_classes/com/sun/xml/internal/messaging/saaj/soap/ver1_2/LocalStrings_zh_TW.properties
! src/share/jaxws_classes/com/sun/xml/internal/messaging/saaj/soap/ver1_2/Message1_2Impl.java
! src/share/jaxws_classes/com/sun/xml/internal/messaging/saaj/soap/ver1_2/SOAPFactory1_2Impl.java
! src/share/jaxws_classes/com/sun/xml/internal/messaging/saaj/soap/ver1_2/SOAPMessageFactory1_2Impl.java
! src/share/jaxws_classes/com/sun/xml/internal/messaging/saaj/soap/ver1_2/SOAPPart1_2Impl.java
! src/share/jaxws_classes/com/sun/xml/internal/messaging/saaj/util/Base64.java
! src/share/jaxws_classes/com/sun/xml/internal/messaging/saaj/util/ByteInputStream.java
! src/share/jaxws_classes/com/sun/xml/internal/messaging/saaj/util/ByteOutputStream.java
! src/share/jaxws_classes/com/sun/xml/internal/messaging/saaj/util/CharReader.java
! src/share/jaxws_classes/com/sun/xml/internal/messaging/saaj/util/CharWriter.java
! src/share/jaxws_classes/com/sun/xml/internal/messaging/saaj/util/FastInfosetReflection.java
! src/share/jaxws_classes/com/sun/xml/internal/messaging/saaj/util/FinalArrayList.java
! src/share/jaxws_classes/com/sun/xml/internal/messaging/saaj/util/JAXMStreamSource.java
! src/share/jaxws_classes/com/sun/xml/internal/messaging/saaj/util/JaxmURI.java
! src/share/jaxws_classes/com/sun/xml/internal/messaging/saaj/util/LocalStrings.properties
+ src/share/jaxws_classes/com/sun/xml/internal/messaging/saaj/util/LocalStrings_de.properties
+ src/share/jaxws_classes/com/sun/xml/internal/messaging/saaj/util/LocalStrings_es.properties
+ src/share/jaxws_classes/com/sun/xml/internal/messaging/saaj/util/LocalStrings_fr.properties
+ src/share/jaxws_classes/com/sun/xml/internal/messaging/saaj/util/LocalStrings_it.properties
+ src/share/jaxws_classes/com/sun/xml/internal/messaging/saaj/util/LocalStrings_ja.properties
+ src/share/jaxws_classes/com/sun/xml/internal/messaging/saaj/util/LocalStrings_ko.properties
+ src/share/jaxws_classes/com/sun/xml/internal/messaging/saaj/util/LocalStrings_pt_BR.properties
+ src/share/jaxws_classes/com/sun/xml/internal/messaging/saaj/util/LocalStrings_zh_CN.properties
+ src/share/jaxws_classes/com/sun/xml/internal/messaging/saaj/util/LocalStrings_zh_TW.properties
! src/share/jaxws_classes/com/sun/xml/internal/messaging/saaj/util/LogDomainConstants.java
! src/share/jaxws_classes/com/sun/xml/internal/messaging/saaj/util/MimeHeadersUtil.java
! src/share/jaxws_classes/com/sun/xml/internal/messaging/saaj/util/NamespaceContextIterator.java
! src/share/jaxws_classes/com/sun/xml/internal/messaging/saaj/util/ParseUtil.java
! src/share/jaxws_classes/com/sun/xml/internal/messaging/saaj/util/ParserPool.java
! src/share/jaxws_classes/com/sun/xml/internal/messaging/saaj/util/RejectDoctypeSaxFilter.java
! src/share/jaxws_classes/com/sun/xml/internal/messaging/saaj/util/SAAJUtil.java
! src/share/jaxws_classes/com/sun/xml/internal/messaging/saaj/util/TeeInputStream.java
! src/share/jaxws_classes/com/sun/xml/internal/messaging/saaj/util/XMLDeclarationParser.java
! src/share/jaxws_classes/com/sun/xml/internal/messaging/saaj/util/transform/EfficientStreamingTransformer.java
+ src/share/jaxws_classes/com/sun/xml/internal/org/jvnet/mimepull/ASCIIUtility.java
+ src/share/jaxws_classes/com/sun/xml/internal/org/jvnet/mimepull/BASE64DecoderStream.java
! src/share/jaxws_classes/com/sun/xml/internal/org/jvnet/mimepull/Chunk.java
! src/share/jaxws_classes/com/sun/xml/internal/org/jvnet/mimepull/ChunkInputStream.java
! src/share/jaxws_classes/com/sun/xml/internal/org/jvnet/mimepull/CleanUpExecutorFactory.java
! src/share/jaxws_classes/com/sun/xml/internal/org/jvnet/mimepull/Data.java
! src/share/jaxws_classes/com/sun/xml/internal/org/jvnet/mimepull/DataFile.java
! src/share/jaxws_classes/com/sun/xml/internal/org/jvnet/mimepull/DataHead.java
+ src/share/jaxws_classes/com/sun/xml/internal/org/jvnet/mimepull/DecodingException.java
! src/share/jaxws_classes/com/sun/xml/internal/org/jvnet/mimepull/FactoryFinder.java
! src/share/jaxws_classes/com/sun/xml/internal/org/jvnet/mimepull/FileData.java
! src/share/jaxws_classes/com/sun/xml/internal/org/jvnet/mimepull/FinalArrayList.java
! src/share/jaxws_classes/com/sun/xml/internal/org/jvnet/mimepull/Header.java
! src/share/jaxws_classes/com/sun/xml/internal/org/jvnet/mimepull/InternetHeaders.java
+ src/share/jaxws_classes/com/sun/xml/internal/org/jvnet/mimepull/LineInputStream.java
! src/share/jaxws_classes/com/sun/xml/internal/org/jvnet/mimepull/MIMEConfig.java
! src/share/jaxws_classes/com/sun/xml/internal/org/jvnet/mimepull/MIMEEvent.java
! src/share/jaxws_classes/com/sun/xml/internal/org/jvnet/mimepull/MIMEMessage.java
! src/share/jaxws_classes/com/sun/xml/internal/org/jvnet/mimepull/MIMEParser.java
! src/share/jaxws_classes/com/sun/xml/internal/org/jvnet/mimepull/MIMEParsingException.java
! src/share/jaxws_classes/com/sun/xml/internal/org/jvnet/mimepull/MIMEPart.java
! src/share/jaxws_classes/com/sun/xml/internal/org/jvnet/mimepull/MemoryData.java
+ src/share/jaxws_classes/com/sun/xml/internal/org/jvnet/mimepull/MimeUtility.java
+ src/share/jaxws_classes/com/sun/xml/internal/org/jvnet/mimepull/PropUtil.java
+ src/share/jaxws_classes/com/sun/xml/internal/org/jvnet/mimepull/QPDecoderStream.java
+ src/share/jaxws_classes/com/sun/xml/internal/org/jvnet/mimepull/UUDecoderStream.java
! src/share/jaxws_classes/com/sun/xml/internal/org/jvnet/mimepull/WeakDataFile.java
! src/share/jaxws_classes/com/sun/xml/internal/org/jvnet/staxex/Base64Data.java
! src/share/jaxws_classes/com/sun/xml/internal/org/jvnet/staxex/XMLStreamReaderEx.java
- src/share/jaxws_classes/com/sun/xml/internal/org/jvnet/ws/EnvelopeStyle.java
- src/share/jaxws_classes/com/sun/xml/internal/org/jvnet/ws/EnvelopeStyleFeature.java
- src/share/jaxws_classes/com/sun/xml/internal/org/jvnet/ws/databinding/Databinding.java
- src/share/jaxws_classes/com/sun/xml/internal/org/jvnet/ws/databinding/DatabindingFactory.java
- src/share/jaxws_classes/com/sun/xml/internal/org/jvnet/ws/databinding/DatabindingMode.java
- src/share/jaxws_classes/com/sun/xml/internal/org/jvnet/ws/databinding/DatabindingModeFeature.java
- src/share/jaxws_classes/com/sun/xml/internal/org/jvnet/ws/databinding/JavaCallInfo.java
- src/share/jaxws_classes/com/sun/xml/internal/org/jvnet/ws/message/ContentType.java
- src/share/jaxws_classes/com/sun/xml/internal/org/jvnet/ws/message/DistributedPropertySet.java
- src/share/jaxws_classes/com/sun/xml/internal/org/jvnet/ws/message/MessageContext.java
- src/share/jaxws_classes/com/sun/xml/internal/org/jvnet/ws/message/MessageContextFactory.java
- src/share/jaxws_classes/com/sun/xml/internal/org/jvnet/ws/message/PropertySet.java
! src/share/jaxws_classes/com/sun/xml/internal/stream/buffer/AbstractCreator.java
! src/share/jaxws_classes/com/sun/xml/internal/stream/buffer/sax/SAXBufferProcessor.java
! src/share/jaxws_classes/com/sun/xml/internal/stream/buffer/stax/NamespaceContexHelper.java
! src/share/jaxws_classes/com/sun/xml/internal/stream/buffer/stax/StreamReaderBufferProcessor.java
! src/share/jaxws_classes/com/sun/xml/internal/stream/buffer/stax/StreamWriterBufferProcessor.java
! src/share/jaxws_classes/com/sun/xml/internal/ws/Closeable.java
! src/share/jaxws_classes/com/sun/xml/internal/ws/addressing/EPRSDDocumentFilter.java
! src/share/jaxws_classes/com/sun/xml/internal/ws/addressing/EndpointReferenceUtil.java
! src/share/jaxws_classes/com/sun/xml/internal/ws/addressing/ProblemAction.java
! src/share/jaxws_classes/com/sun/xml/internal/ws/addressing/ProblemHeaderQName.java
! src/share/jaxws_classes/com/sun/xml/internal/ws/addressing/W3CAddressingConstants.java
! src/share/jaxws_classes/com/sun/xml/internal/ws/addressing/W3CAddressingMetadataConstants.java
! src/share/jaxws_classes/com/sun/xml/internal/ws/addressing/W3CWsaClientTube.java
! src/share/jaxws_classes/com/sun/xml/internal/ws/addressing/W3CWsaServerTube.java
! src/share/jaxws_classes/com/sun/xml/internal/ws/addressing/WSEPRExtension.java
! src/share/jaxws_classes/com/sun/xml/internal/ws/addressing/WsaActionUtil.java
! src/share/jaxws_classes/com/sun/xml/internal/ws/addressing/WsaClientTube.java
! src/share/jaxws_classes/com/sun/xml/internal/ws/addressing/WsaPropertyBag.java
! src/share/jaxws_classes/com/sun/xml/internal/ws/addressing/WsaServerTube.java
! src/share/jaxws_classes/com/sun/xml/internal/ws/addressing/WsaTube.java
! src/share/jaxws_classes/com/sun/xml/internal/ws/addressing/WsaTubeHelper.java
! src/share/jaxws_classes/com/sun/xml/internal/ws/addressing/WsaTubeHelperImpl.java
! src/share/jaxws_classes/com/sun/xml/internal/ws/addressing/model/ActionNotSupportedException.java
! src/share/jaxws_classes/com/sun/xml/internal/ws/addressing/model/InvalidAddressingHeaderException.java
! src/share/jaxws_classes/com/sun/xml/internal/ws/addressing/model/MissingAddressingHeaderException.java
! src/share/jaxws_classes/com/sun/xml/internal/ws/addressing/policy/AddressingFeatureConfigurator.java
! src/share/jaxws_classes/com/sun/xml/internal/ws/addressing/policy/AddressingPolicyMapConfigurator.java
! src/share/jaxws_classes/com/sun/xml/internal/ws/addressing/policy/AddressingPolicyValidator.java
! src/share/jaxws_classes/com/sun/xml/internal/ws/addressing/policy/AddressingPrefixMapper.java
! src/share/jaxws_classes/com/sun/xml/internal/ws/addressing/v200408/MemberSubmissionAddressingConstants.java
! src/share/jaxws_classes/com/sun/xml/internal/ws/addressing/v200408/MemberSubmissionWsaClientTube.java
! src/share/jaxws_classes/com/sun/xml/internal/ws/addressing/v200408/MemberSubmissionWsaServerTube.java
! src/share/jaxws_classes/com/sun/xml/internal/ws/addressing/v200408/ProblemAction.java
! src/share/jaxws_classes/com/sun/xml/internal/ws/addressing/v200408/ProblemHeaderQName.java
! src/share/jaxws_classes/com/sun/xml/internal/ws/addressing/v200408/WsaTubeHelperImpl.java
! src/share/jaxws_classes/com/sun/xml/internal/ws/api/BindingID.java
! src/share/jaxws_classes/com/sun/xml/internal/ws/api/BindingIDFactory.java
! src/share/jaxws_classes/com/sun/xml/internal/ws/api/Cancelable.java
! src/share/jaxws_classes/com/sun/xml/internal/ws/api/Component.java
! src/share/jaxws_classes/com/sun/xml/internal/ws/api/ComponentEx.java
! src/share/jaxws_classes/com/sun/xml/internal/ws/api/ComponentFeature.java
! src/share/jaxws_classes/com/sun/xml/internal/ws/api/ComponentRegistry.java
+ src/share/jaxws_classes/com/sun/xml/internal/ws/api/ComponentsFeature.java
! src/share/jaxws_classes/com/sun/xml/internal/ws/api/DistributedPropertySet.java
! src/share/jaxws_classes/com/sun/xml/internal/ws/api/EndpointAddress.java
! src/share/jaxws_classes/com/sun/xml/internal/ws/api/FeatureConstructor.java
+ src/share/jaxws_classes/com/sun/xml/internal/ws/api/FeatureListValidator.java
+ src/share/jaxws_classes/com/sun/xml/internal/ws/api/FeatureListValidatorAnnotation.java
! src/share/jaxws_classes/com/sun/xml/internal/ws/api/ImpliesWebServiceFeature.java
! src/share/jaxws_classes/com/sun/xml/internal/ws/api/PropertySet.java
! src/share/jaxws_classes/com/sun/xml/internal/ws/api/ResourceLoader.java
! src/share/jaxws_classes/com/sun/xml/internal/ws/api/SOAPVersion.java
! src/share/jaxws_classes/com/sun/xml/internal/ws/api/ServiceSharedFeatureMarker.java
! src/share/jaxws_classes/com/sun/xml/internal/ws/api/WSBinding.java
! src/share/jaxws_classes/com/sun/xml/internal/ws/api/WSDLLocator.java
! src/share/jaxws_classes/com/sun/xml/internal/ws/api/WSFeatureList.java
! src/share/jaxws_classes/com/sun/xml/internal/ws/api/WSService.java
! src/share/jaxws_classes/com/sun/xml/internal/ws/api/WebServiceFeatureFactory.java
+ src/share/jaxws_classes/com/sun/xml/internal/ws/api/addressing/AddressingPropertySet.java
! src/share/jaxws_classes/com/sun/xml/internal/ws/api/addressing/AddressingVersion.java
! src/share/jaxws_classes/com/sun/xml/internal/ws/api/addressing/EPRHeader.java
! src/share/jaxws_classes/com/sun/xml/internal/ws/api/addressing/NonAnonymousResponseProcessor.java
! src/share/jaxws_classes/com/sun/xml/internal/ws/api/addressing/OneWayFeature.java
! src/share/jaxws_classes/com/sun/xml/internal/ws/api/addressing/OutboundReferenceParameterHeader.java
! src/share/jaxws_classes/com/sun/xml/internal/ws/api/addressing/WSEndpointReference.java
! src/share/jaxws_classes/com/sun/xml/internal/ws/api/addressing/package-info.java
! src/share/jaxws_classes/com/sun/xml/internal/ws/api/client/ClientPipelineHook.java
! src/share/jaxws_classes/com/sun/xml/internal/ws/api/client/SelectOptimalEncodingFeature.java
! src/share/jaxws_classes/com/sun/xml/internal/ws/api/client/ServiceInterceptor.java
! src/share/jaxws_classes/com/sun/xml/internal/ws/api/client/ServiceInterceptorFactory.java
+ src/share/jaxws_classes/com/sun/xml/internal/ws/api/client/ThrowableInPacketCompletionFeature.java
! src/share/jaxws_classes/com/sun/xml/internal/ws/api/client/WSPortInfo.java
! src/share/jaxws_classes/com/sun/xml/internal/ws/api/config/management/EndpointCreationAttributes.java
! src/share/jaxws_classes/com/sun/xml/internal/ws/api/config/management/ManagedEndpointFactory.java
! src/share/jaxws_classes/com/sun/xml/internal/ws/api/config/management/Reconfigurable.java
! src/share/jaxws_classes/com/sun/xml/internal/ws/api/config/management/policy/ManagedClientAssertion.java
! src/share/jaxws_classes/com/sun/xml/internal/ws/api/config/management/policy/ManagedServiceAssertion.java
! src/share/jaxws_classes/com/sun/xml/internal/ws/api/config/management/policy/ManagementAssertion.java
! src/share/jaxws_classes/com/sun/xml/internal/ws/api/databinding/ClientCallBridge.java
! src/share/jaxws_classes/com/sun/xml/internal/ws/api/databinding/Databinding.java
! src/share/jaxws_classes/com/sun/xml/internal/ws/api/databinding/DatabindingConfig.java
! src/share/jaxws_classes/com/sun/xml/internal/ws/api/databinding/DatabindingFactory.java
! src/share/jaxws_classes/com/sun/xml/internal/ws/api/databinding/EndpointCallBridge.java
! src/share/jaxws_classes/com/sun/xml/internal/ws/api/databinding/JavaCallInfo.java
! src/share/jaxws_classes/com/sun/xml/internal/ws/api/databinding/MappingInfo.java
! src/share/jaxws_classes/com/sun/xml/internal/ws/api/databinding/MetadataReader.java
! src/share/jaxws_classes/com/sun/xml/internal/ws/api/databinding/SoapBodyStyle.java
! src/share/jaxws_classes/com/sun/xml/internal/ws/api/databinding/WSDLGenInfo.java
! src/share/jaxws_classes/com/sun/xml/internal/ws/api/fastinfoset/FastInfosetFeature.java
! src/share/jaxws_classes/com/sun/xml/internal/ws/api/ha/HaInfo.java
! src/share/jaxws_classes/com/sun/xml/internal/ws/api/ha/StickyFeature.java
! src/share/jaxws_classes/com/sun/xml/internal/ws/api/handler/MessageHandler.java
! src/share/jaxws_classes/com/sun/xml/internal/ws/api/handler/MessageHandlerContext.java
+ src/share/jaxws_classes/com/sun/xml/internal/ws/api/message/AddressingUtils.java
! src/share/jaxws_classes/com/sun/xml/internal/ws/api/message/Attachment.java
! src/share/jaxws_classes/com/sun/xml/internal/ws/api/message/AttachmentEx.java
! src/share/jaxws_classes/com/sun/xml/internal/ws/api/message/AttachmentSet.java
! src/share/jaxws_classes/com/sun/xml/internal/ws/api/message/ExceptionHasMessage.java
! src/share/jaxws_classes/com/sun/xml/internal/ws/api/message/FilterMessageImpl.java
! src/share/jaxws_classes/com/sun/xml/internal/ws/api/message/Header.java
! src/share/jaxws_classes/com/sun/xml/internal/ws/api/message/HeaderList.java
! src/share/jaxws_classes/com/sun/xml/internal/ws/api/message/Headers.java
! src/share/jaxws_classes/com/sun/xml/internal/ws/api/message/Message.java
! src/share/jaxws_classes/com/sun/xml/internal/ws/api/message/MessageContextFactory.java
+ src/share/jaxws_classes/com/sun/xml/internal/ws/api/message/MessageHeaders.java
+ src/share/jaxws_classes/com/sun/xml/internal/ws/api/message/MessageMetadata.java
+ src/share/jaxws_classes/com/sun/xml/internal/ws/api/message/MessageWrapper.java
+ src/share/jaxws_classes/com/sun/xml/internal/ws/api/message/MessageWritable.java
! src/share/jaxws_classes/com/sun/xml/internal/ws/api/message/Messages.java
! src/share/jaxws_classes/com/sun/xml/internal/ws/api/message/Packet.java
! src/share/jaxws_classes/com/sun/xml/internal/ws/api/message/SuppressAutomaticWSARequestHeadersFeature.java
! src/share/jaxws_classes/com/sun/xml/internal/ws/api/message/package-info.java
! src/share/jaxws_classes/com/sun/xml/internal/ws/api/message/saaj/SAAJFactory.java
+ src/share/jaxws_classes/com/sun/xml/internal/ws/api/message/saaj/SAAJMessageHeaders.java
+ src/share/jaxws_classes/com/sun/xml/internal/ws/api/message/saaj/SaajStaxWriter.java
! src/share/jaxws_classes/com/sun/xml/internal/ws/api/message/stream/InputStreamMessage.java
! src/share/jaxws_classes/com/sun/xml/internal/ws/api/message/stream/StreamBasedMessage.java
! src/share/jaxws_classes/com/sun/xml/internal/ws/api/message/stream/XMLStreamReaderMessage.java
! src/share/jaxws_classes/com/sun/xml/internal/ws/api/model/CheckedException.java
! src/share/jaxws_classes/com/sun/xml/internal/ws/api/model/ExceptionType.java
! src/share/jaxws_classes/com/sun/xml/internal/ws/api/model/JavaMethod.java
! src/share/jaxws_classes/com/sun/xml/internal/ws/api/model/MEP.java
! src/share/jaxws_classes/com/sun/xml/internal/ws/api/model/Parameter.java
! src/share/jaxws_classes/com/sun/xml/internal/ws/api/model/ParameterBinding.java
! src/share/jaxws_classes/com/sun/xml/internal/ws/api/model/SEIModel.java
+ src/share/jaxws_classes/com/sun/xml/internal/ws/api/model/WSDLOperationMapping.java
! src/share/jaxws_classes/com/sun/xml/internal/ws/api/model/soap/SOAPBinding.java
! src/share/jaxws_classes/com/sun/xml/internal/ws/api/model/wsdl/WSDLBoundFault.java
! src/share/jaxws_classes/com/sun/xml/internal/ws/api/model/wsdl/WSDLBoundOperation.java
! src/share/jaxws_classes/com/sun/xml/internal/ws/api/model/wsdl/WSDLBoundPortType.java
! src/share/jaxws_classes/com/sun/xml/internal/ws/api/model/wsdl/WSDLDescriptorKind.java
! src/share/jaxws_classes/com/sun/xml/internal/ws/api/model/wsdl/WSDLExtensible.java
! src/share/jaxws_classes/com/sun/xml/internal/ws/api/model/wsdl/WSDLExtension.java
! src/share/jaxws_classes/com/sun/xml/internal/ws/api/model/wsdl/WSDLFault.java
! src/share/jaxws_classes/com/sun/xml/internal/ws/api/model/wsdl/WSDLFeaturedObject.java
! src/share/jaxws_classes/com/sun/xml/internal/ws/api/model/wsdl/WSDLInput.java
! src/share/jaxws_classes/com/sun/xml/internal/ws/api/model/wsdl/WSDLMessage.java
! src/share/jaxws_classes/com/sun/xml/internal/ws/api/model/wsdl/WSDLModel.java
! src/share/jaxws_classes/com/sun/xml/internal/ws/api/model/wsdl/WSDLObject.java
! src/share/jaxws_classes/com/sun/xml/internal/ws/api/model/wsdl/WSDLOperation.java
! src/share/jaxws_classes/com/sun/xml/internal/ws/api/model/wsdl/WSDLOutput.java
! src/share/jaxws_classes/com/sun/xml/internal/ws/api/model/wsdl/WSDLPart.java
! src/share/jaxws_classes/com/sun/xml/internal/ws/api/model/wsdl/WSDLPartDescriptor.java
! src/share/jaxws_classes/com/sun/xml/internal/ws/api/model/wsdl/WSDLPort.java
! src/share/jaxws_classes/com/sun/xml/internal/ws/api/model/wsdl/WSDLPortType.java
! src/share/jaxws_classes/com/sun/xml/internal/ws/api/model/wsdl/WSDLService.java
! src/share/jaxws_classes/com/sun/xml/internal/ws/api/package-info.java
! src/share/jaxws_classes/com/sun/xml/internal/ws/api/pipe/ClientPipeAssemblerContext.java
! src/share/jaxws_classes/com/sun/xml/internal/ws/api/pipe/ClientTubeAssemblerContext.java
! src/share/jaxws_classes/com/sun/xml/internal/ws/api/pipe/Codec.java
! src/share/jaxws_classes/com/sun/xml/internal/ws/api/pipe/Codecs.java
! src/share/jaxws_classes/com/sun/xml/internal/ws/api/pipe/ContentType.java
! src/share/jaxws_classes/com/sun/xml/internal/ws/api/pipe/Engine.java
! src/share/jaxws_classes/com/sun/xml/internal/ws/api/pipe/Fiber.java
! src/share/jaxws_classes/com/sun/xml/internal/ws/api/pipe/FiberContextSwitchInterceptor.java
! src/share/jaxws_classes/com/sun/xml/internal/ws/api/pipe/FiberContextSwitchInterceptorFactory.java
! src/share/jaxws_classes/com/sun/xml/internal/ws/api/pipe/NextAction.java
! src/share/jaxws_classes/com/sun/xml/internal/ws/api/pipe/Pipe.java
! src/share/jaxws_classes/com/sun/xml/internal/ws/api/pipe/PipeCloner.java
! src/share/jaxws_classes/com/sun/xml/internal/ws/api/pipe/PipeClonerImpl.java
! src/share/jaxws_classes/com/sun/xml/internal/ws/api/pipe/PipelineAssembler.java
! src/share/jaxws_classes/com/sun/xml/internal/ws/api/pipe/PipelineAssemblerFactory.java
! src/share/jaxws_classes/com/sun/xml/internal/ws/api/pipe/SOAPBindingCodec.java
! src/share/jaxws_classes/com/sun/xml/internal/ws/api/pipe/ServerPipeAssemblerContext.java
! src/share/jaxws_classes/com/sun/xml/internal/ws/api/pipe/ServerTubeAssemblerContext.java
! src/share/jaxws_classes/com/sun/xml/internal/ws/api/pipe/StreamSOAPCodec.java
! src/share/jaxws_classes/com/sun/xml/internal/ws/api/pipe/Stubs.java
! src/share/jaxws_classes/com/sun/xml/internal/ws/api/pipe/SyncStartForAsyncFeature.java
+ src/share/jaxws_classes/com/sun/xml/internal/ws/api/pipe/ThrowableContainerPropertySet.java
! src/share/jaxws_classes/com/sun/xml/internal/ws/api/pipe/TransportPipeFactory.java
! src/share/jaxws_classes/com/sun/xml/internal/ws/api/pipe/TransportTubeFactory.java
! src/share/jaxws_classes/com/sun/xml/internal/ws/api/pipe/Tube.java
! src/share/jaxws_classes/com/sun/xml/internal/ws/api/pipe/TubeCloner.java
! src/share/jaxws_classes/com/sun/xml/internal/ws/api/pipe/TubelineAssembler.java
! src/share/jaxws_classes/com/sun/xml/internal/ws/api/pipe/TubelineAssemblerFactory.java
! src/share/jaxws_classes/com/sun/xml/internal/ws/api/pipe/helper/AbstractFilterPipeImpl.java
! src/share/jaxws_classes/com/sun/xml/internal/ws/api/pipe/helper/AbstractFilterTubeImpl.java
! src/share/jaxws_classes/com/sun/xml/internal/ws/api/pipe/helper/AbstractPipeImpl.java
! src/share/jaxws_classes/com/sun/xml/internal/ws/api/pipe/helper/AbstractTubeImpl.java
! src/share/jaxws_classes/com/sun/xml/internal/ws/api/pipe/helper/PipeAdapter.java
! src/share/jaxws_classes/com/sun/xml/internal/ws/api/pipe/helper/package-info.java
! src/share/jaxws_classes/com/sun/xml/internal/ws/api/pipe/package-info.java
! src/share/jaxws_classes/com/sun/xml/internal/ws/api/policy/AlternativeSelector.java
! src/share/jaxws_classes/com/sun/xml/internal/ws/api/policy/ModelGenerator.java
! src/share/jaxws_classes/com/sun/xml/internal/ws/api/policy/ModelTranslator.java
! src/share/jaxws_classes/com/sun/xml/internal/ws/api/policy/ModelUnmarshaller.java
! src/share/jaxws_classes/com/sun/xml/internal/ws/api/policy/PolicyResolver.java
! src/share/jaxws_classes/com/sun/xml/internal/ws/api/policy/PolicyResolverFactory.java
! src/share/jaxws_classes/com/sun/xml/internal/ws/api/policy/SourceModel.java
! src/share/jaxws_classes/com/sun/xml/internal/ws/api/policy/ValidationProcessor.java
! src/share/jaxws_classes/com/sun/xml/internal/ws/api/policy/subject/BindingSubject.java
! src/share/jaxws_classes/com/sun/xml/internal/ws/api/server/AbstractInstanceResolver.java
! src/share/jaxws_classes/com/sun/xml/internal/ws/api/server/AbstractServerAsyncTransport.java
! src/share/jaxws_classes/com/sun/xml/internal/ws/api/server/Adapter.java
! src/share/jaxws_classes/com/sun/xml/internal/ws/api/server/AsyncProvider.java
! src/share/jaxws_classes/com/sun/xml/internal/ws/api/server/AsyncProviderCallback.java
! src/share/jaxws_classes/com/sun/xml/internal/ws/api/server/BoundEndpoint.java
! src/share/jaxws_classes/com/sun/xml/internal/ws/api/server/Container.java
! src/share/jaxws_classes/com/sun/xml/internal/ws/api/server/ContainerResolver.java
! src/share/jaxws_classes/com/sun/xml/internal/ws/api/server/DocumentAddressResolver.java
! src/share/jaxws_classes/com/sun/xml/internal/ws/api/server/EndpointAwareCodec.java
! src/share/jaxws_classes/com/sun/xml/internal/ws/api/server/EndpointComponent.java
! src/share/jaxws_classes/com/sun/xml/internal/ws/api/server/EndpointData.java
! src/share/jaxws_classes/com/sun/xml/internal/ws/api/server/EndpointReferenceExtensionContributor.java
! src/share/jaxws_classes/com/sun/xml/internal/ws/api/server/HttpEndpoint.java
! src/share/jaxws_classes/com/sun/xml/internal/ws/api/server/InstanceResolver.java
! src/share/jaxws_classes/com/sun/xml/internal/ws/api/server/InstanceResolverAnnotation.java
! src/share/jaxws_classes/com/sun/xml/internal/ws/api/server/Invoker.java
! src/share/jaxws_classes/com/sun/xml/internal/ws/api/server/LazyMOMProvider.java
! src/share/jaxws_classes/com/sun/xml/internal/ws/api/server/Module.java
! src/share/jaxws_classes/com/sun/xml/internal/ws/api/server/PortAddressResolver.java
+ src/share/jaxws_classes/com/sun/xml/internal/ws/api/server/ProviderInvokerTubeFactory.java
! src/share/jaxws_classes/com/sun/xml/internal/ws/api/server/ResourceInjector.java
! src/share/jaxws_classes/com/sun/xml/internal/ws/api/server/SDDocument.java
! src/share/jaxws_classes/com/sun/xml/internal/ws/api/server/SDDocumentFilter.java
! src/share/jaxws_classes/com/sun/xml/internal/ws/api/server/SDDocumentSource.java
! src/share/jaxws_classes/com/sun/xml/internal/ws/api/server/ServerPipelineHook.java
! src/share/jaxws_classes/com/sun/xml/internal/ws/api/server/ServiceDefinition.java
+ src/share/jaxws_classes/com/sun/xml/internal/ws/api/server/ThreadLocalContainerResolver.java
! src/share/jaxws_classes/com/sun/xml/internal/ws/api/server/TransportBackChannel.java
! src/share/jaxws_classes/com/sun/xml/internal/ws/api/server/WSEndpoint.java
! src/share/jaxws_classes/com/sun/xml/internal/ws/api/server/WSWebServiceContext.java
! src/share/jaxws_classes/com/sun/xml/internal/ws/api/server/WebModule.java
! src/share/jaxws_classes/com/sun/xml/internal/ws/api/server/WebServiceContextDelegate.java
! src/share/jaxws_classes/com/sun/xml/internal/ws/api/server/package-info.java
! src/share/jaxws_classes/com/sun/xml/internal/ws/api/streaming/XMLStreamReaderFactory.java
! src/share/jaxws_classes/com/sun/xml/internal/ws/api/streaming/XMLStreamWriterFactory.java
! src/share/jaxws_classes/com/sun/xml/internal/ws/api/wsdl/parser/MetaDataResolver.java
! src/share/jaxws_classes/com/sun/xml/internal/ws/api/wsdl/parser/MetadataResolverFactory.java
! src/share/jaxws_classes/com/sun/xml/internal/ws/api/wsdl/parser/PolicyWSDLParserExtension.java
! src/share/jaxws_classes/com/sun/xml/internal/ws/api/wsdl/parser/ServiceDescriptor.java
! src/share/jaxws_classes/com/sun/xml/internal/ws/api/wsdl/parser/WSDLParserExtension.java
! src/share/jaxws_classes/com/sun/xml/internal/ws/api/wsdl/parser/WSDLParserExtensionContext.java
! src/share/jaxws_classes/com/sun/xml/internal/ws/api/wsdl/parser/XMLEntityResolver.java
! src/share/jaxws_classes/com/sun/xml/internal/ws/api/wsdl/parser/package-info.java
! src/share/jaxws_classes/com/sun/xml/internal/ws/api/wsdl/writer/WSDLGenExtnContext.java
! src/share/jaxws_classes/com/sun/xml/internal/ws/api/wsdl/writer/WSDLGeneratorExtension.java
+ src/share/jaxws_classes/com/sun/xml/internal/ws/assembler/DefaultClientTubelineAssemblyContext.java
+ src/share/jaxws_classes/com/sun/xml/internal/ws/assembler/DefaultServerTubelineAssemblyContext.java
+ src/share/jaxws_classes/com/sun/xml/internal/ws/assembler/MetroConfigLoader.java
+ src/share/jaxws_classes/com/sun/xml/internal/ws/assembler/MetroConfigName.java
+ src/share/jaxws_classes/com/sun/xml/internal/ws/assembler/MetroConfigNameImpl.java
+ src/share/jaxws_classes/com/sun/xml/internal/ws/assembler/MetroTubelineAssembler.java
+ src/share/jaxws_classes/com/sun/xml/internal/ws/assembler/TubeCreator.java
+ src/share/jaxws_classes/com/sun/xml/internal/ws/assembler/TubelineAssemblyContextImpl.java
+ src/share/jaxws_classes/com/sun/xml/internal/ws/assembler/TubelineAssemblyController.java
+ src/share/jaxws_classes/com/sun/xml/internal/ws/assembler/dev/ClientTubelineAssemblyContext.java
+ src/share/jaxws_classes/com/sun/xml/internal/ws/assembler/dev/ServerTubelineAssemblyContext.java
+ src/share/jaxws_classes/com/sun/xml/internal/ws/assembler/dev/TubeFactory.java
+ src/share/jaxws_classes/com/sun/xml/internal/ws/assembler/dev/TubelineAssemblyContext.java
+ src/share/jaxws_classes/com/sun/xml/internal/ws/assembler/dev/TubelineAssemblyContextUpdater.java
+ src/share/jaxws_classes/com/sun/xml/internal/ws/assembler/dev/TubelineAssemblyDecorator.java
+ src/share/jaxws_classes/com/sun/xml/internal/ws/assembler/jaxws-tubes-default.xml
+ src/share/jaxws_classes/com/sun/xml/internal/ws/assembler/jaxws/AddressingTubeFactory.java
+ src/share/jaxws_classes/com/sun/xml/internal/ws/assembler/jaxws/BasicTransportTubeFactory.java
+ src/share/jaxws_classes/com/sun/xml/internal/ws/assembler/jaxws/HandlerTubeFactory.java
+ src/share/jaxws_classes/com/sun/xml/internal/ws/assembler/jaxws/MonitoringTubeFactory.java
+ src/share/jaxws_classes/com/sun/xml/internal/ws/assembler/jaxws/MustUnderstandTubeFactory.java
+ src/share/jaxws_classes/com/sun/xml/internal/ws/assembler/jaxws/TerminalTubeFactory.java
+ src/share/jaxws_classes/com/sun/xml/internal/ws/assembler/jaxws/ValidationTubeFactory.java
! src/share/jaxws_classes/com/sun/xml/internal/ws/binding/BindingImpl.java
! src/share/jaxws_classes/com/sun/xml/internal/ws/binding/FeatureListUtil.java
! src/share/jaxws_classes/com/sun/xml/internal/ws/binding/HTTPBindingImpl.java
! src/share/jaxws_classes/com/sun/xml/internal/ws/binding/SOAPBindingImpl.java
! src/share/jaxws_classes/com/sun/xml/internal/ws/binding/WebServiceFeatureList.java
! src/share/jaxws_classes/com/sun/xml/internal/ws/client/AsyncInvoker.java
! src/share/jaxws_classes/com/sun/xml/internal/ws/client/AsyncResponseImpl.java
! src/share/jaxws_classes/com/sun/xml/internal/ws/client/BindingProviderProperties.java
! src/share/jaxws_classes/com/sun/xml/internal/ws/client/ClientContainer.java
! src/share/jaxws_classes/com/sun/xml/internal/ws/client/ClientSchemaValidationTube.java
! src/share/jaxws_classes/com/sun/xml/internal/ws/client/ClientTransportException.java
! src/share/jaxws_classes/com/sun/xml/internal/ws/client/ContentNegotiation.java
! src/share/jaxws_classes/com/sun/xml/internal/ws/client/HandlerConfiguration.java
! src/share/jaxws_classes/com/sun/xml/internal/ws/client/HandlerConfigurator.java
! src/share/jaxws_classes/com/sun/xml/internal/ws/client/MonitorRootClient.java
! src/share/jaxws_classes/com/sun/xml/internal/ws/client/PortInfo.java
! src/share/jaxws_classes/com/sun/xml/internal/ws/client/RequestContext.java
! src/share/jaxws_classes/com/sun/xml/internal/ws/client/ResponseContext.java
! src/share/jaxws_classes/com/sun/xml/internal/ws/client/ResponseContextReceiver.java
! src/share/jaxws_classes/com/sun/xml/internal/ws/client/SCAnnotations.java
! src/share/jaxws_classes/com/sun/xml/internal/ws/client/SEIPortInfo.java
! src/share/jaxws_classes/com/sun/xml/internal/ws/client/SenderException.java
! src/share/jaxws_classes/com/sun/xml/internal/ws/client/Stub.java
! src/share/jaxws_classes/com/sun/xml/internal/ws/client/WSServiceDelegate.java
! src/share/jaxws_classes/com/sun/xml/internal/ws/client/dispatch/DataSourceDispatch.java
! src/share/jaxws_classes/com/sun/xml/internal/ws/client/dispatch/DispatchImpl.java
! src/share/jaxws_classes/com/sun/xml/internal/ws/client/dispatch/JAXBDispatch.java
! src/share/jaxws_classes/com/sun/xml/internal/ws/client/dispatch/MessageDispatch.java
! src/share/jaxws_classes/com/sun/xml/internal/ws/client/dispatch/PacketDispatch.java
! src/share/jaxws_classes/com/sun/xml/internal/ws/client/dispatch/RESTSourceDispatch.java
! src/share/jaxws_classes/com/sun/xml/internal/ws/client/dispatch/SOAPMessageDispatch.java
! src/share/jaxws_classes/com/sun/xml/internal/ws/client/dispatch/SOAPSourceDispatch.java
! src/share/jaxws_classes/com/sun/xml/internal/ws/client/package-info.java
! src/share/jaxws_classes/com/sun/xml/internal/ws/client/sei/AsyncMethodHandler.java
! src/share/jaxws_classes/com/sun/xml/internal/ws/client/sei/BodyBuilder.java
! src/share/jaxws_classes/com/sun/xml/internal/ws/client/sei/CallbackMethodHandler.java
! src/share/jaxws_classes/com/sun/xml/internal/ws/client/sei/MessageFiller.java
! src/share/jaxws_classes/com/sun/xml/internal/ws/client/sei/MethodHandler.java
! src/share/jaxws_classes/com/sun/xml/internal/ws/client/sei/PollingMethodHandler.java
! src/share/jaxws_classes/com/sun/xml/internal/ws/client/sei/ResponseBuilder.java
! src/share/jaxws_classes/com/sun/xml/internal/ws/client/sei/SEIMethodHandler.java
! src/share/jaxws_classes/com/sun/xml/internal/ws/client/sei/SEIStub.java
! src/share/jaxws_classes/com/sun/xml/internal/ws/client/sei/StubAsyncHandler.java
! src/share/jaxws_classes/com/sun/xml/internal/ws/client/sei/StubHandler.java
! src/share/jaxws_classes/com/sun/xml/internal/ws/client/sei/SyncMethodHandler.java
! src/share/jaxws_classes/com/sun/xml/internal/ws/client/sei/ValueGetter.java
! src/share/jaxws_classes/com/sun/xml/internal/ws/client/sei/ValueGetterFactory.java
! src/share/jaxws_classes/com/sun/xml/internal/ws/client/sei/ValueSetter.java
! src/share/jaxws_classes/com/sun/xml/internal/ws/client/sei/ValueSetterFactory.java
! src/share/jaxws_classes/com/sun/xml/internal/ws/client/sei/pacakge-info.java
+ src/share/jaxws_classes/com/sun/xml/internal/ws/commons/xmlutil/Converter.java
! src/share/jaxws_classes/com/sun/xml/internal/ws/config/management/policy/ManagementAssertionCreator.java
! src/share/jaxws_classes/com/sun/xml/internal/ws/config/management/policy/ManagementPolicyValidator.java
! src/share/jaxws_classes/com/sun/xml/internal/ws/config/management/policy/ManagementPrefixMapper.java
+ src/share/jaxws_classes/com/sun/xml/internal/ws/config/metro/dev/FeatureReader.java
+ src/share/jaxws_classes/com/sun/xml/internal/ws/config/metro/util/ParserUtil.java
! src/share/jaxws_classes/com/sun/xml/internal/ws/db/DatabindingFactoryImpl.java
! src/share/jaxws_classes/com/sun/xml/internal/ws/db/DatabindingImpl.java
! src/share/jaxws_classes/com/sun/xml/internal/ws/db/DatabindingProviderImpl.java
! src/share/jaxws_classes/com/sun/xml/internal/ws/db/glassfish/BridgeWrapper.java
! src/share/jaxws_classes/com/sun/xml/internal/ws/db/glassfish/JAXBRIContextFactory.java
! src/share/jaxws_classes/com/sun/xml/internal/ws/db/glassfish/JAXBRIContextWrapper.java
! src/share/jaxws_classes/com/sun/xml/internal/ws/db/glassfish/MarshallerBridge.java
! src/share/jaxws_classes/com/sun/xml/internal/ws/db/glassfish/RawAccessorWrapper.java
! src/share/jaxws_classes/com/sun/xml/internal/ws/db/glassfish/WrapperBridge.java
! src/share/jaxws_classes/com/sun/xml/internal/ws/developer/BindingTypeFeature.java
! src/share/jaxws_classes/com/sun/xml/internal/ws/developer/EPRRecipe.java
! src/share/jaxws_classes/com/sun/xml/internal/ws/developer/HttpConfigFeature.java
! src/share/jaxws_classes/com/sun/xml/internal/ws/developer/JAXBContextFactory.java
! src/share/jaxws_classes/com/sun/xml/internal/ws/developer/JAXWSProperties.java
! src/share/jaxws_classes/com/sun/xml/internal/ws/developer/MemberSubmissionAddressing.java
! src/share/jaxws_classes/com/sun/xml/internal/ws/developer/MemberSubmissionAddressingFeature.java
! src/share/jaxws_classes/com/sun/xml/internal/ws/developer/MemberSubmissionEndpointReference.java
! src/share/jaxws_classes/com/sun/xml/internal/ws/developer/SchemaValidation.java
! src/share/jaxws_classes/com/sun/xml/internal/ws/developer/SchemaValidationFeature.java
! src/share/jaxws_classes/com/sun/xml/internal/ws/developer/Serialization.java
! src/share/jaxws_classes/com/sun/xml/internal/ws/developer/SerializationFeature.java
! src/share/jaxws_classes/com/sun/xml/internal/ws/developer/ServerSideException.java
! src/share/jaxws_classes/com/sun/xml/internal/ws/developer/StreamingAttachment.java
! src/share/jaxws_classes/com/sun/xml/internal/ws/developer/StreamingAttachmentFeature.java
! src/share/jaxws_classes/com/sun/xml/internal/ws/developer/StreamingDataHandler.java
! src/share/jaxws_classes/com/sun/xml/internal/ws/developer/UsesJAXBContext.java
! src/share/jaxws_classes/com/sun/xml/internal/ws/developer/UsesJAXBContextFeature.java
! src/share/jaxws_classes/com/sun/xml/internal/ws/developer/ValidationErrorHandler.java
! src/share/jaxws_classes/com/sun/xml/internal/ws/developer/WSBindingProvider.java
! src/share/jaxws_classes/com/sun/xml/internal/ws/developer/package-info.java
+ src/share/jaxws_classes/com/sun/xml/internal/ws/dump/LoggingDumpTube.java
+ src/share/jaxws_classes/com/sun/xml/internal/ws/dump/MessageDumper.java
+ src/share/jaxws_classes/com/sun/xml/internal/ws/dump/MessageDumping.java
+ src/share/jaxws_classes/com/sun/xml/internal/ws/dump/MessageDumpingFeature.java
+ src/share/jaxws_classes/com/sun/xml/internal/ws/dump/MessageDumpingTube.java
+ src/share/jaxws_classes/com/sun/xml/internal/ws/dump/MessageDumpingTubeFactory.java
! src/share/jaxws_classes/com/sun/xml/internal/ws/encoding/ContentType.java
! src/share/jaxws_classes/com/sun/xml/internal/ws/encoding/ContentTypeImpl.java
! src/share/jaxws_classes/com/sun/xml/internal/ws/encoding/DataHandlerDataSource.java
! src/share/jaxws_classes/com/sun/xml/internal/ws/encoding/DataSourceStreamingDataHandler.java
! src/share/jaxws_classes/com/sun/xml/internal/ws/encoding/HasEncoding.java
! src/share/jaxws_classes/com/sun/xml/internal/ws/encoding/HeaderTokenizer.java
! src/share/jaxws_classes/com/sun/xml/internal/ws/encoding/ImageDataContentHandler.java
! src/share/jaxws_classes/com/sun/xml/internal/ws/encoding/MIMEPartStreamingDataHandler.java
! src/share/jaxws_classes/com/sun/xml/internal/ws/encoding/MimeCodec.java
! src/share/jaxws_classes/com/sun/xml/internal/ws/encoding/MimeMultipartParser.java
! src/share/jaxws_classes/com/sun/xml/internal/ws/encoding/MtomCodec.java
! src/share/jaxws_classes/com/sun/xml/internal/ws/encoding/ParameterList.java
! src/share/jaxws_classes/com/sun/xml/internal/ws/encoding/RootOnlyCodec.java
! src/share/jaxws_classes/com/sun/xml/internal/ws/encoding/SOAPBindingCodec.java
! src/share/jaxws_classes/com/sun/xml/internal/ws/encoding/StreamSOAP11Codec.java
! src/share/jaxws_classes/com/sun/xml/internal/ws/encoding/StreamSOAP12Codec.java
! src/share/jaxws_classes/com/sun/xml/internal/ws/encoding/StreamSOAPCodec.java
! src/share/jaxws_classes/com/sun/xml/internal/ws/encoding/StringDataContentHandler.java
! src/share/jaxws_classes/com/sun/xml/internal/ws/encoding/SwACodec.java
! src/share/jaxws_classes/com/sun/xml/internal/ws/encoding/TagInfoset.java
! src/share/jaxws_classes/com/sun/xml/internal/ws/encoding/XMLHTTPBindingCodec.java
! src/share/jaxws_classes/com/sun/xml/internal/ws/encoding/XmlDataContentHandler.java
! src/share/jaxws_classes/com/sun/xml/internal/ws/encoding/fastinfoset/FastInfosetCodec.java
! src/share/jaxws_classes/com/sun/xml/internal/ws/encoding/fastinfoset/FastInfosetMIMETypes.java
! src/share/jaxws_classes/com/sun/xml/internal/ws/encoding/fastinfoset/FastInfosetStreamReaderFactory.java
! src/share/jaxws_classes/com/sun/xml/internal/ws/encoding/fastinfoset/FastInfosetStreamReaderRecyclable.java
! src/share/jaxws_classes/com/sun/xml/internal/ws/encoding/fastinfoset/FastInfosetStreamSOAP11Codec.java
! src/share/jaxws_classes/com/sun/xml/internal/ws/encoding/fastinfoset/FastInfosetStreamSOAP12Codec.java
! src/share/jaxws_classes/com/sun/xml/internal/ws/encoding/fastinfoset/FastInfosetStreamSOAPCodec.java
! src/share/jaxws_classes/com/sun/xml/internal/ws/encoding/policy/EncodingConstants.java
! src/share/jaxws_classes/com/sun/xml/internal/ws/encoding/policy/EncodingPolicyValidator.java
! src/share/jaxws_classes/com/sun/xml/internal/ws/encoding/policy/EncodingPrefixMapper.java
! src/share/jaxws_classes/com/sun/xml/internal/ws/encoding/policy/FastInfosetFeatureConfigurator.java
! src/share/jaxws_classes/com/sun/xml/internal/ws/encoding/policy/MtomFeatureConfigurator.java
! src/share/jaxws_classes/com/sun/xml/internal/ws/encoding/policy/MtomPolicyMapConfigurator.java
! src/share/jaxws_classes/com/sun/xml/internal/ws/encoding/policy/SelectOptimalEncodingFeatureConfigurator.java
! src/share/jaxws_classes/com/sun/xml/internal/ws/encoding/soap/DeserializationException.java
! src/share/jaxws_classes/com/sun/xml/internal/ws/encoding/soap/SOAP12Constants.java
! src/share/jaxws_classes/com/sun/xml/internal/ws/encoding/soap/SOAPConstants.java
! src/share/jaxws_classes/com/sun/xml/internal/ws/encoding/soap/SerializationException.java
! src/share/jaxws_classes/com/sun/xml/internal/ws/encoding/soap/SerializerConstants.java
! src/share/jaxws_classes/com/sun/xml/internal/ws/encoding/soap/streaming/SOAP12NamespaceConstants.java
! src/share/jaxws_classes/com/sun/xml/internal/ws/encoding/soap/streaming/SOAPNamespaceConstants.java
! src/share/jaxws_classes/com/sun/xml/internal/ws/encoding/xml/XMLCodec.java
! src/share/jaxws_classes/com/sun/xml/internal/ws/encoding/xml/XMLConstants.java
! src/share/jaxws_classes/com/sun/xml/internal/ws/encoding/xml/XMLMessage.java
! src/share/jaxws_classes/com/sun/xml/internal/ws/encoding/xml/XMLPropertyBag.java
! src/share/jaxws_classes/com/sun/xml/internal/ws/fault/CodeType.java
! src/share/jaxws_classes/com/sun/xml/internal/ws/fault/DetailType.java
! src/share/jaxws_classes/com/sun/xml/internal/ws/fault/ExceptionBean.java
! src/share/jaxws_classes/com/sun/xml/internal/ws/fault/ReasonType.java
! src/share/jaxws_classes/com/sun/xml/internal/ws/fault/SOAP11Fault.java
! src/share/jaxws_classes/com/sun/xml/internal/ws/fault/SOAP12Fault.java
! src/share/jaxws_classes/com/sun/xml/internal/ws/fault/SOAPFaultBuilder.java
! src/share/jaxws_classes/com/sun/xml/internal/ws/fault/ServerSOAPFaultException.java
! src/share/jaxws_classes/com/sun/xml/internal/ws/fault/SubcodeType.java
! src/share/jaxws_classes/com/sun/xml/internal/ws/fault/TextType.java
! src/share/jaxws_classes/com/sun/xml/internal/ws/handler/ClientLogicalHandlerTube.java
! src/share/jaxws_classes/com/sun/xml/internal/ws/handler/ClientMessageHandlerTube.java
! src/share/jaxws_classes/com/sun/xml/internal/ws/handler/ClientSOAPHandlerTube.java
! src/share/jaxws_classes/com/sun/xml/internal/ws/handler/HandlerChainsModel.java
! src/share/jaxws_classes/com/sun/xml/internal/ws/handler/HandlerException.java
! src/share/jaxws_classes/com/sun/xml/internal/ws/handler/HandlerProcessor.java
! src/share/jaxws_classes/com/sun/xml/internal/ws/handler/HandlerTube.java
! src/share/jaxws_classes/com/sun/xml/internal/ws/handler/LogicalMessageContextImpl.java
! src/share/jaxws_classes/com/sun/xml/internal/ws/handler/LogicalMessageImpl.java
! src/share/jaxws_classes/com/sun/xml/internal/ws/handler/MessageContextImpl.java
! src/share/jaxws_classes/com/sun/xml/internal/ws/handler/MessageHandlerContextImpl.java
! src/share/jaxws_classes/com/sun/xml/internal/ws/handler/MessageUpdatableContext.java
! src/share/jaxws_classes/com/sun/xml/internal/ws/handler/PortInfoImpl.java
! src/share/jaxws_classes/com/sun/xml/internal/ws/handler/SOAPHandlerProcessor.java
! src/share/jaxws_classes/com/sun/xml/internal/ws/handler/SOAPMessageContextImpl.java
! src/share/jaxws_classes/com/sun/xml/internal/ws/handler/ServerLogicalHandlerTube.java
! src/share/jaxws_classes/com/sun/xml/internal/ws/handler/ServerMessageHandlerTube.java
! src/share/jaxws_classes/com/sun/xml/internal/ws/handler/ServerSOAPHandlerTube.java
! src/share/jaxws_classes/com/sun/xml/internal/ws/handler/XMLHandlerProcessor.java
! src/share/jaxws_classes/com/sun/xml/internal/ws/message/AbstractHeaderImpl.java
! src/share/jaxws_classes/com/sun/xml/internal/ws/message/AbstractMessageImpl.java
! src/share/jaxws_classes/com/sun/xml/internal/ws/message/AttachmentSetImpl.java
! src/share/jaxws_classes/com/sun/xml/internal/ws/message/AttachmentUnmarshallerImpl.java
! src/share/jaxws_classes/com/sun/xml/internal/ws/message/ByteArrayAttachment.java
! src/share/jaxws_classes/com/sun/xml/internal/ws/message/DOMHeader.java
! src/share/jaxws_classes/com/sun/xml/internal/ws/message/DOMMessage.java
! src/share/jaxws_classes/com/sun/xml/internal/ws/message/DataHandlerAttachment.java
! src/share/jaxws_classes/com/sun/xml/internal/ws/message/EmptyMessageImpl.java
! src/share/jaxws_classes/com/sun/xml/internal/ws/message/FaultDetailHeader.java
! src/share/jaxws_classes/com/sun/xml/internal/ws/message/FaultMessage.java
! src/share/jaxws_classes/com/sun/xml/internal/ws/message/JAXBAttachment.java
! src/share/jaxws_classes/com/sun/xml/internal/ws/message/MimeAttachmentSet.java
! src/share/jaxws_classes/com/sun/xml/internal/ws/message/PayloadElementSniffer.java
! src/share/jaxws_classes/com/sun/xml/internal/ws/message/ProblemActionHeader.java
! src/share/jaxws_classes/com/sun/xml/internal/ws/message/RelatesToHeader.java
! src/share/jaxws_classes/com/sun/xml/internal/ws/message/RootElementSniffer.java
! src/share/jaxws_classes/com/sun/xml/internal/ws/message/StringHeader.java
! src/share/jaxws_classes/com/sun/xml/internal/ws/message/Util.java
! src/share/jaxws_classes/com/sun/xml/internal/ws/message/XMLReaderImpl.java
! src/share/jaxws_classes/com/sun/xml/internal/ws/message/jaxb/AttachmentMarshallerImpl.java
! src/share/jaxws_classes/com/sun/xml/internal/ws/message/jaxb/JAXBBridgeSource.java
! src/share/jaxws_classes/com/sun/xml/internal/ws/message/jaxb/JAXBDispatchMessage.java
! src/share/jaxws_classes/com/sun/xml/internal/ws/message/jaxb/JAXBHeader.java
! src/share/jaxws_classes/com/sun/xml/internal/ws/message/jaxb/JAXBMessage.java
! src/share/jaxws_classes/com/sun/xml/internal/ws/message/jaxb/MarshallerBridge.java
! src/share/jaxws_classes/com/sun/xml/internal/ws/message/jaxb/package-info.java
! src/share/jaxws_classes/com/sun/xml/internal/ws/message/package-info.java
! src/share/jaxws_classes/com/sun/xml/internal/ws/message/saaj/SAAJHeader.java
! src/share/jaxws_classes/com/sun/xml/internal/ws/message/saaj/SAAJMessage.java
! src/share/jaxws_classes/com/sun/xml/internal/ws/message/source/PayloadSourceMessage.java
! src/share/jaxws_classes/com/sun/xml/internal/ws/message/source/ProtocolSourceMessage.java
! src/share/jaxws_classes/com/sun/xml/internal/ws/message/source/SourceUtils.java
! src/share/jaxws_classes/com/sun/xml/internal/ws/message/stream/OutboundStreamHeader.java
! src/share/jaxws_classes/com/sun/xml/internal/ws/message/stream/PayloadStreamReaderMessage.java
! src/share/jaxws_classes/com/sun/xml/internal/ws/message/stream/StreamAttachment.java
! src/share/jaxws_classes/com/sun/xml/internal/ws/message/stream/StreamHeader.java
! src/share/jaxws_classes/com/sun/xml/internal/ws/message/stream/StreamHeader11.java
! src/share/jaxws_classes/com/sun/xml/internal/ws/message/stream/StreamHeader12.java
! src/share/jaxws_classes/com/sun/xml/internal/ws/message/stream/StreamMessage.java
! src/share/jaxws_classes/com/sun/xml/internal/ws/model/AbstractSEIModelImpl.java
! src/share/jaxws_classes/com/sun/xml/internal/ws/model/AbstractWrapperBeanGenerator.java
! src/share/jaxws_classes/com/sun/xml/internal/ws/model/CheckedExceptionImpl.java
+ src/share/jaxws_classes/com/sun/xml/internal/ws/model/ExternalMetadataReader.java
! src/share/jaxws_classes/com/sun/xml/internal/ws/model/FieldSignature.java
! src/share/jaxws_classes/com/sun/xml/internal/ws/model/Injector.java
! src/share/jaxws_classes/com/sun/xml/internal/ws/model/JavaMethodImpl.java
! src/share/jaxws_classes/com/sun/xml/internal/ws/model/ParameterImpl.java
! src/share/jaxws_classes/com/sun/xml/internal/ws/model/ReflectAnnotationReader.java
! src/share/jaxws_classes/com/sun/xml/internal/ws/model/RuntimeModeler.java
! src/share/jaxws_classes/com/sun/xml/internal/ws/model/RuntimeModelerException.java
! src/share/jaxws_classes/com/sun/xml/internal/ws/model/SOAPSEIModel.java
! src/share/jaxws_classes/com/sun/xml/internal/ws/model/WrapperBeanGenerator.java
! src/share/jaxws_classes/com/sun/xml/internal/ws/model/WrapperParameter.java
! src/share/jaxws_classes/com/sun/xml/internal/ws/model/soap/SOAPBindingImpl.java
! src/share/jaxws_classes/com/sun/xml/internal/ws/model/wsdl/AbstractExtensibleImpl.java
! src/share/jaxws_classes/com/sun/xml/internal/ws/model/wsdl/AbstractFeaturedObjectImpl.java
! src/share/jaxws_classes/com/sun/xml/internal/ws/model/wsdl/AbstractObjectImpl.java
! src/share/jaxws_classes/com/sun/xml/internal/ws/model/wsdl/WSDLBoundFaultImpl.java
! src/share/jaxws_classes/com/sun/xml/internal/ws/model/wsdl/WSDLBoundOperationImpl.java
! src/share/jaxws_classes/com/sun/xml/internal/ws/model/wsdl/WSDLBoundPortTypeImpl.java
! src/share/jaxws_classes/com/sun/xml/internal/ws/model/wsdl/WSDLDirectProperties.java
! src/share/jaxws_classes/com/sun/xml/internal/ws/model/wsdl/WSDLFaultImpl.java
! src/share/jaxws_classes/com/sun/xml/internal/ws/model/wsdl/WSDLInputImpl.java
! src/share/jaxws_classes/com/sun/xml/internal/ws/model/wsdl/WSDLMessageImpl.java
! src/share/jaxws_classes/com/sun/xml/internal/ws/model/wsdl/WSDLModelImpl.java
! src/share/jaxws_classes/com/sun/xml/internal/ws/model/wsdl/WSDLOperationImpl.java
! src/share/jaxws_classes/com/sun/xml/internal/ws/model/wsdl/WSDLOutputImpl.java
! src/share/jaxws_classes/com/sun/xml/internal/ws/model/wsdl/WSDLPartDescriptorImpl.java
! src/share/jaxws_classes/com/sun/xml/internal/ws/model/wsdl/WSDLPartImpl.java
! src/share/jaxws_classes/com/sun/xml/internal/ws/model/wsdl/WSDLPortImpl.java
! src/share/jaxws_classes/com/sun/xml/internal/ws/model/wsdl/WSDLPortProperties.java
! src/share/jaxws_classes/com/sun/xml/internal/ws/model/wsdl/WSDLPortTypeImpl.java
! src/share/jaxws_classes/com/sun/xml/internal/ws/model/wsdl/WSDLProperties.java
! src/share/jaxws_classes/com/sun/xml/internal/ws/model/wsdl/WSDLServiceImpl.java
+ src/share/jaxws_classes/com/sun/xml/internal/ws/org/objectweb/asm/ClassAdapter.java
+ src/share/jaxws_classes/com/sun/xml/internal/ws/org/objectweb/asm/MethodAdapter.java
! src/share/jaxws_classes/com/sun/xml/internal/ws/package-info.java
! src/share/jaxws_classes/com/sun/xml/internal/ws/policy/jaxws/BuilderHandler.java
! src/share/jaxws_classes/com/sun/xml/internal/ws/policy/jaxws/BuilderHandlerEndpointScope.java
! src/share/jaxws_classes/com/sun/xml/internal/ws/policy/jaxws/BuilderHandlerMessageScope.java
! src/share/jaxws_classes/com/sun/xml/internal/ws/policy/jaxws/BuilderHandlerOperationScope.java
! src/share/jaxws_classes/com/sun/xml/internal/ws/policy/jaxws/BuilderHandlerServiceScope.java
! src/share/jaxws_classes/com/sun/xml/internal/ws/policy/jaxws/DefaultPolicyResolver.java
! src/share/jaxws_classes/com/sun/xml/internal/ws/policy/jaxws/PolicyMapBuilder.java
! src/share/jaxws_classes/com/sun/xml/internal/ws/policy/jaxws/PolicyUtil.java
! src/share/jaxws_classes/com/sun/xml/internal/ws/policy/jaxws/PolicyWSDLGeneratorExtension.java
! src/share/jaxws_classes/com/sun/xml/internal/ws/policy/jaxws/PolicyWSDLParserExtension.java
! src/share/jaxws_classes/com/sun/xml/internal/ws/policy/jaxws/SafePolicyReader.java
! src/share/jaxws_classes/com/sun/xml/internal/ws/policy/jaxws/WSDLBoundFaultContainer.java
! src/share/jaxws_classes/com/sun/xml/internal/ws/policy/jaxws/spi/PolicyFeatureConfigurator.java
! src/share/jaxws_classes/com/sun/xml/internal/ws/policy/jaxws/spi/PolicyMapConfigurator.java
! src/share/jaxws_classes/com/sun/xml/internal/ws/protocol/soap/ClientMUTube.java
! src/share/jaxws_classes/com/sun/xml/internal/ws/protocol/soap/MUTube.java
! src/share/jaxws_classes/com/sun/xml/internal/ws/protocol/soap/MessageCreationException.java
! src/share/jaxws_classes/com/sun/xml/internal/ws/protocol/soap/ServerMUTube.java
! src/share/jaxws_classes/com/sun/xml/internal/ws/protocol/soap/VersionMismatchException.java
! src/share/jaxws_classes/com/sun/xml/internal/ws/protocol/xml/XMLMessageException.java
! src/share/jaxws_classes/com/sun/xml/internal/ws/resources/AddressingMessages.java
! src/share/jaxws_classes/com/sun/xml/internal/ws/resources/BindingApiMessages.java
! src/share/jaxws_classes/com/sun/xml/internal/ws/resources/ClientMessages.java
! src/share/jaxws_classes/com/sun/xml/internal/ws/resources/DispatchMessages.java
! src/share/jaxws_classes/com/sun/xml/internal/ws/resources/EncodingMessages.java
! src/share/jaxws_classes/com/sun/xml/internal/ws/resources/HandlerMessages.java
! src/share/jaxws_classes/com/sun/xml/internal/ws/resources/HttpserverMessages.java
! src/share/jaxws_classes/com/sun/xml/internal/ws/resources/ManagementMessages.java
! src/share/jaxws_classes/com/sun/xml/internal/ws/resources/ModelerMessages.java
! src/share/jaxws_classes/com/sun/xml/internal/ws/resources/PolicyMessages.java
! src/share/jaxws_classes/com/sun/xml/internal/ws/resources/ProviderApiMessages.java
! src/share/jaxws_classes/com/sun/xml/internal/ws/resources/SenderMessages.java
! src/share/jaxws_classes/com/sun/xml/internal/ws/resources/ServerMessages.java
! src/share/jaxws_classes/com/sun/xml/internal/ws/resources/SoapMessages.java
! src/share/jaxws_classes/com/sun/xml/internal/ws/resources/StreamingMessages.java
+ src/share/jaxws_classes/com/sun/xml/internal/ws/resources/TubelineassemblyMessages.java
! src/share/jaxws_classes/com/sun/xml/internal/ws/resources/UtilMessages.java
! src/share/jaxws_classes/com/sun/xml/internal/ws/resources/WsdlmodelMessages.java
! src/share/jaxws_classes/com/sun/xml/internal/ws/resources/WsservletMessages.java
! src/share/jaxws_classes/com/sun/xml/internal/ws/resources/XmlmessageMessages.java
! src/share/jaxws_classes/com/sun/xml/internal/ws/resources/addressing.properties
+ src/share/jaxws_classes/com/sun/xml/internal/ws/resources/addressing_de.properties
+ src/share/jaxws_classes/com/sun/xml/internal/ws/resources/addressing_es.properties
+ src/share/jaxws_classes/com/sun/xml/internal/ws/resources/addressing_fr.properties
+ src/share/jaxws_classes/com/sun/xml/internal/ws/resources/addressing_it.properties
+ src/share/jaxws_classes/com/sun/xml/internal/ws/resources/addressing_ja.properties
+ src/share/jaxws_classes/com/sun/xml/internal/ws/resources/addressing_ko.properties
+ src/share/jaxws_classes/com/sun/xml/internal/ws/resources/addressing_pt_BR.properties
+ src/share/jaxws_classes/com/sun/xml/internal/ws/resources/addressing_zh_CN.properties
+ src/share/jaxws_classes/com/sun/xml/internal/ws/resources/addressing_zh_TW.properties
! src/share/jaxws_classes/com/sun/xml/internal/ws/resources/bindingApi.properties
+ src/share/jaxws_classes/com/sun/xml/internal/ws/resources/bindingApi_de.properties
+ src/share/jaxws_classes/com/sun/xml/internal/ws/resources/bindingApi_es.properties
+ src/share/jaxws_classes/com/sun/xml/internal/ws/resources/bindingApi_fr.properties
+ src/share/jaxws_classes/com/sun/xml/internal/ws/resources/bindingApi_it.properties
+ src/share/jaxws_classes/com/sun/xml/internal/ws/resources/bindingApi_ja.properties
+ src/share/jaxws_classes/com/sun/xml/internal/ws/resources/bindingApi_ko.properties
+ src/share/jaxws_classes/com/sun/xml/internal/ws/resources/bindingApi_pt_BR.properties
+ src/share/jaxws_classes/com/sun/xml/internal/ws/resources/bindingApi_zh_CN.properties
+ src/share/jaxws_classes/com/sun/xml/internal/ws/resources/bindingApi_zh_TW.properties
! src/share/jaxws_classes/com/sun/xml/internal/ws/resources/client.properties
+ src/share/jaxws_classes/com/sun/xml/internal/ws/resources/client_de.properties
+ src/share/jaxws_classes/com/sun/xml/internal/ws/resources/client_es.properties
+ src/share/jaxws_classes/com/sun/xml/internal/ws/resources/client_fr.properties
+ src/share/jaxws_classes/com/sun/xml/internal/ws/resources/client_it.properties
+ src/share/jaxws_classes/com/sun/xml/internal/ws/resources/client_ja.properties
+ src/share/jaxws_classes/com/sun/xml/internal/ws/resources/client_ko.properties
+ src/share/jaxws_classes/com/sun/xml/internal/ws/resources/client_pt_BR.properties
+ src/share/jaxws_classes/com/sun/xml/internal/ws/resources/client_zh_CN.properties
+ src/share/jaxws_classes/com/sun/xml/internal/ws/resources/client_zh_TW.properties
! src/share/jaxws_classes/com/sun/xml/internal/ws/resources/dispatch.properties
+ src/share/jaxws_classes/com/sun/xml/internal/ws/resources/dispatch_de.properties
+ src/share/jaxws_classes/com/sun/xml/internal/ws/resources/dispatch_es.properties
+ src/share/jaxws_classes/com/sun/xml/internal/ws/resources/dispatch_fr.properties
+ src/share/jaxws_classes/com/sun/xml/internal/ws/resources/dispatch_it.properties
+ src/share/jaxws_classes/com/sun/xml/internal/ws/resources/dispatch_ja.properties
+ src/share/jaxws_classes/com/sun/xml/internal/ws/resources/dispatch_ko.properties
+ src/share/jaxws_classes/com/sun/xml/internal/ws/resources/dispatch_pt_BR.properties
+ src/share/jaxws_classes/com/sun/xml/internal/ws/resources/dispatch_zh_CN.properties
+ src/share/jaxws_classes/com/sun/xml/internal/ws/resources/dispatch_zh_TW.properties
! src/share/jaxws_classes/com/sun/xml/internal/ws/resources/encoding.properties
+ src/share/jaxws_classes/com/sun/xml/internal/ws/resources/encoding_de.properties
+ src/share/jaxws_classes/com/sun/xml/internal/ws/resources/encoding_es.properties
+ src/share/jaxws_classes/com/sun/xml/internal/ws/resources/encoding_fr.properties
+ src/share/jaxws_classes/com/sun/xml/internal/ws/resources/encoding_it.properties
+ src/share/jaxws_classes/com/sun/xml/internal/ws/resources/encoding_ja.properties
+ src/share/jaxws_classes/com/sun/xml/internal/ws/resources/encoding_ko.properties
+ src/share/jaxws_classes/com/sun/xml/internal/ws/resources/encoding_pt_BR.properties
+ src/share/jaxws_classes/com/sun/xml/internal/ws/resources/encoding_zh_CN.properties
+ src/share/jaxws_classes/com/sun/xml/internal/ws/resources/encoding_zh_TW.properties
! src/share/jaxws_classes/com/sun/xml/internal/ws/resources/handler.properties
+ src/share/jaxws_classes/com/sun/xml/internal/ws/resources/handler_de.properties
+ src/share/jaxws_classes/com/sun/xml/internal/ws/resources/handler_es.properties
+ src/share/jaxws_classes/com/sun/xml/internal/ws/resources/handler_fr.properties
+ src/share/jaxws_classes/com/sun/xml/internal/ws/resources/handler_it.properties
+ src/share/jaxws_classes/com/sun/xml/internal/ws/resources/handler_ja.properties
+ src/share/jaxws_classes/com/sun/xml/internal/ws/resources/handler_ko.properties
+ src/share/jaxws_classes/com/sun/xml/internal/ws/resources/handler_pt_BR.properties
+ src/share/jaxws_classes/com/sun/xml/internal/ws/resources/handler_zh_CN.properties
+ src/share/jaxws_classes/com/sun/xml/internal/ws/resources/handler_zh_TW.properties
! src/share/jaxws_classes/com/sun/xml/internal/ws/resources/httpserver.properties
+ src/share/jaxws_classes/com/sun/xml/internal/ws/resources/httpserver_de.properties
+ src/share/jaxws_classes/com/sun/xml/internal/ws/resources/httpserver_es.properties
+ src/share/jaxws_classes/com/sun/xml/internal/ws/resources/httpserver_fr.properties
+ src/share/jaxws_classes/com/sun/xml/internal/ws/resources/httpserver_it.properties
+ src/share/jaxws_classes/com/sun/xml/internal/ws/resources/httpserver_ja.properties
+ src/share/jaxws_classes/com/sun/xml/internal/ws/resources/httpserver_ko.properties
+ src/share/jaxws_classes/com/sun/xml/internal/ws/resources/httpserver_pt_BR.properties
+ src/share/jaxws_classes/com/sun/xml/internal/ws/resources/httpserver_zh_CN.properties
+ src/share/jaxws_classes/com/sun/xml/internal/ws/resources/httpserver_zh_TW.properties
! src/share/jaxws_classes/com/sun/xml/internal/ws/resources/management.properties
+ src/share/jaxws_classes/com/sun/xml/internal/ws/resources/management_de.properties
+ src/share/jaxws_classes/com/sun/xml/internal/ws/resources/management_es.properties
+ src/share/jaxws_classes/com/sun/xml/internal/ws/resources/management_fr.properties
+ src/share/jaxws_classes/com/sun/xml/internal/ws/resources/management_it.properties
+ src/share/jaxws_classes/com/sun/xml/internal/ws/resources/management_ja.properties
+ src/share/jaxws_classes/com/sun/xml/internal/ws/resources/management_ko.properties
+ src/share/jaxws_classes/com/sun/xml/internal/ws/resources/management_pt_BR.properties
+ src/share/jaxws_classes/com/sun/xml/internal/ws/resources/management_zh_CN.properties
+ src/share/jaxws_classes/com/sun/xml/internal/ws/resources/management_zh_TW.properties
! src/share/jaxws_classes/com/sun/xml/internal/ws/resources/modeler.properties
+ src/share/jaxws_classes/com/sun/xml/internal/ws/resources/modeler_de.properties
+ src/share/jaxws_classes/com/sun/xml/internal/ws/resources/modeler_es.properties
+ src/share/jaxws_classes/com/sun/xml/internal/ws/resources/modeler_fr.properties
+ src/share/jaxws_classes/com/sun/xml/internal/ws/resources/modeler_it.properties
+ src/share/jaxws_classes/com/sun/xml/internal/ws/resources/modeler_ja.properties
+ src/share/jaxws_classes/com/sun/xml/internal/ws/resources/modeler_ko.properties
+ src/share/jaxws_classes/com/sun/xml/internal/ws/resources/modeler_pt_BR.properties
+ src/share/jaxws_classes/com/sun/xml/internal/ws/resources/modeler_zh_CN.properties
+ src/share/jaxws_classes/com/sun/xml/internal/ws/resources/modeler_zh_TW.properties
! src/share/jaxws_classes/com/sun/xml/internal/ws/resources/policy.properties
+ src/share/jaxws_classes/com/sun/xml/internal/ws/resources/policy_de.properties
+ src/share/jaxws_classes/com/sun/xml/internal/ws/resources/policy_es.properties
+ src/share/jaxws_classes/com/sun/xml/internal/ws/resources/policy_fr.properties
+ src/share/jaxws_classes/com/sun/xml/internal/ws/resources/policy_it.properties
+ src/share/jaxws_classes/com/sun/xml/internal/ws/resources/policy_ja.properties
+ src/share/jaxws_classes/com/sun/xml/internal/ws/resources/policy_ko.properties
+ src/share/jaxws_classes/com/sun/xml/internal/ws/resources/policy_pt_BR.properties
+ src/share/jaxws_classes/com/sun/xml/internal/ws/resources/policy_zh_CN.properties
+ src/share/jaxws_classes/com/sun/xml/internal/ws/resources/policy_zh_TW.properties
! src/share/jaxws_classes/com/sun/xml/internal/ws/resources/providerApi.properties
+ src/share/jaxws_classes/com/sun/xml/internal/ws/resources/providerApi_de.properties
+ src/share/jaxws_classes/com/sun/xml/internal/ws/resources/providerApi_es.properties
+ src/share/jaxws_classes/com/sun/xml/internal/ws/resources/providerApi_fr.properties
+ src/share/jaxws_classes/com/sun/xml/internal/ws/resources/providerApi_it.properties
+ src/share/jaxws_classes/com/sun/xml/internal/ws/resources/providerApi_ja.properties
+ src/share/jaxws_classes/com/sun/xml/internal/ws/resources/providerApi_ko.properties
+ src/share/jaxws_classes/com/sun/xml/internal/ws/resources/providerApi_pt_BR.properties
+ src/share/jaxws_classes/com/sun/xml/internal/ws/resources/providerApi_zh_CN.properties
+ src/share/jaxws_classes/com/sun/xml/internal/ws/resources/providerApi_zh_TW.properties
! src/share/jaxws_classes/com/sun/xml/internal/ws/resources/sender.properties
+ src/share/jaxws_classes/com/sun/xml/internal/ws/resources/sender_de.properties
+ src/share/jaxws_classes/com/sun/xml/internal/ws/resources/sender_es.properties
+ src/share/jaxws_classes/com/sun/xml/internal/ws/resources/sender_fr.properties
+ src/share/jaxws_classes/com/sun/xml/internal/ws/resources/sender_it.properties
+ src/share/jaxws_classes/com/sun/xml/internal/ws/resources/sender_ja.properties
+ src/share/jaxws_classes/com/sun/xml/internal/ws/resources/sender_ko.properties
+ src/share/jaxws_classes/com/sun/xml/internal/ws/resources/sender_pt_BR.properties
+ src/share/jaxws_classes/com/sun/xml/internal/ws/resources/sender_zh_CN.properties
+ src/share/jaxws_classes/com/sun/xml/internal/ws/resources/sender_zh_TW.properties
! src/share/jaxws_classes/com/sun/xml/internal/ws/resources/server.properties
+ src/share/jaxws_classes/com/sun/xml/internal/ws/resources/server_de.properties
+ src/share/jaxws_classes/com/sun/xml/internal/ws/resources/server_es.properties
+ src/share/jaxws_classes/com/sun/xml/internal/ws/resources/server_fr.properties
+ src/share/jaxws_classes/com/sun/xml/internal/ws/resources/server_it.properties
+ src/share/jaxws_classes/com/sun/xml/internal/ws/resources/server_ja.properties
+ src/share/jaxws_classes/com/sun/xml/internal/ws/resources/server_ko.properties
+ src/share/jaxws_classes/com/sun/xml/internal/ws/resources/server_pt_BR.properties
+ src/share/jaxws_classes/com/sun/xml/internal/ws/resources/server_zh_CN.properties
+ src/share/jaxws_classes/com/sun/xml/internal/ws/resources/server_zh_TW.properties
! src/share/jaxws_classes/com/sun/xml/internal/ws/resources/soap.properties
+ src/share/jaxws_classes/com/sun/xml/internal/ws/resources/soap_de.properties
+ src/share/jaxws_classes/com/sun/xml/internal/ws/resources/soap_es.properties
+ src/share/jaxws_classes/com/sun/xml/internal/ws/resources/soap_fr.properties
+ src/share/jaxws_classes/com/sun/xml/internal/ws/resources/soap_it.properties
+ src/share/jaxws_classes/com/sun/xml/internal/ws/resources/soap_ja.properties
+ src/share/jaxws_classes/com/sun/xml/internal/ws/resources/soap_ko.properties
+ src/share/jaxws_classes/com/sun/xml/internal/ws/resources/soap_pt_BR.properties
+ src/share/jaxws_classes/com/sun/xml/internal/ws/resources/soap_zh_CN.properties
+ src/share/jaxws_classes/com/sun/xml/internal/ws/resources/soap_zh_TW.properties
! src/share/jaxws_classes/com/sun/xml/internal/ws/resources/streaming.properties
+ src/share/jaxws_classes/com/sun/xml/internal/ws/resources/streaming_de.properties
+ src/share/jaxws_classes/com/sun/xml/internal/ws/resources/streaming_es.properties
+ src/share/jaxws_classes/com/sun/xml/internal/ws/resources/streaming_fr.properties
+ src/share/jaxws_classes/com/sun/xml/internal/ws/resources/streaming_it.properties
+ src/share/jaxws_classes/com/sun/xml/internal/ws/resources/streaming_ja.properties
+ src/share/jaxws_classes/com/sun/xml/internal/ws/resources/streaming_ko.properties
+ src/share/jaxws_classes/com/sun/xml/internal/ws/resources/streaming_pt_BR.properties
+ src/share/jaxws_classes/com/sun/xml/internal/ws/resources/streaming_zh_CN.properties
+ src/share/jaxws_classes/com/sun/xml/internal/ws/resources/streaming_zh_TW.properties
+ src/share/jaxws_classes/com/sun/xml/internal/ws/resources/tubelineassembly.properties
! src/share/jaxws_classes/com/sun/xml/internal/ws/resources/util.properties
+ src/share/jaxws_classes/com/sun/xml/internal/ws/resources/util_de.properties
+ src/share/jaxws_classes/com/sun/xml/internal/ws/resources/util_es.properties
+ src/share/jaxws_classes/com/sun/xml/internal/ws/resources/util_fr.properties
+ src/share/jaxws_classes/com/sun/xml/internal/ws/resources/util_it.properties
+ src/share/jaxws_classes/com/sun/xml/internal/ws/resources/util_ja.properties
+ src/share/jaxws_classes/com/sun/xml/internal/ws/resources/util_ko.properties
+ src/share/jaxws_classes/com/sun/xml/internal/ws/resources/util_pt_BR.properties
+ src/share/jaxws_classes/com/sun/xml/internal/ws/resources/util_zh_CN.properties
+ src/share/jaxws_classes/com/sun/xml/internal/ws/resources/util_zh_TW.properties
! src/share/jaxws_classes/com/sun/xml/internal/ws/resources/wsdlmodel.properties
+ src/share/jaxws_classes/com/sun/xml/internal/ws/resources/wsdlmodel_de.properties
+ src/share/jaxws_classes/com/sun/xml/internal/ws/resources/wsdlmodel_es.properties
+ src/share/jaxws_classes/com/sun/xml/internal/ws/resources/wsdlmodel_fr.properties
+ src/share/jaxws_classes/com/sun/xml/internal/ws/resources/wsdlmodel_it.properties
+ src/share/jaxws_classes/com/sun/xml/internal/ws/resources/wsdlmodel_ja.properties
+ src/share/jaxws_classes/com/sun/xml/internal/ws/resources/wsdlmodel_ko.properties
+ src/share/jaxws_classes/com/sun/xml/internal/ws/resources/wsdlmodel_pt_BR.properties
+ src/share/jaxws_classes/com/sun/xml/internal/ws/resources/wsdlmodel_zh_CN.properties
+ src/share/jaxws_classes/com/sun/xml/internal/ws/resources/wsdlmodel_zh_TW.properties
! src/share/jaxws_classes/com/sun/xml/internal/ws/resources/wsservlet.properties
+ src/share/jaxws_classes/com/sun/xml/internal/ws/resources/wsservlet_de.properties
+ src/share/jaxws_classes/com/sun/xml/internal/ws/resources/wsservlet_es.properties
+ src/share/jaxws_classes/com/sun/xml/internal/ws/resources/wsservlet_fr.properties
+ src/share/jaxws_classes/com/sun/xml/internal/ws/resources/wsservlet_it.properties
+ src/share/jaxws_classes/com/sun/xml/internal/ws/resources/wsservlet_ja.properties
+ src/share/jaxws_classes/com/sun/xml/internal/ws/resources/wsservlet_ko.properties
+ src/share/jaxws_classes/com/sun/xml/internal/ws/resources/wsservlet_pt_BR.properties
+ src/share/jaxws_classes/com/sun/xml/internal/ws/resources/wsservlet_zh_CN.properties
+ src/share/jaxws_classes/com/sun/xml/internal/ws/resources/wsservlet_zh_TW.properties
! src/share/jaxws_classes/com/sun/xml/internal/ws/resources/xmlmessage.properties
+ src/share/jaxws_classes/com/sun/xml/internal/ws/resources/xmlmessage_de.properties
+ src/share/jaxws_classes/com/sun/xml/internal/ws/resources/xmlmessage_es.properties
+ src/share/jaxws_classes/com/sun/xml/internal/ws/resources/xmlmessage_fr.properties
+ src/share/jaxws_classes/com/sun/xml/internal/ws/resources/xmlmessage_it.properties
+ src/share/jaxws_classes/com/sun/xml/internal/ws/resources/xmlmessage_ja.properties
+ src/share/jaxws_classes/com/sun/xml/internal/ws/resources/xmlmessage_ko.properties
+ src/share/jaxws_classes/com/sun/xml/internal/ws/resources/xmlmessage_pt_BR.properties
+ src/share/jaxws_classes/com/sun/xml/internal/ws/resources/xmlmessage_zh_CN.properties
+ src/share/jaxws_classes/com/sun/xml/internal/ws/resources/xmlmessage_zh_TW.properties
+ src/share/jaxws_classes/com/sun/xml/internal/ws/runtime/config/MetroConfig.java
+ src/share/jaxws_classes/com/sun/xml/internal/ws/runtime/config/ObjectFactory.java
+ src/share/jaxws_classes/com/sun/xml/internal/ws/runtime/config/TubeFactoryConfig.java
+ src/share/jaxws_classes/com/sun/xml/internal/ws/runtime/config/TubeFactoryList.java
+ src/share/jaxws_classes/com/sun/xml/internal/ws/runtime/config/TubelineDefinition.java
+ src/share/jaxws_classes/com/sun/xml/internal/ws/runtime/config/TubelineFeature.java
+ src/share/jaxws_classes/com/sun/xml/internal/ws/runtime/config/TubelineFeatureReader.java
+ src/share/jaxws_classes/com/sun/xml/internal/ws/runtime/config/TubelineMapping.java
+ src/share/jaxws_classes/com/sun/xml/internal/ws/runtime/config/Tubelines.java
+ src/share/jaxws_classes/com/sun/xml/internal/ws/runtime/config/package-info.java
! src/share/jaxws_classes/com/sun/xml/internal/ws/server/AbstractMultiInstanceResolver.java
! src/share/jaxws_classes/com/sun/xml/internal/ws/server/AbstractWebServiceContext.java
! src/share/jaxws_classes/com/sun/xml/internal/ws/server/DefaultResourceInjector.java
! src/share/jaxws_classes/com/sun/xml/internal/ws/server/DraconianValidationErrorHandler.java
! src/share/jaxws_classes/com/sun/xml/internal/ws/server/EndpointAwareTube.java
! src/share/jaxws_classes/com/sun/xml/internal/ws/server/EndpointFactory.java
! src/share/jaxws_classes/com/sun/xml/internal/ws/server/EndpointMessageContextImpl.java
! src/share/jaxws_classes/com/sun/xml/internal/ws/server/InvokerTube.java
! src/share/jaxws_classes/com/sun/xml/internal/ws/server/MonitorBase.java
! src/share/jaxws_classes/com/sun/xml/internal/ws/server/MonitorRootService.java
! src/share/jaxws_classes/com/sun/xml/internal/ws/server/SDDocumentImpl.java
! src/share/jaxws_classes/com/sun/xml/internal/ws/server/ServerPropertyConstants.java
! src/share/jaxws_classes/com/sun/xml/internal/ws/server/ServerRtException.java
! src/share/jaxws_classes/com/sun/xml/internal/ws/server/ServerSchemaValidationTube.java
! src/share/jaxws_classes/com/sun/xml/internal/ws/server/ServiceDefinitionImpl.java
! src/share/jaxws_classes/com/sun/xml/internal/ws/server/SingletonResolver.java
! src/share/jaxws_classes/com/sun/xml/internal/ws/server/UnsupportedMediaException.java
! src/share/jaxws_classes/com/sun/xml/internal/ws/server/WSDLGenResolver.java
! src/share/jaxws_classes/com/sun/xml/internal/ws/server/WSEndpointImpl.java
! src/share/jaxws_classes/com/sun/xml/internal/ws/server/WSEndpointMOMProxy.java
! src/share/jaxws_classes/com/sun/xml/internal/ws/server/package-info.java
! src/share/jaxws_classes/com/sun/xml/internal/ws/server/provider/AsyncProviderInvokerTube.java
! src/share/jaxws_classes/com/sun/xml/internal/ws/server/provider/MessageProviderArgumentBuilder.java
! src/share/jaxws_classes/com/sun/xml/internal/ws/server/provider/ProviderArgumentsBuilder.java
! src/share/jaxws_classes/com/sun/xml/internal/ws/server/provider/ProviderEndpointModel.java
! src/share/jaxws_classes/com/sun/xml/internal/ws/server/provider/ProviderInvokerTube.java
! src/share/jaxws_classes/com/sun/xml/internal/ws/server/provider/SOAPProviderArgumentBuilder.java
! src/share/jaxws_classes/com/sun/xml/internal/ws/server/provider/SyncProviderInvokerTube.java
! src/share/jaxws_classes/com/sun/xml/internal/ws/server/provider/XMLProviderArgumentBuilder.java
! src/share/jaxws_classes/com/sun/xml/internal/ws/server/sei/EndpointArgumentsBuilder.java
! src/share/jaxws_classes/com/sun/xml/internal/ws/server/sei/EndpointResponseMessageBuilder.java
! src/share/jaxws_classes/com/sun/xml/internal/ws/server/sei/EndpointValueSetter.java
! src/share/jaxws_classes/com/sun/xml/internal/ws/server/sei/Invoker.java
! src/share/jaxws_classes/com/sun/xml/internal/ws/server/sei/InvokerSource.java
! src/share/jaxws_classes/com/sun/xml/internal/ws/server/sei/InvokerTube.java
! src/share/jaxws_classes/com/sun/xml/internal/ws/server/sei/MessageFiller.java
! src/share/jaxws_classes/com/sun/xml/internal/ws/server/sei/SEIInvokerTube.java
! src/share/jaxws_classes/com/sun/xml/internal/ws/server/sei/TieHandler.java
! src/share/jaxws_classes/com/sun/xml/internal/ws/server/sei/ValueGetter.java
! src/share/jaxws_classes/com/sun/xml/internal/ws/spi/ProviderImpl.java
! src/share/jaxws_classes/com/sun/xml/internal/ws/spi/db/BindingContext.java
! src/share/jaxws_classes/com/sun/xml/internal/ws/spi/db/BindingContextFactory.java
! src/share/jaxws_classes/com/sun/xml/internal/ws/spi/db/BindingHelper.java
! src/share/jaxws_classes/com/sun/xml/internal/ws/spi/db/BindingInfo.java
! src/share/jaxws_classes/com/sun/xml/internal/ws/spi/db/DatabindingException.java
! src/share/jaxws_classes/com/sun/xml/internal/ws/spi/db/DatabindingProvider.java
! src/share/jaxws_classes/com/sun/xml/internal/ws/spi/db/FieldGetter.java
! src/share/jaxws_classes/com/sun/xml/internal/ws/spi/db/FieldSetter.java
! src/share/jaxws_classes/com/sun/xml/internal/ws/spi/db/JAXBWrapperAccessor.java
! src/share/jaxws_classes/com/sun/xml/internal/ws/spi/db/MethodGetter.java
! src/share/jaxws_classes/com/sun/xml/internal/ws/spi/db/MethodSetter.java
! src/share/jaxws_classes/com/sun/xml/internal/ws/spi/db/OldBridge.java
! src/share/jaxws_classes/com/sun/xml/internal/ws/spi/db/PropertyAccessor.java
! src/share/jaxws_classes/com/sun/xml/internal/ws/spi/db/PropertyGetter.java
! src/share/jaxws_classes/com/sun/xml/internal/ws/spi/db/PropertyGetterBase.java
! src/share/jaxws_classes/com/sun/xml/internal/ws/spi/db/PropertySetter.java
! src/share/jaxws_classes/com/sun/xml/internal/ws/spi/db/PropertySetterBase.java
+ src/share/jaxws_classes/com/sun/xml/internal/ws/spi/db/RepeatedElementBridge.java
! src/share/jaxws_classes/com/sun/xml/internal/ws/spi/db/TypeInfo.java
! src/share/jaxws_classes/com/sun/xml/internal/ws/spi/db/WrapperAccessor.java
+ src/share/jaxws_classes/com/sun/xml/internal/ws/spi/db/WrapperBridge.java
! src/share/jaxws_classes/com/sun/xml/internal/ws/spi/db/WrapperComposite.java
! src/share/jaxws_classes/com/sun/xml/internal/ws/spi/db/XMLBridge.java
! src/share/jaxws_classes/com/sun/xml/internal/ws/streaming/Attributes.java
! src/share/jaxws_classes/com/sun/xml/internal/ws/streaming/DOMStreamReader.java
! src/share/jaxws_classes/com/sun/xml/internal/ws/streaming/MtomStreamWriter.java
! src/share/jaxws_classes/com/sun/xml/internal/ws/streaming/PrefixFactory.java
! src/share/jaxws_classes/com/sun/xml/internal/ws/streaming/PrefixFactoryImpl.java
! src/share/jaxws_classes/com/sun/xml/internal/ws/streaming/SourceReaderFactory.java
! src/share/jaxws_classes/com/sun/xml/internal/ws/streaming/TidyXMLStreamReader.java
! src/share/jaxws_classes/com/sun/xml/internal/ws/streaming/XMLReaderException.java
! src/share/jaxws_classes/com/sun/xml/internal/ws/streaming/XMLStreamReaderException.java
! src/share/jaxws_classes/com/sun/xml/internal/ws/streaming/XMLStreamReaderUtil.java
! src/share/jaxws_classes/com/sun/xml/internal/ws/streaming/XMLStreamWriterException.java
! src/share/jaxws_classes/com/sun/xml/internal/ws/streaming/XMLStreamWriterUtil.java
! src/share/jaxws_classes/com/sun/xml/internal/ws/transport/DeferredTransportPipe.java
! src/share/jaxws_classes/com/sun/xml/internal/ws/transport/Headers.java
! src/share/jaxws_classes/com/sun/xml/internal/ws/transport/http/DeploymentDescriptorParser.java
! src/share/jaxws_classes/com/sun/xml/internal/ws/transport/http/HttpAdapter.java
! src/share/jaxws_classes/com/sun/xml/internal/ws/transport/http/HttpAdapterList.java
! src/share/jaxws_classes/com/sun/xml/internal/ws/transport/http/HttpMetadataPublisher.java
! src/share/jaxws_classes/com/sun/xml/internal/ws/transport/http/ResourceLoader.java
! src/share/jaxws_classes/com/sun/xml/internal/ws/transport/http/WSHTTPConnection.java
! src/share/jaxws_classes/com/sun/xml/internal/ws/transport/http/client/HttpClientTransport.java
! src/share/jaxws_classes/com/sun/xml/internal/ws/transport/http/client/HttpResponseProperties.java
! src/share/jaxws_classes/com/sun/xml/internal/ws/transport/http/client/HttpTransportPipe.java
! src/share/jaxws_classes/com/sun/xml/internal/ws/transport/http/server/EndpointImpl.java
! src/share/jaxws_classes/com/sun/xml/internal/ws/transport/http/server/HttpEndpoint.java
! src/share/jaxws_classes/com/sun/xml/internal/ws/transport/http/server/PortableConnectionImpl.java
! src/share/jaxws_classes/com/sun/xml/internal/ws/transport/http/server/PortableHttpHandler.java
! src/share/jaxws_classes/com/sun/xml/internal/ws/transport/http/server/ServerAdapter.java
! src/share/jaxws_classes/com/sun/xml/internal/ws/transport/http/server/ServerAdapterList.java
! src/share/jaxws_classes/com/sun/xml/internal/ws/transport/http/server/ServerConnectionImpl.java
! src/share/jaxws_classes/com/sun/xml/internal/ws/transport/http/server/ServerContainer.java
! src/share/jaxws_classes/com/sun/xml/internal/ws/transport/http/server/ServerMgr.java
! src/share/jaxws_classes/com/sun/xml/internal/ws/transport/http/server/WSHttpHandler.java
! src/share/jaxws_classes/com/sun/xml/internal/ws/util/ASCIIUtility.java
! src/share/jaxws_classes/com/sun/xml/internal/ws/util/ByteArrayBuffer.java
! src/share/jaxws_classes/com/sun/xml/internal/ws/util/ByteArrayDataSource.java
! src/share/jaxws_classes/com/sun/xml/internal/ws/util/CompletedFuture.java
! src/share/jaxws_classes/com/sun/xml/internal/ws/util/Constants.java
! src/share/jaxws_classes/com/sun/xml/internal/ws/util/DOMUtil.java
! src/share/jaxws_classes/com/sun/xml/internal/ws/util/FastInfosetReflection.java
! src/share/jaxws_classes/com/sun/xml/internal/ws/util/FastInfosetUtil.java
! src/share/jaxws_classes/com/sun/xml/internal/ws/util/HandlerAnnotationInfo.java
! src/share/jaxws_classes/com/sun/xml/internal/ws/util/HandlerAnnotationProcessor.java
+ src/share/jaxws_classes/com/sun/xml/internal/ws/util/InjectionPlan.java
! src/share/jaxws_classes/com/sun/xml/internal/ws/util/JAXWSUtils.java
! src/share/jaxws_classes/com/sun/xml/internal/ws/util/MetadataUtil.java
! src/share/jaxws_classes/com/sun/xml/internal/ws/util/NamespaceSupport.java
! src/share/jaxws_classes/com/sun/xml/internal/ws/util/NoCloseInputStream.java
! src/share/jaxws_classes/com/sun/xml/internal/ws/util/NoCloseOutputStream.java
! src/share/jaxws_classes/com/sun/xml/internal/ws/util/Pool.java
! src/share/jaxws_classes/com/sun/xml/internal/ws/util/QNameMap.java
! src/share/jaxws_classes/com/sun/xml/internal/ws/util/ReadAllStream.java
- src/share/jaxws_classes/com/sun/xml/internal/ws/util/ReadOnlyPropertyException.java
! src/share/jaxws_classes/com/sun/xml/internal/ws/util/RuntimeVersion.java
! src/share/jaxws_classes/com/sun/xml/internal/ws/util/ServiceConfigurationError.java
! src/share/jaxws_classes/com/sun/xml/internal/ws/util/ServiceFinder.java
! src/share/jaxws_classes/com/sun/xml/internal/ws/util/StreamUtils.java
! src/share/jaxws_classes/com/sun/xml/internal/ws/util/StringUtils.java
! src/share/jaxws_classes/com/sun/xml/internal/ws/util/UtilException.java
! src/share/jaxws_classes/com/sun/xml/internal/ws/util/Version.java
! src/share/jaxws_classes/com/sun/xml/internal/ws/util/VersionUtil.java
! src/share/jaxws_classes/com/sun/xml/internal/ws/util/exception/JAXWSExceptionBase.java
! src/share/jaxws_classes/com/sun/xml/internal/ws/util/exception/LocatableWebServiceException.java
- src/share/jaxws_classes/com/sun/xml/internal/ws/util/localization/Localizable.java
- src/share/jaxws_classes/com/sun/xml/internal/ws/util/localization/LocalizableImpl.java
- src/share/jaxws_classes/com/sun/xml/internal/ws/util/localization/LocalizableMessage.java
- src/share/jaxws_classes/com/sun/xml/internal/ws/util/localization/LocalizableMessageFactory.java
- src/share/jaxws_classes/com/sun/xml/internal/ws/util/localization/Localizer.java
- src/share/jaxws_classes/com/sun/xml/internal/ws/util/localization/NullLocalizable.java
! src/share/jaxws_classes/com/sun/xml/internal/ws/util/pipe/AbstractSchemaValidationTube.java
! src/share/jaxws_classes/com/sun/xml/internal/ws/util/pipe/DumpTube.java
! src/share/jaxws_classes/com/sun/xml/internal/ws/util/pipe/StandalonePipeAssembler.java
! src/share/jaxws_classes/com/sun/xml/internal/ws/util/pipe/StandaloneTubeAssembler.java
! src/share/jaxws_classes/com/sun/xml/internal/ws/util/resources/Messages_en.properties
+ src/share/jaxws_classes/com/sun/xml/internal/ws/util/resources/Messages_en_de.properties
+ src/share/jaxws_classes/com/sun/xml/internal/ws/util/resources/Messages_en_es.properties
+ src/share/jaxws_classes/com/sun/xml/internal/ws/util/resources/Messages_en_fr.properties
+ src/share/jaxws_classes/com/sun/xml/internal/ws/util/resources/Messages_en_it.properties
+ src/share/jaxws_classes/com/sun/xml/internal/ws/util/resources/Messages_en_ja.properties
+ src/share/jaxws_classes/com/sun/xml/internal/ws/util/resources/Messages_en_ko.properties
+ src/share/jaxws_classes/com/sun/xml/internal/ws/util/resources/Messages_en_pt_BR.properties
+ src/share/jaxws_classes/com/sun/xml/internal/ws/util/resources/Messages_en_zh_CN.properties
+ src/share/jaxws_classes/com/sun/xml/internal/ws/util/resources/Messages_en_zh_TW.properties
! src/share/jaxws_classes/com/sun/xml/internal/ws/util/version.properties
! src/share/jaxws_classes/com/sun/xml/internal/ws/util/xml/CDATA.java
! src/share/jaxws_classes/com/sun/xml/internal/ws/util/xml/ContentHandlerToXMLStreamWriter.java
! src/share/jaxws_classes/com/sun/xml/internal/ws/util/xml/DummyLocation.java
! src/share/jaxws_classes/com/sun/xml/internal/ws/util/xml/NamedNodeMapIterator.java
! src/share/jaxws_classes/com/sun/xml/internal/ws/util/xml/NodeListIterator.java
! src/share/jaxws_classes/com/sun/xml/internal/ws/util/xml/StAXResult.java
! src/share/jaxws_classes/com/sun/xml/internal/ws/util/xml/StAXSource.java
! src/share/jaxws_classes/com/sun/xml/internal/ws/util/xml/XMLStreamReaderFilter.java
! src/share/jaxws_classes/com/sun/xml/internal/ws/util/xml/XMLStreamReaderToXMLStreamWriter.java
! src/share/jaxws_classes/com/sun/xml/internal/ws/util/xml/XMLStreamWriterFilter.java
! src/share/jaxws_classes/com/sun/xml/internal/ws/util/xml/XmlUtil.java
! src/share/jaxws_classes/com/sun/xml/internal/ws/wsdl/ActionBasedOperationFinder.java
! src/share/jaxws_classes/com/sun/xml/internal/ws/wsdl/ActionBasedOperationSignature.java
! src/share/jaxws_classes/com/sun/xml/internal/ws/wsdl/DispatchException.java
! src/share/jaxws_classes/com/sun/xml/internal/ws/wsdl/OperationDispatcher.java
! src/share/jaxws_classes/com/sun/xml/internal/ws/wsdl/PayloadQNameBasedOperationFinder.java
! src/share/jaxws_classes/com/sun/xml/internal/ws/wsdl/SDDocumentResolver.java
! src/share/jaxws_classes/com/sun/xml/internal/ws/wsdl/SOAPActionBasedOperationFinder.java
! src/share/jaxws_classes/com/sun/xml/internal/ws/wsdl/WSDLOperationFinder.java
! src/share/jaxws_classes/com/sun/xml/internal/ws/wsdl/parser/DelegatingParserExtension.java
! src/share/jaxws_classes/com/sun/xml/internal/ws/wsdl/parser/EntityResolverWrapper.java
! src/share/jaxws_classes/com/sun/xml/internal/ws/wsdl/parser/ErrorHandler.java
! src/share/jaxws_classes/com/sun/xml/internal/ws/wsdl/parser/FoolProofParserExtension.java
! src/share/jaxws_classes/com/sun/xml/internal/ws/wsdl/parser/InaccessibleWSDLException.java
! src/share/jaxws_classes/com/sun/xml/internal/ws/wsdl/parser/MIMEConstants.java
! src/share/jaxws_classes/com/sun/xml/internal/ws/wsdl/parser/MemberSubmissionAddressingWSDLParserExtension.java
! src/share/jaxws_classes/com/sun/xml/internal/ws/wsdl/parser/MexEntityResolver.java
! src/share/jaxws_classes/com/sun/xml/internal/ws/wsdl/parser/ParserUtil.java
! src/share/jaxws_classes/com/sun/xml/internal/ws/wsdl/parser/RuntimeWSDLParser.java
! src/share/jaxws_classes/com/sun/xml/internal/ws/wsdl/parser/SOAPConstants.java
! src/share/jaxws_classes/com/sun/xml/internal/ws/wsdl/parser/W3CAddressingMetadataWSDLParserExtension.java
! src/share/jaxws_classes/com/sun/xml/internal/ws/wsdl/parser/W3CAddressingWSDLParserExtension.java
! src/share/jaxws_classes/com/sun/xml/internal/ws/wsdl/parser/WSDLConstants.java
! src/share/jaxws_classes/com/sun/xml/internal/ws/wsdl/parser/WSDLParserExtensionContextImpl.java
! src/share/jaxws_classes/com/sun/xml/internal/ws/wsdl/parser/WSDLParserExtensionFacade.java
! src/share/jaxws_classes/com/sun/xml/internal/ws/wsdl/writer/DocumentLocationResolver.java
! src/share/jaxws_classes/com/sun/xml/internal/ws/wsdl/writer/TXWContentHandler.java
! src/share/jaxws_classes/com/sun/xml/internal/ws/wsdl/writer/UsingAddressing.java
! src/share/jaxws_classes/com/sun/xml/internal/ws/wsdl/writer/W3CAddressingMetadataWSDLGeneratorExtension.java
! src/share/jaxws_classes/com/sun/xml/internal/ws/wsdl/writer/W3CAddressingWSDLGeneratorExtension.java
! src/share/jaxws_classes/com/sun/xml/internal/ws/wsdl/writer/WSDLGenerator.java
! src/share/jaxws_classes/com/sun/xml/internal/ws/wsdl/writer/WSDLGeneratorExtensionFacade.java
! src/share/jaxws_classes/com/sun/xml/internal/ws/wsdl/writer/WSDLPatcher.java
! src/share/jaxws_classes/com/sun/xml/internal/ws/wsdl/writer/WSDLResolver.java
! src/share/jaxws_classes/com/sun/xml/internal/ws/wsdl/writer/document/Binding.java
! src/share/jaxws_classes/com/sun/xml/internal/ws/wsdl/writer/document/BindingOperationType.java
! src/share/jaxws_classes/com/sun/xml/internal/ws/wsdl/writer/document/Definitions.java
! src/share/jaxws_classes/com/sun/xml/internal/ws/wsdl/writer/document/Documented.java
! src/share/jaxws_classes/com/sun/xml/internal/ws/wsdl/writer/document/Fault.java
! src/share/jaxws_classes/com/sun/xml/internal/ws/wsdl/writer/document/FaultType.java
! src/share/jaxws_classes/com/sun/xml/internal/ws/wsdl/writer/document/Import.java
! src/share/jaxws_classes/com/sun/xml/internal/ws/wsdl/writer/document/Message.java
! src/share/jaxws_classes/com/sun/xml/internal/ws/wsdl/writer/document/OpenAtts.java
! src/share/jaxws_classes/com/sun/xml/internal/ws/wsdl/writer/document/Operation.java
! src/share/jaxws_classes/com/sun/xml/internal/ws/wsdl/writer/document/ParamType.java
! src/share/jaxws_classes/com/sun/xml/internal/ws/wsdl/writer/document/Part.java
! src/share/jaxws_classes/com/sun/xml/internal/ws/wsdl/writer/document/Port.java
! src/share/jaxws_classes/com/sun/xml/internal/ws/wsdl/writer/document/PortType.java
! src/share/jaxws_classes/com/sun/xml/internal/ws/wsdl/writer/document/Service.java
! src/share/jaxws_classes/com/sun/xml/internal/ws/wsdl/writer/document/StartWithExtensionsType.java
! src/share/jaxws_classes/com/sun/xml/internal/ws/wsdl/writer/document/Types.java
! src/share/jaxws_classes/com/sun/xml/internal/ws/wsdl/writer/document/http/Address.java
! src/share/jaxws_classes/com/sun/xml/internal/ws/wsdl/writer/document/http/Binding.java
! src/share/jaxws_classes/com/sun/xml/internal/ws/wsdl/writer/document/http/Operation.java
! src/share/jaxws_classes/com/sun/xml/internal/ws/wsdl/writer/document/http/package-info.java
! src/share/jaxws_classes/com/sun/xml/internal/ws/wsdl/writer/document/package-info.java
! src/share/jaxws_classes/com/sun/xml/internal/ws/wsdl/writer/document/soap/Body.java
! src/share/jaxws_classes/com/sun/xml/internal/ws/wsdl/writer/document/soap/BodyType.java
! src/share/jaxws_classes/com/sun/xml/internal/ws/wsdl/writer/document/soap/Header.java
! src/share/jaxws_classes/com/sun/xml/internal/ws/wsdl/writer/document/soap/HeaderFault.java
! src/share/jaxws_classes/com/sun/xml/internal/ws/wsdl/writer/document/soap/SOAPAddress.java
! src/share/jaxws_classes/com/sun/xml/internal/ws/wsdl/writer/document/soap/SOAPBinding.java
! src/share/jaxws_classes/com/sun/xml/internal/ws/wsdl/writer/document/soap/SOAPFault.java
! src/share/jaxws_classes/com/sun/xml/internal/ws/wsdl/writer/document/soap/SOAPOperation.java
! src/share/jaxws_classes/com/sun/xml/internal/ws/wsdl/writer/document/soap/package-info.java
! src/share/jaxws_classes/com/sun/xml/internal/ws/wsdl/writer/document/soap12/Body.java
! src/share/jaxws_classes/com/sun/xml/internal/ws/wsdl/writer/document/soap12/BodyType.java
! src/share/jaxws_classes/com/sun/xml/internal/ws/wsdl/writer/document/soap12/Header.java
! src/share/jaxws_classes/com/sun/xml/internal/ws/wsdl/writer/document/soap12/HeaderFault.java
! src/share/jaxws_classes/com/sun/xml/internal/ws/wsdl/writer/document/soap12/SOAPAddress.java
! src/share/jaxws_classes/com/sun/xml/internal/ws/wsdl/writer/document/soap12/SOAPBinding.java
! src/share/jaxws_classes/com/sun/xml/internal/ws/wsdl/writer/document/soap12/SOAPFault.java
! src/share/jaxws_classes/com/sun/xml/internal/ws/wsdl/writer/document/soap12/SOAPOperation.java
! src/share/jaxws_classes/com/sun/xml/internal/ws/wsdl/writer/document/soap12/package-info.java
! src/share/jaxws_classes/com/sun/xml/internal/ws/wsdl/writer/document/xsd/Import.java
! src/share/jaxws_classes/com/sun/xml/internal/ws/wsdl/writer/document/xsd/Schema.java
! src/share/jaxws_classes/com/sun/xml/internal/ws/wsdl/writer/document/xsd/package-info.java
! src/share/jaxws_classes/javax/annotation/Generated.java
! src/share/jaxws_classes/javax/annotation/PostConstruct.java
! src/share/jaxws_classes/javax/annotation/PreDestroy.java
! src/share/jaxws_classes/javax/annotation/Resource.java
! src/share/jaxws_classes/javax/annotation/Resources.java
! src/share/jaxws_classes/javax/xml/bind/ContextFinder.java
! src/share/jaxws_classes/javax/xml/bind/DatatypeConverterImpl.java
! src/share/jaxws_classes/javax/xml/bind/JAXBContext.java
! src/share/jaxws_classes/javax/xml/bind/JAXBIntrospector.java
! src/share/jaxws_classes/javax/xml/bind/JAXBPermission.java
! src/share/jaxws_classes/javax/xml/bind/Marshaller.java
! src/share/jaxws_classes/javax/xml/bind/Unmarshaller.java
! src/share/jaxws_classes/javax/xml/bind/annotation/XmlInlineBinaryData.java
! src/share/jaxws_classes/javax/xml/bind/annotation/XmlMimeType.java
! src/share/jaxws_classes/javax/xml/bind/annotation/adapters/XmlAdapter.java
! src/share/jaxws_classes/javax/xml/bind/annotation/adapters/XmlJavaTypeAdapter.java
! src/share/jaxws_classes/javax/xml/soap/AttachmentPart.java
! src/share/jaxws_classes/javax/xml/soap/Detail.java
! src/share/jaxws_classes/javax/xml/soap/DetailEntry.java
! src/share/jaxws_classes/javax/xml/soap/FactoryFinder.java
! src/share/jaxws_classes/javax/xml/soap/MessageFactory.java
! src/share/jaxws_classes/javax/xml/soap/MimeHeader.java
! src/share/jaxws_classes/javax/xml/soap/MimeHeaders.java
! src/share/jaxws_classes/javax/xml/soap/Name.java
! src/share/jaxws_classes/javax/xml/soap/Node.java
! src/share/jaxws_classes/javax/xml/soap/SAAJMetaFactory.java
! src/share/jaxws_classes/javax/xml/soap/SAAJResult.java
! src/share/jaxws_classes/javax/xml/soap/SOAPBody.java
! src/share/jaxws_classes/javax/xml/soap/SOAPBodyElement.java
! src/share/jaxws_classes/javax/xml/soap/SOAPConnection.java
! src/share/jaxws_classes/javax/xml/soap/SOAPConnectionFactory.java
! src/share/jaxws_classes/javax/xml/soap/SOAPConstants.java
! src/share/jaxws_classes/javax/xml/soap/SOAPElement.java
! src/share/jaxws_classes/javax/xml/soap/SOAPElementFactory.java
! src/share/jaxws_classes/javax/xml/soap/SOAPEnvelope.java
! src/share/jaxws_classes/javax/xml/soap/SOAPException.java
! src/share/jaxws_classes/javax/xml/soap/SOAPFactory.java
! src/share/jaxws_classes/javax/xml/soap/SOAPFault.java
! src/share/jaxws_classes/javax/xml/soap/SOAPFaultElement.java
! src/share/jaxws_classes/javax/xml/soap/SOAPHeader.java
! src/share/jaxws_classes/javax/xml/soap/SOAPHeaderElement.java
! src/share/jaxws_classes/javax/xml/soap/SOAPMessage.java
! src/share/jaxws_classes/javax/xml/soap/SOAPPart.java
! src/share/jaxws_classes/javax/xml/soap/Text.java
! src/share/jaxws_classes/javax/xml/ws/WebServiceRefs.java
! src/share/jaxws_classes/javax/xml/ws/handler/Handler.java
! src/share/jaxws_classes/javax/xml/ws/soap/AddressingFeature.java
! src/share/jaxws_classes/javax/xml/ws/soap/MTOMFeature.java
! src/share/jaxws_classes/javax/xml/ws/spi/FactoryFinder.java
! src/share/jaxws_classes/javax/xml/ws/wsaddressing/W3CEndpointReference.java

Changeset: a5e7c2f093c9
Author:    lana
Date:      2013-04-16 08:11 -0700
URL:       http://hg.openjdk.java.net/hsx/hotspot-main/jaxws/rev/a5e7c2f093c9

Merge

- src/share/jaxws_classes/com/sun/tools/internal/ws/wscompile/DefaultAuthenticator.java
- src/share/jaxws_classes/com/sun/tools/internal/xjc/api/impl/j2s/JAXBModelImpl.java
- src/share/jaxws_classes/com/sun/tools/internal/xjc/api/impl/j2s/JavaCompilerImpl.java
- src/share/jaxws_classes/com/sun/tools/internal/xjc/generator/annotation/ri/OverrideAnnotationOfWriter.java
- src/share/jaxws_classes/com/sun/tools/internal/xjc/generator/annotation/ri/XmlIsSetWriter.java
- src/share/jaxws_classes/com/sun/tools/internal/xjc/generator/annotation/ri/XmlLocationWriter.java
- src/share/jaxws_classes/com/sun/xml/internal/bind/v2/runtime/output/InPlaceDOMOutput.java
- src/share/jaxws_classes/com/sun/xml/internal/org/jvnet/ws/EnvelopeStyle.java
- src/share/jaxws_classes/com/sun/xml/internal/org/jvnet/ws/EnvelopeStyleFeature.java
- src/share/jaxws_classes/com/sun/xml/internal/org/jvnet/ws/databinding/Databinding.java
- src/share/jaxws_classes/com/sun/xml/internal/org/jvnet/ws/databinding/DatabindingFactory.java
- src/share/jaxws_classes/com/sun/xml/internal/org/jvnet/ws/databinding/DatabindingMode.java
- src/share/jaxws_classes/com/sun/xml/internal/org/jvnet/ws/databinding/DatabindingModeFeature.java
- src/share/jaxws_classes/com/sun/xml/internal/org/jvnet/ws/databinding/JavaCallInfo.java
- src/share/jaxws_classes/com/sun/xml/internal/org/jvnet/ws/message/ContentType.java
- src/share/jaxws_classes/com/sun/xml/internal/org/jvnet/ws/message/DistributedPropertySet.java
- src/share/jaxws_classes/com/sun/xml/internal/org/jvnet/ws/message/MessageContext.java
- src/share/jaxws_classes/com/sun/xml/internal/org/jvnet/ws/message/MessageContextFactory.java
- src/share/jaxws_classes/com/sun/xml/internal/org/jvnet/ws/message/PropertySet.java
- src/share/jaxws_classes/com/sun/xml/internal/ws/util/ReadOnlyPropertyException.java
- src/share/jaxws_classes/com/sun/xml/internal/ws/util/localization/Localizable.java
- src/share/jaxws_classes/com/sun/xml/internal/ws/util/localization/LocalizableImpl.java
- src/share/jaxws_classes/com/sun/xml/internal/ws/util/localization/LocalizableMessage.java
- src/share/jaxws_classes/com/sun/xml/internal/ws/util/localization/LocalizableMessageFactory.java
- src/share/jaxws_classes/com/sun/xml/internal/ws/util/localization/Localizer.java
- src/share/jaxws_classes/com/sun/xml/internal/ws/util/localization/NullLocalizable.java

Changeset: 8abe95530f58
Author:    katleman
Date:      2013-04-18 10:30 -0700
URL:       http://hg.openjdk.java.net/hsx/hotspot-main/jaxws/rev/8abe95530f58

Added tag jdk8-b86 for changeset a5e7c2f093c9

! .hgtags


From john.coomes at oracle.com  Thu Apr 18 20:34:22 2013
From: john.coomes at oracle.com (john.coomes at oracle.com)
Date: Fri, 19 Apr 2013 03:34:22 +0000
Subject: hg: hsx/hotspot-main/jdk: 50 new changesets
Message-ID: <20130419034512.584CA48446@hg.openjdk.java.net>

Changeset: 87c62f03bc07
Author:    jgodinez
Date:      2013-03-27 12:42 -0700
URL:       http://hg.openjdk.java.net/hsx/hotspot-main/jdk/rev/87c62f03bc07

8010005: [parfait] Memory leak in jdk/src/macosx/native/sun/awt/CTextPipe.m
Reviewed-by: bae, prr
Contributed-by: jia-hong.chen at oracle.com

! src/macosx/native/sun/awt/CTextPipe.m

Changeset: 9d4f539e36b6
Author:    lana
Date:      2013-04-02 17:03 -0700
URL:       http://hg.openjdk.java.net/hsx/hotspot-main/jdk/rev/9d4f539e36b6

Merge

- make/com/sun/servicetag/Makefile
- src/share/classes/com/sun/servicetag/BrowserSupport.java
- src/share/classes/com/sun/servicetag/Installer.java
- src/share/classes/com/sun/servicetag/LinuxSystemEnvironment.java
- src/share/classes/com/sun/servicetag/RegistrationData.java
- src/share/classes/com/sun/servicetag/RegistrationDocument.java
- src/share/classes/com/sun/servicetag/Registry.java
- src/share/classes/com/sun/servicetag/ServiceTag.java
- src/share/classes/com/sun/servicetag/SolarisServiceTag.java
- src/share/classes/com/sun/servicetag/SolarisSystemEnvironment.java
- src/share/classes/com/sun/servicetag/SunConnection.java
- src/share/classes/com/sun/servicetag/SystemEnvironment.java
- src/share/classes/com/sun/servicetag/UnauthorizedAccessException.java
- src/share/classes/com/sun/servicetag/Util.java
- src/share/classes/com/sun/servicetag/WindowsSystemEnvironment.java
- src/share/classes/com/sun/servicetag/package.html
- src/share/classes/com/sun/servicetag/resources/Putback-Notes.txt
- src/share/classes/com/sun/servicetag/resources/javase_5_swordfish.properties
- src/share/classes/com/sun/servicetag/resources/javase_6_swordfish.properties
- src/share/classes/com/sun/servicetag/resources/javase_7_swordfish.properties
- src/share/classes/com/sun/servicetag/resources/javase_servicetag.properties
- src/share/classes/com/sun/servicetag/resources/jdk_header.png
- src/share/classes/com/sun/servicetag/resources/product_registration.xsd
- src/share/classes/com/sun/servicetag/resources/register.html
- src/share/classes/com/sun/servicetag/resources/register_ja.html
- src/share/classes/com/sun/servicetag/resources/register_zh_CN.html
- test/com/sun/servicetag/DeleteServiceTag.java
- test/com/sun/servicetag/DuplicateNotFound.java
- test/com/sun/servicetag/FindServiceTags.java
- test/com/sun/servicetag/InstanceUrnCheck.java
- test/com/sun/servicetag/InvalidRegistrationData.java
- test/com/sun/servicetag/InvalidServiceTag.java
- test/com/sun/servicetag/JavaServiceTagTest.java
- test/com/sun/servicetag/JavaServiceTagTest1.java
- test/com/sun/servicetag/NewRegistrationData.java
- test/com/sun/servicetag/SvcTagClient.java
- test/com/sun/servicetag/SystemRegistryTest.java
- test/com/sun/servicetag/TestLoadFromXML.java
- test/com/sun/servicetag/UpdateServiceTagTest.java
- test/com/sun/servicetag/Util.java
- test/com/sun/servicetag/ValidRegistrationData.java
- test/com/sun/servicetag/environ.properties
- test/com/sun/servicetag/missing-environ-field.xml
- test/com/sun/servicetag/newer-registry-version.xml
- test/com/sun/servicetag/registration.xml
- test/com/sun/servicetag/servicetag1.properties
- test/com/sun/servicetag/servicetag2.properties
- test/com/sun/servicetag/servicetag3.properties
- test/com/sun/servicetag/servicetag4.properties
- test/com/sun/servicetag/servicetag5.properties
- test/sun/tools/jstat/gcPermCapacityOutput1.awk
- test/sun/tools/jstat/jstatGcPermCapacityOutput1.sh

Changeset: 2904672aed21
Author:    lana
Date:      2013-04-09 14:59 -0700
URL:       http://hg.openjdk.java.net/hsx/hotspot-main/jdk/rev/2904672aed21

Merge


Changeset: 96750ebc769b
Author:    denis
Date:      2013-03-27 16:19 +0400
URL:       http://hg.openjdk.java.net/hsx/hotspot-main/jdk/rev/96750ebc769b

7075105: WIN: Provide a way to format HTML on drop
Reviewed-by: uta, serb

! src/macosx/classes/sun/lwawt/macosx/CDataTransferer.java
! src/share/classes/java/awt/datatransfer/DataFlavor.java
! src/share/classes/java/awt/datatransfer/SystemFlavorMap.java
! src/share/classes/sun/awt/datatransfer/DataTransferer.java
! src/share/classes/sun/awt/dnd/SunDropTargetContextPeer.java
! src/solaris/classes/sun/awt/X11/XDataTransferer.java
! src/windows/classes/sun/awt/windows/WDataTransferer.java
+ test/java/awt/datatransfer/HTMLDataFlavors/HTMLDataFlavorTest.java
+ test/java/awt/datatransfer/HTMLDataFlavors/HtmlTransferable.java
+ test/java/awt/datatransfer/HTMLDataFlavors/ManualHTMLDataFlavorTest.html
+ test/java/awt/datatransfer/HTMLDataFlavors/ManualHTMLDataFlavorTest.java
+ test/java/awt/datatransfer/HTMLDataFlavors/PutAllHtmlFlavorsOnClipboard.java
+ test/java/awt/datatransfer/HTMLDataFlavors/PutOnlyAllHtmlFlavorOnClipboard.java
+ test/java/awt/datatransfer/HTMLDataFlavors/PutSelectionAndFragmentHtmlFlavorsOnClipboard.java

Changeset: 29570523b6cb
Author:    ant
Date:      2013-03-29 16:12 +0400
URL:       http://hg.openjdk.java.net/hsx/hotspot-main/jdk/rev/29570523b6cb

8010375: sun.swing.JLightweightFrame should be implemented for XToolkit
Reviewed-by: anthony

! src/share/classes/sun/swing/JLightweightFrame.java
! src/solaris/classes/sun/awt/X11/XFramePeer.java
+ src/solaris/classes/sun/awt/X11/XLightweightFramePeer.java
! src/solaris/classes/sun/awt/X11/XToolkit.java

Changeset: c23d58901aa6
Author:    lana
Date:      2013-04-02 16:17 -0700
URL:       http://hg.openjdk.java.net/hsx/hotspot-main/jdk/rev/c23d58901aa6

Merge

- make/com/sun/servicetag/Makefile
- src/share/classes/com/sun/servicetag/BrowserSupport.java
- src/share/classes/com/sun/servicetag/Installer.java
- src/share/classes/com/sun/servicetag/LinuxSystemEnvironment.java
- src/share/classes/com/sun/servicetag/RegistrationData.java
- src/share/classes/com/sun/servicetag/RegistrationDocument.java
- src/share/classes/com/sun/servicetag/Registry.java
- src/share/classes/com/sun/servicetag/ServiceTag.java
- src/share/classes/com/sun/servicetag/SolarisServiceTag.java
- src/share/classes/com/sun/servicetag/SolarisSystemEnvironment.java
- src/share/classes/com/sun/servicetag/SunConnection.java
- src/share/classes/com/sun/servicetag/SystemEnvironment.java
- src/share/classes/com/sun/servicetag/UnauthorizedAccessException.java
- src/share/classes/com/sun/servicetag/Util.java
- src/share/classes/com/sun/servicetag/WindowsSystemEnvironment.java
- src/share/classes/com/sun/servicetag/package.html
- src/share/classes/com/sun/servicetag/resources/Putback-Notes.txt
- src/share/classes/com/sun/servicetag/resources/javase_5_swordfish.properties
- src/share/classes/com/sun/servicetag/resources/javase_6_swordfish.properties
- src/share/classes/com/sun/servicetag/resources/javase_7_swordfish.properties
- src/share/classes/com/sun/servicetag/resources/javase_servicetag.properties
- src/share/classes/com/sun/servicetag/resources/jdk_header.png
- src/share/classes/com/sun/servicetag/resources/product_registration.xsd
- src/share/classes/com/sun/servicetag/resources/register.html
- src/share/classes/com/sun/servicetag/resources/register_ja.html
- src/share/classes/com/sun/servicetag/resources/register_zh_CN.html
- test/com/sun/servicetag/DeleteServiceTag.java
- test/com/sun/servicetag/DuplicateNotFound.java
- test/com/sun/servicetag/FindServiceTags.java
- test/com/sun/servicetag/InstanceUrnCheck.java
- test/com/sun/servicetag/InvalidRegistrationData.java
- test/com/sun/servicetag/InvalidServiceTag.java
- test/com/sun/servicetag/JavaServiceTagTest.java
- test/com/sun/servicetag/JavaServiceTagTest1.java
- test/com/sun/servicetag/NewRegistrationData.java
- test/com/sun/servicetag/SvcTagClient.java
- test/com/sun/servicetag/SystemRegistryTest.java
- test/com/sun/servicetag/TestLoadFromXML.java
- test/com/sun/servicetag/UpdateServiceTagTest.java
- test/com/sun/servicetag/Util.java
- test/com/sun/servicetag/ValidRegistrationData.java
- test/com/sun/servicetag/environ.properties
- test/com/sun/servicetag/missing-environ-field.xml
- test/com/sun/servicetag/newer-registry-version.xml
- test/com/sun/servicetag/registration.xml
- test/com/sun/servicetag/servicetag1.properties
- test/com/sun/servicetag/servicetag2.properties
- test/com/sun/servicetag/servicetag3.properties
- test/com/sun/servicetag/servicetag4.properties
- test/com/sun/servicetag/servicetag5.properties
- test/sun/tools/jstat/gcPermCapacityOutput1.awk
- test/sun/tools/jstat/jstatGcPermCapacityOutput1.sh

Changeset: 36cb7921bc98
Author:    mcherkas
Date:      2013-04-03 20:42 +0400
URL:       http://hg.openjdk.java.net/hsx/hotspot-main/jdk/rev/36cb7921bc98

8011123: serialVersionUID of java.awt.dnd.InvalidDnDOperationException changed in JDK8-b82
Reviewed-by: anthony, serb

! src/share/classes/java/awt/dnd/InvalidDnDOperationException.java

Changeset: 35da3878deef
Author:    mcherkas
Date:      2013-04-03 20:54 +0400
URL:       http://hg.openjdk.java.net/hsx/hotspot-main/jdk/rev/35da3878deef

8010925: COPY AND PASTE TO AND FROM SIGNED APPLET FAILS AFTER FIRST INTERNAL COPY PRFRMD
Reviewed-by: anthony, serb

! src/macosx/classes/sun/lwawt/macosx/CClipboard.java
! src/macosx/classes/sun/lwawt/macosx/CEmbeddedFrame.java
! src/macosx/native/sun/awt/CClipboard.m

Changeset: 2c36899500a0
Author:    pchelko
Date:      2013-04-05 18:29 +0100
URL:       http://hg.openjdk.java.net/hsx/hotspot-main/jdk/rev/2c36899500a0

8006941: [macosx] Deadlock in drag and drop
7199783: Setting cursor on DragSourceContext does not work on OSX
Reviewed-by: anthony, serb

! src/macosx/classes/sun/lwawt/LWComponentPeer.java
! src/macosx/classes/sun/lwawt/macosx/CCursorManager.java
! src/macosx/classes/sun/lwawt/macosx/CDragSourceContextPeer.java
! src/macosx/classes/sun/lwawt/macosx/CDropTarget.java
! src/macosx/classes/sun/lwawt/macosx/CPlatformWindow.java
! src/macosx/native/sun/awt/CDragSource.h
! src/macosx/native/sun/awt/CDragSource.m
! src/macosx/native/sun/awt/CDragSourceContextPeer.m
! src/macosx/native/sun/awt/CDropTarget.m
! src/share/classes/sun/awt/dnd/SunDragSourceContextPeer.java
+ test/java/awt/dnd/DisposeFrameOnDragCrash/DisposeFrameOnDragTest.java

Changeset: 0b083b0e8e63
Author:    kshefov
Date:      2013-04-08 17:18 +0400
URL:       http://hg.openjdk.java.net/hsx/hotspot-main/jdk/rev/0b083b0e8e63

7153702: [TEST_BUG] [macosx] Synchronization problem in test javax/swing/JPopupMenu/6827786/bug6827786.java
Reviewed-by: serb, alexsch

! test/javax/swing/JPopupMenu/6827786/bug6827786.java

Changeset: 981142561d1b
Author:    lana
Date:      2013-04-09 15:01 -0700
URL:       http://hg.openjdk.java.net/hsx/hotspot-main/jdk/rev/981142561d1b

Merge


Changeset: 3b56ef8e1ce1
Author:    martin
Date:      2013-03-26 13:34 -0700
URL:       http://hg.openjdk.java.net/hsx/hotspot-main/jdk/rev/3b56ef8e1ce1

8007905: To add a system property to create zip file without using ZIP64 end table when entry count > 64k
Summary: Provide a system property to inhibit ZIP64 mode for >64k entries
Reviewed-by: alanb, sherman

! src/share/classes/java/util/zip/ZipOutputStream.java
+ test/java/util/zip/EntryCount64k.java

Changeset: 266b43683a2c
Author:    martin
Date:      2013-03-26 13:36 -0700
URL:       http://hg.openjdk.java.net/hsx/hotspot-main/jdk/rev/266b43683a2c

8010316: Improve handling of char sequences containing surrogates
Summary: Fix and optimize codePointAt, codePointBefore and similar methods
Reviewed-by: sherman, okutsu, ulfzibis, kizune

! src/share/classes/java/lang/AbstractStringBuilder.java
! src/share/classes/java/lang/Character.java
! test/java/lang/StringBuilder/Supplementary.java

Changeset: caafe6dca35d
Author:    ehelin
Date:      2013-03-21 20:35 +0100
URL:       http://hg.openjdk.java.net/hsx/hotspot-main/jdk/rev/caafe6dca35d

8009427: Re-enable tests that were disable to ease complicated push
Reviewed-by: sla, mchung, dcubed
Contributed-by: Erik Helin 

! test/ProblemList.txt

Changeset: 49602f599c08
Author:    dxu
Date:      2013-03-27 09:00 -0700
URL:       http://hg.openjdk.java.net/hsx/hotspot-main/jdk/rev/49602f599c08

8010837: FileInputStream.available() throw IOException when encountering negative available values
Summary: Remove the check in the native code to allow negative values
Reviewed-by: mchung

! src/solaris/native/java/io/io_util_md.c
+ test/java/io/FileInputStream/NegativeAvailable.java

Changeset: ae03282ba501
Author:    darcy
Date:      2013-03-27 09:38 -0700
URL:       http://hg.openjdk.java.net/hsx/hotspot-main/jdk/rev/ae03282ba501

7185456: (ann) Optimize Annotation handling in java/sun.reflect.* code for small number of annotations
Reviewed-by: mduigou, jfranck

! src/share/classes/sun/reflect/annotation/AnnotationType.java

Changeset: d254a5f9b93f
Author:    acorn
Date:      2013-03-27 13:40 -0400
URL:       http://hg.openjdk.java.net/hsx/hotspot-main/jdk/rev/d254a5f9b93f

8010846: Update the corresponding test in test/vm/verifier/TestStaticIF.java
Summary: Remove test flag -XX:-UseSplitVerifier, not supported classfile 52
Reviewed-by: acorn, hseigel

! test/vm/verifier/TestStaticIF.java

Changeset: 811c771acf65
Author:    sundar
Date:      2013-03-28 14:36 +0530
URL:       http://hg.openjdk.java.net/hsx/hotspot-main/jdk/rev/811c771acf65

8010991: Enable test/javax/script/GetInterfaceTest.java again
Reviewed-by: lagergren, hannesw

! test/javax/script/GetInterfaceTest.java

Changeset: a87fac00915e
Author:    weijun
Date:      2013-03-28 20:27 +0800
URL:       http://hg.openjdk.java.net/hsx/hotspot-main/jdk/rev/a87fac00915e

8010125: keytool -importkeystore could create a pkcs12 keystore with different storepass and keypass
Reviewed-by: vinnie

! src/share/classes/sun/security/tools/keytool/Main.java
! src/share/classes/sun/security/tools/keytool/Resources.java
+ test/sun/security/tools/keytool/p12importks.sh

Changeset: e433ed08b733
Author:    mchung
Date:      2013-03-28 13:14 -0700
URL:       http://hg.openjdk.java.net/hsx/hotspot-main/jdk/rev/e433ed08b733

8010309: Improve PlatformLogger.isLoggable performance by direct mapping from an integer to Level
Reviewed-by: mchung
Contributed-by: peter.levart at gmail.com, bourges.laurent at gmail.com

! src/share/classes/sun/util/logging/PlatformLogger.java
! test/sun/util/logging/PlatformLoggerTest.java

Changeset: b590bd37a6d0
Author:    mduigou
Date:      2013-04-01 12:02 -0700
URL:       http://hg.openjdk.java.net/hsx/hotspot-main/jdk/rev/b590bd37a6d0

8010268: Remove dependence upon clean target from jdk/test/Makefile prep target
Reviewed-by: tbell, mchung

! test/Makefile

Changeset: 0cccdb9a9a4c
Author:    mduigou
Date:      2013-04-01 20:15 -0700
URL:       http://hg.openjdk.java.net/hsx/hotspot-main/jdk/rev/0cccdb9a9a4c

7143928: Optimize empty HashMap and ArrayList
Reviewed-by: mduigou
Contributed-by: Sergey Linetskiy , John Rose , Mike Duigou 

! src/share/classes/java/util/ArrayList.java
! src/share/classes/java/util/HashMap.java
+ test/java/util/Map/BasicSerialization.java

Changeset: 5ee837ba093a
Author:    mduigou
Date:      2013-04-01 20:15 -0700
URL:       http://hg.openjdk.java.net/hsx/hotspot-main/jdk/rev/5ee837ba093a

8011187: Remove obsolete/unused targets from jdk/test/Makefile
Reviewed-by: ohair

! test/Makefile

Changeset: de228734b742
Author:    mduigou
Date:      2013-04-01 20:51 -0700
URL:       http://hg.openjdk.java.net/hsx/hotspot-main/jdk/rev/de228734b742

8011199: Backout changeset JDK-7143928 (0cccdb9a9a4c)
Reviewed-by: darcy, dholmes

! src/share/classes/java/util/ArrayList.java
! src/share/classes/java/util/HashMap.java
- test/java/util/Map/BasicSerialization.java

Changeset: f1b89d4cce82
Author:    sla
Date:      2013-04-02 10:32 +0200
URL:       http://hg.openjdk.java.net/hsx/hotspot-main/jdk/rev/f1b89d4cce82

8009558: linked_md.c::dll_build_name can get stuck in an infinite loop
Reviewed-by: alanb, sspitsyn

! src/share/back/export/sys.h
! src/share/back/transport.c
! src/share/demo/jvmti/hprof/hprof_md.h
! src/solaris/back/linker_md.c
! src/solaris/demo/jvmti/hprof/hprof_md.c
! src/windows/back/linker_md.c
! src/windows/demo/jvmti/hprof/hprof_md.c

Changeset: e6c3b8e74e50
Author:    sherman
Date:      2013-04-02 10:12 -0700
URL:       http://hg.openjdk.java.net/hsx/hotspot-main/jdk/rev/e6c3b8e74e50

8007379: Base64.getMimeDecoder().decode() throws IAE for a non-base64 character after padding
8008925: Base64.getMimeDecoder().decode() does not ignore padding chars
Summary: updated implementation and spec for corner cases.
Reviewed-by: alanb

! src/share/classes/java/util/Base64.java
! test/java/util/Base64/TestBase64.java

Changeset: 7fbae9125437
Author:    lana
Date:      2013-04-02 11:59 -0700
URL:       http://hg.openjdk.java.net/hsx/hotspot-main/jdk/rev/7fbae9125437

Merge


Changeset: b4f68aca1000
Author:    darcy
Date:      2013-04-02 16:26 -0700
URL:       http://hg.openjdk.java.net/hsx/hotspot-main/jdk/rev/b4f68aca1000

8004979: java.lang.reflect.Modifier.toString should include "default"
Reviewed-by: mduigou

! src/share/classes/java/lang/reflect/Constructor.java
! src/share/classes/java/lang/reflect/Executable.java
! src/share/classes/java/lang/reflect/Field.java
! src/share/classes/java/lang/reflect/Method.java
! src/share/classes/java/lang/reflect/Modifier.java
! test/java/lang/reflect/Method/GenericStringTest.java

Changeset: c534937f6e94
Author:    alanb
Date:      2013-04-03 13:15 +0100
URL:       http://hg.openjdk.java.net/hsx/hotspot-main/jdk/rev/c534937f6e94

8011234: Performance regression with ftp protocol when uploading in image mode
Reviewed-by: chegar

! src/share/classes/sun/net/ftp/impl/FtpClient.java

Changeset: eb8f7bc6f964
Author:    alanb
Date:      2013-04-03 13:41 +0100
URL:       http://hg.openjdk.java.net/hsx/hotspot-main/jdk/rev/eb8f7bc6f964

8011373: Property java.runtime.profile should be removed (left-over code)
Reviewed-by: lancea, dholmes

! src/share/classes/sun/misc/Version.java.template

Changeset: 27ae4f9c7826
Author:    lancea
Date:      2013-04-03 12:47 -0400
URL:       http://hg.openjdk.java.net/hsx/hotspot-main/jdk/rev/27ae4f9c7826

8011393: Typo in javadoc for SerialClob.truncate
Reviewed-by: darcy

! src/share/classes/javax/sql/rowset/serial/SerialClob.java

Changeset: 9a6ef3391f32
Author:    naoto
Date:      2013-04-03 10:32 -0700
URL:       http://hg.openjdk.java.net/hsx/hotspot-main/jdk/rev/9a6ef3391f32

7091601: Arabic Locale: can not set type of digit in application level
Reviewed-by: okutsu

! src/macosx/native/sun/util/locale/provider/HostLocaleProviderAdapter_md.c
! src/windows/classes/sun/util/locale/provider/HostLocaleProviderAdapterImpl.java

Changeset: 7b1189bf1d7b
Author:    dxu
Date:      2013-04-04 15:39 -0700
URL:       http://hg.openjdk.java.net/hsx/hotspot-main/jdk/rev/7b1189bf1d7b

8000406: change files using @GenerateNativeHeader to use @Native
Summary: Use @Native annotation to mark constants interested by native codes
Reviewed-by: alanb, anthony, prr

! src/macosx/classes/apple/laf/JRSUIConstants.java
! src/macosx/classes/com/apple/eawt/FullScreenHandler.java
! src/macosx/classes/com/apple/eawt/event/GestureHandler.java
! src/macosx/classes/sun/java2d/OSXSurfaceData.java
! src/macosx/classes/sun/lwawt/macosx/CocoaConstants.java
! src/macosx/native/jobjc/src/core/PrimitiveCoder.hs
! src/macosx/native/jobjc/src/core/java/com/apple/jobjc/CFType.java
! src/macosx/native/jobjc/src/core/java/com/apple/jobjc/Coder.java
! src/macosx/native/jobjc/src/core/java/com/apple/jobjc/FFIType.java
! src/macosx/native/jobjc/src/core/java/com/apple/jobjc/Function.java
! src/macosx/native/jobjc/src/core/java/com/apple/jobjc/ID.java
! src/macosx/native/jobjc/src/core/java/com/apple/jobjc/Invoke.java
! src/macosx/native/jobjc/src/core/java/com/apple/jobjc/JObjCRuntime.java
! src/macosx/native/jobjc/src/core/java/com/apple/jobjc/MacOSXFramework.java
! src/macosx/native/jobjc/src/core/java/com/apple/jobjc/NSClass.java
! src/macosx/native/jobjc/src/core/java/com/apple/jobjc/NativeArgumentBuffer.java
! src/macosx/native/jobjc/src/core/java/com/apple/jobjc/NativeBuffer.java
! src/macosx/native/jobjc/src/core/java/com/apple/jobjc/NativeObjectLifecycleManager.java
! src/macosx/native/jobjc/src/core/java/com/apple/jobjc/Opaque.java
! src/macosx/native/jobjc/src/core/java/com/apple/jobjc/Pointer.java
! src/macosx/native/jobjc/src/core/java/com/apple/jobjc/PrimitiveCoder.java
! src/macosx/native/jobjc/src/core/java/com/apple/jobjc/SEL.java
! src/macosx/native/jobjc/src/core/java/com/apple/jobjc/Struct.java
! src/macosx/native/jobjc/src/core/java/com/apple/jobjc/Subclassing.java
! src/macosx/native/jobjc/src/core/native/Invoke.m
! src/macosx/native/jobjc/src/core/native/JObjCRuntime.m
! src/macosx/native/sun/awt/PrinterView.m
! src/share/classes/java/awt/Adjustable.java
! src/share/classes/java/awt/AlphaComposite.java
! src/share/classes/java/awt/BasicStroke.java
! src/share/classes/java/awt/Choice.java
! src/share/classes/java/awt/DisplayMode.java
! src/share/classes/java/awt/Image.java
! src/share/classes/java/awt/List.java
! src/share/classes/java/awt/PopupMenu.java
! src/share/classes/java/awt/SystemColor.java
! src/share/classes/java/awt/TextComponent.java
! src/share/classes/java/awt/Transparency.java
! src/share/classes/java/awt/color/ColorSpace.java
! src/share/classes/java/awt/color/ICC_Profile.java
! src/share/classes/java/awt/datatransfer/StringSelection.java
! src/share/classes/java/awt/dnd/DnDConstants.java
! src/share/classes/java/awt/event/ActionEvent.java
! src/share/classes/java/awt/event/AdjustmentEvent.java
! src/share/classes/java/awt/event/ComponentEvent.java
! src/share/classes/java/awt/event/FocusEvent.java
! src/share/classes/java/awt/event/InputMethodEvent.java
! src/share/classes/java/awt/event/MouseWheelEvent.java
! src/share/classes/java/awt/event/WindowEvent.java
! src/share/classes/java/awt/geom/PathIterator.java
! src/share/classes/java/awt/image/AffineTransformOp.java
! src/share/classes/java/awt/image/ConvolveOp.java
! src/share/classes/java/awt/image/DataBuffer.java
! src/share/classes/java/awt/image/ImageConsumer.java
! src/share/classes/java/awt/image/ImageObserver.java
! src/share/classes/java/awt/peer/ComponentPeer.java
! src/share/classes/java/awt/print/PageFormat.java
! src/share/classes/java/awt/print/Pageable.java
! src/share/classes/java/awt/print/Printable.java
! src/share/classes/sun/awt/EmbeddedFrame.java
! src/share/classes/sun/awt/SunHints.java
! src/share/classes/sun/awt/dnd/SunDragSourceContextPeer.java
! src/share/classes/sun/awt/image/BufImgSurfaceData.java
! src/share/classes/sun/font/FontManager.java
! src/share/classes/sun/java2d/SunGraphics2D.java
! src/share/classes/sun/java2d/opengl/OGLBlitLoops.java
! src/share/classes/sun/java2d/opengl/OGLContext.java
! src/share/classes/sun/java2d/pipe/BufferedContext.java
! src/share/classes/sun/java2d/pipe/BufferedOpCodes.java
! src/share/classes/sun/java2d/pipe/BufferedPaints.java
! src/share/classes/sun/java2d/pipe/BufferedTextPipe.java
! src/share/classes/sun/java2d/pipe/RenderBuffer.java
! src/share/classes/sun/java2d/pipe/hw/AccelDeviceEventNotifier.java
! src/share/classes/sun/java2d/pipe/hw/AccelSurface.java
! src/share/classes/sun/java2d/pipe/hw/ContextCapabilities.java
! src/share/classes/sun/nio/ch/DatagramChannelImpl.java
! src/share/classes/sun/nio/ch/sctp/SctpStdSocketOption.java
! src/share/classes/sun/security/pkcs11/Secmod.java
! src/share/classes/sun/security/pkcs11/wrapper/PKCS11.java
! src/solaris/classes/sun/awt/X11/XComponentPeer.java
! src/solaris/classes/sun/nio/ch/sctp/AssociationChange.java
! src/solaris/classes/sun/nio/ch/sctp/PeerAddrChange.java
! src/solaris/classes/sun/nio/ch/sctp/ResultContainer.java
! src/solaris/native/sun/awt/awt_InputMethod.c
! src/solaris/native/sun/awt/fontpath.c
! src/windows/classes/sun/java2d/d3d/D3DBlitLoops.java
! src/windows/classes/sun/java2d/d3d/D3DContext.java
! src/windows/classes/sun/java2d/d3d/D3DPaints.java
! src/windows/native/sun/java2d/d3d/D3DContext.h
! src/windows/native/sun/windows/awt_Component.h
! src/windows/native/sun/windows/awt_DnDDS.cpp
! src/windows/native/sun/windows/awt_Frame.cpp
! src/windows/native/sun/windows/awt_List.h
! src/windows/native/sun/windows/awt_PopupMenu.cpp
! src/windows/native/sun/windows/awt_PopupMenu.h
! src/windows/native/sun/windows/awt_TextComponent.h
! src/windows/native/sun/windows/awt_Toolkit.cpp

Changeset: 7d4e30730f80
Author:    valeriep
Date:      2013-04-04 20:05 -0700
URL:       http://hg.openjdk.java.net/hsx/hotspot-main/jdk/rev/7d4e30730f80

7155720: PKCS11 minor issues in native code
Summary: Added OOM handling to address the two issues found by parfait.
Reviewed-by: weijun

! src/solaris/native/sun/security/pkcs11/wrapper/p11_md.c

Changeset: b62a76763bf3
Author:    mchung
Date:      2013-04-05 10:41 -0700
URL:       http://hg.openjdk.java.net/hsx/hotspot-main/jdk/rev/b62a76763bf3

8011380: FX dependency on PlatformLogger broken by 8010309
Reviewed-by: alanb

! src/share/classes/java/util/logging/LoggingProxyImpl.java
! src/share/classes/sun/util/logging/LoggingProxy.java
! src/share/classes/sun/util/logging/LoggingSupport.java
! src/share/classes/sun/util/logging/PlatformLogger.java
! test/sun/util/logging/PlatformLoggerTest.java

Changeset: b702977e7212
Author:    khazra
Date:      2013-04-05 12:12 -0700
URL:       http://hg.openjdk.java.net/hsx/hotspot-main/jdk/rev/b702977e7212

5001942: Missings SOCKS support for direct connections
Summary: Add support for socksNonProxyHosts
Reviewed-by: chegar, khazra
Contributed-by: Christos Zoulas 

! src/share/classes/sun/net/spi/DefaultProxySelector.java
! test/java/net/Socks/SocksProxyVersion.java

Changeset: ba231ac2890a
Author:    lana
Date:      2013-04-05 14:51 -0700
URL:       http://hg.openjdk.java.net/hsx/hotspot-main/jdk/rev/ba231ac2890a

Merge


Changeset: 785f3a04ee05
Author:    dxu
Date:      2013-04-05 17:15 -0700
URL:       http://hg.openjdk.java.net/hsx/hotspot-main/jdk/rev/785f3a04ee05

8011602: jobjc build failure on Mac
Summary: Remove @Native annotation from macosx/native/jobjc/src/core/java/com/apple/jobjc/Coder.java
Reviewed-by: mchung, dholmes

! src/macosx/native/jobjc/src/core/java/com/apple/jobjc/Coder.java
! src/share/classes/sun/java2d/opengl/OGLContext.java

Changeset: 16f63a94c231
Author:    darcy
Date:      2013-04-05 18:20 -0700
URL:       http://hg.openjdk.java.net/hsx/hotspot-main/jdk/rev/16f63a94c231

8011590: More tests for core reflection modeling of default methods
Reviewed-by: mduigou

+ test/java/lang/reflect/Method/DefaultMethodModeling.java

Changeset: 04617e462512
Author:    lancea
Date:      2013-04-08 15:29 -0400
URL:       http://hg.openjdk.java.net/hsx/hotspot-main/jdk/rev/04617e462512

8006036: (process) cleanup code in java/lang/Runtime/exec/WinCommand.java
Reviewed-by: lancea
Contributed-by: Jim Gish 

! test/java/lang/Runtime/exec/WinCommand.java

Changeset: 3db793b080d8
Author:    martin
Date:      2013-04-08 16:37 -0700
URL:       http://hg.openjdk.java.net/hsx/hotspot-main/jdk/rev/3db793b080d8

8010849: (str) Optimize StringBuilder.append(null)
Summary: Append 4 chars instead of the string "null"
Reviewed-by: mduigou, forax, jgish

! src/share/classes/java/lang/AbstractStringBuilder.java

Changeset: 3e5a18c3e599
Author:    darcy
Date:      2013-04-08 17:06 -0700
URL:       http://hg.openjdk.java.net/hsx/hotspot-main/jdk/rev/3e5a18c3e599

6298888: Add toGenericString to j.l.Class and getTypeName to j.l.reflect.Type
6992705: Include modifiers in Class.toGenericString()
Summary: Class.toGenericString and supporting changes; additional reviews by Peter Levart
Reviewed-by: alanb

! src/share/classes/java/lang/Class.java
! src/share/classes/java/lang/reflect/Constructor.java
! src/share/classes/java/lang/reflect/Executable.java
! src/share/classes/java/lang/reflect/Field.java
! src/share/classes/java/lang/reflect/Method.java
! src/share/classes/java/lang/reflect/Modifier.java
! src/share/classes/java/lang/reflect/Parameter.java
! src/share/classes/java/lang/reflect/Type.java
+ test/java/lang/Class/GenericStringTest.java

Changeset: 57e9eaeca323
Author:    alanb
Date:      2013-04-09 15:51 +0100
URL:       http://hg.openjdk.java.net/hsx/hotspot-main/jdk/rev/57e9eaeca323

8010393: Update JAX-WS RI to 2.2.9-b12941
Reviewed-by: mullan

! src/share/lib/security/java.security-linux
! src/share/lib/security/java.security-macosx
! src/share/lib/security/java.security-solaris
! src/share/lib/security/java.security-windows

Changeset: 50bc8e085a09
Author:    chegar
Date:      2013-04-09 17:27 +0100
URL:       http://hg.openjdk.java.net/hsx/hotspot-main/jdk/rev/50bc8e085a09

8005696: Add CompletableFuture
Reviewed-by: chegar, martin

! make/java/java/FILES_java.gmk
+ src/share/classes/java/util/concurrent/CompletableFuture.java
+ src/share/classes/java/util/concurrent/CompletionException.java
+ test/java/util/concurrent/CompletableFuture/Basic.java

Changeset: f304311cfe9f
Author:    lana
Date:      2013-04-09 15:14 -0700
URL:       http://hg.openjdk.java.net/hsx/hotspot-main/jdk/rev/f304311cfe9f

Merge

! src/share/classes/sun/awt/dnd/SunDragSourceContextPeer.java

Changeset: 6e3763e737b0
Author:    lana
Date:      2013-04-16 08:14 -0700
URL:       http://hg.openjdk.java.net/hsx/hotspot-main/jdk/rev/6e3763e737b0

Merge


Changeset: e5c5e369af6a
Author:    katleman
Date:      2013-04-12 15:22 -0700
URL:       http://hg.openjdk.java.net/hsx/hotspot-main/jdk/rev/e5c5e369af6a

8012048: JDK8 b85 source with GPL header errors
Reviewed-by: iris, mduigou, jjg

! src/share/classes/com/sun/crypto/provider/GaloisCounterMode.java
! src/share/classes/java/util/function/DoublePredicate.java
! src/share/classes/java/util/function/IntPredicate.java
! src/share/classes/java/util/function/LongPredicate.java
! src/share/classes/java/util/function/ObjIntConsumer.java
! src/share/classes/java/util/function/ToDoubleBiFunction.java
! test/java/lang/System/MacJNUEncoding/MacJNUEncoding.sh
! test/java/lang/reflect/Method/IsDefaultTest.java
! test/java/net/URLConnection/RequestProperties.java
! test/java/util/Optional/BasicDouble.java
! test/javax/swing/text/html/7189299/bug7189299.java
! test/sun/management/jdp/JdpTest.sh
! test/sun/misc/URLClassPath/JarLoaderTest.java
! test/sun/util/calendar/zi/ZoneInfoFile.java

Changeset: b45456703c65
Author:    katleman
Date:      2013-04-15 14:20 -0700
URL:       http://hg.openjdk.java.net/hsx/hotspot-main/jdk/rev/b45456703c65

Merge


Changeset: 7989cd0cc3a9
Author:    katleman
Date:      2013-04-16 15:00 -0700
URL:       http://hg.openjdk.java.net/hsx/hotspot-main/jdk/rev/7989cd0cc3a9

Merge


Changeset: f4c62eecf7fa
Author:    katleman
Date:      2013-04-18 10:30 -0700
URL:       http://hg.openjdk.java.net/hsx/hotspot-main/jdk/rev/f4c62eecf7fa

Added tag jdk8-b86 for changeset 7989cd0cc3a9

! .hgtags


From john.coomes at oracle.com  Thu Apr 18 20:49:52 2013
From: john.coomes at oracle.com (john.coomes at oracle.com)
Date: Fri, 19 Apr 2013 03:49:52 +0000
Subject: hg: hsx/hotspot-main/nashorn: 33 new changesets
Message-ID: <20130419035016.42E5B48448@hg.openjdk.java.net>

Changeset: 41a212ea8c0c
Author:    sundar
Date:      2013-03-28 20:48 +0530
URL:       http://hg.openjdk.java.net/hsx/hotspot-main/nashorn/rev/41a212ea8c0c

8010924: Dealing with undefined property gets you a fatal stack
Reviewed-by: lagergren, jlaskey

! src/jdk/nashorn/internal/runtime/resources/mozilla_compat.js
+ test/script/basic/JDK-8010924.js

Changeset: e2ea7a29b9c1
Author:    lagergren
Date:      2013-03-29 08:55 +0100
URL:       http://hg.openjdk.java.net/hsx/hotspot-main/nashorn/rev/e2ea7a29b9c1

8010995: The bug ID 8010710 accidentally got two digits transposed in the checkin and unit test name
Reviewed-by: hannesw, sundar

+ test/script/basic/JDK-8010710.js
+ test/script/basic/JDK-8010710.js.EXPECTED
- test/script/basic/JDK-8017010.js
- test/script/basic/JDK-8017010.js.EXPECTED

Changeset: 704f3083af8a
Author:    sundar
Date:      2013-03-29 18:38 +0530
URL:       http://hg.openjdk.java.net/hsx/hotspot-main/nashorn/rev/704f3083af8a

8011063: With older ant, we get the error "The  type doesn't support nested text data ("${run.te...jvmargs}")."
Reviewed-by: hannesw, ksrini

! make/build.xml

Changeset: a094fc010120
Author:    jlaskey
Date:      2013-03-31 08:19 -0300
URL:       http://hg.openjdk.java.net/hsx/hotspot-main/nashorn/rev/a094fc010120

8011095: PropertyHashMap.rehash() does not grow enough
Reviewed-by: hannesw, lagergren
Contributed-by: james.laskey at oracle.com

! src/jdk/nashorn/internal/runtime/PropertyHashMap.java
! src/jdk/nashorn/internal/runtime/PropertyMap.java

Changeset: 3e4369fb810b
Author:    hannesw
Date:      2013-04-02 13:55 +0200
URL:       http://hg.openjdk.java.net/hsx/hotspot-main/nashorn/rev/3e4369fb810b

8011219: Regression with recent PropertyMap history changes
Reviewed-by: jlaskey, lagergren

! src/jdk/nashorn/internal/runtime/PropertyMap.java

Changeset: 5362d96d5915
Author:    sundar
Date:      2013-04-02 17:40 +0530
URL:       http://hg.openjdk.java.net/hsx/hotspot-main/nashorn/rev/5362d96d5915

8011209: Object.getOwnPropertyDescriptor(function(){"use strict"},"caller").get.length is not 0
Reviewed-by: lagergren, hannesw, jlaskey

! src/jdk/nashorn/internal/objects/ScriptFunctionImpl.java
+ test/script/basic/JDK-8011209.js

Changeset: 9b845033c888
Author:    lana
Date:      2013-04-02 12:01 -0700
URL:       http://hg.openjdk.java.net/hsx/hotspot-main/nashorn/rev/9b845033c888

Merge


Changeset: d82bc6ba3981
Author:    lana
Date:      2013-04-05 14:52 -0700
URL:       http://hg.openjdk.java.net/hsx/hotspot-main/nashorn/rev/d82bc6ba3981

Merge


Changeset: af6fc67aa73d
Author:    jlaskey
Date:      2013-04-02 11:37 -0300
URL:       http://hg.openjdk.java.net/hsx/hotspot-main/nashorn/rev/af6fc67aa73d

8011233: Create a Nashorn shell for JavaFX
Reviewed-by: lagergren, sundar
Contributed-by: james.laskey at oracle.com

! make/build.xml
! make/project.properties
+ tools/fxshell/jdk/nashorn/tools/FXShell.java

Changeset: be5d2e472e22
Author:    jlaskey
Date:      2013-04-02 11:38 -0300
URL:       http://hg.openjdk.java.net/hsx/hotspot-main/nashorn/rev/be5d2e472e22

Merge


Changeset: 159dbe2e02eb
Author:    sundar
Date:      2013-04-02 20:42 +0530
URL:       http://hg.openjdk.java.net/hsx/hotspot-main/nashorn/rev/159dbe2e02eb

8011237: Object.isExtensible(Object.getOwnPropertyDescriptor(function(){"use strict"},"caller").get) should be false
Reviewed-by: lagergren, jlaskey

! src/jdk/nashorn/internal/objects/ScriptFunctionImpl.java
+ test/script/basic/JDK-8011237.js

Changeset: e9af5451d2d1
Author:    sundar
Date:      2013-04-02 23:01 +0530
URL:       http://hg.openjdk.java.net/hsx/hotspot-main/nashorn/rev/e9af5451d2d1

8011274: Object.getOwnPropertyDescriptor(function(){"use strict"},"caller").get.hasOwnProperty("prototype") should be false
Reviewed-by: lagergren, jlaskey

! src/jdk/nashorn/internal/objects/ScriptFunctionImpl.java
+ test/script/basic/JDK-8011274.js

Changeset: e63b20d4f08a
Author:    sundar
Date:      2013-04-03 11:41 +0530
URL:       http://hg.openjdk.java.net/hsx/hotspot-main/nashorn/rev/e63b20d4f08a

8011357: Array.prototype.slice and Array.prototype.splice should not call user defined valueOf of start, end arguments more than once
Reviewed-by: lagergren, hannesw

! src/jdk/nashorn/internal/objects/NativeArray.java
+ test/script/basic/JDK-8011357.js

Changeset: 51da1afbab26
Author:    attila
Date:      2013-04-03 11:13 +0200
URL:       http://hg.openjdk.java.net/hsx/hotspot-main/nashorn/rev/51da1afbab26

8011362: Overloaded method resolution foiled by nulls
Reviewed-by: hannesw, sundar

! src/jdk/internal/dynalink/beans/ClassString.java
! src/jdk/internal/dynalink/beans/OverloadedMethod.java
+ test/script/basic/JDK-8011362.js
+ test/script/basic/JDK-8011362.js.EXPECTED
+ test/src/jdk/nashorn/test/models/Jdk8011362TestSubject.java

Changeset: b4191da366be
Author:    sundar
Date:      2013-04-03 15:27 +0530
URL:       http://hg.openjdk.java.net/hsx/hotspot-main/nashorn/rev/b4191da366be

8011365: Array.prototype.join and Array.prototype.toString do not throw TypeError on null, undefined
Reviewed-by: attila, hannesw, lagergren

! src/jdk/nashorn/internal/objects/NativeArray.java
! test/script/basic/JDK-8011362.js.EXPECTED
+ test/script/basic/JDK-8011365.js

Changeset: 4f7d7576e8c4
Author:    hannesw
Date:      2013-04-03 12:43 +0200
URL:       http://hg.openjdk.java.net/hsx/hotspot-main/nashorn/rev/4f7d7576e8c4

8007774: Enable code cache again
Reviewed-by: lagergren, attila, sundar

! src/jdk/nashorn/internal/runtime/resources/Options.properties

Changeset: 82fed56d8dce
Author:    sundar
Date:      2013-04-03 20:17 +0530
URL:       http://hg.openjdk.java.net/hsx/hotspot-main/nashorn/rev/82fed56d8dce

8011382: Data prototype methods and constructor do not call user defined toISOString, valueOf methods per spec.
Reviewed-by: lagergren, jlaskey

! src/jdk/nashorn/internal/objects/NativeDate.java
+ test/script/basic/JDK-8011382.js

Changeset: a5a8ddc2e028
Author:    sundar
Date:      2013-04-04 10:24 +0530
URL:       http://hg.openjdk.java.net/hsx/hotspot-main/nashorn/rev/a5a8ddc2e028

8011394: RegExp.prototype.test() does not call valueOf on lastIndex property as per the spec.
Reviewed-by: lagergren, jlaskey, hannesw

! src/jdk/nashorn/internal/objects/NativeRegExp.java
+ test/script/basic/JDK-8011394.js

Changeset: 0548c134b9ac
Author:    sundar
Date:      2013-04-04 13:54 +0530
URL:       http://hg.openjdk.java.net/hsx/hotspot-main/nashorn/rev/0548c134b9ac

8011421: When using Object.defineProperty on arrays, PropertyDescriptor's property accessors are invoked multiple times
Reviewed-by: lagergren, hannesw

! src/jdk/nashorn/internal/objects/NativeArray.java
+ test/script/basic/JDK-8011421.js

Changeset: f638f2f094f7
Author:    jlaskey
Date:      2013-04-04 09:05 -0300
URL:       http://hg.openjdk.java.net/hsx/hotspot-main/nashorn/rev/f638f2f094f7

8011540: PropertyMap histories should not begin with empty map
Reviewed-by: lagergren, sundar
Contributed-by: james.laskey at oracle.com

! src/jdk/nashorn/internal/runtime/PropertyMap.java

Changeset: 069923cc9de5
Author:    jlaskey
Date:      2013-04-04 09:06 -0300
URL:       http://hg.openjdk.java.net/hsx/hotspot-main/nashorn/rev/069923cc9de5

Merge


Changeset: 18df6640e63f
Author:    sundar
Date:      2013-04-04 18:30 +0530
URL:       http://hg.openjdk.java.net/hsx/hotspot-main/nashorn/rev/18df6640e63f

8011543: "".split(undefined,{valueOf:function(){throw 2}}) does not throw exception
Reviewed-by: lagergren, jlaskey

! src/jdk/nashorn/internal/objects/NativeString.java
+ test/script/basic/JDK-8011543.js

Changeset: 5eb1427b6a6d
Author:    attila
Date:      2013-04-04 15:53 +0200
URL:       http://hg.openjdk.java.net/hsx/hotspot-main/nashorn/rev/5eb1427b6a6d

8011544: Allow subclassing Java classes from script without creating instances
Reviewed-by: jlaskey, sundar

! src/jdk/nashorn/internal/objects/NativeJava.java
+ src/jdk/nashorn/internal/runtime/linker/AdaptationException.java
+ src/jdk/nashorn/internal/runtime/linker/AdaptationResult.java
+ src/jdk/nashorn/internal/runtime/linker/ClassAndLoader.java
+ src/jdk/nashorn/internal/runtime/linker/JavaAdapterBytecodeGenerator.java
+ src/jdk/nashorn/internal/runtime/linker/JavaAdapterClassLoader.java
! src/jdk/nashorn/internal/runtime/linker/JavaAdapterFactory.java
+ src/jdk/nashorn/internal/runtime/linker/JavaAdapterGeneratorBase.java
+ src/jdk/nashorn/internal/runtime/linker/JavaAdapterServices.java
! src/jdk/nashorn/internal/runtime/linker/NashornLinker.java
! src/jdk/nashorn/internal/runtime/linker/NashornStaticClassLinker.java
! src/jdk/nashorn/internal/runtime/resources/Messages.properties
+ test/script/basic/javaclassoverrides.js
+ test/script/basic/javaclassoverrides.js.EXPECTED

Changeset: 73e1270b240c
Author:    attila
Date:      2013-04-04 15:55 +0200
URL:       http://hg.openjdk.java.net/hsx/hotspot-main/nashorn/rev/73e1270b240c

Merge


Changeset: 349360cc1df5
Author:    sundar
Date:      2013-04-04 20:46 +0530
URL:       http://hg.openjdk.java.net/hsx/hotspot-main/nashorn/rev/349360cc1df5

8011552: Arrays with missing elements are not properly sorted
Reviewed-by: jlaskey, lagergren

! src/jdk/nashorn/internal/objects/NativeArray.java
+ test/script/basic/JDK-8011552.js

Changeset: 050fd5696bcb
Author:    attila
Date:      2013-04-04 18:32 +0200
URL:       http://hg.openjdk.java.net/hsx/hotspot-main/nashorn/rev/050fd5696bcb

8011555: Invalid class name in with block with JavaImporter causes MH type mismatch
Reviewed-by: jlaskey, lagergren

! src/jdk/nashorn/internal/runtime/WithObject.java
+ test/script/basic/JDK-8011555.js
+ test/script/basic/JDK-8011555.js.EXPECTED

Changeset: 1c29dc809de2
Author:    hannesw
Date:      2013-04-05 19:50 +0200
URL:       http://hg.openjdk.java.net/hsx/hotspot-main/nashorn/rev/1c29dc809de2

8009230: Nashorn rejects extended RegExp syntax accepted by all major JS engines
Reviewed-by: jlaskey, lagergren

! src/jdk/nashorn/internal/runtime/regexp/RegExpScanner.java
+ test/script/basic/JDK-8009230.js
+ test/script/basic/JDK-8009230.js.EXPECTED

Changeset: 437861485ffa
Author:    jlaskey
Date:      2013-04-09 08:36 -0300
URL:       http://hg.openjdk.java.net/hsx/hotspot-main/nashorn/rev/437861485ffa

Merge


Changeset: 35881a9d0fc2
Author:    lana
Date:      2013-04-16 08:16 -0700
URL:       http://hg.openjdk.java.net/hsx/hotspot-main/nashorn/rev/35881a9d0fc2

Merge

- test/script/basic/JDK-8017010.js
- test/script/basic/JDK-8017010.js.EXPECTED

Changeset: e7e82c1e9aed
Author:    katleman
Date:      2013-04-12 15:22 -0700
URL:       http://hg.openjdk.java.net/hsx/hotspot-main/nashorn/rev/e7e82c1e9aed

8012048: JDK8 b85 source with GPL header errors
Reviewed-by: iris, mduigou, jjg

! docs/JavaScriptingProgrammersGuide.html
! src/jdk/nashorn/api/scripting/Formatter.java

Changeset: 399a4b8e4607
Author:    katleman
Date:      2013-04-15 14:21 -0700
URL:       http://hg.openjdk.java.net/hsx/hotspot-main/nashorn/rev/399a4b8e4607

Merge


Changeset: 002ad9d6735f
Author:    katleman
Date:      2013-04-16 15:00 -0700
URL:       http://hg.openjdk.java.net/hsx/hotspot-main/nashorn/rev/002ad9d6735f

Merge


Changeset: 899cbeee7253
Author:    katleman
Date:      2013-04-18 10:30 -0700
URL:       http://hg.openjdk.java.net/hsx/hotspot-main/nashorn/rev/899cbeee7253

Added tag jdk8-b86 for changeset 002ad9d6735f

! .hgtags


From john.coomes at oracle.com  Thu Apr 18 20:48:36 2013
From: john.coomes at oracle.com (john.coomes at oracle.com)
Date: Fri, 19 Apr 2013 03:48:36 +0000
Subject: hg: hsx/hotspot-main/langtools: 22 new changesets
Message-ID: <20130419034945.C2AD248447@hg.openjdk.java.net>

Changeset: 330b35b27e68
Author:    darcy
Date:      2013-03-26 17:17 -0700
URL:       http://hg.openjdk.java.net/hsx/hotspot-main/langtools/rev/330b35b27e68

7041251: Use j.u.Objects utility methods in langtools
Reviewed-by: jjg

! src/share/classes/com/sun/tools/javac/util/Pair.java
! src/share/classes/javax/annotation/processing/AbstractProcessor.java

Changeset: 33b6a52f0037
Author:    darcy
Date:      2013-03-26 18:15 -0700
URL:       http://hg.openjdk.java.net/hsx/hotspot-main/langtools/rev/33b6a52f0037

7059170: Assume availablility of URLClassLoader.close
Reviewed-by: jjg

! src/share/classes/com/sun/tools/javac/util/BaseFileManager.java
- src/share/classes/com/sun/tools/javac/util/CloseableURLClassLoader.java

Changeset: 7bebe17ff323
Author:    mcimadamore
Date:      2013-03-28 11:38 +0000
URL:       http://hg.openjdk.java.net/hsx/hotspot-main/langtools/rev/7bebe17ff323

8010469: Bad assertion in LambdaToMethod
Summary: Add assertion in LambdaToMethod.serializedLambdaName
Reviewed-by: jjg

! src/share/classes/com/sun/tools/javac/comp/LambdaToMethod.java

Changeset: a200d8ccfe47
Author:    mcimadamore
Date:      2013-03-28 11:39 +0000
URL:       http://hg.openjdk.java.net/hsx/hotspot-main/langtools/rev/a200d8ccfe47

8010490: FindBugs: double assignments in LambdaToMethod.visitIdent
Summary: Remove dead code from LambdaToMethod
Reviewed-by: jjg

! src/share/classes/com/sun/tools/javac/comp/LambdaToMethod.java

Changeset: 991f11e13598
Author:    jjg
Date:      2013-03-28 10:49 -0700
URL:       http://hg.openjdk.java.net/hsx/hotspot-main/langtools/rev/991f11e13598

8006346: doclint should make allowance for headers generated by standard doclet
Reviewed-by: mcimadamore

! src/share/classes/com/sun/tools/doclint/Checker.java
! src/share/classes/com/sun/tools/doclint/DocLint.java
! src/share/classes/com/sun/tools/doclint/Env.java
! src/share/classes/com/sun/tools/javac/main/Main.java
! src/share/classes/com/sun/tools/javadoc/DocEnv.java
+ test/tools/javac/doclint/ImplicitHeadersTest.java
+ test/tools/javadoc/doclint/ImplicitHeadersTest.java

Changeset: d3648557391b
Author:    jjg
Date:      2013-03-28 10:58 -0700
URL:       http://hg.openjdk.java.net/hsx/hotspot-main/langtools/rev/d3648557391b

8010511: Tests are creating files in /tmp
Reviewed-by: darcy

! test/tools/javac/T6558476.java
! test/tools/javac/T6900149.java
! test/tools/javac/diags/CheckExamples.java
! test/tools/javac/diags/RunExamples.java

Changeset: 29c6984a1673
Author:    vromero
Date:      2013-04-02 10:51 +0100
URL:       http://hg.openjdk.java.net/hsx/hotspot-main/langtools/rev/29c6984a1673

4965689: class literal code wastes a byte
Reviewed-by: jjg

! src/share/classes/com/sun/tools/javac/jvm/Code.java
! src/share/classes/com/sun/tools/javac/jvm/Gen.java
! src/share/classes/com/sun/tools/javac/jvm/Items.java
+ test/tools/javac/T4965689/ClassLiteralWastesByteTest.java

Changeset: 46d2f144ebbd
Author:    lana
Date:      2013-04-02 12:00 -0700
URL:       http://hg.openjdk.java.net/hsx/hotspot-main/langtools/rev/46d2f144ebbd

Merge


Changeset: 0d47e6131490
Author:    darcy
Date:      2013-04-03 12:27 -0700
URL:       http://hg.openjdk.java.net/hsx/hotspot-main/langtools/rev/0d47e6131490

8011052: Add DEFAULT to javax.lang.model.Modifier
Reviewed-by: abuckley, jjg

! src/share/classes/com/sun/tools/javac/code/Flags.java
! src/share/classes/javax/lang/model/element/Modifier.java
! test/tools/javac/processing/model/element/TestExecutableElement.java

Changeset: e06dc8345d9c
Author:    lana
Date:      2013-04-05 14:51 -0700
URL:       http://hg.openjdk.java.net/hsx/hotspot-main/langtools/rev/e06dc8345d9c

Merge


Changeset: b71a61d39cf7
Author:    mcimadamore
Date:      2013-04-08 15:51 +0100
URL:       http://hg.openjdk.java.net/hsx/hotspot-main/langtools/rev/b71a61d39cf7

8010922: Cleanup: add support for ad-hoc method check logic
Summary: Support pluggable method checkers
Reviewed-by: jjg

! src/share/classes/com/sun/tools/javac/comp/Attr.java
! src/share/classes/com/sun/tools/javac/comp/DeferredAttr.java
! src/share/classes/com/sun/tools/javac/comp/Infer.java
! src/share/classes/com/sun/tools/javac/comp/Resolve.java

Changeset: b54122b9372d
Author:    mcimadamore
Date:      2013-04-08 15:52 +0100
URL:       http://hg.openjdk.java.net/hsx/hotspot-main/langtools/rev/b54122b9372d

8010823: DefaultMethodTest.testReflectCall fails with new lambda VM
Summary: Fix lambda test
Reviewed-by: jjg

! test/tools/javac/lambdaShapes/org/openjdk/tests/vm/DefaultMethodsTest.java

Changeset: e9d986381414
Author:    mcimadamore
Date:      2013-04-08 15:53 +0100
URL:       http://hg.openjdk.java.net/hsx/hotspot-main/langtools/rev/e9d986381414

8010404: Lambda debugging: redundant LineNumberTable entry for lambda capture
Summary: Ignore indy entries in LineNumberTable
Reviewed-by: jjg

! src/share/classes/com/sun/tools/javac/jvm/Code.java
! src/share/classes/com/sun/tools/javac/jvm/Gen.java
! test/tools/javac/lambda/TestInvokeDynamic.java

Changeset: 94a202228ec2
Author:    mcimadamore
Date:      2013-04-08 15:57 +0100
URL:       http://hg.openjdk.java.net/hsx/hotspot-main/langtools/rev/94a202228ec2

8009131: Overload: javac should discard methods that lead to errors in lambdas with implicit parameter types
Summary: Lambdas that have errors in their bodies should make enclosing overload resolution fail
Reviewed-by: jjg

! src/share/classes/com/sun/tools/javac/comp/Attr.java
! src/share/classes/com/sun/tools/javac/resources/compiler.properties
+ test/tools/javac/diags/examples/BadArgTypesInLambda.java
! test/tools/javac/lambda/BadRecovery.out
! test/tools/javac/lambda/TargetType01.java
- test/tools/javac/lambda/TargetType01.out
! test/tools/javac/lambda/TargetType43.out
+ test/tools/javac/lambda/TargetType66.java
+ test/tools/javac/lambda/TargetType66.out

Changeset: c635a966ce84
Author:    mcimadamore
Date:      2013-04-08 15:59 +0100
URL:       http://hg.openjdk.java.net/hsx/hotspot-main/langtools/rev/c635a966ce84

8010822: Intersection type cast for functional expressions does not follow spec EDR
Summary: Remove support for marker interfaces; redefine intersection type casts to be order-independent
Reviewed-by: jjg

! src/share/classes/com/sun/tools/javac/code/Type.java
! src/share/classes/com/sun/tools/javac/code/Types.java
! src/share/classes/com/sun/tools/javac/comp/Attr.java
! src/share/classes/com/sun/tools/javac/resources/compiler.properties
! src/share/classes/com/sun/tools/javac/util/RichDiagnosticFormatter.java
+ test/tools/javac/diags/examples/NotAnInterfaceComponent.java
- test/tools/javac/diags/examples/SecondaryBoundMustBeMarkerIntf.java
! test/tools/javac/lambda/Intersection01.java
- test/tools/javac/lambda/Intersection01.out
! test/tools/javac/lambda/intersection/IntersectionTargetTypeTest.java

Changeset: b402b93cbe38
Author:    jjg
Date:      2013-04-08 11:54 -0700
URL:       http://hg.openjdk.java.net/hsx/hotspot-main/langtools/rev/b402b93cbe38

8011676: Instances of Tokens.Comment should not be defined in inner classes
Reviewed-by: mcimadamore

! src/share/classes/com/sun/tools/javac/parser/JavaTokenizer.java
! src/share/classes/com/sun/tools/javac/parser/JavadocTokenizer.java

Changeset: 3f3cc8d3f13c
Author:    jjg
Date:      2013-04-08 11:57 -0700
URL:       http://hg.openjdk.java.net/hsx/hotspot-main/langtools/rev/3f3cc8d3f13c

8011677: EndPosTables should avoid hidden references to Parser
Reviewed-by: mcimadamore

! src/share/classes/com/sun/tools/javac/parser/JavacParser.java

Changeset: 1f19b84efa6d
Author:    lana
Date:      2013-04-16 08:16 -0700
URL:       http://hg.openjdk.java.net/hsx/hotspot-main/langtools/rev/1f19b84efa6d

Merge

- src/share/classes/com/sun/tools/javac/util/CloseableURLClassLoader.java
- test/tools/javac/diags/examples/SecondaryBoundMustBeMarkerIntf.java
- test/tools/javac/lambda/Intersection01.out
- test/tools/javac/lambda/TargetType01.out

Changeset: 2b585be0da7a
Author:    katleman
Date:      2013-04-12 15:22 -0700
URL:       http://hg.openjdk.java.net/hsx/hotspot-main/langtools/rev/2b585be0da7a

8012048: JDK8 b85 source with GPL header errors
Reviewed-by: iris, mduigou, jjg

! test/com/sun/javadoc/testAnnotationOptional/TestAnnotationOptional.java
! test/com/sun/javadoc/testAnnotationOptional/pkg/AnnotationOptional.java
! test/com/sun/javadoc/typeAnnotations/smoke/TestSmoke.java
! test/com/sun/javadoc/typeAnnotations/smoke/pkg/TargetTypes.java

Changeset: 717bcda533f2
Author:    katleman
Date:      2013-04-15 14:21 -0700
URL:       http://hg.openjdk.java.net/hsx/hotspot-main/langtools/rev/717bcda533f2

Merge


Changeset: 6ab578e141df
Author:    katleman
Date:      2013-04-16 15:00 -0700
URL:       http://hg.openjdk.java.net/hsx/hotspot-main/langtools/rev/6ab578e141df

Merge


Changeset: 4f4509c2fe35
Author:    katleman
Date:      2013-04-18 10:30 -0700
URL:       http://hg.openjdk.java.net/hsx/hotspot-main/langtools/rev/4f4509c2fe35

Added tag jdk8-b86 for changeset 6ab578e141df

! .hgtags


From david.holmes at oracle.com  Thu Apr 18 21:17:57 2013
From: david.holmes at oracle.com (David Holmes)
Date: Fri, 19 Apr 2013 14:17:57 +1000
Subject: CFV: New hsx Committer: Tao Mao
In-Reply-To: <20848.19457.854901.807286@oracle.com>
References: <20848.19457.854901.807286@oracle.com>
Message-ID: <5170C575.2030101@oracle.com>

Vote: VETO

Without impugning Tao's abilities or the scope of his future 
contributions, a few of the contributions listed are quite simple. The 
OpenJDK guidelines [1] state:

"As a rough guide, for any given Project, a Contributor should make at 
least eight significant contributions before being nominated."

I do not feel that all the 8 contributions referenced meet the criteria 
of being "significant", and that therefore this request for Committer 
status is a little premature.

Sorry.

David
-----

[1] http://openjdk.java.net/projects/
-----

On 19/04/2013 5:39 AM, John Coomes wrote:
> I hereby nominate Tao Mao to hsx Committer.
>
> Tao joined the HotSpot garbage collection team at Oracle last year;
> over the last eight months he has contributed eight changesets which
> have improved or fixed bugs in several different GC components
> including ergonomics, G1 and serial gc [1].
>
> Votes are due by Thu, May 2, 2013 8:00pm UTC [2].
>
> Only current hsx Committers [3] are eligible to vote on this
> nomination.  Votes must be cast in the open by replying to to this
> mailing list.
>
> For Lazy Consensus voting instructions, see [4].
>
> John Coomes, hsx Project Lead
>
> [1] http://hg.openjdk.java.net/hsx/hotspot-gc/hotspot/log?rev=tao.mao
> [2] http://www.timeanddate.com/worldclock/fixedtime.html?msg=CFV%3A+New+hsx+Committer%3A+Tao+Mao&iso=20130502T20
> [3] http://openjdk.java.net/census/#hsx
> [4] http://openjdk.java.net/projects/#committer-vote
>

From rickard.backman at oracle.com  Thu Apr 18 22:02:04 2013
From: rickard.backman at oracle.com (=?iso-8859-1?Q?Rickard_B=E4ckman?=)
Date: Fri, 19 Apr 2013 07:02:04 +0200
Subject: Review request: 6729929 I18N - Taking Heap Dump failed if project
	path contains multibyte characters
In-Reply-To: <5170A9B0.5020805@oracle.com>
References: <515C55F4.6020002@oracle.com> <516FFEB9.90509@oracle.com>
	<5170A9B0.5020805@oracle.com>
Message-ID: <0206F969-AA52-46B9-A5DD-DA05952C3B69@oracle.com>

Peter,

it looks good to me.

/R

On Apr 19, 2013, at 4:19 AM, David Holmes wrote:

> Hi Peter,
> 
> On 19/04/2013 12:10 AM, Peter Allwin wrote:
>> Hi all, I'm still looking for reviews for this change...
> 
> Sounds like a perfectly reasonable change.
> 
> Reviewed.
> 
> Thanks,
> David
> 
>> Thanks!
>> 
>> /peter
>> 
>> On 4/3/2013 6:16 PM, Peter Allwin wrote:
>>> Webrev: http://cr.openjdk.java.net/~mgronlun/6729929/webrev01/
>>> 
>>> Bug: http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=6729929
>>> 
>>> Summary: When dumpHeap in the HotSpotDiagnostic JMX MBean is called,
>>> the filename parameter must be converted from jstring to char* to be
>>> used in open(). This was done using UTF-8 encoding which is incorrect
>>> as open() expects a platform dependent encoding according to the
>>> system locale. Fix is to use
>>> java_lang_String::as_platform_dependent_str to do the conversion.
>>> 
>>> Thanks to Markus for advising and hosting the webrev!
>>> 
>>> Regards,
>>> 
>>> /peter
>> 


From alejandro.murillo at oracle.com  Thu Apr 18 22:22:17 2013
From: alejandro.murillo at oracle.com (alejandro.murillo at oracle.com)
Date: Fri, 19 Apr 2013 05:22:17 +0000
Subject: hg: hsx/hsx24/hotspot: 8012558: new hotspot build - hs24-b42
Message-ID: <20130419052221.83B4A48468@hg.openjdk.java.net>

Changeset: edd1619a3ae4
Author:    amurillo
Date:      2013-04-18 13:50 -0700
URL:       http://hg.openjdk.java.net/hsx/hsx24/hotspot/rev/edd1619a3ae4

8012558: new hotspot build - hs24-b42
Reviewed-by: jcoomes

! make/hotspot_version


From igor.ignatyev at oracle.com  Thu Apr 18 22:56:08 2013
From: igor.ignatyev at oracle.com (Igor Ignatyev)
Date: Fri, 19 Apr 2013 09:56:08 +0400
Subject: RFR(S) : 8012337 : Change Whitebox implementation to make absence
	of method in Whitebox.class not fatal
In-Reply-To: <51707599.8050907@oracle.com>
References: <516E7569.1060201@oracle.com> <516E85EC.6040203@oracle.com>
	<516EAA0F.2020807@oracle.com> <51705F1E.6050602@oracle.com>
	<51707599.8050907@oracle.com>
Message-ID: <5170DC78.5090001@oracle.com>

I don't want to have directory hierarchy (sun/hotspot) with fake 
WhiteBox, because it can be confusing.

Best regards,
Igor Ignatyev

On 04/19/2013 02:37 AM, Vladimir Kozlov wrote:
> Why not use WB technique (ClassFileInstaller) which compiles and copies
> class file into directory you want so you can avoid using shell?
>
> Vladimir
>
> On 4/18/13 2:01 PM, Igor Ignatyev wrote:
>> could someone with "reviewer" status look at that?
>>
>> Best regards,
>> Igor Ignatyev
>>
>> On 04/17/2013 05:56 PM, Igor Ignatyev wrote:
>>> Mikael,
>>> Thank you for review.
>>>
>>> I have updated webrev:
>>> - added checking for exception class
>>> - added print warning on unexpected error
>>>
>>> http://cr.openjdk.java.net/~iignatyev/8012337/webrev.01/
>>>
>>> Best regards,
>>> Igor Ignatyev
>>>
>>> On 04/17/2013 03:22 PM, Mikael Gerdin wrote:
>>>> Igor,
>>>>
>>>> On 2013-04-17 12:11, Igor Ignatyev wrote:
>>>>> Hi all,
>>>>>
>>>>> Please review patch.
>>>>>
>>>>> Problem:
>>>>> If there is some method that presences in native part of whitebox, but
>>>>> absences in java side, we get 'j.l.NoSuchMethodError' exception
>>>>
>>>> The intended use of is of course that whitebox.cpp and WhiteBox.java
>>>> are
>>>> in sync since they are in the same hg repository.
>>>>
>>>> I understand that some feel that they need to copy WhiteBox to some
>>>> other test suite and I find this change acceptable but unfortunate.
>>>>
>>>>>
>>>>> Fix:
>>>>> Batch registration of WB functions was replaced with one by one
>>>>> registration
>>>>>
>>>>> Testing:
>>>>> JPRT of sanity tests and tests that use WhiteBox: runtime/interned,
>>>>> compiler/whitebox
>>>>>
>>>>> webrev: http://cr.openjdk.java.net/~iignatyev/8012337/webrev.00/
>>>>
>>>> It's too bad that you need a shell script here but I don't see any way
>>>> around it.
>>>>
>>>> I'm ok with you pushing this.
>>>>
>>>> /Mikael
>>>>
>>>>> jbs: https://jbs.oracle.com/bugs/browse/JDK-8012337

From bengt.rutisson at oracle.com  Thu Apr 18 23:08:38 2013
From: bengt.rutisson at oracle.com (Bengt Rutisson)
Date: Fri, 19 Apr 2013 08:08:38 +0200
Subject: CFV: New hsx Committer: Tao Mao
In-Reply-To: <20848.19457.854901.807286@oracle.com>
References: <20848.19457.854901.807286@oracle.com>
Message-ID: <5170DF66.5020107@oracle.com>


Vote: yes

Bengt

On 4/18/13 9:39 PM, John Coomes wrote:
> I hereby nominate Tao Mao to hsx Committer.
>
> Tao joined the HotSpot garbage collection team at Oracle last year;
> over the last eight months he has contributed eight changesets which
> have improved or fixed bugs in several different GC components
> including ergonomics, G1 and serial gc [1].
>
> Votes are due by Thu, May 2, 2013 8:00pm UTC [2].
>
> Only current hsx Committers [3] are eligible to vote on this
> nomination.  Votes must be cast in the open by replying to to this
> mailing list.
>
> For Lazy Consensus voting instructions, see [4].
>
> John Coomes, hsx Project Lead
>
> [1] http://hg.openjdk.java.net/hsx/hotspot-gc/hotspot/log?rev=tao.mao
> [2] http://www.timeanddate.com/worldclock/fixedtime.html?msg=CFV%3A+New+hsx+Committer%3A+Tao+Mao&iso=20130502T20
> [3] http://openjdk.java.net/census/#hsx
> [4] http://openjdk.java.net/projects/#committer-vote


From alejandro.murillo at oracle.com  Fri Apr 19 00:02:03 2013
From: alejandro.murillo at oracle.com (Alejandro E Murillo)
Date: Fri, 19 Apr 2013 01:02:03 -0600
Subject: CFV: New hsx Committer: Tao Mao
In-Reply-To: <20848.19457.854901.807286@oracle.com>
References: <20848.19457.854901.807286@oracle.com>
Message-ID: <5170EBEB.2080106@oracle.com>

vote: yes


-- 
Alejandro


From jiangli.zhou at oracle.com  Fri Apr 19 00:08:00 2013
From: jiangli.zhou at oracle.com (jiangli.zhou at oracle.com)
Date: Fri, 19 Apr 2013 07:08:00 +0000
Subject: hg: hsx/hotspot-main/hotspot: 4 new changesets
Message-ID: <20130419070811.114484846C@hg.openjdk.java.net>

Changeset: aeaca88565e6
Author:    jiangli
Date:      2013-04-09 17:17 -0400
URL:       http://hg.openjdk.java.net/hsx/hotspot-main/hotspot/rev/aeaca88565e6

8010862: The Method counter fields used for profiling can be allocated lazily.
Summary: Allocate the method's profiling related metadata until they are needed.
Reviewed-by: coleenp, roland

! agent/src/share/classes/sun/jvm/hotspot/oops/Method.java
+ agent/src/share/classes/sun/jvm/hotspot/oops/MethodCounters.java
! src/cpu/sparc/vm/cppInterpreter_sparc.cpp
! src/cpu/sparc/vm/interp_masm_sparc.cpp
! src/cpu/sparc/vm/interp_masm_sparc.hpp
! src/cpu/sparc/vm/templateInterpreter_sparc.cpp
! src/cpu/sparc/vm/templateTable_sparc.cpp
! src/cpu/x86/vm/cppInterpreter_x86.cpp
! src/cpu/x86/vm/interp_masm_x86_32.cpp
! src/cpu/x86/vm/interp_masm_x86_32.hpp
! src/cpu/x86/vm/interp_masm_x86_64.cpp
! src/cpu/x86/vm/interp_masm_x86_64.hpp
! src/cpu/x86/vm/templateInterpreter_x86_32.cpp
! src/cpu/x86/vm/templateInterpreter_x86_64.cpp
! src/cpu/x86/vm/templateTable_x86_32.cpp
! src/cpu/x86/vm/templateTable_x86_64.cpp
! src/share/vm/c1/c1_LIRGenerator.cpp
! src/share/vm/ci/ciMethod.cpp
! src/share/vm/ci/ciMethod.hpp
! src/share/vm/ci/ciReplay.cpp
! src/share/vm/interpreter/interpreterRuntime.cpp
! src/share/vm/interpreter/interpreterRuntime.hpp
! src/share/vm/interpreter/invocationCounter.cpp
! src/share/vm/oops/method.cpp
! src/share/vm/oops/method.hpp
+ src/share/vm/oops/methodCounters.cpp
+ src/share/vm/oops/methodCounters.hpp
! src/share/vm/oops/methodData.cpp
! src/share/vm/opto/parseHelper.cpp
! src/share/vm/runtime/advancedThresholdPolicy.cpp
! src/share/vm/runtime/compilationPolicy.cpp
! src/share/vm/runtime/fprofiler.cpp
! src/share/vm/runtime/simpleThresholdPolicy.cpp
! src/share/vm/runtime/vmStructs.cpp

Changeset: 42a42da29fd7
Author:    jiangli
Date:      2013-04-11 23:06 -0400
URL:       http://hg.openjdk.java.net/hsx/hotspot-main/hotspot/rev/42a42da29fd7

8012052: java/lang/invoke/6987555/Test6987555.java crashes with assert(mcs != NULL) failed: MethodCounters cannot be NULL.
Summary: Skip counter decay if the MethodCounters is NULL in NonTieredCompPolicy::delay_compilation().
Reviewed-by: kvn, dholmes

! src/share/vm/runtime/compilationPolicy.cpp

Changeset: 8df6ddda8090
Author:    jiangli
Date:      2013-04-15 21:25 -0400
URL:       http://hg.openjdk.java.net/hsx/hotspot-main/hotspot/rev/8df6ddda8090

Merge

! src/share/vm/c1/c1_LIRGenerator.cpp
! src/share/vm/interpreter/interpreterRuntime.cpp
! src/share/vm/oops/method.hpp
! src/share/vm/oops/methodData.cpp
! src/share/vm/prims/whitebox.cpp
! src/share/vm/runtime/compilationPolicy.cpp
! src/share/vm/runtime/vmStructs.cpp

Changeset: 9500809ceead
Author:    jiangli
Date:      2013-04-18 17:00 -0400
URL:       http://hg.openjdk.java.net/hsx/hotspot-main/hotspot/rev/9500809ceead

Merge

! src/cpu/sparc/vm/templateTable_sparc.cpp
! src/cpu/x86/vm/templateTable_x86_64.cpp


From erik.joelsson at oracle.com  Fri Apr 19 03:10:51 2013
From: erik.joelsson at oracle.com (Erik Joelsson)
Date: Fri, 19 Apr 2013 12:10:51 +0200
Subject: Some ccache benchmarking
Message-ID: <5171182B.5010901@oracle.com>

Hello,

In the new build, on Linux, configure tries to pick up and use ccache if 
available on the machine. It is even being picky about the version 
(3.1.4 minimum) to make sure that precompiled headers are supported, 
since those are used in the hotspot build. I have looked into this 
precompiled header support in ccache some and have some insights to 
share. The trigger for this was observing that building hotspot with an 
empty ccache took a very long time compared to not using ccache at all.

Looking at the ccache manual, for precompiled headers to actually be 
used, the gcc flag -fpch-preprocess needs to be added to the command 
line. What it does is enabling precompiled headers when running gcc in 
preprocess only mode, which ccache needs to do in order to create the 
hash for the cache. I have experimented with adding this flag to see 
what performance differences it would yield. As a second option, I've 
also tried disabling precompiled headers completely. Here is a summary 
of the results from running on my machine (Ubuntu 10.10 x86_64 8 cores):

Summary                    no ccache   empty cache   full cache
without -fpch-preprocess   2:42        5:28          1:07
with -fpch-preprocess      2:43        3:27          1:32
no precompiled headers     3:32        3:47          0:54

Adding the flag reduces the compilation time with an empty cache 
tremendously. However, it also increases the compilation time with a 
full cache significantly. Disabling precompiled headers completely when 
using ccache also reduces time with the empty cache, though not as much. 
It does however speed up compilation with a full cache even more than 
any of the other options.

My conclusion is that the current situation is bad and needs to be 
improved. Either of the methods tested will be an improvement. Here are 
the options as I see them:

A. Add -fpch-preprocess to CFLAGS permanently in hotspot.

B. Have configure add -fpch-preprocess if ccache is used.

C. Have configure disable precompiled headers if ccache is used. This 
also removes the current version requirement of 3.1.4 on ccache for 
precompiled header support which is enforced in configure, and would 
automatically (re)enable ccache use in jprt.

I would lean towards option C, but would be interested in other opinions.

/Erik

From peter.allwin at oracle.com  Fri Apr 19 07:06:25 2013
From: peter.allwin at oracle.com (Peter Allwin)
Date: Fri, 19 Apr 2013 16:06:25 +0200
Subject: Review request: 6729929 I18N - Taking Heap Dump failed if project
	path contains multibyte characters
In-Reply-To: <0206F969-AA52-46B9-A5DD-DA05952C3B69@oracle.com>
References: <515C55F4.6020002@oracle.com> <516FFEB9.90509@oracle.com>
	<5170A9B0.5020805@oracle.com>
	<0206F969-AA52-46B9-A5DD-DA05952C3B69@oracle.com>
Message-ID: <51714F61.4070604@oracle.com>

Great, thanks a lot guys!

/peter
On 4/19/2013 7:02 AM, Rickard B?ckman wrote:
> Peter,
>
> it looks good to me.
>
> /R
>
> On Apr 19, 2013, at 4:19 AM, David Holmes wrote:
>
>> Hi Peter,
>>
>> On 19/04/2013 12:10 AM, Peter Allwin wrote:
>>> Hi all, I'm still looking for reviews for this change...
>> Sounds like a perfectly reasonable change.
>>
>> Reviewed.
>>
>> Thanks,
>> David
>>
>>> Thanks!
>>>
>>> /peter
>>>
>>> On 4/3/2013 6:16 PM, Peter Allwin wrote:
>>>> Webrev: http://cr.openjdk.java.net/~mgronlun/6729929/webrev01/
>>>> 
>>>> Bug: http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=6729929
>>>>
>>>> Summary: When dumpHeap in the HotSpotDiagnostic JMX MBean is called,
>>>> the filename parameter must be converted from jstring to char* to be
>>>> used in open(). This was done using UTF-8 encoding which is incorrect
>>>> as open() expects a platform dependent encoding according to the
>>>> system locale. Fix is to use
>>>> java_lang_String::as_platform_dependent_str to do the conversion.
>>>>
>>>> Thanks to Markus for advising and hosting the webrev!
>>>>
>>>> Regards,
>>>>
>>>> /peter


From bharadwaj.yadavalli at oracle.com  Fri Apr 19 08:47:04 2013
From: bharadwaj.yadavalli at oracle.com (bharadwaj.yadavalli at oracle.com)
Date: Fri, 19 Apr 2013 15:47:04 +0000
Subject: hg: hsx/hotspot-main/hotspot: 15 new changesets
Message-ID: <20130419154744.8001F4847F@hg.openjdk.java.net>

Changeset: b8b081e53312
Author:    twisti
Date:      2013-04-12 12:22 -0700
URL:       http://hg.openjdk.java.net/hsx/hotspot-main/hotspot/rev/b8b081e53312

8011933: add number of classes, methods and time spent to CompileTheWorld
Reviewed-by: jrose, kvn

! src/share/vm/classfile/classLoader.cpp
! src/share/vm/classfile/classLoader.hpp

Changeset: 393fd4ef89c4
Author:    twisti
Date:      2013-04-12 15:43 -0700
URL:       http://hg.openjdk.java.net/hsx/hotspot-main/hotspot/rev/393fd4ef89c4

8011678: test/Makefile should pick up JT_HOME environment variable
Reviewed-by: kvn

! test/Makefile

Changeset: f36e073d56a4
Author:    drchase
Date:      2013-04-12 15:53 -0700
URL:       http://hg.openjdk.java.net/hsx/hotspot-main/hotspot/rev/f36e073d56a4

7104565: trim jprt build targets
Summary: remove JPRT debug builds, remove -DDEBUG -DFASTDEBUG and use ASSERT instead in sources
Reviewed-by: dholmes, kvn, coleenp

! make/Makefile
! make/bsd/Makefile
! make/bsd/makefiles/buildtree.make
! make/bsd/makefiles/debug.make
! make/bsd/makefiles/defs.make
! make/bsd/makefiles/fastdebug.make
- make/bsd/makefiles/jvmg.make
- make/bsd/makefiles/profiled.make
! make/jprt.properties
! make/linux/Makefile
! make/linux/makefiles/buildtree.make
! make/linux/makefiles/debug.make
! make/linux/makefiles/defs.make
! make/linux/makefiles/fastdebug.make
- make/linux/makefiles/jvmg.make
- make/linux/makefiles/profiled.make
! make/solaris/Makefile
! make/solaris/makefiles/buildtree.make
! make/solaris/makefiles/debug.make
! make/solaris/makefiles/defs.make
! make/solaris/makefiles/fastdebug.make
- make/solaris/makefiles/jvmg.make
- make/solaris/makefiles/profiled.make
! make/windows/build.make
! make/windows/makefiles/defs.make
! make/windows/makefiles/vm.make
! make/windows/projectfiles/compiler2/ADLCompiler.dsp
! make/windows/projectfiles/tiered/ADLCompiler.dsp
! src/cpu/sparc/vm/frame_sparc.cpp
! src/os/bsd/dtrace/generateJvmOffsets.cpp
! src/os/solaris/dtrace/generateJvmOffsets.cpp
! src/os/windows/vm/os_windows.cpp
! src/share/tools/hsdis/Makefile
! src/share/vm/classfile/stackMapFrame.hpp
! src/share/vm/gc_implementation/concurrentMarkSweep/concurrentMarkSweepGeneration.cpp
! src/share/vm/memory/allocation.hpp
! src/share/vm/runtime/vmThread.cpp

Changeset: bc63dd2539a4
Author:    kvn
Date:      2013-04-12 20:37 -0400
URL:       http://hg.openjdk.java.net/hsx/hotspot-main/hotspot/rev/bc63dd2539a4

Merge

! make/bsd/makefiles/debug.make
- make/bsd/makefiles/jvmg.make
- make/bsd/makefiles/profiled.make
! make/linux/makefiles/debug.make
- make/linux/makefiles/jvmg.make
- make/linux/makefiles/profiled.make
! make/solaris/makefiles/debug.make
- make/solaris/makefiles/jvmg.make
- make/solaris/makefiles/profiled.make

Changeset: 886d1fd67dc3
Author:    drchase
Date:      2013-04-12 19:14 -0700
URL:       http://hg.openjdk.java.net/hsx/hotspot-main/hotspot/rev/886d1fd67dc3

6443505: Ideal() function for CmpLTMask
Summary: Repair wrong code generation, added new matching rule
Reviewed-by: kvn, twisti

! src/cpu/sparc/vm/sparc.ad
! src/cpu/x86/vm/x86_32.ad
! src/cpu/x86/vm/x86_64.ad
! src/share/vm/opto/cfgnode.cpp
+ test/compiler/6443505/Test6443505.java

Changeset: bb4a966cc68f
Author:    roland
Date:      2013-04-15 09:42 +0200
URL:       http://hg.openjdk.java.net/hsx/hotspot-main/hotspot/rev/bb4a966cc68f

8011582: assert(nbits == 32 || (-(1 << nbits-1) <= x && x < ( 1 << nbits-1))) failed: value out of range
Summary: c1 runtime's predicate_failed_trap should use jump_to on sparc
Reviewed-by: kvn

! src/cpu/sparc/vm/c1_Runtime1_sparc.cpp

Changeset: 1c6887c9afaa
Author:    twisti
Date:      2013-04-15 16:20 -0700
URL:       http://hg.openjdk.java.net/hsx/hotspot-main/hotspot/rev/1c6887c9afaa

7172922: export_ makefile targets do not work unless all supported variants are built
Reviewed-by: dholmes, kvn

! make/Makefile

Changeset: acadb114c818
Author:    roland
Date:      2013-04-15 17:17 +0200
URL:       http://hg.openjdk.java.net/hsx/hotspot-main/hotspot/rev/acadb114c818

8011648: C1: optimized build is broken after 7153771
Summary: missing #ifdef ASSERT
Reviewed-by: kvn

! src/share/vm/c1/c1_Canonicalizer.cpp
! src/share/vm/c1/c1_Canonicalizer.hpp
! src/share/vm/c1/c1_Instruction.hpp
! src/share/vm/c1/c1_InstructionPrinter.cpp
! src/share/vm/c1/c1_InstructionPrinter.hpp
! src/share/vm/c1/c1_LIR.cpp
! src/share/vm/c1/c1_LIR.hpp
! src/share/vm/c1/c1_LIRGenerator.cpp
! src/share/vm/c1/c1_LIRGenerator.hpp
! src/share/vm/c1/c1_Optimizer.cpp
! src/share/vm/c1/c1_RangeCheckElimination.hpp
! src/share/vm/c1/c1_ValueMap.hpp

Changeset: b105029fdbfd
Author:    roland
Date:      2013-04-15 18:42 -0700
URL:       http://hg.openjdk.java.net/hsx/hotspot-main/hotspot/rev/b105029fdbfd

Merge


Changeset: 8373c19be854
Author:    neliasso
Date:      2013-04-16 10:08 +0200
URL:       http://hg.openjdk.java.net/hsx/hotspot-main/hotspot/rev/8373c19be854

8011621: live_ranges_in_separate_class.patch
Reviewed-by: kvn, roland
Contributed-by: niclas.adlertz at oracle.com

! make/bsd/makefiles/vm.make
! make/linux/makefiles/vm.make
! make/solaris/makefiles/vm.make
! make/windows/create_obj_files.sh
- src/os/bsd/vm/chaitin_bsd.cpp
- src/os/linux/vm/chaitin_linux.cpp
- src/os/solaris/vm/chaitin_solaris.cpp
- src/os/windows/vm/chaitin_windows.cpp
! src/share/vm/opto/chaitin.cpp
! src/share/vm/opto/chaitin.hpp
! src/share/vm/opto/coalesce.cpp
! src/share/vm/opto/coalesce.hpp
! src/share/vm/opto/compile.cpp
! src/share/vm/opto/idealGraphPrinter.cpp
! src/share/vm/opto/ifg.cpp
! src/share/vm/opto/live.cpp
! src/share/vm/opto/live.hpp
! src/share/vm/opto/postaloc.cpp
! src/share/vm/opto/reg_split.cpp
! src/share/vm/opto/regalloc.hpp
! src/share/vm/runtime/vmStructs.cpp

Changeset: c89eab0b6b30
Author:    neliasso
Date:      2013-04-16 10:37 -0400
URL:       http://hg.openjdk.java.net/hsx/hotspot-main/hotspot/rev/c89eab0b6b30

Merge

- src/os/bsd/vm/chaitin_bsd.cpp
- src/os/linux/vm/chaitin_linux.cpp
- src/os/solaris/vm/chaitin_solaris.cpp
- src/os/windows/vm/chaitin_windows.cpp

Changeset: 4b2eebe03f93
Author:    iignatyev
Date:      2013-04-16 10:04 -0700
URL:       http://hg.openjdk.java.net/hsx/hotspot-main/hotspot/rev/4b2eebe03f93

8011971: WB API doesn't accept j.l.reflect.Constructor
Reviewed-by: kvn, vlivanov

! src/share/vm/prims/whitebox.cpp
! test/compiler/whitebox/ClearMethodStateTest.java
! test/compiler/whitebox/CompilerWhiteBoxTest.java
! test/compiler/whitebox/DeoptimizeAllTest.java
! test/compiler/whitebox/DeoptimizeMethodTest.java
! test/compiler/whitebox/EnqueueMethodForCompilationTest.java
! test/compiler/whitebox/IsMethodCompilableTest.java
! test/compiler/whitebox/MakeMethodNotCompilableTest.java
! test/compiler/whitebox/SetDontInlineMethodTest.java
! test/compiler/whitebox/SetForceInlineMethodTest.java
! test/testlibrary/whitebox/sun/hotspot/WhiteBox.java

Changeset: a7fb14888912
Author:    neliasso
Date:      2013-04-11 13:57 +0200
URL:       http://hg.openjdk.java.net/hsx/hotspot-main/hotspot/rev/a7fb14888912

8006952: Slow VM due to excessive code cache freelist iteration
Summary: Remove continous free block requirement
Reviewed-by: kvn

! src/share/vm/code/codeBlob.cpp
! src/share/vm/code/codeCache.cpp
! src/share/vm/code/codeCache.hpp
! src/share/vm/code/nmethod.cpp
! src/share/vm/compiler/compileBroker.cpp
! src/share/vm/memory/heap.cpp
! src/share/vm/memory/heap.hpp
! src/share/vm/opto/output.cpp

Changeset: dedc8563e33d
Author:    bharadwaj
Date:      2013-04-18 16:04 -0700
URL:       http://hg.openjdk.java.net/hsx/hotspot-main/hotspot/rev/dedc8563e33d

Merge

- make/bsd/makefiles/jvmg.make
- make/bsd/makefiles/profiled.make
- make/linux/makefiles/jvmg.make
- make/linux/makefiles/profiled.make
- make/solaris/makefiles/jvmg.make
- make/solaris/makefiles/profiled.make
- src/os/bsd/vm/chaitin_bsd.cpp
- src/os/linux/vm/chaitin_linux.cpp
- src/os/solaris/vm/chaitin_solaris.cpp
- src/os/windows/vm/chaitin_windows.cpp

Changeset: 2a9d97b57920
Author:    bharadwaj
Date:      2013-04-19 03:13 -0400
URL:       http://hg.openjdk.java.net/hsx/hotspot-main/hotspot/rev/2a9d97b57920

Merge

- make/bsd/makefiles/jvmg.make
- make/bsd/makefiles/profiled.make
- make/linux/makefiles/jvmg.make
- make/linux/makefiles/profiled.make
- make/solaris/makefiles/jvmg.make
- make/solaris/makefiles/profiled.make
- src/os/bsd/vm/chaitin_bsd.cpp
- src/os/linux/vm/chaitin_linux.cpp
- src/os/solaris/vm/chaitin_solaris.cpp
- src/os/windows/vm/chaitin_windows.cpp
! src/share/vm/c1/c1_LIRGenerator.cpp
! src/share/vm/prims/whitebox.cpp
! src/share/vm/runtime/vmStructs.cpp


From bengt.rutisson at oracle.com  Fri Apr 19 08:34:44 2013
From: bengt.rutisson at oracle.com (bengt.rutisson at oracle.com)
Date: Fri, 19 Apr 2013 15:34:44 +0000
Subject: hg: hsx/hsx24/hotspot: 2 new changesets
Message-ID: <20130419153449.66BFF4847E@hg.openjdk.java.net>

Changeset: 23701768db61
Author:    brutisso
Date:      2013-04-18 06:50 +0200
URL:       http://hg.openjdk.java.net/hsx/hsx24/hotspot/rev/23701768db61

8012455: Missing time and date stamps for PrintGCApplicationConcurrentTime and PrintGCApplicationStoppedTime
Summary: also reviewed by: kirk at kodewerk.com, brandon at twitter.com
Reviewed-by: tschatzl, stefank, johnc

! src/share/vm/services/runtimeService.cpp

Changeset: 7cfae19d0f1c
Author:    brutisso
Date:      2013-04-19 07:25 +0200
URL:       http://hg.openjdk.java.net/hsx/hsx24/hotspot/rev/7cfae19d0f1c

Merge



From volker.simonis at gmail.com  Fri Apr 19 09:54:58 2013
From: volker.simonis at gmail.com (Volker Simonis)
Date: Fri, 19 Apr 2013 18:54:58 +0200
Subject: Some ccache benchmarking
In-Reply-To: <5171182B.5010901@oracle.com>
References: <5171182B.5010901@oracle.com>
Message-ID: 

+1 for C

Another nice side effect of option C would be that the 'no precompiled
headers' build would be automatically used more often. This would eliminate
a lot of small but nasty dependency problems which are introduced from time
to time because apparently everybody is only building with precompiled
headers (and precompiled header usage tends to hide these problems).

And option C would also not introduce yet another flag to the build which
is only familiar to people who know the gcc man page by heart:)

Volker



On Fri, Apr 19, 2013 at 12:10 PM, Erik Joelsson wrote:

> Hello,
>
> In the new build, on Linux, configure tries to pick up and use ccache if
> available on the machine. It is even being picky about the version (3.1.4
> minimum) to make sure that precompiled headers are supported, since those
> are used in the hotspot build. I have looked into this precompiled header
> support in ccache some and have some insights to share. The trigger for
> this was observing that building hotspot with an empty ccache took a very
> long time compared to not using ccache at all.
>
> Looking at the ccache manual, for precompiled headers to actually be used,
> the gcc flag -fpch-preprocess needs to be added to the command line. What
> it does is enabling precompiled headers when running gcc in preprocess only
> mode, which ccache needs to do in order to create the hash for the cache. I
> have experimented with adding this flag to see what performance differences
> it would yield. As a second option, I've also tried disabling precompiled
> headers completely. Here is a summary of the results from running on my
> machine (Ubuntu 10.10 x86_64 8 cores):
>
> Summary                    no ccache   empty cache   full cache
> without -fpch-preprocess   2:42        5:28          1:07
> with -fpch-preprocess      2:43        3:27          1:32
> no precompiled headers     3:32        3:47          0:54
>
> Adding the flag reduces the compilation time with an empty cache
> tremendously. However, it also increases the compilation time with a full
> cache significantly. Disabling precompiled headers completely when using
> ccache also reduces time with the empty cache, though not as much. It does
> however speed up compilation with a full cache even more than any of the
> other options.
>
> My conclusion is that the current situation is bad and needs to be
> improved. Either of the methods tested will be an improvement. Here are the
> options as I see them:
>
> A. Add -fpch-preprocess to CFLAGS permanently in hotspot.
>
> B. Have configure add -fpch-preprocess if ccache is used.
>
> C. Have configure disable precompiled headers if ccache is used. This also
> removes the current version requirement of 3.1.4 on ccache for precompiled
> header support which is enforced in configure, and would automatically
> (re)enable ccache use in jprt.
>
> I would lean towards option C, but would be interested in other opinions.
>
> /Erik
>

From alejandro.murillo at oracle.com  Fri Apr 19 13:06:08 2013
From: alejandro.murillo at oracle.com (alejandro.murillo at oracle.com)
Date: Fri, 19 Apr 2013 20:06:08 +0000
Subject: hg: hsx/hsx25/hotspot: 35 new changesets
Message-ID: <20130419200730.A63BF4848E@hg.openjdk.java.net>

Changeset: b0301c02f38e
Author:    katleman
Date:      2013-04-12 15:22 -0700
URL:       http://hg.openjdk.java.net/hsx/hsx25/hotspot/rev/b0301c02f38e

8012048: JDK8 b85 source with GPL header errors
Reviewed-by: iris, mduigou, jjg

! make/bsd/makefiles/fastdebug.make
! src/share/vm/services/diagnosticArgument.cpp
! test/sanity/WBApi.java
! test/serviceability/ParserTest.java
! test/testlibrary/whitebox/sun/hotspot/WhiteBox.java
! test/testlibrary/whitebox/sun/hotspot/parser/DiagnosticCommand.java

Changeset: c9eb0ec1c792
Author:    katleman
Date:      2013-04-15 14:19 -0700
URL:       http://hg.openjdk.java.net/hsx/hsx25/hotspot/rev/c9eb0ec1c792

Merge

! test/testlibrary/whitebox/sun/hotspot/WhiteBox.java

Changeset: 86db4847f195
Author:    katleman
Date:      2013-04-17 12:38 -0700
URL:       http://hg.openjdk.java.net/hsx/hsx25/hotspot/rev/86db4847f195

Merge

! test/testlibrary/whitebox/sun/hotspot/WhiteBox.java

Changeset: 2e657354f6bc
Author:    katleman
Date:      2013-04-18 10:30 -0700
URL:       http://hg.openjdk.java.net/hsx/hsx25/hotspot/rev/2e657354f6bc

Added tag jdk8-b86 for changeset 86db4847f195

! .hgtags

Changeset: c60f69931e1a
Author:    amurillo
Date:      2013-04-11 21:54 -0700
URL:       http://hg.openjdk.java.net/hsx/hsx25/hotspot/rev/c60f69931e1a

8011949: new hotspot build - hs25-b29
Reviewed-by: jcoomes

! make/hotspot_version

Changeset: 35f8765422b9
Author:    zgu
Date:      2013-04-10 08:55 -0400
URL:       http://hg.openjdk.java.net/hsx/hsx25/hotspot/rev/35f8765422b9

8010151: nsk/regression/b6653214 fails "assert(snapshot != NULL) failed: Worker should not be started"
Summary: Fixed a racing condition when shutting down NMT while worker thread is being started, also fixed a few mis-declared volatile pointers.
Reviewed-by: dholmes, dlong

! src/share/vm/runtime/thread.hpp
! src/share/vm/services/memTrackWorker.cpp
! src/share/vm/services/memTrackWorker.hpp
! src/share/vm/services/memTracker.cpp
! src/share/vm/services/memTracker.hpp

Changeset: f2c0ccccc6b6
Author:    rdurbin
Date:      2013-04-16 08:59 -0700
URL:       http://hg.openjdk.java.net/hsx/hsx25/hotspot/rev/f2c0ccccc6b6

Merge


Changeset: 71013d764f6e
Author:    johnc
Date:      2013-04-10 10:57 -0700
URL:       http://hg.openjdk.java.net/hsx/hsx25/hotspot/rev/71013d764f6e

8010780: G1: Eden occupancy/capacity output wrong after a full GC
Summary: Move the calculation and recording of eden capacity to the start of a GC and print a detailed heap transition for full GCs.
Reviewed-by: tschatzl, jmasa

! src/share/vm/gc_implementation/g1/g1CollectedHeap.cpp
! src/share/vm/gc_implementation/g1/g1CollectorPolicy.cpp
! src/share/vm/gc_implementation/g1/g1CollectorPolicy.hpp

Changeset: c0000f77bc6d
Author:    johnc
Date:      2013-04-11 10:20 -0700
URL:       http://hg.openjdk.java.net/hsx/hsx25/hotspot/rev/c0000f77bc6d

Merge

! src/share/vm/gc_implementation/g1/g1CollectedHeap.cpp

Changeset: 9aa8d8037ee3
Author:    mgerdin
Date:      2013-04-16 12:46 +0200
URL:       http://hg.openjdk.java.net/hsx/hsx25/hotspot/rev/9aa8d8037ee3

Merge

! src/share/vm/gc_implementation/g1/g1CollectorPolicy.cpp

Changeset: df254344edf1
Author:    jmasa
Date:      2013-04-01 10:50 -0700
URL:       http://hg.openjdk.java.net/hsx/hsx25/hotspot/rev/df254344edf1

8011173: NPG: Replace the ChunkList implementation with class FreeList
Reviewed-by: mgerdin, tschatzl, johnc, coleenp

! src/share/vm/memory/metaspace.cpp

Changeset: f2e682ef3156
Author:    johnc
Date:      2013-04-17 10:57 -0700
URL:       http://hg.openjdk.java.net/hsx/hsx25/hotspot/rev/f2e682ef3156

8012335: G1: Fix bug with compressed oops in template interpreter on x86 and sparc.
Summary: In do_oop_store the uncompressed value of the oop being stored needs to be preserved and passed to g1_write_barrier_post. This is necessary for the heap region cross check to work correctly.
Reviewed-by: coleenp, johnc
Contributed-by: Martin Doerr 

! src/cpu/sparc/vm/templateTable_sparc.cpp
! src/cpu/x86/vm/templateTable_x86_64.cpp

Changeset: 07a4efc5ed14
Author:    brutisso
Date:      2013-04-18 06:50 +0200
URL:       http://hg.openjdk.java.net/hsx/hsx25/hotspot/rev/07a4efc5ed14

8012455: Missing time and date stamps for PrintGCApplicationConcurrentTime and PrintGCApplicationStoppedTime
Summary: also reviewed by: kirk at kodewerk.com, brandon at twitter.com
Reviewed-by: tschatzl, stefank, johnc

! src/share/vm/services/runtimeService.cpp

Changeset: cbf8c8c25bbe
Author:    mgerdin
Date:      2013-04-18 14:38 +0200
URL:       http://hg.openjdk.java.net/hsx/hsx25/hotspot/rev/cbf8c8c25bbe

Merge


Changeset: aeaca88565e6
Author:    jiangli
Date:      2013-04-09 17:17 -0400
URL:       http://hg.openjdk.java.net/hsx/hsx25/hotspot/rev/aeaca88565e6

8010862: The Method counter fields used for profiling can be allocated lazily.
Summary: Allocate the method's profiling related metadata until they are needed.
Reviewed-by: coleenp, roland

! agent/src/share/classes/sun/jvm/hotspot/oops/Method.java
+ agent/src/share/classes/sun/jvm/hotspot/oops/MethodCounters.java
! src/cpu/sparc/vm/cppInterpreter_sparc.cpp
! src/cpu/sparc/vm/interp_masm_sparc.cpp
! src/cpu/sparc/vm/interp_masm_sparc.hpp
! src/cpu/sparc/vm/templateInterpreter_sparc.cpp
! src/cpu/sparc/vm/templateTable_sparc.cpp
! src/cpu/x86/vm/cppInterpreter_x86.cpp
! src/cpu/x86/vm/interp_masm_x86_32.cpp
! src/cpu/x86/vm/interp_masm_x86_32.hpp
! src/cpu/x86/vm/interp_masm_x86_64.cpp
! src/cpu/x86/vm/interp_masm_x86_64.hpp
! src/cpu/x86/vm/templateInterpreter_x86_32.cpp
! src/cpu/x86/vm/templateInterpreter_x86_64.cpp
! src/cpu/x86/vm/templateTable_x86_32.cpp
! src/cpu/x86/vm/templateTable_x86_64.cpp
! src/share/vm/c1/c1_LIRGenerator.cpp
! src/share/vm/ci/ciMethod.cpp
! src/share/vm/ci/ciMethod.hpp
! src/share/vm/ci/ciReplay.cpp
! src/share/vm/interpreter/interpreterRuntime.cpp
! src/share/vm/interpreter/interpreterRuntime.hpp
! src/share/vm/interpreter/invocationCounter.cpp
! src/share/vm/oops/method.cpp
! src/share/vm/oops/method.hpp
+ src/share/vm/oops/methodCounters.cpp
+ src/share/vm/oops/methodCounters.hpp
! src/share/vm/oops/methodData.cpp
! src/share/vm/opto/parseHelper.cpp
! src/share/vm/runtime/advancedThresholdPolicy.cpp
! src/share/vm/runtime/compilationPolicy.cpp
! src/share/vm/runtime/fprofiler.cpp
! src/share/vm/runtime/simpleThresholdPolicy.cpp
! src/share/vm/runtime/vmStructs.cpp

Changeset: 42a42da29fd7
Author:    jiangli
Date:      2013-04-11 23:06 -0400
URL:       http://hg.openjdk.java.net/hsx/hsx25/hotspot/rev/42a42da29fd7

8012052: java/lang/invoke/6987555/Test6987555.java crashes with assert(mcs != NULL) failed: MethodCounters cannot be NULL.
Summary: Skip counter decay if the MethodCounters is NULL in NonTieredCompPolicy::delay_compilation().
Reviewed-by: kvn, dholmes

! src/share/vm/runtime/compilationPolicy.cpp

Changeset: 8df6ddda8090
Author:    jiangli
Date:      2013-04-15 21:25 -0400
URL:       http://hg.openjdk.java.net/hsx/hsx25/hotspot/rev/8df6ddda8090

Merge

! src/share/vm/c1/c1_LIRGenerator.cpp
! src/share/vm/interpreter/interpreterRuntime.cpp
! src/share/vm/oops/method.hpp
! src/share/vm/oops/methodData.cpp
! src/share/vm/prims/whitebox.cpp
! src/share/vm/runtime/compilationPolicy.cpp
! src/share/vm/runtime/vmStructs.cpp

Changeset: 9500809ceead
Author:    jiangli
Date:      2013-04-18 17:00 -0400
URL:       http://hg.openjdk.java.net/hsx/hsx25/hotspot/rev/9500809ceead

Merge

! src/cpu/sparc/vm/templateTable_sparc.cpp
! src/cpu/x86/vm/templateTable_x86_64.cpp

Changeset: b8b081e53312
Author:    twisti
Date:      2013-04-12 12:22 -0700
URL:       http://hg.openjdk.java.net/hsx/hsx25/hotspot/rev/b8b081e53312

8011933: add number of classes, methods and time spent to CompileTheWorld
Reviewed-by: jrose, kvn

! src/share/vm/classfile/classLoader.cpp
! src/share/vm/classfile/classLoader.hpp

Changeset: 393fd4ef89c4
Author:    twisti
Date:      2013-04-12 15:43 -0700
URL:       http://hg.openjdk.java.net/hsx/hsx25/hotspot/rev/393fd4ef89c4

8011678: test/Makefile should pick up JT_HOME environment variable
Reviewed-by: kvn

! test/Makefile

Changeset: f36e073d56a4
Author:    drchase
Date:      2013-04-12 15:53 -0700
URL:       http://hg.openjdk.java.net/hsx/hsx25/hotspot/rev/f36e073d56a4

7104565: trim jprt build targets
Summary: remove JPRT debug builds, remove -DDEBUG -DFASTDEBUG and use ASSERT instead in sources
Reviewed-by: dholmes, kvn, coleenp

! make/Makefile
! make/bsd/Makefile
! make/bsd/makefiles/buildtree.make
! make/bsd/makefiles/debug.make
! make/bsd/makefiles/defs.make
! make/bsd/makefiles/fastdebug.make
- make/bsd/makefiles/jvmg.make
- make/bsd/makefiles/profiled.make
! make/jprt.properties
! make/linux/Makefile
! make/linux/makefiles/buildtree.make
! make/linux/makefiles/debug.make
! make/linux/makefiles/defs.make
! make/linux/makefiles/fastdebug.make
- make/linux/makefiles/jvmg.make
- make/linux/makefiles/profiled.make
! make/solaris/Makefile
! make/solaris/makefiles/buildtree.make
! make/solaris/makefiles/debug.make
! make/solaris/makefiles/defs.make
! make/solaris/makefiles/fastdebug.make
- make/solaris/makefiles/jvmg.make
- make/solaris/makefiles/profiled.make
! make/windows/build.make
! make/windows/makefiles/defs.make
! make/windows/makefiles/vm.make
! make/windows/projectfiles/compiler2/ADLCompiler.dsp
! make/windows/projectfiles/tiered/ADLCompiler.dsp
! src/cpu/sparc/vm/frame_sparc.cpp
! src/os/bsd/dtrace/generateJvmOffsets.cpp
! src/os/solaris/dtrace/generateJvmOffsets.cpp
! src/os/windows/vm/os_windows.cpp
! src/share/tools/hsdis/Makefile
! src/share/vm/classfile/stackMapFrame.hpp
! src/share/vm/gc_implementation/concurrentMarkSweep/concurrentMarkSweepGeneration.cpp
! src/share/vm/memory/allocation.hpp
! src/share/vm/runtime/vmThread.cpp

Changeset: bc63dd2539a4
Author:    kvn
Date:      2013-04-12 20:37 -0400
URL:       http://hg.openjdk.java.net/hsx/hsx25/hotspot/rev/bc63dd2539a4

Merge

! make/bsd/makefiles/debug.make
- make/bsd/makefiles/jvmg.make
- make/bsd/makefiles/profiled.make
! make/linux/makefiles/debug.make
- make/linux/makefiles/jvmg.make
- make/linux/makefiles/profiled.make
! make/solaris/makefiles/debug.make
- make/solaris/makefiles/jvmg.make
- make/solaris/makefiles/profiled.make

Changeset: 886d1fd67dc3
Author:    drchase
Date:      2013-04-12 19:14 -0700
URL:       http://hg.openjdk.java.net/hsx/hsx25/hotspot/rev/886d1fd67dc3

6443505: Ideal() function for CmpLTMask
Summary: Repair wrong code generation, added new matching rule
Reviewed-by: kvn, twisti

! src/cpu/sparc/vm/sparc.ad
! src/cpu/x86/vm/x86_32.ad
! src/cpu/x86/vm/x86_64.ad
! src/share/vm/opto/cfgnode.cpp
+ test/compiler/6443505/Test6443505.java

Changeset: bb4a966cc68f
Author:    roland
Date:      2013-04-15 09:42 +0200
URL:       http://hg.openjdk.java.net/hsx/hsx25/hotspot/rev/bb4a966cc68f

8011582: assert(nbits == 32 || (-(1 << nbits-1) <= x && x < ( 1 << nbits-1))) failed: value out of range
Summary: c1 runtime's predicate_failed_trap should use jump_to on sparc
Reviewed-by: kvn

! src/cpu/sparc/vm/c1_Runtime1_sparc.cpp

Changeset: 1c6887c9afaa
Author:    twisti
Date:      2013-04-15 16:20 -0700
URL:       http://hg.openjdk.java.net/hsx/hsx25/hotspot/rev/1c6887c9afaa

7172922: export_ makefile targets do not work unless all supported variants are built
Reviewed-by: dholmes, kvn

! make/Makefile

Changeset: acadb114c818
Author:    roland
Date:      2013-04-15 17:17 +0200
URL:       http://hg.openjdk.java.net/hsx/hsx25/hotspot/rev/acadb114c818

8011648: C1: optimized build is broken after 7153771
Summary: missing #ifdef ASSERT
Reviewed-by: kvn

! src/share/vm/c1/c1_Canonicalizer.cpp
! src/share/vm/c1/c1_Canonicalizer.hpp
! src/share/vm/c1/c1_Instruction.hpp
! src/share/vm/c1/c1_InstructionPrinter.cpp
! src/share/vm/c1/c1_InstructionPrinter.hpp
! src/share/vm/c1/c1_LIR.cpp
! src/share/vm/c1/c1_LIR.hpp
! src/share/vm/c1/c1_LIRGenerator.cpp
! src/share/vm/c1/c1_LIRGenerator.hpp
! src/share/vm/c1/c1_Optimizer.cpp
! src/share/vm/c1/c1_RangeCheckElimination.hpp
! src/share/vm/c1/c1_ValueMap.hpp

Changeset: b105029fdbfd
Author:    roland
Date:      2013-04-15 18:42 -0700
URL:       http://hg.openjdk.java.net/hsx/hsx25/hotspot/rev/b105029fdbfd

Merge


Changeset: 8373c19be854
Author:    neliasso
Date:      2013-04-16 10:08 +0200
URL:       http://hg.openjdk.java.net/hsx/hsx25/hotspot/rev/8373c19be854

8011621: live_ranges_in_separate_class.patch
Reviewed-by: kvn, roland
Contributed-by: niclas.adlertz at oracle.com

! make/bsd/makefiles/vm.make
! make/linux/makefiles/vm.make
! make/solaris/makefiles/vm.make
! make/windows/create_obj_files.sh
- src/os/bsd/vm/chaitin_bsd.cpp
- src/os/linux/vm/chaitin_linux.cpp
- src/os/solaris/vm/chaitin_solaris.cpp
- src/os/windows/vm/chaitin_windows.cpp
! src/share/vm/opto/chaitin.cpp
! src/share/vm/opto/chaitin.hpp
! src/share/vm/opto/coalesce.cpp
! src/share/vm/opto/coalesce.hpp
! src/share/vm/opto/compile.cpp
! src/share/vm/opto/idealGraphPrinter.cpp
! src/share/vm/opto/ifg.cpp
! src/share/vm/opto/live.cpp
! src/share/vm/opto/live.hpp
! src/share/vm/opto/postaloc.cpp
! src/share/vm/opto/reg_split.cpp
! src/share/vm/opto/regalloc.hpp
! src/share/vm/runtime/vmStructs.cpp

Changeset: c89eab0b6b30
Author:    neliasso
Date:      2013-04-16 10:37 -0400
URL:       http://hg.openjdk.java.net/hsx/hsx25/hotspot/rev/c89eab0b6b30

Merge

- src/os/bsd/vm/chaitin_bsd.cpp
- src/os/linux/vm/chaitin_linux.cpp
- src/os/solaris/vm/chaitin_solaris.cpp
- src/os/windows/vm/chaitin_windows.cpp

Changeset: 4b2eebe03f93
Author:    iignatyev
Date:      2013-04-16 10:04 -0700
URL:       http://hg.openjdk.java.net/hsx/hsx25/hotspot/rev/4b2eebe03f93

8011971: WB API doesn't accept j.l.reflect.Constructor
Reviewed-by: kvn, vlivanov

! src/share/vm/prims/whitebox.cpp
! test/compiler/whitebox/ClearMethodStateTest.java
! test/compiler/whitebox/CompilerWhiteBoxTest.java
! test/compiler/whitebox/DeoptimizeAllTest.java
! test/compiler/whitebox/DeoptimizeMethodTest.java
! test/compiler/whitebox/EnqueueMethodForCompilationTest.java
! test/compiler/whitebox/IsMethodCompilableTest.java
! test/compiler/whitebox/MakeMethodNotCompilableTest.java
! test/compiler/whitebox/SetDontInlineMethodTest.java
! test/compiler/whitebox/SetForceInlineMethodTest.java
! test/testlibrary/whitebox/sun/hotspot/WhiteBox.java

Changeset: a7fb14888912
Author:    neliasso
Date:      2013-04-11 13:57 +0200
URL:       http://hg.openjdk.java.net/hsx/hsx25/hotspot/rev/a7fb14888912

8006952: Slow VM due to excessive code cache freelist iteration
Summary: Remove continous free block requirement
Reviewed-by: kvn

! src/share/vm/code/codeBlob.cpp
! src/share/vm/code/codeCache.cpp
! src/share/vm/code/codeCache.hpp
! src/share/vm/code/nmethod.cpp
! src/share/vm/compiler/compileBroker.cpp
! src/share/vm/memory/heap.cpp
! src/share/vm/memory/heap.hpp
! src/share/vm/opto/output.cpp

Changeset: dedc8563e33d
Author:    bharadwaj
Date:      2013-04-18 16:04 -0700
URL:       http://hg.openjdk.java.net/hsx/hsx25/hotspot/rev/dedc8563e33d

Merge

- make/bsd/makefiles/jvmg.make
- make/bsd/makefiles/profiled.make
- make/linux/makefiles/jvmg.make
- make/linux/makefiles/profiled.make
- make/solaris/makefiles/jvmg.make
- make/solaris/makefiles/profiled.make
- src/os/bsd/vm/chaitin_bsd.cpp
- src/os/linux/vm/chaitin_linux.cpp
- src/os/solaris/vm/chaitin_solaris.cpp
- src/os/windows/vm/chaitin_windows.cpp

Changeset: 2a9d97b57920
Author:    bharadwaj
Date:      2013-04-19 03:13 -0400
URL:       http://hg.openjdk.java.net/hsx/hsx25/hotspot/rev/2a9d97b57920

Merge

- make/bsd/makefiles/jvmg.make
- make/bsd/makefiles/profiled.make
- make/linux/makefiles/jvmg.make
- make/linux/makefiles/profiled.make
- make/solaris/makefiles/jvmg.make
- make/solaris/makefiles/profiled.make
- src/os/bsd/vm/chaitin_bsd.cpp
- src/os/linux/vm/chaitin_linux.cpp
- src/os/solaris/vm/chaitin_solaris.cpp
- src/os/windows/vm/chaitin_windows.cpp
! src/share/vm/c1/c1_LIRGenerator.cpp
! src/share/vm/prims/whitebox.cpp
! src/share/vm/runtime/vmStructs.cpp

Changeset: 01d5f04e64dc
Author:    amurillo
Date:      2013-04-19 09:58 -0700
URL:       http://hg.openjdk.java.net/hsx/hsx25/hotspot/rev/01d5f04e64dc

Merge

! make/bsd/makefiles/fastdebug.make
- make/bsd/makefiles/jvmg.make
- make/bsd/makefiles/profiled.make
- make/linux/makefiles/jvmg.make
- make/linux/makefiles/profiled.make
- make/solaris/makefiles/jvmg.make
- make/solaris/makefiles/profiled.make
- src/os/bsd/vm/chaitin_bsd.cpp
- src/os/linux/vm/chaitin_linux.cpp
- src/os/solaris/vm/chaitin_solaris.cpp
- src/os/windows/vm/chaitin_windows.cpp
! test/testlibrary/whitebox/sun/hotspot/WhiteBox.java

Changeset: 0491c26b1f1d
Author:    amurillo
Date:      2013-04-19 09:58 -0700
URL:       http://hg.openjdk.java.net/hsx/hsx25/hotspot/rev/0491c26b1f1d

Added tag hs25-b29 for changeset 01d5f04e64dc

! .hgtags


From igor.ignatyev at oracle.com  Fri Apr 19 13:45:09 2013
From: igor.ignatyev at oracle.com (Igor Ignatyev)
Date: Sat, 20 Apr 2013 00:45:09 +0400
Subject: RFR(S) : 8012337 : Change Whitebox implementation to make absence
	of method in Whitebox.class not fatal
In-Reply-To: <51707599.8050907@oracle.com>
References: <516E7569.1060201@oracle.com> <516E85EC.6040203@oracle.com>
	<516EAA0F.2020807@oracle.com> <51705F1E.6050602@oracle.com>
	<51707599.8050907@oracle.com>
Message-ID: <5171ACD5.7040409@oracle.com>

Vladimir,
thank you for your hint.

I rewrote the test w/o shell using:
http://cr.openjdk.java.net/~iignatyev/8012337/webrev.02/

Best regards,
Igor Ignatyev

On 04/19/2013 02:37 AM, Vladimir Kozlov wrote:
> Why not use WB technique (ClassFileInstaller) which compiles and copies
> class file into directory you want so you can avoid using shell?
>
> Vladimir
>
> On 4/18/13 2:01 PM, Igor Ignatyev wrote:
>> could someone with "reviewer" status look at that?
>>
>> Best regards,
>> Igor Ignatyev
>>
>> On 04/17/2013 05:56 PM, Igor Ignatyev wrote:
>>> Mikael,
>>> Thank you for review.
>>>
>>> I have updated webrev:
>>> - added checking for exception class
>>> - added print warning on unexpected error
>>>
>>> http://cr.openjdk.java.net/~iignatyev/8012337/webrev.01/
>>>
>>> Best regards,
>>> Igor Ignatyev
>>>
>>> On 04/17/2013 03:22 PM, Mikael Gerdin wrote:
>>>> Igor,
>>>>
>>>> On 2013-04-17 12:11, Igor Ignatyev wrote:
>>>>> Hi all,
>>>>>
>>>>> Please review patch.
>>>>>
>>>>> Problem:
>>>>> If there is some method that presences in native part of whitebox, but
>>>>> absences in java side, we get 'j.l.NoSuchMethodError' exception
>>>>
>>>> The intended use of is of course that whitebox.cpp and WhiteBox.java
>>>> are
>>>> in sync since they are in the same hg repository.
>>>>
>>>> I understand that some feel that they need to copy WhiteBox to some
>>>> other test suite and I find this change acceptable but unfortunate.
>>>>
>>>>>
>>>>> Fix:
>>>>> Batch registration of WB functions was replaced with one by one
>>>>> registration
>>>>>
>>>>> Testing:
>>>>> JPRT of sanity tests and tests that use WhiteBox: runtime/interned,
>>>>> compiler/whitebox
>>>>>
>>>>> webrev: http://cr.openjdk.java.net/~iignatyev/8012337/webrev.00/
>>>>
>>>> It's too bad that you need a shell script here but I don't see any way
>>>> around it.
>>>>
>>>> I'm ok with you pushing this.
>>>>
>>>> /Mikael
>>>>
>>>>> jbs: https://jbs.oracle.com/bugs/browse/JDK-8012337

From vladimir.kozlov at oracle.com  Fri Apr 19 13:59:38 2013
From: vladimir.kozlov at oracle.com (Vladimir Kozlov)
Date: Fri, 19 Apr 2013 13:59:38 -0700
Subject: RFR(S) : 8012337 : Change Whitebox implementation to make absence
	of method in Whitebox.class not fatal
In-Reply-To: <5171ACD5.7040409@oracle.com>
References: <516E7569.1060201@oracle.com> <516E85EC.6040203@oracle.com>
	<516EAA0F.2020807@oracle.com> <51705F1E.6050602@oracle.com>
	<51707599.8050907@oracle.com> <5171ACD5.7040409@oracle.com>
Message-ID: <5171B03A.2070903@oracle.com>

Good.

Thanks,
Vladimir

On 4/19/13 1:45 PM, Igor Ignatyev wrote:
> Vladimir,
> thank you for your hint.
>
> I rewrote the test w/o shell using:
> http://cr.openjdk.java.net/~iignatyev/8012337/webrev.02/
>
> Best regards,
> Igor Ignatyev
>
> On 04/19/2013 02:37 AM, Vladimir Kozlov wrote:
>> Why not use WB technique (ClassFileInstaller) which compiles and copies
>> class file into directory you want so you can avoid using shell?
>>
>> Vladimir
>>
>> On 4/18/13 2:01 PM, Igor Ignatyev wrote:
>>> could someone with "reviewer" status look at that?
>>>
>>> Best regards,
>>> Igor Ignatyev
>>>
>>> On 04/17/2013 05:56 PM, Igor Ignatyev wrote:
>>>> Mikael,
>>>> Thank you for review.
>>>>
>>>> I have updated webrev:
>>>> - added checking for exception class
>>>> - added print warning on unexpected error
>>>>
>>>> http://cr.openjdk.java.net/~iignatyev/8012337/webrev.01/
>>>>
>>>> Best regards,
>>>> Igor Ignatyev
>>>>
>>>> On 04/17/2013 03:22 PM, Mikael Gerdin wrote:
>>>>> Igor,
>>>>>
>>>>> On 2013-04-17 12:11, Igor Ignatyev wrote:
>>>>>> Hi all,
>>>>>>
>>>>>> Please review patch.
>>>>>>
>>>>>> Problem:
>>>>>> If there is some method that presences in native part of whitebox,
>>>>>> but
>>>>>> absences in java side, we get 'j.l.NoSuchMethodError' exception
>>>>>
>>>>> The intended use of is of course that whitebox.cpp and WhiteBox.java
>>>>> are
>>>>> in sync since they are in the same hg repository.
>>>>>
>>>>> I understand that some feel that they need to copy WhiteBox to some
>>>>> other test suite and I find this change acceptable but unfortunate.
>>>>>
>>>>>>
>>>>>> Fix:
>>>>>> Batch registration of WB functions was replaced with one by one
>>>>>> registration
>>>>>>
>>>>>> Testing:
>>>>>> JPRT of sanity tests and tests that use WhiteBox: runtime/interned,
>>>>>> compiler/whitebox
>>>>>>
>>>>>> webrev: http://cr.openjdk.java.net/~iignatyev/8012337/webrev.00/
>>>>>
>>>>> It's too bad that you need a shell script here but I don't see any way
>>>>> around it.
>>>>>
>>>>> I'm ok with you pushing this.
>>>>>
>>>>> /Mikael
>>>>>
>>>>>> jbs: https://jbs.oracle.com/bugs/browse/JDK-8012337

From alejandro.murillo at oracle.com  Fri Apr 19 14:29:21 2013
From: alejandro.murillo at oracle.com (alejandro.murillo at oracle.com)
Date: Fri, 19 Apr 2013 21:29:21 +0000
Subject: hg: hsx/hotspot-main/hotspot: 7 new changesets
Message-ID: <20130419212936.A728248491@hg.openjdk.java.net>

Changeset: b0301c02f38e
Author:    katleman
Date:      2013-04-12 15:22 -0700
URL:       http://hg.openjdk.java.net/hsx/hotspot-main/hotspot/rev/b0301c02f38e

8012048: JDK8 b85 source with GPL header errors
Reviewed-by: iris, mduigou, jjg

! make/bsd/makefiles/fastdebug.make
! src/share/vm/services/diagnosticArgument.cpp
! test/sanity/WBApi.java
! test/serviceability/ParserTest.java
! test/testlibrary/whitebox/sun/hotspot/WhiteBox.java
! test/testlibrary/whitebox/sun/hotspot/parser/DiagnosticCommand.java

Changeset: c9eb0ec1c792
Author:    katleman
Date:      2013-04-15 14:19 -0700
URL:       http://hg.openjdk.java.net/hsx/hotspot-main/hotspot/rev/c9eb0ec1c792

Merge

! test/testlibrary/whitebox/sun/hotspot/WhiteBox.java

Changeset: 86db4847f195
Author:    katleman
Date:      2013-04-17 12:38 -0700
URL:       http://hg.openjdk.java.net/hsx/hotspot-main/hotspot/rev/86db4847f195

Merge

! test/testlibrary/whitebox/sun/hotspot/WhiteBox.java

Changeset: 2e657354f6bc
Author:    katleman
Date:      2013-04-18 10:30 -0700
URL:       http://hg.openjdk.java.net/hsx/hotspot-main/hotspot/rev/2e657354f6bc

Added tag jdk8-b86 for changeset 86db4847f195

! .hgtags

Changeset: 01d5f04e64dc
Author:    amurillo
Date:      2013-04-19 09:58 -0700
URL:       http://hg.openjdk.java.net/hsx/hotspot-main/hotspot/rev/01d5f04e64dc

Merge

! make/bsd/makefiles/fastdebug.make
- make/bsd/makefiles/jvmg.make
- make/bsd/makefiles/profiled.make
- make/linux/makefiles/jvmg.make
- make/linux/makefiles/profiled.make
- make/solaris/makefiles/jvmg.make
- make/solaris/makefiles/profiled.make
- src/os/bsd/vm/chaitin_bsd.cpp
- src/os/linux/vm/chaitin_linux.cpp
- src/os/solaris/vm/chaitin_solaris.cpp
- src/os/windows/vm/chaitin_windows.cpp
! test/testlibrary/whitebox/sun/hotspot/WhiteBox.java

Changeset: 0491c26b1f1d
Author:    amurillo
Date:      2013-04-19 09:58 -0700
URL:       http://hg.openjdk.java.net/hsx/hotspot-main/hotspot/rev/0491c26b1f1d

Added tag hs25-b29 for changeset 01d5f04e64dc

! .hgtags

Changeset: f78763f49817
Author:    amurillo
Date:      2013-04-19 10:09 -0700
URL:       http://hg.openjdk.java.net/hsx/hotspot-main/hotspot/rev/f78763f49817

8012559: new hotspot build - hs25-b30
Reviewed-by: jcoomes

! make/hotspot_version


From igor.ignatyev at oracle.com  Fri Apr 19 23:34:40 2013
From: igor.ignatyev at oracle.com (Igor Ignatyev)
Date: Sat, 20 Apr 2013 10:34:40 +0400
Subject: RFR(S) : 8012337 : Change Whitebox implementation to make absence
	of method in Whitebox.class not fatal
In-Reply-To: <5171B03A.2070903@oracle.com>
References: <516E7569.1060201@oracle.com> <516E85EC.6040203@oracle.com>
	<516EAA0F.2020807@oracle.com> <51705F1E.6050602@oracle.com>
	<51707599.8050907@oracle.com> <5171ACD5.7040409@oracle.com>
	<5171B03A.2070903@oracle.com>
Message-ID: <51723700.7020201@oracle.com>

Vladimir,

Thank you for review.

Best regards,
Igor Ignatyev

On 04/20/2013 12:59 AM, Vladimir Kozlov wrote:
> Good.
>
> Thanks,
> Vladimir
>
> On 4/19/13 1:45 PM, Igor Ignatyev wrote:
>> Vladimir,
>> thank you for your hint.
>>
>> I rewrote the test w/o shell using:
>> http://cr.openjdk.java.net/~iignatyev/8012337/webrev.02/
>>
>> Best regards,
>> Igor Ignatyev
>>
>> On 04/19/2013 02:37 AM, Vladimir Kozlov wrote:
>>> Why not use WB technique (ClassFileInstaller) which compiles and copies
>>> class file into directory you want so you can avoid using shell?
>>>
>>> Vladimir
>>>
>>> On 4/18/13 2:01 PM, Igor Ignatyev wrote:
>>>> could someone with "reviewer" status look at that?
>>>>
>>>> Best regards,
>>>> Igor Ignatyev
>>>>
>>>> On 04/17/2013 05:56 PM, Igor Ignatyev wrote:
>>>>> Mikael,
>>>>> Thank you for review.
>>>>>
>>>>> I have updated webrev:
>>>>> - added checking for exception class
>>>>> - added print warning on unexpected error
>>>>>
>>>>> http://cr.openjdk.java.net/~iignatyev/8012337/webrev.01/
>>>>>
>>>>> Best regards,
>>>>> Igor Ignatyev
>>>>>
>>>>> On 04/17/2013 03:22 PM, Mikael Gerdin wrote:
>>>>>> Igor,
>>>>>>
>>>>>> On 2013-04-17 12:11, Igor Ignatyev wrote:
>>>>>>> Hi all,
>>>>>>>
>>>>>>> Please review patch.
>>>>>>>
>>>>>>> Problem:
>>>>>>> If there is some method that presences in native part of whitebox,
>>>>>>> but
>>>>>>> absences in java side, we get 'j.l.NoSuchMethodError' exception
>>>>>>
>>>>>> The intended use of is of course that whitebox.cpp and WhiteBox.java
>>>>>> are
>>>>>> in sync since they are in the same hg repository.
>>>>>>
>>>>>> I understand that some feel that they need to copy WhiteBox to some
>>>>>> other test suite and I find this change acceptable but unfortunate.
>>>>>>
>>>>>>>
>>>>>>> Fix:
>>>>>>> Batch registration of WB functions was replaced with one by one
>>>>>>> registration
>>>>>>>
>>>>>>> Testing:
>>>>>>> JPRT of sanity tests and tests that use WhiteBox: runtime/interned,
>>>>>>> compiler/whitebox
>>>>>>>
>>>>>>> webrev: http://cr.openjdk.java.net/~iignatyev/8012337/webrev.00/
>>>>>>
>>>>>> It's too bad that you need a shell script here but I don't see any
>>>>>> way
>>>>>> around it.
>>>>>>
>>>>>> I'm ok with you pushing this.
>>>>>>
>>>>>> /Mikael
>>>>>>
>>>>>>> jbs: https://jbs.oracle.com/bugs/browse/JDK-8012337

From coleen.phillimore at oracle.com  Sun Apr 21 17:10:49 2013
From: coleen.phillimore at oracle.com (Coleen Phillimore)
Date: Sun, 21 Apr 2013 20:10:49 -0400
Subject: CFV: New hsx Committer: Tao Mao
In-Reply-To: <20848.19457.854901.807286@oracle.com>
References: <20848.19457.854901.807286@oracle.com>
Message-ID: <51748009.8070000@oracle.com>

Vote: yes

On 4/18/2013 3:39 PM, John Coomes wrote:
> I hereby nominate Tao Mao to hsx Committer.
>
> Tao joined the HotSpot garbage collection team at Oracle last year;
> over the last eight months he has contributed eight changesets which
> have improved or fixed bugs in several different GC components
> including ergonomics, G1 and serial gc [1].
>
> Votes are due by Thu, May 2, 2013 8:00pm UTC [2].
>
> Only current hsx Committers [3] are eligible to vote on this
> nomination.  Votes must be cast in the open by replying to to this
> mailing list.
>
> For Lazy Consensus voting instructions, see [4].
>
> John Coomes, hsx Project Lead
>
> [1] http://hg.openjdk.java.net/hsx/hotspot-gc/hotspot/log?rev=tao.mao
> [2] http://www.timeanddate.com/worldclock/fixedtime.html?msg=CFV%3A+New+hsx+Committer%3A+Tao+Mao&iso=20130502T20
> [3] http://openjdk.java.net/census/#hsx
> [4] http://openjdk.java.net/projects/#committer-vote


From markus.gronlund at oracle.com  Mon Apr 22 05:04:41 2013
From: markus.gronlund at oracle.com (markus.gronlund at oracle.com)
Date: Mon, 22 Apr 2013 12:04:41 +0000
Subject: hg: hsx/hsx24/hotspot: 8012714: Assign the unique traceid directly to
	the Klass upon creation
Message-ID: <20130422120449.CEF37484D5@hg.openjdk.java.net>

Changeset: d81b052ce793
Author:    mgronlun
Date:      2013-04-22 10:49 +0200
URL:       http://hg.openjdk.java.net/hsx/hsx24/hotspot/rev/d81b052ce793

8012714: Assign the unique traceid directly to the Klass upon creation
Reviewed-by: sla, dholmes

! src/share/vm/classfile/systemDictionary.cpp
! src/share/vm/oops/klass.cpp
! src/share/vm/trace/traceMacros.hpp


From stefan.karlsson at oracle.com  Mon Apr 22 11:10:26 2013
From: stefan.karlsson at oracle.com (Stefan Karlsson)
Date: Mon, 22 Apr 2013 20:10:26 +0200
Subject: RFR (S): 8011803: release_C_heap_structures is never called for
	anonymous classes.
In-Reply-To: <516EC666.5010805@oracle.com>
References: <51672297.3080503@oracle.com> <5167CA4C.5040608@oracle.com>
	<51680041.5070905@oracle.com> <51685A67.4020007@oracle.com>
	<51687E59.6060702@oracle.com> <516BB8FD.4030001@oracle.com>
	<516EC666.5010805@oracle.com>
Message-ID: <51757D12.10807@oracle.com>

On 2013-04-17 17:57, Coleen Phillimore wrote:
>
> Mikael, Thanks for looking at this in detail.
>
> On 4/15/2013 4:23 AM, Mikael Gerdin wrote:
>> Coleen,
>>
>> On 2013-04-12 23:36, Coleen Phillimore wrote:
>>> On 4/12/2013 3:03 PM, Coleen Phillimore wrote:
>>>>
>>>> Hi,
>>>>
>>>> I have updated the webrev to split the serviceability actions and the
>>>> deleting C heap data for classes in ClassLoaderData.  I left the
>>>> serviceability actions in dictionary::do_unloading() to avoid
>>>> rewalking the ClassLoaderData _klasses.   For
>>>> release_C_heap_structures(), all the _klasses are walked at the end.
>>>> This should work for Markus G's new serviceability changes with minor
>>>> modifications.
>>>
>>> Reload if you looked at this already.  Stefan convinced me that walking
>>> the class list in the ClassLoaderData::unload() is not too 
>>> expensive, so
>>> the serviceability actions have been removed from
>>> dictionary::do_unloading() and done in ClassLoaderData::unload()
>>> unconditionally.
>>
>> It looks like http://cr.openjdk.java.net/~coleenp/8011803_2/ is the 
>> wrong webrev since it's inconsistent with your mail.
>> But I have some comments about moving the calls to 
>> release_c_heap_structures.
>
> I forgot to copy it over.  Please reload.
>>
>>
>> By moving the calls to {IK,CP}::release_c_heap_structures to 
>> ~ClassLoaderData they will be called concurrently from the CMS thread 
>> through its call to ClassLoaderDataGraph::purge.
>>
>> Previously they were called at a safepoint since 
>> Dictionary::do_unloading is only called at safepoint.
>> A cursory inspection suggests that this is safe.
>>
>> However.
>> This will cause the symbol refcounts to be decremented at a later 
>> stage than before, in fact by the time we come to ~ClassLoaderData 
>> we've already called SymbolTable::unkink so this will artificially 
>> extend the lifetime of unreferenced symbols by one full gc.
>
> Yes, this is true and a good point.  I feel like it's safer actually 
> since all the memory shouldn't go away before the destructor is run.   
> Symbols aren't reclaimed that much so this change is not likely to 
> cause a measurable increase in footprint between GC's (famous last 
> words).
If you are OK with the Symbols being reclaimed later, and that we now 
release the C heap structures concurrently with the mutator threads 
(CMS), then this looks good to me.

thanks,
StefanK

>
> Coleen
>
>>
>> /Mikael
>>
>>>
>>>>
>>>> open webrev at http://cr.openjdk.java.net/~coleenp/8011803_2/
>>>>
>>>> thanks,
>>>> Coleen
>>>>
>>>> On 4/12/2013 8:38 AM, Coleen Phillimore wrote:
>>>>> On 4/12/2013 4:48 AM, Stefan Karlsson wrote:
>>>>>> On 04/11/2013 10:52 PM, Coleen Phillimore wrote:
>>>>>>> Summary: Call this function from CLD::unload()  now for anonymous
>>>>>>> classes.
>>>>>>>
>>>>>>> Anonymous classes aren't in the system dictionary so
>>>>>>> release_C_heap_structures isn't called for them if they are
>>>>>>> unloaded.  I fixed this for jdk8 because they are in the class
>>>>>>> loader data graph but for jdk7, I don't know how to fix this. They
>>>>>>> are unloaded by being garbage collected after the references are
>>>>>>> dropped.
>>>>>>>
>>>>>>> Tested with ute tests vm.mvlm.testlist nsk.monitoring.testlist and
>>>>>>> jdk/test/java/lang/invoke tests.
>>>>>>>
>>>>>>> open webrev at http://cr.openjdk.java.net/~coleenp/8011803/
>>>>>>> bug link at http://bugs.sun.com/view_bug.do?bug_id=8011803
>>>>>>
>>>>>> I've two comments.
>>>>>>
>>>>>> 1) It's unfortunate that we now call unload_class() at two different
>>>>>> places in the code. It makes it harder to understand the
>>>>>> deallocation of metadata. It would be better to keep the calls to
>>>>>> unload_class() for ordinary InstanceKlasses and anonymous classes
>>>>>> together.
>>>>>
>>>>> Hi Stefan,  Thank you for looking at this.   This is the feedback I
>>>>> was looking for.
>>>>>
>>>>> I went back and forth about moving the regular class unloading
>>>>> actions for everything in unload (or ~ClassLoaderData), but I didn't
>>>>> want to introduce a _klasses walk for all the class loaders.   We're
>>>>> already walking them in the system dictionary purge.
>>>>>
>>>>> For my change I'm walking these classes if
>>>>> UseCompressedKlassPointers, and Markus is walking them for
>>>>> serviceability (hopefully under some flag) so maybe I should just 
>>>>> do it.
>>>>>
>>>>>>
>>>>>> 2) This change actually breaks the Tracing class unloading event
>>>>>> that Markus is working on. That code walk the
>>>>>> ClassLoaderDataGraph::_unloading list in
>>>>>> ClassLoaderDataGraph::do_unloading and use the information in the
>>>>>> classes of the CLDs that are about to be unloaded. With this patch
>>>>>> they probably crash because some pointers in the anonymous classes
>>>>>> will be trashed.
>>>>>>
>>>>>
>>>>> I thought about that, since I've been talking to Markus about this. I
>>>>> wanted to consolidate the serviceability calls in one place and
>>>>> calling InstanceKlass::unload_class() that notifies serviceability in
>>>>> the ~ClassLoaderData destructor might be too late.  It might not be
>>>>> though.   I think the walk in the destructor might be better for
>>>>> release_C_heap_structures though.
>>>>>
>>>>>> I have a suggestion on how to solve both points above. It's probably
>>>>>> easier to show with a pseudo patch:
>>>>>>
>>>>>> $ hg diff
>>>>>> diff --git a/src/share/vm/classfile/classLoaderData.cpp
>>>>>> b/src/share/vm/classfile/classLoaderData.cpp
>>>>>> --- a/src/share/vm/classfile/classLoaderData.cpp
>>>>>> +++ b/src/share/vm/classfile/classLoaderData.cpp
>>>>>> @@ -671,7 +671,6 @@
>>>>>>      }
>>>>>>      seen_dead_loader = true;
>>>>>>      ClassLoaderData* dead = data;
>>>>>> -    dead->unload();
>>>>>>      data = data->next();
>>>>>>      // Remove from loader list.
>>>>>>      if (prev != NULL) {
>>>>>> @@ -683,9 +682,24 @@
>>>>>>      dead->set_next(_unloading);
>>>>>>      _unloading = dead;
>>>>>>    }
>>>>>> +
>>>>>> +  report_class_unloading_info(_unloading);
>>>>>> +
>>>>>> +  ClassLoaderDataGraph::unload_classes();
>>>>>> +
>>>>>>    return seen_dead_loader;
>>>>>>  }
>>>>>>
>>>>>> +void ClassLoaderDataGraph::unload_classes() {
>>>>>> +  ClassLoaderData* list = _unloading;
>>>>>> +  ClassLoaderData* next = list;
>>>>>> +  while (next != NULL) {
>>>>>> +    for (Klass* k = next->_klasses; k != NULL; k = 
>>>>>> k->next_link()) {
>>>>>> +      k->unload_class();
>>>>>> +    }
>>>>>> +  }
>>>>>> +}
>>>>>> +
>>>>>
>>>>> That's too much extra walking.   But maybe we can split the
>>>>> serviceability stuff into ClassLoaderData::unload() and do the
>>>>> release_C_heap_structures() into the ClassLoaderData destructor. That
>>>>> seems better.   Maybe Markus could put his callback into 
>>>>> CLD::unload().
>>>>>
>>>>> Thanks!  I will change this and resend.
>>>>> Coleen
>>>>>
>>>>>>  void ClassLoaderDataGraph::purge() {
>>>>>>    ClassLoaderData* list = _unloading;
>>>>>>    _unloading = NULL;
>>>>>> diff --git a/src/share/vm/classfile/dictionary.cpp
>>>>>> b/src/share/vm/classfile/dictionary.cpp
>>>>>> --- a/src/share/vm/classfile/dictionary.cpp
>>>>>> +++ b/src/share/vm/classfile/dictionary.cpp
>>>>>> @@ -157,9 +157,6 @@
>>>>>>              // to be unloaded.
>>>>>>              // Notify the debugger and clean up the class.
>>>>>>              class_was_unloaded = true;
>>>>>> -
>>>>>> -            // perform unloading actions on this class
>>>>>> -            ik->unload_class();
>>>>>>            }
>>>>>>            // Also remove this system dictionary entry.
>>>>>>            purge_entry = true;
>>>>>>
>>>>>> As a bonus, the dictionary()->do_unloading() will then only do a
>>>>>> simple purge of the SystemDictionary.
>>>>>>
>>>>>> What do you think?
>>>>>>
>>>>>> thanks,
>>>>>> StefanK
>>>>>>
>>>>>>>
>>>>>>> Thanks,
>>>>>>> Coleen
>>>>>>
>>>>>
>>>>
>>>
>


From christian.thalinger at oracle.com  Mon Apr 22 12:47:07 2013
From: christian.thalinger at oracle.com (Christian Thalinger)
Date: Mon, 22 Apr 2013 12:47:07 -0700
Subject: RFR (M): 8008772: remove gamma launcher
Message-ID: <5C64AF5E-EDD5-4669-9777-5FF7CE6E615F@oracle.com>

http://cr.openjdk.java.net/~twisti/8008772/

8008772: remove gamma launcher
Reviewed-by:

Remove linking the gamma launcher and it's associated source files.

make/Makefile
make/bsd/makefiles/launcher.make
make/bsd/makefiles/vm.make
make/hotspot.script
make/linux/makefiles/launcher.make
make/linux/makefiles/vm.make
make/solaris/makefiles/launcher.make
make/solaris/makefiles/vm.make
make/windows/makefiles/debug.make
make/windows/makefiles/fastdebug.make
make/windows/makefiles/launcher.make
make/windows/makefiles/product.make
make/windows/makefiles/projectcreator.make
make/windows/projectfiles/common/Makefile
src/os/posix/launcher/java_md.c
src/os/posix/launcher/java_md.h
src/os/posix/launcher/launcher.script
src/os/windows/launcher/java_md.c
src/os/windows/launcher/java_md.h
src/share/tools/launcher/java.c
src/share/tools/launcher/java.h
src/share/tools/launcher/jli_util.c
src/share/tools/launcher/jli_util.h
src/share/tools/launcher/wildcard.c
src/share/tools/launcher/wildcard.h

This change removes the duplicated java launcher files (which were subject to bit-rot) and modifies the hotspot script to pick up the libjvm in the current build directory.

The modified hotspot script works with GDB and DBX:

cthaling at intelsdv03.us.oracle.com:/export/twisti/build/8008772/build/linux_i486_compiler2/debug$ ./hotspot -gdb -version
GNU gdb (GDB) Red Hat Enterprise Linux (7.1-29.el6)
Copyright (C) 2010 Free Software Foundation, Inc.
License GPLv3+: GNU GPL version 3 or later 
This is free software: you are free to change and redistribute it.
There is NO WARRANTY, to the extent permitted by law.  Type "show copying"
and "show warranty" for details.
This GDB was configured as "x86_64-redhat-linux-gnu".
For bug reporting instructions, please see:
.
Missing separate debuginfo for /net/scanas404.us.oracle.com/export/java-re/jdk/8/ea/b86/binaries/linux-i586/bin/java
Try: yum --disablerepo='*' --enablerepo='*-debuginfo' install /usr/lib/debug/.build-id/5e/85e6dced3b388a7b0e50630242f4c7ee5e31a3.debug
Function "JNI_CreateJavaVM" not defined.
Breakpoint 1 (JNI_CreateJavaVM) pending.
[Thread debugging using libthread_db enabled]
[New Thread 0xf7fe4b70 (LWP 13459)]
[Switching to Thread 0xf7fe4b70 (LWP 13459)]

Breakpoint 1, JNI_CreateJavaVM (vm=0xf7fe4378, penv=0xf7fe4374, args=0xf7fe4364)
    at /net/10.159.161.234/Users/cthaling/ws/8008772/src/share/vm/prims/jni.cpp:5062
5062	  jint result = JNI_ERR;
Missing separate debuginfos, use: debuginfo-install glibc-2.12-1.7.el6.i686
(gdb) break CompileBroker::compile_method
Breakpoint 2 at 0xaef852: file /net/10.159.161.234/Users/cthaling/ws/8008772/src/share/vm/compiler/compileBroker.cpp, line 1205.
(gdb) c
Continuing.
[New Thread 0xf7f93b70 (LWP 13460)]
[New Thread 0xb4398b70 (LWP 13461)]
[New Thread 0xb41ffb70 (LWP 13462)]
[New Thread 0xb3effb70 (LWP 13463)]
[New Thread 0xb3cffb70 (LWP 13464)]
[New Thread 0xb3affb70 (LWP 13465)]
[New Thread 0xb38ffb70 (LWP 13466)]
[New Thread 0xb36ffb70 (LWP 13467)]
[New Thread 0xb34ffb70 (LWP 13468)]
[New Thread 0xb32ffb70 (LWP 13469)]
[New Thread 0xb30ffb70 (LWP 13470)]
[New Thread 0xb2effb70 (LWP 13471)]
[New Thread 0xb2cffb70 (LWP 13472)]
[New Thread 0xaf8e8b70 (LWP 13473)]
[New Thread 0xb4156b70 (LWP 13474)]
[New Thread 0xb3c7eb70 (LWP 13475)]
[New Thread 0xb3a7eb70 (LWP 13476)]
[New Thread 0xaeeffb70 (LWP 13477)]
[New Thread 0xaecffb70 (LWP 13478)]
[New Thread 0xb387eb70 (LWP 13479)]
[New Thread 0xaeaffb70 (LWP 13480)]
java version "1.8.0-ea"
Java(TM) SE Runtime Environment (build 1.8.0-ea-b86)
Java HotSpot(TM) Server VM (build 25.0-b29-internal-debug, mixed mode)
[Thread 0xaeaffb70 (LWP 13480) exited]
[Thread 0xb3a7eb70 (LWP 13476) exited]
[Thread 0xaf8e8b70 (LWP 13473) exited]
[Thread 0xf7fe4b70 (LWP 13459) exited]
[Thread 0xb2cffb70 (LWP 13472) exited]
[Thread 0xb2effb70 (LWP 13471) exited]
[Thread 0xaecffb70 (LWP 13478) exited]
[Thread 0xb387eb70 (LWP 13479) exited]
[Thread 0xaeeffb70 (LWP 13477) exited]
[Thread 0xb3c7eb70 (LWP 13475) exited]
[Thread 0xb4156b70 (LWP 13474) exited]
[Thread 0xb32ffb70 (LWP 13469) exited]
[Thread 0xb34ffb70 (LWP 13468) exited]
[Thread 0xb36ffb70 (LWP 13467) exited]
[Thread 0xb38ffb70 (LWP 13466) exited]
[Thread 0xb3affb70 (LWP 13465) exited]
[Thread 0xb3cffb70 (LWP 13464) exited]
[Thread 0xb3effb70 (LWP 13463) exited]
[Thread 0xb41ffb70 (LWP 13462) exited]
[Thread 0xb4398b70 (LWP 13461) exited]
[Thread 0xf7f93b70 (LWP 13460) exited]
[Thread 0xb30ffb70 (LWP 13470) exited]

Program exited normally.
(gdb) 


cthaling at intelsdv01:/export/twisti/build/8008772/build/solaris_i486_compiler2/debug$ /bin/bash ./hotspot -dbx -version
dbx: warning: using the alternate init file: /home/cthaling/.dbxrc
Reading java
Reading ld.so.1
Reading libjli.so
Reading libthread.so.1
Reading libdl.so.1
Reading libc.so.1
Reading libjvm.so
Loaded loadobject: /export/twisti/build/8008772/build/solaris_i486_compiler2/debug/libjvm.so
Running: java -Dsun.java.launcher=gamma -XXaltjvm=/export/twisti/build/8008772/build/solaris_i486_compiler2/debug -version 
(process id 29613)
Reading libsocket.so.1
Reading libsched.so.1
Reading libm.so.1
Reading libCrun.so.1
Reading libdoor.so.1
Reading libdemangle.so.1
Reading libnsl.so.1
Reading libm.so.2
Reading libscf.so.1
Reading libuutil.so.1
Reading libgen.so.1
Reading libmd.so.1
Reading libmp.so.2
t at 2 (l at 2) stopped in JNI_CreateJavaVM at line 5062 in file "jni.cpp"
 5062     jint result = JNI_ERR;
(dbx) stop in CompileBroker::compile_method      
(2) stop in CompileBroker::compile_method(methodHandle,int,int,methodHandle,int,const char*,Thread*)
(dbx) c
Reading libverify.so
Reading libjava.so
Reading libzip.so
java version "1.8.0-ea"
Java(TM) SE Runtime Environment (build 1.8.0-ea-b86)
Java HotSpot(TM) Server VM (build 25.0-b29-internal-debug, mixed mode)

execution completed, exit code is 0
(dbx) 


From daniel.daugherty at oracle.com  Mon Apr 22 13:36:59 2013
From: daniel.daugherty at oracle.com (Daniel D. Daugherty)
Date: Mon, 22 Apr 2013 14:36:59 -0600
Subject: RFR (M): 8008772: remove gamma launcher
In-Reply-To: <5C64AF5E-EDD5-4669-9777-5FF7CE6E615F@oracle.com>
References: <5C64AF5E-EDD5-4669-9777-5FF7CE6E615F@oracle.com>
Message-ID: <51759F6B.7080808@oracle.com>

Chris,

Just an observation and not a review.

Looks like you're removing launcher support on Windows, but it
looks like the new hotspot.script doesn't support Windows...
Am I missing something?

Dan


On 4/22/13 1:47 PM, Christian Thalinger wrote:
> http://cr.openjdk.java.net/~twisti/8008772/
>
> 8008772: remove gamma launcher
> Reviewed-by:
>
> Remove linking the gamma launcher and it's associated source files.
>
> make/Makefile
> make/bsd/makefiles/launcher.make
> make/bsd/makefiles/vm.make
> make/hotspot.script
> make/linux/makefiles/launcher.make
> make/linux/makefiles/vm.make
> make/solaris/makefiles/launcher.make
> make/solaris/makefiles/vm.make
> make/windows/makefiles/debug.make
> make/windows/makefiles/fastdebug.make
> make/windows/makefiles/launcher.make
> make/windows/makefiles/product.make
> make/windows/makefiles/projectcreator.make
> make/windows/projectfiles/common/Makefile
> src/os/posix/launcher/java_md.c
> src/os/posix/launcher/java_md.h
> src/os/posix/launcher/launcher.script
> src/os/windows/launcher/java_md.c
> src/os/windows/launcher/java_md.h
> src/share/tools/launcher/java.c
> src/share/tools/launcher/java.h
> src/share/tools/launcher/jli_util.c
> src/share/tools/launcher/jli_util.h
> src/share/tools/launcher/wildcard.c
> src/share/tools/launcher/wildcard.h
>
> This change removes the duplicated java launcher files (which were subject to bit-rot) and modifies the hotspot script to pick up the libjvm in the current build directory.
>
> The modified hotspot script works with GDB and DBX:
>
> cthaling at intelsdv03.us.oracle.com:/export/twisti/build/8008772/build/linux_i486_compiler2/debug$ ./hotspot -gdb -version
> GNU gdb (GDB) Red Hat Enterprise Linux (7.1-29.el6)
> Copyright (C) 2010 Free Software Foundation, Inc.
> License GPLv3+: GNU GPL version 3 or later 
> This is free software: you are free to change and redistribute it.
> There is NO WARRANTY, to the extent permitted by law.  Type "show copying"
> and "show warranty" for details.
> This GDB was configured as "x86_64-redhat-linux-gnu".
> For bug reporting instructions, please see:
> .
> Missing separate debuginfo for /net/scanas404.us.oracle.com/export/java-re/jdk/8/ea/b86/binaries/linux-i586/bin/java
> Try: yum --disablerepo='*' --enablerepo='*-debuginfo' install /usr/lib/debug/.build-id/5e/85e6dced3b388a7b0e50630242f4c7ee5e31a3.debug
> Function "JNI_CreateJavaVM" not defined.
> Breakpoint 1 (JNI_CreateJavaVM) pending.
> [Thread debugging using libthread_db enabled]
> [New Thread 0xf7fe4b70 (LWP 13459)]
> [Switching to Thread 0xf7fe4b70 (LWP 13459)]
>
> Breakpoint 1, JNI_CreateJavaVM (vm=0xf7fe4378, penv=0xf7fe4374, args=0xf7fe4364)
>      at /net/10.159.161.234/Users/cthaling/ws/8008772/src/share/vm/prims/jni.cpp:5062
> 5062	  jint result = JNI_ERR;
> Missing separate debuginfos, use: debuginfo-install glibc-2.12-1.7.el6.i686
> (gdb) break CompileBroker::compile_method
> Breakpoint 2 at 0xaef852: file /net/10.159.161.234/Users/cthaling/ws/8008772/src/share/vm/compiler/compileBroker.cpp, line 1205.
> (gdb) c
> Continuing.
> [New Thread 0xf7f93b70 (LWP 13460)]
> [New Thread 0xb4398b70 (LWP 13461)]
> [New Thread 0xb41ffb70 (LWP 13462)]
> [New Thread 0xb3effb70 (LWP 13463)]
> [New Thread 0xb3cffb70 (LWP 13464)]
> [New Thread 0xb3affb70 (LWP 13465)]
> [New Thread 0xb38ffb70 (LWP 13466)]
> [New Thread 0xb36ffb70 (LWP 13467)]
> [New Thread 0xb34ffb70 (LWP 13468)]
> [New Thread 0xb32ffb70 (LWP 13469)]
> [New Thread 0xb30ffb70 (LWP 13470)]
> [New Thread 0xb2effb70 (LWP 13471)]
> [New Thread 0xb2cffb70 (LWP 13472)]
> [New Thread 0xaf8e8b70 (LWP 13473)]
> [New Thread 0xb4156b70 (LWP 13474)]
> [New Thread 0xb3c7eb70 (LWP 13475)]
> [New Thread 0xb3a7eb70 (LWP 13476)]
> [New Thread 0xaeeffb70 (LWP 13477)]
> [New Thread 0xaecffb70 (LWP 13478)]
> [New Thread 0xb387eb70 (LWP 13479)]
> [New Thread 0xaeaffb70 (LWP 13480)]
> java version "1.8.0-ea"
> Java(TM) SE Runtime Environment (build 1.8.0-ea-b86)
> Java HotSpot(TM) Server VM (build 25.0-b29-internal-debug, mixed mode)
> [Thread 0xaeaffb70 (LWP 13480) exited]
> [Thread 0xb3a7eb70 (LWP 13476) exited]
> [Thread 0xaf8e8b70 (LWP 13473) exited]
> [Thread 0xf7fe4b70 (LWP 13459) exited]
> [Thread 0xb2cffb70 (LWP 13472) exited]
> [Thread 0xb2effb70 (LWP 13471) exited]
> [Thread 0xaecffb70 (LWP 13478) exited]
> [Thread 0xb387eb70 (LWP 13479) exited]
> [Thread 0xaeeffb70 (LWP 13477) exited]
> [Thread 0xb3c7eb70 (LWP 13475) exited]
> [Thread 0xb4156b70 (LWP 13474) exited]
> [Thread 0xb32ffb70 (LWP 13469) exited]
> [Thread 0xb34ffb70 (LWP 13468) exited]
> [Thread 0xb36ffb70 (LWP 13467) exited]
> [Thread 0xb38ffb70 (LWP 13466) exited]
> [Thread 0xb3affb70 (LWP 13465) exited]
> [Thread 0xb3cffb70 (LWP 13464) exited]
> [Thread 0xb3effb70 (LWP 13463) exited]
> [Thread 0xb41ffb70 (LWP 13462) exited]
> [Thread 0xb4398b70 (LWP 13461) exited]
> [Thread 0xf7f93b70 (LWP 13460) exited]
> [Thread 0xb30ffb70 (LWP 13470) exited]
>
> Program exited normally.
> (gdb)
>
>
> cthaling at intelsdv01:/export/twisti/build/8008772/build/solaris_i486_compiler2/debug$ /bin/bash ./hotspot -dbx -version
> dbx: warning: using the alternate init file: /home/cthaling/.dbxrc
> Reading java
> Reading ld.so.1
> Reading libjli.so
> Reading libthread.so.1
> Reading libdl.so.1
> Reading libc.so.1
> Reading libjvm.so
> Loaded loadobject: /export/twisti/build/8008772/build/solaris_i486_compiler2/debug/libjvm.so
> Running: java -Dsun.java.launcher=gamma -XXaltjvm=/export/twisti/build/8008772/build/solaris_i486_compiler2/debug -version
> (process id 29613)
> Reading libsocket.so.1
> Reading libsched.so.1
> Reading libm.so.1
> Reading libCrun.so.1
> Reading libdoor.so.1
> Reading libdemangle.so.1
> Reading libnsl.so.1
> Reading libm.so.2
> Reading libscf.so.1
> Reading libuutil.so.1
> Reading libgen.so.1
> Reading libmd.so.1
> Reading libmp.so.2
> t at 2 (l at 2) stopped in JNI_CreateJavaVM at line 5062 in file "jni.cpp"
>   5062     jint result = JNI_ERR;
> (dbx) stop in CompileBroker::compile_method
> (2) stop in CompileBroker::compile_method(methodHandle,int,int,methodHandle,int,const char*,Thread*)
> (dbx) c
> Reading libverify.so
> Reading libjava.so
> Reading libzip.so
> java version "1.8.0-ea"
> Java(TM) SE Runtime Environment (build 1.8.0-ea-b86)
> Java HotSpot(TM) Server VM (build 25.0-b29-internal-debug, mixed mode)
>
> execution completed, exit code is 0
> (dbx)
>


From coleen.phillimore at oracle.com  Mon Apr 22 13:46:27 2013
From: coleen.phillimore at oracle.com (Coleen Phillimore)
Date: Mon, 22 Apr 2013 16:46:27 -0400
Subject: RFR (S): 8011803: release_C_heap_structures is never called for
	anonymous classes.
In-Reply-To: <51757D12.10807@oracle.com>
References: <51672297.3080503@oracle.com> <5167CA4C.5040608@oracle.com>
	<51680041.5070905@oracle.com> <51685A67.4020007@oracle.com>
	<51687E59.6060702@oracle.com> <516BB8FD.4030001@oracle.com>
	<516EC666.5010805@oracle.com> <51757D12.10807@oracle.com>
Message-ID: <5175A1A3.7010707@oracle.com>


On 04/22/2013 02:10 PM, Stefan Karlsson wrote:
> On 2013-04-17 17:57, Coleen Phillimore wrote:
>>
>> Mikael, Thanks for looking at this in detail.
>>
>> On 4/15/2013 4:23 AM, Mikael Gerdin wrote:
>>> Coleen,
>>>
>>> On 2013-04-12 23:36, Coleen Phillimore wrote:
>>>> On 4/12/2013 3:03 PM, Coleen Phillimore wrote:
>>>>>
>>>>> Hi,
>>>>>
>>>>> I have updated the webrev to split the serviceability actions and the
>>>>> deleting C heap data for classes in ClassLoaderData.  I left the
>>>>> serviceability actions in dictionary::do_unloading() to avoid
>>>>> rewalking the ClassLoaderData _klasses.   For
>>>>> release_C_heap_structures(), all the _klasses are walked at the end.
>>>>> This should work for Markus G's new serviceability changes with minor
>>>>> modifications.
>>>>
>>>> Reload if you looked at this already.  Stefan convinced me that 
>>>> walking
>>>> the class list in the ClassLoaderData::unload() is not too 
>>>> expensive, so
>>>> the serviceability actions have been removed from
>>>> dictionary::do_unloading() and done in ClassLoaderData::unload()
>>>> unconditionally.
>>>
>>> It looks like http://cr.openjdk.java.net/~coleenp/8011803_2/ is the 
>>> wrong webrev since it's inconsistent with your mail.
>>> But I have some comments about moving the calls to 
>>> release_c_heap_structures.
>>
>> I forgot to copy it over.  Please reload.
>>>
>>>
>>> By moving the calls to {IK,CP}::release_c_heap_structures to 
>>> ~ClassLoaderData they will be called concurrently from the CMS 
>>> thread through its call to ClassLoaderDataGraph::purge.
>>>
>>> Previously they were called at a safepoint since 
>>> Dictionary::do_unloading is only called at safepoint.
>>> A cursory inspection suggests that this is safe.
>>>
>>> However.
>>> This will cause the symbol refcounts to be decremented at a later 
>>> stage than before, in fact by the time we come to ~ClassLoaderData 
>>> we've already called SymbolTable::unkink so this will artificially 
>>> extend the lifetime of unreferenced symbols by one full gc.
>>
>> Yes, this is true and a good point.  I feel like it's safer actually 
>> since all the memory shouldn't go away before the destructor is 
>> run.   Symbols aren't reclaimed that much so this change is not 
>> likely to cause a measurable increase in footprint between GC's 
>> (famous last words).
> If you are OK with the Symbols being reclaimed later, and that we now 
> release the C heap structures concurrently with the mutator threads 
> (CMS), then this looks good to me.

Yes, I am ok with this.  I still think it's safer than having classes on 
the _unloaded list pointing to null symbols for names.
Thanks,
Coleen

>
> thanks,
> StefanK
>
>>
>> Coleen
>>
>>>
>>> /Mikael
>>>
>>>>
>>>>>
>>>>> open webrev at http://cr.openjdk.java.net/~coleenp/8011803_2/
>>>>>
>>>>> thanks,
>>>>> Coleen
>>>>>
>>>>> On 4/12/2013 8:38 AM, Coleen Phillimore wrote:
>>>>>> On 4/12/2013 4:48 AM, Stefan Karlsson wrote:
>>>>>>> On 04/11/2013 10:52 PM, Coleen Phillimore wrote:
>>>>>>>> Summary: Call this function from CLD::unload()  now for anonymous
>>>>>>>> classes.
>>>>>>>>
>>>>>>>> Anonymous classes aren't in the system dictionary so
>>>>>>>> release_C_heap_structures isn't called for them if they are
>>>>>>>> unloaded.  I fixed this for jdk8 because they are in the class
>>>>>>>> loader data graph but for jdk7, I don't know how to fix this. They
>>>>>>>> are unloaded by being garbage collected after the references are
>>>>>>>> dropped.
>>>>>>>>
>>>>>>>> Tested with ute tests vm.mvlm.testlist nsk.monitoring.testlist and
>>>>>>>> jdk/test/java/lang/invoke tests.
>>>>>>>>
>>>>>>>> open webrev at http://cr.openjdk.java.net/~coleenp/8011803/
>>>>>>>> bug link at http://bugs.sun.com/view_bug.do?bug_id=8011803
>>>>>>>
>>>>>>> I've two comments.
>>>>>>>
>>>>>>> 1) It's unfortunate that we now call unload_class() at two 
>>>>>>> different
>>>>>>> places in the code. It makes it harder to understand the
>>>>>>> deallocation of metadata. It would be better to keep the calls to
>>>>>>> unload_class() for ordinary InstanceKlasses and anonymous classes
>>>>>>> together.
>>>>>>
>>>>>> Hi Stefan,  Thank you for looking at this.   This is the feedback I
>>>>>> was looking for.
>>>>>>
>>>>>> I went back and forth about moving the regular class unloading
>>>>>> actions for everything in unload (or ~ClassLoaderData), but I didn't
>>>>>> want to introduce a _klasses walk for all the class loaders.   We're
>>>>>> already walking them in the system dictionary purge.
>>>>>>
>>>>>> For my change I'm walking these classes if
>>>>>> UseCompressedKlassPointers, and Markus is walking them for
>>>>>> serviceability (hopefully under some flag) so maybe I should just 
>>>>>> do it.
>>>>>>
>>>>>>>
>>>>>>> 2) This change actually breaks the Tracing class unloading event
>>>>>>> that Markus is working on. That code walk the
>>>>>>> ClassLoaderDataGraph::_unloading list in
>>>>>>> ClassLoaderDataGraph::do_unloading and use the information in the
>>>>>>> classes of the CLDs that are about to be unloaded. With this patch
>>>>>>> they probably crash because some pointers in the anonymous classes
>>>>>>> will be trashed.
>>>>>>>
>>>>>>
>>>>>> I thought about that, since I've been talking to Markus about 
>>>>>> this. I
>>>>>> wanted to consolidate the serviceability calls in one place and
>>>>>> calling InstanceKlass::unload_class() that notifies 
>>>>>> serviceability in
>>>>>> the ~ClassLoaderData destructor might be too late.  It might not be
>>>>>> though.   I think the walk in the destructor might be better for
>>>>>> release_C_heap_structures though.
>>>>>>
>>>>>>> I have a suggestion on how to solve both points above. It's 
>>>>>>> probably
>>>>>>> easier to show with a pseudo patch:
>>>>>>>
>>>>>>> $ hg diff
>>>>>>> diff --git a/src/share/vm/classfile/classLoaderData.cpp
>>>>>>> b/src/share/vm/classfile/classLoaderData.cpp
>>>>>>> --- a/src/share/vm/classfile/classLoaderData.cpp
>>>>>>> +++ b/src/share/vm/classfile/classLoaderData.cpp
>>>>>>> @@ -671,7 +671,6 @@
>>>>>>>      }
>>>>>>>      seen_dead_loader = true;
>>>>>>>      ClassLoaderData* dead = data;
>>>>>>> -    dead->unload();
>>>>>>>      data = data->next();
>>>>>>>      // Remove from loader list.
>>>>>>>      if (prev != NULL) {
>>>>>>> @@ -683,9 +682,24 @@
>>>>>>>      dead->set_next(_unloading);
>>>>>>>      _unloading = dead;
>>>>>>>    }
>>>>>>> +
>>>>>>> +  report_class_unloading_info(_unloading);
>>>>>>> +
>>>>>>> +  ClassLoaderDataGraph::unload_classes();
>>>>>>> +
>>>>>>>    return seen_dead_loader;
>>>>>>>  }
>>>>>>>
>>>>>>> +void ClassLoaderDataGraph::unload_classes() {
>>>>>>> +  ClassLoaderData* list = _unloading;
>>>>>>> +  ClassLoaderData* next = list;
>>>>>>> +  while (next != NULL) {
>>>>>>> +    for (Klass* k = next->_klasses; k != NULL; k = 
>>>>>>> k->next_link()) {
>>>>>>> +      k->unload_class();
>>>>>>> +    }
>>>>>>> +  }
>>>>>>> +}
>>>>>>> +
>>>>>>
>>>>>> That's too much extra walking.   But maybe we can split the
>>>>>> serviceability stuff into ClassLoaderData::unload() and do the
>>>>>> release_C_heap_structures() into the ClassLoaderData destructor. 
>>>>>> That
>>>>>> seems better.   Maybe Markus could put his callback into 
>>>>>> CLD::unload().
>>>>>>
>>>>>> Thanks!  I will change this and resend.
>>>>>> Coleen
>>>>>>
>>>>>>>  void ClassLoaderDataGraph::purge() {
>>>>>>>    ClassLoaderData* list = _unloading;
>>>>>>>    _unloading = NULL;
>>>>>>> diff --git a/src/share/vm/classfile/dictionary.cpp
>>>>>>> b/src/share/vm/classfile/dictionary.cpp
>>>>>>> --- a/src/share/vm/classfile/dictionary.cpp
>>>>>>> +++ b/src/share/vm/classfile/dictionary.cpp
>>>>>>> @@ -157,9 +157,6 @@
>>>>>>>              // to be unloaded.
>>>>>>>              // Notify the debugger and clean up the class.
>>>>>>>              class_was_unloaded = true;
>>>>>>> -
>>>>>>> -            // perform unloading actions on this class
>>>>>>> -            ik->unload_class();
>>>>>>>            }
>>>>>>>            // Also remove this system dictionary entry.
>>>>>>>            purge_entry = true;
>>>>>>>
>>>>>>> As a bonus, the dictionary()->do_unloading() will then only do a
>>>>>>> simple purge of the SystemDictionary.
>>>>>>>
>>>>>>> What do you think?
>>>>>>>
>>>>>>> thanks,
>>>>>>> StefanK
>>>>>>>
>>>>>>>>
>>>>>>>> Thanks,
>>>>>>>> Coleen
>>>>>>>
>>>>>>
>>>>>
>>>>
>>
>


From christian.thalinger at oracle.com  Mon Apr 22 13:55:11 2013
From: christian.thalinger at oracle.com (Christian Thalinger)
Date: Mon, 22 Apr 2013 13:55:11 -0700
Subject: RFR (M): 8008772: remove gamma launcher
In-Reply-To: <51759F6B.7080808@oracle.com>
References: <5C64AF5E-EDD5-4669-9777-5FF7CE6E615F@oracle.com>
	<51759F6B.7080808@oracle.com>
Message-ID: <764DA08E-5A58-4FD4-BB48-0F4F13401BCC@oracle.com>


On Apr 22, 2013, at 1:36 PM, Daniel D. Daugherty  wrote:

> Chris,
> 
> Just an observation and not a review.
> 
> Looks like you're removing launcher support on Windows, but it
> looks like the new hotspot.script doesn't support Windows...
> Am I missing something?

Almost certainly true.  Since I'm not a Windows user (and nobody near me is one) I have no idea how people are using the gamma launcher on Windows (or the hotspot script for that matter).

I presume most people doing debugging on the command line are already in cygwin?  But I might be wrong.

-- Chris

> 
> Dan
> 
> 
> On 4/22/13 1:47 PM, Christian Thalinger wrote:
>> http://cr.openjdk.java.net/~twisti/8008772/
>> 
>> 8008772: remove gamma launcher
>> Reviewed-by:
>> 
>> Remove linking the gamma launcher and it's associated source files.
>> 
>> make/Makefile
>> make/bsd/makefiles/launcher.make
>> make/bsd/makefiles/vm.make
>> make/hotspot.script
>> make/linux/makefiles/launcher.make
>> make/linux/makefiles/vm.make
>> make/solaris/makefiles/launcher.make
>> make/solaris/makefiles/vm.make
>> make/windows/makefiles/debug.make
>> make/windows/makefiles/fastdebug.make
>> make/windows/makefiles/launcher.make
>> make/windows/makefiles/product.make
>> make/windows/makefiles/projectcreator.make
>> make/windows/projectfiles/common/Makefile
>> src/os/posix/launcher/java_md.c
>> src/os/posix/launcher/java_md.h
>> src/os/posix/launcher/launcher.script
>> src/os/windows/launcher/java_md.c
>> src/os/windows/launcher/java_md.h
>> src/share/tools/launcher/java.c
>> src/share/tools/launcher/java.h
>> src/share/tools/launcher/jli_util.c
>> src/share/tools/launcher/jli_util.h
>> src/share/tools/launcher/wildcard.c
>> src/share/tools/launcher/wildcard.h
>> 
>> This change removes the duplicated java launcher files (which were subject to bit-rot) and modifies the hotspot script to pick up the libjvm in the current build directory.
>> 
>> The modified hotspot script works with GDB and DBX:
>> 
>> cthaling at intelsdv03.us.oracle.com:/export/twisti/build/8008772/build/linux_i486_compiler2/debug$ ./hotspot -gdb -version
>> GNU gdb (GDB) Red Hat Enterprise Linux (7.1-29.el6)
>> Copyright (C) 2010 Free Software Foundation, Inc.
>> License GPLv3+: GNU GPL version 3 or later 
>> This is free software: you are free to change and redistribute it.
>> There is NO WARRANTY, to the extent permitted by law.  Type "show copying"
>> and "show warranty" for details.
>> This GDB was configured as "x86_64-redhat-linux-gnu".
>> For bug reporting instructions, please see:
>> .
>> Missing separate debuginfo for /net/scanas404.us.oracle.com/export/java-re/jdk/8/ea/b86/binaries/linux-i586/bin/java
>> Try: yum --disablerepo='*' --enablerepo='*-debuginfo' install /usr/lib/debug/.build-id/5e/85e6dced3b388a7b0e50630242f4c7ee5e31a3.debug
>> Function "JNI_CreateJavaVM" not defined.
>> Breakpoint 1 (JNI_CreateJavaVM) pending.
>> [Thread debugging using libthread_db enabled]
>> [New Thread 0xf7fe4b70 (LWP 13459)]
>> [Switching to Thread 0xf7fe4b70 (LWP 13459)]
>> 
>> Breakpoint 1, JNI_CreateJavaVM (vm=0xf7fe4378, penv=0xf7fe4374, args=0xf7fe4364)
>>     at /net/10.159.161.234/Users/cthaling/ws/8008772/src/share/vm/prims/jni.cpp:5062
>> 5062	  jint result = JNI_ERR;
>> Missing separate debuginfos, use: debuginfo-install glibc-2.12-1.7.el6.i686
>> (gdb) break CompileBroker::compile_method
>> Breakpoint 2 at 0xaef852: file /net/10.159.161.234/Users/cthaling/ws/8008772/src/share/vm/compiler/compileBroker.cpp, line 1205.
>> (gdb) c
>> Continuing.
>> [New Thread 0xf7f93b70 (LWP 13460)]
>> [New Thread 0xb4398b70 (LWP 13461)]
>> [New Thread 0xb41ffb70 (LWP 13462)]
>> [New Thread 0xb3effb70 (LWP 13463)]
>> [New Thread 0xb3cffb70 (LWP 13464)]
>> [New Thread 0xb3affb70 (LWP 13465)]
>> [New Thread 0xb38ffb70 (LWP 13466)]
>> [New Thread 0xb36ffb70 (LWP 13467)]
>> [New Thread 0xb34ffb70 (LWP 13468)]
>> [New Thread 0xb32ffb70 (LWP 13469)]
>> [New Thread 0xb30ffb70 (LWP 13470)]
>> [New Thread 0xb2effb70 (LWP 13471)]
>> [New Thread 0xb2cffb70 (LWP 13472)]
>> [New Thread 0xaf8e8b70 (LWP 13473)]
>> [New Thread 0xb4156b70 (LWP 13474)]
>> [New Thread 0xb3c7eb70 (LWP 13475)]
>> [New Thread 0xb3a7eb70 (LWP 13476)]
>> [New Thread 0xaeeffb70 (LWP 13477)]
>> [New Thread 0xaecffb70 (LWP 13478)]
>> [New Thread 0xb387eb70 (LWP 13479)]
>> [New Thread 0xaeaffb70 (LWP 13480)]
>> java version "1.8.0-ea"
>> Java(TM) SE Runtime Environment (build 1.8.0-ea-b86)
>> Java HotSpot(TM) Server VM (build 25.0-b29-internal-debug, mixed mode)
>> [Thread 0xaeaffb70 (LWP 13480) exited]
>> [Thread 0xb3a7eb70 (LWP 13476) exited]
>> [Thread 0xaf8e8b70 (LWP 13473) exited]
>> [Thread 0xf7fe4b70 (LWP 13459) exited]
>> [Thread 0xb2cffb70 (LWP 13472) exited]
>> [Thread 0xb2effb70 (LWP 13471) exited]
>> [Thread 0xaecffb70 (LWP 13478) exited]
>> [Thread 0xb387eb70 (LWP 13479) exited]
>> [Thread 0xaeeffb70 (LWP 13477) exited]
>> [Thread 0xb3c7eb70 (LWP 13475) exited]
>> [Thread 0xb4156b70 (LWP 13474) exited]
>> [Thread 0xb32ffb70 (LWP 13469) exited]
>> [Thread 0xb34ffb70 (LWP 13468) exited]
>> [Thread 0xb36ffb70 (LWP 13467) exited]
>> [Thread 0xb38ffb70 (LWP 13466) exited]
>> [Thread 0xb3affb70 (LWP 13465) exited]
>> [Thread 0xb3cffb70 (LWP 13464) exited]
>> [Thread 0xb3effb70 (LWP 13463) exited]
>> [Thread 0xb41ffb70 (LWP 13462) exited]
>> [Thread 0xb4398b70 (LWP 13461) exited]
>> [Thread 0xf7f93b70 (LWP 13460) exited]
>> [Thread 0xb30ffb70 (LWP 13470) exited]
>> 
>> Program exited normally.
>> (gdb)
>> 
>> 
>> cthaling at intelsdv01:/export/twisti/build/8008772/build/solaris_i486_compiler2/debug$ /bin/bash ./hotspot -dbx -version
>> dbx: warning: using the alternate init file: /home/cthaling/.dbxrc
>> Reading java
>> Reading ld.so.1
>> Reading libjli.so
>> Reading libthread.so.1
>> Reading libdl.so.1
>> Reading libc.so.1
>> Reading libjvm.so
>> Loaded loadobject: /export/twisti/build/8008772/build/solaris_i486_compiler2/debug/libjvm.so
>> Running: java -Dsun.java.launcher=gamma -XXaltjvm=/export/twisti/build/8008772/build/solaris_i486_compiler2/debug -version
>> (process id 29613)
>> Reading libsocket.so.1
>> Reading libsched.so.1
>> Reading libm.so.1
>> Reading libCrun.so.1
>> Reading libdoor.so.1
>> Reading libdemangle.so.1
>> Reading libnsl.so.1
>> Reading libm.so.2
>> Reading libscf.so.1
>> Reading libuutil.so.1
>> Reading libgen.so.1
>> Reading libmd.so.1
>> Reading libmp.so.2
>> t at 2 (l at 2) stopped in JNI_CreateJavaVM at line 5062 in file "jni.cpp"
>>  5062     jint result = JNI_ERR;
>> (dbx) stop in CompileBroker::compile_method
>> (2) stop in CompileBroker::compile_method(methodHandle,int,int,methodHandle,int,const char*,Thread*)
>> (dbx) c
>> Reading libverify.so
>> Reading libjava.so
>> Reading libzip.so
>> java version "1.8.0-ea"
>> Java(TM) SE Runtime Environment (build 1.8.0-ea-b86)
>> Java HotSpot(TM) Server VM (build 25.0-b29-internal-debug, mixed mode)
>> 
>> execution completed, exit code is 0
>> (dbx)
>> 
> 


From dmitry.samersoff at oracle.com  Mon Apr 22 14:41:54 2013
From: dmitry.samersoff at oracle.com (Dmitry Samersoff)
Date: Tue, 23 Apr 2013 01:41:54 +0400
Subject: RR(S): 8009062 poor performance of JNI AttachCurrentThread after
	fix for 7017193
In-Reply-To: <515493D5.7090308@redhat.com>
References: <512CF7D5.2030300@redhat.com> <512D2B73.4060103@oracle.com>
	
	<5130D0AB.8000001@oracle.com> <513780C0.9050103@redhat.com>
	<513E1210.4030406@oracle.com> <515493D5.7090308@redhat.com>
Message-ID: <5175AEA2.2050408@oracle.com>

Hi Everybody,

Here is webrev of proposed changes:

http://cr.openjdk.java.net/~dsamersoff/8009062/webrev.04/

Any comments is much appreciated.

The problem:

Under Linux stack of main thread is growable, so we have to make sure
that address we plan to put a guard pages to and below is not mapped.

Historically we find bounds of the stack of main thread by seeking
/proc/self/maps for "[stack]" and parsing this line.

I don't like buffered reading of /proc files and sometimes ago rewrite
this function to read it byte-to-byte. Unfortunately, resulting
performance penalties is not acceptable.


Solution:

Below is slightly different approach - I use mincore(2) to check whether
the page is mapped or not. Typically mincore(2) is used to check whether
the page is resides in physical memory or not, but this function returns
-1 and set errno to ENOMEM if a region we are asking about contains not
mapped memory.

Testing:

Passed jprt and couple of jtreg tests. No special regression test
necessary as the test for 6929067 covers this case as well.

-Dmitry



On 2013-03-28 23:02, Adam Domurad wrote:
> On 03/11/2013 01:19 PM, Dmitry Samersoff wrote:
>> Adam,
>>
>> Sorry! I can't provide any estimations right now. But it's a high
>> priority issue in my queue, and I plan to provide a fix as soon as it
>> become possible.
>>
>> -Dmitry
>>
>> On 2013-03-06 21:45, Adam Domurad wrote:
>>> On 03/01/2013 11:00 AM, Dmitry Samersoff wrote:
>>>> Adam,
>>>>
>>>> Thank you for advice! I'm looking for a possibility to remove
>>>> get_stack_bounds function entirely as Dean suggested. But it takes some
>>>> time.
>>> Hi again, not to be a bother, but do you have a rough time-frame that
>>> the fix will take?
>>>
>>> Thanks,
>>> -Adam
>>
> 
> As per our off-list chat, I have attached my implementation of a revised
> implementation of get_stack_bounds with a small test-case. As far as
> performance is concerned, it's an order of magnitude faster from my
> timings. This should be suitable given that no problems were reported
> with the old implementation.
> 
> Happy hacking,
> -Adam


-- 
Dmitry Samersoff
Oracle Java development team, Saint Petersburg, Russia
* Give Rabbit time, and he'll always get the answer

From nils.eliasson at oracle.com  Tue Apr 23 02:09:50 2013
From: nils.eliasson at oracle.com (Nils Eliasson)
Date: Tue, 23 Apr 2013 11:09:50 +0200
Subject: RFR (M): 8008772: remove gamma launcher
In-Reply-To: <764DA08E-5A58-4FD4-BB48-0F4F13401BCC@oracle.com>
References: <5C64AF5E-EDD5-4669-9777-5FF7CE6E615F@oracle.com>
	<51759F6B.7080808@oracle.com>
	<764DA08E-5A58-4FD4-BB48-0F4F13401BCC@oracle.com>
Message-ID: <51764FDE.2090205@oracle.com>

The gamma launcher is used to run and debug hotspot from Visual Studio. 
So removing gamma effectively kills the working environment for a number 
of people that use it daily.  So I am strongly against removing it.

Most people working on Windows use Cygwin as the last resort since it 
makes a lot of thing excruciatingly slow.

//Nils

On 2013-04-22 22:55, Christian Thalinger wrote:
> On Apr 22, 2013, at 1:36 PM, Daniel D. Daugherty  wrote:
>
>> Chris,
>>
>> Just an observation and not a review.
>>
>> Looks like you're removing launcher support on Windows, but it
>> looks like the new hotspot.script doesn't support Windows...
>> Am I missing something?
> Almost certainly true.  Since I'm not a Windows user (and nobody near me is one) I have no idea how people are using the gamma launcher on Windows (or the hotspot script for that matter).
>
> I presume most people doing debugging on the command line are already in cygwin?  But I might be wrong.
>
> -- Chris
>
>> Dan
>>
>>
>> On 4/22/13 1:47 PM, Christian Thalinger wrote:
>>> http://cr.openjdk.java.net/~twisti/8008772/
>>>
>>> 8008772: remove gamma launcher
>>> Reviewed-by:
>>>
>>> Remove linking the gamma launcher and it's associated source files.
>>>
>>> make/Makefile
>>> make/bsd/makefiles/launcher.make
>>> make/bsd/makefiles/vm.make
>>> make/hotspot.script
>>> make/linux/makefiles/launcher.make
>>> make/linux/makefiles/vm.make
>>> make/solaris/makefiles/launcher.make
>>> make/solaris/makefiles/vm.make
>>> make/windows/makefiles/debug.make
>>> make/windows/makefiles/fastdebug.make
>>> make/windows/makefiles/launcher.make
>>> make/windows/makefiles/product.make
>>> make/windows/makefiles/projectcreator.make
>>> make/windows/projectfiles/common/Makefile
>>> src/os/posix/launcher/java_md.c
>>> src/os/posix/launcher/java_md.h
>>> src/os/posix/launcher/launcher.script
>>> src/os/windows/launcher/java_md.c
>>> src/os/windows/launcher/java_md.h
>>> src/share/tools/launcher/java.c
>>> src/share/tools/launcher/java.h
>>> src/share/tools/launcher/jli_util.c
>>> src/share/tools/launcher/jli_util.h
>>> src/share/tools/launcher/wildcard.c
>>> src/share/tools/launcher/wildcard.h
>>>
>>> This change removes the duplicated java launcher files (which were subject to bit-rot) and modifies the hotspot script to pick up the libjvm in the current build directory.
>>>
>>> The modified hotspot script works with GDB and DBX:
>>>
>>> cthaling at intelsdv03.us.oracle.com:/export/twisti/build/8008772/build/linux_i486_compiler2/debug$ ./hotspot -gdb -version
>>> GNU gdb (GDB) Red Hat Enterprise Linux (7.1-29.el6)
>>> Copyright (C) 2010 Free Software Foundation, Inc.
>>> License GPLv3+: GNU GPL version 3 or later 
>>> This is free software: you are free to change and redistribute it.
>>> There is NO WARRANTY, to the extent permitted by law.  Type "show copying"
>>> and "show warranty" for details.
>>> This GDB was configured as "x86_64-redhat-linux-gnu".
>>> For bug reporting instructions, please see:
>>> .
>>> Missing separate debuginfo for /net/scanas404.us.oracle.com/export/java-re/jdk/8/ea/b86/binaries/linux-i586/bin/java
>>> Try: yum --disablerepo='*' --enablerepo='*-debuginfo' install /usr/lib/debug/.build-id/5e/85e6dced3b388a7b0e50630242f4c7ee5e31a3.debug
>>> Function "JNI_CreateJavaVM" not defined.
>>> Breakpoint 1 (JNI_CreateJavaVM) pending.
>>> [Thread debugging using libthread_db enabled]
>>> [New Thread 0xf7fe4b70 (LWP 13459)]
>>> [Switching to Thread 0xf7fe4b70 (LWP 13459)]
>>>
>>> Breakpoint 1, JNI_CreateJavaVM (vm=0xf7fe4378, penv=0xf7fe4374, args=0xf7fe4364)
>>>      at /net/10.159.161.234/Users/cthaling/ws/8008772/src/share/vm/prims/jni.cpp:5062
>>> 5062	  jint result = JNI_ERR;
>>> Missing separate debuginfos, use: debuginfo-install glibc-2.12-1.7.el6.i686
>>> (gdb) break CompileBroker::compile_method
>>> Breakpoint 2 at 0xaef852: file /net/10.159.161.234/Users/cthaling/ws/8008772/src/share/vm/compiler/compileBroker.cpp, line 1205.
>>> (gdb) c
>>> Continuing.
>>> [New Thread 0xf7f93b70 (LWP 13460)]
>>> [New Thread 0xb4398b70 (LWP 13461)]
>>> [New Thread 0xb41ffb70 (LWP 13462)]
>>> [New Thread 0xb3effb70 (LWP 13463)]
>>> [New Thread 0xb3cffb70 (LWP 13464)]
>>> [New Thread 0xb3affb70 (LWP 13465)]
>>> [New Thread 0xb38ffb70 (LWP 13466)]
>>> [New Thread 0xb36ffb70 (LWP 13467)]
>>> [New Thread 0xb34ffb70 (LWP 13468)]
>>> [New Thread 0xb32ffb70 (LWP 13469)]
>>> [New Thread 0xb30ffb70 (LWP 13470)]
>>> [New Thread 0xb2effb70 (LWP 13471)]
>>> [New Thread 0xb2cffb70 (LWP 13472)]
>>> [New Thread 0xaf8e8b70 (LWP 13473)]
>>> [New Thread 0xb4156b70 (LWP 13474)]
>>> [New Thread 0xb3c7eb70 (LWP 13475)]
>>> [New Thread 0xb3a7eb70 (LWP 13476)]
>>> [New Thread 0xaeeffb70 (LWP 13477)]
>>> [New Thread 0xaecffb70 (LWP 13478)]
>>> [New Thread 0xb387eb70 (LWP 13479)]
>>> [New Thread 0xaeaffb70 (LWP 13480)]
>>> java version "1.8.0-ea"
>>> Java(TM) SE Runtime Environment (build 1.8.0-ea-b86)
>>> Java HotSpot(TM) Server VM (build 25.0-b29-internal-debug, mixed mode)
>>> [Thread 0xaeaffb70 (LWP 13480) exited]
>>> [Thread 0xb3a7eb70 (LWP 13476) exited]
>>> [Thread 0xaf8e8b70 (LWP 13473) exited]
>>> [Thread 0xf7fe4b70 (LWP 13459) exited]
>>> [Thread 0xb2cffb70 (LWP 13472) exited]
>>> [Thread 0xb2effb70 (LWP 13471) exited]
>>> [Thread 0xaecffb70 (LWP 13478) exited]
>>> [Thread 0xb387eb70 (LWP 13479) exited]
>>> [Thread 0xaeeffb70 (LWP 13477) exited]
>>> [Thread 0xb3c7eb70 (LWP 13475) exited]
>>> [Thread 0xb4156b70 (LWP 13474) exited]
>>> [Thread 0xb32ffb70 (LWP 13469) exited]
>>> [Thread 0xb34ffb70 (LWP 13468) exited]
>>> [Thread 0xb36ffb70 (LWP 13467) exited]
>>> [Thread 0xb38ffb70 (LWP 13466) exited]
>>> [Thread 0xb3affb70 (LWP 13465) exited]
>>> [Thread 0xb3cffb70 (LWP 13464) exited]
>>> [Thread 0xb3effb70 (LWP 13463) exited]
>>> [Thread 0xb41ffb70 (LWP 13462) exited]
>>> [Thread 0xb4398b70 (LWP 13461) exited]
>>> [Thread 0xf7f93b70 (LWP 13460) exited]
>>> [Thread 0xb30ffb70 (LWP 13470) exited]
>>>
>>> Program exited normally.
>>> (gdb)
>>>
>>>
>>> cthaling at intelsdv01:/export/twisti/build/8008772/build/solaris_i486_compiler2/debug$ /bin/bash ./hotspot -dbx -version
>>> dbx: warning: using the alternate init file: /home/cthaling/.dbxrc
>>> Reading java
>>> Reading ld.so.1
>>> Reading libjli.so
>>> Reading libthread.so.1
>>> Reading libdl.so.1
>>> Reading libc.so.1
>>> Reading libjvm.so
>>> Loaded loadobject: /export/twisti/build/8008772/build/solaris_i486_compiler2/debug/libjvm.so
>>> Running: java -Dsun.java.launcher=gamma -XXaltjvm=/export/twisti/build/8008772/build/solaris_i486_compiler2/debug -version
>>> (process id 29613)
>>> Reading libsocket.so.1
>>> Reading libsched.so.1
>>> Reading libm.so.1
>>> Reading libCrun.so.1
>>> Reading libdoor.so.1
>>> Reading libdemangle.so.1
>>> Reading libnsl.so.1
>>> Reading libm.so.2
>>> Reading libscf.so.1
>>> Reading libuutil.so.1
>>> Reading libgen.so.1
>>> Reading libmd.so.1
>>> Reading libmp.so.2
>>> t at 2 (l at 2) stopped in JNI_CreateJavaVM at line 5062 in file "jni.cpp"
>>>   5062     jint result = JNI_ERR;
>>> (dbx) stop in CompileBroker::compile_method
>>> (2) stop in CompileBroker::compile_method(methodHandle,int,int,methodHandle,int,const char*,Thread*)
>>> (dbx) c
>>> Reading libverify.so
>>> Reading libjava.so
>>> Reading libzip.so
>>> java version "1.8.0-ea"
>>> Java(TM) SE Runtime Environment (build 1.8.0-ea-b86)
>>> Java HotSpot(TM) Server VM (build 25.0-b29-internal-debug, mixed mode)
>>>
>>> execution completed, exit code is 0
>>> (dbx)
>>>


From mikael.gerdin at oracle.com  Tue Apr 23 03:59:50 2013
From: mikael.gerdin at oracle.com (Mikael Gerdin)
Date: Tue, 23 Apr 2013 12:59:50 +0200
Subject: RFR (M): 8008772: remove gamma launcher
In-Reply-To: <51764FDE.2090205@oracle.com>
References: <5C64AF5E-EDD5-4669-9777-5FF7CE6E615F@oracle.com>
	<51759F6B.7080808@oracle.com>
	<764DA08E-5A58-4FD4-BB48-0F4F13401BCC@oracle.com>
	<51764FDE.2090205@oracle.com>
Message-ID: <517669A6.8030705@oracle.com>



On 2013-04-23 11:09, Nils Eliasson wrote:
> The gamma launcher is used to run and debug hotspot from Visual Studio.
> So removing gamma effectively kills the working environment for a number
> of people that use it daily.  So I am strongly against removing it.

Maybe the visual studio project generator could be updated to create a a 
"launch configuration" for launching java.exe from a JDK and use the 
XXaltJVM flag on to select the correct jvm.dll?

I agree that we shouldn't break the visual studio project but currently 
there's nothing indicating that we can't fix it.


/Mikael

>
> Most people working on Windows use Cygwin as the last resort since it
> makes a lot of thing excruciatingly slow.
>
> //Nils
>
> On 2013-04-22 22:55, Christian Thalinger wrote:
>> On Apr 22, 2013, at 1:36 PM, Daniel D. Daugherty
>>  wrote:
>>
>>> Chris,
>>>
>>> Just an observation and not a review.
>>>
>>> Looks like you're removing launcher support on Windows, but it
>>> looks like the new hotspot.script doesn't support Windows...
>>> Am I missing something?
>> Almost certainly true.  Since I'm not a Windows user (and nobody near
>> me is one) I have no idea how people are using the gamma launcher on
>> Windows (or the hotspot script for that matter).
>>
>> I presume most people doing debugging on the command line are already
>> in cygwin?  But I might be wrong.
>>
>> -- Chris
>>
>>> Dan
>>>
>>>
>>> On 4/22/13 1:47 PM, Christian Thalinger wrote:
>>>> http://cr.openjdk.java.net/~twisti/8008772/
>>>>
>>>> 8008772: remove gamma launcher
>>>> Reviewed-by:
>>>>
>>>> Remove linking the gamma launcher and it's associated source files.
>>>>
>>>> make/Makefile
>>>> make/bsd/makefiles/launcher.make
>>>> make/bsd/makefiles/vm.make
>>>> make/hotspot.script
>>>> make/linux/makefiles/launcher.make
>>>> make/linux/makefiles/vm.make
>>>> make/solaris/makefiles/launcher.make
>>>> make/solaris/makefiles/vm.make
>>>> make/windows/makefiles/debug.make
>>>> make/windows/makefiles/fastdebug.make
>>>> make/windows/makefiles/launcher.make
>>>> make/windows/makefiles/product.make
>>>> make/windows/makefiles/projectcreator.make
>>>> make/windows/projectfiles/common/Makefile
>>>> src/os/posix/launcher/java_md.c
>>>> src/os/posix/launcher/java_md.h
>>>> src/os/posix/launcher/launcher.script
>>>> src/os/windows/launcher/java_md.c
>>>> src/os/windows/launcher/java_md.h
>>>> src/share/tools/launcher/java.c
>>>> src/share/tools/launcher/java.h
>>>> src/share/tools/launcher/jli_util.c
>>>> src/share/tools/launcher/jli_util.h
>>>> src/share/tools/launcher/wildcard.c
>>>> src/share/tools/launcher/wildcard.h
>>>>
>>>> This change removes the duplicated java launcher files (which were
>>>> subject to bit-rot) and modifies the hotspot script to pick up the
>>>> libjvm in the current build directory.
>>>>
>>>> The modified hotspot script works with GDB and DBX:
>>>>
>>>> cthaling at intelsdv03.us.oracle.com:/export/twisti/build/8008772/build/linux_i486_compiler2/debug$
>>>> ./hotspot -gdb -version
>>>> GNU gdb (GDB) Red Hat Enterprise Linux (7.1-29.el6)
>>>> Copyright (C) 2010 Free Software Foundation, Inc.
>>>> License GPLv3+: GNU GPL version 3 or later
>>>> 
>>>> This is free software: you are free to change and redistribute it.
>>>> There is NO WARRANTY, to the extent permitted by law.  Type "show
>>>> copying"
>>>> and "show warranty" for details.
>>>> This GDB was configured as "x86_64-redhat-linux-gnu".
>>>> For bug reporting instructions, please see:
>>>> .
>>>> Missing separate debuginfo for
>>>> /net/scanas404.us.oracle.com/export/java-re/jdk/8/ea/b86/binaries/linux-i586/bin/java
>>>>
>>>> Try: yum --disablerepo='*' --enablerepo='*-debuginfo' install
>>>> /usr/lib/debug/.build-id/5e/85e6dced3b388a7b0e50630242f4c7ee5e31a3.debug
>>>>
>>>> Function "JNI_CreateJavaVM" not defined.
>>>> Breakpoint 1 (JNI_CreateJavaVM) pending.
>>>> [Thread debugging using libthread_db enabled]
>>>> [New Thread 0xf7fe4b70 (LWP 13459)]
>>>> [Switching to Thread 0xf7fe4b70 (LWP 13459)]
>>>>
>>>> Breakpoint 1, JNI_CreateJavaVM (vm=0xf7fe4378, penv=0xf7fe4374,
>>>> args=0xf7fe4364)
>>>>      at
>>>> /net/10.159.161.234/Users/cthaling/ws/8008772/src/share/vm/prims/jni.cpp:5062
>>>>
>>>> 5062      jint result = JNI_ERR;
>>>> Missing separate debuginfos, use: debuginfo-install
>>>> glibc-2.12-1.7.el6.i686
>>>> (gdb) break CompileBroker::compile_method
>>>> Breakpoint 2 at 0xaef852: file
>>>> /net/10.159.161.234/Users/cthaling/ws/8008772/src/share/vm/compiler/compileBroker.cpp,
>>>> line 1205.
>>>> (gdb) c
>>>> Continuing.
>>>> [New Thread 0xf7f93b70 (LWP 13460)]
>>>> [New Thread 0xb4398b70 (LWP 13461)]
>>>> [New Thread 0xb41ffb70 (LWP 13462)]
>>>> [New Thread 0xb3effb70 (LWP 13463)]
>>>> [New Thread 0xb3cffb70 (LWP 13464)]
>>>> [New Thread 0xb3affb70 (LWP 13465)]
>>>> [New Thread 0xb38ffb70 (LWP 13466)]
>>>> [New Thread 0xb36ffb70 (LWP 13467)]
>>>> [New Thread 0xb34ffb70 (LWP 13468)]
>>>> [New Thread 0xb32ffb70 (LWP 13469)]
>>>> [New Thread 0xb30ffb70 (LWP 13470)]
>>>> [New Thread 0xb2effb70 (LWP 13471)]
>>>> [New Thread 0xb2cffb70 (LWP 13472)]
>>>> [New Thread 0xaf8e8b70 (LWP 13473)]
>>>> [New Thread 0xb4156b70 (LWP 13474)]
>>>> [New Thread 0xb3c7eb70 (LWP 13475)]
>>>> [New Thread 0xb3a7eb70 (LWP 13476)]
>>>> [New Thread 0xaeeffb70 (LWP 13477)]
>>>> [New Thread 0xaecffb70 (LWP 13478)]
>>>> [New Thread 0xb387eb70 (LWP 13479)]
>>>> [New Thread 0xaeaffb70 (LWP 13480)]
>>>> java version "1.8.0-ea"
>>>> Java(TM) SE Runtime Environment (build 1.8.0-ea-b86)
>>>> Java HotSpot(TM) Server VM (build 25.0-b29-internal-debug, mixed mode)
>>>> [Thread 0xaeaffb70 (LWP 13480) exited]
>>>> [Thread 0xb3a7eb70 (LWP 13476) exited]
>>>> [Thread 0xaf8e8b70 (LWP 13473) exited]
>>>> [Thread 0xf7fe4b70 (LWP 13459) exited]
>>>> [Thread 0xb2cffb70 (LWP 13472) exited]
>>>> [Thread 0xb2effb70 (LWP 13471) exited]
>>>> [Thread 0xaecffb70 (LWP 13478) exited]
>>>> [Thread 0xb387eb70 (LWP 13479) exited]
>>>> [Thread 0xaeeffb70 (LWP 13477) exited]
>>>> [Thread 0xb3c7eb70 (LWP 13475) exited]
>>>> [Thread 0xb4156b70 (LWP 13474) exited]
>>>> [Thread 0xb32ffb70 (LWP 13469) exited]
>>>> [Thread 0xb34ffb70 (LWP 13468) exited]
>>>> [Thread 0xb36ffb70 (LWP 13467) exited]
>>>> [Thread 0xb38ffb70 (LWP 13466) exited]
>>>> [Thread 0xb3affb70 (LWP 13465) exited]
>>>> [Thread 0xb3cffb70 (LWP 13464) exited]
>>>> [Thread 0xb3effb70 (LWP 13463) exited]
>>>> [Thread 0xb41ffb70 (LWP 13462) exited]
>>>> [Thread 0xb4398b70 (LWP 13461) exited]
>>>> [Thread 0xf7f93b70 (LWP 13460) exited]
>>>> [Thread 0xb30ffb70 (LWP 13470) exited]
>>>>
>>>> Program exited normally.
>>>> (gdb)
>>>>
>>>>
>>>> cthaling at intelsdv01:/export/twisti/build/8008772/build/solaris_i486_compiler2/debug$
>>>> /bin/bash ./hotspot -dbx -version
>>>> dbx: warning: using the alternate init file: /home/cthaling/.dbxrc
>>>> Reading java
>>>> Reading ld.so.1
>>>> Reading libjli.so
>>>> Reading libthread.so.1
>>>> Reading libdl.so.1
>>>> Reading libc.so.1
>>>> Reading libjvm.so
>>>> Loaded loadobject:
>>>> /export/twisti/build/8008772/build/solaris_i486_compiler2/debug/libjvm.so
>>>>
>>>> Running: java -Dsun.java.launcher=gamma
>>>> -XXaltjvm=/export/twisti/build/8008772/build/solaris_i486_compiler2/debug
>>>> -version
>>>> (process id 29613)
>>>> Reading libsocket.so.1
>>>> Reading libsched.so.1
>>>> Reading libm.so.1
>>>> Reading libCrun.so.1
>>>> Reading libdoor.so.1
>>>> Reading libdemangle.so.1
>>>> Reading libnsl.so.1
>>>> Reading libm.so.2
>>>> Reading libscf.so.1
>>>> Reading libuutil.so.1
>>>> Reading libgen.so.1
>>>> Reading libmd.so.1
>>>> Reading libmp.so.2
>>>> t at 2 (l at 2) stopped in JNI_CreateJavaVM at line 5062 in file "jni.cpp"
>>>>   5062     jint result = JNI_ERR;
>>>> (dbx) stop in CompileBroker::compile_method
>>>> (2) stop in
>>>> CompileBroker::compile_method(methodHandle,int,int,methodHandle,int,const
>>>> char*,Thread*)
>>>> (dbx) c
>>>> Reading libverify.so
>>>> Reading libjava.so
>>>> Reading libzip.so
>>>> java version "1.8.0-ea"
>>>> Java(TM) SE Runtime Environment (build 1.8.0-ea-b86)
>>>> Java HotSpot(TM) Server VM (build 25.0-b29-internal-debug, mixed mode)
>>>>
>>>> execution completed, exit code is 0
>>>> (dbx)
>>>>
>

From rickard.backman at oracle.com  Tue Apr 23 04:27:52 2013
From: rickard.backman at oracle.com (rickard.backman at oracle.com)
Date: Tue, 23 Apr 2013 11:27:52 +0000
Subject: hg: hsx/hsx24/hotspot: 8011882: Replace spin loops as back off when
	suspending
Message-ID: <20130423112802.4750B48511@hg.openjdk.java.net>

Changeset: d0459a316814
Author:    rbackman
Date:      2013-04-10 09:58 +0200
URL:       http://hg.openjdk.java.net/hsx/hsx24/hotspot/rev/d0459a316814

8011882: Replace spin loops as back off when suspending
Reviewed-by: dholmes, sla

! src/os/bsd/vm/os_bsd.cpp
! src/os/bsd/vm/os_bsd.hpp
! src/os/linux/vm/os_linux.cpp
! src/os/linux/vm/os_linux.hpp
! src/os/solaris/vm/osThread_solaris.cpp
! src/os/solaris/vm/os_solaris.cpp
! src/os/solaris/vm/os_solaris.hpp


From jesper.wilhelmsson at oracle.com  Tue Apr 23 10:35:25 2013
From: jesper.wilhelmsson at oracle.com (jesper.wilhelmsson at oracle.com)
Date: Tue, 23 Apr 2013 17:35:25 +0000
Subject: hg: hsx/hsx24/hotspot: 8010090: GC ID has the wrong type
Message-ID: <20130423173530.5B25548529@hg.openjdk.java.net>

Changeset: 25e2d699bc5a
Author:    jwilhelm
Date:      2013-04-23 16:58 +0200
URL:       http://hg.openjdk.java.net/hsx/hsx24/hotspot/rev/25e2d699bc5a

8010090: GC ID has the wrong type
Summary: Change the GC ID from ULONG to UINT. Also reviewed by yunda.mly at taobao.com
Reviewed-by: neliasso, stefank

! src/share/vm/trace/trace.xml


From nils.eliasson at oracle.com  Tue Apr 23 11:06:06 2013
From: nils.eliasson at oracle.com (Nils Eliasson)
Date: Tue, 23 Apr 2013 20:06:06 +0200
Subject: RFR (M): 8008772: remove gamma launcher
In-Reply-To: <517669A6.8030705@oracle.com>
References: <5C64AF5E-EDD5-4669-9777-5FF7CE6E615F@oracle.com>
	<51759F6B.7080808@oracle.com>
	<764DA08E-5A58-4FD4-BB48-0F4F13401BCC@oracle.com>
	<51764FDE.2090205@oracle.com> <517669A6.8030705@oracle.com>
Message-ID: <5176CD8E.5060704@oracle.com>

As long as we fix it first and remove gamma after - I would love to have 
some redundant code removed. I would fix it myself, I just don't think I 
will have the time before I go on parental leave.

//Nils

On 2013-04-23 12:59, Mikael Gerdin wrote:
>
>
> On 2013-04-23 11:09, Nils Eliasson wrote:
>> The gamma launcher is used to run and debug hotspot from Visual Studio.
>> So removing gamma effectively kills the working environment for a number
>> of people that use it daily.  So I am strongly against removing it.
>
> Maybe the visual studio project generator could be updated to create a 
> a "launch configuration" for launching java.exe from a JDK and use the 
> XXaltJVM flag on to select the correct jvm.dll?
>
> I agree that we shouldn't break the visual studio project but 
> currently there's nothing indicating that we can't fix it.
>
>
> /Mikael
>
>>
>> Most people working on Windows use Cygwin as the last resort since it
>> makes a lot of thing excruciatingly slow.
>>
>> //Nils
>>
>> On 2013-04-22 22:55, Christian Thalinger wrote:
>>> On Apr 22, 2013, at 1:36 PM, Daniel D. Daugherty
>>>  wrote:
>>>
>>>> Chris,
>>>>
>>>> Just an observation and not a review.
>>>>
>>>> Looks like you're removing launcher support on Windows, but it
>>>> looks like the new hotspot.script doesn't support Windows...
>>>> Am I missing something?
>>> Almost certainly true.  Since I'm not a Windows user (and nobody near
>>> me is one) I have no idea how people are using the gamma launcher on
>>> Windows (or the hotspot script for that matter).
>>>
>>> I presume most people doing debugging on the command line are already
>>> in cygwin?  But I might be wrong.
>>>
>>> -- Chris
>>>
>>>> Dan
>>>>
>>>>
>>>> On 4/22/13 1:47 PM, Christian Thalinger wrote:
>>>>> http://cr.openjdk.java.net/~twisti/8008772/
>>>>>
>>>>> 8008772: remove gamma launcher
>>>>> Reviewed-by:
>>>>>
>>>>> Remove linking the gamma launcher and it's associated source files.
>>>>>
>>>>> make/Makefile
>>>>> make/bsd/makefiles/launcher.make
>>>>> make/bsd/makefiles/vm.make
>>>>> make/hotspot.script
>>>>> make/linux/makefiles/launcher.make
>>>>> make/linux/makefiles/vm.make
>>>>> make/solaris/makefiles/launcher.make
>>>>> make/solaris/makefiles/vm.make
>>>>> make/windows/makefiles/debug.make
>>>>> make/windows/makefiles/fastdebug.make
>>>>> make/windows/makefiles/launcher.make
>>>>> make/windows/makefiles/product.make
>>>>> make/windows/makefiles/projectcreator.make
>>>>> make/windows/projectfiles/common/Makefile
>>>>> src/os/posix/launcher/java_md.c
>>>>> src/os/posix/launcher/java_md.h
>>>>> src/os/posix/launcher/launcher.script
>>>>> src/os/windows/launcher/java_md.c
>>>>> src/os/windows/launcher/java_md.h
>>>>> src/share/tools/launcher/java.c
>>>>> src/share/tools/launcher/java.h
>>>>> src/share/tools/launcher/jli_util.c
>>>>> src/share/tools/launcher/jli_util.h
>>>>> src/share/tools/launcher/wildcard.c
>>>>> src/share/tools/launcher/wildcard.h
>>>>>
>>>>> This change removes the duplicated java launcher files (which were
>>>>> subject to bit-rot) and modifies the hotspot script to pick up the
>>>>> libjvm in the current build directory.
>>>>>
>>>>> The modified hotspot script works with GDB and DBX:
>>>>>
>>>>> cthaling at intelsdv03.us.oracle.com:/export/twisti/build/8008772/build/linux_i486_compiler2/debug$ 
>>>>>
>>>>> ./hotspot -gdb -version
>>>>> GNU gdb (GDB) Red Hat Enterprise Linux (7.1-29.el6)
>>>>> Copyright (C) 2010 Free Software Foundation, Inc.
>>>>> License GPLv3+: GNU GPL version 3 or later
>>>>> 
>>>>> This is free software: you are free to change and redistribute it.
>>>>> There is NO WARRANTY, to the extent permitted by law. Type "show
>>>>> copying"
>>>>> and "show warranty" for details.
>>>>> This GDB was configured as "x86_64-redhat-linux-gnu".
>>>>> For bug reporting instructions, please see:
>>>>> .
>>>>> Missing separate debuginfo for
>>>>> /net/scanas404.us.oracle.com/export/java-re/jdk/8/ea/b86/binaries/linux-i586/bin/java 
>>>>>
>>>>>
>>>>> Try: yum --disablerepo='*' --enablerepo='*-debuginfo' install
>>>>> /usr/lib/debug/.build-id/5e/85e6dced3b388a7b0e50630242f4c7ee5e31a3.debug 
>>>>>
>>>>>
>>>>> Function "JNI_CreateJavaVM" not defined.
>>>>> Breakpoint 1 (JNI_CreateJavaVM) pending.
>>>>> [Thread debugging using libthread_db enabled]
>>>>> [New Thread 0xf7fe4b70 (LWP 13459)]
>>>>> [Switching to Thread 0xf7fe4b70 (LWP 13459)]
>>>>>
>>>>> Breakpoint 1, JNI_CreateJavaVM (vm=0xf7fe4378, penv=0xf7fe4374,
>>>>> args=0xf7fe4364)
>>>>>      at
>>>>> /net/10.159.161.234/Users/cthaling/ws/8008772/src/share/vm/prims/jni.cpp:5062 
>>>>>
>>>>>
>>>>> 5062      jint result = JNI_ERR;
>>>>> Missing separate debuginfos, use: debuginfo-install
>>>>> glibc-2.12-1.7.el6.i686
>>>>> (gdb) break CompileBroker::compile_method
>>>>> Breakpoint 2 at 0xaef852: file
>>>>> /net/10.159.161.234/Users/cthaling/ws/8008772/src/share/vm/compiler/compileBroker.cpp, 
>>>>>
>>>>> line 1205.
>>>>> (gdb) c
>>>>> Continuing.
>>>>> [New Thread 0xf7f93b70 (LWP 13460)]
>>>>> [New Thread 0xb4398b70 (LWP 13461)]
>>>>> [New Thread 0xb41ffb70 (LWP 13462)]
>>>>> [New Thread 0xb3effb70 (LWP 13463)]
>>>>> [New Thread 0xb3cffb70 (LWP 13464)]
>>>>> [New Thread 0xb3affb70 (LWP 13465)]
>>>>> [New Thread 0xb38ffb70 (LWP 13466)]
>>>>> [New Thread 0xb36ffb70 (LWP 13467)]
>>>>> [New Thread 0xb34ffb70 (LWP 13468)]
>>>>> [New Thread 0xb32ffb70 (LWP 13469)]
>>>>> [New Thread 0xb30ffb70 (LWP 13470)]
>>>>> [New Thread 0xb2effb70 (LWP 13471)]
>>>>> [New Thread 0xb2cffb70 (LWP 13472)]
>>>>> [New Thread 0xaf8e8b70 (LWP 13473)]
>>>>> [New Thread 0xb4156b70 (LWP 13474)]
>>>>> [New Thread 0xb3c7eb70 (LWP 13475)]
>>>>> [New Thread 0xb3a7eb70 (LWP 13476)]
>>>>> [New Thread 0xaeeffb70 (LWP 13477)]
>>>>> [New Thread 0xaecffb70 (LWP 13478)]
>>>>> [New Thread 0xb387eb70 (LWP 13479)]
>>>>> [New Thread 0xaeaffb70 (LWP 13480)]
>>>>> java version "1.8.0-ea"
>>>>> Java(TM) SE Runtime Environment (build 1.8.0-ea-b86)
>>>>> Java HotSpot(TM) Server VM (build 25.0-b29-internal-debug, mixed 
>>>>> mode)
>>>>> [Thread 0xaeaffb70 (LWP 13480) exited]
>>>>> [Thread 0xb3a7eb70 (LWP 13476) exited]
>>>>> [Thread 0xaf8e8b70 (LWP 13473) exited]
>>>>> [Thread 0xf7fe4b70 (LWP 13459) exited]
>>>>> [Thread 0xb2cffb70 (LWP 13472) exited]
>>>>> [Thread 0xb2effb70 (LWP 13471) exited]
>>>>> [Thread 0xaecffb70 (LWP 13478) exited]
>>>>> [Thread 0xb387eb70 (LWP 13479) exited]
>>>>> [Thread 0xaeeffb70 (LWP 13477) exited]
>>>>> [Thread 0xb3c7eb70 (LWP 13475) exited]
>>>>> [Thread 0xb4156b70 (LWP 13474) exited]
>>>>> [Thread 0xb32ffb70 (LWP 13469) exited]
>>>>> [Thread 0xb34ffb70 (LWP 13468) exited]
>>>>> [Thread 0xb36ffb70 (LWP 13467) exited]
>>>>> [Thread 0xb38ffb70 (LWP 13466) exited]
>>>>> [Thread 0xb3affb70 (LWP 13465) exited]
>>>>> [Thread 0xb3cffb70 (LWP 13464) exited]
>>>>> [Thread 0xb3effb70 (LWP 13463) exited]
>>>>> [Thread 0xb41ffb70 (LWP 13462) exited]
>>>>> [Thread 0xb4398b70 (LWP 13461) exited]
>>>>> [Thread 0xf7f93b70 (LWP 13460) exited]
>>>>> [Thread 0xb30ffb70 (LWP 13470) exited]
>>>>>
>>>>> Program exited normally.
>>>>> (gdb)
>>>>>
>>>>>
>>>>> cthaling at intelsdv01:/export/twisti/build/8008772/build/solaris_i486_compiler2/debug$ 
>>>>>
>>>>> /bin/bash ./hotspot -dbx -version
>>>>> dbx: warning: using the alternate init file: /home/cthaling/.dbxrc
>>>>> Reading java
>>>>> Reading ld.so.1
>>>>> Reading libjli.so
>>>>> Reading libthread.so.1
>>>>> Reading libdl.so.1
>>>>> Reading libc.so.1
>>>>> Reading libjvm.so
>>>>> Loaded loadobject:
>>>>> /export/twisti/build/8008772/build/solaris_i486_compiler2/debug/libjvm.so 
>>>>>
>>>>>
>>>>> Running: java -Dsun.java.launcher=gamma
>>>>> -XXaltjvm=/export/twisti/build/8008772/build/solaris_i486_compiler2/debug 
>>>>>
>>>>> -version
>>>>> (process id 29613)
>>>>> Reading libsocket.so.1
>>>>> Reading libsched.so.1
>>>>> Reading libm.so.1
>>>>> Reading libCrun.so.1
>>>>> Reading libdoor.so.1
>>>>> Reading libdemangle.so.1
>>>>> Reading libnsl.so.1
>>>>> Reading libm.so.2
>>>>> Reading libscf.so.1
>>>>> Reading libuutil.so.1
>>>>> Reading libgen.so.1
>>>>> Reading libmd.so.1
>>>>> Reading libmp.so.2
>>>>> t at 2 (l at 2) stopped in JNI_CreateJavaVM at line 5062 in file "jni.cpp"
>>>>>   5062     jint result = JNI_ERR;
>>>>> (dbx) stop in CompileBroker::compile_method
>>>>> (2) stop in
>>>>> CompileBroker::compile_method(methodHandle,int,int,methodHandle,int,const 
>>>>>
>>>>> char*,Thread*)
>>>>> (dbx) c
>>>>> Reading libverify.so
>>>>> Reading libjava.so
>>>>> Reading libzip.so
>>>>> java version "1.8.0-ea"
>>>>> Java(TM) SE Runtime Environment (build 1.8.0-ea-b86)
>>>>> Java HotSpot(TM) Server VM (build 25.0-b29-internal-debug, mixed 
>>>>> mode)
>>>>>
>>>>> execution completed, exit code is 0
>>>>> (dbx)
>>>>>
>>


From christian.thalinger at oracle.com  Tue Apr 23 11:28:54 2013
From: christian.thalinger at oracle.com (Christian Thalinger)
Date: Tue, 23 Apr 2013 11:28:54 -0700
Subject: RFR (M): 8008772: remove gamma launcher
In-Reply-To: <5176CD8E.5060704@oracle.com>
References: <5C64AF5E-EDD5-4669-9777-5FF7CE6E615F@oracle.com>
	<51759F6B.7080808@oracle.com>
	<764DA08E-5A58-4FD4-BB48-0F4F13401BCC@oracle.com>
	<51764FDE.2090205@oracle.com> <517669A6.8030705@oracle.com>
	<5176CD8E.5060704@oracle.com>
Message-ID: <1897490C-0C9E-4E70-BA70-22C5CB1CDAE3@oracle.com>


On Apr 23, 2013, at 11:06 AM, Nils Eliasson  wrote:

> As long as we fix it first and remove gamma after - I would love to have some redundant code removed. I would fix it myself, I just don't think I will have the time before I go on parental leave.

First, I'm not removing it tomorrow.  I expected a long discussion :-)

What exactly is the problem with Visual Studio?  Why can't you just run the java launcher instead?

-- Chris

> 
> //Nils
> 
> On 2013-04-23 12:59, Mikael Gerdin wrote:
>> 
>> 
>> On 2013-04-23 11:09, Nils Eliasson wrote:
>>> The gamma launcher is used to run and debug hotspot from Visual Studio.
>>> So removing gamma effectively kills the working environment for a number
>>> of people that use it daily.  So I am strongly against removing it.
>> 
>> Maybe the visual studio project generator could be updated to create a a "launch configuration" for launching java.exe from a JDK and use the XXaltJVM flag on to select the correct jvm.dll?
>> 
>> I agree that we shouldn't break the visual studio project but currently there's nothing indicating that we can't fix it.
>> 
>> 
>> /Mikael
>> 
>>> 
>>> Most people working on Windows use Cygwin as the last resort since it
>>> makes a lot of thing excruciatingly slow.
>>> 
>>> //Nils
>>> 
>>> On 2013-04-22 22:55, Christian Thalinger wrote:
>>>> On Apr 22, 2013, at 1:36 PM, Daniel D. Daugherty
>>>>  wrote:
>>>> 
>>>>> Chris,
>>>>> 
>>>>> Just an observation and not a review.
>>>>> 
>>>>> Looks like you're removing launcher support on Windows, but it
>>>>> looks like the new hotspot.script doesn't support Windows...
>>>>> Am I missing something?
>>>> Almost certainly true.  Since I'm not a Windows user (and nobody near
>>>> me is one) I have no idea how people are using the gamma launcher on
>>>> Windows (or the hotspot script for that matter).
>>>> 
>>>> I presume most people doing debugging on the command line are already
>>>> in cygwin?  But I might be wrong.
>>>> 
>>>> -- Chris
>>>> 
>>>>> Dan
>>>>> 
>>>>> 
>>>>> On 4/22/13 1:47 PM, Christian Thalinger wrote:
>>>>>> http://cr.openjdk.java.net/~twisti/8008772/
>>>>>> 
>>>>>> 8008772: remove gamma launcher
>>>>>> Reviewed-by:
>>>>>> 
>>>>>> Remove linking the gamma launcher and it's associated source files.
>>>>>> 
>>>>>> make/Makefile
>>>>>> make/bsd/makefiles/launcher.make
>>>>>> make/bsd/makefiles/vm.make
>>>>>> make/hotspot.script
>>>>>> make/linux/makefiles/launcher.make
>>>>>> make/linux/makefiles/vm.make
>>>>>> make/solaris/makefiles/launcher.make
>>>>>> make/solaris/makefiles/vm.make
>>>>>> make/windows/makefiles/debug.make
>>>>>> make/windows/makefiles/fastdebug.make
>>>>>> make/windows/makefiles/launcher.make
>>>>>> make/windows/makefiles/product.make
>>>>>> make/windows/makefiles/projectcreator.make
>>>>>> make/windows/projectfiles/common/Makefile
>>>>>> src/os/posix/launcher/java_md.c
>>>>>> src/os/posix/launcher/java_md.h
>>>>>> src/os/posix/launcher/launcher.script
>>>>>> src/os/windows/launcher/java_md.c
>>>>>> src/os/windows/launcher/java_md.h
>>>>>> src/share/tools/launcher/java.c
>>>>>> src/share/tools/launcher/java.h
>>>>>> src/share/tools/launcher/jli_util.c
>>>>>> src/share/tools/launcher/jli_util.h
>>>>>> src/share/tools/launcher/wildcard.c
>>>>>> src/share/tools/launcher/wildcard.h
>>>>>> 
>>>>>> This change removes the duplicated java launcher files (which were
>>>>>> subject to bit-rot) and modifies the hotspot script to pick up the
>>>>>> libjvm in the current build directory.
>>>>>> 
>>>>>> The modified hotspot script works with GDB and DBX:
>>>>>> 
>>>>>> cthaling at intelsdv03.us.oracle.com:/export/twisti/build/8008772/build/linux_i486_compiler2/debug$ 
>>>>>> ./hotspot -gdb -version
>>>>>> GNU gdb (GDB) Red Hat Enterprise Linux (7.1-29.el6)
>>>>>> Copyright (C) 2010 Free Software Foundation, Inc.
>>>>>> License GPLv3+: GNU GPL version 3 or later
>>>>>> 
>>>>>> This is free software: you are free to change and redistribute it.
>>>>>> There is NO WARRANTY, to the extent permitted by law. Type "show
>>>>>> copying"
>>>>>> and "show warranty" for details.
>>>>>> This GDB was configured as "x86_64-redhat-linux-gnu".
>>>>>> For bug reporting instructions, please see:
>>>>>> .
>>>>>> Missing separate debuginfo for
>>>>>> /net/scanas404.us.oracle.com/export/java-re/jdk/8/ea/b86/binaries/linux-i586/bin/java 
>>>>>> 
>>>>>> Try: yum --disablerepo='*' --enablerepo='*-debuginfo' install
>>>>>> /usr/lib/debug/.build-id/5e/85e6dced3b388a7b0e50630242f4c7ee5e31a3.debug 
>>>>>> 
>>>>>> Function "JNI_CreateJavaVM" not defined.
>>>>>> Breakpoint 1 (JNI_CreateJavaVM) pending.
>>>>>> [Thread debugging using libthread_db enabled]
>>>>>> [New Thread 0xf7fe4b70 (LWP 13459)]
>>>>>> [Switching to Thread 0xf7fe4b70 (LWP 13459)]
>>>>>> 
>>>>>> Breakpoint 1, JNI_CreateJavaVM (vm=0xf7fe4378, penv=0xf7fe4374,
>>>>>> args=0xf7fe4364)
>>>>>>     at
>>>>>> /net/10.159.161.234/Users/cthaling/ws/8008772/src/share/vm/prims/jni.cpp:5062 
>>>>>> 
>>>>>> 5062      jint result = JNI_ERR;
>>>>>> Missing separate debuginfos, use: debuginfo-install
>>>>>> glibc-2.12-1.7.el6.i686
>>>>>> (gdb) break CompileBroker::compile_method
>>>>>> Breakpoint 2 at 0xaef852: file
>>>>>> /net/10.159.161.234/Users/cthaling/ws/8008772/src/share/vm/compiler/compileBroker.cpp, 
>>>>>> line 1205.
>>>>>> (gdb) c
>>>>>> Continuing.
>>>>>> [New Thread 0xf7f93b70 (LWP 13460)]
>>>>>> [New Thread 0xb4398b70 (LWP 13461)]
>>>>>> [New Thread 0xb41ffb70 (LWP 13462)]
>>>>>> [New Thread 0xb3effb70 (LWP 13463)]
>>>>>> [New Thread 0xb3cffb70 (LWP 13464)]
>>>>>> [New Thread 0xb3affb70 (LWP 13465)]
>>>>>> [New Thread 0xb38ffb70 (LWP 13466)]
>>>>>> [New Thread 0xb36ffb70 (LWP 13467)]
>>>>>> [New Thread 0xb34ffb70 (LWP 13468)]
>>>>>> [New Thread 0xb32ffb70 (LWP 13469)]
>>>>>> [New Thread 0xb30ffb70 (LWP 13470)]
>>>>>> [New Thread 0xb2effb70 (LWP 13471)]
>>>>>> [New Thread 0xb2cffb70 (LWP 13472)]
>>>>>> [New Thread 0xaf8e8b70 (LWP 13473)]
>>>>>> [New Thread 0xb4156b70 (LWP 13474)]
>>>>>> [New Thread 0xb3c7eb70 (LWP 13475)]
>>>>>> [New Thread 0xb3a7eb70 (LWP 13476)]
>>>>>> [New Thread 0xaeeffb70 (LWP 13477)]
>>>>>> [New Thread 0xaecffb70 (LWP 13478)]
>>>>>> [New Thread 0xb387eb70 (LWP 13479)]
>>>>>> [New Thread 0xaeaffb70 (LWP 13480)]
>>>>>> java version "1.8.0-ea"
>>>>>> Java(TM) SE Runtime Environment (build 1.8.0-ea-b86)
>>>>>> Java HotSpot(TM) Server VM (build 25.0-b29-internal-debug, mixed mode)
>>>>>> [Thread 0xaeaffb70 (LWP 13480) exited]
>>>>>> [Thread 0xb3a7eb70 (LWP 13476) exited]
>>>>>> [Thread 0xaf8e8b70 (LWP 13473) exited]
>>>>>> [Thread 0xf7fe4b70 (LWP 13459) exited]
>>>>>> [Thread 0xb2cffb70 (LWP 13472) exited]
>>>>>> [Thread 0xb2effb70 (LWP 13471) exited]
>>>>>> [Thread 0xaecffb70 (LWP 13478) exited]
>>>>>> [Thread 0xb387eb70 (LWP 13479) exited]
>>>>>> [Thread 0xaeeffb70 (LWP 13477) exited]
>>>>>> [Thread 0xb3c7eb70 (LWP 13475) exited]
>>>>>> [Thread 0xb4156b70 (LWP 13474) exited]
>>>>>> [Thread 0xb32ffb70 (LWP 13469) exited]
>>>>>> [Thread 0xb34ffb70 (LWP 13468) exited]
>>>>>> [Thread 0xb36ffb70 (LWP 13467) exited]
>>>>>> [Thread 0xb38ffb70 (LWP 13466) exited]
>>>>>> [Thread 0xb3affb70 (LWP 13465) exited]
>>>>>> [Thread 0xb3cffb70 (LWP 13464) exited]
>>>>>> [Thread 0xb3effb70 (LWP 13463) exited]
>>>>>> [Thread 0xb41ffb70 (LWP 13462) exited]
>>>>>> [Thread 0xb4398b70 (LWP 13461) exited]
>>>>>> [Thread 0xf7f93b70 (LWP 13460) exited]
>>>>>> [Thread 0xb30ffb70 (LWP 13470) exited]
>>>>>> 
>>>>>> Program exited normally.
>>>>>> (gdb)
>>>>>> 
>>>>>> 
>>>>>> cthaling at intelsdv01:/export/twisti/build/8008772/build/solaris_i486_compiler2/debug$ 
>>>>>> /bin/bash ./hotspot -dbx -version
>>>>>> dbx: warning: using the alternate init file: /home/cthaling/.dbxrc
>>>>>> Reading java
>>>>>> Reading ld.so.1
>>>>>> Reading libjli.so
>>>>>> Reading libthread.so.1
>>>>>> Reading libdl.so.1
>>>>>> Reading libc.so.1
>>>>>> Reading libjvm.so
>>>>>> Loaded loadobject:
>>>>>> /export/twisti/build/8008772/build/solaris_i486_compiler2/debug/libjvm.so 
>>>>>> 
>>>>>> Running: java -Dsun.java.launcher=gamma
>>>>>> -XXaltjvm=/export/twisti/build/8008772/build/solaris_i486_compiler2/debug 
>>>>>> -version
>>>>>> (process id 29613)
>>>>>> Reading libsocket.so.1
>>>>>> Reading libsched.so.1
>>>>>> Reading libm.so.1
>>>>>> Reading libCrun.so.1
>>>>>> Reading libdoor.so.1
>>>>>> Reading libdemangle.so.1
>>>>>> Reading libnsl.so.1
>>>>>> Reading libm.so.2
>>>>>> Reading libscf.so.1
>>>>>> Reading libuutil.so.1
>>>>>> Reading libgen.so.1
>>>>>> Reading libmd.so.1
>>>>>> Reading libmp.so.2
>>>>>> t at 2 (l at 2) stopped in JNI_CreateJavaVM at line 5062 in file "jni.cpp"
>>>>>>  5062     jint result = JNI_ERR;
>>>>>> (dbx) stop in CompileBroker::compile_method
>>>>>> (2) stop in
>>>>>> CompileBroker::compile_method(methodHandle,int,int,methodHandle,int,const 
>>>>>> char*,Thread*)
>>>>>> (dbx) c
>>>>>> Reading libverify.so
>>>>>> Reading libjava.so
>>>>>> Reading libzip.so
>>>>>> java version "1.8.0-ea"
>>>>>> Java(TM) SE Runtime Environment (build 1.8.0-ea-b86)
>>>>>> Java HotSpot(TM) Server VM (build 25.0-b29-internal-debug, mixed mode)
>>>>>> 
>>>>>> execution completed, exit code is 0
>>>>>> (dbx)
>>>>>> 
>>> 
> 


From mikael.gerdin at oracle.com  Tue Apr 23 11:33:59 2013
From: mikael.gerdin at oracle.com (Mikael Gerdin)
Date: Tue, 23 Apr 2013 20:33:59 +0200
Subject: RFR (M): 8008772: remove gamma launcher
In-Reply-To: <1897490C-0C9E-4E70-BA70-22C5CB1CDAE3@oracle.com>
References: <5C64AF5E-EDD5-4669-9777-5FF7CE6E615F@oracle.com>
	<51759F6B.7080808@oracle.com>
	<764DA08E-5A58-4FD4-BB48-0F4F13401BCC@oracle.com>
	<51764FDE.2090205@oracle.com> <517669A6.8030705@oracle.com>
	<5176CD8E.5060704@oracle.com>
	<1897490C-0C9E-4E70-BA70-22C5CB1CDAE3@oracle.com>
Message-ID: <5176D417.3040202@oracle.com>


On 2013-04-23 20:28, Christian Thalinger wrote:
>
> On Apr 23, 2013, at 11:06 AM, Nils Eliasson  wrote:
>
>> As long as we fix it first and remove gamma after - I would love to have some redundant code removed. I would fix it myself, I just don't think I will have the time before I go on parental leave.
>
> First, I'm not removing it tomorrow.  I expected a long discussion :-)
>
> What exactly is the problem with Visual Studio?  Why can't you just run the java launcher instead?
>

I don't know if there actually is a problem, but I don't think anyone's 
actually tried to tell it to use the java launcher.
The VS project is automatically setup to launch "hotspot.exe" from the 
IDE. "hotspot.exe" is equivalent to the old option LINK_INTO=AOUT (IIRC) 
which involves linking all the VM object files into the launcher.

Nils, perhaps you can at least try this before you leave?

/Mikael

> -- Chris
>
>>
>> //Nils
>>
>> On 2013-04-23 12:59, Mikael Gerdin wrote:
>>>
>>>
>>> On 2013-04-23 11:09, Nils Eliasson wrote:
>>>> The gamma launcher is used to run and debug hotspot from Visual Studio.
>>>> So removing gamma effectively kills the working environment for a number
>>>> of people that use it daily.  So I am strongly against removing it.
>>>
>>> Maybe the visual studio project generator could be updated to create a a "launch configuration" for launching java.exe from a JDK and use the XXaltJVM flag on to select the correct jvm.dll?
>>>
>>> I agree that we shouldn't break the visual studio project but currently there's nothing indicating that we can't fix it.
>>>
>>>
>>> /Mikael
>>>
>>>>
>>>> Most people working on Windows use Cygwin as the last resort since it
>>>> makes a lot of thing excruciatingly slow.
>>>>
>>>> //Nils
>>>>
>>>> On 2013-04-22 22:55, Christian Thalinger wrote:
>>>>> On Apr 22, 2013, at 1:36 PM, Daniel D. Daugherty
>>>>>  wrote:
>>>>>
>>>>>> Chris,
>>>>>>
>>>>>> Just an observation and not a review.
>>>>>>
>>>>>> Looks like you're removing launcher support on Windows, but it
>>>>>> looks like the new hotspot.script doesn't support Windows...
>>>>>> Am I missing something?
>>>>> Almost certainly true.  Since I'm not a Windows user (and nobody near
>>>>> me is one) I have no idea how people are using the gamma launcher on
>>>>> Windows (or the hotspot script for that matter).
>>>>>
>>>>> I presume most people doing debugging on the command line are already
>>>>> in cygwin?  But I might be wrong.
>>>>>
>>>>> -- Chris
>>>>>
>>>>>> Dan
>>>>>>
>>>>>>
>>>>>> On 4/22/13 1:47 PM, Christian Thalinger wrote:
>>>>>>> http://cr.openjdk.java.net/~twisti/8008772/
>>>>>>>
>>>>>>> 8008772: remove gamma launcher
>>>>>>> Reviewed-by:
>>>>>>>
>>>>>>> Remove linking the gamma launcher and it's associated source files.
>>>>>>>
>>>>>>> make/Makefile
>>>>>>> make/bsd/makefiles/launcher.make
>>>>>>> make/bsd/makefiles/vm.make
>>>>>>> make/hotspot.script
>>>>>>> make/linux/makefiles/launcher.make
>>>>>>> make/linux/makefiles/vm.make
>>>>>>> make/solaris/makefiles/launcher.make
>>>>>>> make/solaris/makefiles/vm.make
>>>>>>> make/windows/makefiles/debug.make
>>>>>>> make/windows/makefiles/fastdebug.make
>>>>>>> make/windows/makefiles/launcher.make
>>>>>>> make/windows/makefiles/product.make
>>>>>>> make/windows/makefiles/projectcreator.make
>>>>>>> make/windows/projectfiles/common/Makefile
>>>>>>> src/os/posix/launcher/java_md.c
>>>>>>> src/os/posix/launcher/java_md.h
>>>>>>> src/os/posix/launcher/launcher.script
>>>>>>> src/os/windows/launcher/java_md.c
>>>>>>> src/os/windows/launcher/java_md.h
>>>>>>> src/share/tools/launcher/java.c
>>>>>>> src/share/tools/launcher/java.h
>>>>>>> src/share/tools/launcher/jli_util.c
>>>>>>> src/share/tools/launcher/jli_util.h
>>>>>>> src/share/tools/launcher/wildcard.c
>>>>>>> src/share/tools/launcher/wildcard.h
>>>>>>>
>>>>>>> This change removes the duplicated java launcher files (which were
>>>>>>> subject to bit-rot) and modifies the hotspot script to pick up the
>>>>>>> libjvm in the current build directory.
>>>>>>>
>>>>>>> The modified hotspot script works with GDB and DBX:
>>>>>>>
>>>>>>> cthaling at intelsdv03.us.oracle.com:/export/twisti/build/8008772/build/linux_i486_compiler2/debug$
>>>>>>> ./hotspot -gdb -version
>>>>>>> GNU gdb (GDB) Red Hat Enterprise Linux (7.1-29.el6)
>>>>>>> Copyright (C) 2010 Free Software Foundation, Inc.
>>>>>>> License GPLv3+: GNU GPL version 3 or later
>>>>>>> 
>>>>>>> This is free software: you are free to change and redistribute it.
>>>>>>> There is NO WARRANTY, to the extent permitted by law. Type "show
>>>>>>> copying"
>>>>>>> and "show warranty" for details.
>>>>>>> This GDB was configured as "x86_64-redhat-linux-gnu".
>>>>>>> For bug reporting instructions, please see:
>>>>>>> .
>>>>>>> Missing separate debuginfo for
>>>>>>> /net/scanas404.us.oracle.com/export/java-re/jdk/8/ea/b86/binaries/linux-i586/bin/java
>>>>>>>
>>>>>>> Try: yum --disablerepo='*' --enablerepo='*-debuginfo' install
>>>>>>> /usr/lib/debug/.build-id/5e/85e6dced3b388a7b0e50630242f4c7ee5e31a3.debug
>>>>>>>
>>>>>>> Function "JNI_CreateJavaVM" not defined.
>>>>>>> Breakpoint 1 (JNI_CreateJavaVM) pending.
>>>>>>> [Thread debugging using libthread_db enabled]
>>>>>>> [New Thread 0xf7fe4b70 (LWP 13459)]
>>>>>>> [Switching to Thread 0xf7fe4b70 (LWP 13459)]
>>>>>>>
>>>>>>> Breakpoint 1, JNI_CreateJavaVM (vm=0xf7fe4378, penv=0xf7fe4374,
>>>>>>> args=0xf7fe4364)
>>>>>>>      at
>>>>>>> /net/10.159.161.234/Users/cthaling/ws/8008772/src/share/vm/prims/jni.cpp:5062
>>>>>>>
>>>>>>> 5062      jint result = JNI_ERR;
>>>>>>> Missing separate debuginfos, use: debuginfo-install
>>>>>>> glibc-2.12-1.7.el6.i686
>>>>>>> (gdb) break CompileBroker::compile_method
>>>>>>> Breakpoint 2 at 0xaef852: file
>>>>>>> /net/10.159.161.234/Users/cthaling/ws/8008772/src/share/vm/compiler/compileBroker.cpp,
>>>>>>> line 1205.
>>>>>>> (gdb) c
>>>>>>> Continuing.
>>>>>>> [New Thread 0xf7f93b70 (LWP 13460)]
>>>>>>> [New Thread 0xb4398b70 (LWP 13461)]
>>>>>>> [New Thread 0xb41ffb70 (LWP 13462)]
>>>>>>> [New Thread 0xb3effb70 (LWP 13463)]
>>>>>>> [New Thread 0xb3cffb70 (LWP 13464)]
>>>>>>> [New Thread 0xb3affb70 (LWP 13465)]
>>>>>>> [New Thread 0xb38ffb70 (LWP 13466)]
>>>>>>> [New Thread 0xb36ffb70 (LWP 13467)]
>>>>>>> [New Thread 0xb34ffb70 (LWP 13468)]
>>>>>>> [New Thread 0xb32ffb70 (LWP 13469)]
>>>>>>> [New Thread 0xb30ffb70 (LWP 13470)]
>>>>>>> [New Thread 0xb2effb70 (LWP 13471)]
>>>>>>> [New Thread 0xb2cffb70 (LWP 13472)]
>>>>>>> [New Thread 0xaf8e8b70 (LWP 13473)]
>>>>>>> [New Thread 0xb4156b70 (LWP 13474)]
>>>>>>> [New Thread 0xb3c7eb70 (LWP 13475)]
>>>>>>> [New Thread 0xb3a7eb70 (LWP 13476)]
>>>>>>> [New Thread 0xaeeffb70 (LWP 13477)]
>>>>>>> [New Thread 0xaecffb70 (LWP 13478)]
>>>>>>> [New Thread 0xb387eb70 (LWP 13479)]
>>>>>>> [New Thread 0xaeaffb70 (LWP 13480)]
>>>>>>> java version "1.8.0-ea"
>>>>>>> Java(TM) SE Runtime Environment (build 1.8.0-ea-b86)
>>>>>>> Java HotSpot(TM) Server VM (build 25.0-b29-internal-debug, mixed mode)
>>>>>>> [Thread 0xaeaffb70 (LWP 13480) exited]
>>>>>>> [Thread 0xb3a7eb70 (LWP 13476) exited]
>>>>>>> [Thread 0xaf8e8b70 (LWP 13473) exited]
>>>>>>> [Thread 0xf7fe4b70 (LWP 13459) exited]
>>>>>>> [Thread 0xb2cffb70 (LWP 13472) exited]
>>>>>>> [Thread 0xb2effb70 (LWP 13471) exited]
>>>>>>> [Thread 0xaecffb70 (LWP 13478) exited]
>>>>>>> [Thread 0xb387eb70 (LWP 13479) exited]
>>>>>>> [Thread 0xaeeffb70 (LWP 13477) exited]
>>>>>>> [Thread 0xb3c7eb70 (LWP 13475) exited]
>>>>>>> [Thread 0xb4156b70 (LWP 13474) exited]
>>>>>>> [Thread 0xb32ffb70 (LWP 13469) exited]
>>>>>>> [Thread 0xb34ffb70 (LWP 13468) exited]
>>>>>>> [Thread 0xb36ffb70 (LWP 13467) exited]
>>>>>>> [Thread 0xb38ffb70 (LWP 13466) exited]
>>>>>>> [Thread 0xb3affb70 (LWP 13465) exited]
>>>>>>> [Thread 0xb3cffb70 (LWP 13464) exited]
>>>>>>> [Thread 0xb3effb70 (LWP 13463) exited]
>>>>>>> [Thread 0xb41ffb70 (LWP 13462) exited]
>>>>>>> [Thread 0xb4398b70 (LWP 13461) exited]
>>>>>>> [Thread 0xf7f93b70 (LWP 13460) exited]
>>>>>>> [Thread 0xb30ffb70 (LWP 13470) exited]
>>>>>>>
>>>>>>> Program exited normally.
>>>>>>> (gdb)
>>>>>>>
>>>>>>>
>>>>>>> cthaling at intelsdv01:/export/twisti/build/8008772/build/solaris_i486_compiler2/debug$
>>>>>>> /bin/bash ./hotspot -dbx -version
>>>>>>> dbx: warning: using the alternate init file: /home/cthaling/.dbxrc
>>>>>>> Reading java
>>>>>>> Reading ld.so.1
>>>>>>> Reading libjli.so
>>>>>>> Reading libthread.so.1
>>>>>>> Reading libdl.so.1
>>>>>>> Reading libc.so.1
>>>>>>> Reading libjvm.so
>>>>>>> Loaded loadobject:
>>>>>>> /export/twisti/build/8008772/build/solaris_i486_compiler2/debug/libjvm.so
>>>>>>>
>>>>>>> Running: java -Dsun.java.launcher=gamma
>>>>>>> -XXaltjvm=/export/twisti/build/8008772/build/solaris_i486_compiler2/debug
>>>>>>> -version
>>>>>>> (process id 29613)
>>>>>>> Reading libsocket.so.1
>>>>>>> Reading libsched.so.1
>>>>>>> Reading libm.so.1
>>>>>>> Reading libCrun.so.1
>>>>>>> Reading libdoor.so.1
>>>>>>> Reading libdemangle.so.1
>>>>>>> Reading libnsl.so.1
>>>>>>> Reading libm.so.2
>>>>>>> Reading libscf.so.1
>>>>>>> Reading libuutil.so.1
>>>>>>> Reading libgen.so.1
>>>>>>> Reading libmd.so.1
>>>>>>> Reading libmp.so.2
>>>>>>> t at 2 (l at 2) stopped in JNI_CreateJavaVM at line 5062 in file "jni.cpp"
>>>>>>>   5062     jint result = JNI_ERR;
>>>>>>> (dbx) stop in CompileBroker::compile_method
>>>>>>> (2) stop in
>>>>>>> CompileBroker::compile_method(methodHandle,int,int,methodHandle,int,const
>>>>>>> char*,Thread*)
>>>>>>> (dbx) c
>>>>>>> Reading libverify.so
>>>>>>> Reading libjava.so
>>>>>>> Reading libzip.so
>>>>>>> java version "1.8.0-ea"
>>>>>>> Java(TM) SE Runtime Environment (build 1.8.0-ea-b86)
>>>>>>> Java HotSpot(TM) Server VM (build 25.0-b29-internal-debug, mixed mode)
>>>>>>>
>>>>>>> execution completed, exit code is 0
>>>>>>> (dbx)
>>>>>>>
>>>>
>>
>

From christian.tornqvist at oracle.com  Tue Apr 23 13:51:04 2013
From: christian.tornqvist at oracle.com (christian.tornqvist at oracle.com)
Date: Tue, 23 Apr 2013 20:51:04 +0000
Subject: hg: hsx/hsx24/hotspot: 2 new changesets
Message-ID: <20130423205110.BC9C848535@hg.openjdk.java.net>

Changeset: 48bd376971b2
Author:    ctornqvi
Date:      2013-04-23 17:39 +0200
URL:       http://hg.openjdk.java.net/hsx/hsx24/hotspot/rev/48bd376971b2

8008454: test/runtime/NMT/PrintNMTStatistics is broken
Summary: Added @run tag so that it actually runs the test, also fixed broken command line and incorrect parsing. Also reviewed by gerard.ziemski at oracle.com
Reviewed-by: mgerdin, zgu

! test/runtime/NMT/PrintNMTStatistics.java

Changeset: 4f296b8b3147
Author:    ctornqvi
Date:      2013-04-23 19:40 +0200
URL:       http://hg.openjdk.java.net/hsx/hsx24/hotspot/rev/4f296b8b3147

Merge



From christian.tornqvist at oracle.com  Tue Apr 23 17:16:32 2013
From: christian.tornqvist at oracle.com (christian.tornqvist at oracle.com)
Date: Wed, 24 Apr 2013 00:16:32 +0000
Subject: hg: hsx/hsx24/hotspot: 8009125: Add NMT tests for Virtual Memory
	operations
Message-ID: <20130424001634.36B7248547@hg.openjdk.java.net>

Changeset: f25c212012a1
Author:    ctornqvi
Date:      2013-04-23 23:37 +0200
URL:       http://hg.openjdk.java.net/hsx/hsx24/hotspot/rev/f25c212012a1

8009125: Add NMT tests for Virtual Memory operations
Summary: Tests added for Reserve/Commit/Uncommit/Unreserve operations
Reviewed-by: zgu, mgerdin

! src/share/vm/prims/whitebox.cpp
- test/runtime/NMT/AllocTestType.java
+ test/runtime/NMT/MallocTestType.java
+ test/runtime/NMT/ThreadedMallocTestType.java
+ test/runtime/NMT/ThreadedVirtualAllocTestType.java
+ test/runtime/NMT/VirtualAllocTestType.java
! test/testlibrary/OutputAnalyzerTest.java
! test/testlibrary/com/oracle/java/testlibrary/OutputAnalyzer.java
! test/testlibrary/whitebox/sun/hotspot/WhiteBox.java


From john.cuthbertson at oracle.com  Tue Apr 23 19:59:55 2013
From: john.cuthbertson at oracle.com (john.cuthbertson at oracle.com)
Date: Wed, 24 Apr 2013 02:59:55 +0000
Subject: hg: hsx/hsx24/hotspot: 4 new changesets
Message-ID: <20130424030005.F353C48555@hg.openjdk.java.net>

Changeset: 948a0f918ef4
Author:    brutisso
Date:      2013-01-16 12:46 +0100
URL:       http://hg.openjdk.java.net/hsx/hsx24/hotspot/rev/948a0f918ef4

8006242: G1: WorkerDataArray::verify() too strict for double calculations
Summary: Also reviewed by vitalyd at gmail.com.
Reviewed-by: johnc, mgerdin

! src/share/vm/gc_implementation/g1/g1GCPhaseTimes.cpp
! src/share/vm/gc_implementation/g1/g1GCPhaseTimes.hpp

Changeset: f33ff5092994
Author:    johnc
Date:      2013-02-01 13:17 -0800
URL:       http://hg.openjdk.java.net/hsx/hsx24/hotspot/rev/f33ff5092994

8006894: G1: Number of marking threads missing from PrintFlagsFinal output
Summary: Set ConcGCThreads to the calculated number of marking threads.
Reviewed-by: jmasa, ysr

! src/share/vm/gc_implementation/g1/concurrentMark.cpp

Changeset: 5e7504597502
Author:    johnc
Date:      2013-02-22 11:01 -0800
URL:       http://hg.openjdk.java.net/hsx/hsx24/hotspot/rev/5e7504597502

8007221: G1: concurrent phase durations do not state the time units ("secs")
Summary: Add timer units to concurrent marking phases where the units were missing.
Reviewed-by: jmasa, ysr

! src/share/vm/gc_implementation/g1/concurrentMarkThread.cpp

Changeset: 28d063f12798
Author:    johnc
Date:      2013-04-23 17:19 -0700
URL:       http://hg.openjdk.java.net/hsx/hsx24/hotspot/rev/28d063f12798

Merge



From vladimir.kozlov at oracle.com  Tue Apr 23 22:35:24 2013
From: vladimir.kozlov at oracle.com (vladimir.kozlov at oracle.com)
Date: Wed, 24 Apr 2013 05:35:24 +0000
Subject: hg: hsx/hsx24/hotspot: 9 new changesets
Message-ID: <20130424053545.3338748562@hg.openjdk.java.net>

Changeset: d59ed8d47aed
Author:    kvn
Date:      2013-04-03 11:12 -0700
URL:       http://hg.openjdk.java.net/hsx/hsx24/hotspot/rev/d59ed8d47aed

8011102: Clear AVX registers after return from JNI call
Summary: Execute vzeroupper instruction after JNI call and on exits in jit compiled code which use 256bit vectors.
Reviewed-by: roland

! src/cpu/x86/vm/assembler_x86.cpp
! src/cpu/x86/vm/assembler_x86.hpp
! src/cpu/x86/vm/cppInterpreter_x86.cpp
! src/cpu/x86/vm/sharedRuntime_x86_32.cpp
! src/cpu/x86/vm/sharedRuntime_x86_64.cpp
! src/cpu/x86/vm/stubGenerator_x86_32.cpp
! src/cpu/x86/vm/stubGenerator_x86_64.cpp
! src/cpu/x86/vm/templateInterpreter_x86_32.cpp
! src/cpu/x86/vm/templateInterpreter_x86_64.cpp
! src/cpu/x86/vm/x86_32.ad
! src/cpu/x86/vm/x86_64.ad
! src/os_cpu/bsd_x86/vm/bsd_x86_64.ad
! src/os_cpu/linux_x86/vm/linux_x86_64.ad
! src/os_cpu/solaris_x86/vm/solaris_x86_64.ad
! src/os_cpu/windows_x86/vm/windows_x86_64.ad

Changeset: 73ec23a2d1a6
Author:    rasbold
Date:      2013-04-03 15:00 -0700
URL:       http://hg.openjdk.java.net/hsx/hsx24/hotspot/rev/73ec23a2d1a6

8010437: guarantee(this->is8bit(imm8)) failed: Short forward jump exceeds 8-bit offset
Summary: Fix shorten_branches() to accurately count an initial nop that may be inserted in a block that starts with a safepoint.
Reviewed-by: kvn

! src/share/vm/opto/output.cpp

Changeset: ab200d01a0db
Author:    neliasso
Date:      2013-04-04 09:18 +0200
URL:       http://hg.openjdk.java.net/hsx/hsx24/hotspot/rev/ab200d01a0db

8006008: Memory leak in hotspot/src/share/vm/adlc/archDesc.cpp
Reviewed-by: roland, kvn
Contributed-by: niclas.adlertz at oracle.com

! src/share/vm/adlc/archDesc.cpp

Changeset: dba7425a1e21
Author:    neliasso
Date:      2013-04-04 09:30 +0200
URL:       http://hg.openjdk.java.net/hsx/hsx24/hotspot/rev/dba7425a1e21

8006014: Memory leak in hotspot/src/share/vm/adlc/dfa.cpp
Reviewed-by: kvn, roland
Contributed-by: niclas.adlertz at oracle.com

! src/share/vm/adlc/dfa.cpp

Changeset: 9bd654867fe1
Author:    neliasso
Date:      2013-04-05 11:09 +0200
URL:       http://hg.openjdk.java.net/hsx/hsx24/hotspot/rev/9bd654867fe1

8006016: Memory leak at hotspot/src/share/vm/adlc/output_c.cpp
Reviewed-by: kvn, roland
Contributed-by: niclas.adlertz at oracle.com

! src/share/vm/adlc/output_c.cpp
! src/share/vm/adlc/output_h.cpp

Changeset: 719fd17b822c
Author:    bharadwaj
Date:      2013-04-08 07:40 -0700
URL:       http://hg.openjdk.java.net/hsx/hsx24/hotspot/rev/719fd17b822c

8010913: compiler/6863420 often exceeds timeout
Summary: add longer timeout for jtreg, add internal timeout thread to prevent spurious timeouts
Reviewed-by: twisti, kvn
Contributed-by: drchase 

! test/compiler/6863420/Test.java

Changeset: c0c1cf79ebd1
Author:    kmo
Date:      2013-04-11 07:12 -0700
URL:       http://hg.openjdk.java.net/hsx/hsx24/hotspot/rev/c0c1cf79ebd1

8011952: Missing ResourceMarks in TraceMethodHandles
Summary: add missing ResourceMark under TraceMethodHandles in LinkResolver
Reviewed-by: dholmes

! src/share/vm/interpreter/linkResolver.cpp

Changeset: 9761ff0af648
Author:    drchase
Date:      2013-04-12 19:14 -0700
URL:       http://hg.openjdk.java.net/hsx/hsx24/hotspot/rev/9761ff0af648

6443505: Ideal() function for CmpLTMask
Summary: Repair wrong code generation, added new matching rule
Reviewed-by: kvn, twisti

! src/cpu/sparc/vm/sparc.ad
! src/cpu/x86/vm/x86_32.ad
! src/cpu/x86/vm/x86_64.ad
! src/share/vm/opto/cfgnode.cpp
+ test/compiler/6443505/Test6443505.java

Changeset: d22109dfc23e
Author:    roland
Date:      2013-04-16 17:06 +0200
URL:       http://hg.openjdk.java.net/hsx/hsx24/hotspot/rev/d22109dfc23e

8011901: Unsafe.getAndAddLong(obj, off, delta) does not work properly with long deltas
Summary: instruct xaddL_no_res shouldn't allow 64 bit constants.
Reviewed-by: kvn

! src/cpu/x86/vm/x86_64.ad
+ test/compiler/8011901/Test8011901.java


From adomurad at redhat.com  Wed Apr 24 10:07:22 2013
From: adomurad at redhat.com (Adam Domurad)
Date: Wed, 24 Apr 2013 13:07:22 -0400
Subject: RR(S): 8009062 poor performance of JNI AttachCurrentThread after
	fix for 7017193
In-Reply-To: <5175AEA2.2050408@oracle.com>
References: <512CF7D5.2030300@redhat.com> <512D2B73.4060103@oracle.com>
	
	<5130D0AB.8000001@oracle.com> <513780C0.9050103@redhat.com>
	<513E1210.4030406@oracle.com> <515493D5.7090308@redhat.com>
	<5175AEA2.2050408@oracle.com>
Message-ID: <5178114A.4030901@redhat.com>

On 04/22/2013 05:41 PM, Dmitry Samersoff wrote:
> Hi Everybody,

Thanks for tackling this.

>
> Here is webrev of proposed changes:
>
> http://cr.openjdk.java.net/~dsamersoff/8009062/webrev.04/
>
> Any comments is much appreciated.
>
> The problem:
>
> Under Linux stack of main thread is growable, so we have to make sure
> that address we plan to put a guard pages to and below is not mapped.
>
> Historically we find bounds of the stack of main thread by seeking
> /proc/self/maps for "[stack]" and parsing this line.
>
> I don't like buffered reading of /proc files and sometimes ago rewrite
> this function to read it byte-to-byte. Unfortunately, resulting
> performance penalties is not acceptable.

I'm afraid I don't follow. What did you not like about the buffered 
reading ? From my performance measurements this patch is slower (not 
significantly, but around 30%).
What are your performance measurements like between get_stack_bounds_ex 
& get_stack_bounds (from this patch) ? Is there any worst-case behaviour 
that you fear from the original patch ?

>
>
> Solution:
>
> Below is slightly different approach - I use mincore(2) to check whether
> the page is mapped or not. Typically mincore(2) is used to check whether
> the page is resides in physical memory or not, but this function returns
> -1 and set errno to ENOMEM if a region we are asking about contains not
> mapped memory.
>
> Testing:
>
> Passed jprt and couple of jtreg tests. No special regression test
> necessary as the test for 6929067 covers this case as well.
>
> -Dmitry
>
>

Overall approach looks sounds,;I have not done thorough testing but I 
did check the assert and everything is fine here.
Libreoffice performance with the E-Porto plugin (against which a bug was 
filed) looks to be acceptable now (there is little doubt of the change - 
the pause time was *very* noticeable before).

Thanks again,
-Adam

From daniel.daugherty at oracle.com  Wed Apr 24 10:48:37 2013
From: daniel.daugherty at oracle.com (daniel.daugherty at oracle.com)
Date: Wed, 24 Apr 2013 17:48:37 +0000
Subject: hg: hsx/hotspot-main/hotspot: 13 new changesets
Message-ID: <20130424174908.1DAB048584@hg.openjdk.java.net>

Changeset: 63e31ce40bdb
Author:    hseigel
Date:      2013-04-17 08:20 -0400
URL:       http://hg.openjdk.java.net/hsx/hotspot-main/hotspot/rev/63e31ce40bdb

8009928: PSR:PERF Increase default string table size
Summary: Increase default string table size to 60013 for 64-bit platforms.
Reviewed-by: coleenp, dholmes

! src/share/vm/runtime/arguments.cpp
! src/share/vm/utilities/globalDefinitions.hpp

Changeset: b80cc96882f7
Author:    zgu
Date:      2013-04-18 10:04 -0400
URL:       http://hg.openjdk.java.net/hsx/hotspot-main/hotspot/rev/b80cc96882f7

8012464: NMT: classes should not derive from _ValueObj, use VALUE_OBJ_CLASS_SPEC instead
Summary: NMT value objects should use VALUE_OBJ_CLASS_SPEC instead of deriving from _ValueObj
Reviewed-by: coleenp, hseigel, dholmes

! src/share/vm/services/memBaseline.hpp
! src/share/vm/services/memPtr.hpp
! src/share/vm/services/memSnapshot.hpp
! src/share/vm/services/memTrackWorker.hpp

Changeset: 41ed397cc0cd
Author:    bharadwaj
Date:      2013-04-18 08:05 -0700
URL:       http://hg.openjdk.java.net/hsx/hotspot-main/hotspot/rev/41ed397cc0cd

8006267: InterfaceMethod_ref should allow invokestatic and invokespecial
Summary: Lambda changes; spec 0.6.2 - Allow static invokestatic and invokespecial calls to InterfaceMethod_ref
Reviewed-by: dholmes, acorn

! src/share/vm/classfile/classFileParser.cpp
! src/share/vm/classfile/genericSignatures.cpp
! src/share/vm/interpreter/linkResolver.cpp
! src/share/vm/prims/methodHandles.cpp

Changeset: 7815eaceaa8c
Author:    bharadwaj
Date:      2013-04-18 14:03 -0400
URL:       http://hg.openjdk.java.net/hsx/hotspot-main/hotspot/rev/7815eaceaa8c

Merge


Changeset: 6f817ce50129
Author:    minqi
Date:      2013-04-19 11:08 -0700
URL:       http://hg.openjdk.java.net/hsx/hotspot-main/hotspot/rev/6f817ce50129

8010992: Remove calls to global ::operator new[] and new
Summary: disable use of global operator new and new[] which could cause unexpected exception and escape from NMT tracking.
Reviewed-by: coleenp, dholmes, zgu
Contributed-by: yumin.qi at oracle.com

! src/os/windows/vm/os_windows.cpp
! src/share/vm/classfile/altHashing.cpp
! src/share/vm/gc_implementation/concurrentMarkSweep/cmsCollectorPolicy.cpp
! src/share/vm/gc_implementation/g1/heapRegionRemSet.cpp
! src/share/vm/memory/allocation.cpp
! src/share/vm/memory/allocation.hpp
! src/share/vm/memory/allocation.inline.hpp
! src/share/vm/memory/cardTableModRefBS.cpp
! src/share/vm/memory/cardTableModRefBS.hpp
! src/share/vm/memory/cardTableRS.cpp
! src/share/vm/memory/cardTableRS.hpp
! src/share/vm/memory/collectorPolicy.cpp
! src/share/vm/opto/idealGraphPrinter.hpp
! src/share/vm/runtime/handles.hpp
! src/share/vm/runtime/reflectionUtils.hpp
! src/share/vm/runtime/synchronizer.cpp
! src/share/vm/runtime/thread.cpp
! src/share/vm/runtime/vmStructs.cpp
! src/share/vm/utilities/events.hpp
! src/share/vm/utilities/quickSort.cpp
! src/share/vm/utilities/workgroup.cpp
! src/share/vm/utilities/workgroup.hpp

Changeset: 17c51f84773a
Author:    dcubed
Date:      2013-04-19 13:48 -0700
URL:       http://hg.openjdk.java.net/hsx/hotspot-main/hotspot/rev/17c51f84773a

Merge


Changeset: 5b6512efcdc4
Author:    dcubed
Date:      2013-04-19 16:51 -0700
URL:       http://hg.openjdk.java.net/hsx/hotspot-main/hotspot/rev/5b6512efcdc4

Merge

- make/bsd/makefiles/jvmg.make
- make/bsd/makefiles/profiled.make
- make/linux/makefiles/jvmg.make
- make/linux/makefiles/profiled.make
- make/solaris/makefiles/jvmg.make
- make/solaris/makefiles/profiled.make
- src/os/bsd/vm/chaitin_bsd.cpp
- src/os/linux/vm/chaitin_linux.cpp
- src/os/solaris/vm/chaitin_solaris.cpp
- src/os/windows/vm/chaitin_windows.cpp
! src/os/windows/vm/os_windows.cpp
! src/share/vm/memory/allocation.hpp
! src/share/vm/runtime/vmStructs.cpp

Changeset: 6337ca4dcad8
Author:    sspitsyn
Date:      2013-04-20 04:07 -0700
URL:       http://hg.openjdk.java.net/hsx/hotspot-main/hotspot/rev/6337ca4dcad8

8008511: JSR 292: MemberName vmtarget refs to methods must be updated at class redefinition
Summary: Lazily create and maintain the MemberNameTable to be able to update MemberName's
Reviewed-by: coleenp, jrose, dholmes
Contributed-by: serguei.spitsyn at oracle.com

! src/share/vm/classfile/javaClasses.cpp
! src/share/vm/classfile/javaClasses.hpp
! src/share/vm/oops/instanceKlass.cpp
! src/share/vm/oops/instanceKlass.hpp
! src/share/vm/prims/jvmtiRedefineClasses.cpp
! src/share/vm/prims/methodHandles.cpp
! src/share/vm/prims/methodHandles.hpp
! src/share/vm/runtime/mutexLocker.cpp
! src/share/vm/runtime/mutexLocker.hpp

Changeset: a527ddd44e07
Author:    mgronlun
Date:      2013-04-20 19:02 +0200
URL:       http://hg.openjdk.java.net/hsx/hotspot-main/hotspot/rev/a527ddd44e07

6729929: I18N - Taking Heap Dump failed if project path contains multibyte characters
Reviewed-by: dholmes, rbackman
Contributed-by: peter.allwin at oracle.com

! src/share/vm/services/management.cpp

Changeset: 5a9fa2ba85f0
Author:    dcubed
Date:      2013-04-21 20:41 -0700
URL:       http://hg.openjdk.java.net/hsx/hotspot-main/hotspot/rev/5a9fa2ba85f0

8012907: anti-delta fix for 8010992
Summary: anti-delta fix for 8010992 until 8012902 can be fixed
Reviewed-by: acorn, minqi, rdurbin

! src/os/windows/vm/os_windows.cpp
! src/share/vm/classfile/altHashing.cpp
! src/share/vm/gc_implementation/concurrentMarkSweep/cmsCollectorPolicy.cpp
! src/share/vm/gc_implementation/g1/heapRegionRemSet.cpp
! src/share/vm/memory/allocation.cpp
! src/share/vm/memory/allocation.hpp
! src/share/vm/memory/allocation.inline.hpp
! src/share/vm/memory/cardTableModRefBS.cpp
! src/share/vm/memory/cardTableModRefBS.hpp
! src/share/vm/memory/cardTableRS.cpp
! src/share/vm/memory/cardTableRS.hpp
! src/share/vm/memory/collectorPolicy.cpp
! src/share/vm/opto/idealGraphPrinter.hpp
! src/share/vm/runtime/handles.hpp
! src/share/vm/runtime/reflectionUtils.hpp
! src/share/vm/runtime/synchronizer.cpp
! src/share/vm/runtime/thread.cpp
! src/share/vm/runtime/vmStructs.cpp
! src/share/vm/utilities/events.hpp
! src/share/vm/utilities/quickSort.cpp
! src/share/vm/utilities/workgroup.cpp
! src/share/vm/utilities/workgroup.hpp

Changeset: cc12becb22e7
Author:    dcubed
Date:      2013-04-21 21:05 -0700
URL:       http://hg.openjdk.java.net/hsx/hotspot-main/hotspot/rev/cc12becb22e7

Merge

! src/os/windows/vm/os_windows.cpp
! src/share/vm/memory/allocation.hpp
! src/share/vm/runtime/vmStructs.cpp

Changeset: ce6d7e43501c
Author:    bharadwaj
Date:      2013-04-23 08:12 -0700
URL:       http://hg.openjdk.java.net/hsx/hotspot-main/hotspot/rev/ce6d7e43501c

8012961: Do not restrict static interface methods to be private
Summary: Lambda changes; spec 0.6.2 - remove the restriction that was added as part of recent changes made to support upcoming changes to compilation of lambda methods.
Reviewed-by: dholmes, acorn

! src/share/vm/prims/methodHandles.cpp

Changeset: 1ea6a35dcbe5
Author:    jiangli
Date:      2013-04-23 12:32 -0400
URL:       http://hg.openjdk.java.net/hsx/hotspot-main/hotspot/rev/1ea6a35dcbe5

8012927: 'assert(nbits == 32 || (-(1 << nbits-1) <= x && x < ( 1 << nbits-1))) failed: value out of range' in interpreter initialization.
Summary: Change br_null_short() to br_null().
Reviewed-by: coleenp, hseigel

! src/cpu/sparc/vm/interp_masm_sparc.cpp


From harold.seigel at oracle.com  Wed Apr 24 13:21:42 2013
From: harold.seigel at oracle.com (harold.seigel at oracle.com)
Date: Wed, 24 Apr 2013 20:21:42 +0000
Subject: hg: hsx/hsx24/hotspot: 2 new changesets
Message-ID: <20130424202202.94A2748594@hg.openjdk.java.net>

Changeset: 8cce6cd64aac
Author:    hseigel
Date:      2013-04-24 13:32 -0400
URL:       http://hg.openjdk.java.net/hsx/hsx24/hotspot/rev/8cce6cd64aac

8009928: PSR:PERF Increase default string table size
Summary: Increase default string table size to 60013 for 64-bit platforms.
Reviewed-by: coleenp, dholmes

! src/share/vm/runtime/globals.hpp

Changeset: ab40cf42161d
Author:    hseigel
Date:      2013-04-24 13:59 -0400
URL:       http://hg.openjdk.java.net/hsx/hsx24/hotspot/rev/ab40cf42161d

Merge

- test/runtime/NMT/AllocTestType.java


From jesper.wilhelmsson at oracle.com  Thu Apr 25 06:52:37 2013
From: jesper.wilhelmsson at oracle.com (Jesper Wilhelmsson)
Date: Thu, 25 Apr 2013 15:52:37 +0200
Subject: RFR: Project files for Solaris Studio / NetBeans
In-Reply-To: <51531883.7070903@oracle.com>
References: <51507B60.6030809@oracle.com> <51531883.7070903@oracle.com>
Message-ID: <51793525.1050108@oracle.com>

Hi,

A new version of the project files are now available:

http://cr.openjdk.java.net/~jwilhelm/7074926/webrev.4/

A new platform was added, we now support Mac, Linux and Solaris.

The project was moved to /common/nb_native/nbproject/ to clearly indicate that 
this project only indexes the C++ part of OpenJDK.

Thanks for everyones comments!
/Jesper


Jesper Wilhelmsson skrev 27/3/13 5:04 PM:
> Hi,
>
> A new webrev is now available. The issues reported from the first review should
> be fixed and the project now contains configurations for both Linux_64 and Mac_64.
>
> To select configuration there is a dropdown menu next to the build button.
>
> http://cr.openjdk.java.net/~jwilhelm/7074926/webrev.2/
>
> Thanks,
> /Jesper
>
>
> Jesper Wilhelmsson skrev 25/3/13 5:29 PM:
>> Hi,
>>
>> Sorry for cross posting, but I think this could be useful for several areas.
>>
>> I would like to add Solaris Studio / NetBeans project files for the entire
>> OpenJDK project. To clarify: One project that contains the entire OpenJDK.
>>
>>
>> With the new build infrastructure in JDK 8 building the entire OpenJDK is fairly
>> fast and even though I personally mostly work in the HotSpot tree, I tend to
>> always clone and build the entire JDK forest. I find this to have several
>> benefits.
>>
>> Webrev: http://cr.openjdk.java.net/~jwilhelm/7074926/webrev/
>>
>> The configuration in this project is currently Mac only. Linux and Solaris
>> configurations are also planned.
>>
>> The webrev is made from the jdk8/build repository which is where I think a
>> change like this should go in. Let me know if you think something else.
>>
>>
>>
>> To use this project (once pushed):
>>
>> 1. Clone your favorite repository
>>     hg clone http://hg.openjdk.java.net/hsx/hotspot-gc
>>
>> 2. Get the whole forest
>>     cd hotspot-gc
>>     sh get_source.sh
>>
>> 3. Configure
>>     sh configure
>>
>> 4. Open Solaris studio / NetBeans and load the project.
>>     The project in located in the common directory.
>>
>>
>> Thanks,
>> /Jesper

From zhengyu.gu at oracle.com  Thu Apr 25 11:18:37 2013
From: zhengyu.gu at oracle.com (Zhengyu Gu)
Date: Thu, 25 Apr 2013 14:18:37 -0400
Subject: RFR: 8013120 NMT: Kitchensink crashes with assert(next_region ==
	NULL || !next_region->is_committed_region()) failed: Sanity check
Message-ID: <5179737D.7070800@oracle.com>

NMT expects all committed regions are uncommitted before the whole 
reserved region can be released. It was the case until 8011268.

This change allows NMT to handle the scenario that virtual memory is 
being released while there are committed segments within the reserved 
region.

It also fixed a missing virtual memory tag when ArrayAllocator allocates 
from virtual memory.

Bug: http://bugs.sun.com/view_bug.do?bug_id=8013120
Webrev: http://cr.openjdk.java.net/~zgu/8013120/webrev.00/ 


Thanks,

-Zhengyu

From alejandro.murillo at oracle.com  Thu Apr 25 13:02:14 2013
From: alejandro.murillo at oracle.com (alejandro.murillo at oracle.com)
Date: Thu, 25 Apr 2013 20:02:14 +0000
Subject: hg: hsx/hsx24/hotspot: 46 new changesets
Message-ID: <20130425200346.DA26B485DA@hg.openjdk.java.net>

Changeset: 315b54ddd99f
Author:    katleman
Date:      2013-02-07 14:20 -0800
URL:       http://hg.openjdk.java.net/hsx/hsx24/hotspot/rev/315b54ddd99f

Added tag jdk7u21-b01 for changeset be57a8d7a1a7

! .hgtags

Changeset: 5119d89c7cc8
Author:    ewendeli
Date:      2013-02-11 21:07 +0100
URL:       http://hg.openjdk.java.net/hsx/hsx24/hotspot/rev/5119d89c7cc8

Merge

! .hgtags

Changeset: ad14169fb640
Author:    katleman
Date:      2013-02-14 14:11 -0800
URL:       http://hg.openjdk.java.net/hsx/hsx24/hotspot/rev/ad14169fb640

Added tag jdk7u21-b02 for changeset 5119d89c7cc8

! .hgtags

Changeset: 6d21458b9459
Author:    katleman
Date:      2013-02-19 17:13 -0800
URL:       http://hg.openjdk.java.net/hsx/hsx24/hotspot/rev/6d21458b9459

Added tag jdk7u21-b03 for changeset ad14169fb640

! .hgtags

Changeset: c954aab38a7f
Author:    twisti
Date:      2013-02-25 11:54 -0800
URL:       http://hg.openjdk.java.net/hsx/hsx24/hotspot/rev/c954aab38a7f

8004336: Better handling of method handle intrinsic frames
Reviewed-by: kvn, jrose, ahgross

! src/share/vm/opto/library_call.cpp

Changeset: 762ad80022d6
Author:    katleman
Date:      2013-02-26 12:44 -0800
URL:       http://hg.openjdk.java.net/hsx/hsx24/hotspot/rev/762ad80022d6

Added tag jdk7u21-b04 for changeset c954aab38a7f

! .hgtags

Changeset: 0785ff7bd741
Author:    dcubed
Date:      2013-02-28 09:50 -0800
URL:       http://hg.openjdk.java.net/hsx/hsx24/hotspot/rev/0785ff7bd741

7182152: Instrumentation hot swap test incorrect monitor count
Summary: Remove optimization that allowed for old and/or obsolete methods in an itable; add new tracing support using -XX:TraceRedefineClasses=16384.
Reviewed-by: coleenp, acorn, sspitsyn

! src/share/vm/oops/cpCacheOop.cpp
! src/share/vm/oops/cpCacheOop.hpp
! src/share/vm/oops/klassVtable.cpp
! src/share/vm/oops/klassVtable.hpp
! src/share/vm/oops/methodOop.cpp
! src/share/vm/oops/methodOop.hpp
! src/share/vm/prims/jvmtiRedefineClasses.cpp
! src/share/vm/prims/jvmtiRedefineClasses.hpp
! src/share/vm/prims/jvmtiRedefineClassesTrace.hpp
! src/share/vm/utilities/accessFlags.cpp
! src/share/vm/utilities/accessFlags.hpp

Changeset: e629a7d0b760
Author:    brutisso
Date:      2013-02-28 13:30 +0100
URL:       http://hg.openjdk.java.net/hsx/hsx24/hotspot/rev/e629a7d0b760

7173959: Jvm crashed during coherence exabus (tmb) testing
Summary: Mapping of aligned memory needs to be MT safe. Also reviewed by: vitalyd at gmail.com
Reviewed-by: dholmes, coleenp, zgu

! src/os/posix/vm/os_posix.cpp
! src/os/windows/vm/os_windows.cpp
! src/share/vm/runtime/os.hpp
! src/share/vm/runtime/virtualspace.cpp

Changeset: bc3dc90c4e9e
Author:    coffeys
Date:      2013-03-04 19:04 +0000
URL:       http://hg.openjdk.java.net/hsx/hsx24/hotspot/rev/bc3dc90c4e9e

8009399: Bump the hsx build number for APRIL CPU
Reviewed-by: asaha

! make/hotspot_version

Changeset: ea83168282c8
Author:    katleman
Date:      2012-10-16 14:54 -0700
URL:       http://hg.openjdk.java.net/hsx/hsx24/hotspot/rev/ea83168282c8

Added tag jdk7u9-b31 for changeset 8eaa45ed5f80

! .hgtags

Changeset: f493d194db95
Author:    katleman
Date:      2012-10-31 10:10 -0700
URL:       http://hg.openjdk.java.net/hsx/hsx24/hotspot/rev/f493d194db95

Added tag jdk7u9-b32 for changeset ea83168282c8

! .hgtags

Changeset: 63e9e76073fb
Author:    asaha
Date:      2012-12-04 11:41 -0800
URL:       http://hg.openjdk.java.net/hsx/hsx24/hotspot/rev/63e9e76073fb

Merge

! .hgtags

Changeset: 07f7daeb2610
Author:    asaha
Date:      2012-12-05 15:24 -0800
URL:       http://hg.openjdk.java.net/hsx/hsx24/hotspot/rev/07f7daeb2610

Merge

! .hgtags

Changeset: c49afcd4b4d1
Author:    katleman
Date:      2012-12-07 08:19 -0800
URL:       http://hg.openjdk.java.net/hsx/hsx24/hotspot/rev/c49afcd4b4d1

Added tag jdk7u10-b31 for changeset 07f7daeb2610

! .hgtags

Changeset: 06b5c3f663b8
Author:    ewendeli
Date:      2013-01-15 08:21 +0100
URL:       http://hg.openjdk.java.net/hsx/hsx24/hotspot/rev/06b5c3f663b8

Merge

! .hgtags

Changeset: abb5b690122c
Author:    katleman
Date:      2013-01-16 13:57 -0800
URL:       http://hg.openjdk.java.net/hsx/hsx24/hotspot/rev/abb5b690122c

Added tag jdk7u11-b32 for changeset 06b5c3f663b8

! .hgtags

Changeset: 3ba8b2780ac9
Author:    katleman
Date:      2013-01-29 14:10 -0800
URL:       http://hg.openjdk.java.net/hsx/hsx24/hotspot/rev/3ba8b2780ac9

Added tag jdk7u11-b33 for changeset abb5b690122c

! .hgtags

Changeset: ef00fdf6f6d3
Author:    asaha
Date:      2013-02-08 19:11 -0800
URL:       http://hg.openjdk.java.net/hsx/hsx24/hotspot/rev/ef00fdf6f6d3

Merge

! .hgtags

Changeset: 0b905a04f573
Author:    asaha
Date:      2013-02-11 11:14 -0800
URL:       http://hg.openjdk.java.net/hsx/hsx24/hotspot/rev/0b905a04f573

Merge

! .hgtags

Changeset: 7b91b50ff761
Author:    katleman
Date:      2013-02-12 12:32 -0800
URL:       http://hg.openjdk.java.net/hsx/hsx24/hotspot/rev/7b91b50ff761

Added tag jdk7u15-b31 for changeset 0b905a04f573

! .hgtags

Changeset: 8b349f332a66
Author:    asaha
Date:      2013-02-14 13:18 -0800
URL:       http://hg.openjdk.java.net/hsx/hsx24/hotspot/rev/8b349f332a66

Merge

! .hgtags

Changeset: b2208bb3e775
Author:    katleman
Date:      2013-02-19 12:02 -0800
URL:       http://hg.openjdk.java.net/hsx/hsx24/hotspot/rev/b2208bb3e775

Added tag jdk7u15-b33 for changeset 8b349f332a66

! .hgtags

Changeset: c91d130b040f
Author:    asaha
Date:      2013-03-01 16:07 -0800
URL:       http://hg.openjdk.java.net/hsx/hsx24/hotspot/rev/c91d130b040f

Merge

! .hgtags

Changeset: 73894d544edd
Author:    cl
Date:      2013-03-02 09:47 -0800
URL:       http://hg.openjdk.java.net/hsx/hsx24/hotspot/rev/73894d544edd

Added tag jdk7u17-b30 for changeset 7b357c079370

! .hgtags

Changeset: 22b6fd616cfe
Author:    asaha
Date:      2013-03-02 14:35 -0800
URL:       http://hg.openjdk.java.net/hsx/hsx24/hotspot/rev/22b6fd616cfe

Merge

! .hgtags

Changeset: 8e04b403f580
Author:    cl
Date:      2013-03-02 18:54 -0800
URL:       http://hg.openjdk.java.net/hsx/hsx24/hotspot/rev/8e04b403f580

Added tag jdk7u17-b31 for changeset 22b6fd616cfe

! .hgtags

Changeset: ee98e8e35da2
Author:    asaha
Date:      2013-03-04 11:40 -0800
URL:       http://hg.openjdk.java.net/hsx/hsx24/hotspot/rev/ee98e8e35da2

Merge

! .hgtags

Changeset: 0e8e9d990d91
Author:    asaha
Date:      2013-03-04 12:34 -0800
URL:       http://hg.openjdk.java.net/hsx/hsx24/hotspot/rev/0e8e9d990d91

Merge


Changeset: ae7be9b23555
Author:    katleman
Date:      2013-03-05 16:45 -0800
URL:       http://hg.openjdk.java.net/hsx/hsx24/hotspot/rev/ae7be9b23555

Added tag jdk7u21-b05 for changeset 0e8e9d990d91

! .hgtags

Changeset: beeb3d6b76f0
Author:    poonam
Date:      2013-03-06 16:30 -0800
URL:       http://hg.openjdk.java.net/hsx/hsx24/hotspot/rev/beeb3d6b76f0

8006309: More reliable control panel operation
Summary: Added a comment in the dead Kernel code
Reviewed-by: ahgross, sla, coleenp

! src/share/vm/runtime/thread.cpp

Changeset: 99d7e552509d
Author:    katleman
Date:      2013-03-12 14:44 -0700
URL:       http://hg.openjdk.java.net/hsx/hsx24/hotspot/rev/99d7e552509d

Added tag jdk7u21-b06 for changeset beeb3d6b76f0

! .hgtags

Changeset: 663b5c744e82
Author:    kvn
Date:      2013-03-15 09:33 -0700
URL:       http://hg.openjdk.java.net/hsx/hsx24/hotspot/rev/663b5c744e82

8009699: Methodhandle lookup
Reviewed-by: ahgross, jrose, jdn

! src/share/vm/prims/methodHandles.cpp

Changeset: 87e9bb582938
Author:    katleman
Date:      2013-03-19 14:33 -0700
URL:       http://hg.openjdk.java.net/hsx/hsx24/hotspot/rev/87e9bb582938

Added tag jdk7u21-b07 for changeset 663b5c744e82

! .hgtags

Changeset: 1f195ee7856a
Author:    katleman
Date:      2013-03-20 14:47 -0700
URL:       http://hg.openjdk.java.net/hsx/hsx24/hotspot/rev/1f195ee7856a

Added tag jdk7u21-b08 for changeset 87e9bb582938

! .hgtags

Changeset: d4a4c2bd389a
Author:    katleman
Date:      2013-03-26 15:00 -0700
URL:       http://hg.openjdk.java.net/hsx/hsx24/hotspot/rev/d4a4c2bd389a

Added tag jdk7u21-b09 for changeset 1f195ee7856a

! .hgtags

Changeset: d07dafb51e1d
Author:    katleman
Date:      2013-03-31 03:46 -0700
URL:       http://hg.openjdk.java.net/hsx/hsx24/hotspot/rev/d07dafb51e1d

Added tag jdk7u21-b10 for changeset d4a4c2bd389a

! .hgtags

Changeset: a977dedec81c
Author:    katleman
Date:      2013-04-04 15:48 -0700
URL:       http://hg.openjdk.java.net/hsx/hsx24/hotspot/rev/a977dedec81c

Added tag jdk7u21-b11 for changeset d07dafb51e1d

! .hgtags

Changeset: c5e4585a045f
Author:    katleman
Date:      2013-04-05 12:48 -0700
URL:       http://hg.openjdk.java.net/hsx/hsx24/hotspot/rev/c5e4585a045f

Added tag jdk7u21-b30 for changeset a977dedec81c

! .hgtags

Changeset: 7d126c8298e7
Author:    katleman
Date:      2013-04-07 16:34 -0700
URL:       http://hg.openjdk.java.net/hsx/hsx24/hotspot/rev/7d126c8298e7

Added tag jdk7u21-b12 for changeset c5e4585a045f

! .hgtags

Changeset: 5db4eda6f534
Author:    coffeys
Date:      2013-04-16 11:49 +0100
URL:       http://hg.openjdk.java.net/hsx/hsx24/hotspot/rev/5db4eda6f534

Merge

! .hgtags
! make/hotspot_version
! src/os/posix/vm/os_posix.cpp
! src/os/windows/vm/os_windows.cpp
! src/share/vm/oops/cpCacheOop.cpp
! src/share/vm/oops/cpCacheOop.hpp
! src/share/vm/oops/methodOop.cpp
! src/share/vm/oops/methodOop.hpp
! src/share/vm/opto/library_call.cpp
! src/share/vm/prims/jvmtiRedefineClasses.cpp
! src/share/vm/prims/methodHandles.cpp
! src/share/vm/runtime/os.hpp
! src/share/vm/runtime/thread.cpp
! src/share/vm/runtime/virtualspace.cpp
! src/share/vm/utilities/accessFlags.hpp

Changeset: 7f17b162e053
Author:    coffeys
Date:      2013-04-17 09:40 +0100
URL:       http://hg.openjdk.java.net/hsx/hsx24/hotspot/rev/7f17b162e053

Merge

! .hgtags
- make/bsd/makefiles/wb.make
! make/hotspot_version
- make/linux/makefiles/wb.make
- make/solaris/makefiles/wb.make
- make/windows/makefiles/wb.make
- make/windows/projectfiles/kernel/Makefile
- make/windows/projectfiles/kernel/vm.def
- make/windows/projectfiles/kernel/vm.dsw
- src/share/tools/whitebox/sun/hotspot/WhiteBox.java
- src/share/tools/whitebox/sun/hotspot/parser/DiagnosticCommand.java

Changeset: 6e999fc47427
Author:    lana
Date:      2013-04-18 14:32 -0700
URL:       http://hg.openjdk.java.net/hsx/hsx24/hotspot/rev/6e999fc47427

Merge

! .hgtags

Changeset: aa9a5e33e823
Author:    amurillo
Date:      2013-04-23 13:58 -0700
URL:       http://hg.openjdk.java.net/hsx/hsx24/hotspot/rev/aa9a5e33e823

Merge

! .hgtags
! make/hotspot_version

Changeset: e0f1aa072185
Author:    katleman
Date:      2013-04-24 12:20 -0700
URL:       http://hg.openjdk.java.net/hsx/hsx24/hotspot/rev/e0f1aa072185

Added tag jdk7u14-b22 for changeset aa9a5e33e823

! .hgtags

Changeset: 482ff4e18ca3
Author:    amurillo
Date:      2013-04-25 08:49 -0700
URL:       http://hg.openjdk.java.net/hsx/hsx24/hotspot/rev/482ff4e18ca3

Merge

! make/hotspot_version
- test/runtime/NMT/AllocTestType.java

Changeset: 34a398422e59
Author:    amurillo
Date:      2013-04-25 08:49 -0700
URL:       http://hg.openjdk.java.net/hsx/hsx24/hotspot/rev/34a398422e59

Added tag hs24-b42 for changeset 482ff4e18ca3

! .hgtags


From zhengyu.gu at oracle.com  Thu Apr 25 13:23:22 2013
From: zhengyu.gu at oracle.com (Zhengyu Gu)
Date: Thu, 25 Apr 2013 16:23:22 -0400
Subject: RFR: 8013120 NMT: Kitchensink crashes with assert(next_region
	== NULL || !next_region->is_committed_region()) failed: Sanity check
In-Reply-To: <5179737D.7070800@oracle.com>
References: <5179737D.7070800@oracle.com>
Message-ID: <517990BA.2000907@oracle.com>


Updated webrev to include regression test: 
http://cr.openjdk.java.net/~zgu/8013120/webrev.01/ 


Thanks Christian for writing the test.

-Zhengyu


On 4/25/2013 2:18 PM, Zhengyu Gu wrote:
> NMT expects all committed regions are uncommitted before the whole 
> reserved region can be released. It was the case until 8011268.
>
> This change allows NMT to handle the scenario that virtual memory is 
> being released while there are committed segments within the reserved 
> region.
>
> It also fixed a missing virtual memory tag when ArrayAllocator 
> allocates from virtual memory.
>
> Bug: http://bugs.sun.com/view_bug.do?bug_id=8013120
> Webrev: http://cr.openjdk.java.net/~zgu/8013120/webrev.00/ 
> 
>
> Thanks,
>
> -Zhengyu


From christian.tornqvist at oracle.com  Thu Apr 25 13:31:33 2013
From: christian.tornqvist at oracle.com (Christian Tornqvist)
Date: Thu, 25 Apr 2013 16:31:33 -0400
Subject: RFR: 8013120 NMT: Kitchensink crashes with assert(next_region ==
	NULL || !next_region->is_committed_region()) failed: Sanity check
In-Reply-To: <517990BA.2000907@oracle.com>
References: <5179737D.7070800@oracle.com> <517990BA.2000907@oracle.com>
Message-ID: <02c901ce41f3$e09dcf20$a1d96d60$@tornqvist@oracle.com>

Hi Zhengyu,

The test should be placed in test/runtime/NMT together with the other NMT tests :)

Thanks,
Christian

-----Original Message-----
From: Zhengyu Gu [mailto:zhengyu.gu at oracle.com] 
Sent: den 25 april 2013 16:23
To: hotspot-dev at openjdk.java.net
Cc: Christian T?rnqvist
Subject: Re: RFR: 8013120 NMT: Kitchensink crashes with assert(next_region == NULL || !next_region->is_committed_region()) failed: Sanity check


Updated webrev to include regression test: 
http://cr.openjdk.java.net/~zgu/8013120/webrev.01/


Thanks Christian for writing the test.

-Zhengyu


On 4/25/2013 2:18 PM, Zhengyu Gu wrote:
> NMT expects all committed regions are uncommitted before the whole 
> reserved region can be released. It was the case until 8011268.
>
> This change allows NMT to handle the scenario that virtual memory is 
> being released while there are committed segments within the reserved 
> region.
>
> It also fixed a missing virtual memory tag when ArrayAllocator 
> allocates from virtual memory.
>
> Bug: http://bugs.sun.com/view_bug.do?bug_id=8013120
> Webrev: http://cr.openjdk.java.net/~zgu/8013120/webrev.00/
> 
>
> Thanks,
>
> -Zhengyu



From zhengyu.gu at oracle.com  Thu Apr 25 13:47:29 2013
From: zhengyu.gu at oracle.com (Zhengyu Gu)
Date: Thu, 25 Apr 2013 16:47:29 -0400
Subject: RFR: 8013120 NMT: Kitchensink crashes with assert(next_region
	== NULL || !next_region->is_committed_region()) failed: Sanity check
In-Reply-To: <02c901ce41f3$e09dcf20$a1d96d60$@tornqvist@oracle.com>
References: <5179737D.7070800@oracle.com> <517990BA.2000907@oracle.com>
	<02c901ce41f3$e09dcf20$a1d96d60$@tornqvist@oracle.com>
Message-ID: <51799661.7070105@oracle.com>

OK, I will move the test before check in.

Thanks,

-Zhengyu

On 4/25/2013 4:31 PM, Christian Tornqvist wrote:
> Hi Zhengyu,
>
> The test should be placed in test/runtime/NMT together with the other NMT tests :)
>
> Thanks,
> Christian
>
> -----Original Message-----
> From: Zhengyu Gu [mailto:zhengyu.gu at oracle.com]
> Sent: den 25 april 2013 16:23
> To: hotspot-dev at openjdk.java.net
> Cc: Christian T?rnqvist
> Subject: Re: RFR: 8013120 NMT: Kitchensink crashes with assert(next_region == NULL || !next_region->is_committed_region()) failed: Sanity check
>
>
> Updated webrev to include regression test:
> http://cr.openjdk.java.net/~zgu/8013120/webrev.01/
> 
>
> Thanks Christian for writing the test.
>
> -Zhengyu
>
>
> On 4/25/2013 2:18 PM, Zhengyu Gu wrote:
>> NMT expects all committed regions are uncommitted before the whole
>> reserved region can be released. It was the case until 8011268.
>>
>> This change allows NMT to handle the scenario that virtual memory is
>> being released while there are committed segments within the reserved
>> region.
>>
>> It also fixed a missing virtual memory tag when ArrayAllocator
>> allocates from virtual memory.
>>
>> Bug: http://bugs.sun.com/view_bug.do?bug_id=8013120
>> Webrev: http://cr.openjdk.java.net/~zgu/8013120/webrev.00/
>> 
>>
>> Thanks,
>>
>> -Zhengyu
>


From alejandro.murillo at oracle.com  Thu Apr 25 20:25:59 2013
From: alejandro.murillo at oracle.com (alejandro.murillo at oracle.com)
Date: Fri, 26 Apr 2013 03:25:59 +0000
Subject: hg: hsx/hsx24/hotspot: 8013226: new hotspot build - hs24-b43
Message-ID: <20130426032606.4F45D485EB@hg.openjdk.java.net>

Changeset: 5a8de8ed7e83
Author:    amurillo
Date:      2013-04-25 08:59 -0700
URL:       http://hg.openjdk.java.net/hsx/hsx24/hotspot/rev/5a8de8ed7e83

8013226: new hotspot build - hs24-b43
Reviewed-by: jcoomes

! make/hotspot_version


From john.cuthbertson at oracle.com  Thu Apr 25 20:52:54 2013
From: john.cuthbertson at oracle.com (john.cuthbertson at oracle.com)
Date: Fri, 26 Apr 2013 03:52:54 +0000
Subject: hg: hsx/hsx24/hotspot: 2 new changesets
Message-ID: <20130426035301.6577A485F5@hg.openjdk.java.net>

Changeset: c4b5ad1ab409
Author:    johnc
Date:      2013-04-22 16:29 -0700
URL:       http://hg.openjdk.java.net/hsx/hsx24/hotspot/rev/c4b5ad1ab409

8007036: G1: Too many old regions added to last mixed GC
Summary: Stop adding old regions to collection set when the remaining reclaimable bytes reaches, or goes below, G1HeapWastePercent. Changes were also reviewed by Vitaly Davidovich .
Reviewed-by: brutisso, tschatzl, jmasa

! src/share/vm/gc_implementation/g1/collectionSetChooser.cpp
! src/share/vm/gc_implementation/g1/collectionSetChooser.hpp
! src/share/vm/gc_implementation/g1/g1CollectorPolicy.cpp
! src/share/vm/gc_implementation/g1/g1CollectorPolicy.hpp

Changeset: dc53b30aa2e1
Author:    johnc
Date:      2013-04-25 20:36 -0700
URL:       http://hg.openjdk.java.net/hsx/hsx24/hotspot/rev/dc53b30aa2e1

Merge



From bharadwaj.yadavalli at oracle.com  Fri Apr 26 00:17:01 2013
From: bharadwaj.yadavalli at oracle.com (bharadwaj.yadavalli at oracle.com)
Date: Fri, 26 Apr 2013 07:17:01 +0000
Subject: hg: hsx/hotspot-main/hotspot: 4 new changesets
Message-ID: <20130426071713.3C9B5485FF@hg.openjdk.java.net>

Changeset: 35c15dad89ea
Author:    roland
Date:      2013-04-16 17:06 +0200
URL:       http://hg.openjdk.java.net/hsx/hotspot-main/hotspot/rev/35c15dad89ea

8011901: Unsafe.getAndAddLong(obj, off, delta) does not work properly with long deltas
Summary: instruct xaddL_no_res shouldn't allow 64 bit constants.
Reviewed-by: kvn

! src/cpu/x86/vm/x86_64.ad
+ test/compiler/8011901/Test8011901.java

Changeset: 6a3629cf7075
Author:    roland
Date:      2013-04-24 09:42 +0200
URL:       http://hg.openjdk.java.net/hsx/hotspot-main/hotspot/rev/6a3629cf7075

8011771: runThese crashed with EAV
Summary: Array bound check elimination's in block motion doesn't always reset its data structures from one step to the other.
Reviewed-by: kvn, twisti

! src/share/vm/c1/c1_RangeCheckElimination.cpp

Changeset: 47766e2d2527
Author:    jiangli
Date:      2013-04-24 18:20 -0400
URL:       http://hg.openjdk.java.net/hsx/hotspot-main/hotspot/rev/47766e2d2527

8013041: guarantee(this->is8bit(imm8)) failed: Short forward jump exceeds 8-bit offset.
Summary: Change jmpb() to jmp().
Reviewed-by: coleenp, rdurbin, dcubed

! src/cpu/x86/vm/templateInterpreter_x86_32.cpp
! src/cpu/x86/vm/templateInterpreter_x86_64.cpp

Changeset: e8a7a5995e65
Author:    bharadwaj
Date:      2013-04-25 13:10 -0700
URL:       http://hg.openjdk.java.net/hsx/hotspot-main/hotspot/rev/e8a7a5995e65

Merge



From john.coomes at oracle.com  Fri Apr 26 01:35:27 2013
From: john.coomes at oracle.com (john.coomes at oracle.com)
Date: Fri, 26 Apr 2013 08:35:27 +0000
Subject: hg: hsx/hotspot-main: 6 new changesets
Message-ID: <20130426083528.357A248605@hg.openjdk.java.net>

Changeset: 7da551071fe8
Author:    lana
Date:      2013-04-11 19:13 -0700
URL:       http://hg.openjdk.java.net/hsx/hotspot-main/rev/7da551071fe8

Merge

! common/makefiles/Main.gmk

Changeset: b95c5c8ee60a
Author:    jgish
Date:      2013-04-16 13:25 -0400
URL:       http://hg.openjdk.java.net/hsx/hotspot-main/rev/b95c5c8ee60a

8011347: JKD-8009824 has broken webrev with some ksh versions
Reviewed-by: mduigou

! make/scripts/webrev.ksh

Changeset: 2600c8d8b619
Author:    lana
Date:      2013-04-17 10:05 -0700
URL:       http://hg.openjdk.java.net/hsx/hotspot-main/rev/2600c8d8b619

Merge


Changeset: 238b28991d66
Author:    lana
Date:      2013-04-17 21:32 -0700
URL:       http://hg.openjdk.java.net/hsx/hotspot-main/rev/238b28991d66

Merge


Changeset: b9415faa7066
Author:    lana
Date:      2013-04-23 09:26 -0700
URL:       http://hg.openjdk.java.net/hsx/hotspot-main/rev/b9415faa7066

Merge


Changeset: c29b583938b1
Author:    katleman
Date:      2013-04-25 09:23 -0700
URL:       http://hg.openjdk.java.net/hsx/hotspot-main/rev/c29b583938b1

Added tag jdk8-b87 for changeset b9415faa7066

! .hgtags


From john.coomes at oracle.com  Fri Apr 26 01:35:49 2013
From: john.coomes at oracle.com (john.coomes at oracle.com)
Date: Fri, 26 Apr 2013 08:35:49 +0000
Subject: hg: hsx/hotspot-main/jaxp: 4 new changesets
Message-ID: <20130426083612.59CD848607@hg.openjdk.java.net>

Changeset: 10db50a26b39
Author:    joehw
Date:      2013-02-18 11:33 -0800
URL:       http://hg.openjdk.java.net/hsx/hotspot-main/jaxp/rev/10db50a26b39

6657673: Issues with JAXP
Reviewed-by: alanb, lancea, ahgross, mullan

! src/com/sun/org/apache/bcel/internal/classfile/JavaClass.java
! src/com/sun/org/apache/bcel/internal/util/Class2HTML.java
! src/com/sun/org/apache/bcel/internal/util/ClassPath.java
! src/com/sun/org/apache/bcel/internal/util/JavaWrapper.java
+ src/com/sun/org/apache/bcel/internal/util/SecuritySupport.java
! src/com/sun/org/apache/xalan/internal/res/XSLMessages.java
! src/com/sun/org/apache/xalan/internal/res/XSLTErrorResources.java
! src/com/sun/org/apache/xalan/internal/res/XSLTErrorResources_de.java
! src/com/sun/org/apache/xalan/internal/res/XSLTErrorResources_es.java
! src/com/sun/org/apache/xalan/internal/res/XSLTErrorResources_fr.java
! src/com/sun/org/apache/xalan/internal/res/XSLTErrorResources_it.java
! src/com/sun/org/apache/xalan/internal/res/XSLTErrorResources_ja.java
! src/com/sun/org/apache/xalan/internal/res/XSLTErrorResources_ko.java
! src/com/sun/org/apache/xalan/internal/res/XSLTErrorResources_pt_BR.java
! src/com/sun/org/apache/xalan/internal/res/XSLTErrorResources_sv.java
! src/com/sun/org/apache/xalan/internal/res/XSLTErrorResources_zh_CN.java
! src/com/sun/org/apache/xalan/internal/res/XSLTErrorResources_zh_TW.java
! src/com/sun/org/apache/xalan/internal/utils/ObjectFactory.java
! src/com/sun/org/apache/xalan/internal/utils/SecuritySupport.java
! src/com/sun/org/apache/xalan/internal/xslt/EnvironmentCheck.java
! src/com/sun/org/apache/xalan/internal/xslt/Process.java
! src/com/sun/org/apache/xalan/internal/xsltc/compiler/Parser.java
! src/com/sun/org/apache/xalan/internal/xsltc/compiler/XSLTC.java
! src/com/sun/org/apache/xalan/internal/xsltc/compiler/util/ErrorMessages.java
! src/com/sun/org/apache/xalan/internal/xsltc/compiler/util/ErrorMsg.java
! src/com/sun/org/apache/xalan/internal/xsltc/compiler/util/Util.java
! src/com/sun/org/apache/xalan/internal/xsltc/dom/NodeSortRecord.java
! src/com/sun/org/apache/xalan/internal/xsltc/runtime/BasisLibrary.java
! src/com/sun/org/apache/xalan/internal/xsltc/runtime/output/WriterOutputBuffer.java
! src/com/sun/org/apache/xalan/internal/xsltc/trax/TemplatesImpl.java
! src/com/sun/org/apache/xalan/internal/xsltc/trax/TransformerFactoryImpl.java
! src/com/sun/org/apache/xerces/internal/dom/DOMMessageFormatter.java
! src/com/sun/org/apache/xerces/internal/impl/XMLEntityManager.java
! src/com/sun/org/apache/xerces/internal/impl/dv/DatatypeException.java
! src/com/sun/org/apache/xerces/internal/impl/msg/XMLMessageFormatter.java
! src/com/sun/org/apache/xerces/internal/impl/msg/XMLMessageFormatter_de.java
! src/com/sun/org/apache/xerces/internal/impl/msg/XMLMessageFormatter_es.java
! src/com/sun/org/apache/xerces/internal/impl/msg/XMLMessageFormatter_fr.java
! src/com/sun/org/apache/xerces/internal/impl/msg/XMLMessageFormatter_it.java
! src/com/sun/org/apache/xerces/internal/impl/msg/XMLMessageFormatter_ja.java
! src/com/sun/org/apache/xerces/internal/impl/msg/XMLMessageFormatter_ko.java
! src/com/sun/org/apache/xerces/internal/impl/msg/XMLMessageFormatter_pt_BR.java
! src/com/sun/org/apache/xerces/internal/impl/msg/XMLMessageFormatter_sv.java
! src/com/sun/org/apache/xerces/internal/impl/msg/XMLMessageFormatter_zh_CN.java
! src/com/sun/org/apache/xerces/internal/impl/msg/XMLMessageFormatter_zh_TW.java
! src/com/sun/org/apache/xerces/internal/impl/xpath/regex/RegexParser.java
! src/com/sun/org/apache/xerces/internal/impl/xs/XSMessageFormatter.java
! src/com/sun/org/apache/xerces/internal/jaxp/validation/JAXPValidationMessageFormatter.java
! src/com/sun/org/apache/xerces/internal/util/DatatypeMessageFormatter.java
! src/com/sun/org/apache/xerces/internal/util/SAXMessageFormatter.java
! src/com/sun/org/apache/xerces/internal/util/SecurityManager.java
! src/com/sun/org/apache/xerces/internal/utils/ObjectFactory.java
! src/com/sun/org/apache/xerces/internal/utils/SecuritySupport.java
! src/com/sun/org/apache/xerces/internal/xinclude/XIncludeMessageFormatter.java
! src/com/sun/org/apache/xerces/internal/xpointer/XPointerMessageFormatter.java
! src/com/sun/org/apache/xml/internal/dtm/DTMManager.java
! src/com/sun/org/apache/xml/internal/res/XMLErrorResources.java
! src/com/sun/org/apache/xml/internal/res/XMLErrorResources_ca.java
! src/com/sun/org/apache/xml/internal/res/XMLErrorResources_cs.java
! src/com/sun/org/apache/xml/internal/res/XMLErrorResources_de.java
! src/com/sun/org/apache/xml/internal/res/XMLErrorResources_es.java
! src/com/sun/org/apache/xml/internal/res/XMLErrorResources_fr.java
! src/com/sun/org/apache/xml/internal/res/XMLErrorResources_it.java
! src/com/sun/org/apache/xml/internal/res/XMLErrorResources_ja.java
! src/com/sun/org/apache/xml/internal/res/XMLErrorResources_ko.java
! src/com/sun/org/apache/xml/internal/res/XMLErrorResources_pt_BR.java
! src/com/sun/org/apache/xml/internal/res/XMLErrorResources_sk.java
! src/com/sun/org/apache/xml/internal/res/XMLErrorResources_sv.java
! src/com/sun/org/apache/xml/internal/res/XMLErrorResources_tr.java
! src/com/sun/org/apache/xml/internal/res/XMLErrorResources_zh_CN.java
! src/com/sun/org/apache/xml/internal/res/XMLErrorResources_zh_TW.java
! src/com/sun/org/apache/xml/internal/res/XMLMessages.java
! src/com/sun/org/apache/xml/internal/resolver/Catalog.java
! src/com/sun/org/apache/xml/internal/resolver/CatalogManager.java
! src/com/sun/org/apache/xml/internal/resolver/Resolver.java
! src/com/sun/org/apache/xml/internal/serialize/SerializerFactory.java
! src/com/sun/org/apache/xml/internal/serializer/Encodings.java
! src/com/sun/org/apache/xml/internal/serializer/OutputPropertiesFactory.java
! src/com/sun/org/apache/xml/internal/serializer/ToStream.java
! src/com/sun/org/apache/xml/internal/serializer/TreeWalker.java
! src/com/sun/org/apache/xml/internal/serializer/utils/Messages.java
! src/com/sun/org/apache/xml/internal/utils/TreeWalker.java
! src/com/sun/org/apache/xml/internal/utils/res/XResourceBundle.java
! src/com/sun/org/apache/xpath/internal/functions/FuncSystemProperty.java
! src/com/sun/org/apache/xpath/internal/res/XPATHErrorResources.java
! src/com/sun/org/apache/xpath/internal/res/XPATHErrorResources_de.java
! src/com/sun/org/apache/xpath/internal/res/XPATHErrorResources_es.java
! src/com/sun/org/apache/xpath/internal/res/XPATHErrorResources_fr.java
! src/com/sun/org/apache/xpath/internal/res/XPATHErrorResources_it.java
! src/com/sun/org/apache/xpath/internal/res/XPATHErrorResources_ja.java
! src/com/sun/org/apache/xpath/internal/res/XPATHErrorResources_ko.java
! src/com/sun/org/apache/xpath/internal/res/XPATHErrorResources_pt_BR.java
! src/com/sun/org/apache/xpath/internal/res/XPATHErrorResources_sv.java
! src/com/sun/org/apache/xpath/internal/res/XPATHErrorResources_zh_CN.java
! src/com/sun/org/apache/xpath/internal/res/XPATHErrorResources_zh_TW.java
! src/com/sun/org/apache/xpath/internal/res/XPATHMessages.java
! src/com/sun/xml/internal/stream/XMLEntityStorage.java
! src/com/sun/xml/internal/stream/writers/WriterUtility.java
! src/com/sun/xml/internal/stream/writers/XMLStreamWriterImpl.java
! src/javax/xml/datatype/FactoryFinder.java
! src/javax/xml/parsers/FactoryFinder.java
! src/javax/xml/stream/FactoryFinder.java
! src/javax/xml/transform/FactoryFinder.java
! src/javax/xml/validation/SchemaFactoryFinder.java
! src/javax/xml/xpath/XPathFactoryFinder.java
! src/org/w3c/dom/bootstrap/DOMImplementationRegistry.java
! src/org/xml/sax/helpers/NewInstance.java
! src/org/xml/sax/helpers/ParserAdapter.java
! src/org/xml/sax/helpers/ParserFactory.java
+ src/org/xml/sax/helpers/SecuritySupport.java
! src/org/xml/sax/helpers/XMLReaderFactory.java

Changeset: 3f9817b8b0e0
Author:    chegar
Date:      2013-04-12 10:20 +0100
URL:       http://hg.openjdk.java.net/hsx/hotspot-main/jaxp/rev/3f9817b8b0e0

Merge


Changeset: eddbc8ad2435
Author:    lana
Date:      2013-04-23 09:27 -0700
URL:       http://hg.openjdk.java.net/hsx/hotspot-main/jaxp/rev/eddbc8ad2435

Merge


Changeset: 7122f7bb0fcc
Author:    katleman
Date:      2013-04-25 09:24 -0700
URL:       http://hg.openjdk.java.net/hsx/hotspot-main/jaxp/rev/7122f7bb0fcc

Added tag jdk8-b87 for changeset eddbc8ad2435

! .hgtags


From john.coomes at oracle.com  Fri Apr 26 01:35:33 2013
From: john.coomes at oracle.com (john.coomes at oracle.com)
Date: Fri, 26 Apr 2013 08:35:33 +0000
Subject: hg: hsx/hotspot-main/corba: Added tag jdk8-b87 for changeset
	f1709874d55a
Message-ID: <20130426083538.9419348606@hg.openjdk.java.net>

Changeset: 4e3a881ebb1e
Author:    katleman
Date:      2013-04-25 09:23 -0700
URL:       http://hg.openjdk.java.net/hsx/hotspot-main/corba/rev/4e3a881ebb1e

Added tag jdk8-b87 for changeset f1709874d55a

! .hgtags


From john.coomes at oracle.com  Fri Apr 26 01:36:19 2013
From: john.coomes at oracle.com (john.coomes at oracle.com)
Date: Fri, 26 Apr 2013 08:36:19 +0000
Subject: hg: hsx/hotspot-main/jaxws: 5 new changesets
Message-ID: <20130426083642.1240E48608@hg.openjdk.java.net>

Changeset: 28886cb008bb
Author:    lana
Date:      2013-04-11 19:15 -0700
URL:       http://hg.openjdk.java.net/hsx/hotspot-main/jaxws/rev/28886cb008bb

Merge


Changeset: ebbd87e3a8b2
Author:    lana
Date:      2013-04-17 10:13 -0700
URL:       http://hg.openjdk.java.net/hsx/hotspot-main/jaxws/rev/ebbd87e3a8b2

Merge


Changeset: 9d251e1ec1eb
Author:    lana
Date:      2013-04-23 09:27 -0700
URL:       http://hg.openjdk.java.net/hsx/hotspot-main/jaxws/rev/9d251e1ec1eb

Merge


Changeset: 72e03566f0a6
Author:    katleman
Date:      2013-04-23 18:33 -0700
URL:       http://hg.openjdk.java.net/hsx/hotspot-main/jaxws/rev/72e03566f0a6

8012643: JDK8 b86 source with GPL header errors
Reviewed-by: dholmes, alanb

! src/share/jaxws_classes/com/oracle/webservices/internal/api/EnvelopeStyle.java
! src/share/jaxws_classes/com/oracle/webservices/internal/api/EnvelopeStyleFeature.java
! src/share/jaxws_classes/com/oracle/webservices/internal/api/databinding/Databinding.java
! src/share/jaxws_classes/com/oracle/webservices/internal/api/databinding/DatabindingFactory.java
! src/share/jaxws_classes/com/oracle/webservices/internal/api/databinding/DatabindingMode.java
! src/share/jaxws_classes/com/oracle/webservices/internal/api/databinding/DatabindingModeFeature.java
! src/share/jaxws_classes/com/oracle/webservices/internal/api/databinding/ExternalMetadataFeature.java
! src/share/jaxws_classes/com/oracle/webservices/internal/api/databinding/JavaCallInfo.java
! src/share/jaxws_classes/com/oracle/webservices/internal/api/databinding/WSDLGenerator.java
! src/share/jaxws_classes/com/oracle/webservices/internal/api/databinding/WSDLResolver.java
! src/share/jaxws_classes/com/oracle/webservices/internal/api/message/BaseDistributedPropertySet.java
! src/share/jaxws_classes/com/oracle/webservices/internal/api/message/BasePropertySet.java
! src/share/jaxws_classes/com/oracle/webservices/internal/api/message/ContentType.java
! src/share/jaxws_classes/com/oracle/webservices/internal/api/message/DistributedPropertySet.java
! src/share/jaxws_classes/com/oracle/webservices/internal/api/message/MessageContext.java
! src/share/jaxws_classes/com/oracle/webservices/internal/api/message/MessageContextFactory.java
! src/share/jaxws_classes/com/oracle/webservices/internal/api/message/PropertySet.java
! src/share/jaxws_classes/com/oracle/webservices/internal/api/message/ReadOnlyPropertyException.java
! src/share/jaxws_classes/com/oracle/webservices/internal/impl/encoding/StreamDecoderImpl.java
! src/share/jaxws_classes/com/oracle/webservices/internal/impl/internalspi/encoding/StreamDecoder.java
! src/share/jaxws_classes/com/oracle/xmlns/internal/webservices/jaxws_databinding/ExistingAnnotationsType.java
! src/share/jaxws_classes/com/oracle/xmlns/internal/webservices/jaxws_databinding/JavaMethod.java
! src/share/jaxws_classes/com/oracle/xmlns/internal/webservices/jaxws_databinding/JavaParam.java
! src/share/jaxws_classes/com/oracle/xmlns/internal/webservices/jaxws_databinding/JavaWsdlMappingType.java
! src/share/jaxws_classes/com/oracle/xmlns/internal/webservices/jaxws_databinding/ObjectFactory.java
! src/share/jaxws_classes/com/oracle/xmlns/internal/webservices/jaxws_databinding/SoapBindingParameterStyle.java
! src/share/jaxws_classes/com/oracle/xmlns/internal/webservices/jaxws_databinding/SoapBindingStyle.java
! src/share/jaxws_classes/com/oracle/xmlns/internal/webservices/jaxws_databinding/SoapBindingUse.java
! src/share/jaxws_classes/com/oracle/xmlns/internal/webservices/jaxws_databinding/Util.java
! src/share/jaxws_classes/com/oracle/xmlns/internal/webservices/jaxws_databinding/WebParamMode.java
! src/share/jaxws_classes/com/oracle/xmlns/internal/webservices/jaxws_databinding/XmlAction.java
! src/share/jaxws_classes/com/oracle/xmlns/internal/webservices/jaxws_databinding/XmlAddressing.java
! src/share/jaxws_classes/com/oracle/xmlns/internal/webservices/jaxws_databinding/XmlBindingType.java
! src/share/jaxws_classes/com/oracle/xmlns/internal/webservices/jaxws_databinding/XmlFaultAction.java
! src/share/jaxws_classes/com/oracle/xmlns/internal/webservices/jaxws_databinding/XmlHandlerChain.java
! src/share/jaxws_classes/com/oracle/xmlns/internal/webservices/jaxws_databinding/XmlMTOM.java
! src/share/jaxws_classes/com/oracle/xmlns/internal/webservices/jaxws_databinding/XmlOneway.java
! src/share/jaxws_classes/com/oracle/xmlns/internal/webservices/jaxws_databinding/XmlRequestWrapper.java
! src/share/jaxws_classes/com/oracle/xmlns/internal/webservices/jaxws_databinding/XmlResponseWrapper.java
! src/share/jaxws_classes/com/oracle/xmlns/internal/webservices/jaxws_databinding/XmlSOAPBinding.java
! src/share/jaxws_classes/com/oracle/xmlns/internal/webservices/jaxws_databinding/XmlServiceMode.java
! src/share/jaxws_classes/com/oracle/xmlns/internal/webservices/jaxws_databinding/XmlWebEndpoint.java
! src/share/jaxws_classes/com/oracle/xmlns/internal/webservices/jaxws_databinding/XmlWebFault.java
! src/share/jaxws_classes/com/oracle/xmlns/internal/webservices/jaxws_databinding/XmlWebMethod.java
! src/share/jaxws_classes/com/oracle/xmlns/internal/webservices/jaxws_databinding/XmlWebParam.java
! src/share/jaxws_classes/com/oracle/xmlns/internal/webservices/jaxws_databinding/XmlWebResult.java
! src/share/jaxws_classes/com/oracle/xmlns/internal/webservices/jaxws_databinding/XmlWebService.java
! src/share/jaxws_classes/com/oracle/xmlns/internal/webservices/jaxws_databinding/XmlWebServiceClient.java
! src/share/jaxws_classes/com/oracle/xmlns/internal/webservices/jaxws_databinding/XmlWebServiceProvider.java
! src/share/jaxws_classes/com/oracle/xmlns/internal/webservices/jaxws_databinding/XmlWebServiceRef.java
! src/share/jaxws_classes/com/oracle/xmlns/internal/webservices/jaxws_databinding/package-info.java

Changeset: 24fa5452e5d4
Author:    katleman
Date:      2013-04-25 09:24 -0700
URL:       http://hg.openjdk.java.net/hsx/hotspot-main/jaxws/rev/24fa5452e5d4

Added tag jdk8-b87 for changeset 72e03566f0a6

! .hgtags


From john.coomes at oracle.com  Fri Apr 26 01:40:16 2013
From: john.coomes at oracle.com (john.coomes at oracle.com)
Date: Fri, 26 Apr 2013 08:40:16 +0000
Subject: hg: hsx/hotspot-main/jdk: 101 new changesets
Message-ID: <20130426091959.823C34860B@hg.openjdk.java.net>

Changeset: b59b1f5a98dd
Author:    bae
Date:      2013-04-15 16:57 +0400
URL:       http://hg.openjdk.java.net/hsx/hotspot-main/jdk/rev/b59b1f5a98dd

8005930: [lcms] ColorConvertOp: Alpha channel is not transferred from source to destination.
Reviewed-by: prr

! src/share/classes/sun/java2d/cmm/lcms/LCMSTransform.java
+ test/sun/java2d/cmm/ColorConvertOp/AlphaTest.java

Changeset: 03ee8c648624
Author:    bae
Date:      2013-04-15 18:10 +0400
URL:       http://hg.openjdk.java.net/hsx/hotspot-main/jdk/rev/03ee8c648624

8011622: Use lcms as the default color management module in jdk8
Reviewed-by: prr, vadim

! make/sun/cmm/Makefile
! make/sun/cmm/kcms/Makefile
! make/sun/cmm/lcms/Makefile
! makefiles/CompileNativeLibraries.gmk
! makefiles/CopyIntoClasses.gmk
+ src/share/classes/sun/java2d/cmm/CMMServiceProvider.java
! src/share/classes/sun/java2d/cmm/CMSManager.java
! src/share/classes/sun/java2d/cmm/lcms/LCMS.java
+ src/share/classes/sun/java2d/cmm/lcms/LcmsServiceProvider.java
+ src/share/classes/sun/java2d/cmm/lcms/META-INF/services/sun.java2d.cmm.CMMServiceProvider
- src/share/classes/sun/java2d/cmm/lcms/META-INF/services/sun.java2d.cmm.PCMM

Changeset: 271d5bf7d61f
Author:    lana
Date:      2013-04-17 12:30 -0700
URL:       http://hg.openjdk.java.net/hsx/hotspot-main/jdk/rev/271d5bf7d61f

Merge

! makefiles/CompileNativeLibraries.gmk
! makefiles/CopyIntoClasses.gmk

Changeset: 0799af4553b5
Author:    lana
Date:      2013-04-17 21:30 -0700
URL:       http://hg.openjdk.java.net/hsx/hotspot-main/jdk/rev/0799af4553b5

Merge

- src/share/classes/sun/java2d/cmm/lcms/META-INF/services/sun.java2d.cmm.PCMM

Changeset: d241f117ff46
Author:    malenkov
Date:      2013-04-11 19:12 +0400
URL:       http://hg.openjdk.java.net/hsx/hotspot-main/jdk/rev/d241f117ff46

4683761: Incomplete Introspection on nonpublic classes lead to IllegalAccessExceptions
Reviewed-by: alexsch

! src/share/classes/java/beans/Introspector.java
+ test/java/beans/Introspector/Test4683761.java

Changeset: be89273ceb9c
Author:    pchelko
Date:      2013-04-12 14:09 +0400
URL:       http://hg.openjdk.java.net/hsx/hotspot-main/jdk/rev/be89273ceb9c

8010009: [macosx] Unable type into online word games on MacOSX
Reviewed-by: anthony, dcherepanov

! src/macosx/classes/sun/lwawt/macosx/CEmbeddedFrame.java
! src/macosx/classes/sun/lwawt/macosx/CPlatformResponder.java
! src/macosx/classes/sun/lwawt/macosx/CPlatformView.java
+ test/java/awt/event/KeyEvent/KeyReleasedInAppletTest/KeyReleasedInAppletTest.html
+ test/java/awt/event/KeyEvent/KeyReleasedInAppletTest/KeyReleasedInAppletTest.java
+ test/java/awt/event/KeyEvent/KeyReleasedInAppletTest/TestApplet.java

Changeset: 4490ef60ecd3
Author:    anthony
Date:      2013-04-12 14:33 +0400
URL:       http://hg.openjdk.java.net/hsx/hotspot-main/jdk/rev/4490ef60ecd3

8010297: Missing isLoggable() checks in logging code
Summary: Add isLoggable() checks
Reviewed-by: anthony, mchung, serb
Contributed-by: Laurent Bourges 

! src/macosx/classes/sun/lwawt/LWWindowPeer.java
! src/share/classes/java/awt/ContainerOrderFocusTraversalPolicy.java
! src/share/classes/java/awt/DefaultKeyboardFocusManager.java
! src/share/classes/java/awt/EventDispatchThread.java
! src/share/classes/java/awt/KeyboardFocusManager.java
! src/share/classes/java/awt/WaitDispatchSupport.java
! src/share/classes/javax/swing/BufferStrategyPaintManager.java
! src/share/classes/javax/swing/SortingFocusTraversalPolicy.java
! src/share/classes/sun/awt/AWTAutoShutdown.java
! src/share/classes/sun/awt/DebugSettings.java
! src/share/classes/sun/awt/KeyboardFocusManagerPeerImpl.java
! src/share/classes/sun/awt/SunToolkit.java
! src/share/classes/sun/awt/im/InputContext.java
! src/share/classes/sun/net/www/protocol/http/HttpURLConnection.java
! src/share/classes/sun/net/www/protocol/http/NTLMAuthenticationProxy.java
! src/share/classes/sun/net/www/protocol/http/Negotiator.java
! src/solaris/classes/sun/awt/X11/XAWTXSettings.java
! src/solaris/classes/sun/awt/X11/XBaseMenuWindow.java
! src/solaris/classes/sun/awt/X11/XBaseWindow.java
! src/solaris/classes/sun/awt/X11/XComponentPeer.java
! src/solaris/classes/sun/awt/X11/XContentWindow.java
! src/solaris/classes/sun/awt/X11/XDecoratedPeer.java
! src/solaris/classes/sun/awt/X11/XEmbedCanvasPeer.java
! src/solaris/classes/sun/awt/X11/XEmbedClientHelper.java
! src/solaris/classes/sun/awt/X11/XEmbedHelper.java
! src/solaris/classes/sun/awt/X11/XEmbedServerTester.java
! src/solaris/classes/sun/awt/X11/XFileDialogPeer.java
! src/solaris/classes/sun/awt/X11/XFramePeer.java
! src/solaris/classes/sun/awt/X11/XIconWindow.java
! src/solaris/classes/sun/awt/X11/XInputMethod.java
! src/solaris/classes/sun/awt/X11/XListPeer.java
! src/solaris/classes/sun/awt/X11/XMSelection.java
! src/solaris/classes/sun/awt/X11/XMenuBarPeer.java
! src/solaris/classes/sun/awt/X11/XMenuPeer.java
! src/solaris/classes/sun/awt/X11/XNETProtocol.java
! src/solaris/classes/sun/awt/X11/XPopupMenuPeer.java
! src/solaris/classes/sun/awt/X11/XProtocol.java
! src/solaris/classes/sun/awt/X11/XScrollbar.java
! src/solaris/classes/sun/awt/X11/XScrollbarPeer.java
! src/solaris/classes/sun/awt/X11/XSystemTrayPeer.java
! src/solaris/classes/sun/awt/X11/XTextFieldPeer.java
! src/solaris/classes/sun/awt/X11/XToolkit.java
! src/solaris/classes/sun/awt/X11/XTrayIconPeer.java
! src/solaris/classes/sun/awt/X11/XWINProtocol.java
! src/solaris/classes/sun/awt/X11/XWM.java
! src/solaris/classes/sun/awt/X11/XWindow.java
! src/solaris/classes/sun/awt/X11/XWindowPeer.java
! src/solaris/classes/sun/awt/X11/generator/WrapperGenerator.java
! src/solaris/classes/sun/awt/X11InputMethod.java
! src/windows/classes/sun/awt/windows/WComponentPeer.java

Changeset: 39ce1056694d
Author:    serb
Date:      2013-04-12 15:28 +0400
URL:       http://hg.openjdk.java.net/hsx/hotspot-main/jdk/rev/39ce1056694d

8000629: [macosx] Blurry rendering with Java 7 on Retina display
Reviewed-by: anthony, prr, flar

! src/macosx/classes/sun/awt/CGraphicsDevice.java
! src/macosx/classes/sun/java2d/opengl/CGLGraphicsConfig.java
! src/macosx/classes/sun/java2d/opengl/CGLLayer.java
! src/macosx/classes/sun/java2d/opengl/CGLSurfaceData.java
! src/macosx/classes/sun/lwawt/LWComponentPeer.java
! src/macosx/classes/sun/lwawt/LWWindowPeer.java
! src/macosx/classes/sun/lwawt/macosx/CPlatformWindow.java
! src/macosx/native/sun/awt/CGraphicsDevice.m
! src/macosx/native/sun/java2d/opengl/CGLLayer.m
! src/share/classes/sun/awt/image/SurfaceManager.java
! src/share/classes/sun/java2d/SunGraphics2D.java
! src/share/classes/sun/java2d/SurfaceData.java
! src/share/classes/sun/java2d/pipe/BufferedContext.java
! src/share/classes/sun/java2d/pipe/DrawImage.java
! src/share/classes/sun/java2d/pipe/Region.java
+ test/java/awt/Graphics2D/FillTexturePaint/FillTexturePaint.java
+ test/java/awt/Graphics2D/FlipDrawImage/FlipDrawImage.java
+ test/java/awt/Graphics2D/TransformSetGet/TransformSetGet.java
+ test/java/awt/image/DrawImage/IncorrectBounds.java
+ test/java/awt/image/DrawImage/IncorrectOffset.java

Changeset: ffd45b1a9c11
Author:    serb
Date:      2013-04-12 20:39 +0400
URL:       http://hg.openjdk.java.net/hsx/hotspot-main/jdk/rev/ffd45b1a9c11

8004866: [macosx] HiDPI support in Aqua L&F
Reviewed-by: swingler, alexsch

! src/macosx/classes/com/apple/laf/AquaPainter.java
! src/macosx/classes/com/apple/laf/ImageCache.java
! src/macosx/native/com/apple/laf/JRSUIController.m

Changeset: dcdf8cd4b09e
Author:    ant
Date:      2013-04-15 13:02 +0400
URL:       http://hg.openjdk.java.net/hsx/hotspot-main/jdk/rev/dcdf8cd4b09e

7147075: JTextField doesn't get focus or loses focus forever
Reviewed-by: anthony

! src/solaris/classes/sun/awt/X11/XDecoratedPeer.java

Changeset: 8fbe247ad2d8
Author:    lana
Date:      2013-04-17 11:24 -0700
URL:       http://hg.openjdk.java.net/hsx/hotspot-main/jdk/rev/8fbe247ad2d8

Merge

! src/share/classes/sun/java2d/SunGraphics2D.java
! src/share/classes/sun/java2d/pipe/BufferedContext.java
! src/solaris/classes/sun/awt/X11/XComponentPeer.java

Changeset: bb098a221d85
Author:    lana
Date:      2013-04-17 21:32 -0700
URL:       http://hg.openjdk.java.net/hsx/hotspot-main/jdk/rev/bb098a221d85

Merge


Changeset: 863da64214e8
Author:    mduigou
Date:      2013-04-10 14:06 -0700
URL:       http://hg.openjdk.java.net/hsx/hotspot-main/jdk/rev/863da64214e8

8010948: Add conversion functional interfaces
Reviewed-by: mduigou, dholmes
Contributed-by: Brian Goetz 

+ src/share/classes/java/util/function/DoubleToIntFunction.java
+ src/share/classes/java/util/function/DoubleToLongFunction.java
+ src/share/classes/java/util/function/IntToDoubleFunction.java
+ src/share/classes/java/util/function/IntToLongFunction.java
+ src/share/classes/java/util/function/LongToDoubleFunction.java
+ src/share/classes/java/util/function/LongToIntFunction.java

Changeset: b0458dd21ba6
Author:    darcy
Date:      2013-04-10 16:38 -0700
URL:       http://hg.openjdk.java.net/hsx/hotspot-main/jdk/rev/b0458dd21ba6

8011930: Long.parseLong(String, int) has inaccurate limit on radix for using 'L'
Reviewed-by: smarks

! src/share/classes/java/lang/Long.java

Changeset: 6f8e1428f7c3
Author:    weijun
Date:      2013-04-11 10:58 +0800
URL:       http://hg.openjdk.java.net/hsx/hotspot-main/jdk/rev/6f8e1428f7c3

8005460: [findbugs] Probably returned array should be cloned
Reviewed-by: xuelei

! src/share/classes/sun/security/krb5/PrincipalName.java
+ test/sun/security/krb5/name/Immutable.java

Changeset: 0ab22e58d151
Author:    weijun
Date:      2013-04-11 11:09 +0800
URL:       http://hg.openjdk.java.net/hsx/hotspot-main/jdk/rev/0ab22e58d151

8011867: Accept unknown PKCS #9 attributes
Reviewed-by: vinnie

! src/share/classes/sun/security/pkcs/PKCS9Attribute.java
+ test/sun/security/pkcs/pkcs9/UnknownAttribute.java

Changeset: 1c3fff140324
Author:    weijun
Date:      2013-04-11 11:10 +0800
URL:       http://hg.openjdk.java.net/hsx/hotspot-main/jdk/rev/1c3fff140324

8011745: Unknown CertificateChoices
Reviewed-by: vinnie

! src/share/classes/sun/security/pkcs/PKCS7.java

Changeset: 006a7a576fe9
Author:    peytoia
Date:      2013-04-11 12:22 +0900
URL:       http://hg.openjdk.java.net/hsx/hotspot-main/jdk/rev/006a7a576fe9

8009638: Wrong comment for PL in LocaleISOData, 1989 forward Poland is Republic of Poland
Reviewed-by: okutsu

! src/share/classes/java/util/LocaleISOData.java

Changeset: e62a707a77d8
Author:    lana
Date:      2013-04-11 19:15 -0700
URL:       http://hg.openjdk.java.net/hsx/hotspot-main/jdk/rev/e62a707a77d8

Merge


Changeset: f4d50e8cc9e2
Author:    sherman
Date:      2013-04-12 07:57 -0700
URL:       http://hg.openjdk.java.net/hsx/hotspot-main/jdk/rev/f4d50e8cc9e2

8011172: JSR 310 DateTime API Updates II
Summary: Integration of JSR310 Date/Time API update
Reviewed-by: alanb, naoto, dholmes
Contributed-by: scolebourne at joda.org, roger.riggs at oracle.com, masayoshi.okutsu at oracle.com

! make/java/java/Makefile
! make/java/text/base/FILES_java.gmk
! make/java/util/FILES_java.gmk
! make/sun/text/FILES_java.gmk
! make/sun/tzdb/Makefile
! make/tools/src/build/tools/cldrconverter/AbstractLDMLHandler.java
! make/tools/src/build/tools/cldrconverter/Bundle.java
! make/tools/src/build/tools/cldrconverter/CLDRConverter.java
! make/tools/src/build/tools/cldrconverter/LDMLParseHandler.java
! make/tools/src/build/tools/tzdb/TzdbZoneRulesCompiler.java
! makefiles/CopyFiles.gmk
! makefiles/CreateJars.gmk
! makefiles/GendataTZDB.gmk
! makefiles/profile-includes.txt
! src/share/classes/java/time/DayOfWeek.java
! src/share/classes/java/time/Duration.java
! src/share/classes/java/time/Instant.java
! src/share/classes/java/time/LocalDate.java
! src/share/classes/java/time/LocalDateTime.java
! src/share/classes/java/time/LocalTime.java
! src/share/classes/java/time/Month.java
! src/share/classes/java/time/MonthDay.java
! src/share/classes/java/time/OffsetDateTime.java
! src/share/classes/java/time/OffsetTime.java
! src/share/classes/java/time/Period.java
! src/share/classes/java/time/Year.java
! src/share/classes/java/time/YearMonth.java
! src/share/classes/java/time/ZoneId.java
! src/share/classes/java/time/ZoneOffset.java
! src/share/classes/java/time/ZoneRegion.java
! src/share/classes/java/time/ZonedDateTime.java
! src/share/classes/java/time/chrono/ChronoDateImpl.java
! src/share/classes/java/time/chrono/ChronoLocalDate.java
! src/share/classes/java/time/chrono/ChronoLocalDateTime.java
! src/share/classes/java/time/chrono/ChronoLocalDateTimeImpl.java
! src/share/classes/java/time/chrono/ChronoZonedDateTime.java
! src/share/classes/java/time/chrono/ChronoZonedDateTimeImpl.java
! src/share/classes/java/time/chrono/Chronology.java
! src/share/classes/java/time/chrono/Era.java
! src/share/classes/java/time/chrono/HijrahChronology.java
! src/share/classes/java/time/chrono/HijrahDate.java
- src/share/classes/java/time/chrono/HijrahDeviationReader.java
! src/share/classes/java/time/chrono/HijrahEra.java
! src/share/classes/java/time/chrono/IsoChronology.java
! src/share/classes/java/time/chrono/IsoEra.java
! src/share/classes/java/time/chrono/JapaneseChronology.java
! src/share/classes/java/time/chrono/JapaneseDate.java
! src/share/classes/java/time/chrono/JapaneseEra.java
! src/share/classes/java/time/chrono/MinguoChronology.java
! src/share/classes/java/time/chrono/MinguoDate.java
! src/share/classes/java/time/chrono/MinguoEra.java
! src/share/classes/java/time/chrono/ThaiBuddhistChronology.java
! src/share/classes/java/time/chrono/ThaiBuddhistDate.java
! src/share/classes/java/time/chrono/ThaiBuddhistEra.java
- src/share/classes/java/time/format/DateTimeBuilder.java
- src/share/classes/java/time/format/DateTimeFormatStyleProvider.java
! src/share/classes/java/time/format/DateTimeFormatter.java
! src/share/classes/java/time/format/DateTimeFormatterBuilder.java
! src/share/classes/java/time/format/DateTimeParseContext.java
! src/share/classes/java/time/format/DateTimePrintContext.java
! src/share/classes/java/time/format/DateTimeTextProvider.java
+ src/share/classes/java/time/format/Parsed.java
+ src/share/classes/java/time/format/ResolverStyle.java
! src/share/classes/java/time/format/TextStyle.java
- src/share/classes/java/time/temporal/Adjusters.java
! src/share/classes/java/time/temporal/ChronoField.java
! src/share/classes/java/time/temporal/ChronoUnit.java
! src/share/classes/java/time/temporal/IsoFields.java
! src/share/classes/java/time/temporal/JulianFields.java
- src/share/classes/java/time/temporal/Queries.java
! src/share/classes/java/time/temporal/Temporal.java
! src/share/classes/java/time/temporal/TemporalAccessor.java
! src/share/classes/java/time/temporal/TemporalAdjuster.java
+ src/share/classes/java/time/temporal/TemporalAdjusters.java
! src/share/classes/java/time/temporal/TemporalAmount.java
! src/share/classes/java/time/temporal/TemporalField.java
+ src/share/classes/java/time/temporal/TemporalQueries.java
! src/share/classes/java/time/temporal/TemporalQuery.java
! src/share/classes/java/time/temporal/TemporalUnit.java
+ src/share/classes/java/time/temporal/UnsupportedTemporalTypeException.java
! src/share/classes/java/time/temporal/ValueRange.java
! src/share/classes/java/time/temporal/WeekFields.java
! src/share/classes/java/time/temporal/package-info.java
! src/share/classes/java/time/zone/TzdbZoneRulesProvider.java
! src/share/classes/java/time/zone/ZoneOffsetTransition.java
! src/share/classes/java/time/zone/ZoneOffsetTransitionRule.java
! src/share/classes/java/time/zone/ZoneRulesProvider.java
! src/share/classes/java/util/Formatter.java
! src/share/classes/java/util/GregorianCalendar.java
! src/share/classes/java/util/TimeZone.java
! src/share/classes/sun/text/resources/FormatData.java
+ src/share/classes/sun/text/resources/JavaTimeSupplementary.java
! src/share/classes/sun/text/resources/ar/FormatData_ar.java
! src/share/classes/sun/text/resources/ar/FormatData_ar_JO.java
! src/share/classes/sun/text/resources/ar/FormatData_ar_LB.java
! src/share/classes/sun/text/resources/ar/FormatData_ar_SY.java
+ src/share/classes/sun/text/resources/ar/JavaTimeSupplementary_ar.java
! src/share/classes/sun/text/resources/be/FormatData_be.java
! src/share/classes/sun/text/resources/be/FormatData_be_BY.java
+ src/share/classes/sun/text/resources/be/JavaTimeSupplementary_be.java
! src/share/classes/sun/text/resources/bg/FormatData_bg.java
! src/share/classes/sun/text/resources/bg/FormatData_bg_BG.java
+ src/share/classes/sun/text/resources/bg/JavaTimeSupplementary_bg.java
! src/share/classes/sun/text/resources/ca/FormatData_ca.java
! src/share/classes/sun/text/resources/ca/FormatData_ca_ES.java
+ src/share/classes/sun/text/resources/ca/JavaTimeSupplementary_ca.java
! src/share/classes/sun/text/resources/cs/FormatData_cs.java
! src/share/classes/sun/text/resources/cs/FormatData_cs_CZ.java
+ src/share/classes/sun/text/resources/cs/JavaTimeSupplementary_cs.java
! src/share/classes/sun/text/resources/da/FormatData_da.java
! src/share/classes/sun/text/resources/da/FormatData_da_DK.java
+ src/share/classes/sun/text/resources/da/JavaTimeSupplementary_da.java
! src/share/classes/sun/text/resources/de/FormatData_de.java
! src/share/classes/sun/text/resources/de/FormatData_de_AT.java
! src/share/classes/sun/text/resources/de/FormatData_de_CH.java
! src/share/classes/sun/text/resources/de/FormatData_de_DE.java
! src/share/classes/sun/text/resources/de/FormatData_de_LU.java
+ src/share/classes/sun/text/resources/de/JavaTimeSupplementary_de.java
! src/share/classes/sun/text/resources/el/FormatData_el.java
! src/share/classes/sun/text/resources/el/FormatData_el_CY.java
! src/share/classes/sun/text/resources/el/FormatData_el_GR.java
+ src/share/classes/sun/text/resources/el/JavaTimeSupplementary_el.java
! src/share/classes/sun/text/resources/en/FormatData_en.java
! src/share/classes/sun/text/resources/en/FormatData_en_AU.java
! src/share/classes/sun/text/resources/en/FormatData_en_CA.java
! src/share/classes/sun/text/resources/en/FormatData_en_GB.java
! src/share/classes/sun/text/resources/en/FormatData_en_IE.java
! src/share/classes/sun/text/resources/en/FormatData_en_IN.java
! src/share/classes/sun/text/resources/en/FormatData_en_MT.java
! src/share/classes/sun/text/resources/en/FormatData_en_NZ.java
! src/share/classes/sun/text/resources/en/FormatData_en_PH.java
! src/share/classes/sun/text/resources/en/FormatData_en_SG.java
! src/share/classes/sun/text/resources/en/FormatData_en_US.java
! src/share/classes/sun/text/resources/en/FormatData_en_ZA.java
+ src/share/classes/sun/text/resources/en/JavaTimeSupplementary_en.java
+ src/share/classes/sun/text/resources/en/JavaTimeSupplementary_en_GB.java
+ src/share/classes/sun/text/resources/en/JavaTimeSupplementary_en_SG.java
! src/share/classes/sun/text/resources/es/FormatData_es.java
! src/share/classes/sun/text/resources/es/FormatData_es_AR.java
! src/share/classes/sun/text/resources/es/FormatData_es_BO.java
! src/share/classes/sun/text/resources/es/FormatData_es_CL.java
! src/share/classes/sun/text/resources/es/FormatData_es_CO.java
! src/share/classes/sun/text/resources/es/FormatData_es_CR.java
! src/share/classes/sun/text/resources/es/FormatData_es_DO.java
! src/share/classes/sun/text/resources/es/FormatData_es_EC.java
! src/share/classes/sun/text/resources/es/FormatData_es_ES.java
! src/share/classes/sun/text/resources/es/FormatData_es_GT.java
! src/share/classes/sun/text/resources/es/FormatData_es_HN.java
! src/share/classes/sun/text/resources/es/FormatData_es_MX.java
! src/share/classes/sun/text/resources/es/FormatData_es_NI.java
! src/share/classes/sun/text/resources/es/FormatData_es_PA.java
! src/share/classes/sun/text/resources/es/FormatData_es_PE.java
! src/share/classes/sun/text/resources/es/FormatData_es_PR.java
! src/share/classes/sun/text/resources/es/FormatData_es_PY.java
! src/share/classes/sun/text/resources/es/FormatData_es_SV.java
! src/share/classes/sun/text/resources/es/FormatData_es_US.java
! src/share/classes/sun/text/resources/es/FormatData_es_UY.java
! src/share/classes/sun/text/resources/es/FormatData_es_VE.java
+ src/share/classes/sun/text/resources/es/JavaTimeSupplementary_es.java
! src/share/classes/sun/text/resources/et/FormatData_et.java
! src/share/classes/sun/text/resources/et/FormatData_et_EE.java
+ src/share/classes/sun/text/resources/et/JavaTimeSupplementary_et.java
! src/share/classes/sun/text/resources/fi/FormatData_fi.java
! src/share/classes/sun/text/resources/fi/FormatData_fi_FI.java
+ src/share/classes/sun/text/resources/fi/JavaTimeSupplementary_fi.java
! src/share/classes/sun/text/resources/fr/FormatData_fr.java
! src/share/classes/sun/text/resources/fr/FormatData_fr_BE.java
! src/share/classes/sun/text/resources/fr/FormatData_fr_CA.java
! src/share/classes/sun/text/resources/fr/FormatData_fr_CH.java
! src/share/classes/sun/text/resources/fr/FormatData_fr_FR.java
+ src/share/classes/sun/text/resources/fr/JavaTimeSupplementary_fr.java
! src/share/classes/sun/text/resources/ga/FormatData_ga.java
! src/share/classes/sun/text/resources/ga/FormatData_ga_IE.java
+ src/share/classes/sun/text/resources/ga/JavaTimeSupplementary_ga.java
! src/share/classes/sun/text/resources/hi/FormatData_hi_IN.java
+ src/share/classes/sun/text/resources/hi/JavaTimeSupplementary_hi_IN.java
! src/share/classes/sun/text/resources/hr/FormatData_hr.java
! src/share/classes/sun/text/resources/hr/FormatData_hr_HR.java
+ src/share/classes/sun/text/resources/hr/JavaTimeSupplementary_hr.java
! src/share/classes/sun/text/resources/hu/FormatData_hu.java
! src/share/classes/sun/text/resources/hu/FormatData_hu_HU.java
+ src/share/classes/sun/text/resources/hu/JavaTimeSupplementary_hu.java
! src/share/classes/sun/text/resources/in/FormatData_in.java
! src/share/classes/sun/text/resources/in/FormatData_in_ID.java
! src/share/classes/sun/text/resources/is/FormatData_is.java
! src/share/classes/sun/text/resources/is/FormatData_is_IS.java
+ src/share/classes/sun/text/resources/is/JavaTimeSupplementary_is.java
! src/share/classes/sun/text/resources/it/FormatData_it.java
! src/share/classes/sun/text/resources/it/FormatData_it_CH.java
! src/share/classes/sun/text/resources/it/FormatData_it_IT.java
+ src/share/classes/sun/text/resources/it/JavaTimeSupplementary_it.java
! src/share/classes/sun/text/resources/iw/FormatData_iw.java
! src/share/classes/sun/text/resources/iw/FormatData_iw_IL.java
+ src/share/classes/sun/text/resources/iw/JavaTimeSupplementary_iw.java
+ src/share/classes/sun/text/resources/iw/JavaTimeSupplementary_iw_IL.java
! src/share/classes/sun/text/resources/ja/FormatData_ja.java
! src/share/classes/sun/text/resources/ja/FormatData_ja_JP.java
+ src/share/classes/sun/text/resources/ja/JavaTimeSupplementary_ja.java
! src/share/classes/sun/text/resources/ko/FormatData_ko.java
! src/share/classes/sun/text/resources/ko/FormatData_ko_KR.java
+ src/share/classes/sun/text/resources/ko/JavaTimeSupplementary_ko.java
! src/share/classes/sun/text/resources/lt/FormatData_lt.java
! src/share/classes/sun/text/resources/lt/FormatData_lt_LT.java
+ src/share/classes/sun/text/resources/lt/JavaTimeSupplementary_lt.java
! src/share/classes/sun/text/resources/lv/FormatData_lv.java
! src/share/classes/sun/text/resources/lv/FormatData_lv_LV.java
+ src/share/classes/sun/text/resources/lv/JavaTimeSupplementary_lv.java
! src/share/classes/sun/text/resources/mk/FormatData_mk.java
! src/share/classes/sun/text/resources/mk/FormatData_mk_MK.java
+ src/share/classes/sun/text/resources/mk/JavaTimeSupplementary_mk.java
! src/share/classes/sun/text/resources/ms/FormatData_ms.java
! src/share/classes/sun/text/resources/ms/FormatData_ms_MY.java
+ src/share/classes/sun/text/resources/ms/JavaTimeSupplementary_ms.java
! src/share/classes/sun/text/resources/mt/FormatData_mt.java
! src/share/classes/sun/text/resources/mt/FormatData_mt_MT.java
+ src/share/classes/sun/text/resources/mt/JavaTimeSupplementary_mt.java
! src/share/classes/sun/text/resources/nl/FormatData_nl.java
! src/share/classes/sun/text/resources/nl/FormatData_nl_BE.java
! src/share/classes/sun/text/resources/nl/FormatData_nl_NL.java
+ src/share/classes/sun/text/resources/nl/JavaTimeSupplementary_nl.java
! src/share/classes/sun/text/resources/no/FormatData_no.java
! src/share/classes/sun/text/resources/no/FormatData_no_NO.java
! src/share/classes/sun/text/resources/no/FormatData_no_NO_NY.java
+ src/share/classes/sun/text/resources/no/JavaTimeSupplementary_no.java
! src/share/classes/sun/text/resources/pl/FormatData_pl.java
! src/share/classes/sun/text/resources/pl/FormatData_pl_PL.java
+ src/share/classes/sun/text/resources/pl/JavaTimeSupplementary_pl.java
! src/share/classes/sun/text/resources/pt/FormatData_pt.java
! src/share/classes/sun/text/resources/pt/FormatData_pt_BR.java
! src/share/classes/sun/text/resources/pt/FormatData_pt_PT.java
+ src/share/classes/sun/text/resources/pt/JavaTimeSupplementary_pt.java
+ src/share/classes/sun/text/resources/pt/JavaTimeSupplementary_pt_PT.java
! src/share/classes/sun/text/resources/ro/FormatData_ro.java
! src/share/classes/sun/text/resources/ro/FormatData_ro_RO.java
+ src/share/classes/sun/text/resources/ro/JavaTimeSupplementary_ro.java
! src/share/classes/sun/text/resources/ru/FormatData_ru.java
! src/share/classes/sun/text/resources/ru/FormatData_ru_RU.java
+ src/share/classes/sun/text/resources/ru/JavaTimeSupplementary_ru.java
! src/share/classes/sun/text/resources/sk/FormatData_sk.java
! src/share/classes/sun/text/resources/sk/FormatData_sk_SK.java
+ src/share/classes/sun/text/resources/sk/JavaTimeSupplementary_sk.java
! src/share/classes/sun/text/resources/sl/FormatData_sl.java
! src/share/classes/sun/text/resources/sl/FormatData_sl_SI.java
+ src/share/classes/sun/text/resources/sl/JavaTimeSupplementary_sl.java
! src/share/classes/sun/text/resources/sq/FormatData_sq.java
! src/share/classes/sun/text/resources/sq/FormatData_sq_AL.java
+ src/share/classes/sun/text/resources/sq/JavaTimeSupplementary_sq.java
! src/share/classes/sun/text/resources/sr/FormatData_sr.java
! src/share/classes/sun/text/resources/sr/FormatData_sr_BA.java
! src/share/classes/sun/text/resources/sr/FormatData_sr_CS.java
! src/share/classes/sun/text/resources/sr/FormatData_sr_Latn.java
! src/share/classes/sun/text/resources/sr/FormatData_sr_Latn_ME.java
! src/share/classes/sun/text/resources/sr/FormatData_sr_ME.java
! src/share/classes/sun/text/resources/sr/FormatData_sr_RS.java
+ src/share/classes/sun/text/resources/sr/JavaTimeSupplementary_sr.java
+ src/share/classes/sun/text/resources/sr/JavaTimeSupplementary_sr_Latn.java
! src/share/classes/sun/text/resources/sv/FormatData_sv.java
! src/share/classes/sun/text/resources/sv/FormatData_sv_SE.java
+ src/share/classes/sun/text/resources/sv/JavaTimeSupplementary_sv.java
! src/share/classes/sun/text/resources/th/FormatData_th.java
! src/share/classes/sun/text/resources/th/FormatData_th_TH.java
+ src/share/classes/sun/text/resources/th/JavaTimeSupplementary_th.java
! src/share/classes/sun/text/resources/tr/FormatData_tr.java
! src/share/classes/sun/text/resources/tr/FormatData_tr_TR.java
+ src/share/classes/sun/text/resources/tr/JavaTimeSupplementary_tr.java
! src/share/classes/sun/text/resources/uk/FormatData_uk.java
! src/share/classes/sun/text/resources/uk/FormatData_uk_UA.java
+ src/share/classes/sun/text/resources/uk/JavaTimeSupplementary_uk.java
! src/share/classes/sun/text/resources/vi/FormatData_vi.java
! src/share/classes/sun/text/resources/vi/FormatData_vi_VN.java
+ src/share/classes/sun/text/resources/vi/JavaTimeSupplementary_vi.java
! src/share/classes/sun/text/resources/zh/FormatData_zh.java
! src/share/classes/sun/text/resources/zh/FormatData_zh_CN.java
! src/share/classes/sun/text/resources/zh/FormatData_zh_HK.java
! src/share/classes/sun/text/resources/zh/FormatData_zh_SG.java
! src/share/classes/sun/text/resources/zh/FormatData_zh_TW.java
+ src/share/classes/sun/text/resources/zh/JavaTimeSupplementary_zh.java
+ src/share/classes/sun/text/resources/zh/JavaTimeSupplementary_zh_TW.java
! src/share/classes/sun/util/calendar/ZoneInfo.java
! src/share/classes/sun/util/calendar/ZoneInfoFile.java
! src/share/classes/sun/util/locale/provider/CalendarDataUtility.java
! src/share/classes/sun/util/locale/provider/CalendarNameProviderImpl.java
! src/share/classes/sun/util/locale/provider/LocaleResources.java
! src/share/classes/sun/util/resources/LocaleData.java
! src/share/classes/sun/util/resources/OpenListResourceBundle.java
+ src/share/classes/sun/util/resources/ParallelListResourceBundle.java
! src/share/lib/calendars.properties
+ src/share/lib/hijrah-config-umalqura.properties
! test/java/time/tck/java/time/AbstractDateTimeTest.java
! test/java/time/tck/java/time/TCKClock.java
! test/java/time/tck/java/time/TCKDayOfWeek.java
! test/java/time/tck/java/time/TCKDuration.java
! test/java/time/tck/java/time/TCKInstant.java
! test/java/time/tck/java/time/TCKLocalDate.java
! test/java/time/tck/java/time/TCKLocalDateTime.java
! test/java/time/tck/java/time/TCKLocalTime.java
! test/java/time/tck/java/time/TCKMonth.java
! test/java/time/tck/java/time/TCKMonthDay.java
! test/java/time/tck/java/time/TCKOffsetDateTime.java
! test/java/time/tck/java/time/TCKOffsetTime.java
! test/java/time/tck/java/time/TCKPeriod.java
! test/java/time/tck/java/time/TCKYear.java
! test/java/time/tck/java/time/TCKYearMonth.java
! test/java/time/tck/java/time/TCKZoneId.java
! test/java/time/tck/java/time/TCKZoneOffset.java
! test/java/time/tck/java/time/TCKZonedDateTime.java
- test/java/time/tck/java/time/TestChronology.java
! test/java/time/tck/java/time/TestIsoChronology.java
! test/java/time/tck/java/time/chrono/CopticChronology.java
! test/java/time/tck/java/time/chrono/CopticDate.java
! test/java/time/tck/java/time/chrono/CopticEra.java
+ test/java/time/tck/java/time/chrono/TCKChronoLocalDate.java
+ test/java/time/tck/java/time/chrono/TCKChronoLocalDateTime.java
+ test/java/time/tck/java/time/chrono/TCKChronoZonedDateTime.java
! test/java/time/tck/java/time/chrono/TCKChronology.java
+ test/java/time/tck/java/time/chrono/TCKChronologySerialization.java
+ test/java/time/tck/java/time/chrono/TCKHijrahChronology.java
+ test/java/time/tck/java/time/chrono/TCKHijrahEra.java
+ test/java/time/tck/java/time/chrono/TCKIsoChronology.java
+ test/java/time/tck/java/time/chrono/TCKIsoEra.java
+ test/java/time/tck/java/time/chrono/TCKJapaneseChronology.java
+ test/java/time/tck/java/time/chrono/TCKJapaneseEra.java
+ test/java/time/tck/java/time/chrono/TCKMinguoChronology.java
+ test/java/time/tck/java/time/chrono/TCKMinguoEra.java
! test/java/time/tck/java/time/chrono/TCKTestServiceLoader.java
+ test/java/time/tck/java/time/chrono/TCKThaiBuddhistChronology.java
+ test/java/time/tck/java/time/chrono/TCKThaiBuddhistEra.java
- test/java/time/tck/java/time/chrono/TestChronoLocalDate.java
- test/java/time/tck/java/time/chrono/TestChronoLocalDateTime.java
- test/java/time/tck/java/time/chrono/TestHijrahChronology.java
- test/java/time/tck/java/time/chrono/TestJapaneseChronology.java
- test/java/time/tck/java/time/chrono/TestMinguoChronology.java
- test/java/time/tck/java/time/chrono/TestThaiBuddhistChronology.java
! test/java/time/tck/java/time/format/TCKChronoPrinterParser.java
! test/java/time/tck/java/time/format/TCKDateTimeFormatSymbols.java
! test/java/time/tck/java/time/format/TCKDateTimeFormatter.java
! test/java/time/tck/java/time/format/TCKDateTimeFormatterBuilder.java
! test/java/time/tck/java/time/format/TCKDateTimeFormatters.java
+ test/java/time/tck/java/time/format/TCKDateTimeParseResolver.java
! test/java/time/tck/java/time/format/TCKDateTimeTextPrinting.java
! test/java/time/tck/java/time/format/TCKLocalizedFieldParser.java
! test/java/time/tck/java/time/format/TCKLocalizedFieldPrinter.java
! test/java/time/tck/java/time/format/TCKLocalizedPrinterParser.java
! test/java/time/tck/java/time/format/TCKOffsetPrinterParser.java
+ test/java/time/tck/java/time/format/TCKTextStyle.java
! test/java/time/tck/java/time/format/TCKZoneIdPrinterParser.java
- test/java/time/tck/java/time/temporal/TCKDateTimeAdjusters.java
! test/java/time/tck/java/time/temporal/TCKIsoFields.java
! test/java/time/tck/java/time/temporal/TCKJulianFields.java
+ test/java/time/tck/java/time/temporal/TCKTemporalAdjusters.java
! test/java/time/tck/java/time/temporal/TCKWeekFields.java
- test/java/time/tck/java/time/temporal/TestChronoLocalDate.java
- test/java/time/tck/java/time/temporal/TestChronoLocalDateTime.java
- test/java/time/tck/java/time/temporal/TestChronoZonedDateTime.java
! test/java/time/tck/java/time/zone/TCKFixedZoneRules.java
! test/java/time/tck/java/time/zone/TCKZoneOffsetTransition.java
! test/java/time/tck/java/time/zone/TCKZoneOffsetTransitionRule.java
! test/java/time/tck/java/time/zone/TCKZoneRules.java
! test/java/time/tck/java/time/zone/TCKZoneRulesProvider.java
! test/java/time/test/java/time/MockSimplePeriod.java
! test/java/time/test/java/time/TestClock_System.java
! test/java/time/test/java/time/TestDuration.java
! test/java/time/test/java/time/TestLocalDate.java
! test/java/time/test/java/time/TestLocalDateTime.java
! test/java/time/test/java/time/TestLocalTime.java
! test/java/time/test/java/time/TestMonthDay.java
! test/java/time/test/java/time/TestOffsetDateTime.java
! test/java/time/test/java/time/TestOffsetDateTime_instants.java
! test/java/time/test/java/time/TestPeriod.java
! test/java/time/test/java/time/TestZoneId.java
+ test/java/time/test/java/time/chrono/TestChronoLocalDate.java
+ test/java/time/test/java/time/chrono/TestChronologyPerf.java
! test/java/time/test/java/time/chrono/TestExampleCode.java
! test/java/time/test/java/time/chrono/TestIsoChronoImpl.java
+ test/java/time/test/java/time/chrono/TestJapaneseChronoImpl.java
! test/java/time/test/java/time/chrono/TestServiceLoader.java
+ test/java/time/test/java/time/chrono/TestThaiBuddhistChronoImpl.java
+ test/java/time/test/java/time/chrono/TestUmmAlQuraChronology.java
! test/java/time/test/java/time/format/AbstractTestPrinterParser.java
! test/java/time/test/java/time/format/MockIOExceptionAppendable.java
! test/java/time/test/java/time/format/TestCharLiteralParser.java
! test/java/time/test/java/time/format/TestCharLiteralPrinter.java
! test/java/time/test/java/time/format/TestDateTimeFormatSymbols.java
! test/java/time/test/java/time/format/TestDateTimeFormatter.java
! test/java/time/test/java/time/format/TestDateTimeFormatterBuilder.java
! test/java/time/test/java/time/format/TestDateTimeTextProvider.java
! test/java/time/test/java/time/format/TestFractionPrinterParser.java
! test/java/time/test/java/time/format/TestNonIsoFormatter.java
! test/java/time/test/java/time/format/TestNumberParser.java
! test/java/time/test/java/time/format/TestPadPrinterDecorator.java
! test/java/time/test/java/time/format/TestReducedParser.java
! test/java/time/test/java/time/format/TestReducedPrinter.java
! test/java/time/test/java/time/format/TestSettingsParser.java
! test/java/time/test/java/time/format/TestStringLiteralParser.java
! test/java/time/test/java/time/format/TestStringLiteralPrinter.java
! test/java/time/test/java/time/format/TestTextParser.java
! test/java/time/test/java/time/format/TestTextPrinter.java
! test/java/time/test/java/time/format/TestZoneOffsetParser.java
! test/java/time/test/java/time/format/TestZoneOffsetPrinter.java
! test/java/time/test/java/time/format/TestZoneTextPrinterParser.java
! test/java/time/test/java/time/format/ZoneName.java
! test/java/time/test/java/time/temporal/MockFieldValue.java
+ test/java/time/test/java/time/temporal/TestChronoField.java
! test/java/time/test/java/time/temporal/TestChronoUnit.java
- test/java/time/test/java/time/temporal/TestDateTimeAdjusters.java
! test/java/time/test/java/time/temporal/TestDateTimeBuilderCombinations.java
! test/java/time/test/java/time/temporal/TestDateTimeValueRange.java
- test/java/time/test/java/time/temporal/TestJapaneseChronoImpl.java
- test/java/time/test/java/time/temporal/TestThaiBuddhistChronoImpl.java
! test/java/time/test/java/time/zone/TestFixedZoneRules.java
! test/java/time/test/java/util/TestFormatter.java
! test/java/util/Calendar/Bug8007038.java
! test/java/util/Calendar/CldrFormatNamesTest.java
! test/java/util/Calendar/JavatimeTest.java
! test/sun/text/resources/LocaleData
! test/sun/util/calendar/zi/TestZoneInfo310.java

Changeset: 035a61c9f981
Author:    sherman
Date:      2013-04-12 09:51 -0700
URL:       http://hg.openjdk.java.net/hsx/hotspot-main/jdk/rev/035a61c9f981

8012123: hijrah-config-umalqura.properties is missing from makefiles/profile-includes.txt
Summary: added the hijrah-config-umalqura.properties into the list
Reviewed-by: alanb

! makefiles/profile-includes.txt

Changeset: e2cd40d7567c
Author:    rfield
Date:      2013-04-12 10:02 -0700
URL:       http://hg.openjdk.java.net/hsx/hotspot-main/jdk/rev/e2cd40d7567c

8011805: Update sun.tools.java class file reading/writing support to include the new constant pool entries
Reviewed-by: mduigou, alanb

! src/share/classes/java/lang/invoke/InnerClassLambdaMetafactory.java
! src/share/classes/sun/tools/java/BinaryConstantPool.java
! src/share/classes/sun/tools/java/RuntimeConstants.java
+ test/sun/tools/java/CFCTest.java

Changeset: 2e3cc7f599ca
Author:    mduigou
Date:      2013-04-10 12:43 -0700
URL:       http://hg.openjdk.java.net/hsx/hotspot-main/jdk/rev/2e3cc7f599ca

8011200: (coll) Optimize empty HashMap and ArrayList
Reviewed-by: mduigou, alanb, bchristi, martin
Contributed-by: Sergey Linetskiy , John Rose , Mike Duigou 

! src/share/classes/java/util/ArrayList.java
! src/share/classes/java/util/HashMap.java
+ test/java/util/Map/BasicSerialization.java

Changeset: 6c935c5ac7ff
Author:    sherman
Date:      2013-04-12 12:03 -0700
URL:       http://hg.openjdk.java.net/hsx/hotspot-main/jdk/rev/6c935c5ac7ff

8011647: Add java.time.Instant methods to java.nio.file.attribute.FileTime
Summary: added the toInstant()/from(Instant) to FileTime
Reviewed-by: alanb

! src/share/classes/java/nio/file/attribute/FileTime.java
! test/java/nio/file/attribute/FileTime/Basic.java

Changeset: 729ca1ef7c75
Author:    sherman
Date:      2013-04-12 12:12 -0700
URL:       http://hg.openjdk.java.net/hsx/hotspot-main/jdk/rev/729ca1ef7c75

8002390: (zipfs) Problems moving files between zip file systems
Summary: fixed the corner cases in zipfs
Reviewed-by: sherman
Contributed-by: mark.sheppard at oracle.com

! src/share/demo/nio/zipfs/src/com/sun/nio/zipfs/ZipFileSystem.java
! test/demo/zipfs/ZipFSTester.java
! test/demo/zipfs/basic.sh

Changeset: d8cae0195fe9
Author:    henryjen
Date:      2013-04-12 12:41 -0700
URL:       http://hg.openjdk.java.net/hsx/hotspot-main/jdk/rev/d8cae0195fe9

8010279: java.util.Stream.min/max((Comparator)null) is not consistent in throwing (unspecified) NPE
Reviewed-by: alanb, mduigou

! src/share/classes/java/util/Comparators.java
+ test/java/util/Comparators/BasicTest.java
- test/java/util/ComparatorsTest.java

Changeset: 06dfdfa8c3e6
Author:    rfield
Date:      2013-04-12 20:23 -0700
URL:       http://hg.openjdk.java.net/hsx/hotspot-main/jdk/rev/06dfdfa8c3e6

8012028: Metafactory-generated lambda classes should be final
8008941: isSynthetic() returns false for lambda instances
Reviewed-by: mduigou

! src/share/classes/java/lang/invoke/InnerClassLambdaMetafactory.java
+ test/java/lang/invoke/lambda/LambdaClassFinal.java
+ test/java/lang/invoke/lambda/LambdaClassSynthetic.java

Changeset: 0111bab8dc35
Author:    jzavgren
Date:      2013-04-11 12:33 -0400
URL:       http://hg.openjdk.java.net/hsx/hotspot-main/jdk/rev/0111bab8dc35

8008118: (process) Possible null pointer dereference in jdk/src/solaris/native/java/lang/UNIXProcess_md.c
Summary: Modified the path processing code so that it detects and handles out of memory errors.
Reviewed-by: chegar, martin, christos, alanb, msheppar
Contributed-by: john.zavgren at oracle.com

! make/java/java/mapfile-vers
! makefiles/mapfiles/libjava/mapfile-vers
! src/solaris/classes/java/lang/UNIXProcess.java.bsd
! src/solaris/classes/java/lang/UNIXProcess.java.linux
! src/solaris/classes/java/lang/UNIXProcess.java.solaris
! src/solaris/native/java/lang/ProcessEnvironment_md.c
! src/solaris/native/java/lang/UNIXProcess_md.c

Changeset: 5c406a747192
Author:    chegar
Date:      2013-04-14 19:17 +0100
URL:       http://hg.openjdk.java.net/hsx/hotspot-main/jdk/rev/5c406a747192

8011799: CompletableFuture/Basic.java fails intermittently
Reviewed-by: martin, alanb

! test/java/util/concurrent/CompletableFuture/Basic.java

Changeset: 4ed143ddbb8a
Author:    martin
Date:      2013-04-15 14:07 -0700
URL:       http://hg.openjdk.java.net/hsx/hotspot-main/jdk/rev/4ed143ddbb8a

8008509: 6588413 changed JNIEXPORT visibility for GCC on HSX, jdk's jni_md.h needs similar change
Summary: Define JNIEXPORT to use "default" visibility where possible.
Reviewed-by: coleenp, ddehaven, dcubed, anthony

! src/share/native/sun/java2d/loops/GraphicsPrimitiveMgr.h
! src/share/npt/npt.h
! src/solaris/javavm/export/jni_md.h
! src/solaris/native/sun/awt/awt_LoadLibrary.c

Changeset: baaa706d7677
Author:    darcy
Date:      2013-04-15 18:31 -0700
URL:       http://hg.openjdk.java.net/hsx/hotspot-main/jdk/rev/baaa706d7677

8011800: Add java.util.Objects.requireNonNull(T, Supplier)
Reviewed-by: alanb, dholmes, mduigou

! src/share/classes/java/util/Objects.java
! test/java/util/Objects/BasicObjectsTest.java

Changeset: 61cfbe08ce5d
Author:    chegar
Date:      2013-04-16 12:23 +0100
URL:       http://hg.openjdk.java.net/hsx/hotspot-main/jdk/rev/61cfbe08ce5d

8012343: Objects.requireNonNull(Object,Supplier) breaks genstubs build
Reviewed-by: alanb

! src/share/classes/java/util/Objects.java
! test/java/util/Objects/BasicObjectsTest.java

Changeset: e2a0e37b152c
Author:    chegar
Date:      2013-04-16 12:51 +0100
URL:       http://hg.openjdk.java.net/hsx/hotspot-main/jdk/rev/e2a0e37b152c

8012237: CompletableFuture/Basic.java still fails intermittently
Reviewed-by: martin

! test/java/util/concurrent/CompletableFuture/Basic.java

Changeset: 6135c60e77e5
Author:    chegar
Date:      2013-04-16 13:26 +0100
URL:       http://hg.openjdk.java.net/hsx/hotspot-main/jdk/rev/6135c60e77e5

8012244: java/net/Socket/asyncClose/Race.java fails intermittently on Windows
Reviewed-by: alanb, dsamersoff

! src/windows/classes/java/net/DualStackPlainSocketImpl.java
! src/windows/native/java/net/SocketInputStream.c
! test/java/net/Socket/asyncClose/Race.java

Changeset: e4e9f6455f3c
Author:    mduigou
Date:      2013-04-16 11:17 -0700
URL:       http://hg.openjdk.java.net/hsx/hotspot-main/jdk/rev/e4e9f6455f3c

8004518: Add in-place operations to Map
8010122: Add defaults for ConcurrentMap operations to Map
Reviewed-by: darcy, briangoetz, mduigou, dholmes, ulfzibis
Contributed-by: Doug Lea 
, Henry Jen , Akhil Arora , Peter Levart , Mike Duigou 

! src/share/classes/java/util/Collections.java
! src/share/classes/java/util/HashMap.java
! src/share/classes/java/util/Hashtable.java
! src/share/classes/java/util/Map.java
! src/share/classes/java/util/concurrent/ConcurrentMap.java
+ test/java/util/Map/Defaults.java

Changeset: c5ead5aa2e13
Author:    bae
Date:      2013-02-07 19:15 +0400
URL:       http://hg.openjdk.java.net/hsx/hotspot-main/jdk/rev/c5ead5aa2e13

8007014: Improve image handling
Reviewed-by: prr, mschoene, jgodinez

! src/share/classes/sun/awt/image/ByteComponentRaster.java
! src/share/classes/sun/awt/image/BytePackedRaster.java
! src/share/classes/sun/awt/image/IntegerComponentRaster.java
! src/share/classes/sun/awt/image/IntegerInterleavedRaster.java
! src/share/classes/sun/awt/image/ShortComponentRaster.java
! src/share/native/sun/awt/image/awt_parseImage.c
! src/share/native/sun/awt/medialib/awt_ImagingLib.c
! src/share/native/sun/awt/medialib/mlib_ImageCreate.c
! src/share/native/sun/awt/medialib/safe_alloc.h
+ src/share/native/sun/awt/medialib/safe_math.h

Changeset: c95973aac928
Author:    malenkov
Date:      2013-02-08 17:32 +0400
URL:       http://hg.openjdk.java.net/hsx/hotspot-main/jdk/rev/c95973aac928

7200507: Refactor Introspector internals
Reviewed-by: ahgross, art

! src/share/classes/java/beans/ThreadGroupContext.java
+ src/share/classes/java/beans/WeakIdentityMap.java

Changeset: 210fb90ee33a
Author:    michaelm
Date:      2013-02-13 10:40 +0000
URL:       http://hg.openjdk.java.net/hsx/hotspot-main/jdk/rev/210fb90ee33a

8000724: Improve networking serialization
Summary: delegate InetAddress fields to a holder object
Reviewed-by: alanb, chegar

! src/share/classes/java/net/AbstractPlainDatagramSocketImpl.java
! src/share/classes/java/net/Inet4Address.java
! src/share/classes/java/net/Inet4AddressImpl.java
! src/share/classes/java/net/Inet6Address.java
! src/share/classes/java/net/Inet6AddressImpl.java
! src/share/classes/java/net/InetAddress.java
! src/share/classes/java/net/InetSocketAddress.java
! src/share/native/java/net/InetAddress.c
! src/share/native/java/net/net_util.c
! src/share/native/java/net/net_util.h
! src/solaris/native/java/net/Inet4AddressImpl.c
! src/solaris/native/java/net/Inet6AddressImpl.c
! src/solaris/native/java/net/NetworkInterface.c
! src/solaris/native/java/net/PlainDatagramSocketImpl.c
! src/solaris/native/java/net/net_util_md.c
! src/windows/classes/java/net/TwoStacksPlainDatagramSocketImpl.java
! src/windows/native/java/net/Inet4AddressImpl.c
! src/windows/native/java/net/Inet6AddressImpl.c
! src/windows/native/java/net/NetworkInterface.c
! src/windows/native/java/net/NetworkInterface.h
! src/windows/native/java/net/NetworkInterface_winXP.c
! src/windows/native/java/net/TwoStacksPlainDatagramSocketImpl.c
! src/windows/native/java/net/TwoStacksPlainSocketImpl.c
! src/windows/native/java/net/net_util_md.c

Changeset: 5ffba58b541f
Author:    valeriep
Date:      2013-02-26 11:12 -0800
URL:       http://hg.openjdk.java.net/hsx/hotspot-main/jdk/rev/5ffba58b541f

8000897: VM crash in CompileBroker
Summary: Fixed to use the corresponding digest length when generating output.
Reviewed-by: mullan

! src/share/classes/sun/security/provider/SHA2.java

Changeset: 96890625ebdf
Author:    smarks
Date:      2013-02-27 14:17 -0800
URL:       http://hg.openjdk.java.net/hsx/hotspot-main/jdk/rev/96890625ebdf

8001040: Rework RMI model
Reviewed-by: alanb, ahgross, coffeys, dmocek

! src/share/classes/sun/rmi/server/MarshalInputStream.java
! test/java/rmi/registry/classPathCodebase/ClassPathCodebase.java
! test/java/rmi/registry/readTest/readTest.sh
! test/java/rmi/server/RMIClassLoader/downloadArrayClass/DownloadArrayClass.java
! test/java/rmi/server/RMIClassLoader/downloadArrayClass/security.policy
! test/java/rmi/server/RMIClassLoader/loadProxyClasses/LoadProxyClasses.java
+ test/java/rmi/server/RMIClassLoader/useCodebaseOnlyDefault/UseCodebaseOnlyDefault.java
! test/java/rmi/testlibrary/RMID.java

Changeset: f12921c0b15b
Author:    dfuchs
Date:      2013-03-14 13:10 +0100
URL:       http://hg.openjdk.java.net/hsx/hotspot-main/jdk/rev/f12921c0b15b

8001322: Refactor deserialization
Reviewed-by: mchung, skoivu, smarks

! src/share/classes/java/io/ObjectInputStream.java

Changeset: bae4a15265d3
Author:    dmocek
Date:      2013-02-05 16:38 -0800
URL:       http://hg.openjdk.java.net/hsx/hotspot-main/jdk/rev/bae4a15265d3

8001329: Augment RMI logging
Reviewed-by: smarks, hawtin, alanb

! src/share/classes/java/rmi/server/LogStream.java

Changeset: c876e9321616
Author:    chegar
Date:      2012-12-20 13:40 +0000
URL:       http://hg.openjdk.java.net/hsx/hotspot-main/jdk/rev/c876e9321616

8003335: Better handling of Finalizer thread
Reviewed-by: alanb, ahgross

! src/share/classes/java/lang/ref/Finalizer.java

Changeset: 0c5c54303c92
Author:    serb
Date:      2013-02-15 13:49 +0400
URL:       http://hg.openjdk.java.net/hsx/hotspot-main/jdk/rev/0c5c54303c92

8004261: Improve input validation
Reviewed-by: art, mschoene, amenkov

! src/share/classes/com/sun/media/sound/AbstractMidiDevice.java
! src/share/classes/com/sun/media/sound/FastShortMessage.java
! src/share/classes/com/sun/media/sound/FastSysexMessage.java
! src/share/classes/com/sun/media/sound/MidiOutDevice.java
! src/share/classes/com/sun/media/sound/RealTimeSequencer.java

Changeset: 3d155555f809
Author:    uta
Date:      2013-02-22 17:49 +0400
URL:       http://hg.openjdk.java.net/hsx/hotspot-main/jdk/rev/3d155555f809

8005942: (process) Improved Runtime.exec
Reviewed-by: alanb, ahgross

! src/share/classes/java/lang/ProcessBuilder.java
! src/windows/classes/java/lang/ProcessImpl.java

Changeset: cf01f2847551
Author:    dsamersoff
Date:      2013-03-05 00:02 +0400
URL:       http://hg.openjdk.java.net/hsx/hotspot-main/jdk/rev/cf01f2847551

8006435: Improvements in JMX
Summary: Improvements in JMX
Reviewed-by: dfuchs, skoivu, alanb, mchung

! src/share/classes/com/sun/jmx/mbeanserver/MBeanInstantiator.java

Changeset: 4effe291c08b
Author:    prr
Date:      2013-02-08 09:15 -0800
URL:       http://hg.openjdk.java.net/hsx/hotspot-main/jdk/rev/4effe291c08b

8006795: Improve font warning messages
Reviewed-by: bae, jgodinez

! src/share/classes/sun/font/CMap.java

Changeset: 9b4bee66fa24
Author:    bae
Date:      2013-02-19 11:47 +0400
URL:       http://hg.openjdk.java.net/hsx/hotspot-main/jdk/rev/9b4bee66fa24

8007617: Better validation of images
Reviewed-by: prr, mschoene, jgodinez

! src/share/classes/sun/awt/image/ImageRepresentation.java
! src/share/native/sun/awt/image/awt_ImageRep.c

Changeset: 620a08212c79
Author:    bae
Date:      2013-02-26 00:41 +0400
URL:       http://hg.openjdk.java.net/hsx/hotspot-main/jdk/rev/620a08212c79

8007667: Better image reading
Reviewed-by: prr, jgodinez, mschoene

! src/share/classes/com/sun/imageio/plugins/jpeg/JPEGImageReader.java
! src/share/native/sun/awt/image/jpeg/imageioJPEG.c

Changeset: 2deab0b85b82
Author:    bae
Date:      2013-02-26 01:41 +0400
URL:       http://hg.openjdk.java.net/hsx/hotspot-main/jdk/rev/2deab0b85b82

8007918: Better image writing
Reviewed-by: mschoene, prr, jgodinez

! src/share/classes/com/sun/imageio/plugins/jpeg/JPEGImageWriter.java
! src/share/native/sun/awt/image/jpeg/imageioJPEG.c

Changeset: f7b331b8661f
Author:    chegar
Date:      2013-03-03 10:07 +0000
URL:       http://hg.openjdk.java.net/hsx/hotspot-main/jdk/rev/f7b331b8661f

8009063: Improve reliability of ConcurrentHashMap
Reviewed-by: alanb, ahgross

! src/share/classes/java/util/concurrent/ConcurrentHashMap.java

Changeset: 5c2c8fb0b885
Author:    dfuchs
Date:      2013-03-14 18:41 +0100
URL:       http://hg.openjdk.java.net/hsx/hotspot-main/jdk/rev/5c2c8fb0b885

8009305: Improve AWT data transfer
Reviewed-by: art, skoivu, smarks, ant

! src/share/classes/sun/awt/datatransfer/TransferableProxy.java

Changeset: af881cbec91e
Author:    uta
Date:      2013-03-08 13:35 +0400
URL:       http://hg.openjdk.java.net/hsx/hotspot-main/jdk/rev/af881cbec91e

8009463: Regression test test\java\lang\Runtime\exec\ArgWithSpaceAndFinalBackslash.java failing.
Reviewed-by: alanb, ahgross

! src/windows/classes/java/lang/ProcessImpl.java

Changeset: 633fd0b99a8d
Author:    valeriep
Date:      2013-03-11 20:18 -0700
URL:       http://hg.openjdk.java.net/hsx/hotspot-main/jdk/rev/633fd0b99a8d

8009610: Blacklist certificate used with malware.
Summary: updated the black list and the reg test with the new cert.
Reviewed-by: weijun

! src/share/classes/sun/security/util/UntrustedCertificates.java

Changeset: 37296d45a11e
Author:    lancea
Date:      2013-03-18 13:30 -0400
URL:       http://hg.openjdk.java.net/hsx/hotspot-main/jdk/rev/37296d45a11e

8009814: Better driver management
Reviewed-by: alanb, skoivu

! src/share/classes/java/sql/DriverManager.java

Changeset: fa919c17da9f
Author:    smarks
Date:      2013-03-18 18:15 -0700
URL:       http://hg.openjdk.java.net/hsx/hotspot-main/jdk/rev/fa919c17da9f

8009857: Problem with plugin
Reviewed-by: jdn, mchung

! src/share/classes/sun/reflect/misc/MethodUtil.java

Changeset: 4267ae18e13a
Author:    prr
Date:      2013-02-15 13:07 -0800
URL:       http://hg.openjdk.java.net/hsx/hotspot-main/jdk/rev/4267ae18e13a

8008249: Sync ICU into JDK
Reviewed-by: bae, jgodinez

! make/sun/font/FILES_c.gmk
! src/share/native/sun/font/layout/ContextualGlyphInsertion.h
+ src/share/native/sun/font/layout/ContextualGlyphInsertionProc2.cpp
+ src/share/native/sun/font/layout/ContextualGlyphInsertionProc2.h
+ src/share/native/sun/font/layout/ContextualGlyphSubstProc2.cpp
+ src/share/native/sun/font/layout/ContextualGlyphSubstProc2.h
! src/share/native/sun/font/layout/ContextualGlyphSubstitution.h
+ src/share/native/sun/font/layout/GXLayoutEngine2.cpp
+ src/share/native/sun/font/layout/GXLayoutEngine2.h
! src/share/native/sun/font/layout/IndicClassTables.cpp
! src/share/native/sun/font/layout/IndicRearrangement.h
+ src/share/native/sun/font/layout/IndicRearrangementProcessor2.cpp
+ src/share/native/sun/font/layout/IndicRearrangementProcessor2.h
! src/share/native/sun/font/layout/IndicReordering.cpp
! src/share/native/sun/font/layout/IndicReordering.h
! src/share/native/sun/font/layout/LEFontInstance.h
! src/share/native/sun/font/layout/LEGlyphFilter.h
! src/share/native/sun/font/layout/LEInsertionList.h
! src/share/native/sun/font/layout/LEScripts.h
! src/share/native/sun/font/layout/LETypes.h
! src/share/native/sun/font/layout/LayoutEngine.cpp
! src/share/native/sun/font/layout/LayoutEngine.h
+ src/share/native/sun/font/layout/LigatureSubstProc2.cpp
+ src/share/native/sun/font/layout/LigatureSubstProc2.h
! src/share/native/sun/font/layout/LigatureSubstitution.h
! src/share/native/sun/font/layout/LookupProcessor.cpp
! src/share/native/sun/font/layout/MPreFixups.cpp
! src/share/native/sun/font/layout/MorphStateTables.h
! src/share/native/sun/font/layout/MorphTables.h
+ src/share/native/sun/font/layout/MorphTables2.cpp
! src/share/native/sun/font/layout/NonContextualGlyphSubst.h
+ src/share/native/sun/font/layout/NonContextualGlyphSubstProc2.cpp
+ src/share/native/sun/font/layout/NonContextualGlyphSubstProc2.h
! src/share/native/sun/font/layout/OpenTypeLayoutEngine.cpp
! src/share/native/sun/font/layout/ScriptAndLanguageTags.cpp
! src/share/native/sun/font/layout/ScriptAndLanguageTags.h
+ src/share/native/sun/font/layout/SegmentArrayProcessor2.cpp
+ src/share/native/sun/font/layout/SegmentArrayProcessor2.h
+ src/share/native/sun/font/layout/SegmentSingleProcessor2.cpp
+ src/share/native/sun/font/layout/SegmentSingleProcessor2.h
+ src/share/native/sun/font/layout/SimpleArrayProcessor2.cpp
+ src/share/native/sun/font/layout/SimpleArrayProcessor2.h
+ src/share/native/sun/font/layout/SingleTableProcessor2.cpp
+ src/share/native/sun/font/layout/SingleTableProcessor2.h
+ src/share/native/sun/font/layout/StateTableProcessor2.cpp
+ src/share/native/sun/font/layout/StateTableProcessor2.h
! src/share/native/sun/font/layout/StateTables.h
+ src/share/native/sun/font/layout/SubtableProcessor2.cpp
+ src/share/native/sun/font/layout/SubtableProcessor2.h
+ src/share/native/sun/font/layout/TrimmedArrayProcessor2.cpp
+ src/share/native/sun/font/layout/TrimmedArrayProcessor2.h

Changeset: 43f2d3d715c5
Author:    prr
Date:      2013-02-26 10:07 -0800
URL:       http://hg.openjdk.java.net/hsx/hotspot-main/jdk/rev/43f2d3d715c5

8004986: Better handling of glyph table
8004987: Improve font layout
8004994: Improve checking of glyph table
Reviewed-by: srl, jgodinez

! src/share/native/sun/font/layout/ArabicLayoutEngine.cpp
! src/share/native/sun/font/layout/ContextualGlyphSubstProc2.cpp
! src/share/native/sun/font/layout/LETypes.h
! src/share/native/sun/font/layout/LayoutEngine.cpp
! src/share/native/sun/font/layout/LigatureSubstProc.cpp
! src/share/native/sun/font/layout/LigatureSubstProc2.cpp
! src/share/native/sun/font/layout/LookupProcessor.cpp
! src/share/native/sun/font/layout/OpenTypeLayoutEngine.cpp
! src/share/native/sun/font/layout/OpenTypeLayoutEngine.h
! src/share/native/sun/font/layout/StateTableProcessor.cpp
! src/share/native/sun/font/layout/StateTableProcessor2.cpp
! src/share/native/sun/font/layout/StateTables.h

Changeset: 32778f4f945f
Author:    prr
Date:      2013-03-07 10:02 -0800
URL:       http://hg.openjdk.java.net/hsx/hotspot-main/jdk/rev/32778f4f945f

8001031: Better font processing
Reviewed-by: srl, vadim

! src/share/native/sun/font/FontInstanceAdapter.cpp
! src/share/native/sun/font/FontInstanceAdapter.h
! src/share/native/sun/font/fontscalerdefs.h
! src/share/native/sun/font/layout/AlternateSubstSubtables.cpp
! src/share/native/sun/font/layout/AlternateSubstSubtables.h
! src/share/native/sun/font/layout/ArabicLayoutEngine.cpp
! src/share/native/sun/font/layout/ArabicLayoutEngine.h
! src/share/native/sun/font/layout/ArabicShaping.cpp
! src/share/native/sun/font/layout/ArabicShaping.h
! src/share/native/sun/font/layout/AttachmentPosnSubtables.h
! src/share/native/sun/font/layout/CanonData.cpp
! src/share/native/sun/font/layout/CanonShaping.cpp
! src/share/native/sun/font/layout/CanonShaping.h
! src/share/native/sun/font/layout/ClassDefinitionTables.cpp
! src/share/native/sun/font/layout/ClassDefinitionTables.h
! src/share/native/sun/font/layout/ContextualGlyphInsertionProc2.cpp
! src/share/native/sun/font/layout/ContextualGlyphInsertionProc2.h
! src/share/native/sun/font/layout/ContextualGlyphSubstProc.cpp
! src/share/native/sun/font/layout/ContextualGlyphSubstProc.h
! src/share/native/sun/font/layout/ContextualGlyphSubstProc2.cpp
! src/share/native/sun/font/layout/ContextualGlyphSubstProc2.h
! src/share/native/sun/font/layout/ContextualSubstSubtables.cpp
! src/share/native/sun/font/layout/ContextualSubstSubtables.h
! src/share/native/sun/font/layout/CoverageTables.h
! src/share/native/sun/font/layout/CursiveAttachmentSubtables.cpp
! src/share/native/sun/font/layout/CursiveAttachmentSubtables.h
! src/share/native/sun/font/layout/DeviceTables.h
! src/share/native/sun/font/layout/ExtensionSubtables.cpp
! src/share/native/sun/font/layout/Features.cpp
! src/share/native/sun/font/layout/GDEFMarkFilter.cpp
! src/share/native/sun/font/layout/GDEFMarkFilter.h
! src/share/native/sun/font/layout/GXLayoutEngine.cpp
! src/share/native/sun/font/layout/GXLayoutEngine.h
! src/share/native/sun/font/layout/GXLayoutEngine2.cpp
! src/share/native/sun/font/layout/GXLayoutEngine2.h
! src/share/native/sun/font/layout/GlyphDefinitionTables.cpp
! src/share/native/sun/font/layout/GlyphDefinitionTables.h
! src/share/native/sun/font/layout/GlyphIterator.cpp
! src/share/native/sun/font/layout/GlyphIterator.h
! src/share/native/sun/font/layout/GlyphLookupTables.cpp
! src/share/native/sun/font/layout/GlyphLookupTables.h
! src/share/native/sun/font/layout/GlyphPositioningTables.cpp
! src/share/native/sun/font/layout/GlyphPositioningTables.h
! src/share/native/sun/font/layout/GlyphPosnLookupProc.cpp
! src/share/native/sun/font/layout/GlyphPosnLookupProc.h
! src/share/native/sun/font/layout/GlyphSubstLookupProc.cpp
! src/share/native/sun/font/layout/GlyphSubstLookupProc.h
! src/share/native/sun/font/layout/GlyphSubstitutionTables.cpp
! src/share/native/sun/font/layout/GlyphSubstitutionTables.h
! src/share/native/sun/font/layout/HanLayoutEngine.cpp
! src/share/native/sun/font/layout/HanLayoutEngine.h
! src/share/native/sun/font/layout/HangulLayoutEngine.cpp
! src/share/native/sun/font/layout/HangulLayoutEngine.h
! src/share/native/sun/font/layout/ICUFeatures.h
! src/share/native/sun/font/layout/IndicLayoutEngine.cpp
! src/share/native/sun/font/layout/IndicLayoutEngine.h
! src/share/native/sun/font/layout/IndicRearrangementProcessor.cpp
! src/share/native/sun/font/layout/IndicRearrangementProcessor.h
! src/share/native/sun/font/layout/IndicRearrangementProcessor2.cpp
! src/share/native/sun/font/layout/IndicRearrangementProcessor2.h
! src/share/native/sun/font/layout/IndicReordering.cpp
! src/share/native/sun/font/layout/KernTable.cpp
! src/share/native/sun/font/layout/KernTable.h
! src/share/native/sun/font/layout/KhmerLayoutEngine.cpp
! src/share/native/sun/font/layout/KhmerLayoutEngine.h
! src/share/native/sun/font/layout/LEScripts.h
+ src/share/native/sun/font/layout/LETableReference.h
! src/share/native/sun/font/layout/LETypes.h
! src/share/native/sun/font/layout/LayoutEngine.cpp
! src/share/native/sun/font/layout/LayoutEngine.h
! src/share/native/sun/font/layout/LigatureSubstProc.cpp
! src/share/native/sun/font/layout/LigatureSubstProc.h
! src/share/native/sun/font/layout/LigatureSubstProc2.cpp
! src/share/native/sun/font/layout/LigatureSubstProc2.h
! src/share/native/sun/font/layout/LigatureSubstSubtables.cpp
! src/share/native/sun/font/layout/LigatureSubstSubtables.h
! src/share/native/sun/font/layout/LookupProcessor.cpp
! src/share/native/sun/font/layout/LookupProcessor.h
! src/share/native/sun/font/layout/LookupTables.cpp
! src/share/native/sun/font/layout/LookupTables.h
! src/share/native/sun/font/layout/Lookups.cpp
! src/share/native/sun/font/layout/Lookups.h
! src/share/native/sun/font/layout/MarkArrays.h
! src/share/native/sun/font/layout/MarkToBasePosnSubtables.cpp
! src/share/native/sun/font/layout/MarkToBasePosnSubtables.h
! src/share/native/sun/font/layout/MarkToLigaturePosnSubtables.cpp
! src/share/native/sun/font/layout/MarkToLigaturePosnSubtables.h
! src/share/native/sun/font/layout/MarkToMarkPosnSubtables.cpp
! src/share/native/sun/font/layout/MarkToMarkPosnSubtables.h
! src/share/native/sun/font/layout/MorphTables.cpp
! src/share/native/sun/font/layout/MorphTables.h
! src/share/native/sun/font/layout/MorphTables2.cpp
! src/share/native/sun/font/layout/MultipleSubstSubtables.cpp
! src/share/native/sun/font/layout/MultipleSubstSubtables.h
! src/share/native/sun/font/layout/NonContextualGlyphSubstProc.cpp
! src/share/native/sun/font/layout/NonContextualGlyphSubstProc.h
! src/share/native/sun/font/layout/NonContextualGlyphSubstProc2.cpp
! src/share/native/sun/font/layout/NonContextualGlyphSubstProc2.h
! src/share/native/sun/font/layout/OpenTypeLayoutEngine.cpp
! src/share/native/sun/font/layout/OpenTypeLayoutEngine.h
! src/share/native/sun/font/layout/OpenTypeTables.h
! src/share/native/sun/font/layout/OpenTypeUtilities.cpp
! src/share/native/sun/font/layout/OpenTypeUtilities.h
! src/share/native/sun/font/layout/PairPositioningSubtables.cpp
! src/share/native/sun/font/layout/PairPositioningSubtables.h
! src/share/native/sun/font/layout/ScriptAndLanguage.cpp
! src/share/native/sun/font/layout/ScriptAndLanguage.h
! src/share/native/sun/font/layout/SegmentArrayProcessor.cpp
! src/share/native/sun/font/layout/SegmentArrayProcessor.h
! src/share/native/sun/font/layout/SegmentArrayProcessor2.cpp
! src/share/native/sun/font/layout/SegmentArrayProcessor2.h
! src/share/native/sun/font/layout/SegmentSingleProcessor.cpp
! src/share/native/sun/font/layout/SegmentSingleProcessor.h
! src/share/native/sun/font/layout/SegmentSingleProcessor2.cpp
! src/share/native/sun/font/layout/SegmentSingleProcessor2.h
! src/share/native/sun/font/layout/ShapingTypeData.cpp
! src/share/native/sun/font/layout/SimpleArrayProcessor.cpp
! src/share/native/sun/font/layout/SimpleArrayProcessor.h
! src/share/native/sun/font/layout/SimpleArrayProcessor2.cpp
! src/share/native/sun/font/layout/SimpleArrayProcessor2.h
! src/share/native/sun/font/layout/SinglePositioningSubtables.cpp
! src/share/native/sun/font/layout/SinglePositioningSubtables.h
! src/share/native/sun/font/layout/SingleSubstitutionSubtables.cpp
! src/share/native/sun/font/layout/SingleSubstitutionSubtables.h
! src/share/native/sun/font/layout/SingleTableProcessor.cpp
! src/share/native/sun/font/layout/SingleTableProcessor.h
! src/share/native/sun/font/layout/SingleTableProcessor2.cpp
! src/share/native/sun/font/layout/SingleTableProcessor2.h
! src/share/native/sun/font/layout/StateTableProcessor.cpp
! src/share/native/sun/font/layout/StateTableProcessor.h
! src/share/native/sun/font/layout/StateTableProcessor2.cpp
! src/share/native/sun/font/layout/StateTableProcessor2.h
! src/share/native/sun/font/layout/StateTables.h
! src/share/native/sun/font/layout/SubtableProcessor.cpp
! src/share/native/sun/font/layout/SubtableProcessor.h
! src/share/native/sun/font/layout/SubtableProcessor2.cpp
! src/share/native/sun/font/layout/SubtableProcessor2.h
! src/share/native/sun/font/layout/ThaiLayoutEngine.cpp
! src/share/native/sun/font/layout/TibetanLayoutEngine.cpp
! src/share/native/sun/font/layout/TibetanLayoutEngine.h
! src/share/native/sun/font/layout/TrimmedArrayProcessor.cpp
! src/share/native/sun/font/layout/TrimmedArrayProcessor.h
! src/share/native/sun/font/layout/TrimmedArrayProcessor2.cpp
! src/share/native/sun/font/layout/TrimmedArrayProcessor2.h
! src/share/native/sun/font/layout/ValueRecords.h
! src/share/native/sun/font/sunFont.c

Changeset: 7b03efca912f
Author:    malenkov
Date:      2013-02-05 20:07 +0400
URL:       http://hg.openjdk.java.net/hsx/hotspot-main/jdk/rev/7b03efca912f

8006790: Improve checking for windows
Reviewed-by: art, mschoene

! src/macosx/classes/sun/lwawt/LWWindowPeer.java
! src/macosx/classes/sun/lwawt/macosx/CFileDialog.java
! src/macosx/classes/sun/lwawt/macosx/CPrinterDialogPeer.java
! src/share/classes/java/awt/Window.java
! src/share/classes/java/awt/peer/WindowPeer.java
! src/share/classes/sun/awt/EmbeddedFrame.java
! src/solaris/classes/sun/awt/X11/XWindowPeer.java
! src/windows/classes/sun/awt/windows/WFileDialogPeer.java
! src/windows/classes/sun/awt/windows/WPrintDialogPeer.java
! src/windows/classes/sun/awt/windows/WWindowPeer.java

Changeset: 4ea6d44a20a0
Author:    mullan
Date:      2013-03-27 10:37 +0000
URL:       http://hg.openjdk.java.net/hsx/hotspot-main/jdk/rev/4ea6d44a20a0

8003445: Adjust JAX-WS to focus on API
Reviewed-by: vinnie, ahgross, mgrebac

! src/share/lib/security/java.security-linux
! src/share/lib/security/java.security-macosx
! src/share/lib/security/java.security-solaris
! src/share/lib/security/java.security-windows
! test/Makefile

Changeset: c921d68edf08
Author:    joehw
Date:      2013-02-18 13:02 -0800
URL:       http://hg.openjdk.java.net/hsx/hotspot-main/jdk/rev/c921d68edf08

6657673: Issues with JAXP
Reviewed-by: alanb, lancea, ahgross, mullan

! src/share/lib/security/java.security-linux
! src/share/lib/security/java.security-macosx
! src/share/lib/security/java.security-solaris
! src/share/lib/security/java.security-windows
! test/Makefile

Changeset: 6a09e4648cfb
Author:    mkos
Date:      2013-03-07 07:19 -0500
URL:       http://hg.openjdk.java.net/hsx/hotspot-main/jdk/rev/6a09e4648cfb

8005432: Update access to JAX-WS
Summary: newly restricted the whole package com.sun.xml.internal; fix reviewed also by Alexander Fomin
Reviewed-by: mullan, skoivu

! src/share/lib/security/java.security-linux
! src/share/lib/security/java.security-macosx
! src/share/lib/security/java.security-solaris
! src/share/lib/security/java.security-windows

Changeset: 12ca12303c33
Author:    raginip
Date:      2013-03-27 21:32 +0000
URL:       http://hg.openjdk.java.net/hsx/hotspot-main/jdk/rev/12ca12303c33

8007406: Improve accessibility of AccessBridge
Reviewed-by: skoivu, mullan, ptbrunet

! src/share/lib/security/java.security-windows

Changeset: 269b7955a885
Author:    chegar
Date:      2013-03-28 09:50 +0000
URL:       http://hg.openjdk.java.net/hsx/hotspot-main/jdk/rev/269b7955a885

8010944: Incorrectly separated package list in java.security-windows
Reviewed-by: mullan

! src/share/lib/security/java.security-windows

Changeset: 7c663f528ff6
Author:    vlivanov
Date:      2013-03-01 04:45 +0400
URL:       http://hg.openjdk.java.net/hsx/hotspot-main/jdk/rev/7c663f528ff6

8008140: Better method handle resolution
Reviewed-by: jrose, twisti, jdn

! src/share/classes/java/lang/invoke/MethodHandles.java

Changeset: 0fb15205acb6
Author:    bae
Date:      2013-02-19 12:06 +0400
URL:       http://hg.openjdk.java.net/hsx/hotspot-main/jdk/rev/0fb15205acb6

8007675: Improve color conversion
Reviewed-by: prr, mschoene, jgodinez

! src/share/classes/sun/java2d/cmm/lcms/LCMSImageLayout.java
! src/share/classes/sun/java2d/cmm/lcms/LCMSTransform.java

Changeset: b057eaf53935
Author:    chegar
Date:      2013-04-04 17:34 +0100
URL:       http://hg.openjdk.java.net/hsx/hotspot-main/jdk/rev/b057eaf53935

Merge

! src/share/classes/sun/java2d/cmm/lcms/LCMSImageLayout.java
! src/share/classes/sun/java2d/cmm/lcms/LCMSTransform.java

Changeset: 5f46a666e06d
Author:    chegar
Date:      2013-04-13 20:16 +0100
URL:       http://hg.openjdk.java.net/hsx/hotspot-main/jdk/rev/5f46a666e06d

Merge

! src/share/classes/sun/awt/EmbeddedFrame.java
! src/share/lib/security/java.security-linux
! src/share/lib/security/java.security-macosx
! src/share/lib/security/java.security-solaris
! src/share/lib/security/java.security-windows
! src/windows/classes/java/lang/ProcessImpl.java
! test/Makefile

Changeset: 84df34924f67
Author:    chegar
Date:      2013-04-13 21:51 +0100
URL:       http://hg.openjdk.java.net/hsx/hotspot-main/jdk/rev/84df34924f67

Merge

- src/share/classes/java/time/chrono/HijrahDeviationReader.java
- src/share/classes/java/time/format/DateTimeBuilder.java
- src/share/classes/java/time/format/DateTimeFormatStyleProvider.java
- src/share/classes/java/time/temporal/Adjusters.java
- src/share/classes/java/time/temporal/Queries.java
- test/java/time/tck/java/time/TestChronology.java
- test/java/time/tck/java/time/chrono/TestChronoLocalDate.java
- test/java/time/tck/java/time/chrono/TestChronoLocalDateTime.java
- test/java/time/tck/java/time/chrono/TestHijrahChronology.java
- test/java/time/tck/java/time/chrono/TestJapaneseChronology.java
- test/java/time/tck/java/time/chrono/TestMinguoChronology.java
- test/java/time/tck/java/time/chrono/TestThaiBuddhistChronology.java
- test/java/time/tck/java/time/temporal/TCKDateTimeAdjusters.java
- test/java/time/tck/java/time/temporal/TestChronoLocalDate.java
- test/java/time/tck/java/time/temporal/TestChronoLocalDateTime.java
- test/java/time/tck/java/time/temporal/TestChronoZonedDateTime.java
- test/java/time/test/java/time/temporal/TestDateTimeAdjusters.java
- test/java/time/test/java/time/temporal/TestJapaneseChronoImpl.java
- test/java/time/test/java/time/temporal/TestThaiBuddhistChronoImpl.java
- test/java/util/ComparatorsTest.java

Changeset: 9246b0fee2f2
Author:    chegar
Date:      2013-04-16 13:30 +0100
URL:       http://hg.openjdk.java.net/hsx/hotspot-main/jdk/rev/9246b0fee2f2

Merge


Changeset: 10fd3b4a77ae
Author:    chegar
Date:      2013-04-16 21:04 +0100
URL:       http://hg.openjdk.java.net/hsx/hotspot-main/jdk/rev/10fd3b4a77ae

Merge


Changeset: a3cc4b8e217a
Author:    weijun
Date:      2013-04-17 10:15 +0800
URL:       http://hg.openjdk.java.net/hsx/hotspot-main/jdk/rev/a3cc4b8e217a

8011124: Make KerberosTime immutable
Reviewed-by: xuelei

! src/share/classes/sun/security/krb5/KrbApReq.java
! src/share/classes/sun/security/krb5/KrbAppMessage.java
! src/share/classes/sun/security/krb5/KrbCred.java
! src/share/classes/sun/security/krb5/KrbTgsReq.java
! src/share/classes/sun/security/krb5/internal/KerberosTime.java
! src/share/classes/sun/security/krb5/internal/KrbCredInfo.java
! src/share/classes/sun/security/krb5/internal/LastReqEntry.java
! src/share/classes/sun/security/krb5/internal/PAEncTSEnc.java
! src/share/classes/sun/security/krb5/internal/ccache/Credentials.java
! test/sun/security/krb5/MicroTime.java

Changeset: da6addef956e
Author:    mchung
Date:      2013-04-16 21:39 -0700
URL:       http://hg.openjdk.java.net/hsx/hotspot-main/jdk/rev/da6addef956e

8010117: Annotate jdk caller sensitive methods with @sun.reflect.CallerSensitive
Reviewed-by: jrose, alanb, twisti

! make/java/java/FILES_c.gmk
! make/java/java/mapfile-vers
! make/java/java/reorder-i586
! make/java/java/reorder-sparc
! make/java/java/reorder-sparcv9
! makefiles/mapfiles/libjava/mapfile-vers
! makefiles/mapfiles/libjava/reorder-sparc
! makefiles/mapfiles/libjava/reorder-sparcv9
! makefiles/mapfiles/libjava/reorder-x86
! src/share/classes/java/lang/Class.java
! src/share/classes/java/lang/ClassLoader.java
! src/share/classes/java/lang/Package.java
! src/share/classes/java/lang/Runtime.java
! src/share/classes/java/lang/SecurityManager.java
! src/share/classes/java/lang/System.java
! src/share/classes/java/lang/Thread.java
! src/share/classes/java/lang/invoke/BoundMethodHandle.java
! src/share/classes/java/lang/invoke/MemberName.java
! src/share/classes/java/lang/invoke/MethodHandleImpl.java
! src/share/classes/java/lang/invoke/MethodHandleNatives.java
! src/share/classes/java/lang/invoke/MethodHandleProxies.java
! src/share/classes/java/lang/invoke/MethodHandles.java
! src/share/classes/java/lang/reflect/Constructor.java
! src/share/classes/java/lang/reflect/Field.java
! src/share/classes/java/lang/reflect/Method.java
! src/share/classes/java/lang/reflect/Proxy.java
! src/share/classes/java/security/AccessController.java
! src/share/classes/java/sql/DriverManager.java
! src/share/classes/java/util/ResourceBundle.java
! src/share/classes/java/util/concurrent/atomic/AtomicIntegerFieldUpdater.java
! src/share/classes/java/util/concurrent/atomic/AtomicLongFieldUpdater.java
! src/share/classes/java/util/concurrent/atomic/AtomicReferenceFieldUpdater.java
! src/share/classes/java/util/logging/Logger.java
! src/share/classes/javax/script/ScriptEngineManager.java
! src/share/classes/sun/misc/Unsafe.java
+ src/share/classes/sun/reflect/CallerSensitive.java
! src/share/classes/sun/reflect/Reflection.java
! src/share/javavm/export/jvm.h
! src/share/native/java/lang/ClassLoader.c
- src/share/native/java/lang/ResourceBundle.c
! src/share/native/java/lang/SecurityManager.c
! src/share/native/sun/reflect/Reflection.c
! test/Makefile
+ test/sun/reflect/CallerSensitive/CallerSensitiveFinder.java
+ test/sun/reflect/CallerSensitive/MethodFinder.java
+ test/sun/reflect/CallerSensitive/MissingCallerSensitive.java
+ test/sun/reflect/Reflection/GetCallerClass.java
+ test/sun/reflect/Reflection/GetCallerClassTest.java
+ test/sun/reflect/Reflection/GetCallerClassTest.sh

Changeset: 414384c3b3eb
Author:    yhuang
Date:      2013-04-16 22:28 -0700
URL:       http://hg.openjdk.java.net/hsx/hotspot-main/jdk/rev/414384c3b3eb

8011977: ISO 4217 Amendment Number 155
Reviewed-by: naoto

! src/share/classes/java/util/CurrencyData.properties
! test/java/util/Currency/tablea1.txt

Changeset: 779ba708fee3
Author:    yhuang
Date:      2013-04-17 01:04 -0700
URL:       http://hg.openjdk.java.net/hsx/hotspot-main/jdk/rev/779ba708fee3

Merge

- src/share/native/java/lang/ResourceBundle.c

Changeset: 473ed4b94306
Author:    vinnie
Date:      2013-04-11 17:57 +0100
URL:       http://hg.openjdk.java.net/hsx/hotspot-main/jdk/rev/473ed4b94306

7171982: Cipher getParameters() throws RuntimeException: Cannot find SunJCE provider
Reviewed-by: vinnie, wetmore
Contributed-by: Tony Scarpino 

! src/share/classes/com/sun/crypto/provider/CipherCore.java
! src/share/classes/com/sun/crypto/provider/CipherWithWrappingSpi.java
! src/share/classes/com/sun/crypto/provider/ConstructKeys.java
! src/share/classes/com/sun/crypto/provider/DESedeWrapCipher.java
! src/share/classes/com/sun/crypto/provider/DHParameterGenerator.java
! src/share/classes/com/sun/crypto/provider/KeyProtector.java
! src/share/classes/com/sun/crypto/provider/PBECipherCore.java
! src/share/classes/com/sun/crypto/provider/PBES1Core.java
! src/share/classes/com/sun/crypto/provider/PBES2Core.java
! src/share/classes/com/sun/crypto/provider/PBKDF2KeyImpl.java
! src/share/classes/com/sun/crypto/provider/PKCS12PBECipherCore.java
! src/share/classes/com/sun/crypto/provider/RSACipher.java
! src/share/classes/com/sun/crypto/provider/SealedObjectForKeyProtector.java
! src/share/classes/com/sun/crypto/provider/SunJCE.java
+ test/com/sun/crypto/provider/Cipher/UTIL/SunJCEGetInstance.java

Changeset: a6ca7cd399b2
Author:    vinnie
Date:      2013-04-11 18:00 +0100
URL:       http://hg.openjdk.java.net/hsx/hotspot-main/jdk/rev/a6ca7cd399b2

8001596: Incorrect condition check in PBKDF2KeyImpl.JAVA
Reviewed-by: wetmore
Contributed-by: Tony Scarpino 

! src/share/classes/com/sun/crypto/provider/PBKDF2KeyImpl.java
+ test/com/sun/crypto/provider/Cipher/PBE/NegativeLength.java

Changeset: 747a09471fd9
Author:    erikj
Date:      2013-04-11 14:47 -0700
URL:       http://hg.openjdk.java.net/hsx/hotspot-main/jdk/rev/747a09471fd9

8011812: JDK-8011278 breaks the old build
Reviewed-by: tbell, wetmore

! make/sun/splashscreen/Makefile

Changeset: 793e0072bfd6
Author:    wetmore
Date:      2013-04-11 17:29 -0700
URL:       http://hg.openjdk.java.net/hsx/hotspot-main/jdk/rev/793e0072bfd6

8012056: SunJCEInstance needs to run in it's own vm
Reviewed-by: wetmore
Contributed-by: anthony.scarpino at oracle.com

! test/com/sun/crypto/provider/Cipher/UTIL/SunJCEGetInstance.java

Changeset: d8d037a7569e
Author:    xuelei
Date:      2013-04-11 18:57 -0700
URL:       http://hg.openjdk.java.net/hsx/hotspot-main/jdk/rev/d8d037a7569e

8011680: Re-integrate AEAD implementation of JSSE
Summary: It is a re-merge of JDK-7030966.
Reviewed-by: wetmore

! src/share/classes/com/sun/crypto/provider/TlsKeyMaterialGenerator.java
! src/share/classes/sun/security/internal/spec/TlsKeyMaterialParameterSpec.java
! src/share/classes/sun/security/internal/spec/TlsKeyMaterialSpec.java
! src/share/classes/sun/security/pkcs11/P11TlsKeyMaterialGenerator.java
+ src/share/classes/sun/security/ssl/Authenticator.java
! src/share/classes/sun/security/ssl/CipherBox.java
! src/share/classes/sun/security/ssl/CipherSuite.java
! src/share/classes/sun/security/ssl/EngineInputRecord.java
! src/share/classes/sun/security/ssl/EngineOutputRecord.java
! src/share/classes/sun/security/ssl/EngineWriter.java
! src/share/classes/sun/security/ssl/Handshaker.java
! src/share/classes/sun/security/ssl/InputRecord.java
! src/share/classes/sun/security/ssl/JsseJce.java
! src/share/classes/sun/security/ssl/MAC.java
! src/share/classes/sun/security/ssl/OutputRecord.java
! src/share/classes/sun/security/ssl/Record.java
! src/share/classes/sun/security/ssl/SSLEngineImpl.java
! src/share/classes/sun/security/ssl/SSLSocketImpl.java
! test/sun/security/ec/TestEC.java
! test/sun/security/pkcs11/fips/CipherTest.java
! test/sun/security/pkcs11/sslecc/CipherTest.java
! test/sun/security/ssl/com/sun/net/ssl/internal/ssl/SSLEngineImpl/SSLEngineBadBufferArrayAccess.java
+ test/sun/security/ssl/javax/net/ssl/TLSv12/ShortRSAKeyGCM.java
! test/sun/security/ssl/sanity/ciphersuites/CipherSuitesInOrder.java
! test/sun/security/ssl/sanity/interop/CipherTest.java
! test/sun/security/ssl/templates/SSLSocketSSLEngineTemplate.java

Changeset: ea7976ed9bc6
Author:    wetmore
Date:      2013-04-11 19:36 -0700
URL:       http://hg.openjdk.java.net/hsx/hotspot-main/jdk/rev/ea7976ed9bc6

Merge


Changeset: 0f93bd5cc8d7
Author:    wetmore
Date:      2013-04-11 21:03 -0700
URL:       http://hg.openjdk.java.net/hsx/hotspot-main/jdk/rev/0f93bd5cc8d7

6425477: Better support for generation of high entropy random numbers
Reviewed-by: xuelei, weijun, mullan

! src/share/classes/java/security/SecureRandom.java
! src/share/classes/sun/security/pkcs11/P11SecureRandom.java
! src/share/classes/sun/security/provider/SecureRandom.java
! src/share/classes/sun/security/provider/SeedGenerator.java
! src/share/classes/sun/security/provider/SunEntries.java
! src/share/lib/security/java.security-linux
! src/share/lib/security/java.security-macosx
! src/share/lib/security/java.security-solaris
! src/share/lib/security/java.security-windows
! src/solaris/classes/sun/security/provider/NativePRNG.java
! src/solaris/classes/sun/security/provider/NativeSeedGenerator.java
! src/windows/classes/sun/security/mscapi/PRNG.java
! src/windows/classes/sun/security/provider/NativePRNG.java
! src/windows/classes/sun/security/provider/NativeSeedGenerator.java
+ test/sun/security/provider/SecureRandom/StrongSecureRandom.java
+ test/sun/security/provider/SecureRandom/StrongSeedReader.java

Changeset: 5435f112e5ea
Author:    vinnie
Date:      2013-04-12 10:42 -0700
URL:       http://hg.openjdk.java.net/hsx/hotspot-main/jdk/rev/5435f112e5ea

Merge

- src/share/classes/java/time/chrono/HijrahDeviationReader.java
- src/share/classes/java/time/format/DateTimeBuilder.java
- src/share/classes/java/time/format/DateTimeFormatStyleProvider.java
- src/share/classes/java/time/temporal/Adjusters.java
- src/share/classes/java/time/temporal/Queries.java
- test/java/time/tck/java/time/TestChronology.java
- test/java/time/tck/java/time/chrono/TestChronoLocalDate.java
- test/java/time/tck/java/time/chrono/TestChronoLocalDateTime.java
- test/java/time/tck/java/time/chrono/TestHijrahChronology.java
- test/java/time/tck/java/time/chrono/TestJapaneseChronology.java
- test/java/time/tck/java/time/chrono/TestMinguoChronology.java
- test/java/time/tck/java/time/chrono/TestThaiBuddhistChronology.java
- test/java/time/tck/java/time/temporal/TCKDateTimeAdjusters.java
- test/java/time/tck/java/time/temporal/TestChronoLocalDate.java
- test/java/time/tck/java/time/temporal/TestChronoLocalDateTime.java
- test/java/time/tck/java/time/temporal/TestChronoZonedDateTime.java
- test/java/time/test/java/time/temporal/TestDateTimeAdjusters.java
- test/java/time/test/java/time/temporal/TestJapaneseChronoImpl.java
- test/java/time/test/java/time/temporal/TestThaiBuddhistChronoImpl.java

Changeset: 6f80a6584fb9
Author:    vinnie
Date:      2013-04-16 01:44 -0700
URL:       http://hg.openjdk.java.net/hsx/hotspot-main/jdk/rev/6f80a6584fb9

Merge

- test/java/util/ComparatorsTest.java

Changeset: 29cbb4617c92
Author:    vinnie
Date:      2013-04-16 05:11 -0700
URL:       http://hg.openjdk.java.net/hsx/hotspot-main/jdk/rev/29cbb4617c92

Merge


Changeset: 13e18d3ac414
Author:    vinnie
Date:      2013-04-16 05:32 -0700
URL:       http://hg.openjdk.java.net/hsx/hotspot-main/jdk/rev/13e18d3ac414

Merge


Changeset: f90b7503019f
Author:    vinnie
Date:      2013-04-17 02:53 -0700
URL:       http://hg.openjdk.java.net/hsx/hotspot-main/jdk/rev/f90b7503019f

Merge

! src/share/lib/security/java.security-linux
! src/share/lib/security/java.security-macosx
! src/share/lib/security/java.security-solaris
! src/share/lib/security/java.security-windows
- src/share/native/java/lang/ResourceBundle.c

Changeset: 7ded74ffea36
Author:    alanb
Date:      2013-04-17 16:11 +0100
URL:       http://hg.openjdk.java.net/hsx/hotspot-main/jdk/rev/7ded74ffea36

8012019: (fc) Thread.interrupt triggers hang in FileChannelImpl.pread (win)
Reviewed-by: chegar

! src/share/classes/sun/nio/ch/DatagramChannelImpl.java
! src/share/classes/sun/nio/ch/FileChannelImpl.java
! src/share/classes/sun/nio/ch/IOUtil.java
! src/share/classes/sun/nio/ch/NativeDispatcher.java
! src/share/classes/sun/nio/ch/SimpleAsynchronousFileChannelImpl.java
! src/share/classes/sun/nio/ch/SocketChannelImpl.java
! src/solaris/classes/sun/nio/ch/FileDispatcherImpl.java
! src/solaris/classes/sun/nio/ch/SinkChannelImpl.java
! src/solaris/classes/sun/nio/ch/SourceChannelImpl.java
! src/solaris/classes/sun/nio/ch/UnixAsynchronousSocketChannelImpl.java
! src/windows/classes/sun/nio/ch/FileDispatcherImpl.java
+ test/java/nio/channels/FileChannel/InterruptDeadlock.java

Changeset: d9f9040554d6
Author:    mduigou
Date:      2013-04-17 11:39 -0700
URL:       http://hg.openjdk.java.net/hsx/hotspot-main/jdk/rev/d9f9040554d6

8010953: Add primitive summary statistics utils
Reviewed-by: mduigou, dholmes, chegar, darcy
Contributed-by: Brian Goetz 

+ src/share/classes/java/util/DoubleSummaryStatistics.java
+ src/share/classes/java/util/IntSummaryStatistics.java
+ src/share/classes/java/util/LongSummaryStatistics.java

Changeset: 73e3b474125e
Author:    mchung
Date:      2013-04-17 12:04 -0700
URL:       http://hg.openjdk.java.net/hsx/hotspot-main/jdk/rev/73e3b474125e

8004260: dynamic proxy class should have the same Java language access as the proxy interfaces
Reviewed-by: alanb, jrose, jdn

! src/share/classes/java/lang/reflect/Proxy.java
! src/share/classes/java/lang/reflect/ReflectPermission.java
! src/share/classes/sun/misc/ProxyGenerator.java
! src/share/classes/sun/reflect/annotation/AnnotationParser.java
! src/share/classes/sun/rmi/server/Util.java
! src/share/classes/sun/tracing/ProviderSkeleton.java
+ test/java/lang/reflect/Proxy/nonPublicProxy/NonPublicProxyClass.java
+ test/java/lang/reflect/Proxy/nonPublicProxy/SimpleProxy.java
+ test/java/lang/reflect/Proxy/nonPublicProxy/p/Bar.java
+ test/java/lang/reflect/Proxy/nonPublicProxy/p/Foo.java
! test/java/rmi/server/RMIClassLoader/loadProxyClasses/security.policy

Changeset: 7f9f69729934
Author:    coleenp
Date:      2013-04-17 12:50 -0400
URL:       http://hg.openjdk.java.net/hsx/hotspot-main/jdk/rev/7f9f69729934

8009531: Crash when redefining class with annotated method
Summary: Add code to annotated methods and command line flags to the tests to verify bug above
Reviewed-by: acorn, sspitsyn, dcubed, dholmes, alanb

! test/java/lang/instrument/RedefineMethodWithAnnotations.sh
! test/java/lang/instrument/RedefineMethodWithAnnotationsTarget.java
! test/java/lang/instrument/RedefineMethodWithAnnotationsTarget_2.java

Changeset: 36f9e357b84b
Author:    coleenp
Date:      2013-04-17 15:06 -0400
URL:       http://hg.openjdk.java.net/hsx/hotspot-main/jdk/rev/36f9e357b84b

Merge


Changeset: a954e407680c
Author:    lana
Date:      2013-04-17 10:30 -0700
URL:       http://hg.openjdk.java.net/hsx/hotspot-main/jdk/rev/a954e407680c

Merge


Changeset: 17dcb75682b7
Author:    lana
Date:      2013-04-17 12:14 -0700
URL:       http://hg.openjdk.java.net/hsx/hotspot-main/jdk/rev/17dcb75682b7

Merge


Changeset: 131686bea632
Author:    lana
Date:      2013-04-17 12:31 -0700
URL:       http://hg.openjdk.java.net/hsx/hotspot-main/jdk/rev/131686bea632

Merge


Changeset: 674880648db4
Author:    briangoetz
Date:      2013-04-16 13:51 -0400
URL:       http://hg.openjdk.java.net/hsx/hotspot-main/jdk/rev/674880648db4

8010096: Initial java.util.Spliterator putback
Reviewed-by: mduigou, alanb, chegar, darcy
Contributed-by: Paul Sandoz , Brian Goetz , Doug Lea 


! src/share/classes/com/sun/tools/jdi/EventSetImpl.java
! src/share/classes/java/lang/Iterable.java
! src/share/classes/java/util/Arrays.java
! src/share/classes/java/util/Collection.java
! src/share/classes/java/util/Iterator.java
! src/share/classes/java/util/List.java
+ src/share/classes/java/util/PrimitiveIterator.java
! src/share/classes/java/util/Set.java
! src/share/classes/java/util/SortedSet.java
+ src/share/classes/java/util/Spliterator.java
+ src/share/classes/java/util/Spliterators.java
+ src/share/classes/java/util/Tripwire.java
+ test/java/util/Spliterator/SpliteratorLateBindingFailFastTest.java
+ test/java/util/Spliterator/SpliteratorTraversingAndSplittingTest.java

Changeset: 4b8e606f8afb
Author:    lana
Date:      2013-04-17 21:48 -0700
URL:       http://hg.openjdk.java.net/hsx/hotspot-main/jdk/rev/4b8e606f8afb

Merge

! src/macosx/classes/sun/lwawt/LWWindowPeer.java
- src/share/classes/java/time/chrono/HijrahDeviationReader.java
- src/share/classes/java/time/format/DateTimeBuilder.java
- src/share/classes/java/time/format/DateTimeFormatStyleProvider.java
- src/share/classes/java/time/temporal/Adjusters.java
- src/share/classes/java/time/temporal/Queries.java
! src/share/classes/sun/java2d/cmm/lcms/LCMSTransform.java
- src/share/native/java/lang/ResourceBundle.c
! src/solaris/classes/sun/awt/X11/XWindowPeer.java
- test/java/time/tck/java/time/TestChronology.java
- test/java/time/tck/java/time/chrono/TestChronoLocalDate.java
- test/java/time/tck/java/time/chrono/TestChronoLocalDateTime.java
- test/java/time/tck/java/time/chrono/TestHijrahChronology.java
- test/java/time/tck/java/time/chrono/TestJapaneseChronology.java
- test/java/time/tck/java/time/chrono/TestMinguoChronology.java
- test/java/time/tck/java/time/chrono/TestThaiBuddhistChronology.java
- test/java/time/tck/java/time/temporal/TCKDateTimeAdjusters.java
- test/java/time/tck/java/time/temporal/TestChronoLocalDate.java
- test/java/time/tck/java/time/temporal/TestChronoLocalDateTime.java
- test/java/time/tck/java/time/temporal/TestChronoZonedDateTime.java
- test/java/time/test/java/time/temporal/TestDateTimeAdjusters.java
- test/java/time/test/java/time/temporal/TestJapaneseChronoImpl.java
- test/java/time/test/java/time/temporal/TestThaiBuddhistChronoImpl.java
- test/java/util/ComparatorsTest.java

Changeset: 10ad4a4330bc
Author:    lana
Date:      2013-04-23 09:28 -0700
URL:       http://hg.openjdk.java.net/hsx/hotspot-main/jdk/rev/10ad4a4330bc

Merge


Changeset: d5228e624826
Author:    katleman
Date:      2013-04-23 18:25 -0700
URL:       http://hg.openjdk.java.net/hsx/hotspot-main/jdk/rev/d5228e624826

8012643: JDK8 b86 source with GPL header errors
Reviewed-by: dholmes, alanb

! test/java/lang/Runtime/exec/WinCommand.java
! test/java/lang/reflect/Method/DefaultMethodModeling.java

Changeset: 53be90fb39d6
Author:    katleman
Date:      2013-04-25 09:24 -0700
URL:       http://hg.openjdk.java.net/hsx/hotspot-main/jdk/rev/53be90fb39d6

Added tag jdk8-b87 for changeset d5228e624826

! .hgtags


From john.coomes at oracle.com  Fri Apr 26 02:27:19 2013
From: john.coomes at oracle.com (john.coomes at oracle.com)
Date: Fri, 26 Apr 2013 09:27:19 +0000
Subject: hg: hsx/hotspot-main/langtools: 17 new changesets
Message-ID: <20130426092817.31C0F4860C@hg.openjdk.java.net>

Changeset: eb134c8e931d
Author:    bpatel
Date:      2013-04-09 14:18 -0700
URL:       http://hg.openjdk.java.net/hsx/hotspot-main/langtools/rev/eb134c8e931d

8005091: javadoc should be able to return the receiver type
Reviewed-by: jjg

! src/share/classes/com/sun/javadoc/ExecutableMemberDoc.java
! src/share/classes/com/sun/tools/doclets/formats/html/AbstractExecutableMemberWriter.java
! src/share/classes/com/sun/tools/doclets/formats/html/ConstructorWriterImpl.java
! src/share/classes/com/sun/tools/doclets/formats/html/HtmlDocletWriter.java
! src/share/classes/com/sun/tools/doclets/formats/html/MethodWriterImpl.java
! src/share/classes/com/sun/tools/javadoc/ExecutableMemberDocImpl.java
+ test/com/sun/javadoc/testTypeAnnotations/TestTypeAnnotations.java
+ test/com/sun/javadoc/testTypeAnnotations/typeannos/ClassExtends.java
+ test/com/sun/javadoc/testTypeAnnotations/typeannos/ClassParameters.java
+ test/com/sun/javadoc/testTypeAnnotations/typeannos/Fields.java
+ test/com/sun/javadoc/testTypeAnnotations/typeannos/MethodReturnType.java
+ test/com/sun/javadoc/testTypeAnnotations/typeannos/MethodTypeParameters.java
+ test/com/sun/javadoc/testTypeAnnotations/typeannos/Parameters.java
+ test/com/sun/javadoc/testTypeAnnotations/typeannos/Receivers.java
+ test/com/sun/javadoc/testTypeAnnotations/typeannos/Throws.java
+ test/com/sun/javadoc/testTypeAnnotations/typeannos/TypeParameters.java
+ test/com/sun/javadoc/testTypeAnnotations/typeannos/Varargs.java
+ test/com/sun/javadoc/testTypeAnnotations/typeannos/Wildcards.java

Changeset: a4be2c2fe0a1
Author:    vromero
Date:      2013-04-10 12:31 +0100
URL:       http://hg.openjdk.java.net/hsx/hotspot-main/langtools/rev/a4be2c2fe0a1

8011432: javac, compiler regression iterable + captured type
Reviewed-by: mcimadamore

! src/share/classes/com/sun/tools/javac/comp/Lower.java
! test/tools/javac/T5053846/MethodRefDupInConstantPoolTest.java

Changeset: d13af7751456
Author:    lana
Date:      2013-04-11 19:15 -0700
URL:       http://hg.openjdk.java.net/hsx/hotspot-main/langtools/rev/d13af7751456

Merge


Changeset: 137994c189e5
Author:    jfranck
Date:      2013-04-12 12:05 +0200
URL:       http://hg.openjdk.java.net/hsx/hotspot-main/langtools/rev/137994c189e5

7015104: use new subtype of TypeSymbol for type parameters
Reviewed-by: jjg, mcimadamore

! src/share/classes/com/sun/tools/javac/code/Symbol.java
! src/share/classes/com/sun/tools/javac/code/Symtab.java
! src/share/classes/com/sun/tools/javac/code/Type.java
! src/share/classes/com/sun/tools/javac/comp/Infer.java
! test/tools/javac/scope/7017664/CompoundScopeTest.java
! test/tools/javac/types/TypeHarness.java

Changeset: 76537856a54e
Author:    vromero
Date:      2013-04-13 12:25 +0100
URL:       http://hg.openjdk.java.net/hsx/hotspot-main/langtools/rev/76537856a54e

8010659: Javac Crashes while building OpenJFX
Reviewed-by: jjg
Contributed-by: maurizio.cimadamore at oracle.com

+ src/share/classes/com/sun/tools/javac/comp/CompileStates.java
! src/share/classes/com/sun/tools/javac/comp/TransTypes.java
! src/share/classes/com/sun/tools/javac/main/JavaCompiler.java
! src/share/classes/com/sun/tools/javac/processing/JavacProcessingEnvironment.java
+ test/tools/javac/T8010659/CompilerCrashWhenMixingBinariesAndSourcesTest.java
! test/tools/javac/annotations/typeAnnotations/TypeProcOnly.java
! test/tools/javac/annotations/typeAnnotations/packageanno/PackageProcessor.java

Changeset: f10cffab99b4
Author:    bpatel
Date:      2013-04-13 18:48 -0700
URL:       http://hg.openjdk.java.net/hsx/hotspot-main/langtools/rev/f10cffab99b4

8009686: Generated javadoc documentation should be able to display type annotation on an array
Reviewed-by: jjg

! src/share/classes/com/sun/javadoc/ExecutableMemberDoc.java
! src/share/classes/com/sun/javadoc/Type.java
! src/share/classes/com/sun/tools/doclets/formats/html/LinkFactoryImpl.java
! src/share/classes/com/sun/tools/doclets/formats/html/LinkOutputImpl.java
! src/share/classes/com/sun/tools/doclets/internal/toolkit/util/links/LinkFactory.java
! src/share/classes/com/sun/tools/doclets/internal/toolkit/util/links/LinkOutput.java
! src/share/classes/com/sun/tools/javadoc/AbstractTypeImpl.java
! src/share/classes/com/sun/tools/javadoc/ClassDocImpl.java
! src/share/classes/com/sun/tools/javadoc/ExecutableMemberDocImpl.java
! src/share/classes/com/sun/tools/javadoc/PrimitiveType.java
! src/share/classes/com/sun/tools/javadoc/TypeMaker.java
! test/com/sun/javadoc/testTypeAnnotations/TestTypeAnnotations.java
! test/com/sun/javadoc/testTypeAnnotations/typeannos/Fields.java

Changeset: b26f36a7ae3b
Author:    mcimadamore
Date:      2013-04-15 14:11 +0100
URL:       http://hg.openjdk.java.net/hsx/hotspot-main/langtools/rev/b26f36a7ae3b

8011383: Symbol.getModifiers omits ACC_ABSTRACT from interface with default methods
Summary: Fixup for default method modifiers erroneously applies to class-level modifiers
Reviewed-by: jjg

! src/share/classes/com/sun/tools/javac/code/Symbol.java
+ test/tools/javac/defaultMethods/DefaultMethodFlags.java

Changeset: c430f1cde21c
Author:    mcimadamore
Date:      2013-04-15 14:12 +0100
URL:       http://hg.openjdk.java.net/hsx/hotspot-main/langtools/rev/c430f1cde21c

8011377: Javac crashes when multiple lambdas are defined in an array
Summary: Wrong attribution environment used by DeferredAttr
Reviewed-by: jjg

! src/share/classes/com/sun/tools/javac/comp/Flow.java
+ test/tools/javac/lambda/TargetType71.java

Changeset: 083c6b199e2f
Author:    mcimadamore
Date:      2013-04-15 14:15 +0100
URL:       http://hg.openjdk.java.net/hsx/hotspot-main/langtools/rev/083c6b199e2f

8011376: Spurious checked exception errors in nested method call
Summary: Fallback attribution logic doesn't work properly when lambda throws checked exceptions
Reviewed-by: jjg

! src/share/classes/com/sun/tools/javac/comp/Attr.java
+ test/tools/javac/lambda/TargetType72.java

Changeset: 6dacab087652
Author:    mcimadamore
Date:      2013-04-15 14:16 +0100
URL:       http://hg.openjdk.java.net/hsx/hotspot-main/langtools/rev/6dacab087652

8011028: lang/INFR/infr001/infr00101md/infr00101md.java fails to compile after switch to JDK8-b82
Summary: Fix bug in Types.removeWildcards
Reviewed-by: jjg

! src/share/classes/com/sun/tools/javac/code/Types.java
! test/tools/javac/lambda/TargetType69.java
+ test/tools/javac/lambda/TargetType70.java

Changeset: c2315af9cc28
Author:    mcimadamore
Date:      2013-04-15 14:17 +0100
URL:       http://hg.openjdk.java.net/hsx/hotspot-main/langtools/rev/c2315af9cc28

8011392: Missing checkcast when casting to intersection type
Summary: javac should emit a checkcast for each additional target type specified in an intersection type cast
Reviewed-by: jjg

! src/share/classes/com/sun/tools/javac/comp/TransTypes.java
+ test/tools/javac/lambda/Intersection03.java

Changeset: 950e8ac120f0
Author:    mcimadamore
Date:      2013-04-15 14:18 +0100
URL:       http://hg.openjdk.java.net/hsx/hotspot-main/langtools/rev/950e8ac120f0

8010923: Avoid redundant speculative attribution
Summary: Add optimization to avoid speculative attribution for certain argument expressions
Reviewed-by: jjg

! src/share/classes/com/sun/tools/javac/comp/Attr.java
! src/share/classes/com/sun/tools/javac/comp/DeferredAttr.java
! src/share/classes/com/sun/tools/javac/comp/Resolve.java
! src/share/classes/com/sun/tools/javac/tree/TreeInfo.java

Changeset: 49d32c84dfea
Author:    vromero
Date:      2013-04-17 11:11 +0100
URL:       http://hg.openjdk.java.net/hsx/hotspot-main/langtools/rev/49d32c84dfea

8011181: javac, empty UTF8 entry generated for inner class
Reviewed-by: jjg

! src/share/classes/com/sun/tools/javac/jvm/ClassWriter.java
+ test/tools/javac/T8011181/EmptyUTF8ForInnerClassNameTest.java

Changeset: 94870c08391c
Author:    lana
Date:      2013-04-17 10:31 -0700
URL:       http://hg.openjdk.java.net/hsx/hotspot-main/langtools/rev/94870c08391c

Merge


Changeset: cad4fc23f691
Author:    lana
Date:      2013-04-17 21:50 -0700
URL:       http://hg.openjdk.java.net/hsx/hotspot-main/langtools/rev/cad4fc23f691

Merge


Changeset: 1329f9c38d93
Author:    lana
Date:      2013-04-23 09:27 -0700
URL:       http://hg.openjdk.java.net/hsx/hotspot-main/langtools/rev/1329f9c38d93

Merge


Changeset: a1e10f3adc47
Author:    katleman
Date:      2013-04-25 09:24 -0700
URL:       http://hg.openjdk.java.net/hsx/hotspot-main/langtools/rev/a1e10f3adc47

Added tag jdk8-b87 for changeset 1329f9c38d93

! .hgtags


From john.coomes at oracle.com  Fri Apr 26 02:28:29 2013
From: john.coomes at oracle.com (john.coomes at oracle.com)
Date: Fri, 26 Apr 2013 09:28:29 +0000
Subject: hg: hsx/hotspot-main/nashorn: 15 new changesets
Message-ID: <20130426092841.E45634860D@hg.openjdk.java.net>

Changeset: 480b90430d29
Author:    lana
Date:      2013-04-11 19:16 -0700
URL:       http://hg.openjdk.java.net/hsx/hotspot-main/nashorn/rev/480b90430d29

Merge


Changeset: 635a93b61d34
Author:    hannesw
Date:      2013-04-10 14:00 +0200
URL:       http://hg.openjdk.java.net/hsx/hotspot-main/nashorn/rev/635a93b61d34

8011714: Regexp decimal escape handling still not correct
Reviewed-by: lagergren, attila

! src/jdk/nashorn/internal/runtime/regexp/RegExpScanner.java
+ test/script/basic/JDK-8011714.js
+ test/script/basic/JDK-8011714.js.EXPECTED

Changeset: b4ea8678bf15
Author:    hannesw
Date:      2013-04-10 14:05 +0200
URL:       http://hg.openjdk.java.net/hsx/hotspot-main/nashorn/rev/b4ea8678bf15

8011749: Bugs with empty character class handling
Reviewed-by: lagergren, attila

! src/jdk/nashorn/internal/runtime/regexp/RegExpScanner.java
+ test/script/basic/JDK-8011749.js
+ test/script/basic/JDK-8011749.js.EXPECTED

Changeset: 8ae9ed1ac1e2
Author:    hannesw
Date:      2013-04-10 14:08 +0200
URL:       http://hg.openjdk.java.net/hsx/hotspot-main/nashorn/rev/8ae9ed1ac1e2

8011756: Wrong characters supported in RegExp \c escape
Reviewed-by: lagergren, attila

! src/jdk/nashorn/internal/runtime/regexp/RegExpScanner.java
+ test/script/basic/JDK-8011756.js
+ test/script/basic/JDK-8011756.js.EXPECTED

Changeset: 571e06d5d23c
Author:    sundar
Date:      2013-04-11 13:20 +0530
URL:       http://hg.openjdk.java.net/hsx/hotspot-main/nashorn/rev/571e06d5d23c

8011960: [2,1].sort(null) should throw TypeError
Reviewed-by: hannesw, lagergren

! src/jdk/nashorn/internal/objects/NativeArray.java
+ test/script/basic/JDK-8011960.js

Changeset: 256bb030ce0a
Author:    sundar
Date:      2013-04-11 15:04 +0530
URL:       http://hg.openjdk.java.net/hsx/hotspot-main/nashorn/rev/256bb030ce0a

8011974: Comparator function returning negative and positive Infinity does not work as expected with Array.prototype.sort
Reviewed-by: hannesw, lagergren

! src/jdk/nashorn/internal/objects/NativeArray.java
+ test/script/basic/JDK-8011974.js

Changeset: a3fc89d33072
Author:    hannesw
Date:      2013-04-11 12:16 +0200
URL:       http://hg.openjdk.java.net/hsx/hotspot-main/nashorn/rev/a3fc89d33072

8011980: Allow NUL character in character class
Reviewed-by: sundar, lagergren

! src/jdk/nashorn/internal/runtime/regexp/RegExpScanner.java
+ test/script/basic/JDK-8011980.js
+ test/script/basic/JDK-8011980.js.EXPECTED

Changeset: ed4293ceec0e
Author:    hannesw
Date:      2013-04-12 16:31 +0200
URL:       http://hg.openjdk.java.net/hsx/hotspot-main/nashorn/rev/ed4293ceec0e

8011884: Regexp literals are compiled twice
Reviewed-by: lagergren, sundar

! src/jdk/nashorn/internal/runtime/regexp/joni/Analyser.java
! src/jdk/nashorn/internal/runtime/regexp/joni/Regex.java
! src/jdk/nashorn/internal/runtime/regexp/joni/ast/QuantifierNode.java

Changeset: 36e36a2d4312
Author:    hannesw
Date:      2013-04-12 16:32 +0200
URL:       http://hg.openjdk.java.net/hsx/hotspot-main/nashorn/rev/36e36a2d4312

8011885: Switch to Joni as default Regexp engine
Reviewed-by: lagergren, sundar

! src/jdk/nashorn/internal/runtime/regexp/RegExpFactory.java

Changeset: e70e6b38826b
Author:    jlaskey
Date:      2013-04-15 08:39 -0300
URL:       http://hg.openjdk.java.net/hsx/hotspot-main/nashorn/rev/e70e6b38826b

Merge


Changeset: 222a72df2f42
Author:    mchung
Date:      2013-04-16 22:11 -0700
URL:       http://hg.openjdk.java.net/hsx/hotspot-main/nashorn/rev/222a72df2f42

8010117: Annotate jdk caller sensitive methods with @sun.reflect.CallerSensitive
Reviewed-by: jrose, alanb, twisti, sundar

! src/jdk/nashorn/api/scripting/NashornScriptEngineFactory.java
! src/jdk/nashorn/internal/runtime/Context.java

Changeset: 44d8612e29b0
Author:    lana
Date:      2013-04-17 10:31 -0700
URL:       http://hg.openjdk.java.net/hsx/hotspot-main/nashorn/rev/44d8612e29b0

Merge


Changeset: cba329ce5efe
Author:    lana
Date:      2013-04-17 21:50 -0700
URL:       http://hg.openjdk.java.net/hsx/hotspot-main/nashorn/rev/cba329ce5efe

Merge


Changeset: 774aeaa89bc1
Author:    lana
Date:      2013-04-23 09:26 -0700
URL:       http://hg.openjdk.java.net/hsx/hotspot-main/nashorn/rev/774aeaa89bc1

Merge


Changeset: 40c107d1ae6f
Author:    katleman
Date:      2013-04-25 09:24 -0700
URL:       http://hg.openjdk.java.net/hsx/hotspot-main/nashorn/rev/40c107d1ae6f

Added tag jdk8-b87 for changeset 774aeaa89bc1

! .hgtags


From alejandro.murillo at oracle.com  Fri Apr 26 04:20:15 2013
From: alejandro.murillo at oracle.com (alejandro.murillo at oracle.com)
Date: Fri, 26 Apr 2013 11:20:15 +0000
Subject: hg: hsx/hsx25/hotspot: 26 new changesets
Message-ID: <20130426112116.AAF6C48622@hg.openjdk.java.net>

Changeset: 3d641132f83b
Author:    twisti
Date:      2013-02-26 16:16 -0800
URL:       http://hg.openjdk.java.net/hsx/hsx25/hotspot/rev/3d641132f83b

8004336: Better handling of method handle intrinsic frames
Reviewed-by: kvn, jrose, ahgross

! src/share/vm/opto/library_call.cpp

Changeset: 124ca22437b1
Author:    chegar
Date:      2013-04-12 10:14 +0100
URL:       http://hg.openjdk.java.net/hsx/hsx25/hotspot/rev/124ca22437b1

Merge

! src/share/vm/opto/library_call.cpp

Changeset: 6c560f9ebb3e
Author:    lana
Date:      2013-04-17 10:12 -0700
URL:       http://hg.openjdk.java.net/hsx/hsx25/hotspot/rev/6c560f9ebb3e

Merge

- test/gc/6941923/test6941923.sh
- test/gc/TestVerifyBeforeGCDuringStartup.java

Changeset: db9c527a1fd8
Author:    lana
Date:      2013-04-17 21:33 -0700
URL:       http://hg.openjdk.java.net/hsx/hsx25/hotspot/rev/db9c527a1fd8

Merge


Changeset: d4c266784660
Author:    lana
Date:      2013-04-23 09:27 -0700
URL:       http://hg.openjdk.java.net/hsx/hsx25/hotspot/rev/d4c266784660

Merge


Changeset: d080f5168deb
Author:    katleman
Date:      2013-04-25 09:24 -0700
URL:       http://hg.openjdk.java.net/hsx/hsx25/hotspot/rev/d080f5168deb

Added tag jdk8-b87 for changeset d4c266784660

! .hgtags

Changeset: f78763f49817
Author:    amurillo
Date:      2013-04-19 10:09 -0700
URL:       http://hg.openjdk.java.net/hsx/hsx25/hotspot/rev/f78763f49817

8012559: new hotspot build - hs25-b30
Reviewed-by: jcoomes

! make/hotspot_version

Changeset: 63e31ce40bdb
Author:    hseigel
Date:      2013-04-17 08:20 -0400
URL:       http://hg.openjdk.java.net/hsx/hsx25/hotspot/rev/63e31ce40bdb

8009928: PSR:PERF Increase default string table size
Summary: Increase default string table size to 60013 for 64-bit platforms.
Reviewed-by: coleenp, dholmes

! src/share/vm/runtime/arguments.cpp
! src/share/vm/utilities/globalDefinitions.hpp

Changeset: b80cc96882f7
Author:    zgu
Date:      2013-04-18 10:04 -0400
URL:       http://hg.openjdk.java.net/hsx/hsx25/hotspot/rev/b80cc96882f7

8012464: NMT: classes should not derive from _ValueObj, use VALUE_OBJ_CLASS_SPEC instead
Summary: NMT value objects should use VALUE_OBJ_CLASS_SPEC instead of deriving from _ValueObj
Reviewed-by: coleenp, hseigel, dholmes

! src/share/vm/services/memBaseline.hpp
! src/share/vm/services/memPtr.hpp
! src/share/vm/services/memSnapshot.hpp
! src/share/vm/services/memTrackWorker.hpp

Changeset: 41ed397cc0cd
Author:    bharadwaj
Date:      2013-04-18 08:05 -0700
URL:       http://hg.openjdk.java.net/hsx/hsx25/hotspot/rev/41ed397cc0cd

8006267: InterfaceMethod_ref should allow invokestatic and invokespecial
Summary: Lambda changes; spec 0.6.2 - Allow static invokestatic and invokespecial calls to InterfaceMethod_ref
Reviewed-by: dholmes, acorn

! src/share/vm/classfile/classFileParser.cpp
! src/share/vm/classfile/genericSignatures.cpp
! src/share/vm/interpreter/linkResolver.cpp
! src/share/vm/prims/methodHandles.cpp

Changeset: 7815eaceaa8c
Author:    bharadwaj
Date:      2013-04-18 14:03 -0400
URL:       http://hg.openjdk.java.net/hsx/hsx25/hotspot/rev/7815eaceaa8c

Merge


Changeset: 6f817ce50129
Author:    minqi
Date:      2013-04-19 11:08 -0700
URL:       http://hg.openjdk.java.net/hsx/hsx25/hotspot/rev/6f817ce50129

8010992: Remove calls to global ::operator new[] and new
Summary: disable use of global operator new and new[] which could cause unexpected exception and escape from NMT tracking.
Reviewed-by: coleenp, dholmes, zgu
Contributed-by: yumin.qi at oracle.com

! src/os/windows/vm/os_windows.cpp
! src/share/vm/classfile/altHashing.cpp
! src/share/vm/gc_implementation/concurrentMarkSweep/cmsCollectorPolicy.cpp
! src/share/vm/gc_implementation/g1/heapRegionRemSet.cpp
! src/share/vm/memory/allocation.cpp
! src/share/vm/memory/allocation.hpp
! src/share/vm/memory/allocation.inline.hpp
! src/share/vm/memory/cardTableModRefBS.cpp
! src/share/vm/memory/cardTableModRefBS.hpp
! src/share/vm/memory/cardTableRS.cpp
! src/share/vm/memory/cardTableRS.hpp
! src/share/vm/memory/collectorPolicy.cpp
! src/share/vm/opto/idealGraphPrinter.hpp
! src/share/vm/runtime/handles.hpp
! src/share/vm/runtime/reflectionUtils.hpp
! src/share/vm/runtime/synchronizer.cpp
! src/share/vm/runtime/thread.cpp
! src/share/vm/runtime/vmStructs.cpp
! src/share/vm/utilities/events.hpp
! src/share/vm/utilities/quickSort.cpp
! src/share/vm/utilities/workgroup.cpp
! src/share/vm/utilities/workgroup.hpp

Changeset: 17c51f84773a
Author:    dcubed
Date:      2013-04-19 13:48 -0700
URL:       http://hg.openjdk.java.net/hsx/hsx25/hotspot/rev/17c51f84773a

Merge


Changeset: 5b6512efcdc4
Author:    dcubed
Date:      2013-04-19 16:51 -0700
URL:       http://hg.openjdk.java.net/hsx/hsx25/hotspot/rev/5b6512efcdc4

Merge

- make/bsd/makefiles/jvmg.make
- make/bsd/makefiles/profiled.make
- make/linux/makefiles/jvmg.make
- make/linux/makefiles/profiled.make
- make/solaris/makefiles/jvmg.make
- make/solaris/makefiles/profiled.make
- src/os/bsd/vm/chaitin_bsd.cpp
- src/os/linux/vm/chaitin_linux.cpp
- src/os/solaris/vm/chaitin_solaris.cpp
- src/os/windows/vm/chaitin_windows.cpp
! src/os/windows/vm/os_windows.cpp
! src/share/vm/memory/allocation.hpp
! src/share/vm/runtime/vmStructs.cpp

Changeset: 6337ca4dcad8
Author:    sspitsyn
Date:      2013-04-20 04:07 -0700
URL:       http://hg.openjdk.java.net/hsx/hsx25/hotspot/rev/6337ca4dcad8

8008511: JSR 292: MemberName vmtarget refs to methods must be updated at class redefinition
Summary: Lazily create and maintain the MemberNameTable to be able to update MemberName's
Reviewed-by: coleenp, jrose, dholmes
Contributed-by: serguei.spitsyn at oracle.com

! src/share/vm/classfile/javaClasses.cpp
! src/share/vm/classfile/javaClasses.hpp
! src/share/vm/oops/instanceKlass.cpp
! src/share/vm/oops/instanceKlass.hpp
! src/share/vm/prims/jvmtiRedefineClasses.cpp
! src/share/vm/prims/methodHandles.cpp
! src/share/vm/prims/methodHandles.hpp
! src/share/vm/runtime/mutexLocker.cpp
! src/share/vm/runtime/mutexLocker.hpp

Changeset: a527ddd44e07
Author:    mgronlun
Date:      2013-04-20 19:02 +0200
URL:       http://hg.openjdk.java.net/hsx/hsx25/hotspot/rev/a527ddd44e07

6729929: I18N - Taking Heap Dump failed if project path contains multibyte characters
Reviewed-by: dholmes, rbackman
Contributed-by: peter.allwin at oracle.com

! src/share/vm/services/management.cpp

Changeset: 5a9fa2ba85f0
Author:    dcubed
Date:      2013-04-21 20:41 -0700
URL:       http://hg.openjdk.java.net/hsx/hsx25/hotspot/rev/5a9fa2ba85f0

8012907: anti-delta fix for 8010992
Summary: anti-delta fix for 8010992 until 8012902 can be fixed
Reviewed-by: acorn, minqi, rdurbin

! src/os/windows/vm/os_windows.cpp
! src/share/vm/classfile/altHashing.cpp
! src/share/vm/gc_implementation/concurrentMarkSweep/cmsCollectorPolicy.cpp
! src/share/vm/gc_implementation/g1/heapRegionRemSet.cpp
! src/share/vm/memory/allocation.cpp
! src/share/vm/memory/allocation.hpp
! src/share/vm/memory/allocation.inline.hpp
! src/share/vm/memory/cardTableModRefBS.cpp
! src/share/vm/memory/cardTableModRefBS.hpp
! src/share/vm/memory/cardTableRS.cpp
! src/share/vm/memory/cardTableRS.hpp
! src/share/vm/memory/collectorPolicy.cpp
! src/share/vm/opto/idealGraphPrinter.hpp
! src/share/vm/runtime/handles.hpp
! src/share/vm/runtime/reflectionUtils.hpp
! src/share/vm/runtime/synchronizer.cpp
! src/share/vm/runtime/thread.cpp
! src/share/vm/runtime/vmStructs.cpp
! src/share/vm/utilities/events.hpp
! src/share/vm/utilities/quickSort.cpp
! src/share/vm/utilities/workgroup.cpp
! src/share/vm/utilities/workgroup.hpp

Changeset: cc12becb22e7
Author:    dcubed
Date:      2013-04-21 21:05 -0700
URL:       http://hg.openjdk.java.net/hsx/hsx25/hotspot/rev/cc12becb22e7

Merge

! src/os/windows/vm/os_windows.cpp
! src/share/vm/memory/allocation.hpp
! src/share/vm/runtime/vmStructs.cpp

Changeset: ce6d7e43501c
Author:    bharadwaj
Date:      2013-04-23 08:12 -0700
URL:       http://hg.openjdk.java.net/hsx/hsx25/hotspot/rev/ce6d7e43501c

8012961: Do not restrict static interface methods to be private
Summary: Lambda changes; spec 0.6.2 - remove the restriction that was added as part of recent changes made to support upcoming changes to compilation of lambda methods.
Reviewed-by: dholmes, acorn

! src/share/vm/prims/methodHandles.cpp

Changeset: 1ea6a35dcbe5
Author:    jiangli
Date:      2013-04-23 12:32 -0400
URL:       http://hg.openjdk.java.net/hsx/hsx25/hotspot/rev/1ea6a35dcbe5

8012927: 'assert(nbits == 32 || (-(1 << nbits-1) <= x && x < ( 1 << nbits-1))) failed: value out of range' in interpreter initialization.
Summary: Change br_null_short() to br_null().
Reviewed-by: coleenp, hseigel

! src/cpu/sparc/vm/interp_masm_sparc.cpp

Changeset: 35c15dad89ea
Author:    roland
Date:      2013-04-16 17:06 +0200
URL:       http://hg.openjdk.java.net/hsx/hsx25/hotspot/rev/35c15dad89ea

8011901: Unsafe.getAndAddLong(obj, off, delta) does not work properly with long deltas
Summary: instruct xaddL_no_res shouldn't allow 64 bit constants.
Reviewed-by: kvn

! src/cpu/x86/vm/x86_64.ad
+ test/compiler/8011901/Test8011901.java

Changeset: 6a3629cf7075
Author:    roland
Date:      2013-04-24 09:42 +0200
URL:       http://hg.openjdk.java.net/hsx/hsx25/hotspot/rev/6a3629cf7075

8011771: runThese crashed with EAV
Summary: Array bound check elimination's in block motion doesn't always reset its data structures from one step to the other.
Reviewed-by: kvn, twisti

! src/share/vm/c1/c1_RangeCheckElimination.cpp

Changeset: 47766e2d2527
Author:    jiangli
Date:      2013-04-24 18:20 -0400
URL:       http://hg.openjdk.java.net/hsx/hsx25/hotspot/rev/47766e2d2527

8013041: guarantee(this->is8bit(imm8)) failed: Short forward jump exceeds 8-bit offset.
Summary: Change jmpb() to jmp().
Reviewed-by: coleenp, rdurbin, dcubed

! src/cpu/x86/vm/templateInterpreter_x86_32.cpp
! src/cpu/x86/vm/templateInterpreter_x86_64.cpp

Changeset: e8a7a5995e65
Author:    bharadwaj
Date:      2013-04-25 13:10 -0700
URL:       http://hg.openjdk.java.net/hsx/hsx25/hotspot/rev/e8a7a5995e65

Merge


Changeset: c4af77d20454
Author:    amurillo
Date:      2013-04-26 00:29 -0700
URL:       http://hg.openjdk.java.net/hsx/hsx25/hotspot/rev/c4af77d20454

Merge

! .hgtags
- make/bsd/makefiles/jvmg.make
- make/bsd/makefiles/profiled.make
- make/linux/makefiles/jvmg.make
- make/linux/makefiles/profiled.make
- make/solaris/makefiles/jvmg.make
- make/solaris/makefiles/profiled.make
- src/os/bsd/vm/chaitin_bsd.cpp
- src/os/linux/vm/chaitin_linux.cpp
- src/os/solaris/vm/chaitin_solaris.cpp
- src/os/windows/vm/chaitin_windows.cpp

Changeset: 8482058e74bc
Author:    amurillo
Date:      2013-04-26 00:29 -0700
URL:       http://hg.openjdk.java.net/hsx/hsx25/hotspot/rev/8482058e74bc

Added tag hs25-b30 for changeset c4af77d20454

! .hgtags


From alejandro.murillo at oracle.com  Fri Apr 26 07:51:43 2013
From: alejandro.murillo at oracle.com (alejandro.murillo at oracle.com)
Date: Fri, 26 Apr 2013 14:51:43 +0000
Subject: hg: hsx/hotspot-main/hotspot: 9 new changesets
Message-ID: <20130426145216.086AE48634@hg.openjdk.java.net>

Changeset: 3d641132f83b
Author:    twisti
Date:      2013-02-26 16:16 -0800
URL:       http://hg.openjdk.java.net/hsx/hotspot-main/hotspot/rev/3d641132f83b

8004336: Better handling of method handle intrinsic frames
Reviewed-by: kvn, jrose, ahgross

! src/share/vm/opto/library_call.cpp

Changeset: 124ca22437b1
Author:    chegar
Date:      2013-04-12 10:14 +0100
URL:       http://hg.openjdk.java.net/hsx/hotspot-main/hotspot/rev/124ca22437b1

Merge

! src/share/vm/opto/library_call.cpp

Changeset: 6c560f9ebb3e
Author:    lana
Date:      2013-04-17 10:12 -0700
URL:       http://hg.openjdk.java.net/hsx/hotspot-main/hotspot/rev/6c560f9ebb3e

Merge

- test/gc/6941923/test6941923.sh
- test/gc/TestVerifyBeforeGCDuringStartup.java

Changeset: db9c527a1fd8
Author:    lana
Date:      2013-04-17 21:33 -0700
URL:       http://hg.openjdk.java.net/hsx/hotspot-main/hotspot/rev/db9c527a1fd8

Merge


Changeset: d4c266784660
Author:    lana
Date:      2013-04-23 09:27 -0700
URL:       http://hg.openjdk.java.net/hsx/hotspot-main/hotspot/rev/d4c266784660

Merge


Changeset: d080f5168deb
Author:    katleman
Date:      2013-04-25 09:24 -0700
URL:       http://hg.openjdk.java.net/hsx/hotspot-main/hotspot/rev/d080f5168deb

Added tag jdk8-b87 for changeset d4c266784660

! .hgtags

Changeset: c4af77d20454
Author:    amurillo
Date:      2013-04-26 00:29 -0700
URL:       http://hg.openjdk.java.net/hsx/hotspot-main/hotspot/rev/c4af77d20454

Merge

! .hgtags
- make/bsd/makefiles/jvmg.make
- make/bsd/makefiles/profiled.make
- make/linux/makefiles/jvmg.make
- make/linux/makefiles/profiled.make
- make/solaris/makefiles/jvmg.make
- make/solaris/makefiles/profiled.make
- src/os/bsd/vm/chaitin_bsd.cpp
- src/os/linux/vm/chaitin_linux.cpp
- src/os/solaris/vm/chaitin_solaris.cpp
- src/os/windows/vm/chaitin_windows.cpp

Changeset: 8482058e74bc
Author:    amurillo
Date:      2013-04-26 00:29 -0700
URL:       http://hg.openjdk.java.net/hsx/hotspot-main/hotspot/rev/8482058e74bc

Added tag hs25-b30 for changeset c4af77d20454

! .hgtags

Changeset: 57ac6a688ae6
Author:    amurillo
Date:      2013-04-26 00:40 -0700
URL:       http://hg.openjdk.java.net/hsx/hotspot-main/hotspot/rev/57ac6a688ae6

8013227: new hotspot build - hs25-b31
Reviewed-by: jcoomes

! make/hotspot_version


From vladimir.x.ivanov at oracle.com  Fri Apr 26 09:03:40 2013
From: vladimir.x.ivanov at oracle.com (Vladimir Ivanov)
Date: Fri, 26 Apr 2013 20:03:40 +0400
Subject: CFV: New HSX Committer: Igor Ignatyev
Message-ID: <517AA55C.3010906@oracle.com>

I hereby nominate Igor Ignatyev (OpenJDK id: iignatyev) to HSX Committer.

Igor is a member of VM SQE team at Oracle working on HotSpot JVM 
compilers testing. He has already contributed 10 changesets which fixed 
some bugs and significantly improved testability of C1/C2 using WhiteBox 
API [1].

Votes are due by Fri, May 10, 2013 8:00pm UTC.

Only current HSX Committers [2] are eligible to vote on this
nomination.  Votes must be cast in the open by replying to this
mailing list.

For Lazy Consensus voting instructions, see [3].

Best regards,
Vladimir Ivanov

[1] http://hg.openjdk.java.net/hsx/hotspot-comp/hotspot/log?rev=ignatyev
[2] http://openjdk.java.net/census/#hsx
[3] http://openjdk.java.net/projects/#committer-vote

From christian.tornqvist at oracle.com  Fri Apr 26 10:30:26 2013
From: christian.tornqvist at oracle.com (Christian Tornqvist)
Date: Fri, 26 Apr 2013 13:30:26 -0400
Subject: New HSX Committer: Igor Ignatyev
In-Reply-To: <517AA55C.3010906@oracle.com>
References: <517AA55C.3010906@oracle.com>
Message-ID: <02e601ce42a3$bdd1aa60$3974ff20$@tornqvist@oracle.com>

Vote: yes

-----Original Message-----
From: hotspot-dev-bounces at openjdk.java.net
[mailto:hotspot-dev-bounces at openjdk.java.net] On Behalf Of Vladimir Ivanov
Sent: den 26 april 2013 12:04
To: hotspot-dev at openjdk.java.net
Subject: CFV: New HSX Committer: Igor Ignatyev

I hereby nominate Igor Ignatyev (OpenJDK id: iignatyev) to HSX Committer.

Igor is a member of VM SQE team at Oracle working on HotSpot JVM compilers
testing. He has already contributed 10 changesets which fixed some bugs and
significantly improved testability of C1/C2 using WhiteBox API [1].

Votes are due by Fri, May 10, 2013 8:00pm UTC.

Only current HSX Committers [2] are eligible to vote on this nomination.
Votes must be cast in the open by replying to this mailing list.

For Lazy Consensus voting instructions, see [3].

Best regards,
Vladimir Ivanov

[1] http://hg.openjdk.java.net/hsx/hotspot-comp/hotspot/log?rev=ignatyev
[2] http://openjdk.java.net/census/#hsx
[3] http://openjdk.java.net/projects/#committer-vote


From vladimir.kozlov at oracle.com  Fri Apr 26 10:41:59 2013
From: vladimir.kozlov at oracle.com (Vladimir Kozlov)
Date: Fri, 26 Apr 2013 10:41:59 -0700
Subject: CFV: New HSX Committer: Igor Ignatyev
In-Reply-To: <517AA55C.3010906@oracle.com>
References: <517AA55C.3010906@oracle.com>
Message-ID: <517ABC67.1080507@oracle.com>

Vote: yes

On 4/26/13 9:03 AM, Vladimir Ivanov wrote:
> I hereby nominate Igor Ignatyev (OpenJDK id: iignatyev) to HSX Committer.
>
> Igor is a member of VM SQE team at Oracle working on HotSpot JVM
> compilers testing. He has already contributed 10 changesets which fixed
> some bugs and significantly improved testability of C1/C2 using WhiteBox
> API [1].
>
> Votes are due by Fri, May 10, 2013 8:00pm UTC.
>
> Only current HSX Committers [2] are eligible to vote on this
> nomination.  Votes must be cast in the open by replying to this
> mailing list.
>
> For Lazy Consensus voting instructions, see [3].
>
> Best regards,
> Vladimir Ivanov
>
> [1] http://hg.openjdk.java.net/hsx/hotspot-comp/hotspot/log?rev=ignatyev
> [2] http://openjdk.java.net/census/#hsx
> [3] http://openjdk.java.net/projects/#committer-vote

From christian.thalinger at oracle.com  Fri Apr 26 14:07:34 2013
From: christian.thalinger at oracle.com (Christian Thalinger)
Date: Fri, 26 Apr 2013 14:07:34 -0700
Subject: CFV: New HSX Committer: Igor Ignatyev
In-Reply-To: <517AA55C.3010906@oracle.com>
References: <517AA55C.3010906@oracle.com>
Message-ID: 

Vote: yes

On Apr 26, 2013, at 9:03 AM, Vladimir Ivanov  wrote:

> I hereby nominate Igor Ignatyev (OpenJDK id: iignatyev) to HSX Committer.
> 
> Igor is a member of VM SQE team at Oracle working on HotSpot JVM compilers testing. He has already contributed 10 changesets which fixed some bugs and significantly improved testability of C1/C2 using WhiteBox API [1].
> 
> Votes are due by Fri, May 10, 2013 8:00pm UTC.
> 
> Only current HSX Committers [2] are eligible to vote on this
> nomination.  Votes must be cast in the open by replying to this
> mailing list.
> 
> For Lazy Consensus voting instructions, see [3].
> 
> Best regards,
> Vladimir Ivanov
> 
> [1] http://hg.openjdk.java.net/hsx/hotspot-comp/hotspot/log?rev=ignatyev
> [2] http://openjdk.java.net/census/#hsx
> [3] http://openjdk.java.net/projects/#committer-vote


From serguei.spitsyn at oracle.com  Fri Apr 26 14:33:43 2013
From: serguei.spitsyn at oracle.com (serguei.spitsyn at oracle.com)
Date: Fri, 26 Apr 2013 14:33:43 -0700
Subject: CFV: New HSX Committer: Igor Ignatyev
In-Reply-To: <517AA55C.3010906@oracle.com>
References: <517AA55C.3010906@oracle.com>
Message-ID: <517AF2B7.1050706@oracle.com>

Vote: yes

On 4/26/13 9:03 AM, Vladimir Ivanov wrote:
> I hereby nominate Igor Ignatyev (OpenJDK id: iignatyev) to HSX Committer.
>
> Igor is a member of VM SQE team at Oracle working on HotSpot JVM 
> compilers testing. He has already contributed 10 changesets which 
> fixed some bugs and significantly improved testability of C1/C2 using 
> WhiteBox API [1].
>
> Votes are due by Fri, May 10, 2013 8:00pm UTC.
>
> Only current HSX Committers [2] are eligible to vote on this
> nomination.  Votes must be cast in the open by replying to this
> mailing list.
>
> For Lazy Consensus voting instructions, see [3].
>
> Best regards,
> Vladimir Ivanov
>
> [1] http://hg.openjdk.java.net/hsx/hotspot-comp/hotspot/log?rev=ignatyev
> [2] http://openjdk.java.net/census/#hsx
> [3] http://openjdk.java.net/projects/#committer-vote


From coleen.phillimore at oracle.com  Fri Apr 26 14:46:21 2013
From: coleen.phillimore at oracle.com (Coleen Phillimore)
Date: Fri, 26 Apr 2013 17:46:21 -0400
Subject: CFV: New HSX Committer: Igor Ignatyev
In-Reply-To: <517AA55C.3010906@oracle.com>
References: <517AA55C.3010906@oracle.com>
Message-ID: <517AF5AD.9010406@oracle.com>

Vote: yes

On 4/26/2013 12:03 PM, Vladimir Ivanov wrote:
> I hereby nominate Igor Ignatyev (OpenJDK id: iignatyev) to HSX Committer.
>
> Igor is a member of VM SQE team at Oracle working on HotSpot JVM 
> compilers testing. He has already contributed 10 changesets which 
> fixed some bugs and significantly improved testability of C1/C2 using 
> WhiteBox API [1].
>
> Votes are due by Fri, May 10, 2013 8:00pm UTC.
>
> Only current HSX Committers [2] are eligible to vote on this
> nomination.  Votes must be cast in the open by replying to this
> mailing list.
>
> For Lazy Consensus voting instructions, see [3].
>
> Best regards,
> Vladimir Ivanov
>
> [1] http://hg.openjdk.java.net/hsx/hotspot-comp/hotspot/log?rev=ignatyev
> [2] http://openjdk.java.net/census/#hsx
> [3] http://openjdk.java.net/projects/#committer-vote


From nils.eliasson at oracle.com  Fri Apr 26 14:51:35 2013
From: nils.eliasson at oracle.com (Nils Eliasson)
Date: Fri, 26 Apr 2013 23:51:35 +0200
Subject: CFV: New HSX Committer: Igor Ignatyev
In-Reply-To: <517AA55C.3010906@oracle.com>
References: <517AA55C.3010906@oracle.com>
Message-ID: <517AF6E7.3050701@oracle.com>

Vote: yes

On 2013-04-26 18:03, Vladimir Ivanov wrote:
> I hereby nominate Igor Ignatyev (OpenJDK id: iignatyev) to HSX Committer.
>
> Igor is a member of VM SQE team at Oracle working on HotSpot JVM 
> compilers testing. He has already contributed 10 changesets which 
> fixed some bugs and significantly improved testability of C1/C2 using 
> WhiteBox API [1].
>
> Votes are due by Fri, May 10, 2013 8:00pm UTC.
>
> Only current HSX Committers [2] are eligible to vote on this
> nomination.  Votes must be cast in the open by replying to this
> mailing list.
>
> For Lazy Consensus voting instructions, see [3].
>
> Best regards,
> Vladimir Ivanov
>
> [1] http://hg.openjdk.java.net/hsx/hotspot-comp/hotspot/log?rev=ignatyev
> [2] http://openjdk.java.net/census/#hsx
> [3] http://openjdk.java.net/projects/#committer-vote


From alejandro.murillo at oracle.com  Fri Apr 26 15:26:51 2013
From: alejandro.murillo at oracle.com (Alejandro E Murillo)
Date: Fri, 26 Apr 2013 16:26:51 -0600
Subject: CFV: New HSX Committer: Igor Ignatyev
In-Reply-To: <517AA55C.3010906@oracle.com>
References: <517AA55C.3010906@oracle.com>
Message-ID: <517AFF2B.2080002@oracle.com>

vote: yes

-- 
Alejandro


From calvin.cheung at oracle.com  Fri Apr 26 15:32:43 2013
From: calvin.cheung at oracle.com (Calvin Cheung)
Date: Fri, 26 Apr 2013 15:32:43 -0700
Subject: RFR: 8011661: Insufficient memory message says "malloc" when sometimes
	it should say "mmap"
Message-ID: <517B008B.1020201@oracle.com>

Problem: needs a way to differentiate the 2 OOM error cases - malloc or mmap

Fix:
Adding an enum parameter to the vm_exit_out_of_memory macro and the 
report_vm_out_of_memory
function so that the caller can indicate whether it's a malloc or mmap 
error.
Main changes are in debug.[cpp | hpp] and vmError.[cpp | hpp].
Other changes are mainly for passing in the additional enum when calling 
vm_exit_out_of_memory.

Test coverage:
     jprt

webrev: http://cr.openjdk.java.net/~ccheung/8011661/webrev/
jbs: https://jbs.oracle.com/bugs/browse/JDK-8011661
bugs.sun.com: http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=8011661

thanks,
Calvin

From john.cuthbertson at oracle.com  Fri Apr 26 17:05:54 2013
From: john.cuthbertson at oracle.com (john.cuthbertson at oracle.com)
Date: Sat, 27 Apr 2013 00:05:54 +0000
Subject: hg: hsx/hsx24/hotspot: 7196080: assert(max_heap >= InitialHeapSize)
	in arguments.cpp
Message-ID: <20130427000558.36D0F48655@hg.openjdk.java.net>

Changeset: 753f6a1ba497
Author:    tamao
Date:      2013-03-20 12:27 -0700
URL:       http://hg.openjdk.java.net/hsx/hsx24/hotspot/rev/753f6a1ba497

7196080: assert(max_heap >= InitialHeapSize) in arguments.cpp
Summary: Remove the related assertions becasue they do not hold here.
Reviewed-by: jmasa, tschatzl
Contributed-by: tamao 

! src/share/vm/runtime/arguments.cpp


From vladimir.danushevsky at oracle.com  Fri Apr 26 17:34:52 2013
From: vladimir.danushevsky at oracle.com (Vladimir Danushevsky)
Date: Fri, 26 Apr 2013 20:34:52 -0400
Subject: RFR: 8013398: Adjust number of stack guard pages on systems with
	large memory page size
Message-ID: 

Please review the following change:

http://cr.openjdk.java.net/~vladidan/8013398/webrev.00/

for 
https://jbs.oracle.com/bugs/browse/JDK-8013398

On a non-typical Linux system configuration with large page size (e.g. 64KB) significant amount of virtual memory is wasted to multiple guard pages when in fact that can be reduced to a single page per Red/Yellow/Shadow categories.
In some edge cases a minimal stack requirement is calculated higher than actual stack size specified by ThreadStackSize parameter causing VM to abort unless stack size is overwritten via -Xss option. 

A patch currently being suggested adjusts amount of guard pages to a single memory page each along with minimal stack size when memory page size exceed 8KB unless explicitly overwritten in command line. 

Currently we are aware of the problem on some Linux platforms, therefore the change is specific to that OS only (Solaris carries a similar approach already).

Shall the description string of StackRedPage, StackYellowPages and StackShadow pages be modified to reflect the values could be scaled down? If so the comment needs to indicate the change affects Linux and Solaris only. Any comments welcome here.

Thanks,
Vlad

From bengt.rutisson at oracle.com  Sun Apr 28 23:55:37 2013
From: bengt.rutisson at oracle.com (Bengt Rutisson)
Date: Mon, 29 Apr 2013 08:55:37 +0200
Subject: CFV: New HSX Committer: Igor Ignatyev
In-Reply-To: <517AA55C.3010906@oracle.com>
References: <517AA55C.3010906@oracle.com>
Message-ID: <517E1969.1020100@oracle.com>


Vote: yes

Bengt

On 4/26/13 6:03 PM, Vladimir Ivanov wrote:
> I hereby nominate Igor Ignatyev (OpenJDK id: iignatyev) to HSX Committer.
>
> Igor is a member of VM SQE team at Oracle working on HotSpot JVM 
> compilers testing. He has already contributed 10 changesets which 
> fixed some bugs and significantly improved testability of C1/C2 using 
> WhiteBox API [1].
>
> Votes are due by Fri, May 10, 2013 8:00pm UTC.
>
> Only current HSX Committers [2] are eligible to vote on this
> nomination.  Votes must be cast in the open by replying to this
> mailing list.
>
> For Lazy Consensus voting instructions, see [3].
>
> Best regards,
> Vladimir Ivanov
>
> [1] http://hg.openjdk.java.net/hsx/hotspot-comp/hotspot/log?rev=ignatyev
> [2] http://openjdk.java.net/census/#hsx
> [3] http://openjdk.java.net/projects/#committer-vote


From mikael.gerdin at oracle.com  Mon Apr 29 01:34:14 2013
From: mikael.gerdin at oracle.com (Mikael Gerdin)
Date: Mon, 29 Apr 2013 10:34:14 +0200
Subject: CFV: New HSX Committer: Igor Ignatyev
In-Reply-To: <517AA55C.3010906@oracle.com>
References: <517AA55C.3010906@oracle.com>
Message-ID: <517E3086.2010905@oracle.com>

Vote: yes

/m

On 2013-04-26 18:03, Vladimir Ivanov wrote:
> I hereby nominate Igor Ignatyev (OpenJDK id: iignatyev) to HSX Committer.
>
> Igor is a member of VM SQE team at Oracle working on HotSpot JVM
> compilers testing. He has already contributed 10 changesets which fixed
> some bugs and significantly improved testability of C1/C2 using WhiteBox
> API [1].
>
> Votes are due by Fri, May 10, 2013 8:00pm UTC.
>
> Only current HSX Committers [2] are eligible to vote on this
> nomination.  Votes must be cast in the open by replying to this
> mailing list.
>
> For Lazy Consensus voting instructions, see [3].
>
> Best regards,
> Vladimir Ivanov
>
> [1] http://hg.openjdk.java.net/hsx/hotspot-comp/hotspot/log?rev=ignatyev
> [2] http://openjdk.java.net/census/#hsx
> [3] http://openjdk.java.net/projects/#committer-vote

From erik.joelsson at oracle.com  Mon Apr 29 05:40:23 2013
From: erik.joelsson at oracle.com (Erik Joelsson)
Date: Mon, 29 Apr 2013 14:40:23 +0200
Subject: RFR: Project files for Solaris Studio / NetBeans
In-Reply-To: <51793525.1050108@oracle.com>
References: <51507B60.6030809@oracle.com> <51531883.7070903@oracle.com>
	<51793525.1050108@oracle.com>
Message-ID: <517E6A37.3030407@oracle.com>

I think this looks good enough now.

/Erik

On 2013-04-25 15:52, Jesper Wilhelmsson wrote:
> Hi,
>
> A new version of the project files are now available:
>
> http://cr.openjdk.java.net/~jwilhelm/7074926/webrev.4/
>
> A new platform was added, we now support Mac, Linux and Solaris.
>
> The project was moved to /common/nb_native/nbproject/ to clearly 
> indicate that this project only indexes the C++ part of OpenJDK.
>
> Thanks for everyones comments!
> /Jesper
>
>
> Jesper Wilhelmsson skrev 27/3/13 5:04 PM:
>> Hi,
>>
>> A new webrev is now available. The issues reported from the first 
>> review should
>> be fixed and the project now contains configurations for both 
>> Linux_64 and Mac_64.
>>
>> To select configuration there is a dropdown menu next to the build 
>> button.
>>
>> http://cr.openjdk.java.net/~jwilhelm/7074926/webrev.2/
>>
>> Thanks,
>> /Jesper
>>
>>
>> Jesper Wilhelmsson skrev 25/3/13 5:29 PM:
>>> Hi,
>>>
>>> Sorry for cross posting, but I think this could be useful for 
>>> several areas.
>>>
>>> I would like to add Solaris Studio / NetBeans project files for the 
>>> entire
>>> OpenJDK project. To clarify: One project that contains the entire 
>>> OpenJDK.
>>>
>>>
>>> With the new build infrastructure in JDK 8 building the entire 
>>> OpenJDK is fairly
>>> fast and even though I personally mostly work in the HotSpot tree, I 
>>> tend to
>>> always clone and build the entire JDK forest. I find this to have 
>>> several
>>> benefits.
>>>
>>> Webrev: http://cr.openjdk.java.net/~jwilhelm/7074926/webrev/
>>>
>>> The configuration in this project is currently Mac only. Linux and 
>>> Solaris
>>> configurations are also planned.
>>>
>>> The webrev is made from the jdk8/build repository which is where I 
>>> think a
>>> change like this should go in. Let me know if you think something else.
>>>
>>>
>>>
>>> To use this project (once pushed):
>>>
>>> 1. Clone your favorite repository
>>>     hg clone http://hg.openjdk.java.net/hsx/hotspot-gc
>>>
>>> 2. Get the whole forest
>>>     cd hotspot-gc
>>>     sh get_source.sh
>>>
>>> 3. Configure
>>>     sh configure
>>>
>>> 4. Open Solaris studio / NetBeans and load the project.
>>>     The project in located in the common directory.
>>>
>>>
>>> Thanks,
>>> /Jesper

From zhengyu.gu at oracle.com  Mon Apr 29 07:01:19 2013
From: zhengyu.gu at oracle.com (Zhengyu Gu)
Date: Mon, 29 Apr 2013 10:01:19 -0400
Subject: RFR: 8011661: Insufficient memory message says "malloc" when
	sometimes it should say "mmap"
In-Reply-To: <517B008B.1020201@oracle.com>
References: <517B008B.1020201@oracle.com>
Message-ID: 

Good to me.

Thanks,

-Zhengyu

On Apr 26, 2013, at 6:32 PM, Calvin Cheung wrote:

> Problem: needs a way to differentiate the 2 OOM error cases - malloc or mmap
> 
> Fix:
> Adding an enum parameter to the vm_exit_out_of_memory macro and the report_vm_out_of_memory
> function so that the caller can indicate whether it's a malloc or mmap error.
> Main changes are in debug.[cpp | hpp] and vmError.[cpp | hpp].
> Other changes are mainly for passing in the additional enum when calling vm_exit_out_of_memory.
> 
> Test coverage:
>    jprt
> 
> webrev: http://cr.openjdk.java.net/~ccheung/8011661/webrev/
> jbs: https://jbs.oracle.com/bugs/browse/JDK-8011661
> bugs.sun.com: http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=8011661
> 
> thanks,
> Calvin


From volker.simonis at gmail.com  Mon Apr 29 08:03:45 2013
From: volker.simonis at gmail.com (Volker Simonis)
Date: Mon, 29 Apr 2013 17:03:45 +0200
Subject: RFR: 8013398: Adjust number of stack guard pages on systems with
	large memory page size
In-Reply-To: 
References: 
Message-ID: 

Hi Vlad,

thanks for addressing this issue. We have this problem as well since
long time and we would like to propose a more general solution:

Introduce three new platform dependant product flags:

StackYellowSize
StackRedSize
StackShadowSize

which are to be used to specify the concrete size of the corresponding
stack regions. These sizes would be rounded up to the next multiple of
the current OS page size (or more precisely the next multiple of the
current OS stack page size, because there are systems which have
different page sizes for stacks than for heap).

This would allow us to make simple, (i.e. not platform dependent)
product flags out of:

StackYellowPages
StackRedPages
StackShadowPages

and set their default value to -1.

At VM start-up, before argument parsing, we will compute the values
for StackYellowPages, StackRedPages, StackShadowPages from
StackYellowSize, StackRedSize, StackShadowSize and the actual OS page
size. Later on, during argument parsing, if one of these flags is
given on the command line, either part of these value pairs may be
adjusted in order to be consistent with its counterpart.

The drawback of this approach is that you get three more options but
from our point of view this is outweighed by the fact that with this
approach you 'fix' all the places where you currently waste a lot of
memory if the VM is running on a system with a default page size
bigger than 4K.

Notice that we use this approach since years in our commercial VM and
only haven't integrated it into our OpenJDK PowerPC/AIX Port because
we wanted to minimize the amount of shared code changes. We would be
happy however to contribute it now that the discussion on this problem
has popped up publicly on the mailing list. So if you agree, I could
post a webrev with the proposed changes.

Regards,
Volker

On Sat, Apr 27, 2013 at 2:34 AM, Vladimir Danushevsky
 wrote:
> Please review the following change:
>
> http://cr.openjdk.java.net/~vladidan/8013398/webrev.00/
>
> for
> https://jbs.oracle.com/bugs/browse/JDK-8013398
>
> On a non-typical Linux system configuration with large page size (e.g. 64KB) significant amount of virtual memory is wasted to multiple guard pages when in fact that can be reduced to a single page per Red/Yellow/Shadow categories.
> In some edge cases a minimal stack requirement is calculated higher than actual stack size specified by ThreadStackSize parameter causing VM to abort unless stack size is overwritten via -Xss option.
>
> A patch currently being suggested adjusts amount of guard pages to a single memory page each along with minimal stack size when memory page size exceed 8KB unless explicitly overwritten in command line.
>
> Currently we are aware of the problem on some Linux platforms, therefore the change is specific to that OS only (Solaris carries a similar approach already).
>
> Shall the description string of StackRedPage, StackYellowPages and StackShadow pages be modified to reflect the values could be scaled down? If so the comment needs to indicate the change affects Linux and Solaris only. Any comments welcome here.
>
> Thanks,
> Vlad

From vladimir.danushevsky at oracle.com  Mon Apr 29 08:38:10 2013
From: vladimir.danushevsky at oracle.com (Vladimir Danushevsky)
Date: Mon, 29 Apr 2013 11:38:10 -0400
Subject: RFR: 8013398: Adjust number of stack guard pages on systems with
	large memory page size
In-Reply-To: 
References: 
	
Message-ID: <8A85EDB0-C7C1-4695-8EA0-71AD6D9EA4E0@oracle.com>

Hi Volker,

Thanks for the suggestion.

If I understand your approach correctly you suggest providing a dual way to specify guard area sizes (ether through number of pages or through an absolute size in KB) and have the VM to correlate between the two: Size value will dominate unless explicitly overwritten by the Page value.
Is that correct?

Will your approach eventually get same amount of allocated guard area as the patch suggested earlier would?
If an intent is to make the adjustments global (i.e. independent of the OS) should we copy those to the arguments.cpp instead of os_.cpp?However  I'm not positive whether Windows, as an example, does need a guard area adjustment (but I might be wrong here).

Please post the webrev with the approach you suggested. It should be viewed as an alternative.

Thanks,
Vlad


On Apr 29, 2013, at 11:03 AM, Volker Simonis wrote:

> Hi Vlad,
> 
> thanks for addressing this issue. We have this problem as well since
> long time and we would like to propose a more general solution:
> 
> Introduce three new platform dependant product flags:
> 
> StackYellowSize
> StackRedSize
> StackShadowSize
> 
> which are to be used to specify the concrete size of the corresponding
> stack regions. These sizes would be rounded up to the next multiple of
> the current OS page size (or more precisely the next multiple of the
> current OS stack page size, because there are systems which have
> different page sizes for stacks than for heap).
> 
> This would allow us to make simple, (i.e. not platform dependent)
> product flags out of:
> 
> StackYellowPages
> StackRedPages
> StackShadowPages
> 
> and set their default value to -1.
> 
> At VM start-up, before argument parsing, we will compute the values
> for StackYellowPages, StackRedPages, StackShadowPages from
> StackYellowSize, StackRedSize, StackShadowSize and the actual OS page
> size. Later on, during argument parsing, if one of these flags is
> given on the command line, either part of these value pairs may be
> adjusted in order to be consistent with its counterpart.
> 
> The drawback of this approach is that you get three more options but
> from our point of view this is outweighed by the fact that with this
> approach you 'fix' all the places where you currently waste a lot of
> memory if the VM is running on a system with a default page size
> bigger than 4K.
> 
> Notice that we use this approach since years in our commercial VM and
> only haven't integrated it into our OpenJDK PowerPC/AIX Port because
> we wanted to minimize the amount of shared code changes. We would be
> happy however to contribute it now that the discussion on this problem
> has popped up publicly on the mailing list. So if you agree, I could
> post a webrev with the proposed changes.
> 
> Regards,
> Volker
> 
> On Sat, Apr 27, 2013 at 2:34 AM, Vladimir Danushevsky
>  wrote:
>> Please review the following change:
>> 
>> http://cr.openjdk.java.net/~vladidan/8013398/webrev.00/
>> 
>> for
>> https://jbs.oracle.com/bugs/browse/JDK-8013398
>> 
>> On a non-typical Linux system configuration with large page size (e.g. 64KB) significant amount of virtual memory is wasted to multiple guard pages when in fact that can be reduced to a single page per Red/Yellow/Shadow categories.
>> In some edge cases a minimal stack requirement is calculated higher than actual stack size specified by ThreadStackSize parameter causing VM to abort unless stack size is overwritten via -Xss option.
>> 
>> A patch currently being suggested adjusts amount of guard pages to a single memory page each along with minimal stack size when memory page size exceed 8KB unless explicitly overwritten in command line.
>> 
>> Currently we are aware of the problem on some Linux platforms, therefore the change is specific to that OS only (Solaris carries a similar approach already).
>> 
>> Shall the description string of StackRedPage, StackYellowPages and StackShadow pages be modified to reflect the values could be scaled down? If so the comment needs to indicate the change affects Linux and Solaris only. Any comments welcome here.
>> 
>> Thanks,
>> Vlad


From roland.westrelin at oracle.com  Mon Apr 29 08:49:45 2013
From: roland.westrelin at oracle.com (Roland Westrelin)
Date: Mon, 29 Apr 2013 17:49:45 +0200
Subject: CFV: New HSX Committer: Igor Ignatyev
In-Reply-To: <517AA55C.3010906@oracle.com>
References: <517AA55C.3010906@oracle.com>
Message-ID: <351E37AF-67BF-44CE-A9FC-610A56808901@oracle.com>

Vote: yes.

Roland.

From volker.simonis at gmail.com  Mon Apr 29 09:55:55 2013
From: volker.simonis at gmail.com (Volker Simonis)
Date: Mon, 29 Apr 2013 18:55:55 +0200
Subject: RFR: 8013398: Adjust number of stack guard pages on systems with
	large memory page size
In-Reply-To: <8A85EDB0-C7C1-4695-8EA0-71AD6D9EA4E0@oracle.com>
References: 
	
	<8A85EDB0-C7C1-4695-8EA0-71AD6D9EA4E0@oracle.com>
Message-ID: 

On Mon, Apr 29, 2013 at 5:38 PM, Vladimir Danushevsky
 wrote:
> Hi Volker,
>
> Thanks for the suggestion.
>
> If I understand your approach correctly you suggest providing a dual way to specify guard area sizes (ether through number of pages or through an absolute size in KB) and have the VM to correlate between the two: Size value will dominate unless explicitly overwritten by the Page value.
> Is that correct?
>

Yes, that's correct. The *Page values should become obsolete although
I think there's currently no mechanism for that in OpenJDK.

Internally, i.e. in globals_.hpp, we could define the values
independently of the actual system page size with the *Size flags.

> Will your approach eventually get same amount of allocated guard area as the patch suggested earlier would?

I think more or less yes:) It would depend on the settings of the
*Size flags of course.

E.g. currently on AMD64 we have:

define_pd_global(intx, StackYellowPages, 2);
define_pd_global(intx, StackRedPages, 1);
define_pd_global(intx, StackShadowPages, NOT_WIN64(20) WIN64_ONLY(6)
DEBUG_ONLY(+2));

With your fix and a page size of 64K we would get:

StackYellowPages = 1;
StackRedPages = 1;
StackShadowPages = round_to((StackShadowPages * 8K), 64K) / 64K =
round_to(20 * 8K, 64K) / 64K = 3

and:

min_staqck =
(StackYellowPages+StackRedPages+StackShadowPages) * Linux::page_size() +
(2*BytesPerWord COMPILER2_PRESENT(+1)) * Linux::vm_default_page_size()
=
(1 + 1 + 3) * 64K +
(16 + 1) * 8K
=
5 * 64K + 17 * 8K
=
456K

With our proposed fix we would get:

define_pd_global(intx, StackYellowSize, 8K);
define_pd_global(intx, StackRedSize, 4K);
define_pd_global(intx, StackShadowSize, NOT_WIN64(80K) WIN64_ONLY(24K)
DEBUG_ONLY(+8K));

this would result in:

StackYellowPages = 1;
StackRedPages = 1;
StackShadowPages = 2

and:

min_staqck =
(StackYellowPages+StackRedPages+StackShadowPages) * Linux::page_size() +
(2*BytesPerWord COMPILER2_PRESENT(+1)) * Linux::vm_default_page_size()
=
(1 + 1 + 2) * 64K +
(16 + 1) * 8K
=
4 * 64K + 17 * 8K
=
392

> If an intent is to make the adjustments global (i.e. independent of the OS) should we copy those to the arguments.cpp instead of os_.cpp?However  I'm not positive whether Windows, as an example, does need a guard area adjustment (but I might be wrong here).
>

I think the adjustment should stay in the platform dependent code.

> Please post the webrev with the approach you suggested. It should be viewed as an alternative.

I'll prepare it.

Just one question - why did you choose:

_vm_default_page_size = 8K

Shouldn't this really be 4K?

>
> Thanks,
> Vlad
>
>
> On Apr 29, 2013, at 11:03 AM, Volker Simonis wrote:
>
>> Hi Vlad,
>>
>> thanks for addressing this issue. We have this problem as well since
>> long time and we would like to propose a more general solution:
>>
>> Introduce three new platform dependant product flags:
>>
>> StackYellowSize
>> StackRedSize
>> StackShadowSize
>>
>> which are to be used to specify the concrete size of the corresponding
>> stack regions. These sizes would be rounded up to the next multiple of
>> the current OS page size (or more precisely the next multiple of the
>> current OS stack page size, because there are systems which have
>> different page sizes for stacks than for heap).
>>
>> This would allow us to make simple, (i.e. not platform dependent)
>> product flags out of:
>>
>> StackYellowPages
>> StackRedPages
>> StackShadowPages
>>
>> and set their default value to -1.
>>
>> At VM start-up, before argument parsing, we will compute the values
>> for StackYellowPages, StackRedPages, StackShadowPages from
>> StackYellowSize, StackRedSize, StackShadowSize and the actual OS page
>> size. Later on, during argument parsing, if one of these flags is
>> given on the command line, either part of these value pairs may be
>> adjusted in order to be consistent with its counterpart.
>>
>> The drawback of this approach is that you get three more options but
>> from our point of view this is outweighed by the fact that with this
>> approach you 'fix' all the places where you currently waste a lot of
>> memory if the VM is running on a system with a default page size
>> bigger than 4K.
>>
>> Notice that we use this approach since years in our commercial VM and
>> only haven't integrated it into our OpenJDK PowerPC/AIX Port because
>> we wanted to minimize the amount of shared code changes. We would be
>> happy however to contribute it now that the discussion on this problem
>> has popped up publicly on the mailing list. So if you agree, I could
>> post a webrev with the proposed changes.
>>
>> Regards,
>> Volker
>>
>> On Sat, Apr 27, 2013 at 2:34 AM, Vladimir Danushevsky
>>  wrote:
>>> Please review the following change:
>>>
>>> http://cr.openjdk.java.net/~vladidan/8013398/webrev.00/
>>>
>>> for
>>> https://jbs.oracle.com/bugs/browse/JDK-8013398
>>>
>>> On a non-typical Linux system configuration with large page size (e.g. 64KB) significant amount of virtual memory is wasted to multiple guard pages when in fact that can be reduced to a single page per Red/Yellow/Shadow categories.
>>> In some edge cases a minimal stack requirement is calculated higher than actual stack size specified by ThreadStackSize parameter causing VM to abort unless stack size is overwritten via -Xss option.
>>>
>>> A patch currently being suggested adjusts amount of guard pages to a single memory page each along with minimal stack size when memory page size exceed 8KB unless explicitly overwritten in command line.
>>>
>>> Currently we are aware of the problem on some Linux platforms, therefore the change is specific to that OS only (Solaris carries a similar approach already).
>>>
>>> Shall the description string of StackRedPage, StackYellowPages and StackShadow pages be modified to reflect the values could be scaled down? If so the comment needs to indicate the change affects Linux and Solaris only. Any comments welcome here.
>>>
>>> Thanks,
>>> Vlad
>

From vladimir.danushevsky at oracle.com  Mon Apr 29 10:27:14 2013
From: vladimir.danushevsky at oracle.com (Vladimir Danushevsky)
Date: Mon, 29 Apr 2013 13:27:14 -0400
Subject: RFR: 8013398: Adjust number of stack guard pages on systems with
	large memory page size
In-Reply-To: 
References: 
	
	<8A85EDB0-C7C1-4695-8EA0-71AD6D9EA4E0@oracle.com>
	
Message-ID: <6F81D78A-6562-4C43-8D10-E8A73B092503@oracle.com>

Hi Volker,

On Apr 29, 2013, at 12:55 PM, Volker Simonis wrote:

> On Mon, Apr 29, 2013 at 5:38 PM, Vladimir Danushevsky
>  wrote:
>> Hi Volker,
>> 
>> Thanks for the suggestion.
>> 
>> If I understand your approach correctly you suggest providing a dual way to specify guard area sizes (ether through number of pages or through an absolute size in KB) and have the VM to correlate between the two: Size value will dominate unless explicitly overwritten by the Page value.
>> Is that correct?
>> 
> 
> Yes, that's correct. The *Page values should become obsolete although
> I think there's currently no mechanism for that in OpenJDK.
> 
> Internally, i.e. in globals_.hpp, we could define the values
> independently of the actual system page size with the *Size flags.
> 
>> Will your approach eventually get same amount of allocated guard area as the patch suggested earlier would?
> 
> I think more or less yes:) It would depend on the settings of the
> *Size flags of course.

I suppose default value of the *Size needs to be set as small as possible on a given architecture (e.g. 4KB on PPC). Ideally the user shall not need to change that in runtime (same applies to other stack topology settings) based on a system OS configuration. 

> 
> E.g. currently on AMD64 we have:
> 
> define_pd_global(intx, StackYellowPages, 2);
> define_pd_global(intx, StackRedPages, 1);
> define_pd_global(intx, StackShadowPages, NOT_WIN64(20) WIN64_ONLY(6)
> DEBUG_ONLY(+2));
> 
> With your fix and a page size of 64K we would get:
> 
> StackYellowPages = 1;
> StackRedPages = 1;
> StackShadowPages = round_to((StackShadowPages * 8K), 64K) / 64K =
> round_to(20 * 8K, 64K) / 64K = 3

StackShadow should be 1 on product systems with 64KB:
round_to((StackShadowPages * 8K), 64K)  ==>round_to(24K,64K) ==> 64K i.e. 1 page

> 
> and:
> 
> min_staqck =
> (StackYellowPages+StackRedPages+StackShadowPages) * Linux::page_size() +
> (2*BytesPerWord COMPILER2_PRESENT(+1)) * Linux::vm_default_page_size()
> =
> (1 + 1 + 3) * 64K +
> (16 + 1) * 8K
> =
> 5 * 64K + 17 * 8K
> =
> 456K
> 
> With our proposed fix we would get:
> 
> define_pd_global(intx, StackYellowSize, 8K);
> define_pd_global(intx, StackRedSize, 4K);
> define_pd_global(intx, StackShadowSize, NOT_WIN64(80K) WIN64_ONLY(24K)
> DEBUG_ONLY(+8K));
> 
> this would result in:
> 
> StackYellowPages = 1;
> StackRedPages = 1;
> StackShadowPages = 2
> 
> and:
> 
> min_staqck =
> (StackYellowPages+StackRedPages+StackShadowPages) * Linux::page_size() +
> (2*BytesPerWord COMPILER2_PRESENT(+1)) * Linux::vm_default_page_size()
> =
> (1 + 1 + 2) * 64K +
> (16 + 1) * 8K
> =
> 4 * 64K + 17 * 8K
> =
> 392
> 

OK. The overall sizes are very close between the approaches.

>> If an intent is to make the adjustments global (i.e. independent of the OS) should we copy those to the arguments.cpp instead of os_.cpp?However  I'm not positive whether Windows, as an example, does need a guard area adjustment (but I might be wrong here).
>> 
> 
> I think the adjustment should stay in the platform dependent code.

I completely agree with you here. This is why my initial suggestion was to stay on os_.cpp side.


> 
>> Please post the webrev with the approach you suggested. It should be viewed as an alternative.
> 
> I'll prepare it.
> 
> Just one question - why did you choose:
> 
> _vm_default_page_size = 8K
> 
> Shouldn't this really be 4K?

Since the change is cross-architecture (same OS but different HW) perhaps it's better to stay conservative and apply the change only in cases where it really causes a problem. 8KB page is not that uncommon and we likely don't want to change behavior on those systems (benefit of 4KB vs 8KB is very small considering this is only the virtual memory allocation we're talking about).

Thanks,
Vlad

> 
>> 
>> Thanks,
>> Vlad
>> 
>> 
>> On Apr 29, 2013, at 11:03 AM, Volker Simonis wrote:
>> 
>>> Hi Vlad,
>>> 
>>> thanks for addressing this issue. We have this problem as well since
>>> long time and we would like to propose a more general solution:
>>> 
>>> Introduce three new platform dependant product flags:
>>> 
>>> StackYellowSize
>>> StackRedSize
>>> StackShadowSize
>>> 
>>> which are to be used to specify the concrete size of the corresponding
>>> stack regions. These sizes would be rounded up to the next multiple of
>>> the current OS page size (or more precisely the next multiple of the
>>> current OS stack page size, because there are systems which have
>>> different page sizes for stacks than for heap).
>>> 
>>> This would allow us to make simple, (i.e. not platform dependent)
>>> product flags out of:
>>> 
>>> StackYellowPages
>>> StackRedPages
>>> StackShadowPages
>>> 
>>> and set their default value to -1.
>>> 
>>> At VM start-up, before argument parsing, we will compute the values
>>> for StackYellowPages, StackRedPages, StackShadowPages from
>>> StackYellowSize, StackRedSize, StackShadowSize and the actual OS page
>>> size. Later on, during argument parsing, if one of these flags is
>>> given on the command line, either part of these value pairs may be
>>> adjusted in order to be consistent with its counterpart.
>>> 
>>> The drawback of this approach is that you get three more options but
>>> from our point of view this is outweighed by the fact that with this
>>> approach you 'fix' all the places where you currently waste a lot of
>>> memory if the VM is running on a system with a default page size
>>> bigger than 4K.
>>> 
>>> Notice that we use this approach since years in our commercial VM and
>>> only haven't integrated it into our OpenJDK PowerPC/AIX Port because
>>> we wanted to minimize the amount of shared code changes. We would be
>>> happy however to contribute it now that the discussion on this problem
>>> has popped up publicly on the mailing list. So if you agree, I could
>>> post a webrev with the proposed changes.
>>> 
>>> Regards,
>>> Volker
>>> 
>>> On Sat, Apr 27, 2013 at 2:34 AM, Vladimir Danushevsky
>>>  wrote:
>>>> Please review the following change:
>>>> 
>>>> http://cr.openjdk.java.net/~vladidan/8013398/webrev.00/
>>>> 
>>>> for
>>>> https://jbs.oracle.com/bugs/browse/JDK-8013398
>>>> 
>>>> On a non-typical Linux system configuration with large page size (e.g. 64KB) significant amount of virtual memory is wasted to multiple guard pages when in fact that can be reduced to a single page per Red/Yellow/Shadow categories.
>>>> In some edge cases a minimal stack requirement is calculated higher than actual stack size specified by ThreadStackSize parameter causing VM to abort unless stack size is overwritten via -Xss option.
>>>> 
>>>> A patch currently being suggested adjusts amount of guard pages to a single memory page each along with minimal stack size when memory page size exceed 8KB unless explicitly overwritten in command line.
>>>> 
>>>> Currently we are aware of the problem on some Linux platforms, therefore the change is specific to that OS only (Solaris carries a similar approach already).
>>>> 
>>>> Shall the description string of StackRedPage, StackYellowPages and StackShadow pages be modified to reflect the values could be scaled down? If so the comment needs to indicate the change affects Linux and Solaris only. Any comments welcome here.
>>>> 
>>>> Thanks,
>>>> Vlad
>> 


From coleen.phillimore at oracle.com  Mon Apr 29 10:36:01 2013
From: coleen.phillimore at oracle.com (Coleen Phillimore)
Date: Mon, 29 Apr 2013 13:36:01 -0400
Subject: RFR: 8013398: Adjust number of stack guard pages on systems with
	large memory page size
In-Reply-To: 
References: 
	
	<8A85EDB0-C7C1-4695-8EA0-71AD6D9EA4E0@oracle.com>
	
Message-ID: <517EAF81.4030309@oracle.com>


Hi Volker,

When looking at Vlad's change, I was thinking along these lines. 
StackYellowPages, RedPages and ShadowPages would be better specified as 
a size in bytes rather than page size to account for the differences in 
page sizes on different platforms.

The stack banging code is done in increments of "page_size" though, and 
the protection code has to be done on page size boundaries.   So there 
has to be some platform specific rounding to get the number of pages.   
I think the code change that Vlad sent is the minimally disruptive way 
to do this.   Adding new options for StackShadowSize and all that will 
just confuse people, I think.   We tell people to use different 
StackShadowPages all the time and it's even in our documentation.

I guess we'll have to see your patch and it would be good to have your 
code to be in open.

Thanks,
Coleen

On 04/29/2013 12:55 PM, Volker Simonis wrote:
> On Mon, Apr 29, 2013 at 5:38 PM, Vladimir Danushevsky
>  wrote:
>> Hi Volker,
>>
>> Thanks for the suggestion.
>>
>> If I understand your approach correctly you suggest providing a dual way to specify guard area sizes (ether through number of pages or through an absolute size in KB) and have the VM to correlate between the two: Size value will dominate unless explicitly overwritten by the Page value.
>> Is that correct?
>>
> Yes, that's correct. The *Page values should become obsolete although
> I think there's currently no mechanism for that in OpenJDK.
>
> Internally, i.e. in globals_.hpp, we could define the values
> independently of the actual system page size with the *Size flags.
>
>> Will your approach eventually get same amount of allocated guard area as the patch suggested earlier would?
> I think more or less yes:) It would depend on the settings of the
> *Size flags of course.
>
> E.g. currently on AMD64 we have:
>
> define_pd_global(intx, StackYellowPages, 2);
> define_pd_global(intx, StackRedPages, 1);
> define_pd_global(intx, StackShadowPages, NOT_WIN64(20) WIN64_ONLY(6)
> DEBUG_ONLY(+2));
>
> With your fix and a page size of 64K we would get:
>
> StackYellowPages = 1;
> StackRedPages = 1;
> StackShadowPages = round_to((StackShadowPages * 8K), 64K) / 64K =
> round_to(20 * 8K, 64K) / 64K = 3
>
> and:
>
> min_staqck =
> (StackYellowPages+StackRedPages+StackShadowPages) * Linux::page_size() +
> (2*BytesPerWord COMPILER2_PRESENT(+1)) * Linux::vm_default_page_size()
> =
> (1 + 1 + 3) * 64K +
> (16 + 1) * 8K
> =
> 5 * 64K + 17 * 8K
> =
> 456K
>
> With our proposed fix we would get:
>
> define_pd_global(intx, StackYellowSize, 8K);
> define_pd_global(intx, StackRedSize, 4K);
> define_pd_global(intx, StackShadowSize, NOT_WIN64(80K) WIN64_ONLY(24K)
> DEBUG_ONLY(+8K));
>
> this would result in:
>
> StackYellowPages = 1;
> StackRedPages = 1;
> StackShadowPages = 2
>
> and:
>
> min_staqck =
> (StackYellowPages+StackRedPages+StackShadowPages) * Linux::page_size() +
> (2*BytesPerWord COMPILER2_PRESENT(+1)) * Linux::vm_default_page_size()
> =
> (1 + 1 + 2) * 64K +
> (16 + 1) * 8K
> =
> 4 * 64K + 17 * 8K
> =
> 392
>
>> If an intent is to make the adjustments global (i.e. independent of the OS) should we copy those to the arguments.cpp instead of os_.cpp?However  I'm not positive whether Windows, as an example, does need a guard area adjustment (but I might be wrong here).
>>
> I think the adjustment should stay in the platform dependent code.
>
>> Please post the webrev with the approach you suggested. It should be viewed as an alternative.
> I'll prepare it.
>
> Just one question - why did you choose:
>
> _vm_default_page_size = 8K
>
> Shouldn't this really be 4K?
>
>> Thanks,
>> Vlad
>>
>>
>> On Apr 29, 2013, at 11:03 AM, Volker Simonis wrote:
>>
>>> Hi Vlad,
>>>
>>> thanks for addressing this issue. We have this problem as well since
>>> long time and we would like to propose a more general solution:
>>>
>>> Introduce three new platform dependant product flags:
>>>
>>> StackYellowSize
>>> StackRedSize
>>> StackShadowSize
>>>
>>> which are to be used to specify the concrete size of the corresponding
>>> stack regions. These sizes would be rounded up to the next multiple of
>>> the current OS page size (or more precisely the next multiple of the
>>> current OS stack page size, because there are systems which have
>>> different page sizes for stacks than for heap).
>>>
>>> This would allow us to make simple, (i.e. not platform dependent)
>>> product flags out of:
>>>
>>> StackYellowPages
>>> StackRedPages
>>> StackShadowPages
>>>
>>> and set their default value to -1.
>>>
>>> At VM start-up, before argument parsing, we will compute the values
>>> for StackYellowPages, StackRedPages, StackShadowPages from
>>> StackYellowSize, StackRedSize, StackShadowSize and the actual OS page
>>> size. Later on, during argument parsing, if one of these flags is
>>> given on the command line, either part of these value pairs may be
>>> adjusted in order to be consistent with its counterpart.
>>>
>>> The drawback of this approach is that you get three more options but
>>> from our point of view this is outweighed by the fact that with this
>>> approach you 'fix' all the places where you currently waste a lot of
>>> memory if the VM is running on a system with a default page size
>>> bigger than 4K.
>>>
>>> Notice that we use this approach since years in our commercial VM and
>>> only haven't integrated it into our OpenJDK PowerPC/AIX Port because
>>> we wanted to minimize the amount of shared code changes. We would be
>>> happy however to contribute it now that the discussion on this problem
>>> has popped up publicly on the mailing list. So if you agree, I could
>>> post a webrev with the proposed changes.
>>>
>>> Regards,
>>> Volker
>>>
>>> On Sat, Apr 27, 2013 at 2:34 AM, Vladimir Danushevsky
>>>  wrote:
>>>> Please review the following change:
>>>>
>>>> http://cr.openjdk.java.net/~vladidan/8013398/webrev.00/
>>>>
>>>> for
>>>> https://jbs.oracle.com/bugs/browse/JDK-8013398
>>>>
>>>> On a non-typical Linux system configuration with large page size (e.g. 64KB) significant amount of virtual memory is wasted to multiple guard pages when in fact that can be reduced to a single page per Red/Yellow/Shadow categories.
>>>> In some edge cases a minimal stack requirement is calculated higher than actual stack size specified by ThreadStackSize parameter causing VM to abort unless stack size is overwritten via -Xss option.
>>>>
>>>> A patch currently being suggested adjusts amount of guard pages to a single memory page each along with minimal stack size when memory page size exceed 8KB unless explicitly overwritten in command line.
>>>>
>>>> Currently we are aware of the problem on some Linux platforms, therefore the change is specific to that OS only (Solaris carries a similar approach already).
>>>>
>>>> Shall the description string of StackRedPage, StackYellowPages and StackShadow pages be modified to reflect the values could be scaled down? If so the comment needs to indicate the change affects Linux and Solaris only. Any comments welcome here.
>>>>
>>>> Thanks,
>>>> Vlad


From christian.thalinger at oracle.com  Mon Apr 29 12:38:56 2013
From: christian.thalinger at oracle.com (christian.thalinger at oracle.com)
Date: Mon, 29 Apr 2013 19:38:56 +0000
Subject: hg: hsx/hsx24/hotspot: 2 new changesets
Message-ID: <20130429193900.CED2E486A6@hg.openjdk.java.net>

Changeset: 18687839e9e8
Author:    drchase
Date:      2013-04-26 12:00 -0700
URL:       http://hg.openjdk.java.net/hsx/hsx24/hotspot/rev/18687839e9e8

8010770: Zero: back port of 8000780 to HS24 broke JSR 292
Reviewed-by: kvn, twisti

! src/share/vm/interpreter/bytecodeInterpreter.cpp

Changeset: 2a0c45364baa
Author:    twisti
Date:      2013-04-26 17:13 -0700
URL:       http://hg.openjdk.java.net/hsx/hsx24/hotspot/rev/2a0c45364baa

Merge



From calvin.cheung at oracle.com  Mon Apr 29 18:37:49 2013
From: calvin.cheung at oracle.com (Calvin Cheung)
Date: Mon, 29 Apr 2013 18:37:49 -0700
Subject: RFR: 8011661: Insufficient memory message says "malloc" when
	sometimes it should say "mmap"
In-Reply-To: 
References: <517B008B.1020201@oracle.com>
	
Message-ID: <517F206D.7080203@oracle.com>

Zhengyu,

Thanks for your review.
Since the fix for 8011773 (Some tests on Interned String crashed JVM 
with OOM) has been pushed today, I needed to update the fix to include 
the change in oop.cpp. Webrev is at the same location: 
http://cr.openjdk.java.net/~ccheung/8011661/webrev/

Also, I need one more reviewer so that this fix can be pushed.

I ran the vm.quick.testlist on linux_x64, there's no new failures 
compared with the promoted build.

thanks,
Calvin

On 4/29/2013 7:01 AM, Zhengyu Gu wrote:
> Good to me.
>
> Thanks,
>
> -Zhengyu
>
> On Apr 26, 2013, at 6:32 PM, Calvin Cheung wrote:
>
>> Problem: needs a way to differentiate the 2 OOM error cases - malloc or mmap
>>
>> Fix:
>> Adding an enum parameter to the vm_exit_out_of_memory macro and the report_vm_out_of_memory
>> function so that the caller can indicate whether it's a malloc or mmap error.
>> Main changes are in debug.[cpp | hpp] and vmError.[cpp | hpp].
>> Other changes are mainly for passing in the additional enum when calling vm_exit_out_of_memory.
>>
>> Test coverage:
>>     jprt
>>
>> webrev: http://cr.openjdk.java.net/~ccheung/8011661/webrev/
>> jbs: https://jbs.oracle.com/bugs/browse/JDK-8011661
>> bugs.sun.com: http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=8011661
>>
>> thanks,
>> Calvin


From david.holmes at oracle.com  Mon Apr 29 23:36:20 2013
From: david.holmes at oracle.com (David Holmes)
Date: Tue, 30 Apr 2013 16:36:20 +1000
Subject: RFR: 8011661: Insufficient memory message says "malloc" when
	sometimes it should say "mmap"
In-Reply-To: <517F206D.7080203@oracle.com>
References: <517B008B.1020201@oracle.com>
	
	<517F206D.7080203@oracle.com>
Message-ID: <517F6664.5040908@oracle.com>

Hi Calvin,

This would be far less disruptive if you used a default parameter so 
that the majority of the call sites did not need to be changed. Also the 
use of an enum seems excessive unless you think we will discover other 
OOM reasons ?

David

On 30/04/2013 11:37 AM, Calvin Cheung wrote:
> Zhengyu,
>
> Thanks for your review.
> Since the fix for 8011773 (Some tests on Interned String crashed JVM
> with OOM) has been pushed today, I needed to update the fix to include
> the change in oop.cpp. Webrev is at the same location:
> http://cr.openjdk.java.net/~ccheung/8011661/webrev/
>
> Also, I need one more reviewer so that this fix can be pushed.
>
> I ran the vm.quick.testlist on linux_x64, there's no new failures
> compared with the promoted build.
>
> thanks,
> Calvin
>
> On 4/29/2013 7:01 AM, Zhengyu Gu wrote:
>> Good to me.
>>
>> Thanks,
>>
>> -Zhengyu
>>
>> On Apr 26, 2013, at 6:32 PM, Calvin Cheung wrote:
>>
>>> Problem: needs a way to differentiate the 2 OOM error cases - malloc
>>> or mmap
>>>
>>> Fix:
>>> Adding an enum parameter to the vm_exit_out_of_memory macro and the
>>> report_vm_out_of_memory
>>> function so that the caller can indicate whether it's a malloc or
>>> mmap error.
>>> Main changes are in debug.[cpp | hpp] and vmError.[cpp | hpp].
>>> Other changes are mainly for passing in the additional enum when
>>> calling vm_exit_out_of_memory.
>>>
>>> Test coverage:
>>>     jprt
>>>
>>> webrev: http://cr.openjdk.java.net/~ccheung/8011661/webrev/
>>> jbs: https://jbs.oracle.com/bugs/browse/JDK-8011661
>>> bugs.sun.com: http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=8011661
>>>
>>> thanks,
>>> Calvin
>

From rickard.backman at oracle.com  Tue Apr 30 01:55:25 2013
From: rickard.backman at oracle.com (rickard.backman at oracle.com)
Date: Tue, 30 Apr 2013 08:55:25 +0000
Subject: hg: hsx/hsx24/hotspot: 8013117: Thread-local trace_buffer has wrong
	type and name
Message-ID: <20130430085528.C5303486D6@hg.openjdk.java.net>

Changeset: 12494ffb721b
Author:    rbackman
Date:      2013-04-17 11:29 +0200
URL:       http://hg.openjdk.java.net/hsx/hsx24/hotspot/rev/12494ffb721b

8013117: Thread-local trace_buffer has wrong type and name
Reviewed-by: dholmes, sla

! src/share/vm/runtime/thread.cpp
! src/share/vm/runtime/thread.hpp
! src/share/vm/trace/noTraceBackend.hpp
! src/share/vm/trace/traceBackend.hpp
! src/share/vm/trace/traceMacros.hpp


From coleen.phillimore at oracle.com  Tue Apr 30 07:17:59 2013
From: coleen.phillimore at oracle.com (Coleen Phillimore)
Date: Tue, 30 Apr 2013 10:17:59 -0400
Subject: RFR: 8011661: Insufficient memory message says "malloc" when
	sometimes it should say "mmap"
In-Reply-To: <517F6664.5040908@oracle.com>
References: <517B008B.1020201@oracle.com>
	
	<517F206D.7080203@oracle.com> <517F6664.5040908@oracle.com>
Message-ID: <517FD297.8090203@oracle.com>


This code looks good to me.  I thought the same thing as David but the 
distribution wasn't all malloc and a few mmaps, or the other way 
around.   The change is disruptive, but I think it's helpful.   Our long 
term goal is to reduce the number of these calls in favor of something 
recoverable.

Coleen

On 04/30/2013 02:36 AM, David Holmes wrote:
> Hi Calvin,
>
> This would be far less disruptive if you used a default parameter so 
> that the majority of the call sites did not need to be changed. Also 
> the use of an enum seems excessive unless you think we will discover 
> other OOM reasons ?
>
> David
>
> On 30/04/2013 11:37 AM, Calvin Cheung wrote:
>> Zhengyu,
>>
>> Thanks for your review.
>> Since the fix for 8011773 (Some tests on Interned String crashed JVM
>> with OOM) has been pushed today, I needed to update the fix to include
>> the change in oop.cpp. Webrev is at the same location:
>> http://cr.openjdk.java.net/~ccheung/8011661/webrev/
>>
>> Also, I need one more reviewer so that this fix can be pushed.
>>
>> I ran the vm.quick.testlist on linux_x64, there's no new failures
>> compared with the promoted build.
>>
>> thanks,
>> Calvin
>>
>> On 4/29/2013 7:01 AM, Zhengyu Gu wrote:
>>> Good to me.
>>>
>>> Thanks,
>>>
>>> -Zhengyu
>>>
>>> On Apr 26, 2013, at 6:32 PM, Calvin Cheung wrote:
>>>
>>>> Problem: needs a way to differentiate the 2 OOM error cases - malloc
>>>> or mmap
>>>>
>>>> Fix:
>>>> Adding an enum parameter to the vm_exit_out_of_memory macro and the
>>>> report_vm_out_of_memory
>>>> function so that the caller can indicate whether it's a malloc or
>>>> mmap error.
>>>> Main changes are in debug.[cpp | hpp] and vmError.[cpp | hpp].
>>>> Other changes are mainly for passing in the additional enum when
>>>> calling vm_exit_out_of_memory.
>>>>
>>>> Test coverage:
>>>>     jprt
>>>>
>>>> webrev: http://cr.openjdk.java.net/~ccheung/8011661/webrev/
>>>> jbs: https://jbs.oracle.com/bugs/browse/JDK-8011661
>>>> bugs.sun.com: 
>>>> http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=8011661
>>>>
>>>> thanks,
>>>> Calvin
>>


From vladimir.danushevsky at oracle.com  Tue Apr 30 08:56:32 2013
From: vladimir.danushevsky at oracle.com (Vladimir Danushevsky)
Date: Tue, 30 Apr 2013 11:56:32 -0400
Subject: RFR: 8013398: Adjust number of stack guard pages on systems with
	large memory page size
In-Reply-To: <517EAF81.4030309@oracle.com>
References: 
	
	<8A85EDB0-C7C1-4695-8EA0-71AD6D9EA4E0@oracle.com>
	
	<517EAF81.4030309@oracle.com>
Message-ID: <6AEED370-77C5-477C-922F-03F962941DBF@oracle.com>

Thanks Coleen.
Unless there is any objection should we deliver currently proposed change (as it is required to meet certain release criteria) and consider Volker's change as a potential feature extension?

Thanks,
Vlad

On Apr 29, 2013, at 1:36 PM, Coleen Phillimore wrote:

> 
> Hi Volker,
> 
> When looking at Vlad's change, I was thinking along these lines. StackYellowPages, RedPages and ShadowPages would be better specified as a size in bytes rather than page size to account for the differences in page sizes on different platforms.
> 
> The stack banging code is done in increments of "page_size" though, and the protection code has to be done on page size boundaries.   So there has to be some platform specific rounding to get the number of pages.   I think the code change that Vlad sent is the minimally disruptive way to do this.   Adding new options for StackShadowSize and all that will just confuse people, I think.   We tell people to use different StackShadowPages all the time and it's even in our documentation.
> 
> I guess we'll have to see your patch and it would be good to have your code to be in open.
> 
> Thanks,
> Coleen
> 
> On 04/29/2013 12:55 PM, Volker Simonis wrote:
>> On Mon, Apr 29, 2013 at 5:38 PM, Vladimir Danushevsky
>>  wrote:
>>> Hi Volker,
>>> 
>>> Thanks for the suggestion.
>>> 
>>> If I understand your approach correctly you suggest providing a dual way to specify guard area sizes (ether through number of pages or through an absolute size in KB) and have the VM to correlate between the two: Size value will dominate unless explicitly overwritten by the Page value.
>>> Is that correct?
>>> 
>> Yes, that's correct. The *Page values should become obsolete although
>> I think there's currently no mechanism for that in OpenJDK.
>> 
>> Internally, i.e. in globals_.hpp, we could define the values
>> independently of the actual system page size with the *Size flags.
>> 
>>> Will your approach eventually get same amount of allocated guard area as the patch suggested earlier would?
>> I think more or less yes:) It would depend on the settings of the
>> *Size flags of course.
>> 
>> E.g. currently on AMD64 we have:
>> 
>> define_pd_global(intx, StackYellowPages, 2);
>> define_pd_global(intx, StackRedPages, 1);
>> define_pd_global(intx, StackShadowPages, NOT_WIN64(20) WIN64_ONLY(6)
>> DEBUG_ONLY(+2));
>> 
>> With your fix and a page size of 64K we would get:
>> 
>> StackYellowPages = 1;
>> StackRedPages = 1;
>> StackShadowPages = round_to((StackShadowPages * 8K), 64K) / 64K =
>> round_to(20 * 8K, 64K) / 64K = 3
>> 
>> and:
>> 
>> min_staqck =
>> (StackYellowPages+StackRedPages+StackShadowPages) * Linux::page_size() +
>> (2*BytesPerWord COMPILER2_PRESENT(+1)) * Linux::vm_default_page_size()
>> =
>> (1 + 1 + 3) * 64K +
>> (16 + 1) * 8K
>> =
>> 5 * 64K + 17 * 8K
>> =
>> 456K
>> 
>> With our proposed fix we would get:
>> 
>> define_pd_global(intx, StackYellowSize, 8K);
>> define_pd_global(intx, StackRedSize, 4K);
>> define_pd_global(intx, StackShadowSize, NOT_WIN64(80K) WIN64_ONLY(24K)
>> DEBUG_ONLY(+8K));
>> 
>> this would result in:
>> 
>> StackYellowPages = 1;
>> StackRedPages = 1;
>> StackShadowPages = 2
>> 
>> and:
>> 
>> min_staqck =
>> (StackYellowPages+StackRedPages+StackShadowPages) * Linux::page_size() +
>> (2*BytesPerWord COMPILER2_PRESENT(+1)) * Linux::vm_default_page_size()
>> =
>> (1 + 1 + 2) * 64K +
>> (16 + 1) * 8K
>> =
>> 4 * 64K + 17 * 8K
>> =
>> 392
>> 
>>> If an intent is to make the adjustments global (i.e. independent of the OS) should we copy those to the arguments.cpp instead of os_.cpp?However  I'm not positive whether Windows, as an example, does need a guard area adjustment (but I might be wrong here).
>>> 
>> I think the adjustment should stay in the platform dependent code.
>> 
>>> Please post the webrev with the approach you suggested. It should be viewed as an alternative.
>> I'll prepare it.
>> 
>> Just one question - why did you choose:
>> 
>> _vm_default_page_size = 8K
>> 
>> Shouldn't this really be 4K?
>> 
>>> Thanks,
>>> Vlad
>>> 
>>> 
>>> On Apr 29, 2013, at 11:03 AM, Volker Simonis wrote:
>>> 
>>>> Hi Vlad,
>>>> 
>>>> thanks for addressing this issue. We have this problem as well since
>>>> long time and we would like to propose a more general solution:
>>>> 
>>>> Introduce three new platform dependant product flags:
>>>> 
>>>> StackYellowSize
>>>> StackRedSize
>>>> StackShadowSize
>>>> 
>>>> which are to be used to specify the concrete size of the corresponding
>>>> stack regions. These sizes would be rounded up to the next multiple of
>>>> the current OS page size (or more precisely the next multiple of the
>>>> current OS stack page size, because there are systems which have
>>>> different page sizes for stacks than for heap).
>>>> 
>>>> This would allow us to make simple, (i.e. not platform dependent)
>>>> product flags out of:
>>>> 
>>>> StackYellowPages
>>>> StackRedPages
>>>> StackShadowPages
>>>> 
>>>> and set their default value to -1.
>>>> 
>>>> At VM start-up, before argument parsing, we will compute the values
>>>> for StackYellowPages, StackRedPages, StackShadowPages from
>>>> StackYellowSize, StackRedSize, StackShadowSize and the actual OS page
>>>> size. Later on, during argument parsing, if one of these flags is
>>>> given on the command line, either part of these value pairs may be
>>>> adjusted in order to be consistent with its counterpart.
>>>> 
>>>> The drawback of this approach is that you get three more options but
>>>> from our point of view this is outweighed by the fact that with this
>>>> approach you 'fix' all the places where you currently waste a lot of
>>>> memory if the VM is running on a system with a default page size
>>>> bigger than 4K.
>>>> 
>>>> Notice that we use this approach since years in our commercial VM and
>>>> only haven't integrated it into our OpenJDK PowerPC/AIX Port because
>>>> we wanted to minimize the amount of shared code changes. We would be
>>>> happy however to contribute it now that the discussion on this problem
>>>> has popped up publicly on the mailing list. So if you agree, I could
>>>> post a webrev with the proposed changes.
>>>> 
>>>> Regards,
>>>> Volker
>>>> 
>>>> On Sat, Apr 27, 2013 at 2:34 AM, Vladimir Danushevsky
>>>>  wrote:
>>>>> Please review the following change:
>>>>> 
>>>>> http://cr.openjdk.java.net/~vladidan/8013398/webrev.00/
>>>>> 
>>>>> for
>>>>> https://jbs.oracle.com/bugs/browse/JDK-8013398
>>>>> 
>>>>> On a non-typical Linux system configuration with large page size (e.g. 64KB) significant amount of virtual memory is wasted to multiple guard pages when in fact that can be reduced to a single page per Red/Yellow/Shadow categories.
>>>>> In some edge cases a minimal stack requirement is calculated higher than actual stack size specified by ThreadStackSize parameter causing VM to abort unless stack size is overwritten via -Xss option.
>>>>> 
>>>>> A patch currently being suggested adjusts amount of guard pages to a single memory page each along with minimal stack size when memory page size exceed 8KB unless explicitly overwritten in command line.
>>>>> 
>>>>> Currently we are aware of the problem on some Linux platforms, therefore the change is specific to that OS only (Solaris carries a similar approach already).
>>>>> 
>>>>> Shall the description string of StackRedPage, StackYellowPages and StackShadow pages be modified to reflect the values could be scaled down? If so the comment needs to indicate the change affects Linux and Solaris only. Any comments welcome here.
>>>>> 
>>>>> Thanks,
>>>>> Vlad
> 


From volker.simonis at gmail.com  Tue Apr 30 09:37:33 2013
From: volker.simonis at gmail.com (Volker Simonis)
Date: Tue, 30 Apr 2013 18:37:33 +0200
Subject: RFR: 8013398: Adjust number of stack guard pages on systems with
	large memory page size
In-Reply-To: <517EAF81.4030309@oracle.com>
References: 
	
	<8A85EDB0-C7C1-4695-8EA0-71AD6D9EA4E0@oracle.com>
	
	<517EAF81.4030309@oracle.com>
Message-ID: 

Hi Coleen, Vladimir,

here you can find a first version of what I was thinking about:

http://cr.openjdk.java.net/~simonis/webrevs/8013398.v1/

This may still need some polishing and I haven?t done extensive testing with it.
I just wanted to give you a quick idea of my proposal as I will be out
of office until Monday.

Thank you and best regards,
Volker



On Mon, Apr 29, 2013 at 7:36 PM, Coleen Phillimore
 wrote:
>
> Hi Volker,
>
> When looking at Vlad's change, I was thinking along these lines.
> StackYellowPages, RedPages and ShadowPages would be better specified as a
> size in bytes rather than page size to account for the differences in page
> sizes on different platforms.
>
> The stack banging code is done in increments of "page_size" though, and the
> protection code has to be done on page size boundaries.   So there has to be
> some platform specific rounding to get the number of pages.   I think the
> code change that Vlad sent is the minimally disruptive way to do this.
> Adding new options for StackShadowSize and all that will just confuse
> people, I think.   We tell people to use different StackShadowPages all the
> time and it's even in our documentation.
>
> I guess we'll have to see your patch and it would be good to have your code
> to be in open.
>
> Thanks,
> Coleen
>
>
> On 04/29/2013 12:55 PM, Volker Simonis wrote:
>>
>> On Mon, Apr 29, 2013 at 5:38 PM, Vladimir Danushevsky
>>  wrote:
>>>
>>> Hi Volker,
>>>
>>> Thanks for the suggestion.
>>>
>>> If I understand your approach correctly you suggest providing a dual way
>>> to specify guard area sizes (ether through number of pages or through an
>>> absolute size in KB) and have the VM to correlate between the two: Size
>>> value will dominate unless explicitly overwritten by the Page value.
>>> Is that correct?
>>>
>> Yes, that's correct. The *Page values should become obsolete although
>> I think there's currently no mechanism for that in OpenJDK.
>>
>> Internally, i.e. in globals_.hpp, we could define the values
>> independently of the actual system page size with the *Size flags.
>>
>>> Will your approach eventually get same amount of allocated guard area as
>>> the patch suggested earlier would?
>>
>> I think more or less yes:) It would depend on the settings of the
>> *Size flags of course.
>>
>> E.g. currently on AMD64 we have:
>>
>> define_pd_global(intx, StackYellowPages, 2);
>> define_pd_global(intx, StackRedPages, 1);
>> define_pd_global(intx, StackShadowPages, NOT_WIN64(20) WIN64_ONLY(6)
>> DEBUG_ONLY(+2));
>>
>> With your fix and a page size of 64K we would get:
>>
>> StackYellowPages = 1;
>> StackRedPages = 1;
>> StackShadowPages = round_to((StackShadowPages * 8K), 64K) / 64K =
>> round_to(20 * 8K, 64K) / 64K = 3
>>
>> and:
>>
>> min_staqck =
>> (StackYellowPages+StackRedPages+StackShadowPages) * Linux::page_size() +
>> (2*BytesPerWord COMPILER2_PRESENT(+1)) * Linux::vm_default_page_size()
>> =
>> (1 + 1 + 3) * 64K +
>> (16 + 1) * 8K
>> =
>> 5 * 64K + 17 * 8K
>> =
>> 456K
>>
>> With our proposed fix we would get:
>>
>> define_pd_global(intx, StackYellowSize, 8K);
>> define_pd_global(intx, StackRedSize, 4K);
>> define_pd_global(intx, StackShadowSize, NOT_WIN64(80K) WIN64_ONLY(24K)
>> DEBUG_ONLY(+8K));
>>
>> this would result in:
>>
>> StackYellowPages = 1;
>> StackRedPages = 1;
>> StackShadowPages = 2
>>
>> and:
>>
>> min_staqck =
>> (StackYellowPages+StackRedPages+StackShadowPages) * Linux::page_size() +
>> (2*BytesPerWord COMPILER2_PRESENT(+1)) * Linux::vm_default_page_size()
>> =
>> (1 + 1 + 2) * 64K +
>> (16 + 1) * 8K
>> =
>> 4 * 64K + 17 * 8K
>> =
>> 392
>>
>>> If an intent is to make the adjustments global (i.e. independent of the
>>> OS) should we copy those to the arguments.cpp instead of os_>> name>.cpp?However  I'm not positive whether Windows, as an example, does
>>> need a guard area adjustment (but I might be wrong here).
>>>
>> I think the adjustment should stay in the platform dependent code.
>>
>>> Please post the webrev with the approach you suggested. It should be
>>> viewed as an alternative.
>>
>> I'll prepare it.
>>
>> Just one question - why did you choose:
>>
>> _vm_default_page_size = 8K
>>
>> Shouldn't this really be 4K?
>>
>>> Thanks,
>>> Vlad
>>>
>>>
>>> On Apr 29, 2013, at 11:03 AM, Volker Simonis wrote:
>>>
>>>> Hi Vlad,
>>>>
>>>> thanks for addressing this issue. We have this problem as well since
>>>> long time and we would like to propose a more general solution:
>>>>
>>>> Introduce three new platform dependant product flags:
>>>>
>>>> StackYellowSize
>>>> StackRedSize
>>>> StackShadowSize
>>>>
>>>> which are to be used to specify the concrete size of the corresponding
>>>> stack regions. These sizes would be rounded up to the next multiple of
>>>> the current OS page size (or more precisely the next multiple of the
>>>> current OS stack page size, because there are systems which have
>>>> different page sizes for stacks than for heap).
>>>>
>>>> This would allow us to make simple, (i.e. not platform dependent)
>>>> product flags out of:
>>>>
>>>> StackYellowPages
>>>> StackRedPages
>>>> StackShadowPages
>>>>
>>>> and set their default value to -1.
>>>>
>>>> At VM start-up, before argument parsing, we will compute the values
>>>> for StackYellowPages, StackRedPages, StackShadowPages from
>>>> StackYellowSize, StackRedSize, StackShadowSize and the actual OS page
>>>> size. Later on, during argument parsing, if one of these flags is
>>>> given on the command line, either part of these value pairs may be
>>>> adjusted in order to be consistent with its counterpart.
>>>>
>>>> The drawback of this approach is that you get three more options but
>>>> from our point of view this is outweighed by the fact that with this
>>>> approach you 'fix' all the places where you currently waste a lot of
>>>> memory if the VM is running on a system with a default page size
>>>> bigger than 4K.
>>>>
>>>> Notice that we use this approach since years in our commercial VM and
>>>> only haven't integrated it into our OpenJDK PowerPC/AIX Port because
>>>> we wanted to minimize the amount of shared code changes. We would be
>>>> happy however to contribute it now that the discussion on this problem
>>>> has popped up publicly on the mailing list. So if you agree, I could
>>>> post a webrev with the proposed changes.
>>>>
>>>> Regards,
>>>> Volker
>>>>
>>>> On Sat, Apr 27, 2013 at 2:34 AM, Vladimir Danushevsky
>>>>  wrote:
>>>>>
>>>>> Please review the following change:
>>>>>
>>>>> http://cr.openjdk.java.net/~vladidan/8013398/webrev.00/
>>>>>
>>>>> for
>>>>> https://jbs.oracle.com/bugs/browse/JDK-8013398
>>>>>
>>>>> On a non-typical Linux system configuration with large page size (e.g.
>>>>> 64KB) significant amount of virtual memory is wasted to multiple guard pages
>>>>> when in fact that can be reduced to a single page per Red/Yellow/Shadow
>>>>> categories.
>>>>> In some edge cases a minimal stack requirement is calculated higher
>>>>> than actual stack size specified by ThreadStackSize parameter causing VM to
>>>>> abort unless stack size is overwritten via -Xss option.
>>>>>
>>>>> A patch currently being suggested adjusts amount of guard pages to a
>>>>> single memory page each along with minimal stack size when memory page size
>>>>> exceed 8KB unless explicitly overwritten in command line.
>>>>>
>>>>> Currently we are aware of the problem on some Linux platforms,
>>>>> therefore the change is specific to that OS only (Solaris carries a similar
>>>>> approach already).
>>>>>
>>>>> Shall the description string of StackRedPage, StackYellowPages and
>>>>> StackShadow pages be modified to reflect the values could be scaled down? If
>>>>> so the comment needs to indicate the change affects Linux and Solaris only.
>>>>> Any comments welcome here.
>>>>>
>>>>> Thanks,
>>>>> Vlad
>
>

From coleen.phillimore at oracle.com  Tue Apr 30 14:48:52 2013
From: coleen.phillimore at oracle.com (Coleen Phillimore)
Date: Tue, 30 Apr 2013 17:48:52 -0400
Subject: RFR: 8013398: Adjust number of stack guard pages on systems with
	large memory page size
In-Reply-To: 
References: 
	
	<8A85EDB0-C7C1-4695-8EA0-71AD6D9EA4E0@oracle.com>
	
	<517EAF81.4030309@oracle.com>
	
Message-ID: <51803C44.9080508@oracle.com>


Hi Volker,
Besides changing the parameters to be in terms of size rather than 
pages, the os_linux.cpp change is compatible with what Vlad has done.  
This part of the change fixes the problem with having too much reserved 
space on the stack.   Changing these parameter names is going to be 
problematic because we do have customers that we've given 
StackShadowPages as an option and they won't be happy if it goes away.

I think we should integrate Vlad's fix and think about your changes or 
how we can make these work compatibly.

Vlad - Should the default page size be changed to 4K though, as Volker 
suggested in his code review?

Thanks,
Coleen

On 04/30/2013 12:37 PM, Volker Simonis wrote:
> Hi Coleen, Vladimir,
>
> here you can find a first version of what I was thinking about:
>
> http://cr.openjdk.java.net/~simonis/webrevs/8013398.v1/
>
> This may still need some polishing and I haven?t done extensive testing with it.
> I just wanted to give you a quick idea of my proposal as I will be out
> of office until Monday.
>
> Thank you and best regards,
> Volker
>
>
>
> On Mon, Apr 29, 2013 at 7:36 PM, Coleen Phillimore
>  wrote:
>> Hi Volker,
>>
>> When looking at Vlad's change, I was thinking along these lines.
>> StackYellowPages, RedPages and ShadowPages would be better specified as a
>> size in bytes rather than page size to account for the differences in page
>> sizes on different platforms.
>>
>> The stack banging code is done in increments of "page_size" though, and the
>> protection code has to be done on page size boundaries.   So there has to be
>> some platform specific rounding to get the number of pages.   I think the
>> code change that Vlad sent is the minimally disruptive way to do this.
>> Adding new options for StackShadowSize and all that will just confuse
>> people, I think.   We tell people to use different StackShadowPages all the
>> time and it's even in our documentation.
>>
>> I guess we'll have to see your patch and it would be good to have your code
>> to be in open.
>>
>> Thanks,
>> Coleen
>>
>>
>> On 04/29/2013 12:55 PM, Volker Simonis wrote:
>>> On Mon, Apr 29, 2013 at 5:38 PM, Vladimir Danushevsky
>>>  wrote:
>>>> Hi Volker,
>>>>
>>>> Thanks for the suggestion.
>>>>
>>>> If I understand your approach correctly you suggest providing a dual way
>>>> to specify guard area sizes (ether through number of pages or through an
>>>> absolute size in KB) and have the VM to correlate between the two: Size
>>>> value will dominate unless explicitly overwritten by the Page value.
>>>> Is that correct?
>>>>
>>> Yes, that's correct. The *Page values should become obsolete although
>>> I think there's currently no mechanism for that in OpenJDK.
>>>
>>> Internally, i.e. in globals_.hpp, we could define the values
>>> independently of the actual system page size with the *Size flags.
>>>
>>>> Will your approach eventually get same amount of allocated guard area as
>>>> the patch suggested earlier would?
>>> I think more or less yes:) It would depend on the settings of the
>>> *Size flags of course.
>>>
>>> E.g. currently on AMD64 we have:
>>>
>>> define_pd_global(intx, StackYellowPages, 2);
>>> define_pd_global(intx, StackRedPages, 1);
>>> define_pd_global(intx, StackShadowPages, NOT_WIN64(20) WIN64_ONLY(6)
>>> DEBUG_ONLY(+2));
>>>
>>> With your fix and a page size of 64K we would get:
>>>
>>> StackYellowPages = 1;
>>> StackRedPages = 1;
>>> StackShadowPages = round_to((StackShadowPages * 8K), 64K) / 64K =
>>> round_to(20 * 8K, 64K) / 64K = 3
>>>
>>> and:
>>>
>>> min_staqck =
>>> (StackYellowPages+StackRedPages+StackShadowPages) * Linux::page_size() +
>>> (2*BytesPerWord COMPILER2_PRESENT(+1)) * Linux::vm_default_page_size()
>>> =
>>> (1 + 1 + 3) * 64K +
>>> (16 + 1) * 8K
>>> =
>>> 5 * 64K + 17 * 8K
>>> =
>>> 456K
>>>
>>> With our proposed fix we would get:
>>>
>>> define_pd_global(intx, StackYellowSize, 8K);
>>> define_pd_global(intx, StackRedSize, 4K);
>>> define_pd_global(intx, StackShadowSize, NOT_WIN64(80K) WIN64_ONLY(24K)
>>> DEBUG_ONLY(+8K));
>>>
>>> this would result in:
>>>
>>> StackYellowPages = 1;
>>> StackRedPages = 1;
>>> StackShadowPages = 2
>>>
>>> and:
>>>
>>> min_staqck =
>>> (StackYellowPages+StackRedPages+StackShadowPages) * Linux::page_size() +
>>> (2*BytesPerWord COMPILER2_PRESENT(+1)) * Linux::vm_default_page_size()
>>> =
>>> (1 + 1 + 2) * 64K +
>>> (16 + 1) * 8K
>>> =
>>> 4 * 64K + 17 * 8K
>>> =
>>> 392
>>>
>>>> If an intent is to make the adjustments global (i.e. independent of the
>>>> OS) should we copy those to the arguments.cpp instead of os_>>> name>.cpp?However  I'm not positive whether Windows, as an example, does
>>>> need a guard area adjustment (but I might be wrong here).
>>>>
>>> I think the adjustment should stay in the platform dependent code.
>>>
>>>> Please post the webrev with the approach you suggested. It should be
>>>> viewed as an alternative.
>>> I'll prepare it.
>>>
>>> Just one question - why did you choose:
>>>
>>> _vm_default_page_size = 8K
>>>
>>> Shouldn't this really be 4K?
>>>
>>>> Thanks,
>>>> Vlad
>>>>
>>>>
>>>> On Apr 29, 2013, at 11:03 AM, Volker Simonis wrote:
>>>>
>>>>> Hi Vlad,
>>>>>
>>>>> thanks for addressing this issue. We have this problem as well since
>>>>> long time and we would like to propose a more general solution:
>>>>>
>>>>> Introduce three new platform dependant product flags:
>>>>>
>>>>> StackYellowSize
>>>>> StackRedSize
>>>>> StackShadowSize
>>>>>
>>>>> which are to be used to specify the concrete size of the corresponding
>>>>> stack regions. These sizes would be rounded up to the next multiple of
>>>>> the current OS page size (or more precisely the next multiple of the
>>>>> current OS stack page size, because there are systems which have
>>>>> different page sizes for stacks than for heap).
>>>>>
>>>>> This would allow us to make simple, (i.e. not platform dependent)
>>>>> product flags out of:
>>>>>
>>>>> StackYellowPages
>>>>> StackRedPages
>>>>> StackShadowPages
>>>>>
>>>>> and set their default value to -1.
>>>>>
>>>>> At VM start-up, before argument parsing, we will compute the values
>>>>> for StackYellowPages, StackRedPages, StackShadowPages from
>>>>> StackYellowSize, StackRedSize, StackShadowSize and the actual OS page
>>>>> size. Later on, during argument parsing, if one of these flags is
>>>>> given on the command line, either part of these value pairs may be
>>>>> adjusted in order to be consistent with its counterpart.
>>>>>
>>>>> The drawback of this approach is that you get three more options but
>>>>> from our point of view this is outweighed by the fact that with this
>>>>> approach you 'fix' all the places where you currently waste a lot of
>>>>> memory if the VM is running on a system with a default page size
>>>>> bigger than 4K.
>>>>>
>>>>> Notice that we use this approach since years in our commercial VM and
>>>>> only haven't integrated it into our OpenJDK PowerPC/AIX Port because
>>>>> we wanted to minimize the amount of shared code changes. We would be
>>>>> happy however to contribute it now that the discussion on this problem
>>>>> has popped up publicly on the mailing list. So if you agree, I could
>>>>> post a webrev with the proposed changes.
>>>>>
>>>>> Regards,
>>>>> Volker
>>>>>
>>>>> On Sat, Apr 27, 2013 at 2:34 AM, Vladimir Danushevsky
>>>>>  wrote:
>>>>>> Please review the following change:
>>>>>>
>>>>>> http://cr.openjdk.java.net/~vladidan/8013398/webrev.00/
>>>>>>
>>>>>> for
>>>>>> https://jbs.oracle.com/bugs/browse/JDK-8013398
>>>>>>
>>>>>> On a non-typical Linux system configuration with large page size (e.g.
>>>>>> 64KB) significant amount of virtual memory is wasted to multiple guard pages
>>>>>> when in fact that can be reduced to a single page per Red/Yellow/Shadow
>>>>>> categories.
>>>>>> In some edge cases a minimal stack requirement is calculated higher
>>>>>> than actual stack size specified by ThreadStackSize parameter causing VM to
>>>>>> abort unless stack size is overwritten via -Xss option.
>>>>>>
>>>>>> A patch currently being suggested adjusts amount of guard pages to a
>>>>>> single memory page each along with minimal stack size when memory page size
>>>>>> exceed 8KB unless explicitly overwritten in command line.
>>>>>>
>>>>>> Currently we are aware of the problem on some Linux platforms,
>>>>>> therefore the change is specific to that OS only (Solaris carries a similar
>>>>>> approach already).
>>>>>>
>>>>>> Shall the description string of StackRedPage, StackYellowPages and
>>>>>> StackShadow pages be modified to reflect the values could be scaled down? If
>>>>>> so the comment needs to indicate the change affects Linux and Solaris only.
>>>>>> Any comments welcome here.
>>>>>>
>>>>>> Thanks,
>>>>>> Vlad
>>