RFR(M) : 7104565 : trim jprt build targets

Vladimir Kozlov vladimir.kozlov at oracle.com
Tue Apr 9 16:26:23 PDT 2013


Perfect!

Lets wait one day for other reviewers to look if they want. And we will 
push it tomorrow.

Thanks,
Vladimir

On 4/9/13 4:01 PM, David Chase wrote:
>
> On 2013-04-09, at 5:26 PM, Vladimir Kozlov <vladimir.kozlov at oracle.com> wrote:
>> One note: in frame_sparc.cpp remove 'jvmg' in the line you modified since we will not build jvmg.
>
> done
>
>> And question: did you use mercurial commands to remove and rename jvm.make and debug.make? We need to use hg commands to preserve changes history for jvmg.make (it has more changesets then old debug.make).
>>
>> I just want to confirm because sometimes webrev may not show correctly what was done to sources. I mean you need to do:
>>
>> hg remove debug.make
>> hg rename jvmg.make debug.make
>>
>> and then edit debug.make
>
> To be sure:
>
> 10009  hg revert make/{solaris,bsd,linux}/makefiles/jvmg.make
> 10010  zip -9 ../safemakes.zip make/{solaris,bsd,linux}/makefiles/debug.make
> 10011  hg revert make/{solaris,bsd,linux}/makefiles/debug.make
> 10012  hg remove make/{solaris,bsd,linux}/makefiles/debug.make
> 10013  for i in solaris bsd linux ; do hg rename make/$i/makefiles/{jvmg,debug}.make; done
> 10014  unzip -l ../safemakes.zip
> 10015  unzip ../safemakes.zip
>
> And the new-and-improved diffs:
>
> http://cr.openjdk.java.net/~drchase/7104565/webrev.06-new/
>
>


More information about the hotspot-dev mailing list