Review request: 6729929 I18N - Taking Heap Dump failed if project path contains multibyte characters

[Peter Allwin]

Great, thanks a lot guys!

/peter
On 4/19/2013 7:02 AM, Rickard Bäckman wrote:
> Peter,
>
> it looks good to me.
>
> /R
>
> On Apr 19, 2013, at 4:19 AM, David Holmes wrote:
>
>> Hi Peter,
>>
>> On 19/04/2013 12:10 AM, Peter Allwin wrote:
>>> Hi all, I'm still looking for reviews for this change...
>> Sounds like a perfectly reasonable change.
>>
>> Reviewed.
>>
>> Thanks,
>> David
>>
>>> Thanks!
>>>
>>> /peter
>>>
>>> On 4/3/2013 6:16 PM, Peter Allwin wrote:
>>>> Webrev: http://cr.openjdk.java.net/~mgronlun/6729929/webrev01/
>>>> <http://cr.openjdk.java.net/%7Emgronlun/6729929/webrev01/>
>>>> Bug: http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=6729929
>>>>
>>>> Summary: When dumpHeap in the HotSpotDiagnostic JMX MBean is called,
>>>> the filename parameter must be converted from jstring to char* to be
>>>> used in open(). This was done using UTF-8 encoding which is incorrect
>>>> as open() expects a platform dependent encoding according to the
>>>> system locale. Fix is to use
>>>> java_lang_String::as_platform_dependent_str to do the conversion.
>>>>
>>>> Thanks to Markus for advising and hosting the webrev!
>>>>
>>>> Regards,
>>>>
>>>> /peter