Make zero compile after 8016131 and 8016697

Christian Thalinger christian.thalinger at oracle.com
Mon Aug 5 20:00:02 PDT 2013


On Aug 4, 2013, at 4:57 PM, David Holmes <david.holmes at oracle.com> wrote:

> Hi Omair,
> 
> On 5/08/2013 5:26 AM, Omair Majid wrote:
>> Hi,
>> 
>> The following webrev makes zero compile again:
>> http://cr.openjdk.java.net/~omajid/webrevs/zero-build-broken/00/
>> 
>> The changes in the werbrev mirror the changes made in the following
>> changesets:
>> 
>> changeset:   4983:e619a2766bcc
>> user:        rbackman
>> date:        Wed Jun 12 11:17:39 2013 +0200
>> summary:     8016131: nsk/sysdict/vm/stress/chain tests crash the VM in
>> 'entry_frame_is_first()'
>> 
>> changeset:   4961:980532a806a5
>> user:        goetz
>> date:        Thu Jun 20 15:02:05 2013 +0200
>> summary:     8016697: Use stubs to implement safefetch
>> 
>> I am not sure what the best tree to use is. I made the webrev against
>> hsx/hotspot-rt, but it applies to hsx/hotspot-main without any changes too.
> 
> hotspot-rt is fine. It must be one of the group repos so hotspot-main is out.
> 
> I've filed 8022188 for this and will sponsor it for you.
> 
>> Any concerns with the patch?
> 
> Nope. Reviewed.
> 
> We need a second Reviewer before the push.

Looks good.  -- Chris

> 
> Cheers,
> David
> -----
> 
>> 
>> Thanks,
>> Omair
>> 



More information about the hotspot-dev mailing list