Review request (hs24): 8007074: SIGSEGV at ParMarkBitMap::verify_clear()
Thomas Schatzl
thomas.schatzl at oracle.com
Fri Aug 23 03:32:31 PDT 2013
Hi Stefan,
On Thu, 2013-08-22 at 13:22 +0200, Stefan Karlsson wrote:
> http://cr.openjdk.java.net/~stefank/8007074/webrev.01/
>
> Hi all,
>
> The original patch didn't make it in time for the hs24 release. So,
> please review this patch that's now based on hs25 (JDK8) instead of hs24.
>
> The main difference between the two patches is the heap setup code,
> which is different because of the permgen removal.
Still looks good.
Minor nit:
Why is there a difference to the hsx24 patch of the text in the assert
at the end of Universe::preferred_heap_base()? I.e. "" instead of "Must
be"?
Thanks,
Thomas
More information about the hotspot-dev
mailing list