Review request (hs24): 8007074: SIGSEGV at ParMarkBitMap::verify_clear()

Stefan Karlsson stefan.karlsson at oracle.com
Fri Aug 23 03:47:46 PDT 2013


On 2013-08-23 12:32, Thomas Schatzl wrote:
> Hi Stefan,
>
> On Thu, 2013-08-22 at 13:22 +0200, Stefan Karlsson wrote:
>> http://cr.openjdk.java.net/~stefank/8007074/webrev.01/
>>
>> Hi all,
>>
>> The original patch didn't make it in time for the hs24 release. So,
>> please review this patch that's now based on hs25 (JDK8) instead of hs24.
>>
>> The main difference between the two patches is the heap setup code,
>> which is different because of the permgen removal.
> Still looks good.

Thanks!

>
> Minor nit:
> Why is there a difference to the hsx24 patch of the text in the assert
> at the end of Universe::preferred_heap_base()? I.e. "" instead of "Must
> be"?

I'll fix it.

thanks,
StefanK
>
> Thanks,
>    Thomas
>
>



More information about the hotspot-dev mailing list