RFR 8023900 [TESTBUG] Initial compact profile test groups need adjusting

Daniel D. Daugherty daniel.daugherty at oracle.com
Wed Aug 28 07:15:49 PDT 2013


Thumbs up.

Dan


On 8/28/13 5:01 AM, David Holmes wrote:
> webrev: http://cr.openjdk.java.net/~dholmes/8023900/webrev/
>
> I discovered while working on the JDK test group definitions taht the 
> initial groups defined under 8006164 didn't quite aggregate the 
> primary groups in the right way. The following changes are needed:
>
> diff -r 7aa0c1fb6fdb test/TEST.groups
> --- a/test/TEST.groups
> +++ b/test/TEST.groups
> @@ -131,6 +131,7 @@
>  # Compact 2 adds full VM tests
>  compact2 = \
>    :compact2_minimal \
> + :compact1 \
>    :needs_full_vm_compact2 \
>   -:needs_compact3 \
>   -:needs_jre \
> @@ -165,6 +166,7 @@
>  compact2_minimal = \
>    :compact1_minimal \
>    :needs_compact2 \
> + -:needs_full_vm_compact2 \
>   -:needs_compact3 \
>   -:needs_jre \
>   -:needs_jdk
>
> Because of the minimal groups there is a fork in the dependency tree - 
> so compact2 has to combine with compact1 to ensure it picks up the 
> compact1 tests that require a full VM. And compact2_minimal has to 
> explicitly exclude needs_full_vm_compact2 otherwise it can pull in 
> full VM tests from the needs_compact2 group.
>
> Thanks,
> David



More information about the hotspot-dev mailing list