JDK 9 RFR and sponsorship of JDK-8030656 Bad version check for parameter information in src/share/vm/classfile/javaClasses.cpp

[Christian Thalinger]

On Dec 18, 2013, at 10:33 AM, Joe Darcy <joe.darcy at oracle.com> wrote:

> Hello,
> 
> During the course of trying to increment the JDK_MINOR_VERSION from 8 to 9 in the JDK 9 forest, a HotSpot bug has discovered:
> 
>        JDK-8030656 Bad version check for parameter information in src/share/vm/classfile/javaClasses.cpp
> 
> Fortunately, the fix is very simple:
> 
> --- a/src/share/vm/classfile/javaClasses.cpp    Fri Dec 13 09:35:12 2013 -0800
> +++ b/src/share/vm/classfile/javaClasses.cpp    Wed Dec 18 10:30:02 2013 -0800
> @@ -3286,7 +3286,7 @@
>     sun_reflect_ConstantPool::compute_offsets();
>     sun_reflect_UnsafeStaticFieldAccessorImpl::compute_offsets();
>   }
> -  if (JDK_Version::is_jdk18x_version())
> +  if (JDK_Version::is_gte_jdk18x_version())

Shouldn’t code like this be removed at all now that HSX is dead?

>     java_lang_reflect_Parameter::compute_offsets();
> 
>   // generated interpreter code wants to know about the offsets we just computed:
> 
> With this patch, the java.lang.reflect.Parameter related tests that fail in the jdk and langtools repos pass.
> 
> I'm requesting review of and sponsorship of this fix for JDK 9.
> 
> Thanks,
> 
> -Joe