JDK 9 RFR and sponsorship of JDK-8030656 Bad version check for parameter information in src/share/vm/classfile/javaClasses.cpp

[Eric McCorkle]

I can push the change for you; I'm a committer.

On 12/18/13 14:20, Joe Darcy wrote:
> On 12/18/2013 11:12 AM, Christian Thalinger wrote:
>> On Dec 18, 2013, at 10:33 AM, Joe Darcy <joe.darcy at oracle.com> wrote:
>>
>>> Hello,
>>>
>>> During the course of trying to increment the JDK_MINOR_VERSION from 8
>>> to 9 in the JDK 9 forest, a HotSpot bug has discovered:
>>>
>>>         JDK-8030656 Bad version check for parameter information in
>>> src/share/vm/classfile/javaClasses.cpp
>>>
>>> Fortunately, the fix is very simple:
>>>
>>> --- a/src/share/vm/classfile/javaClasses.cpp    Fri Dec 13 09:35:12
>>> 2013 -0800
>>> +++ b/src/share/vm/classfile/javaClasses.cpp    Wed Dec 18 10:30:02
>>> 2013 -0800
>>> @@ -3286,7 +3286,7 @@
>>>      sun_reflect_ConstantPool::compute_offsets();
>>>      sun_reflect_UnsafeStaticFieldAccessorImpl::compute_offsets();
>>>    }
>>> -  if (JDK_Version::is_jdk18x_version())
>>> +  if (JDK_Version::is_gte_jdk18x_version())
>> Shouldn’t code like this be removed at all now that HSX is dead?
>>
>>
> 
> There are other checks of that flavor in the same file. For my purposes,
> I just want to get the feature working again when the JDK_MINOR_VERSION
> is updated.
> 
> -Joe
>