RFR: JDK-8030796: Update hotspot jprt.properties to release jdk9
Coleen Phillimore
coleen.phillimore at oracle.com
Mon Dec 30 14:43:14 PST 2013
Erik,
I'm confused by this - since hsx is no longer supported, can you just
change jdk8 to jdk9 and delete the other releases from this file? Do
you need a sponsor?
thanks,
Coleen
On 12/19/2013 12:26 PM, Tim Bell wrote:
> Hi Erik:
>
>> So for the hotspot change, please consider this a new review.
>>
>> Bug: https://bugs.openjdk.java.net/browse/JDK-8030796
>> Webrev: http://cr.openjdk.java.net/~erikj/8030793/webrev.01/
>
> Looks good to me.
>
> /Tim
>
>> On 2013-12-19 14:09, Erik Joelsson wrote:
>>> Thanks for the review,
>>>
>>> Since the root repo part of this change is quite urgent, I split out
>>> a new bug for the Hotspot part, which also might warrant more
>>> discussion.
>>>
>>> /Erik
>>>
>>> On 2013-12-19 13:51, Chris Hegarty wrote:
>>>> Looks good to me. Thanks Eric.
>>>>
>>>> -Chris.
>>>>
>>>> On 19 Dec 2013, at 12:30, Erik Joelsson <erik.joelsson at oracle.com>
>>>> wrote:
>>>>
>>>>> Please review these changes to make/jprt.poperties and
>>>>> hotspot/make/jprt.properties. I've just added a jdk9 configuration
>>>>> to JPRT and this change is needed for JDK 9 to start using it.
>>>>> This will solve the issue of requiring a jdk8 boot when building
>>>>> in JPRT.
>>>>>
>>>>> In the hotspot version of the file, there is a lot of separate
>>>>> configuration for jdk7 and jdk8. I didn't dare touch this now and
>>>>> opted to just add the jdk9 version of these variables. I would
>>>>> guess that this won't be necessary however since hotspot won't be
>>>>> delivered to multiple jdk releases anymore?
>>>>>
>>>>> Webrev: http://cr.openjdk.java.net/~erikj/8030793/webrev.01/
>>>>> Bug: https://bugs.openjdk.java.net/browse/JDK-8030793
>>>>>
>>>>> I'm still unclear on where the hotspot change needs to go and if I
>>>>> need a separate bug for it? My interpretation is that the root
>>>>> repo change should go to jdk9/dev and the hotspot change to
>>>>> jdk9/hs-rt and that since these changes are using separate routes,
>>>>> a separate bug should be used. I also assume that as a jdk9
>>>>> reviewer, I will be able to push this myself (after review) to the
>>>>> hotspot repo.
>>>>>
>>>>> /Erik
>>>
>>
>
More information about the hotspot-dev
mailing list