RFR (XXS) CR 8006997: ContendedPaddingWidth should be uintx

[David Holmes]

Aleksey,

On 28/01/2013 10:02 PM, Aleksey Shipilev wrote:
> Hi guys,
>
> This is the tiny correction it would be nice to have:
>    http://cr.openjdk.java.net/~shade/8006997/
>
> Negative values make no sense (and also can ruin the classloading with
> the fields overlapping each other), so it would better to be uintx. I
> would need a sponsor to push this.

You also need to change all the expressions using this value to use 
unsigned types and update all the printfs to use an unsigned format 
specifier.

David
-----

  > grepsrc.sh ContendedPaddingWidth
./share/vm/classfile/classFileParser.cpp:    int pad_size = 
ContendedPaddingWidth;
./cpu/sparc/vm/vm_version_sparc.cpp:  if 
(FLAG_IS_DEFAULT(ContendedPaddingWidth) &&
./cpu/sparc/vm/vm_version_sparc.cpp:    (cache_line_size > 
ContendedPaddingWidth))
./cpu/sparc/vm/vm_version_sparc.cpp:    ContendedPaddingWidth = 
cache_line_size;
./cpu/sparc/vm/vm_version_sparc.cpp:    if (ContendedPaddingWidth > 0) {
./cpu/sparc/vm/vm_version_sparc.cpp: 
tty->print_cr("ContendedPaddingWidth %d", ContendedPaddingWidth);
./cpu/x86/vm/vm_version_x86.cpp:  if 
(FLAG_IS_DEFAULT(ContendedPaddingWidth) &&
./cpu/x86/vm/vm_version_x86.cpp:     (cache_line_size > 
ContendedPaddingWidth))
./cpu/x86/vm/vm_version_x86.cpp:     ContendedPaddingWidth = 
cache_line_size;
./cpu/x86/vm/vm_version_x86.cpp:    if (ContendedPaddingWidth > 0) {
./cpu/x86/vm/vm_version_x86.cpp: 
tty->print_cr("ContendedPaddingWidth %d", ContendedPaddingWidth);