Review request: 8006878 Some non-existent GC source files are in the minimalVM exclude list

Joe Provino joseph.provino at oracle.com
Wed Feb 6 06:23:56 PST 2013



On 1/31/2013 3:25 AM, David Holmes wrote:
> Joe,
>
> On 26/01/2013 2:28 AM, Joe Provino wrote:
>> 2 ffiles changed.
>>
>> Webrev is here: http://cr.openjdk.java.net/~jprovino/8006878/webrev.00
>
> This seems to mix fixes for two different issues. The removal of the 
> INCLUDE_ALL_GC guard would seem to indicate there is a problem if not 
> building all GCs ie with the minimal VM - is that the case?

David, sorry, I don't know how I'm managing to miss responses.

I think the problem in excludeSrc.make excluding the non-existent file 
"yieldWorkingGroup.cpp"
instead of the correct file "yieldingWorkGroup.cpp" meant that 
yieldingWorkGroup.cpp
wasn't being excluded and didn't compile so I put in the guard to fix it.

However, that being said, I tried not removing yieldingWorkGroup.cpp 
when INCLUDE_ALL_GCS is 0 and it compiled.  So if there was a problem it 
doesn't appear
to be a problem any more.

joe
>
> David
>
>> joe


More information about the hotspot-dev mailing list