RFR (XXS) CR 8006997: ContendedPaddingWidth should be uintx
Vladimir Kozlov
vladimir.kozlov at oracle.com
Fri Feb 8 11:35:23 PST 2013
The final fix is good.
Thanks,
Vladimir
On 2/8/13 8:45 AM, Aleksey Shipilev wrote:
> On 02/08/2013 05:30 PM, Aleksey Shipilev wrote:
>> On 02/08/2013 05:22 PM, David Holmes wrote:
>>> On 8/02/2013 8:39 PM, Aleksey Shipilev wrote:
>>>> Ok then. This is the new webrev:
>>>> http://cr.openjdk.java.net/~shade/8006997/webrev.01/
>>>>
>>>> I haven't found another good place to stick the guarantee() to, so opted
>>>> to stick it before the actual use. I would be happy to stick it
>>>> somewhere else where the options are generally checked, but found no
>>>> non-platform/non-OS specific location.
>>>
>>> arguments.cpp - Arguments::parse_each_vm_init_arg - see
>>> -XX:MaxDirectMemorySize as an example.
>>
>> Ok, great, thanks! I will update the webrev and give it another jprt spin.
>
> Here's the update:
> http://cr.openjdk.java.net/~shade/8006997/webrev.02/
>
> Testing:
> a) ad-hoc fastdebug build with negative value
> b) JPRT/Hotspot full cycle
>
> -Aleksey.
>
More information about the hotspot-dev
mailing list